)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When implementing this spec two critical problems were found:"},{"line_number":10,"context_line":"* PXEBoot.validate requires instance image parameters, so we cannot"},{"line_number":11,"context_line":"  use it during inspection."},{"line_number":12,"context_line":"* PXEBoot.prepare_ramdisk tries to configure DHCP/PXE environment,"},{"line_number":13,"context_line":"  which clashes with inspector\u0027s one and requires VIFs to be present."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_7fafb8e2","line":11,"updated":"2018-08-22 19:27:15.000000000","message":"So validate can be state aware... just a thought.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":10,"context_line":"* PXEBoot.validate requires instance image parameters, so we cannot"},{"line_number":11,"context_line":"  use it during inspection."},{"line_number":12,"context_line":"* PXEBoot.prepare_ramdisk tries to configure DHCP/PXE environment,"},{"line_number":13,"context_line":"  which clashes with inspector\u0027s one and requires VIFs to be present."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additionally, non-obvious heuristic was used to determine which part"},{"line_number":16,"context_line":"should handle boot mode. Ideally, an operator should have a say in it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_df7fec63","line":13,"updated":"2018-08-22 19:27:15.000000000","message":"Hmm... True. But wouldn\u0027t it make sense to address the vif requirement?","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  which clashes with inspector\u0027s one and requires VIFs to be present."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additionally, non-obvious heuristic was used to determine which part"},{"line_number":16,"context_line":"should handle boot mode. Ideally, an operator should have a say in it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This amendment:"},{"line_number":19,"context_line":"* Introduces BootInterface.validate_inspect similar to validate_rescue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_ff60a8a7","line":16,"updated":"2018-08-22 19:27:15.000000000","message":"++","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":16,"context_line":"should handle boot mode. Ideally, an operator should have a say in it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This amendment:"},{"line_number":19,"context_line":"* Introduces BootInterface.validate_inspect similar to validate_rescue."},{"line_number":20,"context_line":"  Modifies PXEBoot.prepare_ramdisk to not configure DHCP for inspection."},{"line_number":21,"context_line":"* Creates a new \"in-band\" inspect interface instead of changing the"},{"line_number":22,"context_line":"  exising \"inspector\". This allow using the standard options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_ffe98819","line":19,"range":{"start_line":19,"start_character":55,"end_line":19,"end_character":70},"updated":"2018-08-22 19:27:15.000000000","message":"I really wish we didn\u0027t do this. :(","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"}],"specs/approved/inspector-boot-management.rst":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0171874cc4b63e6bcdcf13082c39dfbadba09c7e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      interface. The kernel arguments will come from the new ``driver_info``"},{"line_number":91,"context_line":"      and configuration parameters described below."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"   #. The ``inspect`` method will call the **ironic-inspector** API with"},{"line_number":94,"context_line":"      ``manage_boot\u003dFalse``."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   .. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_df2af0e5","line":93,"range":{"start_line":93,"start_character":12,"end_line":93,"end_character":19},"updated":"2018-08-07 02:50:19.000000000","message":"It\u0027s ``inspect_hardware`` I think, or are we going to add a new method to InspectInterface?","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1161475dea97494567bb4756e52f3076a0c412a3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      interface. The kernel arguments will come from the new ``driver_info``"},{"line_number":91,"context_line":"      and configuration parameters described below."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"   #. The ``inspect`` method will call the **ironic-inspector** API with"},{"line_number":94,"context_line":"      ``manage_boot\u003dFalse``."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   .. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a7e7ad12","line":93,"range":{"start_line":93,"start_character":12,"end_line":93,"end_character":19},"in_reply_to":"3f79a3b5_df2af0e5","updated":"2018-08-09 11:14:01.000000000","message":"No, I just forgot the right name.","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0171874cc4b63e6bcdcf13082c39dfbadba09c7e","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"   #. Update ``prepare_ramdisk`` to not configure DHCP for nodes in"},{"line_number":113,"context_line":"      ``INSPECTING`` state."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Alternatives"},{"line_number":116,"context_line":"------------"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_df05107c","line":114,"updated":"2018-08-07 02:50:19.000000000","message":"AIUI we also need to update _build_pxe_config_options and template for the the kernel_params/inspector_kernel_params.\n\nIf we don\u0027t have port mac address before inspection, how would ironic creates pxe option file for each node? I suppose we creating a default option file for inspection, but that doesn\u0027t work for per-node setting like inspector_kernel_params, right?","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1161475dea97494567bb4756e52f3076a0c412a3","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"   #. Update ``prepare_ramdisk`` to not configure DHCP for nodes in"},{"line_number":113,"context_line":"      ``INSPECTING`` state."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Alternatives"},{"line_number":116,"context_line":"------------"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e7b605fb","line":114,"in_reply_to":"3f79a3b5_df05107c","updated":"2018-08-09 11:14:01.000000000","message":"In this version of the spec we do not control DHCP or PXE. Which, of course, leaves the rightful question: why do we use the boot interface instead of e.g. the management one? I\u0027ll think about it.","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0171874cc4b63e6bcdcf13082c39dfbadba09c7e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  may rely on passing additional kernel arguments (e.g. for collectors)."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Make in-band inspection first-class citizen in ironic similarly to cleaning"},{"line_number":129,"context_line":"  and rescue: add ``inspect_network`` and create ports in Neutron for it."},{"line_number":130,"context_line":"  This will require (potentially extensive) modifications of the networking"},{"line_number":131,"context_line":"  interfaces, particularly, around VIFs."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_0d4cc59c","line":129,"range":{"start_line":129,"start_character":42,"end_line":129,"end_character":54},"updated":"2018-08-07 02:50:19.000000000","message":"we may not have port information before inspection, so i don\u0027t think it works..","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1161475dea97494567bb4756e52f3076a0c412a3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  may rely on passing additional kernel arguments (e.g. for collectors)."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Make in-band inspection first-class citizen in ironic similarly to cleaning"},{"line_number":129,"context_line":"  and rescue: add ``inspect_network`` and create ports in Neutron for it."},{"line_number":130,"context_line":"  This will require (potentially extensive) modifications of the networking"},{"line_number":131,"context_line":"  interfaces, particularly, around VIFs."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c7cbc96f","line":129,"range":{"start_line":129,"start_character":42,"end_line":129,"end_character":54},"in_reply_to":"3f79a3b5_0d4cc59c","updated":"2018-08-09 11:14:01.000000000","message":"Well, this spec assumes we do have ports.","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0171874cc4b63e6bcdcf13082c39dfbadba09c7e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"#. Add ``validate_inspect`` to the base `BootInterface` and implement it from"},{"line_number":254,"context_line":"   `PXEBoot`."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Add new ``in-band`` inspect interface (probably inheriting from the existing"},{"line_number":257,"context_line":"   ``inspector`` one)."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Dependencies"},{"line_number":260,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_bfa3744f","line":257,"range":{"start_line":256,"start_character":42,"end_line":257,"end_character":20},"updated":"2018-08-07 02:50:19.000000000","message":"i have a feeling, the in-band is introduced mainly because of upgrades compatibility, inspector interface (which may be removed in the future) would not be a good choice as base class.\n\noneview inspect is inheriting from inspector, but will be removed in Stein..","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1161475dea97494567bb4756e52f3076a0c412a3","unresolved":false,"context_lines":[{"line_number":253,"context_line":"#. Add ``validate_inspect`` to the base `BootInterface` and implement it from"},{"line_number":254,"context_line":"   `PXEBoot`."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Add new ``in-band`` inspect interface (probably inheriting from the existing"},{"line_number":257,"context_line":"   ``inspector`` one)."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Dependencies"},{"line_number":260,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a7956d42","line":257,"range":{"start_line":256,"start_character":42,"end_line":257,"end_character":20},"in_reply_to":"3f79a3b5_bfa3744f","updated":"2018-08-09 11:14:01.000000000","message":"We don\u0027t have plans to remove the inspector one in the near future, since it\u0027s still used when MACs are not known.","commit_id":"bddaeb4c8cdd6c0ce2396526d90eeb8eedff3bd6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab53d30341dd7b51ac7becd7f78b674122fdc765","unresolved":false,"context_lines":[{"line_number":21,"context_line":"be added to in-band inspection. It is also the first step in our long term"},{"line_number":22,"context_line":"(tentative) plans to separate discover and data processing parts of"},{"line_number":23,"context_line":"**ironic-inspector**, moving the latter to **ironic**."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_b2d8f0ee","line":24,"updated":"2018-08-14 08:00:54.000000000","message":"I have a feeling, this spec wants to support the in-band inspection of virtual media boot, while tries to provide a general way in consideration of regular PXE boot, but the latter part is not covered in this spec and seems obscure to readers.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":21,"context_line":"be added to in-band inspection. It is also the first step in our long term"},{"line_number":22,"context_line":"(tentative) plans to separate discover and data processing parts of"},{"line_number":23,"context_line":"**ironic-inspector**, moving the latter to **ironic**."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_dfde0c3d","line":24,"in_reply_to":"3f79a3b5_b2d8f0ee","updated":"2018-08-22 19:27:15.000000000","message":"I feel like we\u0027re attempting to scope creep the original idea.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab53d30341dd7b51ac7becd7f78b674122fdc765","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Allow **ironic** to negotiate which side (**ironic** or **ironic-inspector**)"},{"line_number":29,"context_line":"will manage the boot for each inspection. The DHCP will still be"},{"line_number":30,"context_line":"unconditionally provided by **ironic-inspector**, changing it is out of scope"},{"line_number":31,"context_line":"of this spec (see Alternatives_)."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_d2ca4c9f","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":50},"updated":"2018-08-14 08:00:54.000000000","message":"It\u0027s DHCP/PXE if I get it right.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Allow **ironic** to negotiate which side (**ironic** or **ironic-inspector**)"},{"line_number":29,"context_line":"will manage the boot for each inspection. The DHCP will still be"},{"line_number":30,"context_line":"unconditionally provided by **ironic-inspector**, changing it is out of scope"},{"line_number":31,"context_line":"of this spec (see Alternatives_)."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_7fd01820","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":50},"in_reply_to":"3f79a3b5_d2ca4c9f","updated":"2018-08-22 19:27:15.000000000","message":"We might be able to get DHCP/HTTP in soon without really any headaches or additional complication.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Allow **ironic** to negotiate which side (**ironic** or **ironic-inspector**)"},{"line_number":29,"context_line":"will manage the boot for each inspection. The DHCP will still be"},{"line_number":30,"context_line":"unconditionally provided by **ironic-inspector**, changing it is out of scope"},{"line_number":31,"context_line":"of this spec (see Alternatives_)."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This will be achieved by creating a new ``in-band`` inspect interface"},{"line_number":34,"context_line":"implementation. Unlike the existing ``inspector`` implementation, the new one"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_dfaccca0","line":31,"range":{"start_line":29,"start_character":64,"end_line":31,"end_character":33},"updated":"2018-08-22 19:27:15.000000000","message":"Wouldn\u0027t it be better to just state that DHCP management is out of scope of this spec entirely?","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":30,"context_line":"unconditionally provided by **ironic-inspector**, changing it is out of scope"},{"line_number":31,"context_line":"of this spec (see Alternatives_)."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This will be achieved by creating a new ``in-band`` inspect interface"},{"line_number":34,"context_line":"implementation. Unlike the existing ``inspector`` implementation, the new one"},{"line_number":35,"context_line":"will expect the required boot information (things like ``deploy_kernel`` or"},{"line_number":36,"context_line":"``deploy_iso``) to be present."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_7fdb38ec","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":15},"updated":"2018-08-22 19:27:15.000000000","message":"How will creating a new interface help us? It feels like we\u0027re trying to take that path to avoid some conditional logic around dhcp addresses, but that doesn\u0027t really make sense to me as the interface will take much more substrate and work to implement. Maybe we should get on a call and talk through this.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab53d30341dd7b51ac7becd7f78b674122fdc765","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This will be achieved by creating a new ``in-band`` inspect interface"},{"line_number":34,"context_line":"implementation. Unlike the existing ``inspector`` implementation, the new one"},{"line_number":35,"context_line":"will expect the required boot information (things like ``deploy_kernel`` or"},{"line_number":36,"context_line":"``deploy_iso``) to be present."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The existing ``inspector`` interfaces works as follows:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_32c2a05a","line":35,"range":{"start_line":35,"start_character":57,"end_line":35,"end_character":70},"updated":"2018-08-14 08:00:54.000000000","message":"I\u0027m not familiar with virtual media boot, is this something required? From ilo and irmc, it seems only [vendor]_deploy_iso is required.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":33,"context_line":"This will be achieved by creating a new ``in-band`` inspect interface"},{"line_number":34,"context_line":"implementation. Unlike the existing ``inspector`` implementation, the new one"},{"line_number":35,"context_line":"will expect the required boot information (things like ``deploy_kernel`` or"},{"line_number":36,"context_line":"``deploy_iso``) to be present."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The existing ``inspector`` interfaces works as follows:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_7fa3389f","line":36,"updated":"2018-08-22 19:27:15.000000000","message":"vendor_deploy_iso?","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab53d30341dd7b51ac7becd7f78b674122fdc765","unresolved":false,"context_lines":[{"line_number":35,"context_line":"will expect the required boot information (things like ``deploy_kernel`` or"},{"line_number":36,"context_line":"``deploy_iso``) to be present."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The existing ``inspector`` interfaces works as follows:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#. **ironic**:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_48dea811","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":37},"updated":"2018-08-14 08:00:54.000000000","message":"nit: interface","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fd725149d87ffc49d802bf74ac13d68c5c11fa66","unresolved":false,"context_lines":[{"line_number":139,"context_line":"   #. The ``validate`` method of the new interface will call the"},{"line_number":140,"context_line":"      ``validate_inspect`` method of the node\u0027s boot interface."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   #. The ``inspect_hardware`` method will call ``prepare_ramdisk`` of"},{"line_number":143,"context_line":"      the node\u0027s boot interface."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_acc38237","line":142,"range":{"start_line":142,"start_character":48,"end_line":142,"end_character":67},"updated":"2018-08-16 10:20:58.000000000","message":"This would also need to pass the \u0027ipa-inspection-callback-url\u0027 as command line argument while creating pxe config file. Will we need new label/menuentry \u0027introspect\u0027 in the pxe config template to be used during \u0027in-band\u0027 inspection?","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ccc6743c8aa6aa48fc53b1fdfee156b715031220","unresolved":false,"context_lines":[{"line_number":139,"context_line":"   #. The ``validate`` method of the new interface will call the"},{"line_number":140,"context_line":"      ``validate_inspect`` method of the node\u0027s boot interface."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   #. The ``inspect_hardware`` method will call ``prepare_ramdisk`` of"},{"line_number":143,"context_line":"      the node\u0027s boot interface."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_60a9d08e","line":142,"range":{"start_line":142,"start_character":48,"end_line":142,"end_character":67},"in_reply_to":"3f79a3b5_06c11c2f","updated":"2018-08-17 07:56:03.000000000","message":"Yes, this is the proposed work, to call boot.prepare_ramdisk from the inspect_hardware of in-band interface AIUI.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1154972641db935150d9f0a0ea7e84172bd997cd","unresolved":false,"context_lines":[{"line_number":139,"context_line":"   #. The ``validate`` method of the new interface will call the"},{"line_number":140,"context_line":"      ``validate_inspect`` method of the node\u0027s boot interface."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   #. The ``inspect_hardware`` method will call ``prepare_ramdisk`` of"},{"line_number":143,"context_line":"      the node\u0027s boot interface."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_fb17d144","line":142,"range":{"start_line":142,"start_character":48,"end_line":142,"end_character":67},"in_reply_to":"3f79a3b5_60a9d08e","updated":"2018-08-17 08:16:13.000000000","message":"Ok. In case of PXE, passing the params would be handled by Inspector, but in case of vmedia it would be done through Ironic. When we need to add any new command line arguments for Inspection, we would need to do changes in both Ironic and Inspector. May be it would be useful to capture that here.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3c1fcb240eb074aabf268b7bdc856e1cd6adb6a3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"   #. The ``validate`` method of the new interface will call the"},{"line_number":140,"context_line":"      ``validate_inspect`` method of the node\u0027s boot interface."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   #. The ``inspect_hardware`` method will call ``prepare_ramdisk`` of"},{"line_number":143,"context_line":"      the node\u0027s boot interface."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_f45a984e","line":142,"range":{"start_line":142,"start_character":48,"end_line":142,"end_character":67},"in_reply_to":"3f79a3b5_acc38237","updated":"2018-08-16 15:07:15.000000000","message":"We\u0027re not going to configure DHCP, so kernel parameters will still come from inspector\u0027s own DHCP. No need to change the PXE config.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f9558066a5798da72abf879067e3a12c67d3a2cc","unresolved":false,"context_lines":[{"line_number":139,"context_line":"   #. The ``validate`` method of the new interface will call the"},{"line_number":140,"context_line":"      ``validate_inspect`` method of the node\u0027s boot interface."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   #. The ``inspect_hardware`` method will call ``prepare_ramdisk`` of"},{"line_number":143,"context_line":"      the node\u0027s boot interface."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_06c11c2f","line":142,"range":{"start_line":142,"start_character":48,"end_line":142,"end_character":67},"in_reply_to":"3f79a3b5_f45a984e","updated":"2018-08-17 04:13:45.000000000","message":"How will this work in case of virtual media boot device? Will Inspector cerate the virtual flopppy image with necessary parameters that would be consumed by IPA? If so, how would Inspector insert that media into BMC?","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":139,"context_line":"   #. The ``validate`` method of the new interface will call the"},{"line_number":140,"context_line":"      ``validate_inspect`` method of the node\u0027s boot interface."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   #. The ``inspect_hardware`` method will call ``prepare_ramdisk`` of"},{"line_number":143,"context_line":"      the node\u0027s boot interface."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_bfe310d8","line":142,"range":{"start_line":142,"start_character":48,"end_line":142,"end_character":67},"in_reply_to":"3f79a3b5_fb17d144","updated":"2018-08-22 19:27:15.000000000","message":"I concur, it would be good to capture because that is an easy detail to forget.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab53d30341dd7b51ac7becd7f78b674122fdc765","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   #. The ``inspect_hardware`` method will call the **ironic-inspector** API"},{"line_number":146,"context_line":"      with ``manage_boot\u003dFalse``."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   #. After **ironic-inspector** reports success, reboot the node via its power"},{"line_number":149,"context_line":"      interface."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   .. note::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_28ec8c8d","line":148,"range":{"start_line":148,"start_character":6,"end_line":148,"end_character":48},"updated":"2018-08-14 08:00:54.000000000","message":"Normally I feel it\u0027s unsafe to do so, because the firewall configuration is executed asynchronously.\n\nBut I guess this has no impact on virtual media boot, because it doesn\u0027t need a PXE environment at all.","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75e904984be96dc1864d6d7603dccaba929fd251","unresolved":false,"context_lines":[{"line_number":175,"context_line":"* Make in-band inspection first-class citizen in ironic similarly to cleaning"},{"line_number":176,"context_line":"  and rescue: add ``inspect_network`` and create ports in Neutron for it."},{"line_number":177,"context_line":"  This will require (potentially extensive) modifications of the networking"},{"line_number":178,"context_line":"  interfaces, particularly, around VIFs."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Data model impact"},{"line_number":181,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ff7988fb","line":178,"updated":"2018-08-22 19:27:15.000000000","message":"This last alternative doesn\u0027t seem like one to me given the model, complexity, and headaches this could create. :(","commit_id":"3065bcd40cc237bd47a05bf77d0d9a2ee4393018"}]}