)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christopher Dearborn \u003cChristopher.Dearborn@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-04 16:54:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added firmware update spec for Dell hardware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I833f8c068849ed82c338a4c1d9c929c379b9624c"},{"line_number":10,"context_line":"Story: 2003494"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_5bfc020c","line":7,"updated":"2018-10-15 20:07:47.000000000","message":"Please replace \u0027Dell\u0027 with \u0027Dell EMC\u0027.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christopher Dearborn \u003cChristopher.Dearborn@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-04 16:54:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added firmware update spec for Dell hardware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I833f8c068849ed82c338a4c1d9c929c379b9624c"},{"line_number":10,"context_line":"Story: 2003494"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_3b010608","line":7,"updated":"2018-10-15 20:07:47.000000000","message":"nit: Would you use the imperative mood, \u0027Add\u0027, instead of \u0027Added\u0027?","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fdfed9c16ab9690ae2c97da45bcfaa81d99b2895","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christopher Dearborn \u003cChristopher.Dearborn@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-04 16:54:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added firmware update spec for Dell hardware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I833f8c068849ed82c338a4c1d9c929c379b9624c"},{"line_number":10,"context_line":"Story: 2003494"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_19077283","line":7,"in_reply_to":"3f79a3b5_3b010608","updated":"2018-10-15 21:19:22.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fdfed9c16ab9690ae2c97da45bcfaa81d99b2895","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christopher Dearborn \u003cChristopher.Dearborn@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-04 16:54:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added firmware update spec for Dell hardware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I833f8c068849ed82c338a4c1d9c929c379b9624c"},{"line_number":10,"context_line":"Story: 2003494"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_b9f99e82","line":7,"in_reply_to":"3f79a3b5_5bfc020c","updated":"2018-10-15 21:19:22.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"}],"specs/approved/drac-firmware-update-spec.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"* Update firmware:"},{"line_number":122,"context_line":"  https://$idrac_ip/redfish/v1/UpdateService/Actions/Oem/DellUpdateService.Install"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Redfish support for firmware management"},{"line_number":125,"context_line":"---------------------------------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"There is currently no support for firmware update in Sushy, and therefore no"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_974d1473","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":39},"updated":"2018-09-13 14:33:31.000000000","message":"Redfish standard do support firmware mangement. May be this headline could be:-\n\"Support for firmware management in `redfish` hardware type\"","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":121,"context_line":"* Update firmware:"},{"line_number":122,"context_line":"  https://$idrac_ip/redfish/v1/UpdateService/Actions/Oem/DellUpdateService.Install"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Redfish support for firmware management"},{"line_number":125,"context_line":"---------------------------------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"There is currently no support for firmware update in Sushy, and therefore no"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_69e03fcc","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":39},"in_reply_to":"3f79a3b5_974d1473","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"---------------------------------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"There is currently no support for firmware update in Sushy, and therefore no"},{"line_number":128,"context_line":"support for firmware update in the Redfish driver."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b747f04c","line":128,"range":{"start_line":128,"start_character":35,"end_line":128,"end_character":42},"updated":"2018-09-13 14:33:31.000000000","message":"s/ Redfish driver / ``redfish`` hardware type /","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":125,"context_line":"---------------------------------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"There is currently no support for firmware update in Sushy, and therefore no"},{"line_number":128,"context_line":"support for firmware update in the Redfish driver."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a903b775","line":128,"range":{"start_line":128,"start_character":35,"end_line":128,"end_character":42},"in_reply_to":"3f79a3b5_b747f04c","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created to initiate firmware update. The"},{"line_number":136,"context_line":"clean step will accept a list of dictionaries. Each dictionary will represent"},{"line_number":137,"context_line":"a single firmware update, and will contain a URI to the firmware image. The"},{"line_number":138,"context_line":"implementation will apply the firmware updates in the order specified in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_17f104df","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":26},"updated":"2018-09-13 14:33:31.000000000","message":"Under which interface? In \u0027management\u0027 interface right?","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created to initiate firmware update. The"},{"line_number":136,"context_line":"clean step will accept a list of dictionaries. Each dictionary will represent"},{"line_number":137,"context_line":"a single firmware update, and will contain a URI to the firmware image. The"},{"line_number":138,"context_line":"implementation will apply the firmware updates in the order specified in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c964f34b","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":26},"in_reply_to":"3f79a3b5_17f104df","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created to initiate firmware update. The"},{"line_number":136,"context_line":"clean step will accept a list of dictionaries. Each dictionary will represent"},{"line_number":137,"context_line":"a single firmware update, and will contain a URI to the firmware image. The"},{"line_number":138,"context_line":"implementation will apply the firmware updates in the order specified in the"},{"line_number":139,"context_line":"list."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_f71ec80b","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":71},"updated":"2018-09-13 14:33:31.000000000","message":"Adding a json sample of clean_step arguments would be useful.","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created to initiate firmware update. The"},{"line_number":136,"context_line":"clean step will accept a list of dictionaries. Each dictionary will represent"},{"line_number":137,"context_line":"a single firmware update, and will contain a URI to the firmware image. The"},{"line_number":138,"context_line":"implementation will apply the firmware updates in the order specified in the"},{"line_number":139,"context_line":"list."},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_74557251","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":71},"in_reply_to":"3f79a3b5_f71ec80b","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a312c504409e0588be9ecd77e777411d0ffef394","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":142,"context_line":"and not apply the remaining updates. If a failure does occur midway through"},{"line_number":143,"context_line":"applying the updates, successful updates prior to the failed update will not"},{"line_number":144,"context_line":"be rolled back."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The cleaning step will be out-of-band. Because there is no support for"},{"line_number":147,"context_line":"firmware update in the Redfish driver or in Sushy, the firmware update"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_17dfc438","line":144,"range":{"start_line":143,"start_character":22,"end_line":144,"end_character":14},"updated":"2018-09-13 14:28:43.000000000","message":"Would it make sense to roll back at least the failed update? Could failed firmware update leave the system in an unstable state?","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":142,"context_line":"and not apply the remaining updates. If a failure does occur midway through"},{"line_number":143,"context_line":"applying the updates, successful updates prior to the failed update will not"},{"line_number":144,"context_line":"be rolled back."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The cleaning step will be out-of-band. Because there is no support for"},{"line_number":147,"context_line":"firmware update in the Redfish driver or in Sushy, the firmware update"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_2f71e777","line":144,"range":{"start_line":143,"start_character":22,"end_line":144,"end_character":14},"in_reply_to":"3f79a3b5_17dfc438","updated":"2018-10-02 19:59:51.000000000","message":"As far as I\u0027m aware, a failed firmware update should not leave the system in an unstable state.  Since the ilo hardware type takes the fail fast approach, I thought I would mirror what it does here.","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":142,"context_line":"and not apply the remaining updates. If a failure does occur midway through"},{"line_number":143,"context_line":"applying the updates, successful updates prior to the failed update will not"},{"line_number":144,"context_line":"be rolled back."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The cleaning step will be out-of-band. Because there is no support for"},{"line_number":147,"context_line":"firmware update in the Redfish driver or in Sushy, the firmware update"},{"line_number":148,"context_line":"cleaning step will use WSMAN to perform the update."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b774d037","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":38},"updated":"2018-09-13 14:33:31.000000000","message":"Would this feature need any new configuration into ironic.conf as there are some configs used by iLO drivers for its implementation?","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":142,"context_line":"and not apply the remaining updates. If a failure does occur midway through"},{"line_number":143,"context_line":"applying the updates, successful updates prior to the failed update will not"},{"line_number":144,"context_line":"be rolled back."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The cleaning step will be out-of-band. Because there is no support for"},{"line_number":147,"context_line":"firmware update in the Redfish driver or in Sushy, the firmware update"},{"line_number":148,"context_line":"cleaning step will use WSMAN to perform the update."},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ef43ef3e","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":38},"in_reply_to":"3f79a3b5_b774d037","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The cleaning step will be out-of-band. Because there is no support for"},{"line_number":147,"context_line":"firmware update in the Redfish driver or in Sushy, the firmware update"},{"line_number":148,"context_line":"cleaning step will use WSMAN to perform the update."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Alternatives"},{"line_number":151,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_97bc34dc","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":51},"updated":"2018-09-13 14:33:31.000000000","message":"Will this feature need enhancement to python-dracclient as well?","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The cleaning step will be out-of-band. Because there is no support for"},{"line_number":147,"context_line":"firmware update in the Redfish driver or in Sushy, the firmware update"},{"line_number":148,"context_line":"cleaning step will use WSMAN to perform the update."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Alternatives"},{"line_number":151,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_ef8a0f63","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":51},"in_reply_to":"3f79a3b5_97bc34dc","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a312c504409e0588be9ecd77e777411d0ffef394","unresolved":false,"context_lines":[{"line_number":151,"context_line":"------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"An alternative would be to use the Redfish protocol to perform the firmware"},{"line_number":154,"context_line":"update. At a minimum, this would entail adding support for firmware update"},{"line_number":155,"context_line":"(and possibly OEM support?) to Sushy. This could also include adding support"},{"line_number":156,"context_line":"for firmware update to the Redfish driver."},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b7fff0a9","line":154,"range":{"start_line":154,"start_character":40,"end_line":154,"end_character":74},"updated":"2018-09-13 14:28:43.000000000","message":"We may want to implement firmware update feature in sushy anyway.","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a312c504409e0588be9ecd77e777411d0ffef394","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"An alternative would be to use the Redfish protocol to perform the firmware"},{"line_number":154,"context_line":"update. At a minimum, this would entail adding support for firmware update"},{"line_number":155,"context_line":"(and possibly OEM support?) to Sushy. This could also include adding support"},{"line_number":156,"context_line":"for firmware update to the Redfish driver."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b76a907e","line":155,"range":{"start_line":155,"start_character":1,"end_line":155,"end_character":26},"updated":"2018-09-13 14:28:43.000000000","message":"Note: OEM patch for sushy is on its way [1].\n\n1. https://review.openstack.org/#/c/463829/","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"826501a195f1247f033c39ec42b9a7a55cacadbb","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Alternatives"},{"line_number":151,"context_line":"------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"An alternative would be to use the Redfish protocol to perform the firmware"},{"line_number":154,"context_line":"update. At a minimum, this would entail adding support for firmware update"},{"line_number":155,"context_line":"(and possibly OEM support?) to Sushy. This could also include adding support"},{"line_number":156,"context_line":"for firmware update to the Redfish driver."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_77e6384d","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":36},"updated":"2018-09-13 14:33:31.000000000","message":"Other alternative is to enhance python-dracclient to support redfish OEM extensions like firmware update.","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Alternatives"},{"line_number":151,"context_line":"------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"An alternative would be to use the Redfish protocol to perform the firmware"},{"line_number":154,"context_line":"update. At a minimum, this would entail adding support for firmware update"},{"line_number":155,"context_line":"(and possibly OEM support?) to Sushy. This could also include adding support"},{"line_number":156,"context_line":"for firmware update to the Redfish driver."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cf863366","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":36},"in_reply_to":"3f79a3b5_77e6384d","updated":"2018-10-02 19:59:51.000000000","message":"Done","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"13d1c944a97ff943b6ac5ca7d39dd457b8753b34","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"An alternative would be to use the Redfish protocol to perform the firmware"},{"line_number":154,"context_line":"update. At a minimum, this would entail adding support for firmware update"},{"line_number":155,"context_line":"(and possibly OEM support?) to Sushy. This could also include adding support"},{"line_number":156,"context_line":"for firmware update to the Redfish driver."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8f7cbb71","line":155,"range":{"start_line":155,"start_character":1,"end_line":155,"end_character":26},"in_reply_to":"3f79a3b5_b76a907e","updated":"2018-10-02 19:59:51.000000000","message":"Great!","commit_id":"f41dbdb2b565d6afdc070e1c3b6bf4dc92c4ca9a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Dell hardware firmware update"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2003494"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_3b53463c","line":8,"updated":"2018-10-15 20:07:47.000000000","message":"Throughout this file, please replace \u0027Dell\u0027 with \u0027Dell EMC\u0027.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Dell hardware firmware update"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2003494"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fe037c74","line":8,"in_reply_to":"3f79a3b5_3b53463c","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The firmware is installed in-band from an agent ramdisk."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The ILO driver supports Redfish firmware update by extending sushy classes and"},{"line_number":85,"context_line":"adding the UpdateService. The ILO driver switches on a protocol variable and"},{"line_number":86,"context_line":"makes calls directly into these classes to perform firmware update when"},{"line_number":87,"context_line":"Redfish is selected."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_5b4e4290","line":84,"updated":"2018-10-15 20:07:47.000000000","message":"nit: s/driver/hardware type/\nThis applies throughout this file.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The firmware is installed in-band from an agent ramdisk."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The ILO driver supports Redfish firmware update by extending sushy classes and"},{"line_number":85,"context_line":"adding the UpdateService. The ILO driver switches on a protocol variable and"},{"line_number":86,"context_line":"makes calls directly into these classes to perform firmware update when"},{"line_number":87,"context_line":"Redfish is selected."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_5ee870a5","line":84,"in_reply_to":"3f79a3b5_5b4e4290","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"* CONF.ilo.use_web_server_for_image: Indicates if images should be uploaded to"},{"line_number":102,"context_line":"  the conductor web server"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dell WSMAN firmware management"},{"line_number":105,"context_line":"------------------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Supported operations are:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fb2e2ea9","line":104,"updated":"2018-10-15 20:07:47.000000000","message":"Mentioning that this is offered by the iDRAC would provide helpful context.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":101,"context_line":"* CONF.ilo.use_web_server_for_image: Indicates if images should be uploaded to"},{"line_number":102,"context_line":"  the conductor web server"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Dell WSMAN firmware management"},{"line_number":105,"context_line":"------------------------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Supported operations are:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1e15189b","line":104,"in_reply_to":"3f79a3b5_fb2e2ea9","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* List firmware on server: Enumerate DCIM_SoftwareIdentity"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Update firmware: Invoke DCIM_SoftwareInstallationService.SoftwareUpdate"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dell Redfish firmware management"},{"line_number":114,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1b320a10","line":111,"updated":"2018-10-15 20:07:47.000000000","message":"I do not see this method in the iDRAC 9 (14G) documentation.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"37cff97c458ad0d4939fb2f4c8aaeaae579906f3","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* List firmware on server: Enumerate DCIM_SoftwareIdentity"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Update firmware: Invoke DCIM_SoftwareInstallationService.SoftwareUpdate"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dell Redfish firmware management"},{"line_number":114,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_292e84f8","line":111,"in_reply_to":"3f79a3b5_1990d241","updated":"2018-10-16 21:23:36.000000000","message":"Thanks for the link. \u0027SoftwareUpdate\u0027 isn\u0027t a method. Rather, it\u0027s the value of the \u0027Name\u0027 property of the \u0027DCIM_SoftwareInstallationService\u0027. I believe the method you\u0027re looking for is \u0027InstallFromURI\u0027. That appears in both documents.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* List firmware on server: Enumerate DCIM_SoftwareIdentity"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Update firmware: Invoke DCIM_SoftwareInstallationService.SoftwareUpdate"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dell Redfish firmware management"},{"line_number":114,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1990d241","line":111,"in_reply_to":"3f79a3b5_1b320a10","updated":"2018-10-15 21:18:07.000000000","message":"Unfortunately it appears that the links to the profiles are broken.  You can see a reference to it here in a document from 2012:\nhttps://usermanual.wiki/Dell/DellDellLifecycleController12ForLinuxWebServicesInterfaceGuide137594.2005880032.pdf","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* List firmware on server: Enumerate DCIM_SoftwareIdentity"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Update firmware: Invoke DCIM_SoftwareInstallationService.SoftwareUpdate"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dell Redfish firmware management"},{"line_number":114,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_6ae538db","line":111,"in_reply_to":"3f79a3b5_292e84f8","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Update firmware: Invoke DCIM_SoftwareInstallationService.SoftwareUpdate"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dell Redfish firmware management"},{"line_number":114,"context_line":"--------------------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Supported operations are:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_bb3436fb","line":113,"updated":"2018-10-15 20:07:47.000000000","message":"Mentioning that this is offered by the iDRAC would provide helpful context.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Update firmware: Invoke DCIM_SoftwareInstallationService.SoftwareUpdate"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dell Redfish firmware management"},{"line_number":114,"context_line":"--------------------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Supported operations are:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fe761c0c","line":113,"in_reply_to":"3f79a3b5_bb3436fb","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created in the DRAC hardware type"},{"line_number":136,"context_line":"``ManagementInterface`` to initiate firmware update. The clean step will"},{"line_number":137,"context_line":"accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":138,"context_line":"firmware update, and will contain a URI to the firmware image."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_db37b2fc","line":135,"updated":"2018-10-15 20:07:47.000000000","message":"nit: s/DRAC/iDRAC/","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created in the DRAC hardware type"},{"line_number":136,"context_line":"``ManagementInterface`` to initiate firmware update. The clean step will"},{"line_number":137,"context_line":"accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":138,"context_line":"firmware update, and will contain a URI to the firmware image."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_be550454","line":135,"in_reply_to":"3f79a3b5_db37b2fc","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created in the DRAC hardware type"},{"line_number":136,"context_line":"``ManagementInterface`` to initiate firmware update. The clean step will"},{"line_number":137,"context_line":"accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":138,"context_line":"firmware update, and will contain a URI to the firmware image."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7b221ebc","line":136,"updated":"2018-10-15 20:07:47.000000000","message":"Adding this to the existing .../modules/drac/management.ManagementInterface would intermingle management by WS-Man and Redfish.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created in the DRAC hardware type"},{"line_number":136,"context_line":"``ManagementInterface`` to initiate firmware update. The clean step will"},{"line_number":137,"context_line":"accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":138,"context_line":"firmware update, and will contain a URI to the firmware image."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_b99e7eb4","line":136,"in_reply_to":"3f79a3b5_7b221ebc","updated":"2018-10-15 21:18:07.000000000","message":"Yes.  This is the approach taken in the ILO driver.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"37cff97c458ad0d4939fb2f4c8aaeaae579906f3","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"The proposed design is to mirror what was done in the ILO driver for firmware"},{"line_number":135,"context_line":"update. A manual clean step will be created in the DRAC hardware type"},{"line_number":136,"context_line":"``ManagementInterface`` to initiate firmware update. The clean step will"},{"line_number":137,"context_line":"accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":138,"context_line":"firmware update, and will contain a URI to the firmware image."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_a98b74be","line":136,"in_reply_to":"3f79a3b5_b99e7eb4","updated":"2018-10-16 21:23:36.000000000","message":"Please humor me as I attempt to be more specific about my concern.\n\n1. We plan to add the existing Redfish hardware interface implementations to the interfaces supported by the \u0027idrac\u0027 hardware type. We\u0027ve been referring to that as a hybrid WS-Man and Redfish \u0027idrac\u0027 hardware type. Presently, Redfish management and power interfaces exist, and those will be added.\n2. You\u0027ve confirmed my understanding that this new feature will be added to the management interface that has long been supported by the \u0027idrac\u0027 hardware type and is defined by class .../modules/drac/management.ManagementInterface. Let\u0027s call that the legacy \u0027idrac\u0027 management interface.\n3. A hardware type can support more than one implementation of any type of interface, where type is management, power, deploy, inspect, etc. So, the hybrid \u0027idrac\u0027 hardware type will declare support for both its legacy management interface and the Redfish management interface. So far, no harm and no foul.\n4. A hardware type defines its default interface implementation for each type of interface. Presently, for \u0027idrac\u0027, that\u0027s its legacy management interface.\n5. When a hardware type supports more than one interface implementation of a given type, the operator can override the default and specify another supported one be used.\n6. If the operator wants \u0027idrac\u0027 to use the Redfish management interface, s/he will not be able to use this new feature, because it will be in the legacy management interface. The operator will likely be puzzled by that, since s/he will know that this new feature uses Redfish. That\u0027s a challenge.\n7. If the operator wants to use this feature, s/he will not be able to use the Redfish management interface implementation. That seems incongruous.\n8. How will different credentials for the WS-Man and Redfish iDRAC interfaces be dealt with by a single interface implementation that intermingles the use of both of those?\n\nFrom the preceding, it\u0027s clear that deprecation and removal of the legacy management interface from the \u0027idrac\u0027 hardware type will be more difficult if we go forward with the proposed design.\n\nAs I suggested previously, an alternative approach would be to define a new management interface implementation that is derived from and extends the Redfish management interface implementation. Its source module could host any needed Redfish functionality that sushy lacks.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":146,"context_line":"          \"firmware_update_mode\": \"drac\","},{"line_number":147,"context_line":"          \"firmware_images\":["},{"line_number":148,"context_line":"              {"},{"line_number":149,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":150,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":151,"context_line":"              },"},{"line_number":152,"context_line":"              {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_9b1dba78","line":149,"updated":"2018-10-15 20:07:47.000000000","message":"Does this mean that updates to an individual component\u0027s firmware is not supported? If memory serves, those are offered by .bin files.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":146,"context_line":"          \"firmware_update_mode\": \"drac\","},{"line_number":147,"context_line":"          \"firmware_images\":["},{"line_number":148,"context_line":"              {"},{"line_number":149,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":150,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":151,"context_line":"              },"},{"line_number":152,"context_line":"              {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1ef1986a","line":149,"in_reply_to":"3f79a3b5_9b1dba78","updated":"2018-10-15 21:18:07.000000000","message":"No.  Looking at the firmware updates available for a 14G R640, there are DUP updates available for all components:\nhttps://www.dell.com/support/home/us/en/04/product-support/product/poweredge-r640/drivers","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":166,"context_line":"be rolled back."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_5b23a2bb","line":169,"updated":"2018-10-15 20:07:47.000000000","message":"It was stated above, \"A manual clean step will be created in the DRAC hardware type ``ManagementInterface`` to initiate firmware update.\" Does that mean that the existing WS-Man drivers.modules.drac.management.ManagementInterface class will have a dependency on Redfish functionality added to it? That would intermingle the use of the WS-Man and Redfish protocols in the same hardware interface implementation, which could add challenges when WS-Man support is deprecated and dropped. An alternative approach would be to define a new management interface implementation that is derived from and extends the Redfish management interface implementation.\n\nAlso, since the python-dracclient library\u0027s inception, it has only offered a WS-Man client for the iDRAC. Up and down its stack, it speaks WS-Man. Therefore, adding this to the the python-dracclient gives me pause without a high-level overview on how it will be done.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":166,"context_line":"be rolled back."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_3b282696","line":169,"updated":"2018-10-15 20:07:47.000000000","message":"Would you use Redfish when referring to the DMTF protocol, and ``redfish`` for the ironic hardware type? There are several locations where this applies.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":166,"context_line":"be rolled back."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_deb48083","line":169,"in_reply_to":"3f79a3b5_3b282696","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":166,"context_line":"be rolled back."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_59bacab9","line":169,"in_reply_to":"3f79a3b5_5b23a2bb","updated":"2018-10-15 21:18:07.000000000","message":"Yes.  That is how the ILO hardware type implemented firmware update.  From discussions at the PTG, it was pointed out that we don\u0027t want to gate this feature on firmware update being implemented in the redfish hardware type.  If the code doesn\u0027t live in python-dracclient, then I don\u0027t know where it will live.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"37cff97c458ad0d4939fb2f4c8aaeaae579906f3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"be rolled back."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_a9a4d44c","line":169,"in_reply_to":"3f79a3b5_deb48083","updated":"2018-10-16 21:23:36.000000000","message":"Please see my follow-up above.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"While the iDRAC supports rolling back to the last known good firmware, the"},{"line_number":174,"context_line":"ability to do this will not be implemented as part of this spec.  Instead,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fb170e53","line":171,"updated":"2018-10-15 20:07:47.000000000","message":"nit: Please remove the extra \u0027in\u0027.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":168,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":169,"context_line":"will use ``redfish`` to perform the update.  The intent is to use the"},{"line_number":170,"context_line":"sushy library where possible, and where not, implement the  ``redfish``"},{"line_number":171,"context_line":"operations in in python-dracclient."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"While the iDRAC supports rolling back to the last known good firmware, the"},{"line_number":174,"context_line":"ability to do this will not be implemented as part of this spec.  Instead,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_5ef2b06a","line":171,"in_reply_to":"3f79a3b5_fb170e53","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":189,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":190,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of ``redfish``, it"},{"line_number":191,"context_line":"is preferred to avoid this option."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Data model impact"},{"line_number":194,"context_line":"-----------------"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_1b1bea7f","line":192,"updated":"2018-10-15 20:07:47.000000000","message":"Another alternative would be to do this in-band, via an Ironic Python Agent hardware manager for the iDRAC.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":189,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":190,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of ``redfish``, it"},{"line_number":191,"context_line":"is preferred to avoid this option."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Data model impact"},{"line_number":194,"context_line":"-----------------"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_d9057a10","line":192,"in_reply_to":"3f79a3b5_1b1bea7f","updated":"2018-10-15 21:18:07.000000000","message":"I have added this for completeness though this is not an alternative that I would consider implementing.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":211,"context_line":"\"ironic\" CLI"},{"line_number":212,"context_line":"~~~~~~~~~~~~"},{"line_number":213,"context_line":"Users will be able to launch a cleaning step to upgrade the firmware on Dell"},{"line_number":214,"context_line":"servers."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"\"openstack baremetal\" CLI"},{"line_number":217,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_bb0d1641","line":214,"updated":"2018-10-15 20:07:47.000000000","message":"Do specs still need to mention the impact on the ironic CLI. If memory serves, it has at least been deprecated,","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":211,"context_line":"\"ironic\" CLI"},{"line_number":212,"context_line":"~~~~~~~~~~~~"},{"line_number":213,"context_line":"Users will be able to launch a cleaning step to upgrade the firmware on Dell"},{"line_number":214,"context_line":"servers."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"\"openstack baremetal\" CLI"},{"line_number":217,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fe605c0f","line":214,"in_reply_to":"3f79a3b5_bb0d1641","updated":"2018-10-15 21:18:07.000000000","message":"It\u0027s still in the specs template, therefore it appears here.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":226,"context_line":"Driver API impact"},{"line_number":227,"context_line":"-----------------"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"A cleaning step will be added to upgrade the firmware."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Nova driver impact"},{"line_number":232,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_db10125b","line":229,"updated":"2018-10-15 20:07:47.000000000","message":"Specifically, Dell EMC hardware managed by the ``idrac`` hardware type.","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":226,"context_line":"Driver API impact"},{"line_number":227,"context_line":"-----------------"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"A cleaning step will be added to upgrade the firmware."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"Nova driver impact"},{"line_number":232,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_d91eda5c","line":229,"in_reply_to":"3f79a3b5_db10125b","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Documentation Impact"},{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"The documentation will be updated to represent this new feature.  The"},{"line_number":319,"context_line":"documentation will be updated to include the generations of hardware"},{"line_number":320,"context_line":"officially supported."},{"line_number":321,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7b0bfe29","line":318,"updated":"2018-10-15 20:07:47.000000000","message":"nit: s/represent/cover/","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":315,"context_line":"Documentation Impact"},{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"The documentation will be updated to represent this new feature.  The"},{"line_number":319,"context_line":"documentation will be updated to include the generations of hardware"},{"line_number":320,"context_line":"officially supported."},{"line_number":321,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7e5d2c46","line":318,"in_reply_to":"3f79a3b5_7b0bfe29","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"74bb98e4a755eef0f9e51b2d40dc1029c28bf6b1","unresolved":false,"context_lines":[{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"The documentation will be updated to represent this new feature.  The"},{"line_number":319,"context_line":"documentation will be updated to include the generations of hardware"},{"line_number":320,"context_line":"officially supported."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_9b061a21","line":319,"updated":"2018-10-15 20:07:47.000000000","message":"s/hardware/Dell EMC hardware/","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d16178766110f3418ec5dc9262e5b35bb6531e49","unresolved":false,"context_lines":[{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"The documentation will be updated to represent this new feature.  The"},{"line_number":319,"context_line":"documentation will be updated to include the generations of hardware"},{"line_number":320,"context_line":"officially supported."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_fe493c8d","line":319,"in_reply_to":"3f79a3b5_9b061a21","updated":"2018-10-15 21:18:07.000000000","message":"Done","commit_id":"5f12968e58e440d5a14f1321d2454dd92d325b70"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":175,"context_line":"While the iDRAC supports rolling back to the last known good firmware, the"},{"line_number":176,"context_line":"ability to do this will not be implemented as part of this spec.  Instead,"},{"line_number":177,"context_line":"if a user wishes to roll back to an early version of the firmware, they will"},{"line_number":178,"context_line":"just do a firmware upgrade to an older version."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"While the initial implementation of this will use the Redfish protocol,"},{"line_number":181,"context_line":"it will be implemented in such a way that it will not preclude adding"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_e9664cee","line":178,"updated":"2018-10-16 20:12:08.000000000","message":"Please change \u0027upgrade\u0027 to \u0027downgrade\u0027 or \u0027update\u0027.","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"While the iDRAC supports rolling back to the last known good firmware, the"},{"line_number":176,"context_line":"ability to do this will not be implemented as part of this spec.  Instead,"},{"line_number":177,"context_line":"if a user wishes to roll back to an early version of the firmware, they will"},{"line_number":178,"context_line":"just do a firmware upgrade to an older version."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"While the initial implementation of this will use the Redfish protocol,"},{"line_number":181,"context_line":"it will be implemented in such a way that it will not preclude adding"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_6fe54adb","line":178,"in_reply_to":"3f79a3b5_e9664cee","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"\"ironic\" CLI"},{"line_number":217,"context_line":"~~~~~~~~~~~~"},{"line_number":218,"context_line":"Users will be able to launch a cleaning step to upgrade the firmware on Dell"},{"line_number":219,"context_line":"EMC servers."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_0962a8d9","line":218,"updated":"2018-10-16 20:12:08.000000000","message":"s/upgrade/update/","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"\"ironic\" CLI"},{"line_number":217,"context_line":"~~~~~~~~~~~~"},{"line_number":218,"context_line":"Users will be able to launch a cleaning step to upgrade the firmware on Dell"},{"line_number":219,"context_line":"EMC servers."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_2fc75240","line":218,"in_reply_to":"3f79a3b5_0962a8d9","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\"openstack baremetal\" CLI"},{"line_number":222,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":223,"context_line":"Users will be able to launch a cleaning step to upgrade the firmware on Dell"},{"line_number":224,"context_line":"EMC servers."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_a95cd419","line":223,"updated":"2018-10-16 20:12:08.000000000","message":"Ditto","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"\"openstack baremetal\" CLI"},{"line_number":222,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":223,"context_line":"Users will be able to launch a cleaning step to upgrade the firmware on Dell"},{"line_number":224,"context_line":"EMC servers."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"RPC API impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_efd07af7","line":223,"in_reply_to":"3f79a3b5_a95cd419","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":231,"context_line":"Driver API impact"},{"line_number":232,"context_line":"-----------------"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"A cleaning step will be added to upgrade the firmware on Dell EMC hardware"},{"line_number":235,"context_line":"managed by the ``idrac`` hardware type."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Nova driver impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_c957d0f4","line":234,"updated":"2018-10-16 20:12:08.000000000","message":"Ditto","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"Driver API impact"},{"line_number":232,"context_line":"-----------------"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"A cleaning step will be added to upgrade the firmware on Dell EMC hardware"},{"line_number":235,"context_line":"managed by the ``idrac`` hardware type."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Nova driver impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_8fff8668","line":234,"in_reply_to":"3f79a3b5_c957d0f4","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":298,"context_line":"----------"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"* Ironic iDRAC hardware type changes to add a cleaning step"},{"line_number":301,"context_line":"* python-dracclient changes to implement firmware upgrade"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Dependencies"},{"line_number":304,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_6998fcca","line":301,"updated":"2018-10-16 20:12:08.000000000","message":"Ditto","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"----------"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"* Ironic iDRAC hardware type changes to add a cleaning step"},{"line_number":301,"context_line":"* python-dracclient changes to implement firmware upgrade"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Dependencies"},{"line_number":304,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_4ff96e80","line":301,"in_reply_to":"3f79a3b5_6998fcca","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":309,"context_line":"Testing"},{"line_number":310,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Addition of unit tests to test the firmware upgrade cleaning step."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":315,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_899b18c6","line":312,"updated":"2018-10-16 20:12:08.000000000","message":"Ditto","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"Testing"},{"line_number":310,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Addition of unit tests to test the firmware upgrade cleaning step."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":315,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_6ffeaa6b","line":312,"in_reply_to":"3f79a3b5_899b18c6","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"1ee780955eb47daa38be7f3afc0005b4740cedd2","unresolved":false,"context_lines":[{"line_number":314,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":315,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"If a firmware upgrade is attempted on a Dell EMC server that does not"},{"line_number":318,"context_line":"support the Redfish DellUpdateService firmware upgrade command, then"},{"line_number":319,"context_line":"cleaning will be aborted and an appropriate error message logged."},{"line_number":320,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_299e84b6","line":317,"updated":"2018-10-16 20:12:08.000000000","message":"Ditto","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5576bdf2bcf2d993d6776851958aa7caed801f8f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":315,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"If a firmware upgrade is attempted on a Dell EMC server that does not"},{"line_number":318,"context_line":"support the Redfish DellUpdateService firmware upgrade command, then"},{"line_number":319,"context_line":"cleaning will be aborted and an appropriate error message logged."},{"line_number":320,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_2ff0b292","line":317,"in_reply_to":"3f79a3b5_299e84b6","updated":"2018-10-17 15:14:40.000000000","message":"Done","commit_id":"f5c9d437db76effb9835d41e4f45cecbf69e1d63"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"189a1acc24a3ec61e0ded110e4f0cc5af45c74cc","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The proposed design is to mirror what was done in the ILO hardware type for"},{"line_number":138,"context_line":"firmware update. A manual clean step will be created in the iDRAC hardware"},{"line_number":139,"context_line":"type ``ManagementInterface`` to initiate firmware update. The clean step"},{"line_number":140,"context_line":"will accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":141,"context_line":"firmware update, and will contain a URI to the firmware image."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_cffd7708","line":139,"updated":"2018-10-17 18:28:23.000000000","message":"Please humor me as I attempt to more clearly explain my concern.\n\n1. We plan to add the existing Redfish hardware interface implementations to the interfaces supported by the \u0027idrac\u0027 hardware type. We\u0027ve been referring to that as a hybrid WS-Man and Redfish \u0027idrac\u0027 hardware type. Presently, Redfish management and power interfaces exist, and those will be added.\n2. You\u0027ve confirmed my understanding that this spec calls for adding this new feature to the management interface that has long been supported by the \u0027idrac\u0027 hardware type and is defined by class .../modules/drac/management.ManagementInterface. Let\u0027s call that the legacy \u0027idrac\u0027 management interface.\n3. A hardware type can support more than one implementation of any type of interface, where type is management, power, deploy, inspect, etc. So, the hybrid \u0027idrac\u0027 hardware type will declare support for both its legacy management interface and the Redfish management interface. So far, no harm and no foul.\n4. A hardware type defines its default interface implementation for each type of interface. Presently, for \u0027idrac\u0027, that\u0027s its legacy management interface.\n5. When a hardware type supports more than one interface implementation of a given type, an operator can override the default and specify another supported one be used.\n6. If an operator wants \u0027idrac\u0027 to use the Redfish management interface, s/he will not be able to use this new feature, because it will be in the legacy management interface. The operator will likely be puzzled by that, since s/he will know that this new feature uses Redfish. That\u0027s a challenge.\n7. If the operator wants to use this feature, s/he will not be able to use the Redfish management interface implementation. That seems incongruous.\n\nFrom the preceding, it\u0027s clear that deprecation and removal of the legacy management interface from the \u0027idrac\u0027 hardware type will be more difficult if we go forward with the proposed design.\n\nAnother question comes to mind. How will different credentials for the WS-Man and Redfish iDRAC interfaces be dealt with by a single interface implementation that intermingles the use of both of those?\n\nAs I suggested previously, an alternative approach would be to define a new management interface implementation that is derived from and extends the Redfish management interface implementation. Its source module could host any needed Redfish functionality that sushy lacks.","commit_id":"f930fb1e94c65a6a6debc759ac0d4ebd3ada0eef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1d1a3af15f97f7bc3bc1a9a1daa3e454c2ed778e","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The proposed design is to mirror what was done in the ILO hardware type for"},{"line_number":138,"context_line":"firmware update. A manual clean step will be created in the iDRAC hardware"},{"line_number":139,"context_line":"type ``ManagementInterface`` to initiate firmware update. The clean step"},{"line_number":140,"context_line":"will accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":141,"context_line":"firmware update, and will contain a URI to the firmware image."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_9b17689e","line":139,"in_reply_to":"3f79a3b5_cffd7708","updated":"2018-10-22 20:50:29.000000000","message":"1. You raise a good point.\n2. Done.","commit_id":"f930fb1e94c65a6a6debc759ac0d4ebd3ada0eef"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a8f9f72e0c81a6ecdc6fb4a82cec842487463af6","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"The proposed design is to mirror what was done in the ILO hardware type for"},{"line_number":138,"context_line":"firmware update. A manual clean step will be created in the iDRAC hardware"},{"line_number":139,"context_line":"type ``ManagementInterface`` to initiate firmware update. The clean step"},{"line_number":140,"context_line":"will accept a list of dictionaries.  Each dictionary will represent a single"},{"line_number":141,"context_line":"firmware update, and will contain a URI to the firmware image."},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_9059ac8e","line":139,"in_reply_to":"3f79a3b5_cffd7708","updated":"2018-10-19 16:40:44.000000000","message":"I think there is going to need to be a idrac[x] hardware type that delineates at a particular point, or have a separate named management interface that could be selected but not be default. The earlier option is likely better, all things considered. \n\nAs for credentials, I would think since it would be idrac specific code that would be invoking the redfish client, than the same credentials could be used for this module. Mixing power in though, that does become problematic, but that seems surpass-able. We\u0027ve discussed some options to clean that up, and the only thing that is holding us back seems to be precedence with prior architecture.\n\nPerhaps this is one of those cases where it might be better to just get a POC written.","commit_id":"f930fb1e94c65a6a6debc759ac0d4ebd3ada0eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* An operator or software component removes a firmware image from a firmware"},{"line_number":41,"context_line":"  image repository."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"ILO firmware update implementation"},{"line_number":44,"context_line":"----------------------------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Firmware images are initially manually uploaded to a firmware repository."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_18835708","line":43,"updated":"2018-11-20 16:38:13.000000000","message":"Why are you talking about iLO here and below? Is it just copy-paste or do you want to emphasize that you\u0027re modelling your approach after theirs?","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* An operator or software component removes a firmware image from a firmware"},{"line_number":41,"context_line":"  image repository."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"ILO firmware update implementation"},{"line_number":44,"context_line":"----------------------------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Firmware images are initially manually uploaded to a firmware repository."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_c0ddd041","line":43,"in_reply_to":"3f79a3b5_18835708","updated":"2019-04-05 20:21:30.000000000","message":"I include information about the iLO implementation for readers that were not familiar with it, so that they could see that I was trying not to veer too far from a similar implementation.  I\u0027ve removed the iLO information since it was confusing.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* update_firmware"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* update_firmware_sum"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The update_firmware cleaning step accepts a sequence of dictionaries"},{"line_number":63,"context_line":"containing:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_38865317","line":60,"updated":"2018-11-20 16:38:13.000000000","message":"Do you also have SUM as an update method or is it also copy-paste? :)","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* update_firmware"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* update_firmware_sum"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"The update_firmware cleaning step accepts a sequence of dictionaries"},{"line_number":63,"context_line":"containing:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_c0b630fa","line":60,"in_reply_to":"3f79a3b5_38865317","updated":"2019-04-05 20:21:30.000000000","message":"Neither.  I included information about the iLO implementation for readers who were not familiar with it.  Removed.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Checksum"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The firmware is installed in-band from an agent ramdisk."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The ILO hardware type supports Redfish firmware update by extending sushy"},{"line_number":85,"context_line":"classes and adding the UpdateService. The ILO hardware type switches on a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_d87cff23","line":82,"updated":"2018-11-20 16:38:13.000000000","message":"Do you actually support this?","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Checksum"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The firmware is installed in-band from an agent ramdisk."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The ILO hardware type supports Redfish firmware update by extending sushy"},{"line_number":85,"context_line":"classes and adding the UpdateService. The ILO hardware type switches on a"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_40c24055","line":82,"in_reply_to":"3f79a3b5_d87cff23","updated":"2019-04-05 20:21:30.000000000","message":"No.  I included information about the iLO implementation for readers who were not familiar with it.  Removed.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  https://$idrac_ip/redfish/v1/UpdateService/FirmwareInventory"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Update firmware:"},{"line_number":125,"context_line":"  https://$idrac_ip/redfish/v1/UpdateService/Actions/Oem/DellUpdateService.Install"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Support for firmware management in ``redfish`` hardware type"},{"line_number":128,"context_line":"------------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_f87f7b13","line":125,"updated":"2018-11-20 16:38:13.000000000","message":"Not really a question for you, but why use an Oem extension here? This kind of defeats the purpose of redfish..","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  https://$idrac_ip/redfish/v1/UpdateService/FirmwareInventory"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Update firmware:"},{"line_number":125,"context_line":"  https://$idrac_ip/redfish/v1/UpdateService/Actions/Oem/DellUpdateService.Install"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Support for firmware management in ``redfish`` hardware type"},{"line_number":128,"context_line":"------------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_60889cc5","line":125,"in_reply_to":"3f79a3b5_f87f7b13","updated":"2019-04-05 20:21:30.000000000","message":"Since this spec was originally written, support has been added to the firmware for UpdateService.SimpleUpdate.  I\u0027ve updated the above line appropriately.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"------------------------------------------------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"There is currently no support for firmware update in sushy, and therefore no"},{"line_number":131,"context_line":"support for firmware update in the ``redfish`` hardware type."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_98768740","line":131,"updated":"2018-11-20 16:38:13.000000000","message":"https://review.openstack.org/#/c/613828/ ;)","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":128,"context_line":"------------------------------------------------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"There is currently no support for firmware update in sushy, and therefore no"},{"line_number":131,"context_line":"support for firmware update in the ``redfish`` hardware type."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_c06dd003","line":131,"in_reply_to":"3f79a3b5_98768740","updated":"2019-04-05 20:21:30.000000000","message":"Updated.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      \"interface\": \"management\","},{"line_number":148,"context_line":"      \"step\": \"update_firmware\","},{"line_number":149,"context_line":"      \"args\": {"},{"line_number":150,"context_line":"          \"firmware_update_mode\": \"drac\","},{"line_number":151,"context_line":"          \"firmware_images\":["},{"line_number":152,"context_line":"              {"},{"line_number":153,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_b8710349","line":150,"updated":"2018-11-20 16:38:13.000000000","message":"Do you really need this? iLO has two modes, in-band and out-of-band, you seem to have only one.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      \"interface\": \"management\","},{"line_number":148,"context_line":"      \"step\": \"update_firmware\","},{"line_number":149,"context_line":"      \"args\": {"},{"line_number":150,"context_line":"          \"firmware_update_mode\": \"drac\","},{"line_number":151,"context_line":"          \"firmware_images\":["},{"line_number":152,"context_line":"              {"},{"line_number":153,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_a041a465","line":150,"in_reply_to":"3f79a3b5_b8710349","updated":"2019-04-05 20:21:30.000000000","message":"Removed.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"One alternative is to add support for firmware update and OEM support to"},{"line_number":190,"context_line":"sushy, then implement firmware update support in the ``redfish`` hardware"},{"line_number":191,"context_line":"type."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":194,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_5870ef41","line":191,"updated":"2018-11-20 16:38:13.000000000","message":"FWIW both features have patches proposed.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"One alternative is to add support for firmware update and OEM support to"},{"line_number":190,"context_line":"sushy, then implement firmware update support in the ``redfish`` hardware"},{"line_number":191,"context_line":"type."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":194,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_f2d1be58","line":191,"in_reply_to":"3f79a3b5_5870ef41","updated":"2019-04-05 20:21:30.000000000","message":"Updated.","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b528e4bc3f90df882c370d373c5bf557aa9a6a9f","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"use_web_server_for_images"},{"line_number":279,"context_line":"    Indicates if images should be uploaded to the conductor web server."},{"line_number":280,"context_line":"swift_drac_container"},{"line_number":281,"context_line":"    The swift container for firmware images."},{"line_number":282,"context_line":"swift_object_expiry_timeout"},{"line_number":283,"context_line":"    The timeout in seconds after which the given swift URL should expire."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_786b6b53","line":280,"updated":"2018-11-20 16:38:13.000000000","message":"Instead of duplicating the iLO options, what if we create a new group [firmware_update] and move the iLO options there?","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b46bb9d1d8426845ce8febeefd9440bb2b4a7620","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"use_web_server_for_images"},{"line_number":279,"context_line":"    Indicates if images should be uploaded to the conductor web server."},{"line_number":280,"context_line":"swift_drac_container"},{"line_number":281,"context_line":"    The swift container for firmware images."},{"line_number":282,"context_line":"swift_object_expiry_timeout"},{"line_number":283,"context_line":"    The timeout in seconds after which the given swift URL should expire."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5fc1f717_123c8a91","line":280,"in_reply_to":"3f79a3b5_786b6b53","updated":"2019-04-05 20:21:30.000000000","message":"Done","commit_id":"65fae5e9dfe374f979e4cb84881fe7c0463edfef"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"317a41432dcd3807fc29495098240d52f98e5ec3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The proposed design is to mirror what was done in the ILO hardware type for"},{"line_number":77,"context_line":"firmware update. A new class will be created that inherits from the"},{"line_number":78,"context_line":"``redfish`` managment interface.  A manual clean step will be added to this"},{"line_number":79,"context_line":"class to initiate firmware update. The clean step will accept a list of"},{"line_number":80,"context_line":"dictionaries.  Each dictionary will represent a single firmware update, and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_849a5cc2","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":17},"updated":"2019-04-08 14:01:13.000000000","message":"should this be removed?","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"19ea562a674f11dd21ac6ec836b515629fbb6fdf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The proposed design is to mirror what was done in the ILO hardware type for"},{"line_number":77,"context_line":"firmware update. A new class will be created that inherits from the"},{"line_number":78,"context_line":"``redfish`` managment interface.  A manual clean step will be added to this"},{"line_number":79,"context_line":"class to initiate firmware update. The clean step will accept a list of"},{"line_number":80,"context_line":"dictionaries.  Each dictionary will represent a single firmware update, and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_c4ee24b4","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":17},"in_reply_to":"5fc1f717_849a5cc2","updated":"2019-04-08 14:34:04.000000000","message":"Done","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"317a41432dcd3807fc29495098240d52f98e5ec3","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"As an example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  \"clean_steps\": [{"},{"line_number":86,"context_line":"      \"interface\": \"management\","},{"line_number":87,"context_line":"      \"step\": \"update_firmware\","},{"line_number":88,"context_line":"      \"args\": {"},{"line_number":89,"context_line":"          \"firmware_images\":["},{"line_number":90,"context_line":"              {"},{"line_number":91,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":92,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":93,"context_line":"              },"},{"line_number":94,"context_line":"              {"},{"line_number":95,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":96,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":97,"context_line":"              }"},{"line_number":98,"context_line":"          ]"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"  }]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":103,"context_line":"the list."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_c44f0433","line":100,"range":{"start_line":85,"start_character":0,"end_line":100,"end_character":4},"updated":"2019-04-08 14:01:13.000000000","message":"Is there a dependency list? That is if the current version of FW is X then the new version must from this specific list. For example, you can not upgrade from X to X+3 without going thru X+1 and X+2 in order first.\nOr we assume that implementation figures that under the cover and goes thru these intermediate options under the cover with any reboots as needed?","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"ea1d8545c39c2106e543f5420b72a0f9aab7f7c3","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"As an example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  \"clean_steps\": [{"},{"line_number":86,"context_line":"      \"interface\": \"management\","},{"line_number":87,"context_line":"      \"step\": \"update_firmware\","},{"line_number":88,"context_line":"      \"args\": {"},{"line_number":89,"context_line":"          \"firmware_images\":["},{"line_number":90,"context_line":"              {"},{"line_number":91,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":92,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":93,"context_line":"              },"},{"line_number":94,"context_line":"              {"},{"line_number":95,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":96,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":97,"context_line":"              }"},{"line_number":98,"context_line":"          ]"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"  }]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":103,"context_line":"the list."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_0a474e1f","line":100,"range":{"start_line":85,"start_character":0,"end_line":100,"end_character":4},"in_reply_to":"5fc1f717_47a6b6c2","updated":"2019-04-08 18:01:12.000000000","message":"Done","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"19ea562a674f11dd21ac6ec836b515629fbb6fdf","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"As an example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  \"clean_steps\": [{"},{"line_number":86,"context_line":"      \"interface\": \"management\","},{"line_number":87,"context_line":"      \"step\": \"update_firmware\","},{"line_number":88,"context_line":"      \"args\": {"},{"line_number":89,"context_line":"          \"firmware_images\":["},{"line_number":90,"context_line":"              {"},{"line_number":91,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":92,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":93,"context_line":"              },"},{"line_number":94,"context_line":"              {"},{"line_number":95,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":96,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":97,"context_line":"              }"},{"line_number":98,"context_line":"          ]"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"  }]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":103,"context_line":"the list."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_e742423b","line":100,"range":{"start_line":85,"start_character":0,"end_line":100,"end_character":4},"in_reply_to":"5fc1f717_c44f0433","updated":"2019-04-08 14:34:04.000000000","message":"No, there is no dependency list.  We can\u0027t figure out what the dependencies are programmatically, and the user may not know what they are.  We assume that the update will correctly update from the currently installed version to the supplied version or that the the updater will error out if it is unable to perform the update.","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"75a420cb60e1359185b1f51d096ffce3f6a3e2cb","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"As an example::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  \"clean_steps\": [{"},{"line_number":86,"context_line":"      \"interface\": \"management\","},{"line_number":87,"context_line":"      \"step\": \"update_firmware\","},{"line_number":88,"context_line":"      \"args\": {"},{"line_number":89,"context_line":"          \"firmware_images\":["},{"line_number":90,"context_line":"              {"},{"line_number":91,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":92,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":93,"context_line":"              },"},{"line_number":94,"context_line":"              {"},{"line_number":95,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":96,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":97,"context_line":"              }"},{"line_number":98,"context_line":"          ]"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"  }]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":103,"context_line":"the list."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_47a6b6c2","line":100,"range":{"start_line":85,"start_character":0,"end_line":100,"end_character":4},"in_reply_to":"5fc1f717_e742423b","updated":"2019-04-08 14:47:14.000000000","message":"In this case it is probably worth to be specific about it.\nSpecifying specific FW version to install does not mean that it is feasible.\nImplementation is not required to figure out feasibility, only try to deploy new FW from currently deployed one,\nnor if specified FW is applicable to HW.","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"317a41432dcd3807fc29495098240d52f98e5ec3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":103,"context_line":"the list."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":106,"context_line":"and not apply the remaining updates. If a failure does occur midway through"},{"line_number":107,"context_line":"applying the updates, successful updates prior to the failed update will not"},{"line_number":108,"context_line":"be rolled back."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The cleaning step will be out-of-band. The firmware update cleaning step"},{"line_number":111,"context_line":"will use Redfish to perform the update.  The intent is to use the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_640f30e0","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":15},"updated":"2019-04-08 14:01:13.000000000","message":"like that.","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"317a41432dcd3807fc29495098240d52f98e5ec3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"Config options"},{"line_number":212,"context_line":"~~~~~~~~~~~~~~"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"A new [firmware_update] group will be defined in the ironic configuration"},{"line_number":215,"context_line":"file.  The following options  will be moved from the iLO section to that"},{"line_number":216,"context_line":"group."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"use_web_server_for_images"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_04cbcc52","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":5},"updated":"2019-04-08 14:01:13.000000000","message":"Do we need to specify what options for location of FW files will/can be supported? Or if there are some prerequisite to place FW files in specific locations?","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"19ea562a674f11dd21ac6ec836b515629fbb6fdf","unresolved":false,"context_lines":[{"line_number":211,"context_line":"Config options"},{"line_number":212,"context_line":"~~~~~~~~~~~~~~"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"A new [firmware_update] group will be defined in the ironic configuration"},{"line_number":215,"context_line":"file.  The following options  will be moved from the iLO section to that"},{"line_number":216,"context_line":"group."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"use_web_server_for_images"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_47a0f6f3","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":5},"in_reply_to":"5fc1f717_04cbcc52","updated":"2019-04-08 14:34:04.000000000","message":"The location of each firmware update file is specified in the \"url\" property supplied in the input to the firmware update cleaning step.","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"317a41432dcd3807fc29495098240d52f98e5ec3","unresolved":false,"context_lines":[{"line_number":212,"context_line":"~~~~~~~~~~~~~~"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"A new [firmware_update] group will be defined in the ironic configuration"},{"line_number":215,"context_line":"file.  The following options  will be moved from the iLO section to that"},{"line_number":216,"context_line":"group."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"use_web_server_for_images"},{"line_number":219,"context_line":"    Indicates if images should be uploaded to the conductor web server."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_848edc24","line":216,"range":{"start_line":215,"start_character":7,"end_line":216,"end_character":6},"updated":"2019-04-08 14:01:13.000000000","message":"suggest removing it","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"19ea562a674f11dd21ac6ec836b515629fbb6fdf","unresolved":false,"context_lines":[{"line_number":212,"context_line":"~~~~~~~~~~~~~~"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"A new [firmware_update] group will be defined in the ironic configuration"},{"line_number":215,"context_line":"file.  The following options  will be moved from the iLO section to that"},{"line_number":216,"context_line":"group."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"use_web_server_for_images"},{"line_number":219,"context_line":"    Indicates if images should be uploaded to the conductor web server."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5fc1f717_84133cb8","line":216,"range":{"start_line":215,"start_character":7,"end_line":216,"end_character":6},"in_reply_to":"5fc1f717_848edc24","updated":"2019-04-08 14:34:04.000000000","message":"I\u0027m not sure what you mean here.  Dmitry recommended that we factor common firmware update options out of the iLO and iDRAC drivers into a common group.","commit_id":"4dd5dddce7ad8a40a2a166d31c511118817e66f4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"A new class will be created that inherits from the ``redfish`` managment"},{"line_number":77,"context_line":"interface.  A manual clean step will be added to this class to initiate"},{"line_number":78,"context_line":"firmware update. The clean step will accept a list of dictionaries.  Each"},{"line_number":79,"context_line":"dictionary will represent a single firmware update, and will contain a URI"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_60757a98","line":76,"range":{"start_line":76,"start_character":51,"end_line":76,"end_character":72},"updated":"2019-04-10 22:25:46.000000000","message":"doing this makes me think we\u0027re going to finally need to have methods to enable standardized credential retrieval...","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"A new class will be created that inherits from the ``redfish`` managment"},{"line_number":77,"context_line":"interface.  A manual clean step will be added to this class to initiate"},{"line_number":78,"context_line":"firmware update. The clean step will accept a list of dictionaries.  Each"},{"line_number":79,"context_line":"dictionary will represent a single firmware update, and will contain a URI"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_021ca968","line":76,"range":{"start_line":76,"start_character":62,"end_line":76,"end_character":72},"updated":"2019-04-22 16:46:17.000000000","message":"managment -\u003e management","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"A new class will be created that inherits from the ``redfish`` managment"},{"line_number":77,"context_line":"interface.  A manual clean step will be added to this class to initiate"},{"line_number":78,"context_line":"firmware update. The clean step will accept a list of dictionaries.  Each"},{"line_number":79,"context_line":"dictionary will represent a single firmware update, and will contain a URI"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_9e88d8c6","line":76,"range":{"start_line":76,"start_character":62,"end_line":76,"end_character":72},"in_reply_to":"ffb9cba7_021ca968","updated":"2019-04-23 21:29:35.000000000","message":"Done","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          \"firmware_images\":["},{"line_number":89,"context_line":"              {"},{"line_number":90,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_206f72c6","line":91,"updated":"2019-04-10 22:25:46.000000000","message":"What does dell publish checksum wise for these sorts of files? I think we should use that, but MD5 is generally being avoided.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          \"firmware_images\":["},{"line_number":89,"context_line":"              {"},{"line_number":90,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_deb73086","line":91,"in_reply_to":"3fce034c_206f72c6","updated":"2019-04-23 21:29:35.000000000","message":"Dell publishes MD5, SHA1, and SHA-256.  I\u0027ve changed the md5 references to SHA1.  Please leave another comment if you feel it should be SHA-256.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          \"firmware_images\":["},{"line_number":89,"context_line":"              {"},{"line_number":90,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_023589da","line":91,"in_reply_to":"3fce034c_206f72c6","updated":"2019-04-22 16:46:17.000000000","message":"Done","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_207d326e","line":93,"updated":"2019-04-10 22:25:46.000000000","message":"What about ordering?","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                  \"url\": \"file:///firmware_images/idrac/9/iDRAC-with-Lifecycle-Controller_Firmware_K877V_WN64_3.21.23.22_A00.exe\","},{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_1e63881c","line":93,"in_reply_to":"3fce034c_207d326e","updated":"2019-04-23 21:29:35.000000000","message":"The firmware updates will be applied in the order that they are in the list.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"},{"line_number":97,"context_line":"          ]"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_e0964a95","line":94,"updated":"2019-04-10 22:25:46.000000000","message":"is there no indicator of type of firmware? Does that matter at all with the idrc?","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"},{"line_number":97,"context_line":"          ]"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_c24c5178","line":94,"in_reply_to":"3fce034c_e0964a95","updated":"2019-04-22 16:46:17.000000000","message":"Done","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"},{"line_number":97,"context_line":"          ]"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_be735ce7","line":94,"in_reply_to":"3fce034c_e0964a95","updated":"2019-04-23 21:29:35.000000000","message":"No, there\u0027s no indicator of firmware type.  The iDRAC allows you to upload the .exe file, and it applies it automatically to the applicable hardware.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"},{"line_number":97,"context_line":"          ]"},{"line_number":98,"context_line":"      }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_a0b7e23a","line":95,"updated":"2019-04-10 22:25:46.000000000","message":"Are these just different versions or??? I guess I\u0027m missing on the intent of the second file.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"              },"},{"line_number":93,"context_line":"              {"},{"line_number":94,"context_line":"                  \"url\": \"swift://firmware_container/iDRAC-with-Lifecycle-Controller_Firmware_2GFC7_WN64_2.60.60.60_A00.exe\","},{"line_number":95,"context_line":"                  \"checksum\": \"\u003cmd5-checksum-of-this-file\u003e\""},{"line_number":96,"context_line":"              }"},{"line_number":97,"context_line":"          ]"},{"line_number":98,"context_line":"      }"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_de13b065","line":95,"in_reply_to":"3fce034c_a0b7e23a","updated":"2019-04-23 21:29:35.000000000","message":"The second file was just meant as an example of what an entry would look like that referred to a firmware update file in swift.  I\u0027ve changed the filename to an actual BIOS firmware update for 14G and updated the lifecycle controller filename above to the corresponding lifecycle controller firmware update filename for 14G as well.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":102,"context_line":"the list."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_20f21208","line":102,"updated":"2019-04-10 22:25:46.000000000","message":"This seems like a very particular detail which while makes sense, I\u0027m a little worried about documentation wise. I guess I\u0027m just being overly cautious.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The implementation will apply the firmware updates in the order specified in"},{"line_number":102,"context_line":"the list."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_b10f0d2d","line":102,"in_reply_to":"3fce034c_20f21208","updated":"2019-04-23 21:29:35.000000000","message":"Reworded a little.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"},{"line_number":106,"context_line":"installed on.  The implementation will rely on the firmware update failing"},{"line_number":107,"context_line":"gracefully in these cases."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":110,"context_line":"and not apply the remaining updates. If a failure does occur midway through"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_42ae21e8","line":107,"range":{"start_line":106,"start_character":15,"end_line":107,"end_character":25},"updated":"2019-04-22 16:46:17.000000000","message":"Is implementation going to restore to latest successful FW installed or leave idrac in error?","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"},{"line_number":106,"context_line":"installed on.  The implementation will rely on the firmware update failing"},{"line_number":107,"context_line":"gracefully in these cases."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":110,"context_line":"and not apply the remaining updates. If a failure does occur midway through"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_0094b68a","line":107,"updated":"2019-04-10 22:25:46.000000000","message":"do the updates contain dependency tracking?","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"},{"line_number":106,"context_line":"installed on.  The implementation will rely on the firmware update failing"},{"line_number":107,"context_line":"gracefully in these cases."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":110,"context_line":"and not apply the remaining updates. If a failure does occur midway through"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_6266c5f0","line":107,"in_reply_to":"3fce034c_0094b68a","updated":"2019-04-22 16:46:17.000000000","message":"Done","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"},{"line_number":106,"context_line":"installed on.  The implementation will rely on the firmware update failing"},{"line_number":107,"context_line":"gracefully in these cases."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":110,"context_line":"and not apply the remaining updates. If a failure does occur midway through"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_b1386dd3","line":107,"in_reply_to":"3fce034c_0094b68a","updated":"2019-04-23 21:29:35.000000000","message":"I don\u0027t believe so.  There are times when it is recommended that updates be applied in a particular order, but this is not checked or enforced by the updates themselves.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"The implementation will have no knowledge of dependencies of the supplied"},{"line_number":105,"context_line":"firmware, or if the firmware is applicable to the hardware that it is being"},{"line_number":106,"context_line":"installed on.  The implementation will rely on the firmware update failing"},{"line_number":107,"context_line":"gracefully in these cases."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The updater will fail fast so that if one update fails, it will abort"},{"line_number":110,"context_line":"and not apply the remaining updates. If a failure does occur midway through"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_d1564107","line":107,"range":{"start_line":106,"start_character":15,"end_line":107,"end_character":25},"in_reply_to":"ffb9cba7_42ae21e8","updated":"2019-04-23 21:29:35.000000000","message":"If an update fails to apply, the old firmware is left in place.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3385e713623ddc2a04546fef8c3127b2fa33b1bd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"One alternative is to add support for firmware update to the ``redfish``"},{"line_number":132,"context_line":"hardware type.  From the DMTF specs, it appears that firmware update is"},{"line_number":133,"context_line":"still a work in progress.  As a result, it\u0027s difficult to tell if the"},{"line_number":134,"context_line":"Dell EMC implementation is fully compliant or not."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":137,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_b6acb38c","line":134,"updated":"2019-04-16 10:24:18.000000000","message":"Could you figure that our please before we approve the spec? If you are compatible, there is no point in making this work iDrac-specific.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"One alternative is to add support for firmware update to the ``redfish``"},{"line_number":132,"context_line":"hardware type.  From the DMTF specs, it appears that firmware update is"},{"line_number":133,"context_line":"still a work in progress.  As a result, it\u0027s difficult to tell if the"},{"line_number":134,"context_line":"Dell EMC implementation is fully compliant or not."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":137,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_117619a6","line":134,"in_reply_to":"3fce034c_b6acb38c","updated":"2019-04-23 21:29:35.000000000","message":"According to a firmware expert, Dell\u0027s implementation of firmware update is fully compliant with the DMTF spec.  I\u0027ve updated the text appropriately.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"One alternative is to add support for firmware update to the ``redfish``"},{"line_number":132,"context_line":"hardware type.  From the DMTF specs, it appears that firmware update is"},{"line_number":133,"context_line":"still a work in progress.  As a result, it\u0027s difficult to tell if the"},{"line_number":134,"context_line":"Dell EMC implementation is fully compliant or not."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":137,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_a2d03d52","line":134,"in_reply_to":"3fce034c_b6acb38c","updated":"2019-04-22 16:46:17.000000000","message":"good point.\nWe need to lock it before we start implementation.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"43a6722214fa319850ddf88290f2e117237ca7d9","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"use_web_server_for_images"},{"line_number":223,"context_line":"    Indicates if images should be uploaded to the conductor web server."},{"line_number":224,"context_line":"swift_drac_container"},{"line_number":225,"context_line":"    The swift container for firmware images."},{"line_number":226,"context_line":"swift_object_expiry_timeout"},{"line_number":227,"context_line":"    The timeout in seconds after which the given swift URL should expire."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_60d1fa57","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":20},"updated":"2019-04-10 22:25:46.000000000","message":"This is an ilo setting?","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3385e713623ddc2a04546fef8c3127b2fa33b1bd","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"use_web_server_for_images"},{"line_number":223,"context_line":"    Indicates if images should be uploaded to the conductor web server."},{"line_number":224,"context_line":"swift_drac_container"},{"line_number":225,"context_line":"    The swift container for firmware images."},{"line_number":226,"context_line":"swift_object_expiry_timeout"},{"line_number":227,"context_line":"    The timeout in seconds after which the given swift URL should expire."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3fce034c_d6a7ffa6","line":224,"updated":"2019-04-16 10:24:18.000000000","message":"Yeah, but see above: they\u0027re planning to move them.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"use_web_server_for_images"},{"line_number":223,"context_line":"    Indicates if images should be uploaded to the conductor web server."},{"line_number":224,"context_line":"swift_drac_container"},{"line_number":225,"context_line":"    The swift container for firmware images."},{"line_number":226,"context_line":"swift_object_expiry_timeout"},{"line_number":227,"context_line":"    The timeout in seconds after which the given swift URL should expire."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_5191f198","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":20},"in_reply_to":"3fce034c_60d1fa57","updated":"2019-04-23 21:29:35.000000000","message":"The ilo driver uses the setting \"swift_ilo_container\".  I\u0027ve changed the name of the setting above to \"swift_container\" so it is not driver specific.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"use_web_server_for_images"},{"line_number":223,"context_line":"    Indicates if images should be uploaded to the conductor web server."},{"line_number":224,"context_line":"swift_drac_container"},{"line_number":225,"context_line":"    The swift container for firmware images."},{"line_number":226,"context_line":"swift_object_expiry_timeout"},{"line_number":227,"context_line":"    The timeout in seconds after which the given swift URL should expire."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_2251add9","line":224,"in_reply_to":"3fce034c_d6a7ffa6","updated":"2019-04-22 16:46:17.000000000","message":"Done","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"794cf5526865eaa7bd192451c84bf445ddf979a1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":261,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"If a firmware update is attempted on a Dell EMC server that does not"},{"line_number":264,"context_line":"support the Redfish DellUpdateService firmware upgrade command, then"},{"line_number":265,"context_line":"cleaning will be aborted and an appropriate error message logged."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Documentation Impact"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_a22cbd47","line":265,"range":{"start_line":263,"start_character":0,"end_line":265,"end_character":65},"updated":"2019-04-22 16:46:17.000000000","message":"That suggest that decision was made to go with redfish implementation. If yes, then the rest of spec should be updated with it.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"84f6b1f6fde25b0c224492d9bef5ddb6cdf33af0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":261,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"If a firmware update is attempted on a Dell EMC server that does not"},{"line_number":264,"context_line":"support the Redfish DellUpdateService firmware upgrade command, then"},{"line_number":265,"context_line":"cleaning will be aborted and an appropriate error message logged."},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Documentation Impact"},{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffb9cba7_1184d95d","line":265,"range":{"start_line":263,"start_character":0,"end_line":265,"end_character":65},"in_reply_to":"ffb9cba7_a22cbd47","updated":"2019-04-23 21:29:35.000000000","message":"Changed DellUpdateService to the standard redfish call.\nYes, the decision was made to go with the redfish implementation.  Changed the text to clearly state this in the \"Proposed change\" section.","commit_id":"7db3de32374d062b1189ae7ff1ecbbdcbdad6873"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e502a6d8d5d7f25c9ed20160629d43970f31f1b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The decision has been made to go with a ``redfish`` implementation."},{"line_number":77,"context_line":"A new class will be created that inherits from the ``redfish`` management"},{"line_number":78,"context_line":"interface.  A manual clean step will be added to this class to initiate"},{"line_number":79,"context_line":"firmware update. The clean step will accept a list of dictionaries.  Each"},{"line_number":80,"context_line":"dictionary will represent a single firmware update, and will contain a URI"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ffb9cba7_85d8231e","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":27},"updated":"2019-04-29 14:56:09.000000000","message":"For IDRACHardware?","commit_id":"27933fc18e4b25e196bd3d58549371aa50b68d7a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1fae16f0e4e5956f5bf95820ec8db6fc0d8edeee","unresolved":false,"context_lines":[{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"The decision has been made to go with a ``redfish`` implementation."},{"line_number":77,"context_line":"A new class will be created that inherits from the ``redfish`` management"},{"line_number":78,"context_line":"interface.  A manual clean step will be added to this class to initiate"},{"line_number":79,"context_line":"firmware update. The clean step will accept a list of dictionaries.  Each"},{"line_number":80,"context_line":"dictionary will represent a single firmware update, and will contain a URI"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dfbec78f_d3111c06","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":27},"in_reply_to":"ffb9cba7_85d8231e","updated":"2019-05-14 18:14:41.000000000","message":"Updated to specify adding the cleaning step to the RedfishManagement class instead of creating a new class.","commit_id":"27933fc18e4b25e196bd3d58549371aa50b68d7a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"28d11cb0b0892b58bc0deb5a8980b08e6e2added","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"One alternative is to add support for firmware update to the ``redfish``"},{"line_number":132,"context_line":"hardware type.  The Dell EMC \u0027\u0027redfish\u0027\u0027 implementation of firmware update"},{"line_number":133,"context_line":"is fully compliant with the DMTF spec."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":136,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ffb9cba7_d1a10896","line":133,"updated":"2019-04-29 04:04:07.000000000","message":"Then why not do this?","commit_id":"27933fc18e4b25e196bd3d58549371aa50b68d7a"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1fae16f0e4e5956f5bf95820ec8db6fc0d8edeee","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"One alternative is to add support for firmware update to the ``redfish``"},{"line_number":132,"context_line":"hardware type.  The Dell EMC \u0027\u0027redfish\u0027\u0027 implementation of firmware update"},{"line_number":133,"context_line":"is fully compliant with the DMTF spec."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":136,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":13,"id":"dfbec78f_93a16497","line":133,"in_reply_to":"ffb9cba7_65c5eff0","updated":"2019-05-14 18:14:41.000000000","message":"I\u0027ve updated the spec to indicate that the firmware update cleaning step will be added to the RedfishManagement class.  This means that an iDRAC hardware type user will have to select the Redfish implementation of the ManagementInterface for the IDRACHardware type to use firmware update.","commit_id":"27933fc18e4b25e196bd3d58549371aa50b68d7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e502a6d8d5d7f25c9ed20160629d43970f31f1b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"One alternative is to add support for firmware update to the ``redfish``"},{"line_number":132,"context_line":"hardware type.  The Dell EMC \u0027\u0027redfish\u0027\u0027 implementation of firmware update"},{"line_number":133,"context_line":"is fully compliant with the DMTF spec."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Another alternative would be to implement firmware update using ``WSMAN``."},{"line_number":136,"context_line":"Because ``WSMAN`` will eventually be deprecated in favor of Redfish, it"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ffb9cba7_65c5eff0","line":133,"in_reply_to":"ffb9cba7_d1a10896","updated":"2019-04-29 14:56:09.000000000","message":"In that case only for firmware update, one will have to use \u0027redfish\u0027 hardware type. But idrac has hardware specific features like OOB RAID for which one needs to use \u0027idrac\u0027 hardware type. Isn\u0027t it so?","commit_id":"27933fc18e4b25e196bd3d58549371aa50b68d7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3479e05a6a7f96b0647d12ac2a3dc305f9ca441a","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"None"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Other deployer impact"},{"line_number":209,"context_line":"---------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Config options"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dfbec78f_0981aec3","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":21},"updated":"2019-05-14 05:18:45.000000000","message":"One needs to configure ironic node with \u0027redfish\u0027 management interface and need to set redfish credentials in the node\u0027s driver_info.","commit_id":"ef0e1f0acbfc484010ada3020ef5f6615198df1e"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1fae16f0e4e5956f5bf95820ec8db6fc0d8edeee","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"None"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Other deployer impact"},{"line_number":209,"context_line":"---------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Config options"}],"source_content_type":"text/x-rst","patch_set":14,"id":"dfbec78f_ef2bde91","line":208,"range":{"start_line":208,"start_character":0,"end_line":208,"end_character":21},"in_reply_to":"dfbec78f_0981aec3","updated":"2019-05-14 18:14:41.000000000","message":"Done","commit_id":"ef0e1f0acbfc484010ada3020ef5f6615198df1e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"45d49907bb80f847da4408990e385076a4b7424a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"~~~~~~~~~~~~~~"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"A new [firmware_update] group will be defined in the ironic configuration"},{"line_number":218,"context_line":"file.  The following options  will be moved from the iLO section to that"},{"line_number":219,"context_line":"group."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"use_web_server_for_images"}],"source_content_type":"text/x-rst","patch_set":15,"id":"bfb3d3c7_8aa887db","line":218,"updated":"2019-05-21 17:19:01.000000000","message":"One minor note, we\u0027ll need to broadcast this loudly in the upgrade notes.","commit_id":"ec21b6f4d1731b025ad1fdb22092ac21fa361b64"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2612f6abd7f9a9716d4727cbc73938b1539d3eee","unresolved":false,"context_lines":[{"line_number":243,"context_line":"----------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"* Ironic RedfishManagement changes to add a cleaning step"},{"line_number":246,"context_line":"* python-dracclient changes to implement firmware update"},{"line_number":247,"context_line":"* Ironic iDRAC hardware type changes to add support for the Redfish management"},{"line_number":248,"context_line":"  interface"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bfb3d3c7_2ce4db3b","line":246,"updated":"2019-05-24 09:44:45.000000000","message":"++ I hope this wont\u0027 be needed.","commit_id":"ec21b6f4d1731b025ad1fdb22092ac21fa361b64"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6e0e21115c63255b3d51bfaa011e29e4f56ed451","unresolved":false,"context_lines":[{"line_number":243,"context_line":"----------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"* Ironic RedfishManagement changes to add a cleaning step"},{"line_number":246,"context_line":"* python-dracclient changes to implement firmware update"},{"line_number":247,"context_line":"* Ironic iDRAC hardware type changes to add support for the Redfish management"},{"line_number":248,"context_line":"  interface"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"dfbec78f_ed6af817","line":246,"range":{"start_line":246,"start_character":2,"end_line":246,"end_character":19},"updated":"2019-05-15 14:57:06.000000000","message":"Did you mean sushy?","commit_id":"ec21b6f4d1731b025ad1fdb22092ac21fa361b64"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"45d49907bb80f847da4408990e385076a4b7424a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"----------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"* Ironic RedfishManagement changes to add a cleaning step"},{"line_number":246,"context_line":"* python-dracclient changes to implement firmware update"},{"line_number":247,"context_line":"* Ironic iDRAC hardware type changes to add support for the Redfish management"},{"line_number":248,"context_line":"  interface"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"bfb3d3c7_ca9e7fb7","line":246,"range":{"start_line":246,"start_character":2,"end_line":246,"end_character":19},"in_reply_to":"dfbec78f_5e316ca2","updated":"2019-05-21 17:19:01.000000000","message":"I concur with this logic, although if it is minor, we can make appropriate decisions where necessary. I guess if this is also the case, then we\u0027ll end up with code crossing interfaces, but as long as we\u0027re not forcing raw redfish users to load python-dracclient , I suspect we\u0027re in good shape. We can always have a idrac specific interface which uses an underlying piece of functionality in the redfish interface much as existing interfaces for other drivers behave for things like virtual media booting.\n\nI also think this is one of those \"when we reach the bridge, we will know if we need to cross items\".","commit_id":"ec21b6f4d1731b025ad1fdb22092ac21fa361b64"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"9be196dc8bb9751e72f71bce276629631d45a2f9","unresolved":false,"context_lines":[{"line_number":243,"context_line":"----------"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"* Ironic RedfishManagement changes to add a cleaning step"},{"line_number":246,"context_line":"* python-dracclient changes to implement firmware update"},{"line_number":247,"context_line":"* Ironic iDRAC hardware type changes to add support for the Redfish management"},{"line_number":248,"context_line":"  interface"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"dfbec78f_5e316ca2","line":246,"range":{"start_line":246,"start_character":2,"end_line":246,"end_character":19},"in_reply_to":"dfbec78f_ed6af817","updated":"2019-05-17 18:05:31.000000000","message":"No.  Firmware update has been implemented in sushy already.  I left the above line in because if we find that there are Dell specific changes that we will need to make, we will need to put those somewhere, and currently the best place is python-dracclient.","commit_id":"ec21b6f4d1731b025ad1fdb22092ac21fa361b64"}]}