)]}'
{"specs/approved/ilo-oob-disk-erase.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"268d44bbe4a5628422aee0cb887649700b898e57","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In the current scenario where disk-erase on HPE Proliant servers is"},{"line_number":20,"context_line":"done only via inband cleaning, iLO5 based HPE Proliant Gen10 servers provide"},{"line_number":21,"context_line":"support to perform out-of-band disk-erase which was not there in Gen9"},{"line_number":22,"context_line":"and below servers. However, the disk-erase will take into effect only when"},{"line_number":23,"context_line":"the system reaches POST stage. Hence disk-erase needs to be accompanied by"},{"line_number":24,"context_line":"a reboot."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_c087150f","line":22,"range":{"start_line":22,"start_character":28,"end_line":22,"end_character":64},"updated":"2019-01-17 08:40:52.000000000","message":"disk erase request would be accepted by iLO only when system boot completes POST.","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"56409733e1d50747052be40e47e4d3bacfeaac4f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In the current scenario where disk-erase on HPE Proliant servers is"},{"line_number":20,"context_line":"done only via inband cleaning, iLO5 based HPE Proliant Gen10 servers provide"},{"line_number":21,"context_line":"support to perform out-of-band disk-erase which was not there in Gen9"},{"line_number":22,"context_line":"and below servers. However, the disk-erase will take into effect only when"},{"line_number":23,"context_line":"the system reaches POST stage. Hence disk-erase needs to be accompanied by"},{"line_number":24,"context_line":"a reboot."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_6cf422d0","line":22,"range":{"start_line":22,"start_character":28,"end_line":22,"end_character":64},"in_reply_to":"bfdaf3ff_c087150f","updated":"2019-01-21 07:35:25.000000000","message":"Done","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"268d44bbe4a5628422aee0cb887649700b898e57","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This spec proposes to implement out-of-band disk-erase functionality in"},{"line_number":30,"context_line":"hardware type ``ilo5`` under new management interface ``Ilo5Management``"},{"line_number":31,"context_line":"which would be inherited from ``ilo`` hardware type\u0027s management"},{"line_number":32,"context_line":"interface ``IloManagement``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_a028d133","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":68},"updated":"2019-01-17 08:40:52.000000000","message":"Its a clean-step right?","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"56409733e1d50747052be40e47e4d3bacfeaac4f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This spec proposes to implement out-of-band disk-erase functionality in"},{"line_number":30,"context_line":"hardware type ``ilo5`` under new management interface ``Ilo5Management``"},{"line_number":31,"context_line":"which would be inherited from ``ilo`` hardware type\u0027s management"},{"line_number":32,"context_line":"interface ``IloManagement``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_ec31f2a3","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":68},"in_reply_to":"bfdaf3ff_a028d133","updated":"2019-01-21 07:35:25.000000000","message":"Done","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"268d44bbe4a5628422aee0cb887649700b898e57","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* The following would be the composition of the new management interface"},{"line_number":37,"context_line":"  ``Ilo5Management``:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  + ``perform_disk_erase`` - This will erase all disks on the baremetal node."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - Since a reboot is required for changes to get reflected, this function"},{"line_number":42,"context_line":"      will be decorated with additional argument `reboot_required` with"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_c012b509","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":24},"updated":"2019-01-17 08:40:52.000000000","message":"Can we override the existing clean_step \u0027erase_devices\u0027 in \u0027deploy \u0027 interface? It would be helpful to user to use same clean step. In case of \u0027ilo5\u0027 hardware tupe it would perform the OOB operation. See https://github.com/openstack/ironic/blob/def2fc08aa0511a556c8b30a19dd31ad9cac2c07/doc/source/admin/cleaning.rst","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"56409733e1d50747052be40e47e4d3bacfeaac4f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* The following would be the composition of the new management interface"},{"line_number":37,"context_line":"  ``Ilo5Management``:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  + ``perform_disk_erase`` - This will erase all disks on the baremetal node."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - Since a reboot is required for changes to get reflected, this function"},{"line_number":42,"context_line":"      will be decorated with additional argument `reboot_required` with"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_0c779604","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":24},"in_reply_to":"bfdaf3ff_c012b509","updated":"2019-01-21 07:35:25.000000000","message":"Done","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"268d44bbe4a5628422aee0cb887649700b898e57","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  + ``perform_disk_erase`` - This will erase all disks on the baremetal node."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - Since a reboot is required for changes to get reflected, this function"},{"line_number":42,"context_line":"      will be decorated with additional argument `reboot_required` with"},{"line_number":43,"context_line":"      value set to `True`."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfdaf3ff_20f141ce","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":62},"updated":"2019-01-17 08:40:52.000000000","message":"The reboot is required to initiate the disk erase. The actual disk erase operation would take time based on disk type and size. It needs to be continuously monitored for the completion status. Better to add a psedo-code here elaborating these aspects of the disk erase functionality.","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"56409733e1d50747052be40e47e4d3bacfeaac4f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  + ``perform_disk_erase`` - This will erase all disks on the baremetal node."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - Since a reboot is required for changes to get reflected, this function"},{"line_number":42,"context_line":"      will be decorated with additional argument `reboot_required` with"},{"line_number":43,"context_line":"      value set to `True`."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_4752c469","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":62},"in_reply_to":"bfdaf3ff_20f141ce","updated":"2019-01-21 07:35:25.000000000","message":"Done","commit_id":"af00b574735fbe9d2cbf1de37e545a6efd095089"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Out-of-band disk-erase for Gen10 and above HPE Proliant Servers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_62db927b","line":7,"range":{"start_line":7,"start_character":63,"end_line":7,"end_character":71},"updated":"2019-02-01 14:34:09.000000000","message":"nit: redundant","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In the current scenario where disk-erase on HPE Proliant servers is"},{"line_number":20,"context_line":"done only via inband cleaning, iLO5 based HPE Proliant Gen10 servers provide"},{"line_number":21,"context_line":"support to perform out-of-band disk-erase which was not there in Gen9"},{"line_number":22,"context_line":"and below servers. However, disk-erase request would be accepted by iLO only"},{"line_number":23,"context_line":"when system boot completes POST. Hence disk-erase needs to be accompanied by"},{"line_number":24,"context_line":"a reboot."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_4b1fb8b6","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":9},"updated":"2019-02-01 14:34:09.000000000","message":"s/below/older/","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"In the current scenario where disk-erase on HPE Proliant servers is"},{"line_number":20,"context_line":"done only via inband cleaning, iLO5 based HPE Proliant Gen10 servers provide"},{"line_number":21,"context_line":"support to perform out-of-band disk-erase which was not there in Gen9"},{"line_number":22,"context_line":"and below servers. However, disk-erase request would be accepted by iLO only"},{"line_number":23,"context_line":"when system boot completes POST. Hence disk-erase needs to be accompanied by"},{"line_number":24,"context_line":"a reboot."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_20b25d95","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":9},"in_reply_to":"9fdfeff1_4b1fb8b6","updated":"2019-02-14 10:03:16.000000000","message":"Done","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This spec proposes to implement out-of-band disk-erase clean_step in hardware"},{"line_number":30,"context_line":"type ``ilo5`` under new deploy interface ``Ilo5Deploy`` which would be"},{"line_number":31,"context_line":"inherited from existing deploy interface ``AgentDeploy``."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_0252c6de","line":30,"range":{"start_line":30,"start_character":43,"end_line":30,"end_character":53},"updated":"2019-02-01 14:34:09.000000000","message":"Please consider using name Ilo5AgentDeploy as there is IscsiDeploy. And the deploy name could be ilo5-agent for avoiding confusion.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This spec proposes to implement out-of-band disk-erase clean_step in hardware"},{"line_number":30,"context_line":"type ``ilo5`` under new deploy interface ``Ilo5Deploy`` which would be"},{"line_number":31,"context_line":"inherited from existing deploy interface ``AgentDeploy``."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"List of changes required:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_2077bdd6","line":30,"range":{"start_line":30,"start_character":43,"end_line":30,"end_character":53},"in_reply_to":"9fdfeff1_0252c6de","updated":"2019-02-14 10:03:16.000000000","message":"its not specific to agent","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - This will be override from clean_step `erase_devices` from deploy"},{"line_number":41,"context_line":"      interface ``AgentDeploy``."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    - `erase_devices` will call proliantutils library method `erase_devices`"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_dcd8f01e","line":40,"range":{"start_line":40,"start_character":19,"end_line":40,"end_character":27},"updated":"2019-02-01 14:34:09.000000000","message":"s/override/overridden/","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - This will be override from clean_step `erase_devices` from deploy"},{"line_number":41,"context_line":"      interface ``AgentDeploy``."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    - `erase_devices` will call proliantutils library method `erase_devices`"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_402201bb","line":40,"range":{"start_line":40,"start_character":19,"end_line":40,"end_character":27},"in_reply_to":"9fdfeff1_dcd8f01e","updated":"2019-02-14 10:03:16.000000000","message":"Done","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6bfb85fb477d509b0adecc7ccebd59ef3c7b985b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      to perform the operation in iLO."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":47,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - To monitor status of disk-erase will call proliantutils library method"},{"line_number":50,"context_line":"      `get_erase_decvices_status` and update the ironic about."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_b4270a65","line":47,"updated":"2019-01-22 01:21:46.000000000","message":"Is this actually wiping the disks, or just doing a key rotation, or wiping virtual disks and creating new ones?\n\nI\u0027m a little worried about overriding erase devices because of the possibility of non BMC-managed disk drives being present in any server hardware. \n\nI\u0027d kind of prefer that we consider another option to just overriding erase_devices.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      to perform the operation in iLO."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":47,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - To monitor status of disk-erase will call proliantutils library method"},{"line_number":50,"context_line":"      `get_erase_decvices_status` and update the ironic about."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_3b104c4e","line":47,"in_reply_to":"9fdfeff1_b4270a65","updated":"2019-02-14 10:03:16.000000000","message":"Like shiv explained, it will do the sanitize disk erase with different patterns (block, zero, overwrite) based on disk type.\n\nWe can use the hybrid solution for that case. If non BMC-managed disk present we can fall back to inband, after doing out of band.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"64b6c6242fb64439b470b3cebf0cac95ef77c046","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      to perform the operation in iLO."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":47,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - To monitor status of disk-erase will call proliantutils library method"},{"line_number":50,"context_line":"      `get_erase_decvices_status` and update the ironic about."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_fa833955","line":47,"in_reply_to":"9fdfeff1_b4270a65","updated":"2019-02-01 09:51:24.000000000","message":"The erase devices would do following:-\n1. For HDD it would use \u0027Sanitize Overwrite\u0027 option.\n\u0027Sanitize Overwrite\u0027 option fills every physical sector of\nthe drive with a pattern. \n2. For SSD disks it would use \u0027Sanitize Block Erase\u0027 option\n\u0027Sanitize Block Erase\u0027 option the blocks on the\ndrive to a vendor-specific value, removing all user data.\n3. Use \u0027One-pass erase\u0027 option for the disks where above options are not supported.\n\u0027One-pass erase\u0027 option writes zeroes on the drive.\n[1] https://developer.hpe.com/blog/storage-management-with-redfish\n[2] SSACLI documentation, see \u0027Options for erasing drives\u0027 https://support.hpe.com/hpsc/doc/public/display?docId\u003dc03909334\n\nThe OOB step would perform the operation similar to the one done by inband  ProliantHardwareManager [3] wherein \u0027ssacli\u0027 utility is used. Only difference is that in Gen10 this operation is supported via Redfish OEM extensions. Also current inband implementation disk_erase in iLO drivers do not differentiate between disk types and uses \u0027one-pass erase\u0027 option that writes zeroes on the drives. \n[3] https://github.com/openstack/proliantutils/blob/master/proliantutils/ipa_hw_manager/hardware_manager.py#L91-L110\n\nThe proposed clean step \u0027erase_devices\u0027 would actually complement the inband \u0027erase_devices\u0027. The OOB disk erase can be performed only on those devices that are being managed by smart storage controllers and are not currently used in any logical volumes. These disks are not visible  to operating system as they are behind smart storage controller. Ex: If one creates a RAID volume, used it, deleted the RAID volume and then performs erase_device operation then OOB erase_device would be useful.\nUpon erasing the raw disks available with storage controllers, it would invoke inband \u0027erase_devices\u0027 (IPA implementation) to ensure that any disks that are part of logical volumes or not visible from BMC but visible to operating system are also erased.\nThe idea behind this clean step is to do avoid dependency \u0027ssacli\u0027 utility in the ramdisk. We have received complains from various cloud software providers that they cannot bundle \u0027ssacli\u0027 utility in their default ramdisk as its a licensed product. This clean step would address that issue.\n\nRegarding using different name for this step, If we were to use any other name to perform this task, the user/admin would have to aware of the underlying server model to invoke the new clean step. It would cause inconvenience to the users of this clean step.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":47,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - To monitor status of disk-erase will call proliantutils library method"},{"line_number":50,"context_line":"      `get_erase_decvices_status` and update the ironic about."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  .. code-block:: python"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_fcecd4bb","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":62},"updated":"2019-02-01 14:34:09.000000000","message":"I think I understand this, but it seems not to be well expressed.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":47,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - To monitor status of disk-erase will call proliantutils library method"},{"line_number":50,"context_line":"      `get_erase_decvices_status` and update the ironic about."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  .. code-block:: python"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_5b53d016","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":62},"in_reply_to":"9fdfeff1_fcecd4bb","updated":"2019-02-14 10:03:16.000000000","message":"Done","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6bfb85fb477d509b0adecc7ccebd59ef3c7b985b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  .. code-block:: python"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    class Ilo5Deploy(agent.AgentDeploy):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      @base.clean_step(priority\u003d0, abortable\u003dFalse)"},{"line_number":57,"context_line":"      def erase_devices(self, task):"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_7421a24d","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":38},"updated":"2019-01-22 01:21:46.000000000","message":"Is there any way we can avoid a vendor specific deployment interface which overrides the other interfaces?","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  .. code-block:: python"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    class Ilo5Deploy(agent.AgentDeploy):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      @base.clean_step(priority\u003d0, abortable\u003dFalse)"},{"line_number":57,"context_line":"      def erase_devices(self, task):"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_1cd2f828","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":38},"in_reply_to":"9fdfeff1_7421a24d","updated":"2019-02-01 14:34:09.000000000","message":"++","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6bfb85fb477d509b0adecc7ccebd59ef3c7b985b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"One can perform in-band disk-erase to achieve the same result. However,"},{"line_number":93,"context_line":"The ramdisk to be used in such case should have proliant-tools element"},{"line_number":94,"context_line":"that bundles \u0027ssacli\u0027 utility required for disk-erase operations as"},{"line_number":95,"context_line":"part of the image."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Data model impact"},{"line_number":98,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_341b1a1c","line":95,"updated":"2019-01-22 01:21:46.000000000","message":"I guess I\u0027d like to understand if there are any other OOB options as well.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"One can perform in-band disk-erase to achieve the same result. However,"},{"line_number":93,"context_line":"The ramdisk to be used in such case should have proliant-tools element"},{"line_number":94,"context_line":"that bundles \u0027ssacli\u0027 utility required for disk-erase operations as"},{"line_number":95,"context_line":"part of the image."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Data model impact"},{"line_number":98,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_a2809a47","line":95,"in_reply_to":"9fdfeff1_341b1a1c","updated":"2019-02-01 14:34:09.000000000","message":"++","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"User need to configure below two things to make use of OOB disk-erase on"},{"line_number":149,"context_line":"HPE Proliant Gen10 servers."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Configure the hardware type ``ilo5`` to ([DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_028f2675","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":4},"updated":"2019-02-01 14:34:09.000000000","message":"nit: s/User/Users/","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"User need to configure below two things to make use of OOB disk-erase on"},{"line_number":149,"context_line":"HPE Proliant Gen10 servers."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Configure the hardware type ``ilo5`` to ([DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_eb10ecaa","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":39},"updated":"2019-02-01 14:34:09.000000000","message":"nit: s/below two things/two options below/","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"User need to configure below two things to make use of OOB disk-erase on"},{"line_number":149,"context_line":"HPE Proliant Gen10 servers."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Configure the hardware type ``ilo5`` to ([DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_9b84d85f","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":4},"in_reply_to":"9fdfeff1_028f2675","updated":"2019-02-14 10:03:16.000000000","message":"Done","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"e3578daf0cd8ee70b5cd9ba2cb2321ba1bbfa23a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"User need to configure below two things to make use of OOB disk-erase on"},{"line_number":149,"context_line":"HPE Proliant Gen10 servers."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* Configure the hardware type ``ilo5`` to ([DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_5bef501c","line":148,"range":{"start_line":148,"start_character":23,"end_line":148,"end_character":39},"in_reply_to":"9fdfeff1_eb10ecaa","updated":"2019-02-14 10:03:16.000000000","message":"Done","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"* Configure the hardware type ``ilo5`` to ([DEFAULT]"},{"line_number":152,"context_line":"  ``enabled_hardware_types``)."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* Configure the new deploy interface ``ilo5`` to ([DEFAULT]"},{"line_number":155,"context_line":"  ``enabled_deploy_interfaces``)."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_e266a2c1","line":154,"range":{"start_line":154,"start_character":39,"end_line":154,"end_character":43},"updated":"2019-02-01 14:34:09.000000000","message":"Please consider using name ilo5-agent as it give more details.","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e8ac9823210002dfa97c78435cc06110e8a4b4d4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"Work Items"},{"line_number":173,"context_line":"----------"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* Add a new deploy interface ``Ilo5Deploy`` to hardware type ``ilo5``"},{"line_number":176,"context_line":"* Writing unit-test cases for the new OOB disk-erase interface."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fdfeff1_dc5230de","line":175,"range":{"start_line":175,"start_character":31,"end_line":175,"end_character":41},"updated":"2019-02-01 14:34:09.000000000","message":"ditto","commit_id":"2ad87c2ad6e44e0c9cf8d5b91a121339a072a232"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a22f95cec054441e7ff386a6105c207ca4752d41","unresolved":false,"context_lines":[{"line_number":33,"context_line":"List of changes required:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The following would be the composition of the new deploy interface"},{"line_number":36,"context_line":"  ``Ilo5Deploy``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_5db66340","line":36,"updated":"2019-02-14 12:15:03.000000000","message":"I\u0027m strictly against creating a new deploy interface just for adding an OOB clean step. Since it\u0027s a management action, I think it should go to the management interface.","commit_id":"be98d7eed6a99a8f3c985d866a8087661bdb2a8d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c9dac08b3474e9d975deef21ae0dc171a3f749b3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"List of changes required:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The following would be the composition of the new deploy interface"},{"line_number":36,"context_line":"  ``Ilo5Deploy``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_21ce905b","line":36,"in_reply_to":"9fdfeff1_5db66340","updated":"2019-02-19 08:24:25.000000000","message":"Changed to management interface now","commit_id":"be98d7eed6a99a8f3c985d866a8087661bdb2a8d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"99bdaa27543f88bd8d9a2470ff6c03c4680c96d4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"List of changes required:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The following would be the composition of the new deploy interface"},{"line_number":36,"context_line":"  ``Ilo5Deploy``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_e893b34d","line":36,"in_reply_to":"9fdfeff1_5db66340","updated":"2019-02-15 22:48:41.000000000","message":"I too am against this, and strictly against completely overriding the existing erase_devices step.","commit_id":"be98d7eed6a99a8f3c985d866a8087661bdb2a8d"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c9dac08b3474e9d975deef21ae0dc171a3f749b3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"List of changes required:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* The following would be the composition of the new deploy interface"},{"line_number":36,"context_line":"  ``Ilo5Deploy``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_41cb9449","line":36,"in_reply_to":"9fdfeff1_e893b34d","updated":"2019-02-19 08:24:25.000000000","message":"Changed to management interface now","commit_id":"be98d7eed6a99a8f3c985d866a8087661bdb2a8d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a22f95cec054441e7ff386a6105c207ca4752d41","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - Out-of-band disk-erase status can be monitored by proliantutils library"},{"line_number":50,"context_line":"      call `get_erase_decvices_status` for the updatation of its status to"},{"line_number":51,"context_line":"      the ironic node."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  .. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_7db1e743","line":50,"updated":"2019-02-14 12:15:03.000000000","message":"nit: \"devices\"","commit_id":"be98d7eed6a99a8f3c985d866a8087661bdb2a8d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a22f95cec054441e7ff386a6105c207ca4752d41","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      call `get_erase_decvices_status` for the updatation of its status to"},{"line_number":51,"context_line":"      the ironic node."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  .. code-block:: python"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    class Ilo5Deploy(agent.AgentDeploy):"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fdfeff1_1d869b67","line":53,"updated":"2019-02-14 12:15:03.000000000","message":"nit: you don\u0027t really have to paste the actual code here. having the spec approved won\u0027t mean that the code will be accepted as it is here.","commit_id":"be98d7eed6a99a8f3c985d866a8087661bdb2a8d"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"6425d43399a72ebb0de817d3be2a2619b8240d4e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The following would be the composition of the new management interface"},{"line_number":36,"context_line":"  ``Ilo5Management``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fdfeff1_07459c43","line":38,"updated":"2019-02-19 09:38:18.000000000","message":"Could you give some info of the priority of this clean step?","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"53052329eabba30b764cdb0b95f2b4ce20819f89","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The following would be the composition of the new management interface"},{"line_number":36,"context_line":"  ``Ilo5Management``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_112cf097","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":19},"updated":"2019-03-20 06:24:35.000000000","message":"Gen10 platform supports multiple sanitize options [1], it would be useful to provide optional argument to specify the erase option.\n[1] See \u0027Options for erasing drives\u0027 https://support.hpe.com/hpsc/doc/public/display?docId\u003demr_na-a00018944en_us","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"53052329eabba30b764cdb0b95f2b4ce20819f89","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The following would be the composition of the new management interface"},{"line_number":36,"context_line":"  ``Ilo5Management``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_1151500f","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":19},"updated":"2019-03-20 06:24:35.000000000","message":"This is the only method that would be a clean step. Other method is just a helper method.","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c12a3c161db45ade72c2079e2dca975c355ac8a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The following would be the composition of the new management interface"},{"line_number":36,"context_line":"  ``Ilo5Management``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffb9cba7_7b14f2a0","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":19},"in_reply_to":"5fc1f717_112cf097","updated":"2019-04-25 07:08:23.000000000","message":"Done","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c12a3c161db45ade72c2079e2dca975c355ac8a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The following would be the composition of the new management interface"},{"line_number":36,"context_line":"  ``Ilo5Management``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffb9cba7_5bb56ecc","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":19},"in_reply_to":"5fc1f717_1151500f","updated":"2019-04-25 07:08:23.000000000","message":"Done","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c12a3c161db45ade72c2079e2dca975c355ac8a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* The following would be the composition of the new management interface"},{"line_number":36,"context_line":"  ``Ilo5Management``:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  + ``erase_devices`` - This will erase all disks on the baremetal node."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffb9cba7_db715e0e","line":38,"in_reply_to":"9fdfeff1_07459c43","updated":"2019-04-25 07:08:23.000000000","message":"The priority will be the same what ironic has for in band disk erase.","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"53052329eabba30b764cdb0b95f2b4ce20819f89","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":44,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  + ``get_disk_erase_status`` - This will get status of disk erase of the"},{"line_number":47,"context_line":"    baremetal node."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - Out-of-band disk-erase status can be monitored by proliantutils library"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_d15ae828","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":27},"updated":"2019-03-20 06:24:35.000000000","message":"I suppose this is just a internal helper method and not a clean step. If so, need not be captured in spec.","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c12a3c161db45ade72c2079e2dca975c355ac8a5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"},{"line_number":44,"context_line":"      erase operation would take time based on disk type and size."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  + ``get_disk_erase_status`` - This will get status of disk erase of the"},{"line_number":47,"context_line":"    baremetal node."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    - Out-of-band disk-erase status can be monitored by proliantutils library"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffb9cba7_3bb2fae7","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":27},"in_reply_to":"5fc1f717_d15ae828","updated":"2019-04-25 07:08:23.000000000","message":"Done","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"6425d43399a72ebb0de817d3be2a2619b8240d4e","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Configure the new management interface ``ilo5`` to ([DEFAULT]"},{"line_number":119,"context_line":"  ``enabled_management_interfaces``)."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Developer impact"},{"line_number":123,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fdfeff1_075efc11","line":120,"updated":"2019-02-19 09:38:18.000000000","message":"If this clean step has a customizable priority, please include some info about it such as name, default value.","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c12a3c161db45ade72c2079e2dca975c355ac8a5","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Configure the new management interface ``ilo5`` to ([DEFAULT]"},{"line_number":119,"context_line":"  ``enabled_management_interfaces``)."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Developer impact"},{"line_number":123,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffb9cba7_fb554251","line":120,"in_reply_to":"9fdfeff1_075efc11","updated":"2019-04-25 07:08:23.000000000","message":"It has the same priority which inband disk-erase is having","commit_id":"22353e63937ee110b53ed077595a07d06d8c2438"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"441f1594f65379e390883886db16f3cc9fbf4aab","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Out-of-band disk-erase for Gen10 and above HPE Proliant Servers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffb9cba7_6befd9e8","line":7,"updated":"2019-05-10 13:10:24.000000000","message":"nit: reduce line ``\u003d`` characters to match title length","commit_id":"6cafab43fbb511e0e003a2e9c6de8f1dfdd7e2f7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"441f1594f65379e390883886db16f3cc9fbf4aab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Out-of-band disk-erase for Gen10 and above HPE Proliant Servers"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2004786"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffb9cba7_8bea4dd5","line":9,"updated":"2019-05-10 13:10:24.000000000","message":"ditto","commit_id":"6cafab43fbb511e0e003a2e9c6de8f1dfdd7e2f7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9b707787f58c371beb24724ef4d1d9e4fe4201b3","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO. User can also choose between different"},{"line_number":42,"context_line":"      erase pattern (ex. block, overwrite, crypto, zero) to perfrom the disk"},{"line_number":43,"context_line":"      erase operation."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffb9cba7_c78b6d65","line":42,"range":{"start_line":42,"start_character":60,"end_line":42,"end_character":67},"updated":"2019-05-02 12:35:56.000000000","message":"s/ perfrom / perform /","commit_id":"6cafab43fbb511e0e003a2e9c6de8f1dfdd7e2f7"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"c7f4d69349ddbba85ce92b3a16cd462fce280510","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - `erase_devices` will call proliantutils library method `do_disk_erase`"},{"line_number":41,"context_line":"      to perform the operation in iLO. User can also choose between different"},{"line_number":42,"context_line":"      erase pattern (ex. block, overwrite, crypto, zero) to perfrom the disk"},{"line_number":43,"context_line":"      erase operation."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - The reboot is required to initiate the disk erase. The actual disk"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfbec78f_cbef9cae","line":42,"range":{"start_line":42,"start_character":60,"end_line":42,"end_character":67},"in_reply_to":"ffb9cba7_c78b6d65","updated":"2019-05-03 04:47:55.000000000","message":"Done","commit_id":"6cafab43fbb511e0e003a2e9c6de8f1dfdd7e2f7"}]}