)]}'
{"specs/approved/power-control-passthrough.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9f56f4b71730c9b84eabd0ea01b431230c53c80d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We propose using a single proxy to act as a power control intermediary."},{"line_number":41,"context_line":"sushy-tools [0]_ allows for the creation of a configurable Redfish"},{"line_number":42,"context_line":"emulator that can be used with a variety of drivers, including libvirt"},{"line_number":43,"context_line":"and Nova drivers. We propose creating a new Ironic driver that implements"},{"line_number":44,"context_line":"the following methods by calling the matching Ironic API:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a22b32a_3b8cf249","line":41,"updated":"2020-12-04 21:43:16.000000000","message":"I don\u0027t have strong feelings about the emulation/client side of this, but it seems like this might be better off as two specs:\n- expose an interface to get/set power state and get/set boot device\n- develop a client for that interface inside sushy-tools\n\nWhile I know sushy is an Ironic project, I suspect it could be more clear to talk about them separately.","commit_id":"550df5ee69d13092eef6d36db2e2114a9a116b04"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9f56f4b71730c9b84eabd0ea01b431230c53c80d","unresolved":true,"context_lines":[{"line_number":61,"context_line":"using the Ironic driver, the emulator will make an Ironic API call to"},{"line_number":62,"context_line":"retrieve the Ironic node\u0027s `emulated_bmc` values. If they match the"},{"line_number":63,"context_line":"passed in username and password, then the Ironic driver will make the"},{"line_number":64,"context_line":"requested API call using the equivalent Ironic API."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The `emulated_bmc` values can also be directly set by an administrator"},{"line_number":67,"context_line":"or anyone else with the appropriate API access, such as a node owner."}],"source_content_type":"text/x-rst","patch_set":2,"id":"8b9178e8_3bbe0251","line":64,"updated":"2020-12-04 21:43:16.000000000","message":"Are we sure we want this integrated deeply into Ironic? I\u0027d rather implement this as a separate server and client, and trust the client (in this case a redfish emulator) handle the credentials. I do not think it\u0027s a good idea to expose details/credentials about this emulation inside an Ironic node.","commit_id":"550df5ee69d13092eef6d36db2e2114a9a116b04"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9f56f4b71730c9b84eabd0ea01b431230c53c80d","unresolved":true,"context_lines":[{"line_number":88,"context_line":"REST API impact"},{"line_number":89,"context_line":"---------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Client (CLI) impact"},{"line_number":94,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2a889694_5bedf9a4","line":91,"updated":"2020-12-04 21:43:16.000000000","message":"This is false. You\u0027re proposing adding 4 endpoints to the Ironic REST API. Details of those endpoints must be laid out here.\n\nOne thing I wonder about is\n- Do the get calls return cached or real time data? Is it possible to specify cached or real time?","commit_id":"550df5ee69d13092eef6d36db2e2114a9a116b04"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9f56f4b71730c9b84eabd0ea01b431230c53c80d","unresolved":true,"context_lines":[{"line_number":111,"context_line":"None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Driver API impact"},{"line_number":114,"context_line":"-----------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"None"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"740dc663_4e94e637","line":114,"updated":"2020-12-04 21:43:16.000000000","message":"Again, this isn\u0027t true. You\u0027re proposing adding four endpoints which will have a direct change to the ManagementInterface. How will we handle situations where the underlying BMC doesn\u0027t allow \"get\" of power status or network devices? What about bmcs that don\u0027t have a concept of what disk to boot from?","commit_id":"550df5ee69d13092eef6d36db2e2114a9a116b04"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9d9ae8990b26719bebcca3aae8c89f398d512bd1","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This spec describes a solution that adds an Ironic driver to"},{"line_number":22,"context_line":"sushy-tools, allowing sushy-tools\u0027 Redfish emulator to act as a"},{"line_number":23,"context_line":"power control intermediary."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"62f41f77_894d5e69","line":23,"updated":"2021-04-28 12:13:20.000000000","message":"sushy-tools was not designed to be used in production, it does not even have ANY authentication. If we think it\u0027s valuable, maybe we should add Redfish-compatible API to ironic proper?","commit_id":"1594b4fb609977a841282c9cf307ce63b66b0a68"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"75c4e0db09795c1e975880e1a6b1dbebe1d90e94","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This spec describes a solution that adds an Ironic driver to"},{"line_number":22,"context_line":"sushy-tools, allowing sushy-tools\u0027 Redfish emulator to act as a"},{"line_number":23,"context_line":"power control intermediary."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fc0f64d4_40d6e9ed","line":23,"in_reply_to":"62f41f77_894d5e69","updated":"2021-04-28 14:36:44.000000000","message":"I agree about the authentication; that\u0027s why the proposed solution does not involve storing credentials on the sushy-tools in any way, and uses keystone application credentials so that users have full control over whether access is even possible. That being said - if we can bring this functionality into Ironic proper, that would definitely be preferable! What would such a solution look like? Would we simply extend the Ironic API to mock a redfish interface?","commit_id":"1594b4fb609977a841282c9cf307ce63b66b0a68"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"5ef22c5dbb1cf057122457a7bf9718bc609d2caa","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This spec describes a solution that adds an Ironic driver to"},{"line_number":22,"context_line":"sushy-tools, allowing sushy-tools\u0027 Redfish emulator to act as a"},{"line_number":23,"context_line":"power control intermediary."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"28052a9d_c8c732f4","line":23,"in_reply_to":"7739e5e9_b76c1e88","updated":"2021-04-29 13:45:29.000000000","message":"Okay! I\u0027ll work on updating this spec then. Thanks for the feedback!","commit_id":"1594b4fb609977a841282c9cf307ce63b66b0a68"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ba94304e72f785a2cdcb1fb2f3e31c97f6a9d1e","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This spec describes a solution that adds an Ironic driver to"},{"line_number":22,"context_line":"sushy-tools, allowing sushy-tools\u0027 Redfish emulator to act as a"},{"line_number":23,"context_line":"power control intermediary."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7739e5e9_b76c1e88","line":23,"in_reply_to":"fc0f64d4_40d6e9ed","updated":"2021-04-29 07:45:33.000000000","message":"\u003e Would we simply extend the Ironic API to mock a redfish interface?\n\nYes, why not?\n\nOr we can provide another WSGI application that people can deploy if they want Redfish (can be a part of the Ironic repo, just not enabled by default).","commit_id":"1594b4fb609977a841282c9cf307ce63b66b0a68"}]}