)]}'
{"specs/approved/bios-registry-api.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Addition of a new configuration option in ironic.conf to specify the"},{"line_number":81,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"},{"line_number":82,"context_line":"  for the registry in multiple languages.  The default language will be"},{"line_number":83,"context_line":"  English, which will also be used if the vendor does not support multiple"},{"line_number":84,"context_line":"  languages.  The preferred language will be passed in to Sushy."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ef901254_0a5cb425","line":82,"range":{"start_line":82,"start_character":42,"end_line":82,"end_character":43},"updated":"2021-03-08 14:20:57.000000000","message":"nit: blank space","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Addition of a new configuration option in ironic.conf to specify the"},{"line_number":81,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"},{"line_number":82,"context_line":"  for the registry in multiple languages.  The default language will be"},{"line_number":83,"context_line":"  English, which will also be used if the vendor does not support multiple"},{"line_number":84,"context_line":"  languages.  The preferred language will be passed in to Sushy."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"379d4b88_bacb4947","line":82,"range":{"start_line":82,"start_character":42,"end_line":82,"end_character":43},"in_reply_to":"ef901254_0a5cb425","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f8d8e75c685a525b9d8e8ba7b3ebc63f8620964a","unresolved":true,"context_lines":[{"line_number":81,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"},{"line_number":82,"context_line":"  for the registry in multiple languages.  The default language will be"},{"line_number":83,"context_line":"  English, which will also be used if the vendor does not support multiple"},{"line_number":84,"context_line":"  languages.  The preferred language will be passed in to Sushy."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Support in Ironic to cache the BIOS Registry received from Sushy per node."},{"line_number":87,"context_line":"  Each registry can be quite large - in the range of 500K to 1M, so it will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9dbf2ff1_b3a3192f","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":64},"updated":"2021-03-08 14:20:46.000000000","message":"I think we should carry it, and just put a warning on the config parameter.","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"},{"line_number":82,"context_line":"  for the registry in multiple languages.  The default language will be"},{"line_number":83,"context_line":"  English, which will also be used if the vendor does not support multiple"},{"line_number":84,"context_line":"  languages.  The preferred language will be passed in to Sushy."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Support in Ironic to cache the BIOS Registry received from Sushy per node."},{"line_number":87,"context_line":"  Each registry can be quite large - in the range of 500K to 1M, so it will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5767a7fc_79732d95","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":64},"in_reply_to":"9dbf2ff1_b3a3192f","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f8d8e75c685a525b9d8e8ba7b3ebc63f8620964a","unresolved":true,"context_lines":[{"line_number":88,"context_line":"  cached to disk in gzip format.  The cache will be updated whenever Ironic"},{"line_number":89,"context_line":"  gets the BIOS Registry."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* Exposing the BIOS Registry per node via a new REST API.  The uncompressed"},{"line_number":92,"context_line":"  Registry will be returned in the same format it was received from the BMC."},{"line_number":93,"context_line":"  If the cached BIOS Registry is not available, Ironic will not attempt a"},{"line_number":94,"context_line":"  synchronous retrieval but will return an HTTP error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f629c03a_c0f7652a","line":91,"range":{"start_line":91,"start_character":63,"end_line":91,"end_character":75},"updated":"2021-03-08 14:20:46.000000000","message":"Assuming this is not breaking of the stream compression that HTTP responses are subjected to in some webservers.","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":88,"context_line":"  cached to disk in gzip format.  The cache will be updated whenever Ironic"},{"line_number":89,"context_line":"  gets the BIOS Registry."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* Exposing the BIOS Registry per node via a new REST API.  The uncompressed"},{"line_number":92,"context_line":"  Registry will be returned in the same format it was received from the BMC."},{"line_number":93,"context_line":"  If the cached BIOS Registry is not available, Ironic will not attempt a"},{"line_number":94,"context_line":"  synchronous retrieval but will return an HTTP error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5226f308_297c3dea","line":91,"range":{"start_line":91,"start_character":58,"end_line":91,"end_character":59},"updated":"2021-03-08 14:20:57.000000000","message":"nit: blank space","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  cached to disk in gzip format.  The cache will be updated whenever Ironic"},{"line_number":89,"context_line":"  gets the BIOS Registry."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* Exposing the BIOS Registry per node via a new REST API.  The uncompressed"},{"line_number":92,"context_line":"  Registry will be returned in the same format it was received from the BMC."},{"line_number":93,"context_line":"  If the cached BIOS Registry is not available, Ironic will not attempt a"},{"line_number":94,"context_line":"  synchronous retrieval but will return an HTTP error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"cd7e3d04_2d720a84","line":91,"range":{"start_line":91,"start_character":58,"end_line":91,"end_character":59},"in_reply_to":"5226f308_297c3dea","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  cached to disk in gzip format.  The cache will be updated whenever Ironic"},{"line_number":89,"context_line":"  gets the BIOS Registry."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* Exposing the BIOS Registry per node via a new REST API.  The uncompressed"},{"line_number":92,"context_line":"  Registry will be returned in the same format it was received from the BMC."},{"line_number":93,"context_line":"  If the cached BIOS Registry is not available, Ironic will not attempt a"},{"line_number":94,"context_line":"  synchronous retrieval but will return an HTTP error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4f965ac4_42b94712","line":91,"range":{"start_line":91,"start_character":63,"end_line":91,"end_character":75},"in_reply_to":"f629c03a_c0f7652a","updated":"2021-03-08 20:06:13.000000000","message":"Ack","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":101,"context_line":"  values."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Instead of retrieving the registry and caching it, Ironic could do a"},{"line_number":104,"context_line":"  synchronous get from the API.  However, this may lead to performance problems"},{"line_number":105,"context_line":"  especially when handling multiple API requests."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bd0d9883_7b3459ae","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":32},"updated":"2021-03-08 14:20:57.000000000","message":"nit: blank space","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  values."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"* Instead of retrieving the registry and caching it, Ironic could do a"},{"line_number":104,"context_line":"  synchronous get from the API.  However, this may lead to performance problems"},{"line_number":105,"context_line":"  especially when handling multiple API requests."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"043ee98c_5c66d52b","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":32},"in_reply_to":"bd0d9883_7b3459ae","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":108,"context_line":"-----------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* There is no fixed schema defined for the BIOS Registry, it is vendor"},{"line_number":111,"context_line":"  dependent.  Therefore no validation checks will be made on the data -"},{"line_number":112,"context_line":"  what is received from the BMC will be presented via the API."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* The BIOS Registry will be stored by Ironic in a cache using a simple caching"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0056c8d0_cdad858f","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":14},"updated":"2021-03-08 14:20:57.000000000","message":"nit: blank space","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":108,"context_line":"-----------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* There is no fixed schema defined for the BIOS Registry, it is vendor"},{"line_number":111,"context_line":"  dependent.  Therefore no validation checks will be made on the data -"},{"line_number":112,"context_line":"  what is received from the BMC will be presented via the API."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* The BIOS Registry will be stored by Ironic in a cache using a simple caching"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a653883e_9d40a37e","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":14},"in_reply_to":"0056c8d0_cdad858f","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":112,"context_line":"  what is received from the BMC will be presented via the API."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* The BIOS Registry will be stored by Ironic in a cache using a simple caching"},{"line_number":115,"context_line":"  mechanism such as dogpile.cache.  Note that this model can be extended to"},{"line_number":116,"context_line":"  support caching the MessageRegistry as described in"},{"line_number":117,"context_line":"  `Excessive loading (and logging) of message registry resources in sushy"},{"line_number":118,"context_line":"  \u003chttps://storyboard.openstack.org/#!/story/2007918\u003e`_ although that\u0027s not the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"02e67e06_3121dd28","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":36},"updated":"2021-03-08 14:20:57.000000000","message":"nit: blank space","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  what is received from the BMC will be presented via the API."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* The BIOS Registry will be stored by Ironic in a cache using a simple caching"},{"line_number":115,"context_line":"  mechanism such as dogpile.cache.  Note that this model can be extended to"},{"line_number":116,"context_line":"  support caching the MessageRegistry as described in"},{"line_number":117,"context_line":"  `Excessive loading (and logging) of message registry resources in sushy"},{"line_number":118,"context_line":"  \u003chttps://storyboard.openstack.org/#!/story/2007918\u003e`_ although that\u0027s not the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2d0f1425_b7996742","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":36},"in_reply_to":"02e67e06_3121dd28","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f8d8e75c685a525b9d8e8ba7b3ebc63f8620964a","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  support caching the MessageRegistry as described in"},{"line_number":117,"context_line":"  `Excessive loading (and logging) of message registry resources in sushy"},{"line_number":118,"context_line":"  \u003chttps://storyboard.openstack.org/#!/story/2007918\u003e`_ although that\u0027s not the"},{"line_number":119,"context_line":"  focus of this proposal."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"State Machine Impact"},{"line_number":122,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"58b02087_4a46a31a","line":119,"updated":"2021-03-08 14:20:46.000000000","message":"Cool! I\u0027m slightly worried about when we clear the node\u0027s cache entry. Per Bob, we\u0027re going to force the contents to be refreshed upon manageable.","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  support caching the MessageRegistry as described in"},{"line_number":117,"context_line":"  `Excessive loading (and logging) of message registry resources in sushy"},{"line_number":118,"context_line":"  \u003chttps://storyboard.openstack.org/#!/story/2007918\u003e`_ although that\u0027s not the"},{"line_number":119,"context_line":"  focus of this proposal."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"State Machine Impact"},{"line_number":122,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9dd54ff0_4185341a","line":119,"in_reply_to":"58b02087_4a46a31a","updated":"2021-03-08 20:06:13.000000000","message":"Ack","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":122,"context_line":"--------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The BIOS Registry will be retrieved from the BMC upon transition to"},{"line_number":125,"context_line":"``manageable`` and ``cleaning`` states using multiple Redfish requests.  This"},{"line_number":126,"context_line":"may add some additional time to the state transition but it is not"},{"line_number":127,"context_line":"foreseen that this will have an impact on the state transition performance."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"af9e3e40_039ac169","line":125,"range":{"start_line":125,"start_character":72,"end_line":125,"end_character":73},"updated":"2021-03-08 14:20:57.000000000","message":"nit: blank space","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":122,"context_line":"--------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The BIOS Registry will be retrieved from the BMC upon transition to"},{"line_number":125,"context_line":"``manageable`` and ``cleaning`` states using multiple Redfish requests.  This"},{"line_number":126,"context_line":"may add some additional time to the state transition but it is not"},{"line_number":127,"context_line":"foreseen that this will have an impact on the state transition performance."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6c291f17_1239e95b","line":125,"range":{"start_line":125,"start_character":72,"end_line":125,"end_character":73},"in_reply_to":"af9e3e40_039ac169","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3868d44175faa96e76827f802f0feade42102688","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    GET /v1/nodes/\u003cnode_ident\u003e/bios_registry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  The operation will return a JSON encoded response of the the currently"},{"line_number":138,"context_line":"  cached settings in vendor format."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  The API will return HTTP 400 (Bad Request) if driver doesn\u0027t support BIOS"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c37a91f7_37c49fbe","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":59},"updated":"2021-03-08 14:20:57.000000000","message":"nit: duplicate \u0027the\u0027","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    GET /v1/nodes/\u003cnode_ident\u003e/bios_registry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  The operation will return a JSON encoded response of the the currently"},{"line_number":138,"context_line":"  cached settings in vendor format."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  The API will return HTTP 400 (Bad Request) if driver doesn\u0027t support BIOS"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e20b2284_4f0afe6a","line":137,"range":{"start_line":137,"start_character":54,"end_line":137,"end_character":59},"in_reply_to":"c37a91f7_37c49fbe","updated":"2021-03-08 20:06:13.000000000","message":"Done","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f8d8e75c685a525b9d8e8ba7b3ebc63f8620964a","unresolved":true,"context_lines":[{"line_number":198,"context_line":"The Redfish requests to retrieve BIOS Registry data will increase the traffic"},{"line_number":199,"context_line":"to the BMC however, since these requests will only be when the node"},{"line_number":200,"context_line":"transitions to ``manageable`` or ``cleaning``, it should not impact"},{"line_number":201,"context_line":"scalability."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Performance Impact"},{"line_number":204,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0ba69925_bd0637fb","line":201,"updated":"2021-03-08 14:20:46.000000000","message":"So I think disk space is a concern. While not a ton, we could hit container limits or even run small\nconductors out of space. So maybe this is somethign that can be entirely admin disabled \"We\u0027re sorry, but the administrator has disabled the cache, and thus this feature\".\n\nJust an idea.","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"28a53e3de47247a8f80ac94fb25620a07ef4ddef","unresolved":false,"context_lines":[{"line_number":198,"context_line":"The Redfish requests to retrieve BIOS Registry data will increase the traffic"},{"line_number":199,"context_line":"to the BMC however, since these requests will only be when the node"},{"line_number":200,"context_line":"transitions to ``manageable`` or ``cleaning``, it should not impact"},{"line_number":201,"context_line":"scalability."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Performance Impact"},{"line_number":204,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6a3f22d2_2c142858","line":201,"in_reply_to":"0ba69925_bd0637fb","updated":"2021-03-08 20:06:13.000000000","message":"Added new configuration option to allow this feature to be disabled.","commit_id":"7163b2cf2a167fc6043029a533ebdcae238d86d1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b928fa7c93d3e22af6c46cb82d526724bd0d618","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Changes to Ironic to retrieve the Redfish BIOS Registry for a node when"},{"line_number":78,"context_line":"  it gets the BIOS settings; currently this is when Ironic moves the node to"},{"line_number":79,"context_line":"  ``manageable`` or ``cleaning``."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* Addition of a new configuration option in ironic.conf to specify the"},{"line_number":82,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c79894e4_24bb5330","line":79,"updated":"2021-04-20 11:23:11.000000000","message":"nit: And after changing the settings","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7693ec80877b644f75ea73db6a3ce91d52ecb186","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Changes to Ironic to retrieve the Redfish BIOS Registry for a node when"},{"line_number":78,"context_line":"  it gets the BIOS settings; currently this is when Ironic moves the node to"},{"line_number":79,"context_line":"  ``manageable`` or ``cleaning``."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* Addition of a new configuration option in ironic.conf to specify the"},{"line_number":82,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"}],"source_content_type":"text/x-rst","patch_set":6,"id":"700ee758_cbbd8209","line":79,"in_reply_to":"c79894e4_24bb5330","updated":"2021-04-20 18:36:18.000000000","message":"Done","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b928fa7c93d3e22af6c46cb82d526724bd0d618","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  it gets the BIOS settings; currently this is when Ironic moves the node to"},{"line_number":79,"context_line":"  ``manageable`` or ``cleaning``."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* Addition of a new configuration option in ironic.conf to specify the"},{"line_number":82,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"},{"line_number":83,"context_line":"  for the registry in multiple languages. The default language will be"},{"line_number":84,"context_line":"  English, which will also be used if the vendor does not support multiple"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7d3ee7b5_ee97bbf5","line":81,"updated":"2021-04-20 11:23:11.000000000","message":"It\u0027s fine in our case (we don\u0027t have a good localization story anyway), but in theory we should respect the caller\u0027s headers. No action required, just mentioning it for completeness.","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7693ec80877b644f75ea73db6a3ce91d52ecb186","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  it gets the BIOS settings; currently this is when Ironic moves the node to"},{"line_number":79,"context_line":"  ``manageable`` or ``cleaning``."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* Addition of a new configuration option in ironic.conf to specify the"},{"line_number":82,"context_line":"  language localization for the BIOS Registry as some vendors provide endpoints"},{"line_number":83,"context_line":"  for the registry in multiple languages. The default language will be"},{"line_number":84,"context_line":"  English, which will also be used if the vendor does not support multiple"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6563878e_cba8dddf","line":81,"in_reply_to":"7d3ee7b5_ee97bbf5","updated":"2021-04-20 18:36:18.000000000","message":"OK","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b928fa7c93d3e22af6c46cb82d526724bd0d618","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-----------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* There is no fixed schema defined for the BIOS Registry, it is vendor"},{"line_number":117,"context_line":"  dependent. Therefore no validation checks will be made on the data -"},{"line_number":118,"context_line":"  what is received from the BMC will be presented via the API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3e549c67_0ad30202","line":117,"updated":"2021-04-20 11:23:11.000000000","message":"Ugh. UGH. Wait, it doesn\u0027t seem to be true, AttributeRegistry actually specifies the fields: https://redfish.dmtf.org/schemas/v1/AttributeRegistry.v1_3_4.json. I don\u0027t suggest we add them as separate columns to the database, but it seems that we can decide on a subset of fields we support.\n\nThis can include default_value, immutable, unique, lower_bound, max_length, min_length, read_only (wtf, why is it different from immutable??), reset_required, possible_values, value_expression and upper_bound (and write_only?). Maybe also display_name and help_text.\n\nThis is especially important for potential non-Redfish implementations.","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7693ec80877b644f75ea73db6a3ce91d52ecb186","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-----------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* There is no fixed schema defined for the BIOS Registry, it is vendor"},{"line_number":117,"context_line":"  dependent. Therefore no validation checks will be made on the data -"},{"line_number":118,"context_line":"  what is received from the BMC will be presented via the API."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3dd691f1_32103eb4","line":117,"in_reply_to":"3e549c67_0ad30202","updated":"2021-04-20 18:36:18.000000000","message":"Good point. Changed to define the common set of attribute fields defined in the schema which Sushy will set when caching the registry.\n\nWe should also be able to use these registry fields to validate the BIOS settings in clean steps to verify attribute names, allowable values, ranges (and if readonly in particular!) etc. when setting BIOS attributes. Its not really applicable to this spec but possible for a follow-on.","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3b928fa7c93d3e22af6c46cb82d526724bd0d618","unresolved":false,"context_lines":[{"line_number":149,"context_line":"          \"updated_at\": null,"},{"line_number":150,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":151,"context_line":"          \"value\": \"Enabled\","},{"line_number":152,"context_line":"          \"registry\":"},{"line_number":153,"context_line":"            { \"AttributeName\": \"ProcVirtualization\","},{"line_number":154,"context_line":"              \"DisplayName\": \"Intel(R) Virtualization Technology (Intel VT) \","},{"line_number":155,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"e96e44ca_74ece3f9","line":152,"updated":"2021-04-20 11:23:11.000000000","message":"I\u0027m not found of a free-form API output. As proposed above, let\u0027s settle down on a subset of fields.","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"7693ec80877b644f75ea73db6a3ce91d52ecb186","unresolved":false,"context_lines":[{"line_number":149,"context_line":"          \"updated_at\": null,"},{"line_number":150,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":151,"context_line":"          \"value\": \"Enabled\","},{"line_number":152,"context_line":"          \"registry\":"},{"line_number":153,"context_line":"            { \"AttributeName\": \"ProcVirtualization\","},{"line_number":154,"context_line":"              \"DisplayName\": \"Intel(R) Virtualization Technology (Intel VT) \","},{"line_number":155,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"3b70a3f9_74972a19","line":152,"in_reply_to":"e96e44ca_74ece3f9","updated":"2021-04-20 18:36:18.000000000","message":"Updated to only include the subset of fields in \"Data model impact\".","commit_id":"0b1944800a52e1da7138bbffedddb82d81505e1e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":136,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"},{"line_number":137,"context_line":"  see [4]_. Since the registry keys are vendor dependent, with the exception of"},{"line_number":138,"context_line":"  ``AttributeName`` key, the registry data will be stored as a JsonEncodedDict"},{"line_number":139,"context_line":"  similar to the ``extra`` field on other items."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"State Machine Impact"},{"line_number":142,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dc8614c8_3765d725","line":139,"updated":"2021-04-26 08:29:50.000000000","message":"Well actually, we\u0027re talking about not making them vendor dependent here. We can add normal fields and default them to NULL/None.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"},{"line_number":137,"context_line":"  see [4]_. Since the registry keys are vendor dependent, with the exception of"},{"line_number":138,"context_line":"  ``AttributeName`` key, the registry data will be stored as a JsonEncodedDict"},{"line_number":139,"context_line":"  similar to the ``extra`` field on other items."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"State Machine Impact"},{"line_number":142,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9929772e_7fc90714","line":139,"in_reply_to":"dc8614c8_3765d725","updated":"2021-04-28 16:41:48.000000000","message":"Done","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  ``/v1/nodes/\u003cnode\u003e/bios/\u003cattribute\u003e`` endpoint will be changed to include"},{"line_number":154,"context_line":"  a ``registry`` field that will be a dictionary containing the BIOS"},{"line_number":155,"context_line":"  registry data for that attribute. The ``/v1/nodes/\u003cnode\u003e/bios`` endpoint"},{"line_number":156,"context_line":"  will only include this data per attribute if ``?detail\u003dTrue`` is set,"},{"line_number":157,"context_line":"  similar to how the ``/v1/nodes/`` endpoint works. If BIOS Registry was"},{"line_number":158,"context_line":"  not received from the node then the ``registry`` field will be empty."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"2f3eca07_61222dae","line":156,"updated":"2021-04-26 08:29:50.000000000","message":"Let\u0027s also support \u0027fields\u0027, I can easily imagine that someone won\u0027t want to fetch help_text.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  ``/v1/nodes/\u003cnode\u003e/bios/\u003cattribute\u003e`` endpoint will be changed to include"},{"line_number":154,"context_line":"  a ``registry`` field that will be a dictionary containing the BIOS"},{"line_number":155,"context_line":"  registry data for that attribute. The ``/v1/nodes/\u003cnode\u003e/bios`` endpoint"},{"line_number":156,"context_line":"  will only include this data per attribute if ``?detail\u003dTrue`` is set,"},{"line_number":157,"context_line":"  similar to how the ``/v1/nodes/`` endpoint works. If BIOS Registry was"},{"line_number":158,"context_line":"  not received from the node then the ``registry`` field will be empty."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"cbb87963_7284740c","line":156,"in_reply_to":"2f3eca07_61222dae","updated":"2021-04-28 16:41:48.000000000","message":"OK, added text for this.  Note that I\u0027ve removed help_text in addition to display_name. Help_text can be very long for certain vendors - one or two paragraphs, and probably not worth storing. Display_name is practically just the attribute name split into separate words in order to show on a menu and does not provide much value to an API.\n\nSince the language localization is only used for HelpText and DisplayName (all other fields are always in English) I removed that also.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":165,"context_line":"          \"updated_at\": null,"},{"line_number":166,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":167,"context_line":"          \"value\": \"Enabled\","},{"line_number":168,"context_line":"          \"registry\":"},{"line_number":169,"context_line":"            { \"AttributeName\": \"ProcVirtualization\","},{"line_number":170,"context_line":"              \"DisplayName\": \"Intel(R) Virtualization Technology (Intel VT) \","},{"line_number":171,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"99b03c42_802641a7","line":168,"updated":"2021-04-26 08:29:50.000000000","message":"I\u0027d prefer not to have a nested field. At the very least it prevents us from adding meaningful --fields query.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"          \"updated_at\": null,"},{"line_number":166,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":167,"context_line":"          \"value\": \"Enabled\","},{"line_number":168,"context_line":"          \"registry\":"},{"line_number":169,"context_line":"            { \"AttributeName\": \"ProcVirtualization\","},{"line_number":170,"context_line":"              \"DisplayName\": \"Intel(R) Virtualization Technology (Intel VT) \","},{"line_number":171,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"fe8a1161_8cbe5bce","line":168,"in_reply_to":"99b03c42_802641a7","updated":"2021-04-28 16:41:48.000000000","message":"As we talked about, changed this to remove the \u0027\u0027registry\u0027\u0027 nesting and now all fields will be at the same level which will allow queries.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":166,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":167,"context_line":"          \"value\": \"Enabled\","},{"line_number":168,"context_line":"          \"registry\":"},{"line_number":169,"context_line":"            { \"AttributeName\": \"ProcVirtualization\","},{"line_number":170,"context_line":"              \"DisplayName\": \"Intel(R) Virtualization Technology (Intel VT) \","},{"line_number":171,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","},{"line_number":172,"context_line":"              \"ReadOnly\": false,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c1578596_87ed08cd","line":169,"updated":"2021-04-26 08:29:50.000000000","message":"I would also like us to switch to using underscores instead of camel case for consistency with the rest of Ironic.\n\nAnd AttributeName is duplicated with name.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":167,"context_line":"          \"value\": \"Enabled\","},{"line_number":168,"context_line":"          \"registry\":"},{"line_number":169,"context_line":"            { \"AttributeName\": \"ProcVirtualization\","},{"line_number":170,"context_line":"              \"DisplayName\": \"Intel(R) Virtualization Technology (Intel VT) \","},{"line_number":171,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","},{"line_number":172,"context_line":"              \"ReadOnly\": false,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2e00f2fd_04c12946","line":169,"in_reply_to":"c1578596_87ed08cd","updated":"2021-04-28 16:41:48.000000000","message":"Done","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":171,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","},{"line_number":172,"context_line":"              \"ReadOnly\": false,"},{"line_number":173,"context_line":"              \"Type\": \"Enumeration\","},{"line_number":174,"context_line":"              \"Value\": ["},{"line_number":175,"context_line":"                { \"ValueName\": \"Enabled\","},{"line_number":176,"context_line":"                  \"ValueDisplayName\": \"Enabled\""},{"line_number":177,"context_line":"                },"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a5661f0c_b3ecbd6d","line":174,"updated":"2021-04-26 08:29:50.000000000","message":"I\u0027d rename this to allowed_values to avoid confusing with the existing value","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"              \"HelpText\": \"When enabled, a hypervisor or operating system supporting this option can use hardware capabilities provided by Intel VT. Some hypervisors require that you enable Intel VT. You can leave this set to enabled even if you are not using a hypervisor or an operating system that uses this option.\","},{"line_number":172,"context_line":"              \"ReadOnly\": false,"},{"line_number":173,"context_line":"              \"Type\": \"Enumeration\","},{"line_number":174,"context_line":"              \"Value\": ["},{"line_number":175,"context_line":"                { \"ValueName\": \"Enabled\","},{"line_number":176,"context_line":"                  \"ValueDisplayName\": \"Enabled\""},{"line_number":177,"context_line":"                },"}],"source_content_type":"text/x-rst","patch_set":8,"id":"40d23b3d_b3952ed1","line":174,"in_reply_to":"a5661f0c_b3ecbd6d","updated":"2021-04-28 16:41:48.000000000","message":"Done","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":172,"context_line":"              \"ReadOnly\": false,"},{"line_number":173,"context_line":"              \"Type\": \"Enumeration\","},{"line_number":174,"context_line":"              \"Value\": ["},{"line_number":175,"context_line":"                { \"ValueName\": \"Enabled\","},{"line_number":176,"context_line":"                  \"ValueDisplayName\": \"Enabled\""},{"line_number":177,"context_line":"                },"},{"line_number":178,"context_line":"                { \"ValueName\": \"Disabled\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"db623e8f_4ca23c37","line":175,"updated":"2021-04-26 08:29:50.000000000","message":"just name","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"              \"ReadOnly\": false,"},{"line_number":173,"context_line":"              \"Type\": \"Enumeration\","},{"line_number":174,"context_line":"              \"Value\": ["},{"line_number":175,"context_line":"                { \"ValueName\": \"Enabled\","},{"line_number":176,"context_line":"                  \"ValueDisplayName\": \"Enabled\""},{"line_number":177,"context_line":"                },"},{"line_number":178,"context_line":"                { \"ValueName\": \"Disabled\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"01d8a566_b005facc","line":175,"in_reply_to":"db623e8f_4ca23c37","updated":"2021-04-28 16:41:48.000000000","message":"Done","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":173,"context_line":"              \"Type\": \"Enumeration\","},{"line_number":174,"context_line":"              \"Value\": ["},{"line_number":175,"context_line":"                { \"ValueName\": \"Enabled\","},{"line_number":176,"context_line":"                  \"ValueDisplayName\": \"Enabled\""},{"line_number":177,"context_line":"                },"},{"line_number":178,"context_line":"                { \"ValueName\": \"Disabled\","},{"line_number":179,"context_line":"                  \"ValueDisplayName\": \"Disabled\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"93299ae3_d6c2fef9","line":176,"updated":"2021-04-26 08:29:50.000000000","message":"just display_name","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"              \"Type\": \"Enumeration\","},{"line_number":174,"context_line":"              \"Value\": ["},{"line_number":175,"context_line":"                { \"ValueName\": \"Enabled\","},{"line_number":176,"context_line":"                  \"ValueDisplayName\": \"Enabled\""},{"line_number":177,"context_line":"                },"},{"line_number":178,"context_line":"                { \"ValueName\": \"Disabled\","},{"line_number":179,"context_line":"                  \"ValueDisplayName\": \"Disabled\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"f7eaafaa_9ced724d","line":176,"in_reply_to":"93299ae3_d6c2fef9","updated":"2021-04-28 16:41:48.000000000","message":"As per the earlier comment I also removed the the display_name here as it provides little value.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f562b604a82c55d209c1df983c5fb41252ee2f61","unresolved":false,"context_lines":[{"line_number":255,"context_line":"A new method will be added to ``BIOSInterface``:"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"* ``cache_bios_registry`` - This method will be called to store/update the"},{"line_number":258,"context_line":"  BIOS Registry."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Nova driver impact"},{"line_number":261,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fcd62593_ab65f922","line":258,"updated":"2021-04-26 08:29:50.000000000","message":"I actually wonder if we need a new method, or we can cache the schema in the same call where we collect the data.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"ba639242f1fa8740a178a565f9a017c8dc5e552a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"A new method will be added to ``BIOSInterface``:"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"* ``cache_bios_registry`` - This method will be called to store/update the"},{"line_number":258,"context_line":"  BIOS Registry."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Nova driver impact"},{"line_number":261,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"94f972b7_40566ced","line":258,"in_reply_to":"fcd62593_ab65f922","updated":"2021-04-28 16:41:48.000000000","message":"Removed the new method, will get the data in ``cache_bios_settings``.","commit_id":"c55f27ae358a15647cce8445b68c0afc39946f83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6fd2ff89be7f578d5fdbbc651944ad2018eed97d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"          \"updated_at\": null,"},{"line_number":159,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":160,"context_line":"          \"value\": \"Enabled\","},{"line_number":161,"context_line":"          \"allowed_values\": ["},{"line_number":162,"context_line":"            { \"name\": \"Enabled\","},{"line_number":163,"context_line":"            },"},{"line_number":164,"context_line":"            { \"name\": \"Disabled\","}],"source_content_type":"text/x-rst","patch_set":11,"id":"67061b96_a17f0f43","line":161,"updated":"2021-05-03 13:27:29.000000000","message":"If you\u0027re not going to expose ValueDisplayName, maybe create a normal list? [\"Enabled\", \"Disabled\"]?","commit_id":"9c7649dce29923fd2a4e55ad741ee8690434dc68"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"6c616f88c8f6a401df1bdf9edd236a6bef2971e8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"          \"updated_at\": null,"},{"line_number":159,"context_line":"          \"name\": \"ProcVirtualization\","},{"line_number":160,"context_line":"          \"value\": \"Enabled\","},{"line_number":161,"context_line":"          \"allowed_values\": ["},{"line_number":162,"context_line":"            { \"name\": \"Enabled\","},{"line_number":163,"context_line":"            },"},{"line_number":164,"context_line":"            { \"name\": \"Disabled\","}],"source_content_type":"text/x-rst","patch_set":11,"id":"0c7b17b4_a24a8e76","line":161,"in_reply_to":"67061b96_a17f0f43","updated":"2021-05-03 14:19:45.000000000","message":"Good idea. Some vendors include both ValueName and DisplayValueName in the response while one in particular only includes DisplayValueName (and not ValueName) so a simple list would hide that.\n\nFixed.","commit_id":"9c7649dce29923fd2a4e55ad741ee8690434dc68"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6fd2ff89be7f578d5fdbbc651944ad2018eed97d","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\"openstacksdk\""},{"line_number":258,"context_line":"~~~~~~~~~~~~~~"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"None"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"RPC API impact"},{"line_number":263,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"193afef0_4e56c121","line":260,"updated":"2021-05-03 13:27:29.000000000","message":"We should probably expose detail there.","commit_id":"9c7649dce29923fd2a4e55ad741ee8690434dc68"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"6c616f88c8f6a401df1bdf9edd236a6bef2971e8","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\"openstacksdk\""},{"line_number":258,"context_line":"~~~~~~~~~~~~~~"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"None"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"RPC API impact"},{"line_number":263,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"a1733a83_63f1cfc2","line":260,"in_reply_to":"193afef0_4e56c121","updated":"2021-05-03 14:19:45.000000000","message":"Openstacksdk does not currently support BIOS settings. I\u0027ve added a note that adding support isn\u0027t required for this functionality, but when its added the detail info should also be included.","commit_id":"9c7649dce29923fd2a4e55ad741ee8690434dc68"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0e9b8e8bd4e352f0b8f080312f5f19ff991a778d","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    * Value (possible values for enumeration types)"},{"line_number":123,"context_line":"      * ValueName"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"},{"line_number":126,"context_line":"  see [4]_. All the above fields will be set as populated in the registry. For"},{"line_number":127,"context_line":"  each setting the fields that are in the registry depend on the Type, e.g."},{"line_number":128,"context_line":"  an Integer type will have UpperBound and LowerBound set but MinLength and"}],"source_content_type":"text/x-rst","patch_set":12,"id":"c866aff7_11bca17a","line":125,"updated":"2021-05-04 17:24:57.000000000","message":"Let\u0027s be really explicit about exactly how the columns in the existing bios setting table is working.","commit_id":"6f251e52df2513e8f86e8f8366f312e1422a02b5"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"273585033fddc2c88945b7325d8eb636b4ef28c8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    * Value (possible values for enumeration types)"},{"line_number":123,"context_line":"      * ValueName"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"},{"line_number":126,"context_line":"  see [4]_. All the above fields will be set as populated in the registry. For"},{"line_number":127,"context_line":"  each setting the fields that are in the registry depend on the Type, e.g."},{"line_number":128,"context_line":"  an Integer type will have UpperBound and LowerBound set but MinLength and"}],"source_content_type":"text/x-rst","patch_set":12,"id":"522dbc21_d08789ef","line":125,"in_reply_to":"c866aff7_11bca17a","updated":"2021-05-04 20:13:28.000000000","message":"Done","commit_id":"6f251e52df2513e8f86e8f8366f312e1422a02b5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ae318f0bcbeab52af1d1a92ee07641b5fc099731","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* The BIOS Registry will be stored in the Ironic DB along with the BIOSSetting,"},{"line_number":126,"context_line":"  see [4]_. The following columns will be added and must be included in the"},{"line_number":127,"context_line":"  migration code:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    * ``attribute_type`` (string)"},{"line_number":130,"context_line":"    * ``allowable_values`` (list)"}],"source_content_type":"text/x-rst","patch_set":13,"id":"57f5d63b_a3d2efdf","line":127,"updated":"2021-05-11 18:54:29.000000000","message":"nit: should specify table :) . Follow up?","commit_id":"b31ddfea4c6643ad0531057e1dff2b9c5eb6bf96"}]}