)]}'
{"specs/approved/event-subscriptions.rst":[{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":48,"context_line":"#. Delete a subscription ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csub_id\u003e``"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. List all subscriptions ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7eae6c0c_9d8b289b","line":51,"updated":"2021-04-28 11:54:16.000000000","message":"Updating the subscription should be supported as the end URL may change.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#. Delete a subscription ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csub_id\u003e``"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. List all subscriptions ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b3d51e72_150e28f5","line":51,"in_reply_to":"7eae6c0c_9d8b289b","updated":"2021-05-19 08:22:09.000000000","message":"I couldn\u0027t update the destination url in iLO or iDRAC, based on this I don\u0027t think it makes sense to support update here","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Te user can directly access the BMC and configure the subscriptions."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"79e9dbc5_bd17caa8","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":3},"updated":"2021-04-28 11:54:16.000000000","message":"nit:The","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Te user can directly access the BMC and configure the subscriptions."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"635375d1_dfc79de8","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":3},"in_reply_to":"79e9dbc5_bd17caa8","updated":"2021-05-19 08:22:09.000000000","message":"Done","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* subscription_id"},{"line_number":66,"context_line":"* node_id"},{"line_number":67,"context_line":"* subscription_information (maybe multiple columns instead of just one)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":70,"context_line":"upgrade."}],"source_content_type":"text/x-rst","patch_set":2,"id":"f870373b_7597644a","line":67,"updated":"2021-04-26 08:35:03.000000000","message":"I think multiple columns make sense. Let\u0027s specify the whole table structure here.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* subscription_id"},{"line_number":66,"context_line":"* node_id"},{"line_number":67,"context_line":"* subscription_information (maybe multiple columns instead of just one)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":70,"context_line":"upgrade."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5c0d4af9_928098f3","line":67,"in_reply_to":"f870373b_7597644a","updated":"2021-05-19 08:22:09.000000000","message":"Updating to match what we will store in the DB.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* subscription_id"},{"line_number":66,"context_line":"* node_id"},{"line_number":67,"context_line":"* subscription_information (maybe multiple columns instead of just one)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":70,"context_line":"upgrade."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6ee060e7_9b2afab2","line":68,"updated":"2021-04-28 11:54:16.000000000","message":"IMO even the Node model needs to be updated to include subscription field","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* subscription_id"},{"line_number":66,"context_line":"* node_id"},{"line_number":67,"context_line":"* subscription_information (maybe multiple columns instead of just one)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":70,"context_line":"upgrade."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b2d511f9_7e7f32a2","line":68,"in_reply_to":"6ee060e7_9b2afab2","updated":"2021-05-19 08:22:09.000000000","message":"we will have a separate Table for subscriptions","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  Retrieves a list of subscriptions from the node."},{"line_number":86,"context_line":"  Returns a JSON object listing all available node subscriptions."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  Error codes:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b11b390e_7ba5b233","line":85,"range":{"start_line":85,"start_character":36,"end_line":85,"end_character":40},"updated":"2021-04-28 11:54:16.000000000","message":"s/from/for","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  Retrieves a list of subscriptions from the node."},{"line_number":86,"context_line":"  Returns a JSON object listing all available node subscriptions."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  Error codes:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6bfc0b8d_cdfd29f5","line":85,"updated":"2021-04-28 15:31:05.000000000","message":"since the subscriptions will be tied to the node I think we can keep from here.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  Retrieves a list of subscriptions from the node."},{"line_number":86,"context_line":"  Returns a JSON object listing all available node subscriptions."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  Error codes:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9512c10a_fd35053a","line":85,"in_reply_to":"6bfc0b8d_cdfd29f5","updated":"2021-05-19 08:22:09.000000000","message":"Done","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  Retrieves a list of subscriptions from the node."},{"line_number":86,"context_line":"  Returns a JSON object listing all available node subscriptions."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  Error codes:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f56c16ab_6a8d3ca3","line":85,"range":{"start_line":85,"start_character":36,"end_line":85,"end_character":40},"in_reply_to":"b11b390e_7ba5b233","updated":"2021-05-19 08:22:09.000000000","message":"Done","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"uuid\": \"\","},{"line_number":100,"context_line":"            \"node_uuid\": \"\","},{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e0f891b2_508e2fbd","line":102,"updated":"2021-04-26 08:35:03.000000000","message":"Let\u0027s specify what each field means (probably above in the data model impact). E.g. I don\u0027t remember what context is (and we should probably not call anything new context since this term is already overloaded)","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"uuid\": \"\","},{"line_number":100,"context_line":"            \"node_uuid\": \"\","},{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8c4c1b01_7b22db8c","line":102,"in_reply_to":"e0f891b2_508e2fbd","updated":"2021-04-28 15:31:05.000000000","message":"ack","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            \"node_uuid\": \"\","},{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5b73cb9a_ee5d42ed","line":103,"updated":"2021-04-26 08:35:03.000000000","message":"This looks suspicious. The node\u0027s driver already knows its protocol.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            \"node_uuid\": \"\","},{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"}],"source_content_type":"text/x-rst","patch_set":2,"id":"98b357fa_54409147","line":103,"in_reply_to":"5b73cb9a_ee5d42ed","updated":"2021-04-28 15:31:05.000000000","message":"most of the examples they show protocol as required (I will try to add the links I\u0027ve used)","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":true,"context_lines":[{"line_number":100,"context_line":"            \"node_uuid\": \"\","},{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9da2c63f_1501ab49","line":103,"in_reply_to":"98b357fa_54409147","updated":"2021-05-19 08:22:09.000000000","message":"This is reported by the BMC, we can decide if we want to store this field or not.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"},{"line_number":107,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"57270d1a_1a09962d","line":104,"updated":"2021-04-26 08:35:03.000000000","message":"This is not a string.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":102,"context_line":"            \"context\": \"\","},{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"},{"line_number":107,"context_line":"        ]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"00b07666_e6320276","line":104,"in_reply_to":"57270d1a_1a09962d","updated":"2021-04-28 15:31:05.000000000","message":"done","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"},{"line_number":107,"context_line":"        ]"},{"line_number":108,"context_line":"      }"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a52ce934_1deee6c5","line":106,"updated":"2021-04-28 11:54:16.000000000","message":"Must include a field for \"subscription_time\"","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            \"protocol\": \"Redfish\","},{"line_number":104,"context_line":"            \"headers\": \"\","},{"line_number":105,"context_line":"            \"event_type\": [\"Alert\", \"StatusChange\"]"},{"line_number":106,"context_line":"          },"},{"line_number":107,"context_line":"        ]"},{"line_number":108,"context_line":"      }"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9037c770_a39eb290","line":106,"in_reply_to":"a52ce934_1deee6c5","updated":"2021-04-28 15:31:05.000000000","message":"we will probably store the time when we created the subscription in the database, so it will be possible to have this information when requesting the list of subscriptions or a subscription.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  .. code-block:: json"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"      {"},{"line_number":121,"context_line":"       \"target_url\": \"http(s)://host/path\","},{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"75346a9b_eef8a8a2","line":121,"updated":"2021-04-26 08:35:03.000000000","message":"It\u0027s called destination above, I think target_url is slightly better.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  .. code-block:: json"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"      {"},{"line_number":121,"context_line":"       \"target_url\": \"http(s)://host/path\","},{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a6cc791_b6d1acd5","line":121,"in_reply_to":"4439ab93_b9f31057","updated":"2021-05-19 08:22:09.000000000","message":"Thinking a bit more I think we can use destination (to match the redfish schema wdyt)?","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  .. code-block:: json"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"      {"},{"line_number":121,"context_line":"       \"target_url\": \"http(s)://host/path\","},{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4439ab93_b9f31057","line":121,"in_reply_to":"75346a9b_eef8a8a2","updated":"2021-04-28 15:31:05.000000000","message":"I will update","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      {"},{"line_number":121,"context_line":"       \"target_url\": \"http(s)://host/path\","},{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"21621a84_75193fa4","line":123,"updated":"2021-04-26 08:35:03.000000000","message":"Filters are not in the example record above, please synchronize the example records.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      {"},{"line_number":121,"context_line":"       \"target_url\": \"http(s)://host/path\","},{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4e2df9b9_e4f44f52","line":123,"in_reply_to":"21621a84_75193fa4","updated":"2021-05-19 08:22:09.000000000","message":"Looking at the schemas I couldn\u0027t find anything related to filters so I\u0027m removing this.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csubscription_id\u003e``"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"686ac49d_62f06c2f","line":125,"updated":"2021-04-28 11:54:16.000000000","message":"Timestamp of the subscription is required.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csubscription_id\u003e``"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff77c2f6_c52b6965","line":125,"in_reply_to":"0ceec0da_f562e3df","updated":"2021-05-19 08:22:09.000000000","message":"Done","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":true,"context_lines":[{"line_number":122,"context_line":"       \"headers\": \"{}\","},{"line_number":123,"context_line":"       \"filters\": \"\u003cdriver-specific filters\u003e\","},{"line_number":124,"context_line":"       \"uuid\": \"\u003coptional pre-generated subscription UUID\u003e\""},{"line_number":125,"context_line":"      }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csubscription_id\u003e``"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"0ceec0da_f562e3df","line":125,"in_reply_to":"686ac49d_62f06c2f","updated":"2021-04-28 15:31:05.000000000","message":"We don\u0027t pass the timestamp when creating a subscription (at least I couldn\u0027t find any redfish examples with this)","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csubscription_id\u003e``"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Requests the deletion of a subscription"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  HTPP codes:"},{"line_number":132,"context_line":"  * 204 No Content"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5677e95c_6c02174e","line":129,"updated":"2021-04-26 08:35:03.000000000","message":"Requests or deletes? I.e. is it synchronous or asynchronous? Does it have any side effects?","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csubscription_id\u003e``"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  Requests the deletion of a subscription"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  HTPP codes:"},{"line_number":132,"context_line":"  * 204 No Content"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fb908966_7e00a31b","line":129,"in_reply_to":"5677e95c_6c02174e","updated":"2021-05-19 08:22:09.000000000","message":"The tests I did with iLO and iDRAC both return 200 in DELETE, we can consider calling async in ironic without problems I think","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. code-block:: bash"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    baremetal node subscription add \u003cnode\u003e \u003csubscription\u003e"},{"line_number":142,"context_line":"    baremetal node subscription delete subscription \u003cnode\u003e \u003csubscription\u003e"},{"line_number":143,"context_line":"    baremetal node subscription list \u003cnode\u003e"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"38d7f126_68d9852d","line":141,"updated":"2021-04-26 08:35:03.000000000","message":"s/add/create/\n\nlet\u0027s maybe show at least the most important arguments?","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. code-block:: bash"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    baremetal node subscription add \u003cnode\u003e \u003csubscription\u003e"},{"line_number":142,"context_line":"    baremetal node subscription delete subscription \u003cnode\u003e \u003csubscription\u003e"},{"line_number":143,"context_line":"    baremetal node subscription list \u003cnode\u003e"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"0ebce0ed_86c165dc","line":141,"in_reply_to":"38d7f126_68d9852d","updated":"2021-04-28 15:31:05.000000000","message":"ack","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":139,"context_line":".. code-block:: bash"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    baremetal node subscription add \u003cnode\u003e \u003csubscription\u003e"},{"line_number":142,"context_line":"    baremetal node subscription delete subscription \u003cnode\u003e \u003csubscription\u003e"},{"line_number":143,"context_line":"    baremetal node subscription list \u003cnode\u003e"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5e8605f0_2fedb96a","line":142,"updated":"2021-04-26 08:35:03.000000000","message":"redundant subscription","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":139,"context_line":".. code-block:: bash"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    baremetal node subscription add \u003cnode\u003e \u003csubscription\u003e"},{"line_number":142,"context_line":"    baremetal node subscription delete subscription \u003cnode\u003e \u003csubscription\u003e"},{"line_number":143,"context_line":"    baremetal node subscription list \u003cnode\u003e"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\"openstack baremetal\" CLI"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e96c9ad4_350aedf6","line":142,"in_reply_to":"5e8605f0_2fedb96a","updated":"2021-04-28 15:31:05.000000000","message":"my bad \u003d)","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    baremetal node subscription list \u003cnode\u003e"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\"openstack baremetal\" CLI"},{"line_number":146,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The following commands will be created:"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"135b710f_46b8d7da","line":146,"updated":"2021-04-26 08:35:03.000000000","message":"Redundant","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    baremetal node subscription list \u003cnode\u003e"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\"openstack baremetal\" CLI"},{"line_number":146,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The following commands will be created:"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e04c794e_1e117a0b","line":146,"in_reply_to":"135b710f_46b8d7da","updated":"2021-04-28 15:31:05.000000000","message":"So, I should just remove?","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def remove_subscription(self, task, subscription):"},{"line_number":195,"context_line":"        \"\"\"Remove the subscription object from the BMC.\"\"\""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The above methods are implemented for Redfish hardware types."},{"line_number":199,"context_line":"We will disallow changing the management interface of a node if there are"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c8772c0_7a5d789c","line":196,"updated":"2021-04-28 11:54:16.000000000","message":"isn\u0027t it worth to have update_subscription?","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":true,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def remove_subscription(self, task, subscription):"},{"line_number":195,"context_line":"        \"\"\"Remove the subscription object from the BMC.\"\"\""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The above methods are implemented for Redfish hardware types."},{"line_number":199,"context_line":"We will disallow changing the management interface of a node if there are"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4cc1d307_257810bb","line":196,"in_reply_to":"3c8772c0_7a5d789c","updated":"2021-04-28 15:31:05.000000000","message":"Maybe, I\u0027m not sure I will be able to cover the update part, that\u0027s why I\u0027ve only added the add/remove","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1de4d6ca6efc26fe2d2f1b404bceab4b0e34c344","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def remove_subscription(self, task, subscription):"},{"line_number":195,"context_line":"        \"\"\"Remove the subscription object from the BMC.\"\"\""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"The above methods are implemented for Redfish hardware types."},{"line_number":199,"context_line":"We will disallow changing the management interface of a node if there are"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0abd3c66_da415c9b","line":196,"in_reply_to":"4cc1d307_257810bb","updated":"2021-05-19 08:22:09.000000000","message":"Based on my tests only iLO accepted the update action, so I don\u0027t think it\u0027s worth.","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1b6c8208cf4a8aadf2cce45f6566d9e7c0f08240","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Security impact"},{"line_number":213,"context_line":"---------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"None."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"792258ce_876a95e8","line":214,"updated":"2021-04-28 11:54:16.000000000","message":"Should not we allow only HTTPS URL\u0027s. Or atleast we need a note here mentioning the risks of not using https URLs","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Security impact"},{"line_number":213,"context_line":"---------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"None."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ec486db5_1c6baa2a","line":214,"in_reply_to":"792258ce_876a95e8","updated":"2021-04-28 15:31:05.000000000","message":"Let\u0027s see what others think about this","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":262,"context_line":"Dependencies"},{"line_number":263,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* .. _Metal3 BMC event API: https://github.com/metal3-io/metal3-docs/pull/167"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"* Sushy needs to have support for Event Subscriptions."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a9aadf86_7bca38ef","line":265,"updated":"2021-04-26 08:35:03.000000000","message":"It\u0027s not a dependency","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":262,"context_line":"Dependencies"},{"line_number":263,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* .. _Metal3 BMC event API: https://github.com/metal3-io/metal3-docs/pull/167"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"* Sushy needs to have support for Event Subscriptions."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e10f417b_11b2e855","line":265,"in_reply_to":"a9aadf86_7bca38ef","updated":"2021-04-28 15:31:05.000000000","message":"Yeah, I will remove","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"89f22e6ca376ffb1a847b81f29313c4f1d189a61","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"* Sushy needs to have support for Event Subscriptions."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"* This feature will be implemented for Redfish hardware type."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Testing"},{"line_number":272,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f8f9d7c5_3bb23d28","line":269,"updated":"2021-04-26 08:35:03.000000000","message":"These two are work items","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7898c35dede870add212f85fa4b531716c781505","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"* Sushy needs to have support for Event Subscriptions."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"* This feature will be implemented for Redfish hardware type."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Testing"},{"line_number":272,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"673f2f53_73c6896e","line":269,"in_reply_to":"f8f9d7c5_3bb23d28","updated":"2021-04-28 15:31:05.000000000","message":"It\u0027s already there \u003d)","commit_id":"f910f109419d885015d34786d32cf30c1b147b50"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0b8163121caae7dada26a0b11698b493c0af12af","unresolved":true,"context_lines":[{"line_number":20,"context_line":"* Provide a way to poll for events."},{"line_number":21,"context_line":"* Proxy notifications (see [RFE 2008555](https://storyboard.openstack.org/#!/story/2008555))."},{"line_number":22,"context_line":"* Store events in ironic at all."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6a28072b_595b0e54","line":23,"updated":"2021-05-24 14:55:11.000000000","message":"I\u0027d add a non-goal:\n* Update an existing subscription in the BMC, at this time, as some vendors support partial updates where as other vendors essentially require a delete/re-creation to perform an update. This may be something that can be added later, but it seems not feasible at this time.","commit_id":"d5fb6234cd16b41bff3a20730103fc53fae47a12"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"547b6c43bf7814494ce14a598d12e59a7c5fb033","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Provide a way to poll for events."},{"line_number":21,"context_line":"* Proxy notifications (see [RFE 2008555](https://storyboard.openstack.org/#!/story/2008555))."},{"line_number":22,"context_line":"* Store events in ironic at all."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"85fad28b_12e9244a","line":23,"in_reply_to":"6a28072b_595b0e54","updated":"2021-05-24 14:59:15.000000000","message":"Ack","commit_id":"d5fb6234cd16b41bff3a20730103fc53fae47a12"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0b8163121caae7dada26a0b11698b493c0af12af","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  Error codes:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  * 404 Not Found if node is not found."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  Example response object:"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"c9a0f1cc_b94c41ca","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":39},"updated":"2021-05-24 14:55:11.000000000","message":"technically this should not return a 404, but an emtpy list if there are no  subscriptions. A 404 would be if the microversion is not high enough for the API consumer.","commit_id":"d5fb6234cd16b41bff3a20730103fc53fae47a12"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"547b6c43bf7814494ce14a598d12e59a7c5fb033","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  Error codes:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"  * 404 Not Found if node is not found."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  Example response object:"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"6e29e108_b1aee6d8","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":39},"in_reply_to":"c9a0f1cc_b94c41ca","updated":"2021-05-24 14:59:15.000000000","message":"404 here would be in the case where the node is not found \u003d)\nI will add this details","commit_id":"d5fb6234cd16b41bff3a20730103fc53fae47a12"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0b8163121caae7dada26a0b11698b493c0af12af","unresolved":true,"context_lines":[{"line_number":139,"context_line":"  Requests the deletion of a subscription"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  HTPP codes:"},{"line_number":142,"context_line":"  * 204 No Content"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Client (CLI) impact"},{"line_number":145,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"befdb549_5fe5f8cb","line":142,"updated":"2021-05-24 14:55:11.000000000","message":"I\u0027d add a note that the patch verb is not being supported at this time in this feature.","commit_id":"d5fb6234cd16b41bff3a20730103fc53fae47a12"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"547b6c43bf7814494ce14a598d12e59a7c5fb033","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  Requests the deletion of a subscription"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  HTPP codes:"},{"line_number":142,"context_line":"  * 204 No Content"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Client (CLI) impact"},{"line_number":145,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7593c7c3_1c2beb8c","line":142,"in_reply_to":"befdb549_5fe5f8cb","updated":"2021-05-24 14:59:15.000000000","message":"Ack","commit_id":"d5fb6234cd16b41bff3a20730103fc53fae47a12"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ba4f63fb028721a7301a7ba4afdd9e5808ca3949","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Store events in ironic at all."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Update an existing subscription in the BMC, at this time, as some vendors"},{"line_number":28,"context_line":"  support partial updates where as other vendors essentially require a"},{"line_number":29,"context_line":"  delete/re-creation to perform an update. This may be something that can"},{"line_number":30,"context_line":"  be added later, but it seems not feasible at this time."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cfc04be0_303a8b3e","line":29,"range":{"start_line":27,"start_character":60,"end_line":29,"end_character":41},"updated":"2021-06-11 08:08:07.000000000","message":"What is meant with partial update? Is it updating all eligible fields by Redfish spec excluding read-only fields? Or is it updating all subscription fields stored in ironic of which some are read-only by Redfish spec?\n\nIf goal is to update all fields stored in Ironic, then current Redfish spec does not support that and delete/re-creation is necessary to update read-only fields.\n\nAre there currently vendors that support updating Redfish read-only fields such as protocol, destination? Or is this about non-Redfish implementations?","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b7e8f20c306eb772fed48cd337990878ab573cd2","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Store events in ironic at all."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Update an existing subscription in the BMC, at this time, as some vendors"},{"line_number":28,"context_line":"  support partial updates where as other vendors essentially require a"},{"line_number":29,"context_line":"  delete/re-creation to perform an update. This may be something that can"},{"line_number":30,"context_line":"  be added later, but it seems not feasible at this time."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c524744b_df9eec35","line":29,"range":{"start_line":27,"start_character":60,"end_line":29,"end_character":41},"in_reply_to":"93293968_d493827d","updated":"2021-06-14 13:47:50.000000000","message":"then could be more specific which fields can be updated and which will never be possible to update.\n\nFrom another side (thinking aloud) this should be invisible to ironic user as behind the scenes existing subscriptions could be deleted and new created as long as ironic\u0027s uuid remains the same. In this case it wouldn\u0027t matter how much BMC support patching now. The blocker to this is that http headers are not stored in ironic and they can get lost with delete/create pretending to be update.\n\nWould add somewhere in the spec which fields are envisioned to be editable. Not knowing anything about Redfish spec, I would assume that all fields (except uuid) could be updated.","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2b04dfda68a8872ebc33dcb0a893825c02b4620c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Store events in ironic at all."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Update an existing subscription in the BMC, at this time, as some vendors"},{"line_number":28,"context_line":"  support partial updates where as other vendors essentially require a"},{"line_number":29,"context_line":"  delete/re-creation to perform an update. This may be something that can"},{"line_number":30,"context_line":"  be added later, but it seems not feasible at this time."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"512e99ed_ce43d623","line":29,"range":{"start_line":27,"start_character":60,"end_line":29,"end_character":41},"in_reply_to":"c524744b_df9eec35","updated":"2021-06-25 13:41:18.000000000","message":"I like the idea of the conductor just ripping/replacing and not making any assumptions on trying to support some BMCs which support partial updates, and others that do not. That way we keep it as simple as possible mechanics wise. To the point of the ironic user, they don\u0027t *need* to know that detail really, as long as the task is completed in the end and ultimately regarding storing the headers. If we need to, we can temporarily house something like a header if an action had to cross tasks in driver_internal_info, as long as the name ends in _secret so it will get scrubbed from being exposed by the api... But I don\u0027t see why that would really need to be the case anyway.","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa26a82b7d90f9e63aed889d044be23099b19057","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"* Store events in ironic at all."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Update an existing subscription in the BMC, at this time, as some vendors"},{"line_number":28,"context_line":"  support partial updates where as other vendors essentially require a"},{"line_number":29,"context_line":"  delete/re-creation to perform an update. This may be something that can"},{"line_number":30,"context_line":"  be added later, but it seems not feasible at this time."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"93293968_d493827d","line":29,"range":{"start_line":27,"start_character":60,"end_line":29,"end_character":41},"in_reply_to":"cfc04be0_303a8b3e","updated":"2021-06-11 08:37:37.000000000","message":"partial updates - fields that can be updated according to the redfish spec.","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"ba4f63fb028721a7301a7ba4afdd9e5808ca3949","unresolved":true,"context_lines":[{"line_number":74,"context_line":"* subscription_id (based on the BMC)"},{"line_number":75,"context_line":"* context"},{"line_number":76,"context_line":"* destination"},{"line_number":77,"context_line":"* event_types"},{"line_number":78,"context_line":"* protocol"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"A database migration will be provided to create the new table when doing an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5e646958_265f9b92","line":77,"range":{"start_line":77,"start_character":2,"end_line":77,"end_character":13},"updated":"2021-06-11 08:08:07.000000000","message":"EventTypes is getting deprecated in Redfish, though it\u0027s what currently at least iDRAC implements. Any plans for supporting non-deprecated options in future from Ironic?","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aa26a82b7d90f9e63aed889d044be23099b19057","unresolved":true,"context_lines":[{"line_number":74,"context_line":"* subscription_id (based on the BMC)"},{"line_number":75,"context_line":"* context"},{"line_number":76,"context_line":"* destination"},{"line_number":77,"context_line":"* event_types"},{"line_number":78,"context_line":"* protocol"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"A database migration will be provided to create the new table when doing an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e2feb58a_4a40b3aa","line":77,"range":{"start_line":77,"start_character":2,"end_line":77,"end_character":13},"in_reply_to":"5e646958_265f9b92","updated":"2021-06-11 08:37:37.000000000","message":"Yeah I just saw in [1], seems like it will be replaced by RegistryPrefix and ResourceType,\nmy idea is to first provide initial support for what I see vendors using, what EventDestination version iDRAC is supporting atm (latest FW) ? Do you know have an estimated time for when the new options will be used?\n\nConsidering the Ironic API I think the approach would be new fields we would introduce in the future to handle RegistryPrefix/ResourceType and making them optional and sushy would be able to handle different versions wdyt?\n\n[1] https://redfish.dmtf.org/schemas/v1/EventDestination.v1_10_1.json","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2e3ffeff3dd2f5f8503aad10995152fb4b3bf260","unresolved":false,"context_lines":[{"line_number":74,"context_line":"* subscription_id (based on the BMC)"},{"line_number":75,"context_line":"* context"},{"line_number":76,"context_line":"* destination"},{"line_number":77,"context_line":"* event_types"},{"line_number":78,"context_line":"* protocol"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"A database migration will be provided to create the new table when doing an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"22501667_4d155e6c","line":77,"range":{"start_line":77,"start_character":2,"end_line":77,"end_character":13},"in_reply_to":"b3908fd9_c6e6aa88","updated":"2021-06-28 09:43:59.000000000","message":"Based on discussion on IRC I\u0027m dropping EventTypes\nhttps://meetings.opendev.org/irclogs/%23openstack-ironic/%23openstack-ironic.2021-06-25.log.html#t2021-06-25T13:41:57","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2b04dfda68a8872ebc33dcb0a893825c02b4620c","unresolved":true,"context_lines":[{"line_number":74,"context_line":"* subscription_id (based on the BMC)"},{"line_number":75,"context_line":"* context"},{"line_number":76,"context_line":"* destination"},{"line_number":77,"context_line":"* event_types"},{"line_number":78,"context_line":"* protocol"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"A database migration will be provided to create the new table when doing an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b3908fd9_c6e6aa88","line":77,"range":{"start_line":77,"start_character":2,"end_line":77,"end_character":13},"in_reply_to":"b679f3d5_7bc2c2b8","updated":"2021-06-25 13:41:18.000000000","message":"So at some point, I have to wonder, is the field even needed?","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b7e8f20c306eb772fed48cd337990878ab573cd2","unresolved":true,"context_lines":[{"line_number":74,"context_line":"* subscription_id (based on the BMC)"},{"line_number":75,"context_line":"* context"},{"line_number":76,"context_line":"* destination"},{"line_number":77,"context_line":"* event_types"},{"line_number":78,"context_line":"* protocol"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"A database migration will be provided to create the new table when doing an"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b679f3d5_7bc2c2b8","line":77,"range":{"start_line":77,"start_character":2,"end_line":77,"end_character":13},"in_reply_to":"e2feb58a_4a40b3aa","updated":"2021-06-14 13:47:50.000000000","message":"iDRAC reports v.1.9.0, but that does not mean that RegistryPrefix/ResourceType are supported. I\u0027m checking what are the plans for this.\n\nIt could be OK to base new feature on deprecated stuff, though feels odd - assuming EventTypes will be supported for years until removed if at all. But this is just a wild guess. Also don\u0027t know what\u0027s the status of other vendors. Is any supporting RegistryPrefix/ResourceType now?","commit_id":"181a0807c920875838cd45f26be79cd612514baf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b4b50cbaa306dd0b7bd2913b17751039967e2624","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  be added later, but it seems not feasible at this time."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Choosing EventTypes when creating a subscription won\u0027t be supported,"},{"line_number":33,"context_line":"  since option is deprecated since EventDestination v1_5_0."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"30f60bcf_7d0270b2","line":33,"updated":"2021-06-29 14:32:32.000000000","message":"nit: I\u0027d personally link to it, but its all good.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  be added later, but it seems not feasible at this time."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* Choosing EventTypes when creating a subscription won\u0027t be supported,"},{"line_number":33,"context_line":"  since option is deprecated since EventDestination v1_5_0."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"94d2ad64_30383049","line":33,"in_reply_to":"30f60bcf_7d0270b2","updated":"2021-07-09 15:12:55.000000000","message":"Done","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"#. Delete a subscription ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csub_id\u003e``"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#. List all subscriptions ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f46eb39_65972ec7","line":61,"updated":"2021-07-08 12:31:18.000000000","message":"nit: and get one subscription","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"#. Delete a subscription ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csub_id\u003e``"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#. List all subscriptions ``GET /v1/nodes/\u003cnode\u003e/subscriptions``"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"404366a2_f6df6426","line":61,"in_reply_to":"9f46eb39_65972ec7","updated":"2021-07-09 15:12:55.000000000","message":"Done","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* uuid"},{"line_number":77,"context_line":"* node_id"},{"line_number":78,"context_line":"* subscription_id (based on the BMC)"},{"line_number":79,"context_line":"* context"},{"line_number":80,"context_line":"* destination"},{"line_number":81,"context_line":"* protocol"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"e3bbbc52_c62656be","line":79,"updated":"2021-07-08 12:31:18.000000000","message":"Some explanation could be useful. What is context here?","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":78,"context_line":"* subscription_id (based on the BMC)"},{"line_number":79,"context_line":"* context"},{"line_number":80,"context_line":"* destination"},{"line_number":81,"context_line":"* protocol"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":84,"context_line":"upgrade."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffc60989_08a12e9e","line":81,"updated":"2021-07-08 12:31:18.000000000","message":"What are possible values here?","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"* subscription_id (based on the BMC)"},{"line_number":79,"context_line":"* context"},{"line_number":80,"context_line":"* destination"},{"line_number":81,"context_line":"* protocol"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":84,"context_line":"upgrade."}],"source_content_type":"text/x-rst","patch_set":5,"id":"f75ffa80_e4d310e3","line":81,"in_reply_to":"ffc60989_08a12e9e","updated":"2021-07-09 15:12:55.000000000","message":"Removed based on IRC discussion, we will be default to \"Redfish\" since is the value the schema shows.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":79,"context_line":"* context"},{"line_number":80,"context_line":"* destination"},{"line_number":81,"context_line":"* protocol"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":84,"context_line":"upgrade."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"873066e4_316731de","line":82,"updated":"2021-07-08 12:31:18.000000000","message":"Should we support \"extra\" like most other resources?","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"* context"},{"line_number":80,"context_line":"* destination"},{"line_number":81,"context_line":"* protocol"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"A database migration will be provided to create the new table when doing an"},{"line_number":84,"context_line":"upgrade."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"d805519a_6ec564e0","line":82,"in_reply_to":"873066e4_316731de","updated":"2021-07-09 15:12:55.000000000","message":"Added extra to keep consistency between the resources.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      {"},{"line_number":112,"context_line":"        \"subscriptions\": ["},{"line_number":113,"context_line":"          {"},{"line_number":114,"context_line":"            \"uuid\": \"\u003csubscription_uuid_generated_by_ironic\u003e\","},{"line_number":115,"context_line":"            \"node_uuid\": \"\u003cnode_uuid\u003e\","},{"line_number":116,"context_line":"            \"subscription_id\": \"\u003cid_generated_by_the_bmc\u003e\","},{"line_number":117,"context_line":"            \"destination\": \"http(s)://host/path\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"f91d2368_ea23096b","line":114,"updated":"2021-07-08 12:31:18.000000000","message":"Yep, we\u0027ll need to enable this","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b4b50cbaa306dd0b7bd2913b17751039967e2624","unresolved":true,"context_lines":[{"line_number":111,"context_line":"      {"},{"line_number":112,"context_line":"        \"subscriptions\": ["},{"line_number":113,"context_line":"          {"},{"line_number":114,"context_line":"            \"uuid\": \"\u003csubscription_uuid_generated_by_ironic\u003e\","},{"line_number":115,"context_line":"            \"node_uuid\": \"\u003cnode_uuid\u003e\","},{"line_number":116,"context_line":"            \"subscription_id\": \"\u003cid_generated_by_the_bmc\u003e\","},{"line_number":117,"context_line":"            \"destination\": \"http(s)://host/path\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"e9b98bbf_d2fa8863","line":114,"updated":"2021-06-29 14:32:32.000000000","message":"possible question, can the client post a uuid? This *might* be helpful for things like metal3. We do this in node creation.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      {"},{"line_number":112,"context_line":"        \"subscriptions\": ["},{"line_number":113,"context_line":"          {"},{"line_number":114,"context_line":"            \"uuid\": \"\u003csubscription_uuid_generated_by_ironic\u003e\","},{"line_number":115,"context_line":"            \"node_uuid\": \"\u003cnode_uuid\u003e\","},{"line_number":116,"context_line":"            \"subscription_id\": \"\u003cid_generated_by_the_bmc\u003e\","},{"line_number":117,"context_line":"            \"destination\": \"http(s)://host/path\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"8b66df53_5b50724d","line":114,"in_reply_to":"e9b98bbf_d2fa8863","updated":"2021-07-09 15:12:55.000000000","message":"Done","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            \"subscription_id\": \"\u003cid_generated_by_the_bmc\u003e\","},{"line_number":117,"context_line":"            \"destination\": \"http(s)://host/path\","},{"line_number":118,"context_line":"            \"context\": \"\u003ccontext\u003e\","},{"line_number":119,"context_line":"            \"protocol\": \"Redfish\""},{"line_number":120,"context_line":"          },"},{"line_number":121,"context_line":"          {"},{"line_number":122,"context_line":"            \"uuid\": \"\u003csubscription_uuid_generated_by_ironic\u003e\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"8913a10a_13ea077c","line":119,"updated":"2021-07-08 12:31:18.000000000","message":"This is defined by the node\u0027s driver, why is it needed here?","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":146,"context_line":"       \"protocol\": \"Redfish\""},{"line_number":147,"context_line":"       \"destination\": \"http(s)://host/path\","},{"line_number":148,"context_line":"       \"context\": \"some context\","},{"line_number":149,"context_line":"       \"http_headers\": [{\"Content-Type\":\"application/json\"}]"},{"line_number":150,"context_line":"      }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"* ``DELETE /v1/nodes/\u003cnode\u003e/subscriptions/\u003csubscription_id\u003e``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1e549acd_6a00c64c","line":149,"updated":"2021-07-08 12:31:18.000000000","message":"This fiels is not mentioned anywhere else (and content-type is not a great example, let\u0027s use authentication)","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: bash"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    baremetal node subscription create [node] [destination] [event_types] [context] [protocol] \u003cheaders\u003e"},{"line_number":171,"context_line":"    baremetal node subscription delete [subscription_uuid]"},{"line_number":172,"context_line":"    baremetal node subscription list [node]"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"66a4ef0e_a66f56d5","line":170,"updated":"2021-07-08 12:31:18.000000000","message":"Which of the argument are actually positional? I suspect none of them, but worth checking.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: bash"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    baremetal node subscription create [node] [destination] [event_types] [context] [protocol] \u003cheaders\u003e"},{"line_number":171,"context_line":"    baremetal node subscription delete [subscription_uuid]"},{"line_number":172,"context_line":"    baremetal node subscription list [node]"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"65095083_448ab0b7","line":170,"in_reply_to":"66a4ef0e_a66f56d5","updated":"2021-07-09 15:12:55.000000000","message":"I\u0027ve updated and added :optional if the argument is optional during create","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"065fbc6c0b72c4fb86a73c1bf166d09b83c077db","unresolved":false,"context_lines":[{"line_number":168,"context_line":".. code-block:: bash"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    baremetal node subscription create [node] [destination] [event_types] [context] [protocol] \u003cheaders\u003e"},{"line_number":171,"context_line":"    baremetal node subscription delete [subscription_uuid]"},{"line_number":172,"context_line":"    baremetal node subscription list [node]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\"openstacksdk\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"f18b054d_0cafcaf9","line":171,"updated":"2021-07-08 12:31:18.000000000","message":"It feels weird to miss node here..\n\nActually, since it\u0027s not strictly a subresource of a Node, maybe move it to top level? like\n\n baremetal subscription create --node \u003cnode ID\u003e --destination \u003cURL\u003e\n\n? Then you won\u0027t need to have mandatory node everywhere.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":168,"context_line":".. code-block:: bash"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    baremetal node subscription create [node] [destination] [event_types] [context] [protocol] \u003cheaders\u003e"},{"line_number":171,"context_line":"    baremetal node subscription delete [subscription_uuid]"},{"line_number":172,"context_line":"    baremetal node subscription list [node]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\"openstacksdk\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"eac3ba01_a5484169","line":171,"in_reply_to":"f18b054d_0cafcaf9","updated":"2021-07-09 15:12:55.000000000","message":"Yeah, I\u0027ve updated to top level API and the node is required to create.\nTo delete we need the subscription uuid only to keep it simple.","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1942633064beb48f670d11e6745ead395c5be3e0","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    baremetal node subscription create [node] [destination] [event_types] [context] [protocol] \u003cheaders\u003e"},{"line_number":171,"context_line":"    baremetal node subscription delete [subscription_uuid]"},{"line_number":172,"context_line":"    baremetal node subscription list [node]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\"openstacksdk\""},{"line_number":175,"context_line":"~~~~~~~~~~~~~~"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"6fbbf4b5_cd93bc27","line":173,"updated":"2021-07-09 15:12:55.000000000","message":"added baremetal subscription show \u003csubscription uuid\u003e","commit_id":"602d1116c05612812d2c759dac3575721b106eef"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"42b4cebb2ed2d4640a433d0834e5d633de70b86b","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    def add_subscription(self, task, subscription):"},{"line_number":225,"context_line":"        \"\"\"Add the new subscription object to the BMC.\"\"\""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def remove_subscription(self, task, subscription):"},{"line_number":228,"context_line":"        \"\"\"Remove the subscription object from the BMC.\"\"\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"The above methods are implemented for Redfish hardware types."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bd761d99_2b8e1f4b","line":228,"range":{"start_line":227,"start_character":3,"end_line":228,"end_character":58},"updated":"2021-07-16 06:07:29.000000000","message":"Would get_subscriptions() be required? \n\nSome BMC like iLO could delete a subscription in case it continuously fails to post events at its destination. The subscription is deleted automatically after a certain amount of time (DeliveryRetryAttempts * DeliveryRetryIntervalSeconds seconds). The DeliveryRetryAttempts and DeliveryRetryIntervalSeconds is configurable.\n\nThis can cause subscriptions held by Ironic and at BMC to differ.","commit_id":"6b7d81156366bf8e60de67bae122fdf72a2e06b7"}]}