)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40f1367b_86d5a2cf","updated":"2022-12-05 15:49:04.000000000","message":"Greetings! Thanks! This is in a good initial state. I think we\u0027re glossing over the conductor inner workings, but I *believe* that has been stated in other specs. Whether those specs are approved, I\u0027m not sure.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d50991ebe81b6addfdde1a5885dd1260c5e762cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f95793d1_e0b47655","updated":"2022-12-12 16:25:31.000000000","message":"looks good, thanks!\nleaving open to let other cores review it","commit_id":"9a8ea0ae019eb51648c18d8bfc4d1a9c09e3c77a"}],"specs/approved/vnc-console.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fbe413e6_6752fa67","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"updated":"2022-12-05 15:49:04.000000000","message":"This is a nova integrated specific command, fwiw.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"439cba906914900c5a07b0b8c450d9baad3a13d4","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cb9c81ab_e114df2a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"5e5f5b2b_157d8df0","updated":"2022-12-12 16:54:59.000000000","message":"the same as Nova did via ironic client - we have a get_console method which returns an \"enabled console\" url. so if you switch on vnc? the result will be vnc url","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7cb81421ef1a1255885eeb138b88ced7c68aa25c","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5e5f5b2b_157d8df0","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"90261a39_5f4ec800","updated":"2022-12-12 14:36:48.000000000","message":"No, the note was more for other reviewers. If I was using ironic directly, I think we would return the url via the existing mechanism.... I think.\n\nActually this raises a good question, how would I ask ironic directly for the url?","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a82e9b029481a1ecd4dcf9a60d986734f67ec42","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"19e5f0ad_d14036be","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"9b70daf9_f85ebd17","updated":"2023-01-09 17:15:27.000000000","message":"develop your service! And we\u0027ll go from there I guess.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8f5bcfb8d4e569dd898c58b7c98747882a570b81","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fe52fce2_139107ab","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"cb9c81ab_e114df2a","updated":"2022-12-13 18:38:05.000000000","message":"That seems reasonable to me. I think we had a spec out there to make that selectable as well.... but all good. Thanks for the follow-up.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"90261a39_5f4ec800","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"fbe413e6_6752fa67","updated":"2022-12-08 10:30:37.000000000","message":"it\u0027s just an example how end user can work with it. Should i delete it?","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"45362551a4ab6c174ebcddf98353a779ff3fe21b","unresolved":true,"context_lines":[{"line_number":33,"context_line":"server:"},{"line_number":34,"context_line":"switch console type on bm side to ``vnc``"},{"line_number":35,"context_line":"``openstack baremetal node console enable``"},{"line_number":36,"context_line":"``openstack console url show --novnc``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9b70daf9_f85ebd17","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"fe52fce2_139107ab","updated":"2022-12-27 08:44:15.000000000","message":"thanks\nwhat steps will be next?","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* for supporting vnc handshake we have to implement proxy service as a part"},{"line_number":42,"context_line":"of security isolation. During handshake ``vnc password`` is used. It is stored"},{"line_number":43,"context_line":"on ironic side in ``driver_info``: \u0027drac_vnc_password\u0027: \u0027******\u0027, and without"},{"line_number":44,"context_line":"proxy need to be provided to Nova. With novncproxy Nova internals don\u0027t need"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c2c70ad8_37bbadee","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":20},"updated":"2022-12-05 15:49:04.000000000","message":"I\u0027d s/* for supporting vnc handshake/In order to support the handshake for VNC authentication,/","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* for supporting vnc handshake we have to implement proxy service as a part"},{"line_number":42,"context_line":"of security isolation. During handshake ``vnc password`` is used. It is stored"},{"line_number":43,"context_line":"on ironic side in ``driver_info``: \u0027drac_vnc_password\u0027: \u0027******\u0027, and without"},{"line_number":44,"context_line":"proxy need to be provided to Nova. With novncproxy Nova internals don\u0027t need"}],"source_content_type":"text/x-rst","patch_set":1,"id":"238a5f8e_05104fe9","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":20},"in_reply_to":"c2c70ad8_37bbadee","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* for supporting vnc handshake we have to implement proxy service as a part"},{"line_number":42,"context_line":"of security isolation. During handshake ``vnc password`` is used. It is stored"},{"line_number":43,"context_line":"on ironic side in ``driver_info``: \u0027drac_vnc_password\u0027: \u0027******\u0027, and without"},{"line_number":44,"context_line":"proxy need to be provided to Nova. With novncproxy Nova internals don\u0027t need"},{"line_number":45,"context_line":"internal details of the BMC network. Expected that this new service can be"},{"line_number":46,"context_line":"based on nova_novncproxy."}],"source_content_type":"text/x-rst","patch_set":1,"id":"760bb63d_49fcc9e4","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":65},"updated":"2022-12-05 15:49:04.000000000","message":"The field masking code will hide the value by default, fwiw, as \"password\" is in the value name. Also, we typically refer to these nested fields as ``driver_info/field_name``\n\nI guess another aspect is this is a DRAC-ism, and is not applicable to other interfaces. It is worthwhile to explicitly mention it. Since this is not the preferred path, we woudl rather create/generate/set passwords instead of relying upon pre-existing passwords.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* for supporting vnc handshake we have to implement proxy service as a part"},{"line_number":42,"context_line":"of security isolation. During handshake ``vnc password`` is used. It is stored"},{"line_number":43,"context_line":"on ironic side in ``driver_info``: \u0027drac_vnc_password\u0027: \u0027******\u0027, and without"},{"line_number":44,"context_line":"proxy need to be provided to Nova. With novncproxy Nova internals don\u0027t need"},{"line_number":45,"context_line":"internal details of the BMC network. Expected that this new service can be"},{"line_number":46,"context_line":"based on nova_novncproxy."}],"source_content_type":"text/x-rst","patch_set":1,"id":"be9254d9_c1a47a11","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":65},"in_reply_to":"760bb63d_49fcc9e4","updated":"2022-12-08 10:30:37.000000000","message":"this password is a legacy standard. it is a 8 symbols string\nand can be set via web interface. End user will not know anything about this password it is only for admin. Per my understanding only admin can use bm web interface. VNC also supports handshake with out password but on drac it was impossible to select it. Only with password.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a82e9b029481a1ecd4dcf9a60d986734f67ec42","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* for supporting vnc handshake we have to implement proxy service as a part"},{"line_number":42,"context_line":"of security isolation. During handshake ``vnc password`` is used. It is stored"},{"line_number":43,"context_line":"on ironic side in ``driver_info``: \u0027drac_vnc_password\u0027: \u0027******\u0027, and without"},{"line_number":44,"context_line":"proxy need to be provided to Nova. With novncproxy Nova internals don\u0027t need"},{"line_number":45,"context_line":"internal details of the BMC network. Expected that this new service can be"},{"line_number":46,"context_line":"based on nova_novncproxy."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e3336276_48eca50b","line":43,"range":{"start_line":43,"start_character":34,"end_line":43,"end_character":65},"in_reply_to":"be9254d9_c1a47a11","updated":"2023-01-09 17:15:27.000000000","message":"ack, thanks.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":45,"context_line":"internal details of the BMC network. Expected that this new service can be"},{"line_number":46,"context_line":"based on nova_novncproxy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* for drac will be created a vnc driver based on ``base.ConsoleInterface`` "},{"line_number":49,"context_line":" "},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"589a2536_bc587046","line":49,"range":{"start_line":48,"start_character":75,"end_line":49,"end_character":1},"updated":"2022-12-05 15:49:04.000000000","message":"Whitespace on this line and the prior line. This is a linter error.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":45,"context_line":"internal details of the BMC network. Expected that this new service can be"},{"line_number":46,"context_line":"based on nova_novncproxy."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* for drac will be created a vnc driver based on ``base.ConsoleInterface`` "},{"line_number":49,"context_line":" "},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2ec78577_5fe604fd","line":49,"range":{"start_line":48,"start_character":75,"end_line":49,"end_character":1},"in_reply_to":"589a2536_bc587046","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* Accept this limitation and only offer a serial console. "},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":57,"context_line":"serial proxy and shell in a box for nova provisioned ironic baremetal"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6a3b6264_05710cdf","line":54,"updated":"2022-12-05 15:49:04.000000000","message":"Another end of line linter error","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* Accept this limitation and only offer a serial console. "},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":57,"context_line":"serial proxy and shell in a box for nova provisioned ironic baremetal"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f19f4f1b_90f1f5e5","line":54,"in_reply_to":"6a3b6264_05710cdf","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":57,"context_line":"serial proxy and shell in a box for nova provisioned ironic baremetal"},{"line_number":58,"context_line":"intances."},{"line_number":59,"context_line":"00"},{"line_number":60,"context_line":"* Use out-of-band KVM access provided by administrator without Ironic support."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"310c8aa3_577d0bb2","line":58,"updated":"2022-12-05 15:49:04.000000000","message":"I\u0027d note that this would require exposing credentials.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":57,"context_line":"serial proxy and shell in a box for nova provisioned ironic baremetal"},{"line_number":58,"context_line":"intances."},{"line_number":59,"context_line":"00"},{"line_number":60,"context_line":"* Use out-of-band KVM access provided by administrator without Ironic support."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ba2d62d_8459c4dc","line":58,"in_reply_to":"310c8aa3_577d0bb2","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":56,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":57,"context_line":"serial proxy and shell in a box for nova provisioned ironic baremetal"},{"line_number":58,"context_line":"intances."},{"line_number":59,"context_line":"00"},{"line_number":60,"context_line":"* Use out-of-band KVM access provided by administrator without Ironic support."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"63740884_0d4e5d00","line":59,"updated":"2022-12-05 15:49:04.000000000","message":"00?","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":56,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":57,"context_line":"serial proxy and shell in a box for nova provisioned ironic baremetal"},{"line_number":58,"context_line":"intances."},{"line_number":59,"context_line":"00"},{"line_number":60,"context_line":"* Use out-of-band KVM access provided by administrator without Ironic support."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"031b3e0c_cafe8abf","line":59,"in_reply_to":"63740884_0d4e5d00","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":63,"context_line":"-----------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- A new node field ``graphical_console_enabled``, during upgrade/conversion"},{"line_number":66,"context_line":"  will be populated from ``default_graphical_console_interface`` config option"},{"line_number":67,"context_line":"  (``no-graphical-console`` by default)."},{"line_number":68,"context_line":"- new node field ``graphical_console_interface`` will be added."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"State Machine Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"78a56ea9_fef96ce1","line":67,"range":{"start_line":66,"start_character":2,"end_line":67,"end_character":40},"updated":"2022-12-05 15:49:04.000000000","message":"I\u0027m not sure populating with the default on upgrade is the right thing, because the default should be drawn from the hardware type.\n\nAt the same time, I\u0027m not sure we\u0027ve added an interface recently so we might need a value, but I thought the code, if the field is None, defaults on the running config and the union of configuration and available options.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":63,"context_line":"-----------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- A new node field ``graphical_console_enabled``, during upgrade/conversion"},{"line_number":66,"context_line":"  will be populated from ``default_graphical_console_interface`` config option"},{"line_number":67,"context_line":"  (``no-graphical-console`` by default)."},{"line_number":68,"context_line":"- new node field ``graphical_console_interface`` will be added."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"State Machine Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6f09febd_f7223a0e","line":67,"range":{"start_line":66,"start_character":2,"end_line":67,"end_character":40},"in_reply_to":"78a56ea9_fef96ce1","updated":"2022-12-08 10:30:37.000000000","message":"sorry, on this step (adding vnc) we don\u0027t need any new fields.\nrm this.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":121,"context_line":"  creating the console in Nova."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* This bearer token is the only thing required to connect to the proxy,"},{"line_number":124,"context_line":"So the connection between user and proxy should be protected vai ssl"},{"line_number":125,"context_line":"the same as with vms"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6bfa36b6_eec5b630","line":124,"range":{"start_line":124,"start_character":61,"end_line":124,"end_character":64},"updated":"2022-12-05 15:49:04.000000000","message":"s/vai/via/","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  creating the console in Nova."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* This bearer token is the only thing required to connect to the proxy,"},{"line_number":124,"context_line":"So the connection between user and proxy should be protected vai ssl"},{"line_number":125,"context_line":"the same as with vms"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9d5d83f4_f4df3de1","line":124,"range":{"start_line":124,"start_character":61,"end_line":124,"end_character":64},"in_reply_to":"6bfa36b6_eec5b630","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* This bearer token is the only thing required to connect to the proxy,"},{"line_number":124,"context_line":"So the connection between user and proxy should be protected vai ssl"},{"line_number":125,"context_line":"the same as with vms"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other end user impact"},{"line_number":128,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0221b950_1d7cc895","line":125,"updated":"2022-12-05 15:49:04.000000000","message":"nit: The sentence is sort of incomplete.  I\u0027m also not sure most ironic contributors are going to know which bearer token your referring to. It is the connection to the novnc proxy service which are the credentials for interacting with OpenStack.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* This bearer token is the only thing required to connect to the proxy,"},{"line_number":124,"context_line":"So the connection between user and proxy should be protected vai ssl"},{"line_number":125,"context_line":"the same as with vms"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Other end user impact"},{"line_number":128,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bbfe3786_92a4c581","line":125,"in_reply_to":"0221b950_1d7cc895","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"``ironic-conductor/ironic.conf``:"},{"line_number":151,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"``ironic-api/ironic.conf``:"},{"line_number":154,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0c9746ac_0afd23a0","line":152,"updated":"2022-12-05 15:49:04.000000000","message":"The thought that comes to mind, is that ``vnc`` would be a specific implementation\u0027s default name. That is fine, however is there a conductor level call, but what configuration drives \n\nI guess the other thought is VNC for an ilo machine and a redfish machine will differ than what idrac is using. We shouldn\u0027t name a conductor module interface name to be just \"vnc\" when it is vendor specific.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"``ironic-conductor/ironic.conf``:"},{"line_number":151,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"``ironic-api/ironic.conf``:"},{"line_number":154,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"742d2d31_8d2fcbff","line":152,"in_reply_to":"0c9746ac_0afd23a0","updated":"2022-12-08 10:30:37.000000000","message":"agree. for drac i\u0027ll change to \u0027idrac-vnc\u0027 the same as done with idrac-socat","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":151,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"``ironic-api/ironic.conf``:"},{"line_number":154,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Developer impact"},{"line_number":157,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"849a14d4_f5ea75db","line":154,"updated":"2022-12-05 15:49:04.000000000","message":"who will be responsible for starting the new service? Will it have specific configuration needs?","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":true,"context_lines":[{"line_number":151,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"``ironic-api/ironic.conf``:"},{"line_number":154,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Developer impact"},{"line_number":157,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e06e1804_9ccc6339","line":154,"in_reply_to":"849a14d4_f5ea75db","updated":"2022-12-08 10:30:37.000000000","message":"could you please clarify about which service are you talking.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a82e9b029481a1ecd4dcf9a60d986734f67ec42","unresolved":true,"context_lines":[{"line_number":151,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"``ironic-api/ironic.conf``:"},{"line_number":154,"context_line":"enabled_console_interfaces \u003d idrac-socat,ipmitool-socat, ``vnc``,no-console"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Developer impact"},{"line_number":157,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a739e30e_ff9a6f38","line":154,"in_reply_to":"e06e1804_9ccc6339","updated":"2023-01-09 17:15:27.000000000","message":"will a system admin need to setup the new service, or will we automatically launch it somehow?","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":174,"context_line":"Work Items"},{"line_number":175,"context_line":"----------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* implement ``ironic_novncproxy`` service "},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Introduce ``drac.DracWSManVNCConsole(base.ConsoleInterface)``"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a5beb806_3c781db2","line":177,"updated":"2022-12-05 15:49:04.000000000","message":"Two things:\n1) end of line linter error\n2) For the purposes of consistency, please make it ``ironic-novncproxy``, since the other services/tools use dashes.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Work Items"},{"line_number":175,"context_line":"----------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* implement ``ironic_novncproxy`` service "},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Introduce ``drac.DracWSManVNCConsole(base.ConsoleInterface)``"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"03b66cc5_b6bd5a15","line":177,"in_reply_to":"a5beb806_3c781db2","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1bc624259581a22c5bea14bfe75a005fd9436130","unresolved":true,"context_lines":[{"line_number":177,"context_line":"* implement ``ironic_novncproxy`` service "},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Introduce ``drac.DracWSManVNCConsole(base.ConsoleInterface)``"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Dependencies"},{"line_number":183,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"89411001_cd193767","line":180,"updated":"2022-12-05 15:49:04.000000000","message":"You\u0027ll need to update documentation to explain how to use this.","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"923b71738ec2ec6fc8a0227f258242e2ca107859","unresolved":false,"context_lines":[{"line_number":177,"context_line":"* implement ``ironic_novncproxy`` service "},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Introduce ``drac.DracWSManVNCConsole(base.ConsoleInterface)``"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Dependencies"},{"line_number":183,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a53ab94_4841d946","line":180,"in_reply_to":"89411001_cd193767","updated":"2022-12-08 10:30:37.000000000","message":"Done","commit_id":"a926d2cc02f1249b30263873cd9bd07d5bf3d031"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7cb81421ef1a1255885eeb138b88ced7c68aa25c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"In addition to a serial console, allow ironic nodes to be accessed through a"},{"line_number":14,"context_line":"vnc console. This proposal presents the work required to create a new"},{"line_number":15,"context_line":"driver interface for accessing graphical console of a node."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"77859b83_660dae30","line":16,"updated":"2022-12-12 14:36:48.000000000","message":"Just a note, I would highlight this is a dependency on Nova work as well. Just so we get across the overall urgency.","commit_id":"9a8ea0ae019eb51648c18d8bfc4d1a9c09e3c77a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7cb81421ef1a1255885eeb138b88ced7c68aa25c","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"End users often have to troubleshoot their instances because they might"},{"line_number":22,"context_line":"have broken their boot configuration or locked themselves out with a"},{"line_number":23,"context_line":"firewall. Keyboard-Video-Mouse (KVM) access is often required for"},{"line_number":24,"context_line":"troubleshooting these types of issues as serial access is not always"},{"line_number":25,"context_line":"available or correctly configured. Also, KVM provides a better user"},{"line_number":26,"context_line":"experience as compared to serial console."}],"source_content_type":"text/x-rst","patch_set":4,"id":"a0a44f2b_d5a10ef3","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":8},"updated":"2022-12-12 14:36:48.000000000","message":"nit: s/firewall/local firewall/","commit_id":"9a8ea0ae019eb51648c18d8bfc4d1a9c09e3c77a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7cb81421ef1a1255885eeb138b88ced7c68aa25c","unresolved":true,"context_lines":[{"line_number":53,"context_line":"Alternatives"},{"line_number":54,"context_line":"------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Accept this limitation and only offer a serial console."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* We can configure kvm access including access to the bios via the"},{"line_number":59,"context_line":"  serial proxy and shell in a box for nova provisioned ironic baremetal"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bef5f1f4_9c1c7601","line":56,"updated":"2022-12-12 14:36:48.000000000","message":"reviewer note: It should be noted that many do not fine the serial console acceptable or even usable with nova today. We should do better!","commit_id":"9a8ea0ae019eb51648c18d8bfc4d1a9c09e3c77a"}]}