)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"eec6ae0783016013f2c29e7ba53c6449c9015fea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"674c6e27_ae2a4ba3","updated":"2023-09-01 23:54:10.000000000","message":"Past spec ilo-uefi-iscsi-boot.rst causes linter error in CI.\nI make patch to fix that error through modifying formatting of that spec.","commit_id":"7154a83cc19409ee68d7593e68aeb9643eb94a56"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"dfe09641d021836b9965948e4cb01919a6f97e9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4208fff_7209e54d","updated":"2025-11-22 19:17:56.000000000","message":"@ishii.vanou@fujitsu.com will you abandon this then?","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"b61869823922aa37262eef41217fa3e1139ac6b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02a6112b_f1ca61c5","updated":"2023-10-15 03:47:23.000000000","message":"Because Fujitsu internally discusses another approach in addition to this spec.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":30566,"name":"Vanou Ishii","email":"ishii.vanou@fujitsu.com","username":"vanou"},"change_message_id":"7a97e9dccacced2ea530a4d34cc14f11f4c67aee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49450e7d_57c8cc03","updated":"2023-09-25 11:39:31.000000000","message":"Dmitry, Julia\nThanks for review \u0026 comment. Now Fujitsu internally discusses about another approach on this: to make server\u0027s firmware Redfish compliant.\n\nAnyway, thanks a lot!","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c9005cc1c156dffe83d0ba941f9ab76940fbfd1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7652847a_083d3bd2","updated":"2023-09-20 23:22:38.000000000","message":"Modifying my vote as I thought of a concern regarding Third Party CI.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb76fb9a81ea3b3584097c17299179aeac52de26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51634634_75412807","updated":"2023-09-20 23:19:42.000000000","message":"My thoughts and concerns are basically identical to Dmitry’s.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"}],"specs/approved/irmc-redfish-driver.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Use of vendor specific API leads vendor specific library dependency and"},{"line_number":22,"context_line":"increases maintenance and QA cost. At the time when `irmc` driver was"},{"line_number":23,"context_line":"developed, Fujitsu server didn\u0027t provide Redfish API, but recent Fujitsu"},{"line_number":24,"context_line":"server does. Managing Fujitsu server with Redfish, without vendor specific"},{"line_number":25,"context_line":"library or protocol, on Ironic reduces library dependency at community and"},{"line_number":26,"context_line":"downstream. With transition to Redfish, more resource on Fujitsu may commit"},{"line_number":27,"context_line":"to vendor neutral common code in Ironic community."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a3cfa1f_61ddab7f","line":24,"updated":"2023-09-14 09:23:41.000000000","message":"Please specify which exactly servers support Redfish. At least, please make sure it will be a part of your documentation patch.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"driver as possible with vendor specific logic implemented through class"},{"line_number":37,"context_line":"inheritance and method override. Fujitsu will gradually reduce the number"},{"line_number":38,"context_line":"of Fujitsu specific Redfish behavior and eventually make Fujitsu server"},{"line_number":39,"context_line":"completely Redfish specification compliant."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8191bebd_7033135c","line":39,"updated":"2023-09-14 09:23:41.000000000","message":"Side note. There are two paths you could take here. One is this (add irmc-redfish), the other would be adding new interfaces to the existing hardware type. We\u0027ve done the latter for idrac, but I\u0027m not sure it was the best experience. Maybe the path you propose is actually the best.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb76fb9a81ea3b3584097c17299179aeac52de26","unresolved":false,"context_lines":[{"line_number":36,"context_line":"driver as possible with vendor specific logic implemented through class"},{"line_number":37,"context_line":"inheritance and method override. Fujitsu will gradually reduce the number"},{"line_number":38,"context_line":"of Fujitsu specific Redfish behavior and eventually make Fujitsu server"},{"line_number":39,"context_line":"completely Redfish specification compliant."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c87f42e8_2f98ca44","line":39,"in_reply_to":"8191bebd_7033135c","updated":"2023-09-20 23:19:42.000000000","message":"I do thing this is likely the better path, at least with this scope.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As described above, Fujitsu server provides few of Redfish operations through"},{"line_number":46,"context_line":"Redfish Oem path or Oem action. These operation should be handled with Fujitsu"},{"line_number":47,"context_line":"specific logic. These are followings:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Virtual media functionality"},{"line_number":50,"context_line":"* BIOS configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c2fc1be3_d9ad612c","line":47,"updated":"2023-09-14 09:23:41.000000000","message":"nit: \"the following\"","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Another current Fujitsu server specific Redfish API behaviors are:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* No support for SecurBoot configuration through Redfish API"},{"line_number":63,"context_line":"* Support UEFI only and no LegacyBIOS support at Fujitsu server"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ac49f077_37b1e244","line":63,"updated":"2023-09-14 09:23:41.000000000","message":"Note: not having these is not a blocker for using the `redfish` hardware type.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb76fb9a81ea3b3584097c17299179aeac52de26","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Another current Fujitsu server specific Redfish API behaviors are:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* No support for SecurBoot configuration through Redfish API"},{"line_number":63,"context_line":"* Support UEFI only and no LegacyBIOS support at Fujitsu server"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4d2dfbe1_e19f8eb1","line":63,"in_reply_to":"ac49f077_37b1e244","updated":"2023-09-20 23:19:42.000000000","message":"I concur. I would almost prefer to teach the driver to be tolerant of any issues like these. for example, current arm has no concept aside from UEFI.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* Provide BIOS configuration functionality through Fujitsu server Redfish"},{"line_number":77,"context_line":"  Oem path and Oem action. BIOS configuration is managed through eLCM profile"},{"line_number":78,"context_line":"  management framework in Fujitsu server firmware."},{"line_number":79,"context_line":"  See `eLCM Profile Management` below."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* Provide RAID configuration functionality through Fujitsu server Redfish"},{"line_number":82,"context_line":"  Oem path and Oem action. RAID configuration is managed through eLCM profile"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c835beef_537412a0","line":79,"updated":"2023-09-14 09:23:41.000000000","message":"The link syntax is `title`_ (note the trailing underscore)","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  if power is off, only `On` appears and if power is on, `Nmi`, `ForceOff`,"},{"line_number":91,"context_line":"  `ForceRestart` and `PushPowerButton` appear. This behavior isn\u0027t what"},{"line_number":92,"context_line":"  Redfish specification expects and leads to failure of reboot operation"},{"line_number":93,"context_line":"  under current Sushy code."},{"line_number":94,"context_line":"  2) `ComputerSystem.Reset` action doesn\u0027t support `GracefulRestart` and"},{"line_number":95,"context_line":"  `GracefulShutdown`. Fujitsu HW team will make these 2 operation available"},{"line_number":96,"context_line":"  at `ComputerSystem.Reset`, but till that, these 2 operation should be"}],"source_content_type":"text/x-rst","patch_set":4,"id":"53113723_46230e93","line":93,"updated":"2023-09-14 09:23:41.000000000","message":"Is it possible to fix that in our code? From just your description, I would not expect sushy/ironic to fail.\n\nIf so, you can reuse the existing interface completely.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  2) `ComputerSystem.Reset` action doesn\u0027t support `GracefulRestart` and"},{"line_number":95,"context_line":"  `GracefulShutdown`. Fujitsu HW team will make these 2 operation available"},{"line_number":96,"context_line":"  at `ComputerSystem.Reset`, but till that, these 2 operation should be"},{"line_number":97,"context_line":"  disabled."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* Disable operation around SecureBoot configuration"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"e8ef27e9_6d0c3aa3","line":97,"updated":"2023-09-14 09:23:41.000000000","message":"This is not a problem for the current code (there is a call to get available actions).","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  at `ComputerSystem.Reset`, but till that, these 2 operation should be"},{"line_number":97,"context_line":"  disabled."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* Disable operation around SecureBoot configuration"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Support UEFI only at BootMode configuration"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"80b0bf85_699a94b5","line":99,"updated":"2023-09-14 09:23:41.000000000","message":"You don\u0027t really need to disable it (as in: modify the `redfish` management interface). The existing code should handle missing support for secure boot (if it does not, it\u0027s a bug).","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  driver"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* Disable Redfish event subscription at `irmc-redfish` driver because Redfish"},{"line_number":107,"context_line":"  implementation of Fujitsu server doesn\u0027t support event subscription."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"eLCM Profile Management"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a23d013_4cd3826a","line":107,"updated":"2023-09-14 09:23:41.000000000","message":"Same comment on these two: you don\u0027t really need to disable things. Not all hardware supports all features, this applies generally, not just to FJ hardware.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb76fb9a81ea3b3584097c17299179aeac52de26","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  driver"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* Disable Redfish event subscription at `irmc-redfish` driver because Redfish"},{"line_number":107,"context_line":"  implementation of Fujitsu server doesn\u0027t support event subscription."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"eLCM Profile Management"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b79032ad_f33751ac","line":107,"in_reply_to":"7a23d013_4cd3826a","updated":"2023-09-20 23:19:42.000000000","message":"Agree completely.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"Developer impact"},{"line_number":226,"context_line":"----------------"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"None"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"Implementation"},{"line_number":231,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c3160790_629cac49","line":228,"updated":"2023-09-14 09:23:41.000000000","message":"Where is the Fujitsu-specific code going to live? For Dell, we\u0027ve created https://opendev.org/openstack/sushy-oem-idrac to simply maintenance for both the vendor and the Ironic team.","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c9005cc1c156dffe83d0ba941f9ab76940fbfd1c","unresolved":true,"context_lines":[{"line_number":269,"context_line":"Because new driver is based on current `redfish` driver and `Sushy` but with"},{"line_number":270,"context_line":"few vendor HW specific Redfish logic, new driver should be tested with 3rd"},{"line_number":271,"context_line":"party testing."},{"line_number":272,"context_line":"Fujitsu has 3rd party testing environment for current `irmc` driver. Same"},{"line_number":273,"context_line":"environment can be used to test new driver."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"68b04694_36bb4b32","line":272,"updated":"2023-09-20 23:22:38.000000000","message":"I am unsure this is correct. Can we verify this statement?","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e58a4f9653a847d64172dd982cebfc92fabb94a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"few vendor HW specific Redfish logic, new driver should be tested with 3rd"},{"line_number":271,"context_line":"party testing."},{"line_number":272,"context_line":"Fujitsu has 3rd party testing environment for current `irmc` driver. Same"},{"line_number":273,"context_line":"environment can be used to test new driver."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"Upgrades and Backwards Compatibility"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6a2e72e5_2a0fbeb3","line":273,"updated":"2023-09-14 09:23:41.000000000","message":"+1","commit_id":"95796f7a1cf1849136577983713a6362190b7d73"}]}