)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"127c50f97b587bfc83030f90db9d3a2dafa1642c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ee43000f_f014ffda","updated":"2023-10-18 03:09:27.000000000","message":"Adding to my list to take a look during this week","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f1ba626fc982b5811659bd80c59cc5a0223cccb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f07d3692_ad487c27","updated":"2023-10-20 07:36:20.000000000","message":"I\u0027m ok with this, thanks!","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cdc0f0d2fec9eda86bbf89bb8ea66e69a0e8be12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48b8cfa5_095285d7","updated":"2023-10-19 03:21:16.000000000","message":"I\u0027ve checked the spec and lgtm, I think this approach makes sense moving forward since we know some HW doesn\u0027t support vmedia but does support httpboot.\n+1 from now only because I see changes in `specs/approved/ilo-uefi-iscsi-boot.rst`","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"cf6b155f92724c8f0095f75b11ed29821a7b0435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e2c6755_d5f38566","updated":"2023-10-18 05:27:18.000000000","message":"Looks good, do we have any indicator that if a bmc supports this?","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"016029ea40ef8a7a16268b8cc589dd495a7b32e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"faa9b8aa_35a6b0e2","updated":"2023-10-20 23:03:01.000000000","message":"Moving to +2, since Julia explained that the repo was broken and the changes in ilo-uefi-iscsi-boot are required.\n\n+W","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b69cbe32de2e92d1e3d8e6d20c9a11ef9de43107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8465baf7_05e6719f","updated":"2023-10-18 21:13:07.000000000","message":"This seems sane to me, I have little knowledge of the underlying hardware but this seems like a good enhancement.","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"31236ba611910ca29c8743dfee46f1a08b8b540f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1cadb024_62741985","updated":"2023-10-19 15:37:04.000000000","message":"looks really good, just puzzled by the changes in ilo-uefi-iscsi-boot.rst","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f3c2c4065586a444bb541ea4732511e448e795e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"160f1332_71ecd1e0","updated":"2023-10-09 13:12:08.000000000","message":"moopsy!","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e57ef018a0a8ba3779b2999a12fbd7d5c2311c82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5386faad_4387ad34","in_reply_to":"3e2c6755_d5f38566","updated":"2023-10-18 21:25:41.000000000","message":"Yes, We do! The list of valid target values would include a \"UefiHttp\" possible value, and DMTF redfish defines the ability to read the current value, or at least, last set value from the BMC.\n\nI guess the net effect could be, we could have validation see if the needful is present in the bmc when attempting to verify the boot interface.","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cdc0f0d2fec9eda86bbf89bb8ea66e69a0e8be12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05873457_d7252d66","in_reply_to":"5386faad_4387ad34","updated":"2023-10-19 03:21:16.000000000","message":"++ to check if the needful is present in the BMC during validation","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"}],"specs/approved/httpboot.rst":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"cf6b155f92724c8f0095f75b11ed29821a7b0435","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Problem description"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Infrastructure operators need reliable, and realtively secure means of"},{"line_number":39,"context_line":"conveying bootloaders and initial artifacts to remote machines."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Ironic\u0027s historical answer has been to utilize virtual media."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3911aaf6_eac4a9c4","line":38,"range":{"start_line":38,"start_character":44,"end_line":38,"end_character":55},"updated":"2023-10-18 05:27:18.000000000","message":"relatively","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"31236ba611910ca29c8743dfee46f1a08b8b540f","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Ironic\u0027s historical answer has been to utilize virtual media."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"But not all hardware supports virutal media, and emulating a block device"},{"line_number":44,"context_line":"is not exactly the simplest thing once you boot an operating system. A helpful"},{"line_number":45,"context_line":"aspect with UEFI and the evolution of systems is now we have facilities in"},{"line_number":46,"context_line":"Baseboard management controllers and even UEFI base firmware support"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e76ba253_a2f8fa64","line":43,"range":{"start_line":43,"start_character":30,"end_line":43,"end_character":37},"updated":"2023-10-19 15:37:04.000000000","message":"nit: virtual","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"31236ba611910ca29c8743dfee46f1a08b8b540f","unresolved":true,"context_lines":[{"line_number":212,"context_line":"* Add support to pxe_utils logic to generate a URL boot response"},{"line_number":213,"context_line":"  payload, and set that based upon a driver feature/capability flag."},{"line_number":214,"context_line":"* Compose lots of documentation."},{"line_number":215,"context_line":"* Create tempest suite to execise both modes of boot operations."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Dependencies"},{"line_number":218,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"de084e6a_dd96a03c","line":215,"range":{"start_line":215,"start_character":26,"end_line":215,"end_character":33},"updated":"2023-10-19 15:37:04.000000000","message":"nit: exercise","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"}],"specs/approved/ilo-uefi-iscsi-boot.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"31236ba611910ca29c8743dfee46f1a08b8b540f","unresolved":true,"context_lines":[{"line_number":30,"context_line":"This change is based on the reference driver implementation guidelines"},{"line_number":31,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ spec to support booting"},{"line_number":32,"context_line":"ironic nodes from a storage device that is hosted and/or controlled remotely."},{"line_number":33,"context_line":"This change proposes two new methods for iLO drivers management interface;"},{"line_number":34,"context_line":"namely ``set_iscsi_boot_target`` and ``clear_iscsi_boot_target``, which will"},{"line_number":35,"context_line":"facilitate setting and clearing iSCSI target information using iLO interfaces"},{"line_number":36,"context_line":"for UEFI iSCSI boot capable HPE Proliant servers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"19c554f6_745a39fb","line":33,"updated":"2023-10-19 15:37:04.000000000","message":"are those changes done on purpose?","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"016029ea40ef8a7a16268b8cc589dd495a7b32e8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"This change is based on the reference driver implementation guidelines"},{"line_number":31,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ spec to support booting"},{"line_number":32,"context_line":"ironic nodes from a storage device that is hosted and/or controlled remotely."},{"line_number":33,"context_line":"This change proposes two new methods for iLO drivers management interface;"},{"line_number":34,"context_line":"namely ``set_iscsi_boot_target`` and ``clear_iscsi_boot_target``, which will"},{"line_number":35,"context_line":"facilitate setting and clearing iSCSI target information using iLO interfaces"},{"line_number":36,"context_line":"for UEFI iSCSI boot capable HPE Proliant servers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1c50588b_d9058a61","line":33,"in_reply_to":"137bbfe8_35f872da","updated":"2023-10-20 23:03:01.000000000","message":"Ack","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cc0757da644ef8af1f17ceb29b97b4420a556dd1","unresolved":true,"context_lines":[{"line_number":30,"context_line":"This change is based on the reference driver implementation guidelines"},{"line_number":31,"context_line":"proposed by `Boot from Volume - Reference Drivers`_ spec to support booting"},{"line_number":32,"context_line":"ironic nodes from a storage device that is hosted and/or controlled remotely."},{"line_number":33,"context_line":"This change proposes two new methods for iLO drivers management interface;"},{"line_number":34,"context_line":"namely ``set_iscsi_boot_target`` and ``clear_iscsi_boot_target``, which will"},{"line_number":35,"context_line":"facilitate setting and clearing iSCSI target information using iLO interfaces"},{"line_number":36,"context_line":"for UEFI iSCSI boot capable HPE Proliant servers."}],"source_content_type":"text/x-rst","patch_set":2,"id":"137bbfe8_35f872da","line":33,"in_reply_to":"19c554f6_745a39fb","updated":"2023-10-19 16:33:50.000000000","message":"Yes, updated style checks now fail on the prior state in the repo.","commit_id":"9a489a47293fb0ef071e839f555206d60c5c7100"}]}
