)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-23 15:58:43 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for the new instance_info field of Nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0e8f5905aa9a55fa968445023599f39c7625f212"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7adec928_c649cbb8","line":7,"updated":"2014-05-23 18:42:02.000000000","message":"following nova\u0027s lead here, the commit title should be the spec title, and the commit message should be the summary paragraph from the spec","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"}],"specs/juno/add-node-instance-info.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Standardize logging and improve log coverage"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_f5bcb36e","line":7,"updated":"2014-05-23 18:42:02.000000000","message":"incorrect title","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Standardize logging and improve log coverage"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_a50c1096","line":7,"in_reply_to":"7adec928_f5bcb36e","updated":"2014-05-27 15:18:03.000000000","message":"ops done.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/add-node-instance-info"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will introduce a new field to the Nodes resource that will"},{"line_number":14,"context_line":"be used to pass instance-level data to a driver when provisioning a node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_0693b34f","line":14,"updated":"2014-05-23 18:42:02.000000000","message":"I would clarify this slightly more by saying:\n\n  will be used to store instance-specific data, which will be used by the driver\n  when provisioning or managing that instance.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/add-node-instance-info"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint will introduce a new field to the Nodes resource that will"},{"line_number":14,"context_line":"be used to pass instance-level data to a driver when provisioning a node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_05ff8435","line":14,"in_reply_to":"7adec928_0693b34f","updated":"2014-05-27 15:18:03.000000000","message":"done, thank you for the suggestion","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c89090a7e6fe8505895cb5f709e17bc04b96506d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"proposal adds a new JSON field to the node model containing this instance"},{"line_number":22,"context_line":"info. This field can contain info that should be passed to the driver,"},{"line_number":23,"context_line":"as well as instance level data that is currently stuffed in driver_info"},{"line_number":24,"context_line":"(root_gb, swap_gb, ephemeral_gb, ephemeral_format, image_source)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As all the data in the new instance_info attribute is related to the"},{"line_number":27,"context_line":"instance/deployment, this field will be completed erased as part of the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3ae8d1ca_99406c58","line":24,"updated":"2014-05-27 09:08:52.000000000","message":"Should we mention potential field to designate whole-image deployment as being done in https://review.openstack.org/73054 ?","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":22,"context_line":"info. This field can contain info that should be passed to the driver,"},{"line_number":23,"context_line":"as well as instance level data that is currently stuffed in driver_info"},{"line_number":24,"context_line":"(root_gb, swap_gb, ephemeral_gb, ephemeral_format, image_source)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As all the data in the new instance_info attribute is related to the"},{"line_number":27,"context_line":"instance/deployment, this field will be completed erased as part of the"},{"line_number":28,"context_line":"node\u0027s tear down process."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_c6bf0ba9","line":25,"updated":"2014-05-23 18:42:02.000000000","message":"Also, driver info should be used to store the information required by the driver to manage the node, and thus should be invariant across multiple deployments on the same node. This is not the case today, but this change will correct that.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"info. This field can contain info that should be passed to the driver,"},{"line_number":23,"context_line":"as well as instance level data that is currently stuffed in driver_info"},{"line_number":24,"context_line":"(root_gb, swap_gb, ephemeral_gb, ephemeral_format, image_source)."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As all the data in the new instance_info attribute is related to the"},{"line_number":27,"context_line":"instance/deployment, this field will be completed erased as part of the"},{"line_number":28,"context_line":"node\u0027s tear down process."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_c5ed9c8d","line":25,"in_reply_to":"7adec928_c6bf0ba9","updated":"2014-05-27 15:18:03.000000000","message":"added, thank you for the suggestion.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c89090a7e6fe8505895cb5f709e17bc04b96506d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  of the driver_info when deploying a node."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* deploy ramdisk and deploy kernel to not be part of the Flavor\u0027s"},{"line_number":40,"context_line":"  extra_data and live in the Node\u0027s driver_info instead."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3ae8d1ca_591d0473","line":40,"updated":"2014-05-27 09:08:52.000000000","message":"While completely valid, Tuskar developers should be made aware of this change, as it\u0027s going to complicate supporting both nova-bm and Ironic","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Security impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"None"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_66f8f77c","line":78,"updated":"2014-05-23 18:42:02.000000000","message":"This change would allow the driver_info field to be hidden from the REST API, if policies were added and enforced in the API layer. This would allow the management credentials to be hidden from users.\n\nWhile out of scope of this change itself, it is worth noting that this enables a later improvement in security.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Security impact"},{"line_number":77,"context_line":"---------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"None"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_40e41a3b","line":78,"in_reply_to":"7adec928_66f8f77c","updated":"2014-05-27 15:18:03.000000000","message":"oh good idea! Will add a note","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Instead of setting the deploy ramdisk and deploy kernel as part of"},{"line_number":85,"context_line":"the flavor in Nova, this fields if required (depending on the driver)"},{"line_number":86,"context_line":"should be set by the client in the driver_info field of the Nodes when"},{"line_number":87,"context_line":"enrolling it."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Scalability impact"},{"line_number":90,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_46877bd7","line":87,"updated":"2014-05-23 18:42:02.000000000","message":"It would be good to include, at minimum, a script demonstrating how to extract the k\u0026r from the nova flavor and update all the ironic node.driver_info fields appropriately.\n\nThis could be done as a migration script, or just an example in the documentation.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Instead of setting the deploy ramdisk and deploy kernel as part of"},{"line_number":85,"context_line":"the flavor in Nova, this fields if required (depending on the driver)"},{"line_number":86,"context_line":"should be set by the client in the driver_info field of the Nodes when"},{"line_number":87,"context_line":"enrolling it."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Scalability impact"},{"line_number":90,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_4af194cc","line":87,"in_reply_to":"7adec928_46877bd7","updated":"2014-05-27 15:18:03.000000000","message":"I can create a script for it and also put a note in the documentation pointing to it","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Developer impact"},{"line_number":105,"context_line":"----------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"This will require future developers (and core reviewers) to be cognizant of"},{"line_number":108,"context_line":"the expected logging behavior and continue to maintain consistency."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_062f33f7","line":107,"updated":"2014-05-23 18:42:02.000000000","message":"copy error","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Developer impact"},{"line_number":105,"context_line":"----------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"This will require future developers (and core reviewers) to be cognizant of"},{"line_number":108,"context_line":"the expected logging behavior and continue to maintain consistency."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_80046216","line":107,"in_reply_to":"7adec928_062f33f7","updated":"2014-05-27 15:18:03.000000000","message":"done","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Testing"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Unit tests and devstack needs to be changed to cover the new changes."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Documentation Impact"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_e6608737","line":149,"updated":"2014-05-23 18:42:02.000000000","message":"devstack change will need to be staggered in three changes:\n\n- have devstack add k\u0026r to driver_info (while still also adding on flavor)\n- land patch in Ironic\n- have devstack stop writing k\u0026r to flavor","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb071a032f0df550db878bdfb74c6f1590c04ff9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Testing"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Unit tests and devstack needs to be changed to cover the new changes."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Documentation Impact"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5adbc538_40697a8a","line":149,"in_reply_to":"7adec928_e6608737","updated":"2014-05-27 15:18:03.000000000","message":"+1, I didn\u0027t know if I should put the required steps in this part of the spec or not, I will add it. Thanks","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e4ad435286717cdfe8c936ab2ae409793a601e82","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Deployer docs should be modified to point to the client to not add the"},{"line_number":155,"context_line":"deploy kernel and deploy ramdisk as part of the flavor and pass it as"},{"line_number":156,"context_line":"a parameter to the driver."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"References"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_a6775f01","line":156,"updated":"2014-05-23 18:42:02.000000000","message":"and include a migration script.","commit_id":"6f93a59575436cf1b033872542cc13eec6aa8d7e"}]}