)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Whole-Disk-Image Spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The spec to add whole disk image support to Ironic."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I37a2734647a57860ca00fbbba28cce4b6550ebb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_ee587d58","line":9,"updated":"2014-06-02 10:41:00.000000000","message":"IIRC, the commit summary message should copy header and introduction from the text","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Whole-Disk-Image Spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The spec to add whole disk image support to Ironic."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I37a2734647a57860ca00fbbba28cce4b6550ebb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_54b74086","line":9,"in_reply_to":"1ae5cdf2_ee587d58","updated":"2014-06-02 11:41:00.000000000","message":"Done","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"86ecc07ee98cff4c7371bb8260f8012304eab809","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Whole Disk Image Support for PXE Deploy Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add a feature of deploying whole disk images to Ironic\u0027s"},{"line_number":10,"context_line":"PXE Deploy driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I37a2734647a57860ca00fbbba28cce4b6550ebb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5a890539_d8d605f1","line":10,"updated":"2014-11-20 23:39:27.000000000","message":"Commit message should include a reference to the blueprint, and the first paragraph describing it","commit_id":"badb609a1e4e13381c41b858cb0f6d6889aec2d8"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"0b39a1a5419b7d5b51b9b4c88ca5c3b65b678fc9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Whole Disk Image Support for PXE Deploy Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec proposes to add a feature of deploying whole disk images to Ironic\u0027s"},{"line_number":10,"context_line":"PXE Deploy driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I37a2734647a57860ca00fbbba28cce4b6550ebb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5a890539_e6dddb15","line":10,"in_reply_to":"5a890539_d8d605f1","updated":"2014-11-21 06:32:05.000000000","message":"Done","commit_id":"badb609a1e4e13381c41b858cb0f6d6889aec2d8"}],"specs/Disk_Image_support_Ironic.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ae5cdf2_4ee171cf","updated":"2014-06-02 10:41:00.000000000","message":"I think, the convention is to have all-lowercase file names.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ae5cdf2_59cbf9a4","in_reply_to":"1ae5cdf2_4ee171cf","updated":"2014-06-02 11:41:00.000000000","message":"Done","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, Ironic PXE driver deploys only partition images making an Image"},{"line_number":23,"context_line":"kernel/ramdisk to be mandatory. This limits deploying of Images that are"},{"line_number":24,"context_line":"not capable of providing a kernel/ramdisk."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"A significantly important use-case would be to deploy Windows Images on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_8e02996d","line":23,"updated":"2014-06-02 10:41:00.000000000","message":"I guess s/limits/makes impossible/","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, Ironic PXE driver deploys only partition images making an Image"},{"line_number":23,"context_line":"kernel/ramdisk to be mandatory. This limits deploying of Images that are"},{"line_number":24,"context_line":"not capable of providing a kernel/ramdisk."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"A significantly important use-case would be to deploy Windows Images on"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_f9e04598","line":23,"in_reply_to":"1ae5cdf2_8e02996d","updated":"2014-06-02 11:41:00.000000000","message":"Done","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"we expect a Glance property \u0027deploy_disk\u0027 to be set by the user to either True"},{"line_number":35,"context_line":"or False defaulting to False."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Nova will use this explicit value and pass it on to Ironic to tell it to"},{"line_number":38,"context_line":"deploy a Disk Image."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"It needs to be noted that the Glance property is only valid for Nova and will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_eef23d99","line":37,"updated":"2014-06-02 10:41:00.000000000","message":"Do you have spec on Nova for doing this? Please link here.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":34,"context_line":"we expect a Glance property \u0027deploy_disk\u0027 to be set by the user to either True"},{"line_number":35,"context_line":"or False defaulting to False."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Nova will use this explicit value and pass it on to Ironic to tell it to"},{"line_number":38,"context_line":"deploy a Disk Image."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"It needs to be noted that the Glance property is only valid for Nova and will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_195fb1e6","line":37,"in_reply_to":"1ae5cdf2_eef23d99","updated":"2014-06-02 11:41:00.000000000","message":"Yep, I meant the Nova Ironic Driver. Will change.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"It needs to be noted that the Glance property is only valid for Nova and will"},{"line_number":41,"context_line":"only be used by Nova, where as Ironic has an explicit deploy_disk value set"},{"line_number":42,"context_line":"into it\u0027s data model by Nova and will not depend on the Glance Image property"},{"line_number":43,"context_line":"for making the decision."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since Whole disk images need to be booted locally from disk, a Power Manager"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_0e45a9b2","line":42,"updated":"2014-06-02 10:41:00.000000000","message":"Please expand \"data model\" to something specific (Node instance_info?). Also elaborate on how exactly Nova will do it. You probably meant Ironic Nova driver, not Nova itself.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"It needs to be noted that the Glance property is only valid for Nova and will"},{"line_number":41,"context_line":"only be used by Nova, where as Ironic has an explicit deploy_disk value set"},{"line_number":42,"context_line":"into it\u0027s data model by Nova and will not depend on the Glance Image property"},{"line_number":43,"context_line":"for making the decision."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Since Whole disk images need to be booted locally from disk, a Power Manager"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_b9f4fdcf","line":42,"in_reply_to":"1ae5cdf2_0e45a9b2","updated":"2014-06-02 11:41:00.000000000","message":"So I assumed this to be a little more generic and be more specific in the sections below to avoid redundancy. Will change it if it supposed to be specific.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"A new deploy_disk boolean attribute will be added to the Instance Info dict."},{"line_number":62,"context_line":"Based on this key, we validate various parameters related to disk or partition"},{"line_number":63,"context_line":"images and figure out if we need to deploy a disk or a partition image."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ce682124","line":61,"updated":"2014-06-02 10:41:00.000000000","message":"s/Instance Info/instance_info/. And it means, that this change should depend on https://review.openstack.org/#/c/95701/","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"A new deploy_disk boolean attribute will be added to the Instance Info dict."},{"line_number":62,"context_line":"Based on this key, we validate various parameters related to disk or partition"},{"line_number":63,"context_line":"images and figure out if we need to deploy a disk or a partition image."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_59de9940","line":61,"in_reply_to":"1ae5cdf2_ce682124","updated":"2014-06-02 11:41:00.000000000","message":"Yeah, I have added it to the dependencies list below. Is there something else I\u0027m missing?","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"-----------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"A new deploy_disk boolean attribute will be added to the Instance Info dict."},{"line_number":62,"context_line":"Based on this key, we validate various parameters related to disk or partition"},{"line_number":63,"context_line":"images and figure out if we need to deploy a disk or a partition image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_8e5e1975","line":62,"updated":"2014-06-02 10:41:00.000000000","message":"Which various parameters? Please state.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":59,"context_line":"-----------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"A new deploy_disk boolean attribute will be added to the Instance Info dict."},{"line_number":62,"context_line":"Based on this key, we validate various parameters related to disk or partition"},{"line_number":63,"context_line":"images and figure out if we need to deploy a disk or a partition image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_99e74112","line":62,"in_reply_to":"1ae5cdf2_8e5e1975","updated":"2014-06-02 11:41:00.000000000","message":"Done","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Nova driver impact"},{"line_number":77,"context_line":"------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Since this change affects instance_info, Nova needs to set this value to"},{"line_number":80,"context_line":"Ironic\u0027s PXE Deploy driver."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_4ecb311e","line":79,"updated":"2014-06-02 10:41:00.000000000","message":"Again, you mean Nova driver, probably. Or am I missing something?","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Nova driver impact"},{"line_number":77,"context_line":"------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Since this change affects instance_info, Nova needs to set this value to"},{"line_number":80,"context_line":"Ironic\u0027s PXE Deploy driver."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_99ce6182","line":79,"in_reply_to":"1ae5cdf2_4ecb311e","updated":"2014-06-02 11:41:00.000000000","message":"Not missing anything. Spot on, needs to be s/nova/nova driver/ everywhere.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Slight negative impact by adding an extra REST API Call to Neutron in PXE"},{"line_number":101,"context_line":"deploy driver to disable PXE DHCP Opts per deployment, if that counts."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Other deployer impact"},{"line_number":104,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_0ee1299a","line":101,"updated":"2014-06-02 10:41:00.000000000","message":"I don\u0027t think it counts.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":98,"context_line":"------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Slight negative impact by adding an extra REST API Call to Neutron in PXE"},{"line_number":101,"context_line":"deploy driver to disable PXE DHCP Opts per deployment, if that counts."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Other deployer impact"},{"line_number":104,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_d9c8e976","line":101,"in_reply_to":"1ae5cdf2_0ee1299a","updated":"2014-06-02 11:41:00.000000000","message":"Done, will remove this.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Modify the Nova Driver to patch in the deploy_disk value to Ironic\u0027s"},{"line_number":132,"context_line":"instance_info dict."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Add deploy_disk boolean to instance_info."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Modify PXE driver to deploy without kernel/ramdisk."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_2ebd0569","line":134,"updated":"2014-06-02 10:41:00.000000000","message":"What is the difference from previous work item? I think they\u0027re actually the same","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Modify the Nova Driver to patch in the deploy_disk value to Ironic\u0027s"},{"line_number":132,"context_line":"instance_info dict."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Add deploy_disk boolean to instance_info."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Modify PXE driver to deploy without kernel/ramdisk."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_19909142","line":134,"in_reply_to":"1ae5cdf2_2ebd0569","updated":"2014-06-02 11:41:00.000000000","message":"Since one was a task in Nova driver and the other in Ironic, I\u0027d split it. I probably misunderstood the whole \"Work Items\" section. Will change this and the ones below to non-dependent tasks.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Make PXE driver modify PXE Template for Whole Disk Images."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Enable PXE driver to deploy Whole Disk Images via a separate dd call."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ceabc11c","line":140,"updated":"2014-06-02 10:41:00.000000000","message":"These 3 are the same work item, as they don\u0027t have value on their own (and are actually impossible to implement without each other), so it should be one paragraph.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Make PXE driver modify PXE Template for Whole Disk Images."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Enable PXE driver to deploy Whole Disk Images via a separate dd call."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_599a1964","line":140,"in_reply_to":"1ae5cdf2_ceabc11c","updated":"2014-06-02 11:41:00.000000000","message":"Done","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Dependencies"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Depends On spec/add-node-instance-info."},{"line_number":147,"context_line":"Partially Related To spec/better-bootloader-options.rst."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_4e67b125","line":146,"updated":"2014-06-02 10:41:00.000000000","message":"This should be a link to the blueprint and also actual Gerrit dependency of this spec.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Dependencies"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Depends On spec/add-node-instance-info."},{"line_number":147,"context_line":"Partially Related To spec/better-bootloader-options.rst."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_79eb55b0","line":146,"in_reply_to":"1ae5cdf2_4e67b125","updated":"2014-06-02 11:41:00.000000000","message":"Done","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d1ffd6c7c9c82efcb9d12d0cc3f1f269a5cda7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Depends On spec/add-node-instance-info."},{"line_number":147,"context_line":"Partially Related To spec/better-bootloader-options.rst."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Testing"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ce59015d","line":147,"updated":"2014-06-02 10:41:00.000000000","message":"This maybe interesting: how exactly are they related? May make sense to add something on it to \"Proposed changes\" section.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"7b597b7b2e420f38df508dd5326ef50afe2f5b24","unresolved":false,"context_lines":[{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Depends On spec/add-node-instance-info."},{"line_number":147,"context_line":"Partially Related To spec/better-bootloader-options.rst."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Testing"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_79d515b8","line":147,"in_reply_to":"1ae5cdf2_ce59015d","updated":"2014-06-02 11:41:00.000000000","message":"It\u0027s related in that that spec aims to add a feature of selecting the boot order. For whole-disk-images, this will explicitly change the boot order to \u0027boot from disk first\u0027. This may or may not conflict with the better-bootloader-options spec.","commit_id":"f0c5095c505aa1112ae98908ab3c35c1dc9e4d90"}],"specs/juno/whole-disk-image-pxe-driver.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b5ede868b566d34a9fb2e56dd2b5b93759bffc0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"to maintain consistency with current behavior."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Nova Ironic driver will use this explicit value and patch it on to Ironic\u0027s"},{"line_number":38,"context_line":"instance_info dict to tell it to deploy a Disk Image."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"It needs to be noted that the Glance property \u0027ironic_deploy_disk\u0027"},{"line_number":41,"context_line":"is only valid for the Nova Ironic Driver and will only be used by the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_17ad4c84","line":38,"updated":"2014-06-27 13:43:49.000000000","message":"it will be called \"deploy_disk\" in instance_info, right? please state here. I know that you define it later, but you use it in the following text and it\u0027s a bit confusing","commit_id":"20dead2e8e24823662fdc1f7b9c6547e0c3dba0c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e1f2f0d2d098709b39009d4cedf7191386352bc7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"to maintain consistency with current behavior."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The Nova Ironic driver will use this explicit value and patch it on to Ironic\u0027s"},{"line_number":38,"context_line":"instance_info dict to tell it to deploy a Disk Image."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"It needs to be noted that the Glance property \u0027ironic_deploy_disk\u0027"},{"line_number":41,"context_line":"is only valid for the Nova Ironic Driver and will only be used by the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab895d6_934a0182","line":38,"in_reply_to":"1ae5cdf2_17ad4c84","updated":"2014-06-30 12:11:41.000000000","message":"Done","commit_id":"20dead2e8e24823662fdc1f7b9c6547e0c3dba0c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b5ede868b566d34a9fb2e56dd2b5b93759bffc0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"a disk image. If either one of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 is set, it does not validate"},{"line_number":51,"context_line":"any parameters related to partition images such as root_gb, swap_mb,"},{"line_number":52,"context_line":"ephemeral_gb, etc and goes on to continue to deploy a whole disk image."},{"line_number":53,"context_line":"For any other value set, a partition image is deployed."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"},{"line_number":56,"context_line":"to only support deploying of the disk image via the deploy images. This is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_57d194f9","line":53,"updated":"2014-06-27 13:43:49.000000000","message":"Can we add a check here, that destination has enough hard driver to put given image on it?","commit_id":"20dead2e8e24823662fdc1f7b9c6547e0c3dba0c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e1f2f0d2d098709b39009d4cedf7191386352bc7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"a disk image. If either one of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 is set, it does not validate"},{"line_number":51,"context_line":"any parameters related to partition images such as root_gb, swap_mb,"},{"line_number":52,"context_line":"ephemeral_gb, etc and goes on to continue to deploy a whole disk image."},{"line_number":53,"context_line":"For any other value set, a partition image is deployed."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"},{"line_number":56,"context_line":"to only support deploying of the disk image via the deploy images. This is"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab895d6_b34f0592","line":53,"in_reply_to":"1ae5cdf2_57d194f9","updated":"2014-06-30 12:11:41.000000000","message":"Nice, that sounds good. Thanks.","commit_id":"20dead2e8e24823662fdc1f7b9c6547e0c3dba0c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0b5ede868b566d34a9fb2e56dd2b5b93759bffc0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"ephemeral_gb, etc and goes on to continue to deploy a whole disk image."},{"line_number":53,"context_line":"For any other value set, a partition image is deployed."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"},{"line_number":56,"context_line":"to only support deploying of the disk image via the deploy images. This is"},{"line_number":57,"context_line":"because Whole disk images need to be booted locally from disk, and hence a"},{"line_number":58,"context_line":"Power Manager call will be made to change the boot order for whole disk images"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_77ccd061","line":55,"updated":"2014-06-27 13:43:49.000000000","message":"s/ ,/, /","commit_id":"20dead2e8e24823662fdc1f7b9c6547e0c3dba0c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e1f2f0d2d098709b39009d4cedf7191386352bc7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"ephemeral_gb, etc and goes on to continue to deploy a whole disk image."},{"line_number":53,"context_line":"For any other value set, a partition image is deployed."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"},{"line_number":56,"context_line":"to only support deploying of the disk image via the deploy images. This is"},{"line_number":57,"context_line":"because Whole disk images need to be booted locally from disk, and hence a"},{"line_number":58,"context_line":"Power Manager call will be made to change the boot order for whole disk images"}],"source_content_type":"text/x-rst","patch_set":9,"id":"dab895d6_f3497d8c","line":55,"in_reply_to":"1ae5cdf2_77ccd061","updated":"2014-06-30 12:11:41.000000000","message":"Done","commit_id":"20dead2e8e24823662fdc1f7b9c6547e0c3dba0c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"14d77cbc5beef607b8f535b60ebcbba0c312736d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"A significantly important use-case would be to deploy Windows Images on"},{"line_number":25,"context_line":"baremetal systems. Since Windows cannot be PXE-Booted via a certain"},{"line_number":26,"context_line":"kernel/ramdisk, there\u0027s no choice but to deploy whole disk Windows images."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_eaecf091","line":26,"updated":"2014-07-02 06:59:13.000000000","message":"This statement is false: it is possible to PXE boot Windows images by chain-loading \"hd0\"\nSee Peter\u0027s code here:\n\nhttps://github.com/ppouliot/ironic/commit/02fc294bda94f9d3dceb1f7793282206e3fae8a1","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"f43326a12f8597dd4d710de5dad7676b166d7756","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"A significantly important use-case would be to deploy Windows Images on"},{"line_number":25,"context_line":"baremetal systems. Since Windows cannot be PXE-Booted via a certain"},{"line_number":26,"context_line":"kernel/ramdisk, there\u0027s no choice but to deploy whole disk Windows images."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_b9ebf011","line":26,"in_reply_to":"baada198_9105637c","updated":"2014-07-03 15:35:31.000000000","message":"Not every setup has the capability to modify boot order. Some machines are only interfaced through a PDU and the BIOS is already setup for some specific boot order. chainloading makes sense in these setups.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"0eee1dfaa1d5be1d7de3cd0c89076d95d683a921","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"A significantly important use-case would be to deploy Windows Images on"},{"line_number":25,"context_line":"baremetal systems. Since Windows cannot be PXE-Booted via a certain"},{"line_number":26,"context_line":"kernel/ramdisk, there\u0027s no choice but to deploy whole disk Windows images."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_73a8698d","line":26,"in_reply_to":"baada198_b9ebf011","updated":"2014-07-04 20:03:51.000000000","message":"This topic came up, there was a patch before with this exact procedure. It was discussed and then come to a conclusion that, we PXE-Boot for PXE-boot scenarios and local-boot for local boot scenarios. So even if the Power Manager does not have the ability to switch boot order, the node will eventually fail PXE and boot from hard disk going down the boot order.\n\nAs for chainloading, It\u0027s just a separate config file, not related to deploying plain Whole Disk Images. Just changing the current PXE config template file should give you that. Although, it\u0027s currently a PXE-Config per conductor and not per deployment.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"407068bd50797a6bd75a3b9683700779faaef59b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"A significantly important use-case would be to deploy Windows Images on"},{"line_number":25,"context_line":"baremetal systems. Since Windows cannot be PXE-Booted via a certain"},{"line_number":26,"context_line":"kernel/ramdisk, there\u0027s no choice but to deploy whole disk Windows images."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_9105637c","line":26,"in_reply_to":"baada198_eaecf091","updated":"2014-07-02 09:13:59.000000000","message":"PXE Chain-load \"hd0\" is still eventually going to local-boot the node? \n\nHere\u0027s my assumption about \u0027PXE-Boot\u0027. For windows, PXE won\u0027t boot off a tftp directory like it does for linux now. So by chain-loading, it simply hands over responsibility to the node instead of actually booting the operating system on its own which can just as well be done by changing the boot order via a Power Manager Call.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"390c2287491b1e779027d1529b414f5265a4de09","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_a663f3da","line":31,"updated":"2014-07-02 19:54:27.000000000","message":"Can we make this Glance property more generic so Nova could use it too? The problem describes here is not specific to Ironic.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"0eee1dfaa1d5be1d7de3cd0c89076d95d683a921","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_13facd42","line":31,"in_reply_to":"baada198_338b5169","updated":"2014-07-04 20:03:51.000000000","message":"AMI !\u003d Partition Images. AMI \u003d Image format. Partition Images are not bound to any format. The two are very different things.\n\nThe idea as I understand it is that Nova prefers disk images for virtual machines. That, is the most commonly used pattern currently AIUI. Forcing all the users to switch to an option is just too burdensome to be even considered. I\u0027m not a fan of that option myself, but it seems like the explicit value is needed. READ Below.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"8a52097de739ef720640dc36b816870acc0bad4c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_c00cfd3d","line":31,"in_reply_to":"baada198_80f78c8a","updated":"2014-07-04 17:30:57.000000000","message":"I think this problem is very much isolated to Ironic. Do you see a case where people would use anything other than whole disk images in Nova? Why does Nova need to support Partition Images?","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"50b27996c09016c50b8d990df97efddfa38540a8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_dded0927","line":31,"in_reply_to":"baada198_a663f3da","updated":"2014-07-03 04:04:02.000000000","message":"Though currently, Ironic will be the only one to consume it? Nova deploys whole disk images by default anyway. So I don\u0027t think Nova would want to use it. What do you think?","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"b394d6f2a7d0a7a10103f79cd5f558b4b8cb7381","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_338b5169","line":31,"in_reply_to":"baada198_c00cfd3d","updated":"2014-07-04 19:25:53.000000000","message":"Nova supports AMI images.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"f43326a12f8597dd4d710de5dad7676b166d7756","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_99ec6cf5","line":31,"in_reply_to":"baada198_dded0927","updated":"2014-07-03 15:35:31.000000000","message":"Changing the property name when Nova uses it will be an additional burden imposed on the different deployers. The current proposed change already imposes that burden on deployers. We will not be able to use current glance images with bare-metal only due to this property that will have to be added.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"55eab1cb3cc765d164c2980c148d585ce29f12b0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":32,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":33,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":34,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"baada198_80f78c8a","line":31,"in_reply_to":"baada198_dded0927","updated":"2014-07-03 16:58:06.000000000","message":"Nova does not do any validation as imposed by Ironic where you would have to set a boolean property to True to allow its deployment. You can upload a partition image without kernel/ramdisk just fine in Nova, it just won\u0027t boot. Ironic is introducing (already has) a validation not present/imposed in Nova.\n\nThe idea is to extend the use of this new property to Nova too as it\u0027s not a problem isolated to Ironic. I would therefore like the problem to be addressed in a more generic way instead of introducing namespaced Glance property for Ironic only.\n\nThis property would however break backward compatibility for Nova as you would now HAVE to provide it when uploading whole disk image.\n\nIMO, this discussion should be extended to Nova and Glance too.","commit_id":"d90bd5ee4a4de1b34626a51af3d4cbabe336e610"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6a81d5f3c393bb2df779c5bedb287bae4cffa253","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":29,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":30,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":31,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baa201ad_749a326f","line":28,"updated":"2014-10-06 23:19:16.000000000","message":"I think the property name should be more generic, and not pinned to Ironic. something like \"Is_whole_disk_image\" would make more sense to me.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"c14e833b2e9114740269da4a2fb3ca29ea5c6fe5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":29,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":30,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":31,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baa201ad_c3a96291","line":28,"in_reply_to":"baa201ad_749a326f","updated":"2014-10-07 16:48:24.000000000","message":"Initially, people were concerned that we were updating a glance metadata attribute which was only ever going to used by Ironic hence the name but sure, is_whole_disk_image though sounds semantically more correct than ironic_deploy_disk.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6a81d5f3c393bb2df779c5bedb287bae4cffa253","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The Nova Ironic Driver will use the explicit `ironic_deploy_disk` value"},{"line_number":35,"context_line":"and PATCH it onto Ironic\u0027s instance_info dict with a key named as"},{"line_number":36,"context_line":"\u0027deploy_disk\u0027 to tell Ironic to deploy a whole disk image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It needs to be noted that the Glance property \u0027ironic_deploy_disk\u0027"},{"line_number":39,"context_line":"is only valid for the Nova Ironic Driver and will only be used by the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baa201ad_147e4619","line":36,"updated":"2014-10-06 23:19:16.000000000","message":"again this may be confused with the deploy kernel and ramdisk. again would something like: Is_whole_disk_image work here.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"c14e833b2e9114740269da4a2fb3ca29ea5c6fe5","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The Nova Ironic Driver will use the explicit `ironic_deploy_disk` value"},{"line_number":35,"context_line":"and PATCH it onto Ironic\u0027s instance_info dict with a key named as"},{"line_number":36,"context_line":"\u0027deploy_disk\u0027 to tell Ironic to deploy a whole disk image."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It needs to be noted that the Glance property \u0027ironic_deploy_disk\u0027"},{"line_number":39,"context_line":"is only valid for the Nova Ironic Driver and will only be used by the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baa201ad_0397ea48","line":36,"in_reply_to":"baa201ad_147e4619","updated":"2014-10-07 16:48:24.000000000","message":"Done.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6a81d5f3c393bb2df779c5bedb287bae4cffa253","unresolved":false,"context_lines":[{"line_number":72,"context_line":"- As images cannot be safely differentiated apart from whether they are really"},{"line_number":73,"context_line":"whole disk images or partition images without examining the internals of the"},{"line_number":74,"context_line":"image, it may be inappropriate to assume that they are disk/partition images"},{"line_number":75,"context_line":"based on the presence of an associated kernel/ramdisk in Glance. Furthermore,"},{"line_number":76,"context_line":"if the user fails to associate a kernel/ramdisk and expects to deploy a"},{"line_number":77,"context_line":"partition image, it\u0027d be good to error out early rather than not knowing at"},{"line_number":78,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baa201ad_14600600","line":75,"updated":"2014-10-06 23:19:16.000000000","message":"I\u0027m not sure I agree here. It up to the user to correctly set kernel and ramdisk properties. just as they would have to set \u0027ironic_deploy_disk\u0027 so I think it would be safe to assume that an image with out kernel and ramdisk properties could be assumed to be a whole disk image. I welcome other reviewer input on this.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"c14e833b2e9114740269da4a2fb3ca29ea5c6fe5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"- As images cannot be safely differentiated apart from whether they are really"},{"line_number":73,"context_line":"whole disk images or partition images without examining the internals of the"},{"line_number":74,"context_line":"image, it may be inappropriate to assume that they are disk/partition images"},{"line_number":75,"context_line":"based on the presence of an associated kernel/ramdisk in Glance. Furthermore,"},{"line_number":76,"context_line":"if the user fails to associate a kernel/ramdisk and expects to deploy a"},{"line_number":77,"context_line":"partition image, it\u0027d be good to error out early rather than not knowing at"},{"line_number":78,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baa201ad_adbd1d04","line":75,"in_reply_to":"baa201ad_14600600","updated":"2014-10-07 16:48:24.000000000","message":"Hmm, that was how I went out implementing initially, but the feedback was that an explicit tag is more appropriate since it is less error-prone. Sure, more input would be great :-)","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":12060,"name":"Jonathan Provost","email":"jprovost.sh@gmail.com","username":"jprovost"},"change_message_id":"115bfca85db7e69c4d7069552d2224ae31b180bc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"It was suggested that one could assume image type(i.e part or disk) based on"},{"line_number":82,"context_line":"the image format. So, AMI for Partition images, QCOW2, RAW, etc for Disk"},{"line_number":83,"context_line":"Images. This does not seem appropriate as the other image formats could"},{"line_number":84,"context_line":"also very well be used as a Partition image with a certain Kernel/Ramdisk."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Data model impact"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baada198_248d94d3","line":84,"updated":"2014-07-08 01:46:43.000000000","message":"I agree with the fact that the image type is not helping here.  What about checking the presence of a partition table?  It could be done just before deployment using parted, it actually works for me.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"641256a35e41be9a16d850dc53ae199d90c6acd7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"It was suggested that one could assume image type(i.e part or disk) based on"},{"line_number":82,"context_line":"the image format. So, AMI for Partition images, QCOW2, RAW, etc for Disk"},{"line_number":83,"context_line":"Images. This does not seem appropriate as the other image formats could"},{"line_number":84,"context_line":"also very well be used as a Partition image with a certain Kernel/Ramdisk."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Data model impact"},{"line_number":87,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"baada198_e304fd7f","line":84,"in_reply_to":"baada198_248d94d3","updated":"2014-07-10 17:35:06.000000000","message":"I think we want to stay away from poking inside of the image as much as possible. The case you mentioned as I understand isn\u0027t a generic one and may fail out with different types of images.","commit_id":"d189f37a6a6ba0b9cd2c6434489a747871300266"}],"specs/kilo/whole-disk-image-pxe-driver.rst":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"002c1f38cdd14af17fe0d5dce271e84cd96c17d3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"is only valid for the Nova Ironic Driver and will only be used by the"},{"line_number":40,"context_line":"Nova Ironic Driver and Ironic itself has an explicit \u0027is_whole_disk_image\u0027"},{"line_number":41,"context_line":"value set into it\u0027s instance_info dict by the Nova Ironic Driver and will"},{"line_number":42,"context_line":"not depend on the Glance Image property for making the decision."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Once the deployment related values are patched into Ironic, Ironic checks"},{"line_number":45,"context_line":"for the is_whole_disk_image variable to validate various paramaters related to"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_8f4a7f25","line":42,"updated":"2014-10-13 18:10:02.000000000","message":"i assume there is a deliberate reason why nova should pick up the \u0027is_whole_disk_image\u0027 property from glance image and put it in instance_info. if so, can you please state it here ?\n\nto my mind, \u0027is_whole_disk_image\u0027 is similar to \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 in the glance image.  ironic *does* read both kernel_id and ramdisk_id, and straight away i don\u0027t see a reason why ironic should refrain from reading directly from glance. if ironic does read from glance, i see that our changes are no-longer dependent on nova.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"fa95088647c12bb3bc76497a83fcc7ed7a850f40","unresolved":false,"context_lines":[{"line_number":39,"context_line":"is only valid for the Nova Ironic Driver and will only be used by the"},{"line_number":40,"context_line":"Nova Ironic Driver and Ironic itself has an explicit \u0027is_whole_disk_image\u0027"},{"line_number":41,"context_line":"value set into it\u0027s instance_info dict by the Nova Ironic Driver and will"},{"line_number":42,"context_line":"not depend on the Glance Image property for making the decision."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Once the deployment related values are patched into Ironic, Ironic checks"},{"line_number":45,"context_line":"for the is_whole_disk_image variable to validate various paramaters related to"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_6b8c01db","line":42,"in_reply_to":"baa201ad_8f4a7f25","updated":"2014-10-27 08:08:54.000000000","message":"This was originally how I implemented it. I can\u0027t seem to remember why we went on to consult Nova now. I don\u0027t see now why Ironic shouldn\u0027t. Thanks a lot.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ffab06aa9d9ce75fbf61d7d9c2e0c52112f03039","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if the user fails to associate a kernel/ramdisk and expects to deploy a"},{"line_number":69,"context_line":"partition image, it\u0027d be good to error out early rather than not knowing at"},{"line_number":70,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"},{"line_number":71,"context_line":"it has been decided to keep this decision explicit."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"It was suggested that one could assume image type(i.e part or disk) based on"},{"line_number":74,"context_line":"the image format. So, AMI for Partition images, QCOW2, RAW, etc for Disk"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_048f7824","line":71,"updated":"2014-10-10 23:13:04.000000000","message":"I brought this up in a past review, It is up to the user to correctly set kernel and ramdisk properties. just as they would have to set \u0027is_whole_disk_image\u0027. So I think it would be safe to assume that an image in glance with out kernel and ramdisk properties could be assumed to be a whole disk image. \n\nI welcome other reviewer input on this.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"12a653ffecafd81cb3d2fcfe4cf07b76d10a1fe6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if the user fails to associate a kernel/ramdisk and expects to deploy a"},{"line_number":69,"context_line":"partition image, it\u0027d be good to error out early rather than not knowing at"},{"line_number":70,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"},{"line_number":71,"context_line":"it has been decided to keep this decision explicit."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"It was suggested that one could assume image type(i.e part or disk) based on"},{"line_number":74,"context_line":"the image format. So, AMI for Partition images, QCOW2, RAW, etc for Disk"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_8e639cb0","line":71,"in_reply_to":"7a8c0949_144b0e88","updated":"2014-11-10 19:38:04.000000000","message":"Done, thanks, I think this way of inferring is cleaner.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"002c1f38cdd14af17fe0d5dce271e84cd96c17d3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if the user fails to associate a kernel/ramdisk and expects to deploy a"},{"line_number":69,"context_line":"partition image, it\u0027d be good to error out early rather than not knowing at"},{"line_number":70,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"},{"line_number":71,"context_line":"it has been decided to keep this decision explicit."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"It was suggested that one could assume image type(i.e part or disk) based on"},{"line_number":74,"context_line":"the image format. So, AMI for Partition images, QCOW2, RAW, etc for Disk"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_4f0c1795","line":71,"in_reply_to":"baa201ad_048f7824","updated":"2014-10-13 18:10:02.000000000","message":"+1. \n\nbut from backward compatibility view - currently the user would get a validate error if they forgot to put kernel_id and ramdisk_id. now the new behavior will change that to an acceptable image.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"56158aefdfd84702ec2859ed004936db226d320a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if the user fails to associate a kernel/ramdisk and expects to deploy a"},{"line_number":69,"context_line":"partition image, it\u0027d be good to error out early rather than not knowing at"},{"line_number":70,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"},{"line_number":71,"context_line":"it has been decided to keep this decision explicit."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"It was suggested that one could assume image type(i.e part or disk) based on"},{"line_number":74,"context_line":"the image format. So, AMI for Partition images, QCOW2, RAW, etc for Disk"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a8c0949_144b0e88","line":71,"in_reply_to":"baa201ad_4f0c1795","updated":"2014-11-04 23:00:40.000000000","message":"maybe not a good suggestion, would it be ok that setting the kernel_id/ramdisk_id to the image itself to indicate the is_whole_disk_image?","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"99e912b2741588d153de8db3b289b1be2d072a06","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"A new is_whole_disk_image boolean attribute will be added to the instance_info"},{"line_number":82,"context_line":"dict. Based on this key, we decide to validate various parameters"},{"line_number":83,"context_line":"such as root_gb, swap_mb, ephemeral_mb, etc and then proceed appropriately to"},{"line_number":84,"context_line":"deploy either a disk image or a partition image."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_67009f34","line":83,"updated":"2014-10-08 08:00:14.000000000","message":"Btw, what will be the meanings of root_gb, swap_mb, ephemeral_mb in case of whole disk images? Could you please elaborate on validation step.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09f80bd9296505181c4cb3681592b42c4007ac04","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"A new is_whole_disk_image boolean attribute will be added to the instance_info"},{"line_number":82,"context_line":"dict. Based on this key, we decide to validate various parameters"},{"line_number":83,"context_line":"such as root_gb, swap_mb, ephemeral_mb, etc and then proceed appropriately to"},{"line_number":84,"context_line":"deploy either a disk image or a partition image."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_7c59f033","line":83,"in_reply_to":"baa201ad_03996778","updated":"2014-10-09 08:05:06.000000000","message":"thanks, please state this information here","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2855e95d9742eaa6bc253c94faa198b60c93446b","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"A new is_whole_disk_image boolean attribute will be added to the instance_info"},{"line_number":82,"context_line":"dict. Based on this key, we decide to validate various parameters"},{"line_number":83,"context_line":"such as root_gb, swap_mb, ephemeral_mb, etc and then proceed appropriately to"},{"line_number":84,"context_line":"deploy either a disk image or a partition image."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_03996778","line":83,"in_reply_to":"baa201ad_67009f34","updated":"2014-10-09 05:54:45.000000000","message":"So, if a flavor consists of swap/ephemeral and we\u0027re deploying whole disk images, we fail immediately asking the user to specify a flavor with only root_gb. \n\nIf we choose to not respect swap and ephemeral in the flavor, then we get into all sorts of scheduling problems, so it\u0027s best this be a validation for whole disk images.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"fa95088647c12bb3bc76497a83fcc7ed7a850f40","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"A new is_whole_disk_image boolean attribute will be added to the instance_info"},{"line_number":82,"context_line":"dict. Based on this key, we decide to validate various parameters"},{"line_number":83,"context_line":"such as root_gb, swap_mb, ephemeral_mb, etc and then proceed appropriately to"},{"line_number":84,"context_line":"deploy either a disk image or a partition image."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_ebbf115f","line":83,"in_reply_to":"baa201ad_7c59f033","updated":"2014-10-27 08:08:54.000000000","message":"Done","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"99e912b2741588d153de8db3b289b1be2d072a06","unresolved":false,"context_lines":[{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Since this change affects instance_info, the Nova Ironic driver needs to set"},{"line_number":105,"context_line":"this value to Ironic\u0027s PXE Deploy driver."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_c7ca2b1a","line":105,"updated":"2014-10-08 08:00:14.000000000","message":"Please provide a link to a Nova spec. We also can\u0027t approve this spec IMO until Nova approves their side, because it should land first.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09f80bd9296505181c4cb3681592b42c4007ac04","unresolved":false,"context_lines":[{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Since this change affects instance_info, the Nova Ironic driver needs to set"},{"line_number":105,"context_line":"this value to Ironic\u0027s PXE Deploy driver."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_1c854459","line":105,"in_reply_to":"baa201ad_0370873e","updated":"2014-10-09 08:05:06.000000000","message":"then please get explicit agreement from Nova folks, that this change does not require a spec on their side. this is possible: IIRC they decided to have simple blueprints w/o specs. so your actions should be (again IIRC): file a nova blueprint, ask nova folks to accept it, if they demand spec - write one.\n\nI understand your frustration, but it\u0027s of no use to land ironic change without nova one anyway.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"fa95088647c12bb3bc76497a83fcc7ed7a850f40","unresolved":false,"context_lines":[{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Since this change affects instance_info, the Nova Ironic driver needs to set"},{"line_number":105,"context_line":"this value to Ironic\u0027s PXE Deploy driver."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_8bae852c","line":105,"in_reply_to":"baa201ad_1c854459","updated":"2014-10-27 08:08:54.000000000","message":"Alright, I think the above mentioned comment eliminates the dependency on Nova. I will propose a revised spec without the dependency.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2855e95d9742eaa6bc253c94faa198b60c93446b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Since this change affects instance_info, the Nova Ironic driver needs to set"},{"line_number":105,"context_line":"this value to Ironic\u0027s PXE Deploy driver."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Security impact"},{"line_number":108,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_0370873e","line":105,"in_reply_to":"baa201ad_c7ca2b1a","updated":"2014-10-09 05:54:45.000000000","message":"Oh no! Do we have to do this? It\u0027s barely a 5 line change that just passes in a new parameter is_whole_disk_image to be patched into instance_info dict based on the glance tag.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"99e912b2741588d153de8db3b289b1be2d072a06","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Other deployer impact"},{"line_number":128,"context_line":"---------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"There is no implicit mechanism to detect disk images from partition images"},{"line_number":131,"context_line":"being implemented in this change. Deployers will have to explicitly set"},{"line_number":132,"context_line":"Boolean value \u0027is_whole_disk_image\u0027 in either Glance\u0027s image properties or if"},{"line_number":133,"context_line":"they are supposedly consuming Ironic as a service directly, they must patch"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_c7986b1e","line":130,"updated":"2014-10-08 08:00:14.000000000","message":"s/detect/distinguish/ ?","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2855e95d9742eaa6bc253c94faa198b60c93446b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Other deployer impact"},{"line_number":128,"context_line":"---------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"There is no implicit mechanism to detect disk images from partition images"},{"line_number":131,"context_line":"being implemented in this change. Deployers will have to explicitly set"},{"line_number":132,"context_line":"Boolean value \u0027is_whole_disk_image\u0027 in either Glance\u0027s image properties or if"},{"line_number":133,"context_line":"they are supposedly consuming Ironic as a service directly, they must patch"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_2392eb4b","line":130,"in_reply_to":"baa201ad_c7986b1e","updated":"2014-10-09 05:54:45.000000000","message":"Done.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"2298b856765f057b0db18e74084e6920ad095ac4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"being implemented in this change. Deployers will have to explicitly set"},{"line_number":132,"context_line":"Boolean value \u0027is_whole_disk_image\u0027 in either Glance\u0027s image properties or if"},{"line_number":133,"context_line":"they are supposedly consuming Ironic as a service directly, they must patch"},{"line_number":134,"context_line":"\u0027is_whole_disk_image\u0027 boolean into Ironic\u0027s instance_info dict via REST API."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"For those using disk-image-builder to build images, currently, the `vm` element"},{"line_number":137,"context_line":"should help in building of whole-disk-images."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a8c0949_573cb8e2","line":134,"updated":"2014-11-05 04:53:48.000000000","message":"you meant add \u0027is_whole_disk_image\u0027 property to instance_info manually using ironic node-update command right? This change shouldn\u0027t need any changes to REST API as mentioned in REST API impact section?\nplease clarify if I\u0027m wrong","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"12a653ffecafd81cb3d2fcfe4cf07b76d10a1fe6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"being implemented in this change. Deployers will have to explicitly set"},{"line_number":132,"context_line":"Boolean value \u0027is_whole_disk_image\u0027 in either Glance\u0027s image properties or if"},{"line_number":133,"context_line":"they are supposedly consuming Ironic as a service directly, they must patch"},{"line_number":134,"context_line":"\u0027is_whole_disk_image\u0027 boolean into Ironic\u0027s instance_info dict via REST API."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"For those using disk-image-builder to build images, currently, the `vm` element"},{"line_number":137,"context_line":"should help in building of whole-disk-images."}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_4ebb740e","line":134,"in_reply_to":"7a8c0949_573cb8e2","updated":"2014-11-10 19:38:04.000000000","message":"Nope, that was probably a mistake. In any case, moving away from the tag to inferring whole disk images.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"99e912b2741588d153de8db3b289b1be2d072a06","unresolved":false,"context_lines":[{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_a7a4474b","line":143,"updated":"2014-10-08 08:00:14.000000000","message":"\"which is the only deploy driver present in Ironic today\" we also have IPA deploy driver, which is similar. Please state if this change will enable deploy whole disk images for agent driver (likely yes).","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8ef678ebb9233cfd79708486766f772c0f6aba52","unresolved":false,"context_lines":[{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_e698281e","line":143,"in_reply_to":"9aa7fdbe_8b75a5cc","updated":"2014-10-27 08:59:02.000000000","message":"Thanks a lot, I can help in making the changes too, but would help if you would just refer it in this spec that changes will be made in iscsi_ilo driver too for this.  Then I can probably throw in a patch dependent on your patches. :-)","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"12a653ffecafd81cb3d2fcfe4cf07b76d10a1fe6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_0e488c2c","line":143,"in_reply_to":"9aa7fdbe_e698281e","updated":"2014-11-10 19:38:04.000000000","message":"Done","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"002c1f38cdd14af17fe0d5dce271e84cd96c17d3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_2e851959","line":143,"in_reply_to":"baa201ad_03a7a7a7","updated":"2014-10-13 18:10:02.000000000","message":"ipa deploys only whole disk images so i think it doesn\u0027t apply to ipa.  but iscsi_ilo use the same backend as pxe driver (iscsi_deploy), and should be able to benifit straight away from this change as pxe driver.  it should be a small change (same as that of pxe driver)  to make this happen for iscsi_ilo driver.  \n\ni would be happy if this change enables for iscsi_ilo driver too :)","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"fa95088647c12bb3bc76497a83fcc7ed7a850f40","unresolved":false,"context_lines":[{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_8b75a5cc","line":143,"in_reply_to":"baa201ad_2e851959","updated":"2014-10-27 08:08:54.000000000","message":"Sure, I\u0027d be happy to help. I don\u0027t have the resources to test iLO however.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2855e95d9742eaa6bc253c94faa198b60c93446b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"----------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_03a7a7a7","line":143,"in_reply_to":"baa201ad_a7a4474b","updated":"2014-10-09 05:54:45.000000000","message":"Oops, this spec is a little old :-) Thanks for pointing it out and I think IIRC, the IPA only deploys whole disk images presently?","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"867b0e3b90c22895cf32dc8a4e4158867d3bbd32","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a8c0949_fd7dd3b2","line":144,"updated":"2014-10-30 04:49:57.000000000","message":"The propsed glance image proeprty can be used by Ironic drivers that want to add full disk image support.   So, my suggestion is to make this spec generic (not specific to PXE) so that any driver that wants to support full disk image can use the same glance image property.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"12a653ffecafd81cb3d2fcfe4cf07b76d10a1fe6","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"This change only works for the PXE Deploy Driver, which is the only deploy"},{"line_number":143,"context_line":"driver present in Ironic today. However, this change will try and make it"},{"line_number":144,"context_line":"as generic as possible in relation to the current Ironic architecture for"},{"line_number":145,"context_line":"future deploy drivers to easily consume this change."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a890539_2ebe2800","line":144,"in_reply_to":"7a8c0949_fd7dd3b2","updated":"2014-11-10 19:38:04.000000000","message":"Done","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"99e912b2741588d153de8db3b289b1be2d072a06","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Partially Depends On spec/better-bootloader-options.rst"},{"line_number":168,"context_line":"- https://review.openstack.org/#/c/94925/"},{"line_number":169,"context_line":"- Currently, there exists an internal API call not exposed to the user that"},{"line_number":170,"context_line":"allows us to tell the power manager to change the boot order. The"},{"line_number":171,"context_line":"aforementioned spec consists of a feature that exposes this option to the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_6775ffc9","line":168,"updated":"2014-10-08 08:00:14.000000000","message":"You can\u0027t really depend on abandoned spec. Also judging by what you write below, it\u0027s not a dependency, it\u0027s a possible  conflict, no? If it is a dependency, you should either ask Deva to revive it or overtake.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2855e95d9742eaa6bc253c94faa198b60c93446b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Partially Depends On spec/better-bootloader-options.rst"},{"line_number":168,"context_line":"- https://review.openstack.org/#/c/94925/"},{"line_number":169,"context_line":"- Currently, there exists an internal API call not exposed to the user that"},{"line_number":170,"context_line":"allows us to tell the power manager to change the boot order. The"},{"line_number":171,"context_line":"aforementioned spec consists of a feature that exposes this option to the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_63af937d","line":168,"in_reply_to":"baa201ad_6775ffc9","updated":"2014-10-09 05:54:45.000000000","message":"Yep, I\u0027ll remove the dependency. It\u0027s just that the spec was written a long time ago. Thanks a lot for pointing this out again.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"002c1f38cdd14af17fe0d5dce271e84cd96c17d3","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Partially Depends On spec/better-bootloader-options.rst"},{"line_number":168,"context_line":"- https://review.openstack.org/#/c/94925/"},{"line_number":169,"context_line":"- Currently, there exists an internal API call not exposed to the user that"},{"line_number":170,"context_line":"allows us to tell the power manager to change the boot order. The"},{"line_number":171,"context_line":"aforementioned spec consists of a feature that exposes this option to the"},{"line_number":172,"context_line":"user allowing him to configure the boot order. The current spec proposed"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_ef706b42","line":169,"updated":"2014-10-13 18:10:02.000000000","message":"is this talking about set_boot_device() ? if so, it has changed and it is available for the user too. :)\n\nbut all drivers are impacted by this. the user could take an instance deployed with current pxe driver (which needs to boot always from \u0027net\u0027) and change the boot order to disk.  \n\ni can\u0027t see the dependency for this on set_boot_device() ? does this exist still ?","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"fa95088647c12bb3bc76497a83fcc7ed7a850f40","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Partially Depends On spec/better-bootloader-options.rst"},{"line_number":168,"context_line":"- https://review.openstack.org/#/c/94925/"},{"line_number":169,"context_line":"- Currently, there exists an internal API call not exposed to the user that"},{"line_number":170,"context_line":"allows us to tell the power manager to change the boot order. The"},{"line_number":171,"context_line":"aforementioned spec consists of a feature that exposes this option to the"},{"line_number":172,"context_line":"user allowing him to configure the boot order. The current spec proposed"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_cb7b2dbc","line":169,"in_reply_to":"baa201ad_ef706b42","updated":"2014-10-27 08:08:54.000000000","message":"Alright, I\u0027ll remove it. Thanks.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"99e912b2741588d153de8db3b289b1be2d072a06","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"No changes made to the API. Deploy Drivers are free to use the"},{"line_number":196,"context_line":"is_whole_disk_image option in the instance_info dict as they like."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_6a3866d3","line":196,"updated":"2014-10-08 08:00:14.000000000","message":"I\u0027m not sure about this one. Can\u0027t we have some means of checking, if the driver supports whole disk image? otherwise user may end up with wrong deploy.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"09f80bd9296505181c4cb3681592b42c4007ac04","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"No changes made to the API. Deploy Drivers are free to use the"},{"line_number":196,"context_line":"is_whole_disk_image option in the instance_info dict as they like."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_dce57c38","line":196,"in_reply_to":"baa201ad_0371670b","updated":"2014-10-09 08:05:06.000000000","message":"Probably does not, but it sounds good. Could you bring this question to devananda and folks today? this seems worth discussing.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b9dac1f4410efc394a912996a983d74ce74b334","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"No changes made to the API. Deploy Drivers are free to use the"},{"line_number":196,"context_line":"is_whole_disk_image option in the instance_info dict as they like."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_2e1db2be","line":196,"in_reply_to":"baa201ad_0371670b","updated":"2014-10-16 14:34:47.000000000","message":"here: https://review.openstack.org/#/c/128927","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"fa95088647c12bb3bc76497a83fcc7ed7a850f40","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"No changes made to the API. Deploy Drivers are free to use the"},{"line_number":196,"context_line":"is_whole_disk_image option in the instance_info dict as they like."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9aa7fdbe_2b3bd9eb","line":196,"in_reply_to":"baa201ad_2e1db2be","updated":"2014-10-27 08:08:54.000000000","message":"Thanks a lot for this effort. I didn\u0027t have time to bring up the question, but thank you again for this effort.","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"2855e95d9742eaa6bc253c94faa198b60c93446b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"No changes made to the API. Deploy Drivers are free to use the"},{"line_number":196,"context_line":"is_whole_disk_image option in the instance_info dict as they like."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Documentation Impact"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baa201ad_0371670b","line":196,"in_reply_to":"baa201ad_6a3866d3","updated":"2014-10-09 05:54:45.000000000","message":"How would we check? One way is if there\u0027s an abstract class to handle get_some_capability that\u0027s implemented by every deploy driver and if that\u0027s not implemented, we could raise NotImplementedError, similar to how Nova-Compute handles with the different vendor drivers. Although I don\u0027t know if that exists today. Does it?","commit_id":"3ab7f6393fecdeaaf1f6a94708511df41f40f312"}],"specs/kilo/whole-disk-image-support.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1200495057d23fcaca27838f2a5ac8f71ab91a16","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Proposed change"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Ironic\u0027s deploy drivers will infer if they have to deploy a whole disk image"},{"line_number":28,"context_line":"or a partition image based on the presence of a kernel/ramdisk by querying"},{"line_number":29,"context_line":"Glance\u0027s properties."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_60b3539a","line":27,"updated":"2014-11-24 14:15:35.000000000","message":"To note, the pxe driver already queries glance for this information in\n  _get_image_info()","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"f5771ecbd150b9184f6e95029b75c06116d35419","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Proposed change"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Ironic\u0027s deploy drivers will infer if they have to deploy a whole disk image"},{"line_number":28,"context_line":"or a partition image based on the presence of a kernel/ramdisk by querying"},{"line_number":29,"context_line":"Glance\u0027s properties."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_ef02cc0a","line":27,"in_reply_to":"5a890539_60b3539a","updated":"2014-11-24 16:42:21.000000000","message":"Agreed, so we could probably use that.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1200495057d23fcaca27838f2a5ac8f71ab91a16","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during validation."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Whole disk images need to be booted locally from disk and cannot be booted"},{"line_number":36,"context_line":"otherwise and hence a Power Manager call will be made explicitly to change"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_80b83f76","line":33,"updated":"2014-11-24 14:15:35.000000000","message":"This requires changes in Nova, so while good to call out here, you may want to seek separate approval (within the Nova program) for them, and include any references here.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"f5771ecbd150b9184f6e95029b75c06116d35419","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during validation."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Whole disk images need to be booted locally from disk and cannot be booted"},{"line_number":36,"context_line":"otherwise and hence a Power Manager call will be made explicitly to change"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_8fea270d","line":33,"in_reply_to":"5a890539_80b83f76","updated":"2014-11-24 16:42:21.000000000","message":"It does? how so? \n\nI just think the existing Nova driver would patch in(pass-through) ephemeral/swap partition sizes as is and then Ironic figures out if the deploy mode is partition or whole disk and then fail if it\u0027s a invalid combination. Eg:- in this case whole_disk+swap/ephemeral is an invalid combination.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8c85419a245749d52a25e5375bb34424fb2b8cd7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during validation."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Whole disk images need to be booted locally from disk and cannot be booted"},{"line_number":36,"context_line":"otherwise and hence a Power Manager call will be made explicitly to change"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a961159_146ccd07","line":33,"in_reply_to":"5a890539_8fea270d","updated":"2015-01-14 02:38:54.000000000","message":"Nova should be validating the combination of flavor and image to ensure that they are compatible with each other.\n\nIf this is passed down to Ironic, the error will happen in such a way that will waste a lot of time (Nova will retry the request, and it will fail again, and again ...). Nova knows both the image and the flavor; both of these are Nova primitives; it is both correct and more efficient to validate them there.\n\nI\u0027m glad to see you added this in later revisions :)","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1200495057d23fcaca27838f2a5ac8f71ab91a16","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Nova driver impact"},{"line_number":80,"context_line":"------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Security impact"},{"line_number":85,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_a0b0db8b","line":82,"updated":"2014-11-24 14:15:35.000000000","message":"As noted above, the scheduler change mentioned is a Nova impact.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"f5771ecbd150b9184f6e95029b75c06116d35419","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Nova driver impact"},{"line_number":80,"context_line":"------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Security impact"},{"line_number":85,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_0fde376d","line":82,"in_reply_to":"5a890539_a0b0db8b","updated":"2014-11-24 16:42:21.000000000","message":"I\u0027ve replied to that above.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1200495057d23fcaca27838f2a5ac8f71ab91a16","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Modify PXE Deploy Driver to support deploying of whole disk images."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Modify Agent Deploy Driver to use the whole-disk-image inference pattern since"},{"line_number":132,"context_line":"it already supports deploying of whole-disk-images by default."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Modify iLO Deploy Driver to support deploying of whole disk images."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_c0ade732","line":132,"updated":"2014-11-24 14:15:35.000000000","message":"What modification is necessary here? The Agent driver already assumes whole-disk-images, and in fact has no support for partition images today.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"f5771ecbd150b9184f6e95029b75c06116d35419","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Modify PXE Deploy Driver to support deploying of whole disk images."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Modify Agent Deploy Driver to use the whole-disk-image inference pattern since"},{"line_number":132,"context_line":"it already supports deploying of whole-disk-images by default."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Modify iLO Deploy Driver to support deploying of whole disk images."},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_6f709b40","line":132,"in_reply_to":"5a890539_c0ade732","updated":"2014-11-24 16:42:21.000000000","message":"Since this spec suggests a generic pattern deploy drivers should use to deploy whole disk images, I assumed IPA and any other deploy driver must also be modified to use the same pattern(if possible) for deploying whole disk images.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1200495057d23fcaca27838f2a5ac8f71ab91a16","unresolved":false,"context_lines":[{"line_number":146,"context_line":"DiskImage-Builder needs to build whole-disk images rather than partition"},{"line_number":147,"context_line":"images as the user image to test this. Alternatively, we could use the Cirros"},{"line_number":148,"context_line":"Whole Disk image provided by the Cirros community as the user image to test"},{"line_number":149,"context_line":"this."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_e0a66353","line":149,"updated":"2014-11-24 14:15:35.000000000","message":"I would prefer we use the Cirros whole-disk image. Support for precaching that could be added to devstack, I believe, fairly easily.","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"f5771ecbd150b9184f6e95029b75c06116d35419","unresolved":false,"context_lines":[{"line_number":146,"context_line":"DiskImage-Builder needs to build whole-disk images rather than partition"},{"line_number":147,"context_line":"images as the user image to test this. Alternatively, we could use the Cirros"},{"line_number":148,"context_line":"Whole Disk image provided by the Cirros community as the user image to test"},{"line_number":149,"context_line":"this."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a890539_2f493331","line":149,"in_reply_to":"5a890539_e0a66353","updated":"2014-11-24 16:42:21.000000000","message":"Done","commit_id":"50f3011f4731d6c93b2aa5e09e0882322c55ae4f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_1a860514","line":33,"updated":"2014-11-27 15:25:11.000000000","message":"It should happen when Nova is scheduling node. Ideally, Nova should not schedule such request at all, but it may be too hard to implement.\n\nOf course, Ironic should do this check as well, because it may be used without Nova.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_ba9331ff","line":33,"in_reply_to":"5a890539_1a860514","updated":"2014-11-27 16:06:41.000000000","message":"Sure, I\u0027ll mention that but won\u0027t the capabilities spec take care of this though? We won\u0027t implement anything hard-coded in Nova especially for this spec, do we?","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ce6fb8b23c4f93a38474a205d0504cf74514770","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_c0c56c0b","line":33,"in_reply_to":"5a890539_ba9331ff","updated":"2014-11-27 16:50:56.000000000","message":"Both capabilities spec are generic, they don\u0027t have particular details. So you may add them (actually the \"hardware\" one) as a dependency and extend in your spec with what capabilities you\u0027re going to offer.\n\nThat said, IMO it\u0027s not a capability. Capability is whether driver can create whole-disk partitions, and it\u0027s worth adding it. But here we talk about using flavor incompatible with the image, it\u0027s Nova\u0027s problem.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9919c2b3e5b5ebf4f95922f5d3aa5617394273cb","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_5aefa8e9","line":33,"in_reply_to":"5a890539_c0c56c0b","updated":"2014-11-27 19:10:22.000000000","message":"That is true, but it\u0027s a flavor that is incompatible with the image type for a `particular driver` here though. The other drivers may/may not support it. So anything driver-related should lie in the driver and not the scheduler? I wonder if we should however add driver-specific checks to the scheduler in the form of a filter? \n\nOn second thoughts, it does reduce considerable overhead when/if a user deploys at a large scale. Again, that comes down to then having the validate logic in two places though? It\u0027s worth it I suppose. I\u0027ll perhaps add a new work item to implement a new filter which checks flavor attributes and the type of image being deployed and the same filter could just as well check anything else that people decide the validation they want at schedule time. It could be one of those filters that are exclusive to Ironic only? How does it sound?\n\nWith that said, I think that should be a different spec anyway for the kind of problem it solves and also probably a nova-spec. Please however, let\u0027s not make that a dependency for this though?","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"},{"line_number":37,"context_line":"node is restarted with a pxe config file that instructs the server to"},{"line_number":38,"context_line":"boot from the local disk(PXE-localboot)."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The agent driver currently only supports deploying whole disk images, however,"},{"line_number":41,"context_line":"the agent driver will adopt the inference pattern stated above to deploy whole"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_9a711547","line":38,"updated":"2014-11-27 15:25:11.000000000","message":"1. can\u0027t we use set_boot_device in the management interface?\n\n2. you should state somewhere that these images are _required_ to have a bootloader on them","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ce6fb8b23c4f93a38474a205d0504cf74514770","unresolved":false,"context_lines":[{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"},{"line_number":37,"context_line":"node is restarted with a pxe config file that instructs the server to"},{"line_number":38,"context_line":"boot from the local disk(PXE-localboot)."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The agent driver currently only supports deploying whole disk images, however,"},{"line_number":41,"context_line":"the agent driver will adopt the inference pattern stated above to deploy whole"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_e0f1886b","line":38,"in_reply_to":"5a890539_05c946ac","updated":"2014-11-27 16:50:56.000000000","message":"1. Sorry I didn\u0027t quite understand. We have an interface for setting a boot device. If you\u0027re working around it, that\u0027s a problem. SO a user will issue a get_boot_device call, it will return \u0027PXE\u0027, while actually you boot from the local driver. It looks wrong, doesn\u0027t it?\n\n2. Documentation should be enough","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"},{"line_number":37,"context_line":"node is restarted with a pxe config file that instructs the server to"},{"line_number":38,"context_line":"boot from the local disk(PXE-localboot)."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The agent driver currently only supports deploying whole disk images, however,"},{"line_number":41,"context_line":"the agent driver will adopt the inference pattern stated above to deploy whole"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_05c946ac","line":38,"in_reply_to":"5a890539_9a711547","updated":"2014-11-27 16:06:41.000000000","message":"1. I had a chat on IRC a few days back about this. So the idea is to not conflate boot device selection based on the image structure. If one uses a PXE driver, then the default boot device is PXE unless otherwise overridden by the user.\n\nThere\u0027s an unanswered question here though, what if the user wants a said boot device explicitly changed at deploy-time? Do we incorporate that in the deployment workflow somehow or do we leave it to the user to manually change it? I can\u0027t imagine sending it through Nova although I think it\u0027d be great in the instance_info dict?\n\n2. I could perhaps add a work-item to update the docs on this? Although, I think the general convention is to have disk images with a bootloader in them? Nova seems to expect that?","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9919c2b3e5b5ebf4f95922f5d3aa5617394273cb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"For the PXE Deploy driver, once the image structure is infered and is found"},{"line_number":36,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"},{"line_number":37,"context_line":"node is restarted with a pxe config file that instructs the server to"},{"line_number":38,"context_line":"boot from the local disk(PXE-localboot)."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The agent driver currently only supports deploying whole disk images, however,"},{"line_number":41,"context_line":"the agent driver will adopt the inference pattern stated above to deploy whole"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_66e21003","line":38,"in_reply_to":"5a890539_e0f1886b","updated":"2014-11-27 19:10:22.000000000","message":"1. That\u0027s a really good point. However, it\u0027s still PXE, but its PXE-\u003e`localboot 0`. It\u0027s also arguable that the user chooses a pxe-driver and does get_boot_device() and gets \u0027disk\u0027 when he could\u0027ve expected \u0027pxe\u0027 to return?\n\nSo, then there are two ways to do this. We could PXE-boot for PXE based environments and local-boot for local environments __or__ we could choose a boot device based on the type of the deploy driver being deployed and if needed we could let the user change the boot device.\n\nI spoke to Devananda about it and he seemed to think that setting the boot device is orthogonal to the image structure itself. So, anything the PXE deploy driver controls should always be booted via PXE. \nAIUI, the reasoning is that some folks may want everything to be PXE-controlled. They restrict the boot sequence and if there isn\u0027t a PXE controller around, they don\u0027t want the machines to boot up at all and start acting up un-managed. \nThat\u0027s basically just de-coupling boot_device and image_structure and giving users the option to use any combination they want.\n\nHowever, we could also use the former approach and let the periodic task shut down any machines that comes up un-managed albeit with a tolerance level at how frequent the periodic task itself runs.\n\nStill, it seems like we should support all combinations and just not restrict the user to a certain combination.\n\nHere\u0027s the relevant IRC logs of where the discussion happened, you could search for my name there for reference. http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2014-11-24.log","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Nova driver impact"},{"line_number":82,"context_line":"------------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Security impact"},{"line_number":87,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_5a9ecd55","line":84,"updated":"2014-11-27 15:25:11.000000000","message":"see above - we should duplicate checks on Nova side, so that we fail early (ideally before scheduling)","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Nova driver impact"},{"line_number":82,"context_line":"------------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Security impact"},{"line_number":87,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_45c26e87","line":84,"in_reply_to":"5a890539_5a9ecd55","updated":"2014-11-27 16:06:41.000000000","message":"I\u0027ve commented on this above.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For those using disk-image-builder to build images, currently, the `vm` element"},{"line_number":110,"context_line":"should help in building of whole-disk-images."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_7aab8975","line":109,"updated":"2014-11-27 15:25:11.000000000","message":"nit: s/disk-image-builder/diskimage-builder/","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Other deployer impact"},{"line_number":107,"context_line":"---------------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For those using disk-image-builder to build images, currently, the `vm` element"},{"line_number":110,"context_line":"should help in building of whole-disk-images."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_65bf6afd","line":109,"in_reply_to":"5a890539_7aab8975","updated":"2014-11-27 16:06:41.000000000","message":"Done","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":134,"context_line":"it already supports deploying of whole-disk-images by default."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Modify iLO virtual media Deploy Driver to support deploying of whole disk"},{"line_number":137,"context_line":"images."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_5ac5ed3b","line":137,"updated":"2014-11-27 15:25:11.000000000","message":"IRC both iLO virtual media uses either PXE or agent, so no specific action should be required","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":134,"context_line":"it already supports deploying of whole-disk-images by default."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Modify iLO virtual media Deploy Driver to support deploying of whole disk"},{"line_number":137,"context_line":"images."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_25b802e5","line":137,"in_reply_to":"5a890539_5ac5ed3b","updated":"2014-11-27 16:06:41.000000000","message":"It seems to validate kernel/ramdisk ID which it shouldn\u0027t for whole disk images. So just making sure it works for that driver too.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"May be a dependency - https://review.openstack.org/#/c/128927"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Testing"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_1aeb65b1","line":142,"updated":"2014-11-27 15:25:11.000000000","message":"What do you mean by \"may be\"? :) you spec does not state any driver capabilities.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9919c2b3e5b5ebf4f95922f5d3aa5617394273cb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"May be a dependency - https://review.openstack.org/#/c/128927"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Testing"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_3a63bcde","line":142,"in_reply_to":"5a890539_009e9407","updated":"2014-11-27 19:10:22.000000000","message":"Done","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"May be a dependency - https://review.openstack.org/#/c/128927"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Testing"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_65904a4f","line":142,"in_reply_to":"5a890539_1aeb65b1","updated":"2014-11-27 16:06:41.000000000","message":"deploying whole disk images is a deploy-driver capability? as mentioned in that spec? or am I missing something here?\n\nThe \u0027may be\u0027 is for me being uncertain if it\u0027s a dependency :)","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ce6fb8b23c4f93a38474a205d0504cf74514770","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"May be a dependency - https://review.openstack.org/#/c/128927"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Testing"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_009e9407","line":142,"in_reply_to":"5a890539_65904a4f","updated":"2014-11-27 16:50:56.000000000","message":"It is a possible capability, if someone creates it :) currently no spec _explicitly_ calls for creating it, so it may be worth mentioning here.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d5b922e85ebc946ee0a7a627ee331f8d93216b5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"May be enabled by this spec - https://review.openstack.org/#/c/128927"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_5acc0d62","line":155,"updated":"2014-11-27 15:25:11.000000000","message":"see above","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9919c2b3e5b5ebf4f95922f5d3aa5617394273cb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"May be enabled by this spec - https://review.openstack.org/#/c/128927"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_3a357cdb","line":155,"in_reply_to":"5a890539_4087bcb6","updated":"2014-11-27 19:10:22.000000000","message":"Yeah, sorry about this. I\u0027ll remove it. Not sure what I was thinking.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"20e06093553b303b026bf3a103c3554f25f07480","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"May be enabled by this spec - https://review.openstack.org/#/c/128927"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_c5101eae","line":155,"in_reply_to":"5a890539_5acc0d62","updated":"2014-11-27 16:06:41.000000000","message":"i\u0027ve replied above.","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ce6fb8b23c4f93a38474a205d0504cf74514770","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Upgrades and Backwards Compatibility"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"May be enabled by this spec - https://review.openstack.org/#/c/128927"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"5a890539_4087bcb6","line":155,"in_reply_to":"5a890539_c5101eae","updated":"2014-11-27 16:50:56.000000000","message":"could you elaborate on relationship between upgrades and capabilities?","commit_id":"367c33da2f4cabc560e481c2cfdde74264ac2b5c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7e60a2c79f93f664d1519d4ab91e5d518d81f3cc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the Ironic PXE deploy driver and the iLO deploy driver"},{"line_number":19,"context_line":"deploys only partition images making an Image kernel/ramdisk to be mandatory."},{"line_number":20,"context_line":"The current approach makes it impossible to deploy Images that are not capable"},{"line_number":21,"context_line":"of providing a corresponding kernel/ramdisk. A significantly important use-case"},{"line_number":22,"context_line":"would be to deploy Windows Images on baremetal systems."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_9a2d4792","line":19,"updated":"2015-01-14 03:41:41.000000000","message":"nit s/Image/image/","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7e60a2c79f93f664d1519d4ab91e5d518d81f3cc","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the Ironic PXE deploy driver and the iLO deploy driver"},{"line_number":19,"context_line":"deploys only partition images making an Image kernel/ramdisk to be mandatory."},{"line_number":20,"context_line":"The current approach makes it impossible to deploy Images that are not capable"},{"line_number":21,"context_line":"of providing a corresponding kernel/ramdisk. A significantly important use-case"},{"line_number":22,"context_line":"would be to deploy Windows Images on baremetal systems."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_da4eef6d","line":20,"updated":"2015-01-14 03:41:41.000000000","message":"same","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9327c6676cf68b3ef56555c7cd2ab1f3ed68138b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, the Ironic PXE deploy driver and the iLO deploy driver"},{"line_number":19,"context_line":"deploys only partition images making an Image kernel/ramdisk to be mandatory."},{"line_number":20,"context_line":"The current approach makes it impossible to deploy Images that are not capable"},{"line_number":21,"context_line":"of providing a corresponding kernel/ramdisk. A significantly important use-case"},{"line_number":22,"context_line":"would be to deploy Windows Images on baremetal systems."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a930d6b_9f55e8fb","line":20,"in_reply_to":"3a961159_da4eef6d","updated":"2015-01-26 21:09:25.000000000","message":"Thanks but the spec got merged.","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d2f2e7e4eed200f38e43bc49a952dec35912e6a8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":"To help the scheduler fail fast, a new filter will be added to the scheduler"},{"line_number":35,"context_line":"which will compare the image structure with the flavor attributes to check if"},{"line_number":36,"context_line":"it can proceed with scheduling."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_0cd6be4f","line":34,"updated":"2015-01-14 02:52:57.000000000","message":"This requires a change in Nova. Have these filters been added already, or proposed to Nova? \n\nReferences to a patch would be helpful, even if the code hasn\u0027t merged yet.","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3377bdded60b8ddb4429a8d73fa442baea8eb5a3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":"To help the scheduler fail fast, a new filter will be added to the scheduler"},{"line_number":35,"context_line":"which will compare the image structure with the flavor attributes to check if"},{"line_number":36,"context_line":"it can proceed with scheduling."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"da86d52c_90931a5a","line":34,"in_reply_to":"1a930d6b_ea2cf44c","updated":"2015-02-05 11:47:40.000000000","message":"https://review.openstack.org/#/c/153196/","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9327c6676cf68b3ef56555c7cd2ab1f3ed68138b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during the validation phase in Ironic."},{"line_number":34,"context_line":"To help the scheduler fail fast, a new filter will be added to the scheduler"},{"line_number":35,"context_line":"which will compare the image structure with the flavor attributes to check if"},{"line_number":36,"context_line":"it can proceed with scheduling."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a930d6b_ea2cf44c","line":34,"in_reply_to":"3a961159_0cd6be4f","updated":"2015-01-26 21:09:25.000000000","message":"Sure, I\u0027ll propose a patch to Nova and link it in the comments section for reference.","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d2f2e7e4eed200f38e43bc49a952dec35912e6a8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"which will compare the image structure with the flavor attributes to check if"},{"line_number":36,"context_line":"it can proceed with scheduling."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"For the PXE Deploy driver, once the image structure is inferred and is found"},{"line_number":39,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"},{"line_number":40,"context_line":"node is restarted with a pxe config file that instructs the server to"},{"line_number":41,"context_line":"boot from the local disk(PXE-localboot)."}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a961159_5a33dff6","line":38,"updated":"2015-01-14 02:52:57.000000000","message":"if image structure is found to be partition-based, I assume that it will follow the current code paths and deploy that. It\u0027s worth stating that here, though.","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"9327c6676cf68b3ef56555c7cd2ab1f3ed68138b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"which will compare the image structure with the flavor attributes to check if"},{"line_number":36,"context_line":"it can proceed with scheduling."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"For the PXE Deploy driver, once the image structure is inferred and is found"},{"line_number":39,"context_line":"out to be a whole disk image, the image is dumped onto the disk-lun and the"},{"line_number":40,"context_line":"node is restarted with a pxe config file that instructs the server to"},{"line_number":41,"context_line":"boot from the local disk(PXE-localboot)."}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a930d6b_3f187474","line":38,"in_reply_to":"3a961159_5a33dff6","updated":"2015-01-26 21:09:25.000000000","message":"Sure, I\u0027ve explicitly stated that in the commit message of the code if that helps.","commit_id":"e72c8af9953956a7258e6d64a30b4b5d4f2b3706"}],"specs/kilo/whole-disk-image.rst":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"16cb7a438caa6d1e9ee588a72df376e2324f544d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Glance\u0027s properties."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during validation."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Whole disk images need to be booted locally from disk and cannot be booted"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_5c3e6429","line":32,"updated":"2014-11-13 23:03:43.000000000","message":"it may be my jet lag but I am unsure what a \"root-only\" flavor is in this case. Would that be a nova flavor with only root_gb set?","commit_id":"3c75d1806749961cf83ba51cfe2f4fba8dea3f72"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b97ec9b90b970485811f0325f324ab47632a7d9f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Glance\u0027s properties."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"To utilise the scheduler efficiently, Ironic deployments of whole disk images"},{"line_number":32,"context_line":"will only accept a root-only flavor to efficiently utilise the entire disk."},{"line_number":33,"context_line":"Any other flavor type would be rejected during validation."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Whole disk images need to be booted locally from disk and cannot be booted"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_31253a5c","line":32,"in_reply_to":"5a890539_5c3e6429","updated":"2014-11-14 06:07:46.000000000","message":"Yup, that\u0027s right.","commit_id":"3c75d1806749961cf83ba51cfe2f4fba8dea3f72"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"16cb7a438caa6d1e9ee588a72df376e2324f544d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Documentation Impact"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"None"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"References"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_29ba386e","line":159,"updated":"2014-11-13 23:03:43.000000000","message":"I think the docs would need to be updated to point out the differences between setting up a node for partition deployment vs whole-disk deployment.","commit_id":"3c75d1806749961cf83ba51cfe2f4fba8dea3f72"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b97ec9b90b970485811f0325f324ab47632a7d9f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Documentation Impact"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"None"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"References"},{"line_number":162,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a890539_911fce07","line":159,"in_reply_to":"5a890539_29ba386e","updated":"2014-11-14 06:07:46.000000000","message":"Cool, I\u0027ll add that now","commit_id":"3c75d1806749961cf83ba51cfe2f4fba8dea3f72"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"86ecc07ee98cff4c7371bb8260f8012304eab809","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Whole Disk Image Support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/windows-disk-image-support"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to add a feature of deploying whole disk images to Ironic."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5a890539_98f39d9e","line":11,"updated":"2014-11-20 23:39:27.000000000","message":"the blueprint name must match the spec file name, which it does not.\n\nSince this has expanded to \"whole disk\", not just \"windows disk\", I would encourage you to rename the blueprint, or abandon the current one (so it\u0027s preserved for historical reasons) and create a new one.","commit_id":"badb609a1e4e13381c41b858cb0f6d6889aec2d8"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"0b39a1a5419b7d5b51b9b4c88ca5c3b65b678fc9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Whole Disk Image Support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/windows-disk-image-support"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to add a feature of deploying whole disk images to Ironic."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5a890539_c6d61ff1","line":11,"in_reply_to":"5a890539_98f39d9e","updated":"2014-11-21 06:32:05.000000000","message":"Done. Renaming sounds like the better option considering people won\u0027t have to subscribe to another blueprint.","commit_id":"badb609a1e4e13381c41b858cb0f6d6889aec2d8"}],"specs/whole-disk-image-support.rst":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"On making a decision on whether to deploy a Disk Image or a Partition Image,"},{"line_number":35,"context_line":"we expect a Glance property \u0027deploy_disk\u0027 to be set by the user to either True"},{"line_number":36,"context_line":"or False defaulting to False."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_46e11afd","line":34,"updated":"2014-06-03 23:10:23.000000000","message":"The grammatical order may be difficult for some people to understand.:\n\n  ( decision, prior expectation, default of expectation. action )\n\nThis structure is easier to read:\n\n  ( prior expectation, decision, action, default of expectation )\n\nThus, I would suggest the following:\n\n  An optional \u0027deploy_disk\u0027 property will be added on Glance images,\n  which will be used by Ironic\u0027s PXE driver to determine whether it\n  should deploy a whole disk or a partition image. If not present,\n  Ironic will default to deploying the image as though it is a partition image,\n  to maintain consistency with current behavior.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"On making a decision on whether to deploy a Disk Image or a Partition Image,"},{"line_number":35,"context_line":"we expect a Glance property \u0027deploy_disk\u0027 to be set by the user to either True"},{"line_number":36,"context_line":"or False defaulting to False."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b0ef67e8","line":34,"in_reply_to":"1ae5cdf2_46e11afd","updated":"2014-06-04 06:06:32.000000000","message":"Sounds good, done.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":48,"context_line":"call needs to be made to change the boot order for whole disk images."},{"line_number":49,"context_line":"Furthermore, Neutron needs to be told to disable PXE Opts and only enable DHCP"},{"line_number":50,"context_line":"but not PXE. These changes will be reset upon the next deployment of any"},{"line_number":51,"context_line":"image. This bit of change partially conflicts with this spec"},{"line_number":52,"context_line":"bp/better-bootloader-options.rst - https://review.openstack.org/#/c/94925/"},{"line_number":53,"context_line":"in that the aforementioned spec consists of a feature that allows the user to"},{"line_number":54,"context_line":"configure the boot order. This feature intends to set a certain boot order"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6641b6a8","line":51,"updated":"2014-06-03 23:10:23.000000000","message":"The comment regarding potential conflict should be moved to the end of the spec, not within the proposed change.\n\nUnless you plan to build these changes upon that specification.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":48,"context_line":"call needs to be made to change the boot order for whole disk images."},{"line_number":49,"context_line":"Furthermore, Neutron needs to be told to disable PXE Opts and only enable DHCP"},{"line_number":50,"context_line":"but not PXE. These changes will be reset upon the next deployment of any"},{"line_number":51,"context_line":"image. This bit of change partially conflicts with this spec"},{"line_number":52,"context_line":"bp/better-bootloader-options.rst - https://review.openstack.org/#/c/94925/"},{"line_number":53,"context_line":"in that the aforementioned spec consists of a feature that allows the user to"},{"line_number":54,"context_line":"configure the boot order. This feature intends to set a certain boot order"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_f0bc8fde","line":51,"in_reply_to":"1ae5cdf2_6641b6a8","updated":"2014-06-04 06:06:32.000000000","message":"Cool, will move it there.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Alternatives"},{"line_number":59,"context_line":"------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Implicitly check for Glance Image properties and figure out if it is a"},{"line_number":62,"context_line":"disk image or partition image based on the presence of kernel/ramdisk."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Separate PXE Config Template for booting disk images from a local disk."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_f1ce5e2d","line":61,"updated":"2014-06-03 23:10:23.000000000","message":"I think this is a reasonably good option. Please include a discussion as to why this was not chosen, including citations to mailing list or IRC logs, if it was discussed previously (which I think it was).\n\nThanks!","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Alternatives"},{"line_number":59,"context_line":"------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Implicitly check for Glance Image properties and figure out if it is a"},{"line_number":62,"context_line":"disk image or partition image based on the presence of kernel/ramdisk."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Separate PXE Config Template for booting disk images from a local disk."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_10c2db58","line":61,"in_reply_to":"1ae5cdf2_f1ce5e2d","updated":"2014-06-04 06:06:32.000000000","message":"Done","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Security impact"},{"line_number":92,"context_line":"---------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"None"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Other end user impact"},{"line_number":97,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ec2da596","line":94,"updated":"2014-06-03 23:10:23.000000000","message":"Allowing nodes to boot from local disk has a security impact.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Security impact"},{"line_number":92,"context_line":"---------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"None"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Other end user impact"},{"line_number":97,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_30b3570b","line":94,"in_reply_to":"1ae5cdf2_ec2da596","updated":"2014-06-04 06:06:32.000000000","message":"Done, will add that.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":121,"context_line":"----------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"This change only works for the PXE Deploy Driver. Other Deploy drivers must"},{"line_number":124,"context_line":"take this change into consideration if they are consuming instance_info."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2c130d0e","line":124,"updated":"2014-06-03 23:10:23.000000000","message":"While the PXE driver is the only deploy driver present today, this must be implemented in such a way that future deploy drivers (eg, IPA) can consume the same information from node.instance_info and deploy the appropriate type of image.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":121,"context_line":"----------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"This change only works for the PXE Deploy Driver. Other Deploy drivers must"},{"line_number":124,"context_line":"take this change into consideration if they are consuming instance_info."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_abc29a31","line":124,"in_reply_to":"1ae5cdf2_2c130d0e","updated":"2014-06-04 06:06:32.000000000","message":"Done.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Currently, the Libvirt Virtual Machines that are used in Ironic\u0027s Integration"},{"line_number":159,"context_line":"tests have booting from local disk disabled. So to test this feature in the"},{"line_number":160,"context_line":"gate via Tempest, DevStack needs to configure and enable the libvirt virtual"},{"line_number":161,"context_line":"machine to boot from Hard Disk also apart from PXE."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ccdf090c","line":160,"updated":"2014-06-03 23:10:23.000000000","message":"This is incorrect. If devstack configures the virtual machine to boot from HDD, it will not be provisionable by the PXE driver. Either it won\u0027t PXE boot at all (if it only boots from HDD) or it won\u0027t be deletable (if it boots from HDD first, since any reboot won\u0027t cause a PXE boot).\n\nTo test this upstream, we will need a change to the SSH driver that allows changing the libvirt config for a virtual machine to programatically determine whether it boots from network (PXE) or local disk (HDD). This is the intent of the related better-boot-options specification.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Currently, the Libvirt Virtual Machines that are used in Ironic\u0027s Integration"},{"line_number":159,"context_line":"tests have booting from local disk disabled. So to test this feature in the"},{"line_number":160,"context_line":"gate via Tempest, DevStack needs to configure and enable the libvirt virtual"},{"line_number":161,"context_line":"machine to boot from Hard Disk also apart from PXE."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_306c3708","line":160,"in_reply_to":"1ae5cdf2_ccdf090c","updated":"2014-06-04 06:06:32.000000000","message":"Perhaps, what I wrote wasn\u0027t too clear.\n\nCurrently, booting from HDD is disabled entirely in the boot order. Even if PXE fails, the VM does not attempt to boot from HDD. \n\nSo what I was trying to say was to also enable HDD in the boot order after PXE, but only as a temporary workaround until the SSH driver is implemented with the changes that allows us to change the boot order.\n\nSo, adding HDD to the boot order should still allow us to deploy the disk image via PXE and boot from HDD after(failing PXE-boot).","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"5ef4fc6da867b662aa2cd2efe426a323511ca103","unresolved":false,"context_lines":[{"line_number":159,"context_line":"tests have booting from local disk disabled. So to test this feature in the"},{"line_number":160,"context_line":"gate via Tempest, DevStack needs to configure and enable the libvirt virtual"},{"line_number":161,"context_line":"machine to boot from Hard Disk also apart from PXE."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ec8f6528","line":162,"updated":"2014-06-03 23:10:23.000000000","message":"Also, diskimage-builder needs to create whole-disk images, rather than partition images.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81013744e36fe4bf01fca55511b49cca10e5a4af","unresolved":false,"context_lines":[{"line_number":159,"context_line":"tests have booting from local disk disabled. So to test this feature in the"},{"line_number":160,"context_line":"gate via Tempest, DevStack needs to configure and enable the libvirt virtual"},{"line_number":161,"context_line":"machine to boot from Hard Disk also apart from PXE."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_10e57bdc","line":162,"in_reply_to":"1ae5cdf2_ec8f6528","updated":"2014-06-04 06:06:32.000000000","message":"Done.","commit_id":"a349c43a9243e6e9ff382aec868dccf6c86d3acf"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"af25581bb49f5c4d59aae622ed4b464b3d2de6c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"call needs to be made to change the boot order for whole disk images."},{"line_number":51,"context_line":"Furthermore, Neutron needs to be told to disable PXE Opts and only enable DHCP"},{"line_number":52,"context_line":"but not PXE. These changes will be reset upon the next deployment of any"},{"line_number":53,"context_line":"image."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_95d30a5f","line":53,"updated":"2014-06-05 09:54:54.000000000","message":"Adding a little more detail to this section in a bit.","commit_id":"23e0811f4c513b5a20f62ff498614ec2666c7123"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"c8d03bfadb79847d0353a5ccea737b5a4b18f125","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_10e451aa","line":33,"updated":"2014-06-05 21:16:48.000000000","message":"Good design!\nI am sorry that I just need to get more understanding. Is it still 2 step process?\n1. initrd loads the whole-image and dd it to the disk.  And issue a boot command\n2. the node reboot into the whole-disk image.\n\nIf it is true, then we still need images for the deploy kernel and ramdisk in step 1, correct?","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e16282af5a6c60f7ce6423e860a57375cb4b624a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_796d79cb","line":33,"in_reply_to":"1ae5cdf2_10e451aa","updated":"2014-06-06 05:49:19.000000000","message":"Hi, Thanks for asking :-) \n\nYes, it is still a 2 step process. \n\nStep 1:- You\u0027re right that the initrd loads the whole disk image and dd\u0027s it onto the disk, notifies the conductor and reboots the node.\n\nSo Yes, we still do require deploy kernel and deploy ramdisk in step 1.\n\nI hope I answered your question? I think I should\u0027ve been more explicit about that here :-)  Thanks.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ee195d23","line":33,"in_reply_to":"1ae5cdf2_49f8a2e5","updated":"2014-06-10 07:02:30.000000000","message":"The deploy process is almost entirely the same. It still does follow the existing PXE deploy process using the deploy kernel/ramdisk. The core change will be how the images are written to the disk. Whole Disk Images are simply written directly to the lun of the disk without creating any partitions and copying an image to the root partition.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"678796a4c006cf40460b0609c8aa31bdd6ad8b41","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_49f8a2e5","line":33,"in_reply_to":"1ae5cdf2_796d79cb","updated":"2014-06-09 18:06:04.000000000","message":"Thanks for the response. Can deploy kernel and ramdisk be different os than the whole-disk image?  For example, can windows whole-disk image use the Linux kernel and ramdisk?","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":37,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_e55420cc","line":34,"updated":"2014-06-10 04:46:59.000000000","message":"If this option is specific to Ironic\u0027s virt driver, perhaps it should be called \u0027ironic_deploy_disk\u0027?","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":37,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_48d6c928","line":34,"in_reply_to":"1ae5cdf2_e55420cc","updated":"2014-06-10 07:02:30.000000000","message":"Good idea, since Ironic is the only project which will consume the variable.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"for the deploy_disk variable to validate various paramaters related to disk"},{"line_number":51,"context_line":"or partition images. In the case of whole disk images, Ironic checks for the"},{"line_number":52,"context_line":"deploy_disk key in its instance_info dict to decide on if it needs to deploy"},{"line_number":53,"context_line":"a disk image. If either one of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 is set, it does not validate"},{"line_number":54,"context_line":"any parameters related to partition images such as root_gb, swap_mb, ephemeral_gb,"},{"line_number":55,"context_line":"etc and goes on to continue to deploy a whole disk image. For any other value set,"},{"line_number":56,"context_line":"a partition image is deployed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_650f30e2","line":53,"updated":"2014-06-10 04:46:59.000000000","message":"The instance_info field is JSON and gets converted to a Python dictionary by the time it is accessed - I think we should stick to booleans and only look for True.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"for the deploy_disk variable to validate various paramaters related to disk"},{"line_number":51,"context_line":"or partition images. In the case of whole disk images, Ironic checks for the"},{"line_number":52,"context_line":"deploy_disk key in its instance_info dict to decide on if it needs to deploy"},{"line_number":53,"context_line":"a disk image. If either one of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 is set, it does not validate"},{"line_number":54,"context_line":"any parameters related to partition images such as root_gb, swap_mb, ephemeral_gb,"},{"line_number":55,"context_line":"etc and goes on to continue to deploy a whole disk image. For any other value set,"},{"line_number":56,"context_line":"a partition image is deployed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ab01073b","line":53,"in_reply_to":"1ae5cdf2_650f30e2","updated":"2014-06-10 07:02:30.000000000","message":"There\u0027s a strutils.bool_from_string() method from oslo.strutils() that should take care of converting any of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 to True or \u0027False\u0027, \u0027false\u0027,0 to False.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"deploy_disk key in its instance_info dict to decide on if it needs to deploy"},{"line_number":53,"context_line":"a disk image. If either one of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 is set, it does not validate"},{"line_number":54,"context_line":"any parameters related to partition images such as root_gb, swap_mb, ephemeral_gb,"},{"line_number":55,"context_line":"etc and goes on to continue to deploy a whole disk image. For any other value set,"},{"line_number":56,"context_line":"a partition image is deployed."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_05fe6cae","line":55,"updated":"2014-06-10 04:46:59.000000000","message":"Same thing, look for False or that the \u0027deploy_disk\u0027 key does not exist.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"deploy_disk key in its instance_info dict to decide on if it needs to deploy"},{"line_number":53,"context_line":"a disk image. If either one of \u0027True\u0027,\u0027true\u0027,\u00271\u0027 is set, it does not validate"},{"line_number":54,"context_line":"any parameters related to partition images such as root_gb, swap_mb, ephemeral_gb,"},{"line_number":55,"context_line":"etc and goes on to continue to deploy a whole disk image. For any other value set,"},{"line_number":56,"context_line":"a partition image is deployed."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_8ba28b49","line":55,"in_reply_to":"1ae5cdf2_05fe6cae","updated":"2014-06-10 07:02:30.000000000","message":"Ditto.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"},{"line_number":59,"context_line":"to only support deploying of the disk image via the deploy images. This is"},{"line_number":60,"context_line":"because Whole disk images need to be booted locally from disk, and hence a Power"},{"line_number":61,"context_line":"Manager call will be made to change the boot order for whole disk images and Neutron"},{"line_number":62,"context_line":"will be told to disable PXE Opts and only enable DHCP but not PXE. These changes"},{"line_number":63,"context_line":"will be reset upon the next deployment of any image."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_65fe506d","line":60,"updated":"2014-06-10 04:46:59.000000000","message":"It might not be true that whole disk images need to booted locally - they might not include a kernel/ramdisk, and that would be booted via PXE and pointed at the root partition, as is done today.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Only in the case of deploying whole disk images ,the PXE Config file is trimmed"},{"line_number":59,"context_line":"to only support deploying of the disk image via the deploy images. This is"},{"line_number":60,"context_line":"because Whole disk images need to be booted locally from disk, and hence a Power"},{"line_number":61,"context_line":"Manager call will be made to change the boot order for whole disk images and Neutron"},{"line_number":62,"context_line":"will be told to disable PXE Opts and only enable DHCP but not PXE. These changes"},{"line_number":63,"context_line":"will be reset upon the next deployment of any image."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_0b2f5b89","line":60,"in_reply_to":"1ae5cdf2_65fe506d","updated":"2014-06-10 07:02:30.000000000","message":"So, this could just be deployed via the current pxe deployment process that is done today with perhaps, a pxe configuration change.\n\nThe idea here is to not deploy a disk image to a partition but to deploy to the disk directly.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"c8d03bfadb79847d0353a5ccea737b5a4b18f125","unresolved":false,"context_lines":[{"line_number":59,"context_line":"to only support deploying of the disk image via the deploy images. This is"},{"line_number":60,"context_line":"because Whole disk images need to be booted locally from disk, and hence a Power"},{"line_number":61,"context_line":"Manager call will be made to change the boot order for whole disk images and Neutron"},{"line_number":62,"context_line":"will be told to disable PXE Opts and only enable DHCP but not PXE. These changes"},{"line_number":63,"context_line":"will be reset upon the next deployment of any image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The whole disk image finally will be deployed via iSCSI and to the lun directly."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_b0b2bde2","line":62,"updated":"2014-06-05 21:16:48.000000000","message":"Can you explain more about \"Neutron disable PXE Opts\"? I thought Neutron does not handle PXE.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e16282af5a6c60f7ce6423e860a57375cb4b624a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"to only support deploying of the disk image via the deploy images. This is"},{"line_number":60,"context_line":"because Whole disk images need to be booted locally from disk, and hence a Power"},{"line_number":61,"context_line":"Manager call will be made to change the boot order for whole disk images and Neutron"},{"line_number":62,"context_line":"will be told to disable PXE Opts and only enable DHCP but not PXE. These changes"},{"line_number":63,"context_line":"will be reset upon the next deployment of any image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The whole disk image finally will be deployed via iSCSI and to the lun directly."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_b9746168","line":62,"in_reply_to":"1ae5cdf2_b0b2bde2","updated":"2014-06-06 05:49:19.000000000","message":"It partially does in that it sets the relevant PXE options for DHCP.\n\n- http://docs.openstack.org/api/openstack-network/2.0/content/extra-dhcp-opt-ext.html\n- https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L443-L474","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"},{"line_number":79,"context_line":"it has been decided to keep this decision explicit."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Separate PXE Config Template for booting disk images from a local disk."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2588c821","line":81,"updated":"2014-06-10 04:46:59.000000000","message":"This probably belongs in spec/better-bootloader-options. This spec shouldn\u0027t be interested in the mechanism for booting from local disk, as long as it can happen.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"all and then poking inside the console to figuring out what went wrong. Thus,"},{"line_number":79,"context_line":"it has been decided to keep this decision explicit."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Separate PXE Config Template for booting disk images from a local disk."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Data model impact"},{"line_number":84,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_6b6e1fcb","line":81,"in_reply_to":"1ae5cdf2_2588c821","updated":"2014-06-10 07:02:30.000000000","message":"Agreed.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"-----------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Apart from the instance_info dict being modified with an added key-value pair,"},{"line_number":100,"context_line":"no changes are made to the Core Driver API."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Nova driver impact"},{"line_number":103,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_c576443f","line":100,"updated":"2014-06-10 04:46:59.000000000","message":"I don\u0027t think this is related to the driver API, can probably leave this out.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"-----------------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Apart from the instance_info dict being modified with an added key-value pair,"},{"line_number":100,"context_line":"no changes are made to the Core Driver API."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Nova driver impact"},{"line_number":103,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_a8a2ed97","line":100,"in_reply_to":"1ae5cdf2_c576443f","updated":"2014-06-10 07:02:30.000000000","message":"Done","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"PXE-boot and this may be used to potentially attack other nodes in the network"},{"line_number":115,"context_line":"or possibly go unbilled but still crunching through resources."},{"line_number":116,"context_line":"A best-effort solution to this issue would be to maintain a periodic task in"},{"line_number":117,"context_line":"the conductor syncing the power states of the nodes to that in the database."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Other end user impact"},{"line_number":120,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_05710c44","line":117,"updated":"2014-06-10 04:46:59.000000000","message":"This also probably belongs in spec/better-bootloader-options; this spec is not adding local boot capabilities, just utilizing them.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"PXE-boot and this may be used to potentially attack other nodes in the network"},{"line_number":115,"context_line":"or possibly go unbilled but still crunching through resources."},{"line_number":116,"context_line":"A best-effort solution to this issue would be to maintain a periodic task in"},{"line_number":117,"context_line":"the conductor syncing the power states of the nodes to that in the database."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Other end user impact"},{"line_number":120,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_6b837fcc","line":117,"in_reply_to":"1ae5cdf2_05710c44","updated":"2014-06-10 07:02:30.000000000","message":"Since this spec talks about a feature that will only work when it is booted locally, it felt like this should be mentioned here but I guess this could be moved there. Thanks.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"There is no implicit mechanism to detect disk images from partition images"},{"line_number":138,"context_line":"being implemented in this change. Deployers will have to explicitly set"},{"line_number":139,"context_line":"Boolean value \u0027deploy_disk\u0027 in either Glance\u0027s image properties or if they"},{"line_number":140,"context_line":"are supposedly consuming Ironic as a service directly,they must patch"},{"line_number":141,"context_line":"\u0027deploy_disk\u0027 into Ironic\u0027s instance_info dict via REST API."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_a5a21898","line":140,"updated":"2014-06-10 04:46:59.000000000","message":"nit: add a space after the comma.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"There is no implicit mechanism to detect disk images from partition images"},{"line_number":138,"context_line":"being implemented in this change. Deployers will have to explicitly set"},{"line_number":139,"context_line":"Boolean value \u0027deploy_disk\u0027 in either Glance\u0027s image properties or if they"},{"line_number":140,"context_line":"are supposedly consuming Ironic as a service directly,they must patch"},{"line_number":141,"context_line":"\u0027deploy_disk\u0027 into Ironic\u0027s instance_info dict via REST API."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_eb8f8f73","line":140,"in_reply_to":"1ae5cdf2_a5a21898","updated":"2014-06-10 07:02:30.000000000","message":"Done","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"- https://blueprints.launchpad.net/ironic/+spec/add-node-instance-info"},{"line_number":173,"context_line":"- https://review.openstack.org/#/c/95701/"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Partially Related To spec/better-bootloader-options.rst"},{"line_number":176,"context_line":"- https://review.openstack.org/#/c/94925/"},{"line_number":177,"context_line":"- The aforementioned spec consists of a feature that allows the user to"},{"line_number":178,"context_line":"configure the boot order. The current spec proposed consists of a change that"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_25ba88e1","line":175,"updated":"2014-06-10 04:46:59.000000000","message":"I think this spec fully depends on better-bootloader-options. Without the ability to boot from local disk, this spec will not work.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"- https://blueprints.launchpad.net/ironic/+spec/add-node-instance-info"},{"line_number":173,"context_line":"- https://review.openstack.org/#/c/95701/"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Partially Related To spec/better-bootloader-options.rst"},{"line_number":176,"context_line":"- https://review.openstack.org/#/c/94925/"},{"line_number":177,"context_line":"- The aforementioned spec consists of a feature that allows the user to"},{"line_number":178,"context_line":"configure the boot order. The current spec proposed consists of a change that"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_2bddf714","line":175,"in_reply_to":"1ae5cdf2_25ba88e1","updated":"2014-06-10 07:02:30.000000000","message":"As I understand it, the better-bootloader-options spec adds an API call to the power manager for the operators to set the boot device but the ability to choose the boot device itself exists today via a Power Manager call which is what this spec wants. So we aren\u0027t depending on the API Call to be implemented, but since there might be a possible conflict, this was marked as partially related to the \u0027setting the boot device\u0027 feature of that spec.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b24114cd923e40520048be2d2f3b134b46b09f3c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"virtual machine to add booting from Hard Disk to the boot order. This is done"},{"line_number":191,"context_line":"so that the Image is deployed via PXE and then with PXE DHCP disabled via"},{"line_number":192,"context_line":"Neutron, the node will fail PXE Boot and proceed down the boot order to boot"},{"line_number":193,"context_line":"from HDD and then the whole-disk-image should boot."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"This change will only be a temporary workaround until the SSH Driver is"},{"line_number":196,"context_line":"implemented with the necessary changes that will allow changing the boot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_e5ac208f","line":193,"updated":"2014-06-10 04:46:59.000000000","message":"Again, this probably belongs in spec/better-bootloader-options, as this is part of testing booting from local disk, not full disk images.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"b1791135116d96f8b2a40df40025015f62e8a76a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"virtual machine to add booting from Hard Disk to the boot order. This is done"},{"line_number":191,"context_line":"so that the Image is deployed via PXE and then with PXE DHCP disabled via"},{"line_number":192,"context_line":"Neutron, the node will fail PXE Boot and proceed down the boot order to boot"},{"line_number":193,"context_line":"from HDD and then the whole-disk-image should boot."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"This change will only be a temporary workaround until the SSH Driver is"},{"line_number":196,"context_line":"implemented with the necessary changes that will allow changing the boot"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_8b70cbdd","line":193,"in_reply_to":"1ae5cdf2_e5ac208f","updated":"2014-06-10 07:02:30.000000000","message":"This is only a workaround to the current limitations of the SSH Driver. Shouldn\u0027t be relevant when the SSHDriver is implemented with the necessary changes. So this is only a mention to what is required to fully test this feature. I think I\u0027ll add the related features to better-bootloaders-options with a tag to not confuse that that feature will actually be implemented here.","commit_id":"fe4ba7923c4094ac752964f22febdfc58e51a1a0"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"a060946bb7dddc16cf3f2c73c8bdb69e5758a94e","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Whole Disk Image Support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/windows-disk-image-support"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_3538cdd3","line":8,"updated":"2014-06-25 18:38:35.000000000","message":"Could the title be updated to reflect that this support is only for PXE Deploy driver?","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"159d8137be1b5a872ede8014ce017c8597d75b68","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Whole Disk Image Support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/windows-disk-image-support"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_224cdf75","line":8,"in_reply_to":"1ae5cdf2_087e586a","updated":"2014-06-26 22:48:52.000000000","message":"Please do update this to indicate PXE driver. Agent driver currently /only/ supports whole disk images.","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81f3328d594a170e6ddd6c21e19004aeeb4e0632","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Whole Disk Image Support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/windows-disk-image-support"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_75b5bace","line":8,"in_reply_to":"1ae5cdf2_224cdf75","updated":"2014-06-27 09:06:04.000000000","message":"Done","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e0f6ad69a6b827d03726fcc57715efc2f1186320","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Whole Disk Image Support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ironic/+spec/windows-disk-image-support"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_087e586a","line":8,"in_reply_to":"1ae5cdf2_3538cdd3","updated":"2014-06-25 19:42:45.000000000","message":"Hmmm, I agree to a certain extent that this change should be made. Although there will be changes made on a global level that will enable other Deploy Drivers make use of a part of this. So perhaps, It should be fine leaving it like this.","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":12060,"name":"Jonathan Provost","email":"jprovost.sh@gmail.com","username":"jprovost"},"change_message_id":"cdbb0df5a56695f456419bda5fcaf2192b16e8ea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":37,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_92442e74","line":34,"updated":"2014-06-26 16:29:26.000000000","message":"I believe that the \u0027ironic_deploy_disk\u0027 propterty may always be derived form \u0027disk_format\u0027 property already present in Glance.  I propose that the following formats are considered as disk images: (\u0027raw\u0027, \u0027vhd\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027) and that only \u0027ami\u0027 is considered as a partition image that is always associated to \u0027ari\u0027 and \u0027aki\u0027 images.\n\nThis would avoid specifying a new parameter in Glance only for ironic and also prevent adding a parameter to ironic.  A validation in ironic regarding the image format is already present and could simply be adapted.","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"159d8137be1b5a872ede8014ce017c8597d75b68","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":37,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_e22e778c","line":34,"in_reply_to":"1ae5cdf2_92442e74","updated":"2014-06-26 22:48:52.000000000","message":"-1 To this comment.\n\nI have absolutely seen cases where a full disk image exists in the same format as \u0027partition\u0027 images and vice-versa. If this is a setting in glance, it\u0027d need to be one set per image and not derived based on extension.","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"be80cb1d7caa3be9a8aed6683a7dcdb9cd5a1ef9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":37,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_78078170","line":34,"in_reply_to":"1ae5cdf2_92442e74","updated":"2014-06-26 17:15:49.000000000","message":"Can\u0027t those formats(qcow2, raw, etc) also have a kernel/ramdisk associated with them? Assuming those images will simply just be disk images and not partition images seems wrong because they needn\u0027t always be disk images. What do you think? I\u0027m not a fan of the extra Glance Property Tag myself but it seems like it is required.","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"81f3328d594a170e6ddd6c21e19004aeeb4e0632","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"An optional \u0027ironic_deploy_disk\u0027 property will be added on Glance images,"},{"line_number":35,"context_line":"which will be used by Ironic\u0027s PXE driver to determine whether it"},{"line_number":36,"context_line":"should deploy a whole disk or a partition image. If not present,"},{"line_number":37,"context_line":"Ironic will default to deploying the image as though it is a partition image,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_7625c0ac","line":34,"in_reply_to":"1ae5cdf2_e22e778c","updated":"2014-06-27 09:06:04.000000000","message":"Agreed for not deriving based on extension.","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"a060946bb7dddc16cf3f2c73c8bdb69e5758a94e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Implicitly check for Glance Image properties and figure out if it is a"},{"line_number":74,"context_line":"disk image or partition image based on the presence of kernel/ramdisk."},{"line_number":75,"context_line":"- As images cannot be safely differentiated apart from whether they are really"},{"line_number":76,"context_line":"whole disk images or partition images without examining the internals of the"},{"line_number":77,"context_line":"image, it may be inappropriate to assume that they are disk/partition images"},{"line_number":78,"context_line":"based on the presence of an associated kernel/ramdisk in Glance. Furthermore,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_b524ddb2","line":75,"updated":"2014-06-25 18:38:35.000000000","message":"Nova code seems to use disk_format property to differentiate ami to raw disk images (https://github.com/openstack/nova/blob/8e4532e967f15b0e49e1bd4c7d66d02881687ffd/nova/tests/image/fake.py#L52). Could something like this be used here?","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"e0f6ad69a6b827d03726fcc57715efc2f1186320","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Implicitly check for Glance Image properties and figure out if it is a"},{"line_number":74,"context_line":"disk image or partition image based on the presence of kernel/ramdisk."},{"line_number":75,"context_line":"- As images cannot be safely differentiated apart from whether they are really"},{"line_number":76,"context_line":"whole disk images or partition images without examining the internals of the"},{"line_number":77,"context_line":"image, it may be inappropriate to assume that they are disk/partition images"},{"line_number":78,"context_line":"based on the presence of an associated kernel/ramdisk in Glance. Furthermore,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_2b94ee8a","line":75,"in_reply_to":"1ae5cdf2_b524ddb2","updated":"2014-06-25 19:42:45.000000000","message":"IIUC, They seem like two different things. The code reference suggests that Nova\u0027s disk_format property will eventually obtain it\u0027s value from the properties of the image.  Eg: QCOW2, AMI, VHD, etc\n\nThe alternative here suggested is a mechanism to the problem of figuring out the type of the image(i.e Partition or Whole-Disk-Image), not the format the specified image is in. \n\nDid that answer your question?","commit_id":"2a4fb7c2b35337e7541fe1bee7f8f495c00808f1"}]}