)]}'
{"specs/ironic-ilo-power-driver.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"* The HP iLO subsystem is a standard component of HP ProLiant servers that"},{"line_number":19,"context_line":"  simplifies initial server setup, server health monitoring, power and thermal"},{"line_number":20,"context_line":"  optimization, and remote server administration.Our proposed ironic IloDriver"},{"line_number":21,"context_line":"  will expose these capabilities in Openstack to manage HP Proliant servers."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ac8aa6bc","line":18,"updated":"2014-06-04 12:46:02.000000000","message":"Formatting: this should not be a list, just a paragraph","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"* The HP iLO subsystem is a standard component of HP ProLiant servers that"},{"line_number":19,"context_line":"  simplifies initial server setup, server health monitoring, power and thermal"},{"line_number":20,"context_line":"  optimization, and remote server administration.Our proposed ironic IloDriver"},{"line_number":21,"context_line":"  will expose these capabilities in Openstack to manage HP Proliant servers."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  This proposal covers support for power management interfaces using iLO."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2cbe9665","line":20,"updated":"2014-06-04 12:46:02.000000000","message":"Nit: space before `Our`, `Ironic` - from capital letter","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"133c808735d74b1a1409897e01a2d378ca9029c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* Initial design will support -"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  * validate() - which validates, if proper parameters are passed to IloDriver,"},{"line_number":31,"context_line":"  * get_power_state() - retrieves the host power status (\u0027ON\u0027 or \u0027OFF\u0027)"},{"line_number":32,"context_line":"  * set power state() - sets the host power to ON or OFF, and"},{"line_number":33,"context_line":"  * reboot() - hard reboots the node."},{"line_number":34,"context_line":"* Additional power control operations will be added later."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_1ecd52b7","line":31,"updated":"2014-06-05 14:26:26.000000000","message":"The actual names for the states are (\u0027power on\u0027 or \u0027power off\u0027)","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  * validate() - which validates, if proper parameters are passed to IloDriver,"},{"line_number":31,"context_line":"  * get_power_state() - retrieves the host power status (\u0027ON\u0027 or \u0027OFF\u0027)"},{"line_number":32,"context_line":"  * set power state() - sets the host power to ON or OFF, and"},{"line_number":33,"context_line":"  * reboot() - hard reboots the node."},{"line_number":34,"context_line":"* Additional power control operations will be added later."},{"line_number":35,"context_line":"* Uses ilo client in proliantUtils library to talk to iLO."},{"line_number":36,"context_line":"* It will conform to Ironic testing requirements."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ccae122e","line":33,"updated":"2014-06-04 12:46:02.000000000","message":"You don\u0027t need to list these, they are parts of required interface","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":7589,"name":"linggao","email":"linggao@us.ibm.com","username":"linggao"},"change_message_id":"133c808735d74b1a1409897e01a2d378ca9029c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  * get_power_state() - retrieves the host power status (\u0027ON\u0027 or \u0027OFF\u0027)"},{"line_number":32,"context_line":"  * set power state() - sets the host power to ON or OFF, and"},{"line_number":33,"context_line":"  * reboot() - hard reboots the node."},{"line_number":34,"context_line":"* Additional power control operations will be added later."},{"line_number":35,"context_line":"* Uses ilo client in proliantUtils library to talk to iLO."},{"line_number":36,"context_line":"* It will conform to Ironic testing requirements."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_9ec24251","line":34,"updated":"2014-06-05 14:26:26.000000000","message":"The current PowerInterface only contains the functions mentioned above. What additional \u0027power\u0027 control operations will be added later? Are you saying that additional interfaces (like ConsoleInterface) will be added later?","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"66d5d9db43958020f02b8602e6e452ea44518a13","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  * get_power_state() - retrieves the host power status (\u0027ON\u0027 or \u0027OFF\u0027)"},{"line_number":32,"context_line":"  * set power state() - sets the host power to ON or OFF, and"},{"line_number":33,"context_line":"  * reboot() - hard reboots the node."},{"line_number":34,"context_line":"* Additional power control operations will be added later."},{"line_number":35,"context_line":"* Uses ilo client in proliantUtils library to talk to iLO."},{"line_number":36,"context_line":"* It will conform to Ironic testing requirements."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_72576726","line":34,"in_reply_to":"1ae5cdf2_9ec24251","updated":"2014-06-10 10:45:18.000000000","message":"No ,not about the additional interfaces. HP iLO provides additional features for power management to view and control the power state of the server, monitor power usage, and modify power settings.We have plans to expose the same ,as required.","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  * reboot() - hard reboots the node."},{"line_number":34,"context_line":"* Additional power control operations will be added later."},{"line_number":35,"context_line":"* Uses ilo client in proliantUtils library to talk to iLO."},{"line_number":36,"context_line":"* It will conform to Ironic testing requirements."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6c397ef1","line":36,"updated":"2014-06-04 12:46:02.000000000","message":"I don\u0027t think this should be listed here, again, it\u0027s a requirement :) See below in testing section.\n\nAlso, I suggest just putting it as a single paragraph, without list.","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Alternatives"},{"line_number":39,"context_line":"------------"},{"line_number":40,"context_line":"* Today , IPMI standard specification can be used for the power management"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Data model impact"},{"line_number":43,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4c1f626c","line":40,"updated":"2014-06-04 12:46:02.000000000","message":"\"Today , \" is not needed here","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* validate()"},{"line_number":97,"context_line":"* get_power_state()"},{"line_number":98,"context_line":"* set_power_state()"},{"line_number":99,"context_line":"* reboot()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Dependencies"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_872305a6","line":99,"updated":"2014-06-04 12:46:02.000000000","message":"again, no need for this list - we know what is in PowerInterface :) Better emphasize that this is a new power module, put it\u0027s proposed name here.","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"51574561a303feba45f678fff4c5901180b6dfa2","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":"* Unit tests will be included"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Documentation Impact"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_875a2528","line":109,"updated":"2014-06-04 12:46:02.000000000","message":"I would like to see covered here: 1. will 3rdparty CI be provided by someone for testing it? 2. if not, please state, that you\u0027re going to include unit tests, mocking proliantUtils library","commit_id":"c454f7945d8c2ecec9ebcb36348522c263c313f5"}],"specs/juno/ironic-ilo-power-driver.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"To add a new IloPower() module which will conform to base.PowerInterface."},{"line_number":28,"context_line":"Additional power control operations will be added later. It uses iLO client in "},{"line_number":29,"context_line":"proliantUtils library to talk to iLO."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_0cd9be56","line":28,"updated":"2014-06-12 21:20:47.000000000","message":"nit: trailing whitespace should be removed.","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Alternatives"},{"line_number":32,"context_line":"------------"},{"line_number":33,"context_line":"IPMI standard specification can be used for the power management."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Data model impact"},{"line_number":36,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_6c7ec21a","line":33,"updated":"2014-06-12 21:20:47.000000000","message":"Why should Ironic use iLO over IPMI?","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6f97279a9e6b080ae40fd8bdd3a846007d212759","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Alternatives"},{"line_number":32,"context_line":"------------"},{"line_number":33,"context_line":"IPMI standard specification can be used for the power management."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Data model impact"},{"line_number":36,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_74faf743","line":33,"in_reply_to":"1ae5cdf2_6c7ec21a","updated":"2014-06-13 16:16:55.000000000","message":"1. HP iLO provides additional features for power management to view and control the power state of the server, monitor power usage, and modify power settings.We have plans to expose the same ,as required.\n\n2. Proposed deploy module in IloDriver has a dependency on this module for deployed instances.For more details,refer :https://review.openstack.org/#/c/97744/\n\n3. We are planning to manage all operations on (power,deploy firmwareupdate,discovery etc) HP Proliant servers under a common framework with iLO.","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Driver API impact"},{"line_number":44,"context_line":"-----------------"},{"line_number":45,"context_line":"No Driver API impact"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Nova driver impact"},{"line_number":48,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_8ca06e91","line":45,"updated":"2014-06-12 21:20:47.000000000","message":"nit: this should just read \"None\"","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Dependencies"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":91,"context_line":"*  This feature is targeted for HP ProLiant servers with iLO4."},{"line_number":92,"context_line":"*  Depends on proliantUtils library ."},{"line_number":93,"context_line":"   (https://github.com/hpproliant/proliantutils)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_0c7ffee0","line":92,"updated":"2014-06-12 21:20:47.000000000","message":"nit: remove the space between \"library\" and the period.","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Testing"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"Unit tests will be added , mocking proliantUtils library."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Documentation Impact"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_ec7bb2f2","line":97,"updated":"2014-06-12 21:20:47.000000000","message":"nit: remove the space between \"added\" and the comma.\n\nAlso, are there plans to do third-party testing for this driver?","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6f97279a9e6b080ae40fd8bdd3a846007d212759","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Testing"},{"line_number":96,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":97,"context_line":"Unit tests will be added , mocking proliantUtils library."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Documentation Impact"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_507a5eba","line":97,"in_reply_to":"1ae5cdf2_ec7bb2f2","updated":"2014-06-13 16:16:55.000000000","message":"As of now, we don\u0027t have plans for third-party testing for this driver","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Documentation Impact"},{"line_number":100,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":101,"context_line":"None"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"References"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_ccd436eb","line":101,"updated":"2014-06-12 21:20:47.000000000","message":"We\u0027ll need some documentation effort to document what driver_info is needed for this, that it is an available driver, etc.","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1904bcaaec3d45747c110984c8ba42f02b4d15bc","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"References"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_2c0bda7d","line":105,"updated":"2014-06-12 21:20:47.000000000","message":"Might be nice to link to the proliantUtils library here.","commit_id":"2407e2529cb6b03c2ace479ebf8988f658d28c07"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"816f972313fd72bb2b94f09dcbb38bf961007043","unresolved":false,"context_lines":[{"line_number":18,"context_line":"The HP iLO subsystem is a standard component of HP ProLiant servers that"},{"line_number":19,"context_line":"simplifies initial server setup, server health monitoring, power and thermal"},{"line_number":20,"context_line":"optimization, and remote server administration. Our proposed Ironic IloDriver"},{"line_number":21,"context_line":"will expose these capabilities in Openstack to manage HP Proliant servers."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This proposal covers support for power management interfaces using iLO."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_e82bda7f","line":21,"updated":"2014-06-18 15:43:49.000000000","message":"s/Openstack/OpenStack/","commit_id":"3308270fe892995f6d3bdbbf35a7a751e2976208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"816f972313fd72bb2b94f09dcbb38bf961007043","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Documentation Impact"},{"line_number":99,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":100,"context_line":"The required driver_info properties need be included in the documentation to"},{"line_number":101,"context_line":"instruct operators how to use iLO Driver with Ironic."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"References"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_68650ae0","line":101,"updated":"2014-06-18 15:43:49.000000000","message":"These properties should be listed in the spec, probably in \"Proposed Changes\"","commit_id":"3308270fe892995f6d3bdbbf35a7a751e2976208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"816f972313fd72bb2b94f09dcbb38bf961007043","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"References"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":"proliantUtils library: https://github.com/hpproliant/proliantutils"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_48ddae6f","line":105,"updated":"2014-06-18 15:43:49.000000000","message":"Is it possible to also add some link to ILO specification or something?","commit_id":"3308270fe892995f6d3bdbbf35a7a751e2976208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f465751851ad003dd844927ef213ec5c34118b1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  * ``ilo_address`` - hostname or IP address of the iLO."},{"line_number":62,"context_line":"  * ``ilo_username`` - the username for the iLO with administrator privileges."},{"line_number":63,"context_line":"  * ``ilo_password`` - the password for ``ilo_username``"},{"line_number":64,"context_line":"  * ``ilo_client_timeout`` - the timeout for iLO operations."},{"line_number":65,"context_line":"  * ``ilo_client_port`` - the port to be used by iLO client for iLO operations."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_1a8d2cd4","line":64,"updated":"2014-06-23 11:10:38.000000000","message":"Will it have a default value? Please state here.","commit_id":"5e4069d58fdaa6a64a2c4d2c0524e9d657ef8d95"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"d3c36819eb9ca3ded289c8d7abe27893720bb8e9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  * ``ilo_address`` - hostname or IP address of the iLO."},{"line_number":62,"context_line":"  * ``ilo_username`` - the username for the iLO with administrator privileges."},{"line_number":63,"context_line":"  * ``ilo_password`` - the password for ``ilo_username``"},{"line_number":64,"context_line":"  * ``ilo_client_timeout`` - the timeout for iLO operations."},{"line_number":65,"context_line":"  * ``ilo_client_port`` - the port to be used by iLO client for iLO operations."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_7d554ac1","line":64,"in_reply_to":"1ae5cdf2_1a8d2cd4","updated":"2014-06-23 11:20:59.000000000","message":"Done","commit_id":"5e4069d58fdaa6a64a2c4d2c0524e9d657ef8d95"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9361c607cc27bc1ad84e74f27bb9830781e00786","unresolved":false,"context_lines":[{"line_number":29,"context_line":"specified in driver_info property of the node to connect to target iLO."},{"line_number":30,"context_line":"It makes use of iLO client in proliantUtils library to talk to iLO."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Additional power control operations will be added later."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_622034f9","line":32,"updated":"2014-06-23 21:03:03.000000000","message":"could you clarify what additional power operations are planned?","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15f6ac2b7f7c5374aa72cbe0e6898ac014d7c9eb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"specified in driver_info property of the node to connect to target iLO."},{"line_number":30,"context_line":"It makes use of iLO client in proliantUtils library to talk to iLO."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Additional power control operations will be added later."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_bc8c1430","line":32,"in_reply_to":"1ae5cdf2_622034f9","updated":"2014-06-24 04:27:45.000000000","message":"Mainly we wanted to expose the features of power capping and monitoring.  I have just added a line, add the HP whitepaper in the references page.","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9361c607cc27bc1ad84e74f27bb9830781e00786","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":"IPMI standard specification can be used for the power management."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Data model impact"},{"line_number":39,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_22d46cbc","line":36,"updated":"2014-06-23 21:03:03.000000000","message":"could you elaborate a little bit?\n\nIs there any benefit to using the iLO interface instead of standard IPMI for power management? \n\nIf there is no functional benefit, but it is more consistent with using the rest of the iLO drivers (deploy, management, console, etc) then that\u0027s fine -- please state that, though.","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15f6ac2b7f7c5374aa72cbe0e6898ac014d7c9eb","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Alternatives"},{"line_number":35,"context_line":"------------"},{"line_number":36,"context_line":"IPMI standard specification can be used for the power management."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Data model impact"},{"line_number":39,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_fc7f7c15","line":36,"in_reply_to":"1ae5cdf2_22d46cbc","updated":"2014-06-24 04:27:45.000000000","message":"Done.  There is no functional benefit as of now, and I have added that in the spec now.","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9361c607cc27bc1ad84e74f27bb9830781e00786","unresolved":false,"context_lines":[{"line_number":56,"context_line":"None"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Other end user impact"},{"line_number":59,"context_line":"---------------------"},{"line_number":60,"context_line":"The following driver_info fields are required:"},{"line_number":61,"context_line":"  * ``ilo_address`` - hostname or IP address of the iLO."},{"line_number":62,"context_line":"  * ``ilo_username`` - the username for the iLO with administrator privileges."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_0233f062","line":59,"updated":"2014-06-23 21:03:03.000000000","message":"Please move this info to the \"deployer impact\" section","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15f6ac2b7f7c5374aa72cbe0e6898ac014d7c9eb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"None"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Other end user impact"},{"line_number":59,"context_line":"---------------------"},{"line_number":60,"context_line":"The following driver_info fields are required:"},{"line_number":61,"context_line":"  * ``ilo_address`` - hostname or IP address of the iLO."},{"line_number":62,"context_line":"  * ``ilo_username`` - the username for the iLO with administrator privileges."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_dc8ac019","line":59,"in_reply_to":"1ae5cdf2_0233f062","updated":"2014-06-24 04:27:45.000000000","message":"Done","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9361c607cc27bc1ad84e74f27bb9830781e00786","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":"*  This feature is targeted for HP ProLiant servers with iLO4."},{"line_number":103,"context_line":"*  Depends on proliantUtils library."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_62767441","line":102,"updated":"2014-06-23 21:03:03.000000000","message":"Is this compatible with iLO3? \n\nIf not, how will this driver act when it communicates with an older version of iLO?","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15f6ac2b7f7c5374aa72cbe0e6898ac014d7c9eb","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":"*  This feature is targeted for HP ProLiant servers with iLO4."},{"line_number":103,"context_line":"*  Depends on proliantUtils library."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_7caa8c72","line":102,"in_reply_to":"1ae5cdf2_62767441","updated":"2014-06-24 04:27:45.000000000","message":"The power module might work with iLO3, even though we don\u0027t test it officially. I will jut add a note.","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9361c607cc27bc1ad84e74f27bb9830781e00786","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":"*  This feature is targeted for HP ProLiant servers with iLO4."},{"line_number":103,"context_line":"*  Depends on proliantUtils library."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Testing"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_02ae9081","line":103,"updated":"2014-06-23 21:03:03.000000000","message":"I found the proliantutils library on github, but could not find any packages for it on pypi.\n\nhttps://pypi.python.org/pypi?%3Aaction\u003dsearch\u0026term\u003dproliantutils\u0026submit\u003dsearch\n\nAdding a dependency such as this is fine, but it will need to be available as a package installable by pip. If you aren\u0027t sure how to create that, many openstack-related projects are using PBR for their build automation:\n\nhttp://docs.openstack.org/developer/pbr/","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15f6ac2b7f7c5374aa72cbe0e6898ac014d7c9eb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":"*  This feature is targeted for HP ProLiant servers with iLO4."},{"line_number":103,"context_line":"*  Depends on proliantUtils library."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Testing"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_bcb334eb","line":103,"in_reply_to":"1ae5cdf2_02ae9081","updated":"2014-06-24 04:27:45.000000000","message":"Done","commit_id":"063d075cb10329e4bd447a7c395bd449283d0124"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"a9e57e4eacd6fa1f2eef74f08d2b01829e979d14","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"To add a new IloPower() module which will conform to base.PowerInterface."},{"line_number":28,"context_line":"This module uses iLO credentials (ilo_address, ilo_username, ilo_password),"},{"line_number":29,"context_line":"specified in driver_info property of the node to connect to target iLO."},{"line_number":30,"context_line":"It makes use of iLO client in proliantUtils library to talk to iLO."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_1f4a0327","line":28,"updated":"2014-06-26 00:00:00.000000000","message":"Can iLo support Keys auth as well as password?","commit_id":"69aea361569e05b3fe8b4c8c77090596dce8d901"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ab2fc3707581bb2a65b6d4df4bfa763fc0cd2f51","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"To add a new IloPower() module which will conform to base.PowerInterface."},{"line_number":28,"context_line":"This module uses iLO credentials (ilo_address, ilo_username, ilo_password),"},{"line_number":29,"context_line":"specified in driver_info property of the node to connect to target iLO."},{"line_number":30,"context_line":"It makes use of iLO client in proliantUtils library to talk to iLO."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_6c9fd550","line":28,"in_reply_to":"1ae5cdf2_1f4a0327","updated":"2014-06-26 11:14:28.000000000","message":"iLO doesn\u0027t support key based authentication(eventhough it communicates over port 443). We need username/password everytime to communicate to iLO using RIBCL.","commit_id":"69aea361569e05b3fe8b4c8c77090596dce8d901"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"a9e57e4eacd6fa1f2eef74f08d2b01829e979d14","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Other end user impact"},{"line_number":68,"context_line":"---------------------"},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Scalability impact"},{"line_number":72,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_1f712377","line":69,"updated":"2014-06-26 00:00:00.000000000","message":"should inability to use  key based auth be listed?","commit_id":"69aea361569e05b3fe8b4c8c77090596dce8d901"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ab2fc3707581bb2a65b6d4df4bfa763fc0cd2f51","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Other end user impact"},{"line_number":68,"context_line":"---------------------"},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Scalability impact"},{"line_number":72,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_cced4990","line":69,"in_reply_to":"1ae5cdf2_1f712377","updated":"2014-06-26 11:14:28.000000000","message":"Done","commit_id":"69aea361569e05b3fe8b4c8c77090596dce8d901"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1f3095d0f04644a94581707b6067efed2c653f58","unresolved":false,"context_lines":[{"line_number":33,"context_line":"and power capping.  We would like to add support for these advanced vendor"},{"line_number":34,"context_line":"specific features later on."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"*NOTE*: Eventhough iLO uses SSL over port 443 for communication, ssh key based"},{"line_number":37,"context_line":"authentication is not supported for RIBCL communication. iLO username/password"},{"line_number":38,"context_line":"will need to be provided for talking to iLO."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_42cbab1d","line":36,"updated":"2014-06-26 23:08:51.000000000","message":"nit: s/Eventhough/Even though/","commit_id":"dad74737b975027a3889c604a319ba02f6464fe2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"a8cc05bc41f9b888f04dca056bc0f029358fcc30","unresolved":false,"context_lines":[{"line_number":33,"context_line":"and power capping.  We would like to add support for these advanced vendor"},{"line_number":34,"context_line":"specific features later on."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"*NOTE*: Eventhough iLO uses SSL over port 443 for communication, ssh key based"},{"line_number":37,"context_line":"authentication is not supported for RIBCL communication. iLO username/password"},{"line_number":38,"context_line":"will need to be provided for talking to iLO."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_9455df53","line":36,"in_reply_to":"1ae5cdf2_42cbab1d","updated":"2014-06-27 10:42:42.000000000","message":"Done","commit_id":"dad74737b975027a3889c604a319ba02f6464fe2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1f3095d0f04644a94581707b6067efed2c653f58","unresolved":false,"context_lines":[{"line_number":45,"context_line":"drivers for deploy, management in using a single iLO interface to do the"},{"line_number":46,"context_line":"operations."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"There is no functional benifit as of now in choosing this module over IPMI."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_82d133ce","line":48,"updated":"2014-06-26 23:08:51.000000000","message":"nit: s/benifit/benefit/","commit_id":"dad74737b975027a3889c604a319ba02f6464fe2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"a8cc05bc41f9b888f04dca056bc0f029358fcc30","unresolved":false,"context_lines":[{"line_number":45,"context_line":"drivers for deploy, management in using a single iLO interface to do the"},{"line_number":46,"context_line":"operations."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"There is no functional benifit as of now in choosing this module over IPMI."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_b45adb7f","line":48,"in_reply_to":"1ae5cdf2_82d133ce","updated":"2014-06-27 10:42:42.000000000","message":"Done","commit_id":"dad74737b975027a3889c604a319ba02f6464fe2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0859d008e6f39c06a76b12a657062ff0d9b19d1","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Security impact"},{"line_number":68,"context_line":"---------------"},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other end user impact"},{"line_number":72,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_6f62a0ae","line":69,"updated":"2014-07-02 14:12:02.000000000","message":"I don\u0027t know if it falls under here or not, but if ilo_password is specified -- there is the possibility that someone (else) will get access to that password. Are we OK with admins having access? It is stored (unencrypted) in the DB and I think if you do an ironic show, it\u0027ll display the password. But only admins should have access to this stuff.\n\nIt isn\u0027t unique to iLO. Just thought I\u0027d mention it.","commit_id":"c7f503306e9f0f6c1b4cdcff2df0f8620c03e24d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"a9ba51ab38e1df7fa962c167012299add55acecf","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Security impact"},{"line_number":68,"context_line":"---------------"},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other end user impact"},{"line_number":72,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_121ea763","line":69,"in_reply_to":"baada198_6f62a0ae","updated":"2014-07-02 14:29:18.000000000","message":"Yeah, as you had mentioned, since this is the case with every power driver that is available or proposed, I thought not to mention it as separate security concern only for this driver.  If you still feel I should add a note, please let me know, I will add the same.","commit_id":"c7f503306e9f0f6c1b4cdcff2df0f8620c03e24d"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ddc685d67cf6af89a53aee469adf8edf84eaa212","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  * ``ilo_client_timeout`` - the timeout for iLO operations. The default value"},{"line_number":90,"context_line":"    will be 60 seconds."},{"line_number":91,"context_line":"  * ``ilo_client_port`` - the port to be used by iLO client for iLO operations."},{"line_number":92,"context_line":"    The default value will be 443."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_9802690a","line":92,"updated":"2014-06-27 15:00:54.000000000","message":"this implies ssl, Can users add / use their own ssl certs? if so how will the Ilo driver know?","commit_id":"c7f503306e9f0f6c1b4cdcff2df0f8620c03e24d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"108b6b2b62ee989b410c73d7804424d741966b40","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  * ``ilo_client_timeout`` - the timeout for iLO operations. The default value"},{"line_number":90,"context_line":"    will be 60 seconds."},{"line_number":91,"context_line":"  * ``ilo_client_port`` - the port to be used by iLO client for iLO operations."},{"line_number":92,"context_line":"    The default value will be 443."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_0c161ea7","line":92,"in_reply_to":"1ae5cdf2_9802690a","updated":"2014-06-27 15:14:06.000000000","message":"Users can install SSL certificate on the iLO.  The RIBCL client works irrespective of whether certificates are installed on the iLO or not.  So, the iLO driver doesn\u0027t see any difference when the SSL certs are installed or not.","commit_id":"c7f503306e9f0f6c1b4cdcff2df0f8620c03e24d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d0859d008e6f39c06a76b12a657062ff0d9b19d1","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Testing"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":"Unit tests will be added, mocking proliantutils library."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Documentation Impact"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_afe11800","line":122,"updated":"2014-07-02 14:12:02.000000000","message":"I think we will want some third party CI for this [1]?\n\n[1] https://wiki.openstack.org/wiki/Ironic/Testing","commit_id":"c7f503306e9f0f6c1b4cdcff2df0f8620c03e24d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"a9ba51ab38e1df7fa962c167012299add55acecf","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Testing"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":"Unit tests will be added, mocking proliantutils library."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Documentation Impact"},{"line_number":125,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"baada198_8f3c54e4","line":122,"in_reply_to":"baada198_afe11800","updated":"2014-07-02 14:29:18.000000000","message":"Yes, we would like to add to tempest for third party testing, but don\u0027t have any current plans as of now.  Hence we didn\u0027t mention it here.  Also power being a very small module, and not much useful only by itself, we thought not to mention it here.  For example, just added a note in a more useful feature deploy, but nothing much useful there as well: https://review.openstack.org/#/c/97744/5/specs/juno/ironic-ilo-virtualmedia-driver.rst\n\nWe will really think of adding something when we have a useful feature like deploy.  Please let me know if it sounds okay.","commit_id":"c7f503306e9f0f6c1b4cdcff2df0f8620c03e24d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ec42b03dc6b1be826e3cb6098ca1b75d0f606538","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    will be 60 seconds."},{"line_number":94,"context_line":"  * ``ilo_client_port`` - the port to be used by iLO client for iLO operations."},{"line_number":95,"context_line":"    The default value will be 443."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Developer impact"},{"line_number":99,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"baada198_ccdfa867","line":96,"updated":"2014-07-07 20:06:53.000000000","message":"Nit:\n\nA note saying that only the pxe_ipmitool driver is currently enabled by default in Ironic at the moment[1] so operators would have add the iLO driver to the list of enabled drivers to use it.\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L28","commit_id":"96a7540ace8afe20c7c2c5833c170fe00a81719b"}]}
