)]}'
{"specs/enabling-ipmi-double-bridge-support.rst":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"35c7fdca4183c4039d8fe19dd4950f2ec5b74c93","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* When registering an baremetal node which requires double bridging, the"},{"line_number":32,"context_line":"  appropriate parameters should be specified to ironic IPMI power driver"},{"line_number":33,"context_line":"  as follows:"},{"line_number":34,"context_line":"  -i ipmi_local_address\u003d\u003cvalue\u003e"},{"line_number":35,"context_line":"  -i ipmi_transit_channel\u003d\u003cvalue\u003e"},{"line_number":36,"context_line":"  -i ipmi_transit_address\u003d\u003cvalue\u003e"},{"line_number":37,"context_line":"  -i ipmi_target_channel\u003d\u003cvalue\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_ce04cfc8","line":34,"updated":"2014-06-09 06:03:24.000000000","message":"For these list items, we need to add some \u0027new line\u0027 control here to avoid they are displayed within one single line in html page.","commit_id":"6a47be3103fd849020291954e48f57068b77b7f7"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"b3e5a8f5aba5dedd9ff894ded7a4baac1afcfef1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* When registering an baremetal node which requires double bridging, the"},{"line_number":32,"context_line":"  appropriate parameters should be specified to ironic IPMI power driver"},{"line_number":33,"context_line":"  as follows:"},{"line_number":34,"context_line":"  -i ipmi_local_address\u003d\u003cvalue\u003e"},{"line_number":35,"context_line":"  -i ipmi_transit_channel\u003d\u003cvalue\u003e"},{"line_number":36,"context_line":"  -i ipmi_transit_address\u003d\u003cvalue\u003e"},{"line_number":37,"context_line":"  -i ipmi_target_channel\u003d\u003cvalue\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_a17871f9","line":34,"in_reply_to":"1ae5cdf2_ce04cfc8","updated":"2014-06-09 10:22:28.000000000","message":"Done","commit_id":"6a47be3103fd849020291954e48f57068b77b7f7"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"35c7fdca4183c4039d8fe19dd4950f2ec5b74c93","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"When an node which mandates double bridging is being registered, provide"},{"line_number":100,"context_line":"the following:"},{"line_number":101,"context_line":"-i ipmi_local_address\u003d\u003cvalue\u003e"},{"line_number":102,"context_line":"-i ipmi_transit_channel\u003d\u003cvalue\u003e"},{"line_number":103,"context_line":"-i ipmi_transit_address\u003d\u003cvalue\u003e"},{"line_number":104,"context_line":"-i ipmi_target_channel\u003d\u003cvalue\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_2e1453f4","line":101,"updated":"2014-06-09 06:03:24.000000000","message":"ditto.","commit_id":"6a47be3103fd849020291954e48f57068b77b7f7"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"b3e5a8f5aba5dedd9ff894ded7a4baac1afcfef1","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"When an node which mandates double bridging is being registered, provide"},{"line_number":100,"context_line":"the following:"},{"line_number":101,"context_line":"-i ipmi_local_address\u003d\u003cvalue\u003e"},{"line_number":102,"context_line":"-i ipmi_transit_channel\u003d\u003cvalue\u003e"},{"line_number":103,"context_line":"-i ipmi_transit_address\u003d\u003cvalue\u003e"},{"line_number":104,"context_line":"-i ipmi_target_channel\u003d\u003cvalue\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_e18279c7","line":101,"in_reply_to":"1ae5cdf2_2e1453f4","updated":"2014-06-09 10:22:28.000000000","message":"Done","commit_id":"6a47be3103fd849020291954e48f57068b77b7f7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"299339ccbdf41e3420aafb86f1540d37c6a6e845","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    i.e, In order to perform an double-bridge, an user can just specify"},{"line_number":42,"context_line":"    transit_channel and transit_address, rest is taken care by ipmi."},{"line_number":43,"context_line":"    But some hardware will mandate to specify transit_channel and"},{"line_number":44,"context_line":"    target_channel, if they are using different channels."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Ironic IPMI driver should be modified to parse the above information"},{"line_number":47,"context_line":"  and perform ipmi operations with appropriate parameters."}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_1d640ce4","line":44,"updated":"2014-07-02 07:10:10.000000000","message":"How will the user know whether they need to include the additional parameters?\nWill the driver auto-detect this somehow and inform the user, or does the\nuser need to know this ahead of time?","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    i.e, In order to perform an double-bridge, an user can just specify"},{"line_number":42,"context_line":"    transit_channel and transit_address, rest is taken care by ipmi."},{"line_number":43,"context_line":"    But some hardware will mandate to specify transit_channel and"},{"line_number":44,"context_line":"    target_channel, if they are using different channels."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Ironic IPMI driver should be modified to parse the above information"},{"line_number":47,"context_line":"  and perform ipmi operations with appropriate parameters."}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_b2d4ed20","line":44,"in_reply_to":"baada198_1d640ce4","updated":"2014-07-11 12:33:58.000000000","message":"The need for the additional parameters is based on the underlying hardware that is being provisioned using ironic. The user needs to know the parameters ahead of time. The details should be available from the IPMI mgmt interface of the hardware.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"299339ccbdf41e3420aafb86f1540d37c6a6e845","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Ironic IPMI driver should be modified to parse the above information"},{"line_number":47,"context_line":"  and perform ipmi operations with appropriate parameters."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_3d6390dd","line":48,"updated":"2014-07-02 07:10:10.000000000","message":"Will this proposal have any impact on non-double-bridged systems?","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Ironic IPMI driver should be modified to parse the above information"},{"line_number":47,"context_line":"  and perform ipmi operations with appropriate parameters."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Alternatives"},{"line_number":50,"context_line":"------------"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_b2a22dac","line":48,"in_reply_to":"baada198_3d6390dd","updated":"2014-07-11 12:33:58.000000000","message":"The logic takes care of keeping the existing functionality intact. It can coexist with the non-bridged systems.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"299339ccbdf41e3420aafb86f1540d37c6a6e845","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Driver API impact"},{"line_number":67,"context_line":"-----------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When an node is registered using double bridging configurations,"},{"line_number":70,"context_line":"IPMI driver uses these configurations to reach the baremetal node."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Nova driver impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_5d5e8413","line":69,"updated":"2014-07-02 07:10:10.000000000","message":"This isn\u0027t describing any impact to the driver api...","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Driver API impact"},{"line_number":67,"context_line":"-----------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When an node is registered using double bridging configurations,"},{"line_number":70,"context_line":"IPMI driver uses these configurations to reach the baremetal node."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Nova driver impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_12ae7998","line":69,"in_reply_to":"baada198_5d5e8413","updated":"2014-07-11 12:33:58.000000000","message":"I was mentioning that while registering the nodes to use double bridging functionality, the user needs to provide the required parameters as mentioned above.\nThe driver API will anyways work seamless. So there will not be any impact.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"dee4aec73242374d5b7f5cea8e4217fdb4bd4c7d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Security impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Other end user impact"},{"line_number":83,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_4ed22901","line":80,"updated":"2014-07-02 23:59:59.000000000","message":"Could this double bridging be exploited to to access un intended systems?","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Security impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Other end user impact"},{"line_number":83,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_32dc5de4","line":80,"in_reply_to":"baada198_4ed22901","updated":"2014-07-11 12:33:58.000000000","message":"The IPMI commands operate on the specified Host/Chassis address. Also all the operations that are enabled to use double bridging work only on server nodes. So unintended systems cannot be accessed using the double bridging that will be enabled by this proposal.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"299339ccbdf41e3420aafb86f1540d37c6a6e845","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Scalability impact"},{"line_number":87,"context_line":"------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Performance Impact"},{"line_number":92,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_7d9c28c1","line":89,"updated":"2014-07-02 07:10:10.000000000","message":"Are there scalability implications when interacting with many nodes in parallel\nwhich share the same IPMI bridge? \n\nDoes the BMC limit the number of concurrent double-bridged sessions?\nIf so, what needs to be done within Ironic to handle these limitations?","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Scalability impact"},{"line_number":87,"context_line":"------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Performance Impact"},{"line_number":92,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_45666dee","line":89,"in_reply_to":"baada198_7d9c28c1","updated":"2014-07-11 12:33:58.000000000","message":"Not sure how I missed to update this.\nSo far we have not encountered any scalability implications when testing double bridging with Moonshot servers, where every BMC can support up to 45 to 180 servers.\nBut, it depends on the IPMI interface on the underlying BMC.\nIn such a situation if the session is not available, we can have retries in ironic IPMI.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"299339ccbdf41e3420aafb86f1540d37c6a6e845","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Performance Impact"},{"line_number":92,"context_line":"------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"None"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Other deployer impact"},{"line_number":97,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_9d9f3cb4","line":94,"updated":"2014-07-02 07:10:10.000000000","message":"Are double-bridged IPMI sessions slower than non-bridged sessions? If so, that\u0027s worth calling out","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":91,"context_line":"Performance Impact"},{"line_number":92,"context_line":"------------------"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"None"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Other deployer impact"},{"line_number":97,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_65e4513c","line":94,"in_reply_to":"baada198_9d9f3cb4","updated":"2014-07-11 12:33:58.000000000","message":"If it is an federated mgmt, where there might be one main controller and many sub controllers, there might not be much difference. But if only one controller exists in the BMC that manages all the nodes, then the sessions might be slower.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"dee4aec73242374d5b7f5cea8e4217fdb4bd4c7d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"ipmitool utility"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Testing"},{"line_number":141,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_0e84b10a","line":138,"updated":"2014-07-02 23:59:59.000000000","message":"there are different ipmitool commands out:\nwe have to take steps to determine if some options are supported. (see https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L77-L105 as an example). Will we have to do the same type of checking for bridging support. Some quick looking seem to indicate that support was added in version 1.8.10 in the OpenIpmi tools command.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"ipmitool utility"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Testing"},{"line_number":141,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_055b95f6","line":138,"in_reply_to":"baada198_0e84b10a","updated":"2014-07-11 12:33:58.000000000","message":"IPMI double bridging is supported in IPMI tool from 1.8.12 onwards. I will update it.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"299339ccbdf41e3420aafb86f1540d37c6a6e845","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Unit test cases to test IPMI driver with double bridging enabled and disabled"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Documentation Impact"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_bda6c00e","line":145,"updated":"2014-07-02 07:10:10.000000000","message":"How will this be functionally tested on hardware which supports double bridging?\n\nDo different vendors support / implement this feature in different ways?\nWill the same briding parameters work on hardware from all vendors?\n\nA reference to the IPMI specification for double bridge support would be helpful.","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"f67419e0363b5b528a0ccf7e51e080b11d92b383","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Unit test cases to test IPMI driver with double bridging enabled and disabled"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Documentation Impact"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"baada198_45ccad89","line":145,"in_reply_to":"baada198_bda6c00e","updated":"2014-07-11 12:33:58.000000000","message":"IPMI tool is based on standard IPMI specification. So we assume that if an hardware vendor adheres to the IPMI specification there should not be any issues. We will look for the IPMI specification referencing double bridging support and update here","commit_id":"2a7b2544a10dcd5b89eb3776c2ee718fd64887d1"}],"specs/juno/enabling-ipmi-double-bridge-support.rst":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18de34257216cf6f73fbe9ad08cef92df0d53cd1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently, ironic IPMI driver does not support bridging."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Many of the recent server architecture is based on distributed management."},{"line_number":22,"context_line":"For a chassis that has \"n\" number of servers, the management is delegated"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_1186b3ba","line":19,"updated":"2014-07-30 17:56:28.000000000","message":"We currently have two IPMI drivers, ipmitool and native. I\u0027m assuming it\u0027s ipmitool only by looking at the \"Dependencies\" section, is that correct? It would be nice to clarify it","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"7e043a3b99ea9691e7233120586ba56164fd634e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently, ironic IPMI driver does not support bridging."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Many of the recent server architecture is based on distributed management."},{"line_number":22,"context_line":"For a chassis that has \"n\" number of servers, the management is delegated"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_3f58cf89","line":19,"in_reply_to":"baada198_1186b3ba","updated":"2014-07-31 11:12:22.000000000","message":"yes, you are right, it is ipmitool, today the native driver does not expose this functionality.\nI will update in the next patch.","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18de34257216cf6f73fbe9ad08cef92df0d53cd1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- When registering an baremetal node which requires double bridging, the"},{"line_number":31,"context_line":"  appropriate parameters should be specified to ironic IPMI power driver"},{"line_number":32,"context_line":"  as follows:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_919e4368","line":30,"updated":"2014-07-30 17:56:28.000000000","message":"Question:\n\nHow does that validation of that options occurs?\n\nI mean if the node requires double bridging those new configs needs to be set (mandatory), if the node doesn\u0027t require double bridging that options doesn\u0027t need to be set (not mandatory). How does the validation knows that the node requires or not double bridging? Maybe another flag to tell the driver that the node supports double_bridging?\n\ne.g\n\nipmi_double_bridging \u003d True","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"7e043a3b99ea9691e7233120586ba56164fd634e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Proposed change"},{"line_number":28,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- When registering an baremetal node which requires double bridging, the"},{"line_number":31,"context_line":"  appropriate parameters should be specified to ironic IPMI power driver"},{"line_number":32,"context_line":"  as follows:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_df50b32e","line":30,"in_reply_to":"baada198_919e4368","updated":"2014-07-31 11:12:22.000000000","message":"we wanted to determine based on the parameters provided while registering the node.\n\nHowever yes, assumptions may not be good. Lets ask the user to explicitly specify","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18de34257216cf6f73fbe9ad08cef92df0d53cd1","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Adds the above key:value pairs to IPMI driver."},{"line_number":58,"context_line":"Database migration should not be affected, since it is only adding"},{"line_number":59,"context_line":"key:value pairs to driver_info dictionary."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"REST API impact"},{"line_number":62,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_91cd63bd","line":59,"updated":"2014-07-30 17:56:28.000000000","message":"Nit: this should be None\n\ndriver_info is a dict-like blob data field, so no changes to the model is needed to add/remove/update fields on that","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"7e043a3b99ea9691e7233120586ba56164fd634e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Adds the above key:value pairs to IPMI driver."},{"line_number":58,"context_line":"Database migration should not be affected, since it is only adding"},{"line_number":59,"context_line":"key:value pairs to driver_info dictionary."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"REST API impact"},{"line_number":62,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_ff2e57aa","line":59,"in_reply_to":"baada198_91cd63bd","updated":"2014-07-31 11:12:22.000000000","message":"Done","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18de34257216cf6f73fbe9ad08cef92df0d53cd1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"IPMITOOL_1_8_12"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_b1dd0716","line":142,"updated":"2014-07-30 17:56:28.000000000","message":"Are we going to have a validation to check the version of the ipmitool?\n\nSomething like we have now to check if the number of retry and attempts are supported by ipmitool[1]\n\n[1]  https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L98-L126","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"},{"author":{"_account_id":11424,"name":"Rakesh H S","email":"rakeshhs1@gmail.com","username":"rakesh"},"change_message_id":"7e043a3b99ea9691e7233120586ba56164fd634e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"IPMITOOL_1_8_12"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_bf2cdfad","line":142,"in_reply_to":"baada198_b1dd0716","updated":"2014-07-31 11:12:22.000000000","message":"We got an similar comment, and yes we are planning to do that in code.","commit_id":"d8b6606b753b81dd28a88de0dadfcb76b6c58cd9"}]}