)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"2242a53600fc80f0d93bff2ff2a110ad7efe5563","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8544da3_af87f4b1","updated":"2026-04-27 08:09:44.000000000","message":"Thank you for the feedback, pushed an update.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"}],"specs/approved/firmware-endpoint-hardware-identity.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e8217869aaac83a2bcdd965dd8e370d61f402ee","unresolved":true,"context_lines":[{"line_number":16,"context_line":"version-tracking fields.  The Redfish resources already queried also"},{"line_number":17,"context_line":"carry hardware identity attributes — vendor, model, and serial number —"},{"line_number":18,"context_line":"useful for inventory, auditing, and correlating firmware versions to"},{"line_number":19,"context_line":"specific hardware models.  This spec adds those attributes to the"},{"line_number":20,"context_line":"firmware endpoint."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1fe82e0f_1a418714","line":20,"range":{"start_line":19,"start_character":27,"end_line":20,"end_character":18},"updated":"2026-04-23 18:24:32.000000000","message":"It would be more helpful to explain the \"why\" and how that can be used or users can benefit.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"2242a53600fc80f0d93bff2ff2a110ad7efe5563","unresolved":true,"context_lines":[{"line_number":16,"context_line":"version-tracking fields.  The Redfish resources already queried also"},{"line_number":17,"context_line":"carry hardware identity attributes — vendor, model, and serial number —"},{"line_number":18,"context_line":"useful for inventory, auditing, and correlating firmware versions to"},{"line_number":19,"context_line":"specific hardware models.  This spec adds those attributes to the"},{"line_number":20,"context_line":"firmware endpoint."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ed088896_9ab5d857","line":20,"range":{"start_line":19,"start_character":27,"end_line":20,"end_character":18},"in_reply_to":"1fe82e0f_1a418714","updated":"2026-04-27 08:09:44.000000000","message":"I have reworded.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"2bcb3973419d41abedcbec9c6a598ecda432c676","unresolved":true,"context_lines":[{"line_number":48,"context_line":"version carries hardware identity fields:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":51,"context_line":"  in the Ironic API, consistent with the existing ``Port.vendor`` field"},{"line_number":52,"context_line":"  and the IPA hardware inventory naming convention [1]_)"},{"line_number":53,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":54,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b87e0b0a_37df2cac","line":51,"updated":"2026-04-23 16:21:19.000000000","message":"``Port.vendor`` isn\u0027t a field to be set to that. It\u0027s a free form field for vendor specific data about this port.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"2242a53600fc80f0d93bff2ff2a110ad7efe5563","unresolved":true,"context_lines":[{"line_number":48,"context_line":"version carries hardware identity fields:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":51,"context_line":"  in the Ironic API, consistent with the existing ``Port.vendor`` field"},{"line_number":52,"context_line":"  and the IPA hardware inventory naming convention [1]_)"},{"line_number":53,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":54,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"85375316_9093e8c6","line":51,"in_reply_to":"3f6df899_ebc6747b","updated":"2026-04-27 08:09:44.000000000","message":"The point here is that we should avoid use \"Manufacturer\" (return by redfish) and use \"vendor\" to be aligned with IPA. The port.vendor is indeed confusing(removed).","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e8217869aaac83a2bcdd965dd8e370d61f402ee","unresolved":true,"context_lines":[{"line_number":48,"context_line":"version carries hardware identity fields:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":51,"context_line":"  in the Ironic API, consistent with the existing ``Port.vendor`` field"},{"line_number":52,"context_line":"  and the IPA hardware inventory naming convention [1]_)"},{"line_number":53,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":54,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f6df899_ebc6747b","line":51,"in_reply_to":"b87e0b0a_37df2cac","updated":"2026-04-23 18:24:32.000000000","message":"I could see reason to provide more visibility, but that seems disjointed with the exception of $whatever value is used to internally track/identify the device internally as it relates internally.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"2bcb3973419d41abedcbec9c6a598ecda432c676","unresolved":true,"context_lines":[{"line_number":87,"context_line":"| NIC       | NetworkAdapter. | NetworkAdapter. | NetworkAdapter.   |"},{"line_number":88,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"},{"line_number":89,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":90,"context_line":"| BMC       | null            | Manager.Model   | null              |"},{"line_number":91,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":92,"context_line":"| BIOS      | ComputerSystem. | ComputerSystem. | ComputerSystem.   |"},{"line_number":93,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f16a2850_b063a387","line":90,"updated":"2026-04-23 16:21:19.000000000","message":"nulling this seems wrong...","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"2242a53600fc80f0d93bff2ff2a110ad7efe5563","unresolved":true,"context_lines":[{"line_number":87,"context_line":"| NIC       | NetworkAdapter. | NetworkAdapter. | NetworkAdapter.   |"},{"line_number":88,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"},{"line_number":89,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":90,"context_line":"| BMC       | null            | Manager.Model   | null              |"},{"line_number":91,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":92,"context_line":"| BIOS      | ComputerSystem. | ComputerSystem. | ComputerSystem.   |"},{"line_number":93,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"}],"source_content_type":"text/x-rst","patch_set":2,"id":"54cbbc1b_708aa1c8","line":90,"in_reply_to":"f16a2850_b063a387","updated":"2026-04-27 08:09:44.000000000","message":"We use same schema for bios/bmc/nic. Redfish returns fields e.g. BMC does not have vendor. Keeping the fields that do not exist null (or other keyword e.g. empty) imo is cleaner than trying to infer the value. \n\nI suppose a cleaner approach would be to create different tables per component or even challenge the need for DB since that information just duplicate to the what BMC has.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"2bcb3973419d41abedcbec9c6a598ecda432c676","unresolved":true,"context_lines":[{"line_number":90,"context_line":"| BMC       | null            | Manager.Model   | null              |"},{"line_number":91,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":92,"context_line":"| BIOS      | ComputerSystem. | ComputerSystem. | ComputerSystem.   |"},{"line_number":93,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"},{"line_number":94,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"All fields are optional in the Redfish schema and may be ``null`` if the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"45e60e0b_8bf45ccf","line":93,"updated":"2026-04-23 16:21:19.000000000","message":"Are we sure those are correct and not the actual manufacture vs the motherboard info?","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e8217869aaac83a2bcdd965dd8e370d61f402ee","unresolved":true,"context_lines":[{"line_number":90,"context_line":"| BMC       | null            | Manager.Model   | null              |"},{"line_number":91,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":92,"context_line":"| BIOS      | ComputerSystem. | ComputerSystem. | ComputerSystem.   |"},{"line_number":93,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"},{"line_number":94,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"All fields are optional in the Redfish schema and may be ``null`` if the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7c143776_d55759c3","line":93,"in_reply_to":"45e60e0b_8bf45ccf","updated":"2026-04-23 18:24:32.000000000","message":"Basically one is flashable/settable, the other often is not. I think we\u0027re boiling it down but placing some of that data in the wrong place, but I really can\u0027t be sure because of the way this spec is written.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"2242a53600fc80f0d93bff2ff2a110ad7efe5563","unresolved":true,"context_lines":[{"line_number":90,"context_line":"| BMC       | null            | Manager.Model   | null              |"},{"line_number":91,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":92,"context_line":"| BIOS      | ComputerSystem. | ComputerSystem. | ComputerSystem.   |"},{"line_number":93,"context_line":"|           | Manufacturer    | Model           | SerialNumber      |"},{"line_number":94,"context_line":"+-----------+-----------------+-----------------+-------------------+"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"All fields are optional in the Redfish schema and may be ``null`` if the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"28719840_1aa62a40","line":93,"in_reply_to":"7c143776_d55759c3","updated":"2026-04-27 08:09:44.000000000","message":"This RFE is about NICs (that are not unique/fixed). Because we share the db schema, it looked better to attempt to fill values. But this is out of scope, so I will let it NULL(empty) and having a value there be different RFE.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e8217869aaac83a2bcdd965dd8e370d61f402ee","unresolved":true,"context_lines":[{"line_number":102,"context_line":"without parsing the component string, so that the field surface is"},{"line_number":103,"context_line":"consistent across all component types, and to allow flexibility if the"},{"line_number":104,"context_line":"component identifier format needs to change in the future."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Alternatives"},{"line_number":108,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f6542bc0_3e0c7405","line":105,"updated":"2026-04-23 18:24:32.000000000","message":"I\u0027d really like each table, and value enumerated here.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"e5c5133e96242f9d0cf0c033121dffe207dad5e9","unresolved":false,"context_lines":[{"line_number":102,"context_line":"without parsing the component string, so that the field surface is"},{"line_number":103,"context_line":"consistent across all component types, and to allow flexibility if the"},{"line_number":104,"context_line":"component identifier format needs to change in the future."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Alternatives"},{"line_number":108,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f7f1c1a0_0a0ad921","line":105,"in_reply_to":"f6542bc0_3e0c7405","updated":"2026-05-28 12:29:11.000000000","message":"Done","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e8217869aaac83a2bcdd965dd8e370d61f402ee","unresolved":true,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"* **Alembic migration** (new file under"},{"line_number":320,"context_line":"  ``ironic/db/sqlalchemy/alembic/versions/``): ``op.add_column`` for"},{"line_number":321,"context_line":"  each of the three new columns on ``firmware_information``."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"* **Versioned object** (``ironic/objects/firmware.py``):"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"15dd2dd6_826900a4","line":321,"updated":"2026-04-23 18:24:32.000000000","message":"Please indicate the columns.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"e5c5133e96242f9d0cf0c033121dffe207dad5e9","unresolved":true,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"* **Alembic migration** (new file under"},{"line_number":320,"context_line":"  ``ironic/db/sqlalchemy/alembic/versions/``): ``op.add_column`` for"},{"line_number":321,"context_line":"  each of the three new columns on ``firmware_information``."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"* **Versioned object** (``ironic/objects/firmware.py``):"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7bd6084c_4e0fe9b4","line":321,"in_reply_to":"15dd2dd6_826900a4","updated":"2026-05-28 12:29:11.000000000","message":"done (I think)","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e8217869aaac83a2bcdd965dd8e370d61f402ee","unresolved":true,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"* **Docs**: ``doc/source/contributor/webapi-version-history.rst`` entry"},{"line_number":362,"context_line":"  and ``api-ref`` sample JSON updated."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Dependencies"},{"line_number":366,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6b01ccd4_064cf12a","line":363,"updated":"2026-04-23 18:24:32.000000000","message":"So, I\u0027m reading through the work items, and I\u0027m not exactly clear on who, what, why from the earlier requirements. It feels like we\u0027re painting a very high level picture and trying to burry the details of what in the implementation details. At least, that is how it comes off.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"96368cdbaf374c57f5a49be49b670851c1b6715a","unresolved":true,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"* **Docs**: ``doc/source/contributor/webapi-version-history.rst`` entry"},{"line_number":362,"context_line":"  and ``api-ref`` sample JSON updated."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Dependencies"},{"line_number":366,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"79f4f602_ad921593","line":363,"in_reply_to":"19e351f4_54db62cc","updated":"2026-04-27 15:01:28.000000000","message":"At the very least you should mention that you want to add more DB fields. Extend the API to add more fields. Update the CLI to display these fields, etc.","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"2242a53600fc80f0d93bff2ff2a110ad7efe5563","unresolved":true,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"* **Docs**: ``doc/source/contributor/webapi-version-history.rst`` entry"},{"line_number":362,"context_line":"  and ``api-ref`` sample JSON updated."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"Dependencies"},{"line_number":366,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"19e351f4_54db62cc","line":363,"in_reply_to":"6b01ccd4_064cf12a","updated":"2026-04-27 08:09:44.000000000","message":"It was not clear due to the template and the AI what is a complete RFE. I have removed everything I am unsure with TBD. We can for sure fill/investigate on demand","commit_id":"2531b3466a105019545a7ef7adede4d09754b720"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"96368cdbaf374c57f5a49be49b670851c1b6715a","unresolved":true,"context_lines":[{"line_number":78,"context_line":"resource (DMTF schema ``NetworkAdapter.v1_3_0``) that Ironic already"},{"line_number":79,"context_line":"queries for firmware version carries hardware identity fields:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":82,"context_line":"  in the Ironic API)"},{"line_number":83,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":84,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cb759ac7_5f14dcd0","line":81,"updated":"2026-04-27 15:01:28.000000000","message":"You write this like Ironic is wrong but its not with PCI devices you have a vendor and the sub-device\u0027s vendor. Typically speaking the sub-device vendor or sub-vendor is the manufacturer while the vendor is of the chipset. You\u0027ll see this with HPE or Dell branded NIC cards. The vendor will be 0x8086 for Intel and whatever the HPE or Dell value is for the sub-vendor.","commit_id":"1aac4d2249245ba8424d64487d78cdfcff3408fc"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"e5c5133e96242f9d0cf0c033121dffe207dad5e9","unresolved":true,"context_lines":[{"line_number":78,"context_line":"resource (DMTF schema ``NetworkAdapter.v1_3_0``) that Ironic already"},{"line_number":79,"context_line":"queries for firmware version carries hardware identity fields:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":82,"context_line":"  in the Ironic API)"},{"line_number":83,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":84,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"15463cdc_c249d4d9","line":81,"in_reply_to":"cb759ac7_5f14dcd0","updated":"2026-05-28 12:29:11.000000000","message":"I do not understand what part of the proposal suggests that ironic is wrong in something. Can you please expand? valies like \"Intel Corporation\" and any value are  taken from real Redfish call to dell/hpe server. I have reworded a bit to stretch that the correlation between inventory/firmware is one to one but heurestic (but best thing we can do)","commit_id":"1aac4d2249245ba8424d64487d78cdfcff3408fc"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"96368cdbaf374c57f5a49be49b670851c1b6715a","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":82,"context_line":"  in the Ironic API)"},{"line_number":83,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":84,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"},{"line_number":85,"context_line":"  component identifier, but not returned as a structured field)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9d052945_bbd23781","line":83,"updated":"2026-04-27 15:01:28.000000000","message":"This is again the string value that the vendor picked. It should be the same as the sub-device in string form.","commit_id":"1aac4d2249245ba8424d64487d78cdfcff3408fc"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"e5c5133e96242f9d0cf0c033121dffe207dad5e9","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* ``Manufacturer`` – e.g. ``\"Intel Corporation\"`` (exposed as ``vendor``"},{"line_number":82,"context_line":"  in the Ironic API)"},{"line_number":83,"context_line":"* ``Model`` – e.g. ``\"Intel(R) 25GbE 2P XXV710 Adptr\"``"},{"line_number":84,"context_line":"* ``SerialNumber`` – e.g. ``\"ABC12345\"`` (already used to build the"},{"line_number":85,"context_line":"  component identifier, but not returned as a structured field)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9477e1ad_59bc835d","line":83,"in_reply_to":"9d052945_bbd23781","updated":"2026-05-28 12:29:11.000000000","message":"What is \"sub-device\"? Is that field in the inventory?","commit_id":"1aac4d2249245ba8424d64487d78cdfcff3408fc"}]}