)]}'
{"tools/make-tempest-plugin-repo.sh":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"6018e59459fc4012861c0d9053e9113cebc595d2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":"# set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BASE_DIR\u003d$(cd $(dirname $0)/.. \u0026\u0026 pwd)"},{"line_number":8,"context_line":"IRONIC_DIR\u003d$(cd ${BASE_DIR}/../ironic \u0026\u0026 pwd)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"BACKUP_DIR\u003d${BASE_DIR}/copy-ironic_tempest_plugin/"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_8bad979c","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":30},"updated":"2017-08-03 22:45:57.000000000","message":"shouldn\u0027t this be $(cd $(dirname $0/..) \u0026\u0026 pwd). For e.g. if my ironic repo is in /opt/stack/ironic then i will pass /opt/stack/ironic as an argument, but with the current code BASE_DIR will be evaluated to /opt and when it tries to evaluate IRONIC_DIR it will be looking for ironic in \"/opt/..\" directory where it will not exist?","commit_id":"12fe8b66788f6347d3f66561d7aa9eb346627b45"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5be56503ddc6fd26888577d05f9b7249cbe165a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":"# set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BASE_DIR\u003d$(cd $(dirname $0)/.. \u0026\u0026 pwd)"},{"line_number":8,"context_line":"IRONIC_DIR\u003d$(cd ${BASE_DIR}/../ironic \u0026\u0026 pwd)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"BACKUP_DIR\u003d${BASE_DIR}/copy-ironic_tempest_plugin/"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_cbcddf31","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":30},"in_reply_to":"df3967d1_8bad979c","updated":"2017-08-03 22:51:00.000000000","message":"I don\u0027t quite understand the question.\n\n$0 is the filename of this script. Which is not located in the ironic directory but in ironic-tempest-plugin/tools/make-tempest-plugin-repo.sh","commit_id":"12fe8b66788f6347d3f66561d7aa9eb346627b45"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"8bc1d82bbc4c25dbc95edaa7d969f05143bd9521","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":"# set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BASE_DIR\u003d$(cd $(dirname $0)/.. \u0026\u0026 pwd)"},{"line_number":8,"context_line":"IRONIC_DIR\u003d$(cd ${BASE_DIR}/../ironic \u0026\u0026 pwd)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"BACKUP_DIR\u003d${BASE_DIR}/copy-ironic_tempest_plugin/"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_b1fd6e6f","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":30},"in_reply_to":"df3967d1_cbcddf31","updated":"2017-08-04 00:35:17.000000000","message":"Oh i got you then, my bad. The question is then invalid. Somehow i thought it\u0027s under ironic/tools","commit_id":"12fe8b66788f6347d3f66561d7aa9eb346627b45"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5f4e77090ad41a660a7729756fb94f31ac89225","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -u"},{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":"# set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BASE_DIR\u003d$(cd $(dirname $0)/.. \u0026\u0026 pwd)"},{"line_number":8,"context_line":"IRONIC_DIR\u003d$(cd ${BASE_DIR}/../ironic \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_5c445eb7","line":5,"updated":"2017-09-26 13:22:39.000000000","message":"remove this one?","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d40f3b4f3b362b94be3b7e825026ebc254b604f7","unresolved":false,"context_lines":[{"line_number":102,"context_line":"read"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"echo \"Cherry picking commits...\""},{"line_number":105,"context_line":"sleep 1.0"},{"line_number":106,"context_line":"git remote add ironic-$$ ${IRONIC_DIR}/.git"},{"line_number":107,"context_line":"git fetch ironic-$$"},{"line_number":108,"context_line":"for revision in ${REV_LIST}; do"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_1c9f06b5","line":105,"updated":"2017-09-26 12:55:15.000000000","message":"I wonder why this is needed","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f7e513e2a181834854899d200643d0b1806a6e57","unresolved":false,"context_lines":[{"line_number":102,"context_line":"read"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"echo \"Cherry picking commits...\""},{"line_number":105,"context_line":"sleep 1.0"},{"line_number":106,"context_line":"git remote add ironic-$$ ${IRONIC_DIR}/.git"},{"line_number":107,"context_line":"git fetch ironic-$$"},{"line_number":108,"context_line":"for revision in ${REV_LIST}; do"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_ce336c13","line":105,"in_reply_to":"7f515b1d_1c9f06b5","updated":"2017-10-02 17:40:47.000000000","message":"Because I wanted time to read the message","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5f4e77090ad41a660a7729756fb94f31ac89225","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# But if we don\u0027t do this then every patch will have the committer be the"},{"line_number":122,"context_line":"# person running this script."},{"line_number":123,"context_line":"git filter-branch -f --env-filter \u0027"},{"line_number":124,"context_line":"    export GIT_COMMITTER_NAME\u003d\"${GIT_AUTHOR_NAME}\""},{"line_number":125,"context_line":"    export GIT_COMMITTER_EMAIL\u003d\"${GIT_AUTHOR_EMAIL}\""},{"line_number":126,"context_line":"    export GIT_COMMITTER_DATE\u003d\"${GIT_AUTHOR_DATE}\""},{"line_number":127,"context_line":"\u0027 --tag-name-filter cat ${CURRENT_REV}..HEAD"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_afb2f292","line":124,"updated":"2017-09-26 13:22:39.000000000","message":"can we do this only once here and remove lines 74-78?","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f7e513e2a181834854899d200643d0b1806a6e57","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# But if we don\u0027t do this then every patch will have the committer be the"},{"line_number":122,"context_line":"# person running this script."},{"line_number":123,"context_line":"git filter-branch -f --env-filter \u0027"},{"line_number":124,"context_line":"    export GIT_COMMITTER_NAME\u003d\"${GIT_AUTHOR_NAME}\""},{"line_number":125,"context_line":"    export GIT_COMMITTER_EMAIL\u003d\"${GIT_AUTHOR_EMAIL}\""},{"line_number":126,"context_line":"    export GIT_COMMITTER_DATE\u003d\"${GIT_AUTHOR_DATE}\""},{"line_number":127,"context_line":"\u0027 --tag-name-filter cat ${CURRENT_REV}..HEAD"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_30437e44","line":124,"in_reply_to":"7f515b1d_afb2f292","updated":"2017-10-02 17:40:47.000000000","message":"Maybe, I\u0027m not 100%. Realize that this script will be done once and we are done. So not sure we need to optimize things.","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5f4e77090ad41a660a7729756fb94f31ac89225","unresolved":false,"context_lines":[{"line_number":134,"context_line":"echo \"We should have no output\""},{"line_number":135,"context_line":"diff -Naur ${TEMPEST_PLUGIN_DIR} ${NEW_PLUGIN_DIR}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"echo \"No differences. Yay! :)\""},{"line_number":138,"context_line":"echo \"Success. We are done!\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_8f9e1652","line":137,"updated":"2017-09-26 13:22:39.000000000","message":"this will be output even if there was output?","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55836e5309587b1f6b2fef00851053bf960dec30","unresolved":false,"context_lines":[{"line_number":134,"context_line":"echo \"We should have no output\""},{"line_number":135,"context_line":"diff -Naur ${TEMPEST_PLUGIN_DIR} ${NEW_PLUGIN_DIR}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"echo \"No differences. Yay! :)\""},{"line_number":138,"context_line":"echo \"Success. We are done!\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_f06166d4","line":137,"in_reply_to":"7f515b1d_705576f9","updated":"2017-10-02 17:43:30.000000000","message":"Whoops, I cut that off:\n\n $ echo $?\n 1","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f7e513e2a181834854899d200643d0b1806a6e57","unresolved":false,"context_lines":[{"line_number":134,"context_line":"echo \"We should have no output\""},{"line_number":135,"context_line":"diff -Naur ${TEMPEST_PLUGIN_DIR} ${NEW_PLUGIN_DIR}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"echo \"No differences. Yay! :)\""},{"line_number":138,"context_line":"echo \"Success. We are done!\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f515b1d_705576f9","line":137,"in_reply_to":"7f515b1d_8f9e1652","updated":"2017-10-02 17:40:47.000000000","message":"Actually no. Line 4 does \"set -e\". Which stops output if an error.\n\n $ diff -u hello hello2 \n --- hello\t2017-10-02 10:39:17.024795162 -0700\n +++ hello2\t2017-10-02 10:39:20.857809104 -0700\n @@ -1 +1 @@\n -hello\n +hello2\n $ echo $?","commit_id":"d22378da76874a282a132af5d7fb4684ad091128"}]}