)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15455aba0dadf2cb85a63cfaceff280ac2b9ade9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to end deployment using standalone ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iba962e8e31c2275cc278ecf06220c66dfdb64a08"},{"line_number":13,"context_line":"Depends on: Idef1bc876fe440824894332a211af9a10401e49c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa0c359_648f3075","line":13,"updated":"2018-02-09 09:52:05.000000000","message":"incorrect syntax, should be Depends-On (note the dash)","commit_id":"08862b87907df55af1d060270635df2504ba6a2c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"328993d69ef0042036bf6677c55c3dd66fa66b53","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to end deployment using standalone ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iba962e8e31c2275cc278ecf06220c66dfdb64a08"},{"line_number":13,"context_line":"Depends on: Idef1bc876fe440824894332a211af9a10401e49c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa0c359_33174ca6","line":13,"in_reply_to":"3fa0c359_648f3075","updated":"2018-02-20 07:45:01.000000000","message":"Done","commit_id":"08862b87907df55af1d060270635df2504ba6a2c"}],"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_basic_ops.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15455aba0dadf2cb85a63cfaceff280ac2b9ade9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":246,"context_line":"    def test_ip_access_to_server(self):"},{"line_number":247,"context_line":"        self.assertTrue(self.ping_ip_address(self.node_ip,"},{"line_number":248,"context_line":"                                             should_succeed\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_848cbc7f","line":248,"updated":"2018-02-09 09:52:05.000000000","message":"could you please add tests using hardware types? they are required starting with Queens","commit_id":"08862b87907df55af1d060270635df2504ba6a2c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"328993d69ef0042036bf6677c55c3dd66fa66b53","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":246,"context_line":"    def test_ip_access_to_server(self):"},{"line_number":247,"context_line":"        self.assertTrue(self.ping_ip_address(self.node_ip,"},{"line_number":248,"context_line":"                                             should_succeed\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_933e6027","line":248,"in_reply_to":"3fa0c359_848cbc7f","updated":"2018-02-20 07:45:01.000000000","message":"Done","commit_id":"08862b87907df55af1d060270635df2504ba6a2c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6bebb88dc4058c2d3702f93868e4bef5c7057d7","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.boot_and_verify_node()"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"class BaremetalIloPxeWholediskHttpLink("},{"line_number":295,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    driver \u003d \u0027ilo\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_2c0b312b","line":294,"updated":"2018-07-06 09:43:42.000000000","message":"This looks identical to BaremetalIloIscsoWholediskHttpLink. Did you mean to set deploy_interface? Also the Iscsi vs Pxe is unclear: the former is a deploy interface, the latter - a boot interface.","commit_id":"058e94118c54322b1a5ed483c8e3fb32c75f8e6c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d7635195fde71865dd5943839ab22ebe90397e3d","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.boot_and_verify_node()"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"class BaremetalIloPxeWholediskHttpLink("},{"line_number":295,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    driver \u003d \u0027ilo\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_993f7221","line":294,"in_reply_to":"5f7c97a3_2c0b312b","updated":"2018-07-16 09:38:15.000000000","message":"Done","commit_id":"058e94118c54322b1a5ed483c8e3fb32c75f8e6c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ecd13e4412230a6bf1087e7ac5b68c3d8500c7a8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.boot_and_verify_node()"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"class BaremetalIloPxeWholediskHttpLink("},{"line_number":295,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    driver \u003d \u0027ilo\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_c06281ad","line":294,"in_reply_to":"5f7c97a3_2c0b312b","updated":"2018-07-06 10:01:17.000000000","message":"Yes, you are right. It should be differentiated based on deploy and boot interfaces. Ilo supports \u0027direct\u0027/\u0027iscsi\u0027 deploy interfaces and \u0027ilo-ilo-virtual-media\u0027/\u0027ilo-pxe\u0027 interfaces. These classes needs to reworked based on the combination of these deploy/boot interfaces.","commit_id":"058e94118c54322b1a5ed483c8e3fb32c75f8e6c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d7635195fde71865dd5943839ab22ebe90397e3d","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.boot_and_verify_node()"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"class BaremetalIloPxeWholediskHttpLink("},{"line_number":295,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    driver \u003d \u0027ilo\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_59131ab8","line":294,"in_reply_to":"5f7c97a3_c06281ad","updated":"2018-07-16 09:38:15.000000000","message":"Done","commit_id":"058e94118c54322b1a5ed483c8e3fb32c75f8e6c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6bebb88dc4058c2d3702f93868e4bef5c7057d7","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        self.boot_and_verify_node()"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"class BaremetalIloPxePartitioned(bsm.BaremetalStandaloneScenarioTest):"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    driver \u003d \u0027ilo\u0027"},{"line_number":311,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_4c08ed2b","line":308,"updated":"2018-07-06 09:43:42.000000000","message":"This looks identical to BaremetalIloIscsiPartitioned. Did you mean to set deploy_interface?","commit_id":"058e94118c54322b1a5ed483c8e3fb32c75f8e6c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"d7635195fde71865dd5943839ab22ebe90397e3d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        self.boot_and_verify_node()"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"class BaremetalIloPxePartitioned(bsm.BaremetalStandaloneScenarioTest):"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    driver \u003d \u0027ilo\u0027"},{"line_number":311,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f909c683","line":308,"in_reply_to":"5f7c97a3_4c08ed2b","updated":"2018-07-16 09:38:15.000000000","message":"Yes, here deploy_interface is direct and boot_interface is ilo-pxe. Whereas for BaremetalIloIscsiPartitioned, deploy_interface is iscsi and boot_interface is ilo-virtual-media. I have made the changes in the next patch.","commit_id":"058e94118c54322b1a5ed483c8e3fb32c75f8e6c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"001340b74c2632cb379dfb880062a331652b9b74","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    api_microversion \u003d \u00271.31\u0027  # to set the deploy_interface"},{"line_number":246,"context_line":"    driver \u003d \u0027ilo\u0027"},{"line_number":247,"context_line":"    deploy_interface \u003d \u0027direct\u0027"},{"line_number":248,"context_line":"    boot_interface \u003d \u0027ilo-virtual-media\u0027"},{"line_number":249,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_url"},{"line_number":250,"context_line":"    image_checksum \u003d CONF.baremetal.whole_disk_image_checksum"},{"line_number":251,"context_line":"    wholedisk_image \u003d True"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_7bf08e93","line":248,"updated":"2018-07-24 08:44:41.000000000","message":"where is support for boot_interface here implemented? I only see bios, deploy and rescue.","commit_id":"aac1015f222470721fdcbb2acb904cb5b5797ab5"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"fd58b02027130e11371f023f431690d5147dd169","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    api_microversion \u003d \u00271.31\u0027  # to set the deploy_interface"},{"line_number":246,"context_line":"    driver \u003d \u0027ilo\u0027"},{"line_number":247,"context_line":"    deploy_interface \u003d \u0027direct\u0027"},{"line_number":248,"context_line":"    boot_interface \u003d \u0027ilo-virtual-media\u0027"},{"line_number":249,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_url"},{"line_number":250,"context_line":"    image_checksum \u003d CONF.baremetal.whole_disk_image_checksum"},{"line_number":251,"context_line":"    wholedisk_image \u003d True"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_1641f663","line":248,"in_reply_to":"5f7c97a3_7bf08e93","updated":"2018-07-26 09:04:42.000000000","message":"Done","commit_id":"aac1015f222470721fdcbb2acb904cb5b5797ab5"}]}