)]}'
{"ironic_tempest_plugin/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"adecc938cbd1210f610135fbcddb72f93ab762be","unresolved":false,"context_lines":[{"line_number":120,"context_line":"               min\u003d0,"},{"line_number":121,"context_line":"               help\u003d\"Ironic adjusted disk size to use in the standalone tests \""},{"line_number":122,"context_line":"                    \"as instance_info/root_gb value.\"),"},{"line_number":123,"context_line":"    cfg.IntOpt(\u0027available_nodes\u0027, min\u003d0, default\u003dNone,"},{"line_number":124,"context_line":"               help\u003d\"The number of baremetal hosts available to use for \""},{"line_number":125,"context_line":"                    \"the tests.\")"},{"line_number":126,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_a4b0d844","line":123,"updated":"2018-02-09 09:51:05.000000000","message":"so \"None\" means the same as \"0\"? I\u0027d change to min\u003d1 to avoid confusion.","commit_id":"c74b274d14331c17272fd9a4e285f9ad1ae7ac4d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d64481859f76f0b05e50462bb71c2323ed871dfc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"               min\u003d0,"},{"line_number":121,"context_line":"               help\u003d\"Ironic adjusted disk size to use in the standalone tests \""},{"line_number":122,"context_line":"                    \"as instance_info/root_gb value.\"),"},{"line_number":123,"context_line":"    cfg.IntOpt(\u0027available_nodes\u0027, min\u003d0, default\u003dNone,"},{"line_number":124,"context_line":"               help\u003d\"The number of baremetal hosts available to use for \""},{"line_number":125,"context_line":"                    \"the tests.\")"},{"line_number":126,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_e4afc07a","line":123,"in_reply_to":"3fa0c359_a4b0d844","updated":"2018-02-09 10:06:49.000000000","message":"\"None\" means its not in the config file, so that we can check if its not specified so it\u0027ll keep working as it does today. Which is different from it being set to 0 in the config which means there are no nodes available.","commit_id":"c74b274d14331c17272fd9a4e285f9ad1ae7ac4d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5125e387ef7e1077324f7bf24d83bbc0f52c9aca","unresolved":false,"context_lines":[{"line_number":120,"context_line":"               min\u003d0,"},{"line_number":121,"context_line":"               help\u003d\"Ironic adjusted disk size to use in the standalone tests \""},{"line_number":122,"context_line":"                    \"as instance_info/root_gb value.\"),"},{"line_number":123,"context_line":"    cfg.IntOpt(\u0027available_nodes\u0027, min\u003d0, default\u003dNone,"},{"line_number":124,"context_line":"               help\u003d\"The number of baremetal hosts available to use for \""},{"line_number":125,"context_line":"                    \"the tests.\")"},{"line_number":126,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_641f30b7","line":123,"in_reply_to":"3fa0c359_e4afc07a","updated":"2018-02-09 10:08:26.000000000","message":"Well, in this patch 0 means the same as None, see my other comment","commit_id":"c74b274d14331c17272fd9a4e285f9ad1ae7ac4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da55db746f1ccd6175894ec88187e1c762dde7e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    \"as instance_info/root_gb value.\"),"},{"line_number":123,"context_line":"    cfg.IntOpt(\u0027available_nodes\u0027, min\u003d0, default\u003dNone,"},{"line_number":124,"context_line":"               help\u003d\"The number of baremetal hosts available to use for \""},{"line_number":125,"context_line":"                    \"the tests.\")"},{"line_number":126,"context_line":"]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"BaremetalFeaturesGroup \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_5509e92e","line":125,"updated":"2018-03-19 13:37:04.000000000","message":"would be good to document what None means.","commit_id":"f31abcc95b1d9abb44536aabc7ebe5ce49426106"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_multitenancy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5125e387ef7e1077324f7bf24d83bbc0f52c9aca","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not CONF.baremetal.use_provision_network:"},{"line_number":45,"context_line":"            msg \u003d \u0027Ironic/Neutron tenant isolation is not configured.\u0027"},{"line_number":46,"context_line":"            raise cls.skipException(msg)"},{"line_number":47,"context_line":"        if (CONF.baremetal.available_nodes and"},{"line_number":48,"context_line":"                CONF.baremetal.available_nodes \u003c 2):"},{"line_number":49,"context_line":"            msg \u003d (\u0027Not enough baremetal nodes, %d configured, test requires \u0027"},{"line_number":50,"context_line":"                   \u0027a minimum of 2\u0027) % CONF.baremetal.available_nodes"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_4480f4c0","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":42},"updated":"2018-02-09 10:08:26.000000000","message":"you probably want `CONF.baremetal.available_nodes is not None`, otherwise you also capture 0 this way","commit_id":"c74b274d14331c17272fd9a4e285f9ad1ae7ac4d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"aa1f4c48693649dd4b382ab0c416294531d2fbed","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not CONF.baremetal.use_provision_network:"},{"line_number":45,"context_line":"            msg \u003d \u0027Ironic/Neutron tenant isolation is not configured.\u0027"},{"line_number":46,"context_line":"            raise cls.skipException(msg)"},{"line_number":47,"context_line":"        if (CONF.baremetal.available_nodes and"},{"line_number":48,"context_line":"                CONF.baremetal.available_nodes \u003c 2):"},{"line_number":49,"context_line":"            msg \u003d (\u0027Not enough baremetal nodes, %d configured, test requires \u0027"},{"line_number":50,"context_line":"                   \u0027a minimum of 2\u0027) % CONF.baremetal.available_nodes"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_5dce5e2d","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":42},"in_reply_to":"3fa0c359_4480f4c0","updated":"2018-02-12 11:11:25.000000000","message":"Done","commit_id":"c74b274d14331c17272fd9a4e285f9ad1ae7ac4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4da55db746f1ccd6175894ec88187e1c762dde7e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not CONF.baremetal.use_provision_network:"},{"line_number":45,"context_line":"            msg \u003d \u0027Ironic/Neutron tenant isolation is not configured.\u0027"},{"line_number":46,"context_line":"            raise cls.skipException(msg)"},{"line_number":47,"context_line":"        if (CONF.baremetal.available_nodes is not None and"},{"line_number":48,"context_line":"                CONF.baremetal.available_nodes \u003c 2):"},{"line_number":49,"context_line":"            msg \u003d (\u0027Not enough baremetal nodes, %d configured, test requires \u0027"},{"line_number":50,"context_line":"                   \u0027a minimum of 2\u0027) % CONF.baremetal.available_nodes"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_b5188584","line":47,"updated":"2018-03-19 13:37:04.000000000","message":"What does None mean? That there are enough nodes so we can do the test?","commit_id":"f31abcc95b1d9abb44536aabc7ebe5ce49426106"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"fcdade55562b198833708937344b789d0110e5ec","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                CONF.baremetal.available_nodes \u003c 2):"},{"line_number":49,"context_line":"            msg \u003d (\u0027Not enough baremetal nodes, %d configured, test requires \u0027"},{"line_number":50,"context_line":"                   \u0027a minimum of 2\u0027) % CONF.baremetal.available_nodes"},{"line_number":51,"context_line":"            raise cls.skipException(msg)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_tenant_network(self, clients, tenant_cidr):"},{"line_number":54,"context_line":"        network \u003d self._create_network("}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_35db3e4f","line":51,"updated":"2018-03-16 13:07:56.000000000","message":"Why do we need this to be a config? Let\u0027s just hit the list nodes API instead, no?","commit_id":"f31abcc95b1d9abb44536aabc7ebe5ce49426106"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e234b001eafbadac756dd6d6e3e5f7f91a9aacda","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                CONF.baremetal.available_nodes \u003c 2):"},{"line_number":49,"context_line":"            msg \u003d (\u0027Not enough baremetal nodes, %d configured, test requires \u0027"},{"line_number":50,"context_line":"                   \u0027a minimum of 2\u0027) % CONF.baremetal.available_nodes"},{"line_number":51,"context_line":"            raise cls.skipException(msg)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_tenant_network(self, clients, tenant_cidr):"},{"line_number":54,"context_line":"        network \u003d self._create_network("}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_589dc2b9","line":51,"in_reply_to":"df7087c5_35db3e4f","updated":"2018-03-16 16:13:00.000000000","message":"I\u0027m kind of on the fence about it, but I feel like there is an argument for not making requests to the service under test when trying to decide whether to run a test for that service.\n\nNova has a similar config option \"min_compute_nodes\" for the minimum number of available compute nodes in the cluster.","commit_id":"f31abcc95b1d9abb44536aabc7ebe5ce49426106"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3206b41e3d5aa96bed43643148ba77ee7a74d9ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                CONF.baremetal.available_nodes \u003c 2):"},{"line_number":49,"context_line":"            msg \u003d (\u0027Not enough baremetal nodes, %d configured, test requires \u0027"},{"line_number":50,"context_line":"                   \u0027a minimum of 2\u0027) % CONF.baremetal.available_nodes"},{"line_number":51,"context_line":"            raise cls.skipException(msg)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_tenant_network(self, clients, tenant_cidr):"},{"line_number":54,"context_line":"        network \u003d self._create_network("}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_8e00f0ac","line":51,"in_reply_to":"df7087c5_589dc2b9","updated":"2018-03-16 17:30:10.000000000","message":"Okay, I guess I\u0027m fine with it.","commit_id":"f31abcc95b1d9abb44536aabc7ebe5ce49426106"}]}