)]}'
{"ironic_tempest_plugin/tests/api/admin/test_nodes.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9190b879498ff323442e89da6998ce2ccf343cca","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"class TestNodeFault(base.BaseBaremetalTest):"},{"line_number":734,"context_line":"    \"\"\"Tests for maintenance_type of baremetal nodes.\"\"\""},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    min_microversion \u003d \u00271.42\u0027"},{"line_number":737,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_1e70ed71","line":734,"updated":"2018-06-11 14:37:27.000000000","message":"maintenance_type?","commit_id":"f8edb71a560dc79a67d12a382b42099cd17dcc7c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"74b1515fb62feb374a81c9ef74552a4e1ec64d0c","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"class TestNodeFault(base.BaseBaremetalTest):"},{"line_number":734,"context_line":"    \"\"\"Tests for maintenance_type of baremetal nodes.\"\"\""},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    min_microversion \u003d \u00271.42\u0027"},{"line_number":737,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_c7684a22","line":734,"in_reply_to":"5f7c97a3_1e70ed71","updated":"2018-06-12 15:43:51.000000000","message":"Done","commit_id":"f8edb71a560dc79a67d12a382b42099cd17dcc7c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"27cb04b9e870ce094e60189e54ac5af9c309a607","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"class TestNodeFault(base.BaseBaremetalTest):"},{"line_number":734,"context_line":"    \"\"\"Tests for maintenance_type of baremetal nodes.\"\"\""},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    min_microversion \u003d \u00271.42\u0027"},{"line_number":737,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_cdd95156","line":734,"in_reply_to":"5f7c97a3_1e70ed71","updated":"2018-06-12 12:18:13.000000000","message":"oh, fox tail showes up..","commit_id":"f8edb71a560dc79a67d12a382b42099cd17dcc7c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9190b879498ff323442e89da6998ce2ccf343cca","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        _, body \u003d self.client.list_nodes()"},{"line_number":752,"context_line":"        self.assertIn(self.node[\u0027uuid\u0027], [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        _, body \u003d self.client.list_nodes(fault\u003d\u0027fake fault\u0027)"},{"line_number":755,"context_line":"        self.assertNotIn(self.node[\u0027uuid\u0027],"},{"line_number":756,"context_line":"                         [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_5eb665fb","line":754,"updated":"2018-06-11 14:37:27.000000000","message":"we really should have the REST API return an error for an invalid fault value. Given that this node is not in any fault, I think we should use a valid value here.","commit_id":"f8edb71a560dc79a67d12a382b42099cd17dcc7c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"74b1515fb62feb374a81c9ef74552a4e1ec64d0c","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        _, body \u003d self.client.list_nodes()"},{"line_number":752,"context_line":"        self.assertIn(self.node[\u0027uuid\u0027], [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        _, body \u003d self.client.list_nodes(fault\u003d\u0027fake fault\u0027)"},{"line_number":755,"context_line":"        self.assertNotIn(self.node[\u0027uuid\u0027],"},{"line_number":756,"context_line":"                         [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_27633e44","line":754,"in_reply_to":"5f7c97a3_5eb665fb","updated":"2018-06-12 15:43:51.000000000","message":"Done","commit_id":"f8edb71a560dc79a67d12a382b42099cd17dcc7c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"27cb04b9e870ce094e60189e54ac5af9c309a607","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        _, body \u003d self.client.list_nodes()"},{"line_number":752,"context_line":"        self.assertIn(self.node[\u0027uuid\u0027], [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        _, body \u003d self.client.list_nodes(fault\u003d\u0027fake fault\u0027)"},{"line_number":755,"context_line":"        self.assertNotIn(self.node[\u0027uuid\u0027],"},{"line_number":756,"context_line":"                         [n[\u0027uuid\u0027] for n in body[\u0027nodes\u0027]])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_6de83dde","line":754,"in_reply_to":"5f7c97a3_5eb665fb","updated":"2018-06-12 12:18:13.000000000","message":"I\u0027m ok with this, it needs a patch to ironic api first.","commit_id":"f8edb71a560dc79a67d12a382b42099cd17dcc7c"}]}