)]}'
{"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_basic_ops.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8df683cf09efada44b7ee6aa69410a51113b558d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    wholedisk_image \u003d False"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    # NOTE(jroll) the ansible deploy interface doesn\u0027t support partition images"},{"line_number":234,"context_line":"    # with netboot mode. Since that\u0027s what is happening here, explicitly choose"},{"line_number":235,"context_line":"    # a deploy interface to be sure we don\u0027t end up with a node using the"},{"line_number":236,"context_line":"    # ansible interface here."},{"line_number":237,"context_line":"    deploy_interface \u003d \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_3406a088","line":234,"updated":"2018-04-17 14:55:37.000000000","message":"I\u0027m not sure that the \"Since that\u0027s what is happening here\u0027 part makes sense to any future reader that doesn\u0027t know we\u0027re trying to fix this bug.\n\nMaybe something like \u0027Explicitly set the deploy...\u0027 is sufficient. The code picks a node that is available (it doesn\u0027t choose a node with that deploy interface), and then sets the node\u0027s interfaces. (Which doesn\u0027t seem to be a good pattern to use in production but maybe in stand-alone case...?)","commit_id":"d2bfdb8d58c8a73435d64492b22a4034ba1a682a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"378e6492a8d578545faa9134143ce5d7bd860eb8","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    wholedisk_image \u003d False"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    # NOTE(jroll) the ansible deploy interface doesn\u0027t support partition images"},{"line_number":234,"context_line":"    # with netboot mode. Since that\u0027s what is happening here, explicitly choose"},{"line_number":235,"context_line":"    # a deploy interface to be sure we don\u0027t end up with a node using the"},{"line_number":236,"context_line":"    # ansible interface here."},{"line_number":237,"context_line":"    deploy_interface \u003d \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_74e418ad","line":234,"in_reply_to":"9f6a8fd7_3406a088","updated":"2018-04-17 14:57:16.000000000","message":"\"Since that\u0027s what is happening here\" was referring to partition mode + netboot. :) I can change it to make it more clear, or drop it.\n\nAnd yes, these aren\u0027t really suitable for production, it\u0027s something we should work on.","commit_id":"d2bfdb8d58c8a73435d64492b22a4034ba1a682a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"989ec48c5c0f10a2e5b336ce3b1f051e7edf7aff","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    wholedisk_image \u003d False"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    # NOTE(jroll) the ansible deploy interface doesn\u0027t support partition images"},{"line_number":234,"context_line":"    # with netboot mode. Since that\u0027s what is happening here, explicitly choose"},{"line_number":235,"context_line":"    # a deploy interface to be sure we don\u0027t end up with a node using the"},{"line_number":236,"context_line":"    # ansible interface here."},{"line_number":237,"context_line":"    deploy_interface \u003d \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_bfdcc974","line":234,"in_reply_to":"9f6a8fd7_74e418ad","updated":"2018-04-17 15:08:31.000000000","message":"Oops, I misunderstood that. Yeah, probably good to change.","commit_id":"d2bfdb8d58c8a73435d64492b22a4034ba1a682a"}]}