)]}'
{"ironic_tempest_plugin/tests/scenario/test_baremetal_single_tenant.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"33fc9ef4d4c95b66dc26a009d51172ff6eca6102","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_9415a89e","line":2,"updated":"2019-04-19 08:03:52.000000000","message":"do  we really need this ?","commit_id":"121861390814f434d68b91718a7c2e8fa3095d5c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a048632ba8bcc9c077bd20206359a307c2adfbee","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def tenancy_check(self, use_vm\u003dFalse):"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            tenant_cidr \u003d \u002710.0.100.0/24\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            keypair \u003d self.create_keypair()"},{"line_number":91,"context_line":"            network, subnet, router \u003d self.create_tenant_network("}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_6c23b357","line":88,"updated":"2019-05-24 09:55:06.000000000","message":"this whole function is overindented","commit_id":"59a60798e7cc3dea366ff6bc23bfc7ce82249bad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c97aa8e6708b68a5b48957f1ef62d525ebee1ba","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    * Delete both instances"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027alt\u0027, \u0027admin\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_5cb3c40a","line":39,"updated":"2019-05-29 06:53:58.000000000","message":"nit: I suspect \u0027alt\u0027 is not needed","commit_id":"40560e3a5c0223f89c6ca39b3bd4d60cbc5b2781"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c97aa8e6708b68a5b48957f1ef62d525ebee1ba","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        subnet \u003d result[\u0027subnet\u0027]"},{"line_number":68,"context_line":"        clients.routers_client.add_router_interface(router[\u0027id\u0027],"},{"line_number":69,"context_line":"                                                    subnet_id\u003dsubnet[\u0027id\u0027])"},{"line_number":70,"context_line":"        self.addCleanup(clients.subnets_client.delete_subnet, subnet[\u0027id\u0027])"},{"line_number":71,"context_line":"        self.addCleanup(clients.routers_client.remove_router_interface,"},{"line_number":72,"context_line":"                        router[\u0027id\u0027], subnet_id\u003dsubnet[\u0027id\u0027])"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_7cb808e4","line":70,"updated":"2019-05-29 06:53:58.000000000","message":"nit: this should go right after creating a subnet","commit_id":"40560e3a5c0223f89c6ca39b3bd4d60cbc5b2781"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c97aa8e6708b68a5b48957f1ef62d525ebee1ba","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if conn_expected:"},{"line_number":85,"context_line":"            self.assertIn(success_substring, output)"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            self.assertNotIn(success_substring, output)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def tenancy_check(self, use_vm\u003dFalse):"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_1cd1cc23","line":87,"updated":"2019-05-29 06:53:58.000000000","message":"nit: this is never hit, maybe drop conn_expected?","commit_id":"40560e3a5c0223f89c6ca39b3bd4d60cbc5b2781"}]}