)]}'
{"id":"openstack%2Fironic-tempest-plugin~656366","triplet_id":"openstack%2Fironic-tempest-plugin~master~I2eaad4c91d9beec7077fb71186713e552afaa11a","project":"openstack/ironic-tempest-plugin","branch":"master","topic":"fix-grep-mountpoint","hashtags":[],"change_id":"I2eaad4c91d9beec7077fb71186713e552afaa11a","subject":"Fixing grep in validate mount point","status":"MERGED","created":"2019-04-29 16:40:44.000000000","updated":"2019-04-30 07:23:39.000000000","submitted":"2019-04-30 07:23:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656366-1556609019501-82ae42cf","meta_rev_id":"957db504db245496860d4a4765cbba2bb913946c","_number":656366,"virtual_id_number":656366,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":2,"date":"2019-04-30 07:23:39.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":2,"date":"2019-04-30 00:56:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-04-30 03:47:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-04-30 03:47:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-30 00:56:43.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2019-04-30 03:47:24.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-04-30 07:23:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a6cde74683ae6635fca6595b82610a1a588f0f80","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-29 16:40:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2153c4d77c3aedded5afe88b6e7ce2e3ed695ac8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 19:51:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/66/656366/1/check/openstack-tox-docs/7456cb6/html/ : SUCCESS in 5m 31s\n- openstack-tox-pep8 http://logs.openstack.org/66/656366/1/check/openstack-tox-pep8/e49a2f5/ : SUCCESS in 5m 21s\n- ironic-standalone http://logs.openstack.org/66/656366/1/check/ironic-standalone/91af75e/ : SUCCESS in 1h 02m 29s\n- ironic-standalone-stein http://logs.openstack.org/66/656366/1/check/ironic-standalone-stein/584e885/ : SUCCESS in 59m 59s\n- ironic-dsvm-standalone-rocky http://logs.openstack.org/66/656366/1/check/ironic-dsvm-standalone-rocky/7e84f40/ : SUCCESS in 47m 48s\n- ironic-dsvm-standalone-queens http://logs.openstack.org/66/656366/1/check/ironic-dsvm-standalone-queens/6c26260/ : FAILURE in 1h 04m 09s (non-voting)\n- ironic-tempest-functional-python3 http://logs.openstack.org/66/656366/1/check/ironic-tempest-functional-python3/65508c7/ : SUCCESS in 25m 02s\n- ironic-tempest-functional-python3-stein http://logs.openstack.org/66/656366/1/check/ironic-tempest-functional-python3-stein/7e0825b/ : SUCCESS in 28m 43s\n- ironic-tempest-dsvm-functional-python3-rocky http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-functional-python3-rocky/250e6ac/ : SUCCESS in 25m 00s\n- ironic-inspector-tempest http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest/8f33966/ : SUCCESS in 52m 16s\n- ironic-inspector-tempest-stein http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-stein/620d485/ : FAILURE in 57m 30s\n- ironic-tempest-dsvm-ironic-inspector-rocky http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ironic-inspector-rocky/c71612f/ : SUCCESS in 40m 18s\n- ironic-tempest-dsvm-ironic-inspector-queens http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ironic-inspector-queens/b4aa440/ : FAILURE in 1h 09m 57s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode http://logs.openstack.org/66/656366/1/check/ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode/7c11035/ : SUCCESS in 1h 30m 48s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-stein http://logs.openstack.org/66/656366/1/check/ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-stein/6ee6645/ : FAILURE in 1h 21m 49s (non-voting)\n- ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-rocky http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-rocky/eab3d14/ : FAILURE in 1h 28m 55s (non-voting)\n- ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-queens http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-queens/44c8d7a/ : FAILURE in 34m 33s (non-voting)\n- ironic-inspector-tempest-discovery http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-discovery/7af88d9/ : SUCCESS in 35m 00s\n- ironic-inspector-tempest-discovery-stein http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-discovery-stein/3a412c9/ : SUCCESS in 35m 11s (non-voting)\n- ironic-inspector-tempest-dsvm-discovery-rocky http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-dsvm-discovery-rocky/e99c6f1/ : SUCCESS in 48m 05s (non-voting)\n- ironic-inspector-tempest-dsvm-discovery-queens http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-dsvm-discovery-queens/031e004/ : SUCCESS in 46m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e840fdce31c72326c8b0393308cd724a0cbe43f8","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2019-04-30 00:56:43.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Riccardo, it makes sense to me (though a rare example for virtual disks :)","accounts_in_message":[],"_revision_number":1},{"id":"1442826488405e992495a32b0a36c618a46e26ca","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-30 03:47:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nrecheck\n\neven in virtual case the higher numbers are sometimes used, I\u0027m not sure why","accounts_in_message":[],"_revision_number":1},{"id":"f33993468c90f8d118c3d2d34e4b3f07f6a3997f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 05:38:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/66/656366/1/check/openstack-tox-docs/5e20a99/html/ : SUCCESS in 5m 16s\n- openstack-tox-pep8 http://logs.openstack.org/66/656366/1/check/openstack-tox-pep8/1f87b07/ : SUCCESS in 5m 12s\n- ironic-standalone http://logs.openstack.org/66/656366/1/check/ironic-standalone/d682f9f/ : SUCCESS in 1h 04m 16s\n- ironic-standalone-stein http://logs.openstack.org/66/656366/1/check/ironic-standalone-stein/1ecf04c/ : SUCCESS in 1h 05m 27s\n- ironic-dsvm-standalone-rocky http://logs.openstack.org/66/656366/1/check/ironic-dsvm-standalone-rocky/2fb21ba/ : SUCCESS in 44m 28s\n- ironic-dsvm-standalone-queens http://logs.openstack.org/66/656366/1/check/ironic-dsvm-standalone-queens/d940b5b/ : FAILURE in 1h 15m 10s (non-voting)\n- ironic-tempest-functional-python3 http://logs.openstack.org/66/656366/1/check/ironic-tempest-functional-python3/0d03ce4/ : SUCCESS in 26m 45s\n- ironic-tempest-functional-python3-stein http://logs.openstack.org/66/656366/1/check/ironic-tempest-functional-python3-stein/2237840/ : SUCCESS in 40m 57s\n- ironic-tempest-dsvm-functional-python3-rocky http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-functional-python3-rocky/ebfb969/ : SUCCESS in 37m 25s\n- ironic-inspector-tempest http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest/68547e6/ : SUCCESS in 1h 02m 58s\n- ironic-inspector-tempest-stein http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-stein/6956908/ : SUCCESS in 50m 55s\n- ironic-tempest-dsvm-ironic-inspector-rocky http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ironic-inspector-rocky/048ab55/ : SUCCESS in 1h 00m 41s\n- ironic-tempest-dsvm-ironic-inspector-queens http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ironic-inspector-queens/9e264b7/ : FAILURE in 1h 06m 09s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode http://logs.openstack.org/66/656366/1/check/ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode/5c5a202/ : SUCCESS in 1h 18m 00s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-stein http://logs.openstack.org/66/656366/1/check/ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-stein/298062a/ : SUCCESS in 1h 27m 34s (non-voting)\n- ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-rocky http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-rocky/3b59e04/ : FAILURE in 1h 37m 37s (non-voting)\n- ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-queens http://logs.openstack.org/66/656366/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-queens/d1decfe/ : FAILURE in 37m 20s (non-voting)\n- ironic-inspector-tempest-discovery http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-discovery/e1b5707/ : SUCCESS in 37m 24s\n- ironic-inspector-tempest-discovery-stein http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-discovery-stein/afca308/ : SUCCESS in 37m 24s (non-voting)\n- ironic-inspector-tempest-dsvm-discovery-rocky http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-dsvm-discovery-rocky/c8ddad7/ : SUCCESS in 38m 06s (non-voting)\n- ironic-inspector-tempest-dsvm-discovery-queens http://logs.openstack.org/66/656366/1/check/ironic-inspector-tempest-dsvm-discovery-queens/ee16cee/ : SUCCESS in 39m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e0f1cbda180a8f034b62ea94e5d16cbd4e7beb92","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 05:38:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7831011674624845d762aaafc40b9384f4c2cb0b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 07:23:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"77225cc58d70acc5307f0c48665cacb5acf14541","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 07:23:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/66/656366/1/gate/openstack-tox-docs/3593b42/html/ : SUCCESS in 3m 45s\n- openstack-tox-pep8 http://logs.openstack.org/66/656366/1/gate/openstack-tox-pep8/3d48cb2/ : SUCCESS in 5m 06s\n- ironic-standalone http://logs.openstack.org/66/656366/1/gate/ironic-standalone/1ef4c72/ : SUCCESS in 51m 19s\n- ironic-standalone-stein http://logs.openstack.org/66/656366/1/gate/ironic-standalone-stein/a3f6f18/ : SUCCESS in 47m 09s\n- ironic-dsvm-standalone-rocky http://logs.openstack.org/66/656366/1/gate/ironic-dsvm-standalone-rocky/46aff85/ : SUCCESS in 50m 09s\n- ironic-tempest-functional-python3 http://logs.openstack.org/66/656366/1/gate/ironic-tempest-functional-python3/70fcaaa/ : SUCCESS in 25m 37s\n- ironic-tempest-functional-python3-stein http://logs.openstack.org/66/656366/1/gate/ironic-tempest-functional-python3-stein/c6ed653/ : SUCCESS in 31m 11s\n- ironic-tempest-dsvm-functional-python3-rocky http://logs.openstack.org/66/656366/1/gate/ironic-tempest-dsvm-functional-python3-rocky/c89fe3c/ : SUCCESS in 25m 34s\n- ironic-inspector-tempest http://logs.openstack.org/66/656366/1/gate/ironic-inspector-tempest/7e71031/ : SUCCESS in 45m 01s\n- ironic-inspector-tempest-stein http://logs.openstack.org/66/656366/1/gate/ironic-inspector-tempest-stein/546a327/ : SUCCESS in 46m 02s\n- ironic-tempest-dsvm-ironic-inspector-rocky http://logs.openstack.org/66/656366/1/gate/ironic-tempest-dsvm-ironic-inspector-rocky/5609b6e/ : SUCCESS in 45m 08s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode http://logs.openstack.org/66/656366/1/gate/ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode/e0f4c6a/ : SUCCESS in 1h 32m 46s\n- ironic-inspector-tempest-discovery http://logs.openstack.org/66/656366/1/gate/ironic-inspector-tempest-discovery/fa501f6/ : SUCCESS in 38m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8cfd0e16f4d7546cf2cf22a3a084817265d269d8","revisions":{"8cfd0e16f4d7546cf2cf22a3a084817265d269d8":{"kind":"REWORK","_number":1,"created":"2019-04-29 16:40:44.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/66/656366/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-tempest-plugin","ref":"refs/changes/66/656366/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/66/656366/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/66/656366/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/66/656366/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/66/656366/1"}}},"commit":{"parents":[{"commit":"70cbfe7f8c7877f9838b037838bca547d3ee3ac5","subject":"Merge \"Add Stein jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-tempest-plugin/commit/70cbfe7f8c7877f9838b037838bca547d3ee3ac5"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-04-29 16:32:04.000000000","tz":120},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-04-29 16:40:41.000000000","tz":120},"subject":"Fixing grep in validate mount point","message":"Fixing grep in validate mount point\n\nWhen we look for the mount point of a labeled partition it can\nhappen that the grep command reports more than one mount point\nbecause the devices start with the same path.\n\nAs an example, let\u0027s consider /dev/vda1, assigned from the\ncommand ``/sbin/blkid | grep \u0027ephemeral0\u0027 | cut -d\u0027:\u0027``\nIf we now call the ``mount`` command and grep for that\ndevice, we actually get 2 different mount point:\nsudo mount | grep \u0027/dev/vda1\u0027 | cut -d\u0027 \u0027 -f1\n/dev/vda1\n/dev/vda15\n\nThis output will make the test fail.\n\nAs a fix, we call the grep command with the -w option that match\nonly entire words:\nsudo mount | grep -w \u0027/dev/vda1\u0027 | cut -d\u0027 \u0027 -f1\n/dev/vda1\n\nChange-Id: I2eaad4c91d9beec7077fb71186713e552afaa11a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-tempest-plugin/commit/8cfd0e16f4d7546cf2cf22a3a084817265d269d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-tempest-plugin/commit/8cfd0e16f4d7546cf2cf22a3a084817265d269d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
