)]}'
{"ironic_tempest_plugin/config.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"d5ac395a3d4b318e52249bb9d8b1d315b96ac2ae","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    cfg.StrOpt(\u0027auto_discovery_target_driver\u0027,"},{"line_number":199,"context_line":"               help\u003d\"The driver to set on the newly discovered nodes. \""},{"line_number":200,"context_line":"                    \"Only has effect with auto_discovery_feature is True.\"),"},{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               help\u003d\"The storage backend for storing introspection data. \""},{"line_number":203,"context_line":"                    \"We can use database or swift.\"),"},{"line_number":204,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_8a6ff590","line":201,"updated":"2019-05-10 02:31:24.000000000","message":"can we have a default value to \u0027swift\u0027 here?","commit_id":"339244ea1299b119fd7d35de028929000b5d24ac"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"44a14251185af8ac17fb7361ae5b6e44fbe16520","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    cfg.StrOpt(\u0027auto_discovery_target_driver\u0027,"},{"line_number":199,"context_line":"               help\u003d\"The driver to set on the newly discovered nodes. \""},{"line_number":200,"context_line":"                    \"Only has effect with auto_discovery_feature is True.\"),"},{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               help\u003d\"The storage backend for storing introspection data. \""},{"line_number":203,"context_line":"                    \"We can use database or swift.\"),"},{"line_number":204,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_8a793530","line":201,"in_reply_to":"dfbec78f_8a6ff590","updated":"2019-05-10 02:41:07.000000000","message":"Good idea.","commit_id":"339244ea1299b119fd7d35de028929000b5d24ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e0264aca1dc26b3655980521285b36271a8aec2b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               default\u003d\u0027swift\u0027,"},{"line_number":203,"context_line":"               help\u003d\"The storage backend for storing introspection data. \""},{"line_number":204,"context_line":"                    \"We can use database or swift.\"),"},{"line_number":205,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_c40c013d","line":204,"updated":"2019-05-10 07:07:19.000000000","message":"nit: I\u0027d remove the 2nd sentence, especially since it does not mention \"none\"","commit_id":"51b902e90d2363a15cd0e68f0331eaefece441f4"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a3ed40047f9441787c634bf55aa642473ec7732b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               default\u003d\u0027swift\u0027,"},{"line_number":203,"context_line":"               help\u003d\"The storage backend for storing introspection data. \""},{"line_number":204,"context_line":"                    \"We can use database or swift.\"),"},{"line_number":205,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_64419539","line":204,"in_reply_to":"dfbec78f_c40c013d","updated":"2019-05-10 07:11:18.000000000","message":"Done","commit_id":"51b902e90d2363a15cd0e68f0331eaefece441f4"}],"ironic_tempest_plugin/tests/scenario/test_introspection_basic.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"d5ac395a3d4b318e52249bb9d8b1d315b96ac2ae","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            node \u003d self.node_show(node_id)"},{"line_number":96,"context_line":"            self.assertEqual(\u0027yes\u0027, node[\u0027extra\u0027][\u0027rule_success\u0027])"},{"line_number":97,"context_line":"            if (CONF.baremetal_introspection.data_store \u003d\u003d \"database\" or"},{"line_number":98,"context_line":"                CONF.service_available.swift):"},{"line_number":99,"context_line":"                self.verify_node_introspection_data(node)"},{"line_number":100,"context_line":"            self.verify_node_flavor(node)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_2a0369ba","line":98,"updated":"2019-05-10 02:31:24.000000000","message":"we can check like this:\n\n  if CONF.baremetal_introspection.data_store !\u003d \u0027none\u0027:\n      self.verify_node_intropection_data(node)\n\nobject service is available when introspection data is set to swift, this should be guaranteed by our job settings.","commit_id":"339244ea1299b119fd7d35de028929000b5d24ac"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"44a14251185af8ac17fb7361ae5b6e44fbe16520","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            node \u003d self.node_show(node_id)"},{"line_number":96,"context_line":"            self.assertEqual(\u0027yes\u0027, node[\u0027extra\u0027][\u0027rule_success\u0027])"},{"line_number":97,"context_line":"            if (CONF.baremetal_introspection.data_store \u003d\u003d \"database\" or"},{"line_number":98,"context_line":"                CONF.service_available.swift):"},{"line_number":99,"context_line":"                self.verify_node_introspection_data(node)"},{"line_number":100,"context_line":"            self.verify_node_flavor(node)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_2a784928","line":98,"in_reply_to":"dfbec78f_2a0369ba","updated":"2019-05-10 02:41:07.000000000","message":"Done","commit_id":"339244ea1299b119fd7d35de028929000b5d24ac"}]}