)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a68d20594466d84583c21b0adfb6865c7897d6d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of gate job, like ironic-inspector-tempest-dsvm-python3 doesn\u0027t"},{"line_number":10,"context_line":"support data stores in Swift[1]. If use swift as tempest default"},{"line_number":11,"context_line":"config, it will breaks that stable branch gate job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://github.com/openstack/ironic-inspector/blob/stable/rocky/devstack/plugin.sh#L271-L273"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_11be1565","line":11,"updated":"2019-05-21 10:33:43.000000000","message":"It should be handled per job per branch, not here IMO. This change may cause regression in test coverage.","commit_id":"4810d5d93ddc0de834f27d37e3ff80a1336f125d"}],"ironic_tempest_plugin/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9c4018c8637cf0b540f7785692c9b5802491c836","unresolved":false,"context_lines":[{"line_number":199,"context_line":"               help\u003d\"The driver to set on the newly discovered nodes. \""},{"line_number":200,"context_line":"                    \"Only has effect with auto_discovery_feature is True.\"),"},{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               default\u003d\u0027none\u0027,"},{"line_number":203,"context_line":"               help\u003d\"The storage backend for storing introspection data.\"),"},{"line_number":204,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_f13fc1d3","line":202,"updated":"2019-05-21 10:40:24.000000000","message":"I think the best way to fix the current breakage is to set this to None and use service_enabled.swift as previously.","commit_id":"4810d5d93ddc0de834f27d37e3ff80a1336f125d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"df2e044da2633cee74319fc096092b6aad98182a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"               help\u003d\"The driver to set on the newly discovered nodes. \""},{"line_number":200,"context_line":"                    \"Only has effect with auto_discovery_feature is True.\"),"},{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               default\u003d\u0027none\u0027,"},{"line_number":203,"context_line":"               help\u003d\"The storage backend for storing introspection data.\"),"},{"line_number":204,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_0cffde01","line":202,"updated":"2019-05-21 10:42:10.000000000","message":"Sorry, I realized my previous comment was too short. We can set this to None by default. Then if it is None, we can fall back to whether Swift is enabled (as it was before). If it is not None, we can use the provided value.","commit_id":"4810d5d93ddc0de834f27d37e3ff80a1336f125d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3905b5884a74e379c5183fa0a87617befec31293","unresolved":false,"context_lines":[{"line_number":199,"context_line":"               help\u003d\"The driver to set on the newly discovered nodes. \""},{"line_number":200,"context_line":"                    \"Only has effect with auto_discovery_feature is True.\"),"},{"line_number":201,"context_line":"    cfg.StrOpt(\u0027data_store\u0027,"},{"line_number":202,"context_line":"               default\u003d\u0027none\u0027,"},{"line_number":203,"context_line":"               help\u003d\"The storage backend for storing introspection data.\"),"},{"line_number":204,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_8c3e6e27","line":202,"updated":"2019-05-21 11:11:54.000000000","message":"Let\u0027s remove this line completely, see the other file for explanation.","commit_id":"d145f584c054cff5dcfd1c1b1b96bec0e16436f2"}],"ironic_tempest_plugin/tests/scenario/test_introspection_basic.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3905b5884a74e379c5183fa0a87617befec31293","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            node \u003d self.node_show(node_id)"},{"line_number":96,"context_line":"            self.assertEqual(\u0027yes\u0027, node[\u0027extra\u0027][\u0027rule_success\u0027])"},{"line_number":97,"context_line":"            if (CONF.baremetal_introspection.data_store !\u003d \"none\""},{"line_number":98,"context_line":"                or CONF.service_available.swift):"},{"line_number":99,"context_line":"                self.verify_node_introspection_data(node)"},{"line_number":100,"context_line":"            self.verify_node_flavor(node)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_ac3b3236","line":98,"updated":"2019-05-21 11:11:54.000000000","message":"What I meant is rather:\n\n data_store \u003d CONF.baremetal_introspection.data_store\n if data_store is None:\n     # Backward compatibility, the option is not set.\n     data_store \u003d \u0027swift\u0027 if CONF.service_available.swift else \u0027none\u0027\n if data_store !\u003d \u0027none\u0027:\n     self.verify_node_introspection_data(node)","commit_id":"d145f584c054cff5dcfd1c1b1b96bec0e16436f2"}]}