)]}'
{"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_cleaning.py":[{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"99fea42993561f2356ccbb54537134a94e90ddaa","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        {"},{"line_number":95,"context_line":"            \"interface\": \"raid\","},{"line_number":96,"context_line":"            \"step\": \"delete_configuration\""},{"line_number":97,"context_line":"        },"},{"line_number":98,"context_line":"        {"},{"line_number":99,"context_line":"            \"interface\": \"raid\","},{"line_number":100,"context_line":"            \"step\": \"create_configuration\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8f1e9db9","line":97,"updated":"2019-08-07 09:17:36.000000000","message":"May be there misses the following step, between both to make sure it can be replayed safely:\n\nsome step that calls the agent command\n\n{\n    \"name\": \"clean.execute_clean_step\",\n    \"params\": {\n        \"step\": {\n            \"step\": \"erase_devices_metadata\"\n        },\n        \"node\": {\n            \"uuid\": \"hello\",\n            \"properties\": {\n                \"root_device\": {\"name\": \"/dev/whatever\"}\n            }\n        },\n        \"ports\": []\n    }\n}\n\nOtherwise create_configuration could find some pre existing partitioning on devices and fail, no ?","commit_id":"280b7f4ebc4009189c5cdcb7ab4792f43ef8764d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"195e07dd9a563b9fe01c65dc7a281797eedb08bb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        {"},{"line_number":95,"context_line":"            \"interface\": \"raid\","},{"line_number":96,"context_line":"            \"step\": \"delete_configuration\""},{"line_number":97,"context_line":"        },"},{"line_number":98,"context_line":"        {"},{"line_number":99,"context_line":"            \"interface\": \"raid\","},{"line_number":100,"context_line":"            \"step\": \"create_configuration\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4f5f4575","line":97,"in_reply_to":"7faddb67_8f1e9db9","updated":"2019-08-07 09:19:49.000000000","message":"yeah, probably worth doing","commit_id":"280b7f4ebc4009189c5cdcb7ab4792f43ef8764d"}]}