)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1eb761cd3c0455e3f1d7b5b2c7f3b57aa94c6b78","unresolved":false,"context_lines":[{"line_number":17,"context_line":"image usage. This is ultimately required to enable ironic to"},{"line_number":18,"context_line":"change the underlying default boot_option netboot to local."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Also hard coded boot_option to local for RAID tests as support"},{"line_number":21,"context_line":"is only for wholedisk images."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Story: #1619339"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_0cb6d78b","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":29},"updated":"2019-08-28 15:43:16.000000000","message":"Did it actually happen?","commit_id":"e9caba280687d49cb6b167bc1ceeda4a870879f9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"af5b5b3a00e1218c5d5a30e34fbc3c5697cb1890","unresolved":false,"context_lines":[{"line_number":17,"context_line":"image usage. This is ultimately required to enable ironic to"},{"line_number":18,"context_line":"change the underlying default boot_option netboot to local."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Also hard coded boot_option to local for RAID tests as support"},{"line_number":21,"context_line":"is only for wholedisk images."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Story: #1619339"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_1c2cc648","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":29},"in_reply_to":"7faddb67_0cb6d78b","updated":"2019-08-28 18:08:49.000000000","message":"No, I ripped them out in the last patch set and forgot to fix this. There _seems_ to be a bug in the raid code :\\\n\nThey _likely_ should have it hard coded though. Truthfully, all of our tests should have it coded if they vary.","commit_id":"e9caba280687d49cb6b167bc1ceeda4a870879f9"}],"ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"4235a9f9993f6c7b7b09b020d34d33d8fbfccbc5","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if boot_option:"},{"line_number":265,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/capabilities\u0027,"},{"line_number":266,"context_line":"                          \u0027op\u0027: \u0027add\u0027,"},{"line_number":267,"context_line":"                          \u0027value\u0027: {\u0027boot_option\u0027: boot_option}})"},{"line_number":268,"context_line":"        # TODO(vsaienko) add testing for custom configdrive"},{"line_number":269,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], patch\u003dpatch)"},{"line_number":270,"context_line":"        cls.set_node_provision_state(cls.node[\u0027uuid\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_55a8611e","line":267,"updated":"2019-11-01 08:30:07.000000000","message":"is it safe to overwrite this field? I thought we should append the option to the existing value.","commit_id":"cd85f209ac7fda775cad4361d4bf770215d88d24"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"57632bbfb39f091f4024e6fbc861473af73b5c59","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if boot_option:"},{"line_number":265,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/capabilities\u0027,"},{"line_number":266,"context_line":"                          \u0027op\u0027: \u0027add\u0027,"},{"line_number":267,"context_line":"                          \u0027value\u0027: {\u0027boot_option\u0027: boot_option}})"},{"line_number":268,"context_line":"        # TODO(vsaienko) add testing for custom configdrive"},{"line_number":269,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], patch\u003dpatch)"},{"line_number":270,"context_line":"        cls.set_node_provision_state(cls.node[\u0027uuid\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_9795ef8a","line":267,"in_reply_to":"3fa7e38b_2ade173e","updated":"2019-11-14 07:30:05.000000000","message":"I was thinking about boot_mode, because we use this field to generate pxe configuration files. Suppose we want to uefi boot the machine, while this code will remove the field and default mode will be used which is legacy mode.\nIt seems an issue for real machines, but I am not sure if it applies to current tests though.","commit_id":"cd85f209ac7fda775cad4361d4bf770215d88d24"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1b98b27f57f511c6f3afb33dc6589d8398927f0b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if boot_option:"},{"line_number":265,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/capabilities\u0027,"},{"line_number":266,"context_line":"                          \u0027op\u0027: \u0027add\u0027,"},{"line_number":267,"context_line":"                          \u0027value\u0027: {\u0027boot_option\u0027: boot_option}})"},{"line_number":268,"context_line":"        # TODO(vsaienko) add testing for custom configdrive"},{"line_number":269,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], patch\u003dpatch)"},{"line_number":270,"context_line":"        cls.set_node_provision_state(cls.node[\u0027uuid\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_2ade173e","line":267,"in_reply_to":"3fa7e38b_55a8611e","updated":"2019-11-14 03:23:05.000000000","message":"It is the choice/preference of the instance being requested, so I think it is safe for us to append the option in for addition.","commit_id":"cd85f209ac7fda775cad4361d4bf770215d88d24"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e456a5c1575ba4b8eae4fba96bba20f793c04560","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if boot_option:"},{"line_number":265,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/capabilities\u0027,"},{"line_number":266,"context_line":"                          \u0027op\u0027: \u0027add\u0027,"},{"line_number":267,"context_line":"                          \u0027value\u0027: {\u0027boot_option\u0027: boot_option}})"},{"line_number":268,"context_line":"        # TODO(vsaienko) add testing for custom configdrive"},{"line_number":269,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], patch\u003dpatch)"},{"line_number":270,"context_line":"        cls.set_node_provision_state(cls.node[\u0027uuid\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_cea3909a","line":267,"in_reply_to":"3fa7e38b_9795ef8a","updated":"2019-11-19 23:36:26.000000000","message":"It is inside the instance info field which should be wiped on undeploy.\n\nSo on a real machine, yes, it could change the mode, but the tests ideally should be declaring the boot_option/boot_mode for each test... but ultimately I\u0027m just trying to fix the software raid tests so we can change the default boot option as we don\u0027t define it explicitly and software raid requires local boot.","commit_id":"cd85f209ac7fda775cad4361d4bf770215d88d24"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"27692aa44bc9a811e3afecbf8dae37210985eb59","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        if boot_option:"},{"line_number":265,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/capabilities\u0027,"},{"line_number":266,"context_line":"                          \u0027op\u0027: \u0027add\u0027,"},{"line_number":267,"context_line":"                          \u0027value\u0027: {\u0027boot_option\u0027: boot_option}})"},{"line_number":268,"context_line":"        # TODO(vsaienko) add testing for custom configdrive"},{"line_number":269,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], patch\u003dpatch)"},{"line_number":270,"context_line":"        cls.set_node_provision_state(cls.node[\u0027uuid\u0027], \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_c9e70a0f","line":267,"in_reply_to":"3fa7e38b_cea3909a","updated":"2019-11-20 01:57:10.000000000","message":"thanks for clarification.","commit_id":"cd85f209ac7fda775cad4361d4bf770215d88d24"}]}