)]}'
{"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b92f638f20d2629565f036c769204464cd5e6869","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self.get_remote_client(server_ip)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"class BaremetalBootModeScenario(BaremetalScenarioTest):"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":283,"context_line":"    min_microversion \u003d \u00271.28\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c506ddce","line":280,"updated":"2020-06-22 09:10:37.000000000","message":"I assume this code was largely copied from test_baremetal_basic_ops? I think it should removed from there now to avoid duplication and slight differences.","commit_id":"a4756d629b75e7578e2b2987cd758f4c4c8f3065"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f0515303e8e81f7023c3a81859cbe5003ffe18a2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self.wait_node(instance[\u0027id\u0027])"},{"line_number":254,"context_line":"        node \u003d self.get_node(instance_id\u003dinstance[\u0027id\u0027])"},{"line_number":255,"context_line":"        if boot_mode \u003d\u003d \"uefi\":"},{"line_number":256,"context_line":"            patch \u003d [{\u0027path\u0027: \u0027/instance_info/capabilities\u0027,"},{"line_number":257,"context_line":"                      \u0027op\u0027: \u0027add\u0027,"},{"line_number":258,"context_line":"                      \u0027value\u0027: {\u0027boot_mode\u0027: \u0027uefi\u0027}}]"},{"line_number":259,"context_line":"            self.update_node(node[\u0027uuid\u0027], patch)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        self.wait_power_state(node[\u0027uuid\u0027], BaremetalPowerStates.POWER_ON)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_32c332ef","line":258,"range":{"start_line":256,"start_character":0,"end_line":258,"end_character":54},"updated":"2020-06-29 10:00:15.000000000","message":"I don\u0027t think we interpret boot_mode in instance_info/capabilities, the value from properties is used instead and is set by devstack.","commit_id":"d8b9e33235ad627ccb5867f97ba6310f5dcefb4b"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5d0571354ee68291f2cc09d881b12d651fd5be4","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        self.wholedisk_image \u003d True"},{"line_number":237,"context_line":"        self.baremetal_server_ops()"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"class BaremetalBasicOpsAndRescue(BaremetalBasicOps):"},{"line_number":240,"context_line":"    \"\"\"This test includes rescue/unrescue ops.\"\"\""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    TEST_RESCUE_MODE \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_93878b10","line":239,"updated":"2020-06-30 16:02:49.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"6b2c5686e6d582d51e6c374e5002728f9fd89725"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6329683e8ad9a2fff7417a547099db07d3d46446","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    TEST_RESCUE_MODE \u003d False"},{"line_number":51,"context_line":"    image_ref \u003d None"},{"line_number":52,"context_line":"    wholedisk_image \u003d None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_00c6434a","line":52,"updated":"2020-07-06 08:14:05.000000000","message":"Is it used anywhere?","commit_id":"d180a3ef76a332f059f420889fb19ddd2695f4f1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"33d559329d276b77de811ea7962676d455f0843c","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    TEST_RESCUE_MODE \u003d False"},{"line_number":51,"context_line":"    image_ref \u003d None"},{"line_number":52,"context_line":"    wholedisk_image \u003d None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_bce16d2d","line":52,"in_reply_to":"bf51134e_00c6434a","updated":"2020-07-07 07:31:26.000000000","message":"Yes, L229 and L236","commit_id":"d180a3ef76a332f059f420889fb19ddd2695f4f1"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_bootmode.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"248a5aace9c5ce5fe690343f4736c8ab38b52707","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.validate_ports()"},{"line_number":56,"context_line":"        self.validate_scheduling()"},{"line_number":57,"context_line":"        ip_address \u003d self.get_server_ip(self.instance)"},{"line_number":58,"context_line":"        self.get_remote_client(ip_address)"},{"line_number":59,"context_line":"        self.terminate_instance(self.instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0923e0a9","line":58,"updated":"2020-06-19 21:52:16.000000000","message":"I wonder if we should be logging in and checking boot mode?","commit_id":"a4756d629b75e7578e2b2987cd758f4c4c8f3065"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b92f638f20d2629565f036c769204464cd5e6869","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.validate_ports()"},{"line_number":56,"context_line":"        self.validate_scheduling()"},{"line_number":57,"context_line":"        ip_address \u003d self.get_server_ip(self.instance)"},{"line_number":58,"context_line":"        self.get_remote_client(ip_address)"},{"line_number":59,"context_line":"        self.terminate_instance(self.instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a50be9d3","line":58,"updated":"2020-06-22 09:10:37.000000000","message":"You can check for /sys/firmware/efi presence.","commit_id":"a4756d629b75e7578e2b2987cd758f4c4c8f3065"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5fbe622a4c189df843de3634cb7040b935125569","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.validate_ports()"},{"line_number":56,"context_line":"        self.validate_scheduling()"},{"line_number":57,"context_line":"        ip_address \u003d self.get_server_ip(self.instance)"},{"line_number":58,"context_line":"        self.get_remote_client(ip_address)"},{"line_number":59,"context_line":"        self.terminate_instance(self.instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e5f5e1ee","line":58,"in_reply_to":"bf51134e_0923e0a9","updated":"2020-06-22 09:05:42.000000000","message":"tbh I didn\u0027t think about this, I can give a try to check the boot mode inside the instance","commit_id":"a4756d629b75e7578e2b2987cd758f4c4c8f3065"}]}