)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22dce4041912d38ab430f5a2c161c731bdbb29d0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Iury Gregory Melo Ferreira \u003cimelofer@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-16 21:51:56 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update basic_ops"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to initialize the image_ref otherwise the default from"},{"line_number":10,"context_line":"`CONF.compute.image_ref` will be used, causing both tests to use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"20e6482c_1305a4d5","line":7,"updated":"2021-02-15 13:55:01.000000000","message":"Iury, I\u0027m not sure to what end your seeking to reach with this change, since you seem to be making changes heading in multiple different directions.","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1f2db01915d4471ab85cea190bd2193515d96588","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Iury Gregory Melo Ferreira \u003cimelofer@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-16 21:51:56 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update basic_ops"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to initialize the image_ref otherwise the default from"},{"line_number":10,"context_line":"`CONF.compute.image_ref` will be used, causing both tests to use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"faacbdb1_74dff45a","line":7,"in_reply_to":"20e6482c_1305a4d5","updated":"2021-02-21 14:59:59.000000000","message":"My idea was to be able to test Partition/Wholedisk images on the same jobs (also be able to test when rescue is enable), maybe I don\u0027t need to worry about the boot_option it will use for the test.","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22dce4041912d38ab430f5a2c161c731bdbb29d0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"same type of image."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Created a class to each type of image (wholediks/partition) and the"},{"line_number":14,"context_line":"equivalent classes for Rescue"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Added a new option to set the boot_option for the nodes."},{"line_number":17,"context_line":"Added two new configs that allow us to set flavors with local/netboot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"adffdc10_1e8a7702","line":14,"updated":"2021-02-15 13:55:01.000000000","message":"I guess this makes sense","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22dce4041912d38ab430f5a2c161c731bdbb29d0","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Added a new option to set the boot_option for the nodes."},{"line_number":17,"context_line":"Added two new configs that allow us to set flavors with local/netboot"},{"line_number":18,"context_line":"boot_option set."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I446a1701d0de27eebc2ee8ea617d3c7e7466d794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"88f4ba95_e82c412e","line":18,"updated":"2021-02-15 13:55:01.000000000","message":"Do we really want to give people the ability to choose or do we want to focus in one direction? We also have ramdisk as a possibility if the ramdisk deploy interface is in use, but I\u0027m not sure this is something we shoudl be exposing as a external test point. I also don\u0027t know if we really need to test the old netboot all the things logic as the ironic community has been moving away from that for a long time.","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1f2db01915d4471ab85cea190bd2193515d96588","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Added a new option to set the boot_option for the nodes."},{"line_number":17,"context_line":"Added two new configs that allow us to set flavors with local/netboot"},{"line_number":18,"context_line":"boot_option set."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I446a1701d0de27eebc2ee8ea617d3c7e7466d794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"fdb88719_cfd36259","line":18,"in_reply_to":"88f4ba95_e82c412e","updated":"2021-02-21 14:59:59.000000000","message":"So maybe we just use what is set from the ironic config? I think it would make sense.","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c964302efaa55cb7f4deb9a0fe367ce362d3373a","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Added a new option to set the boot_option for the nodes."},{"line_number":17,"context_line":"Added two new configs that allow us to set flavors with local/netboot"},{"line_number":18,"context_line":"boot_option set."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I446a1701d0de27eebc2ee8ea617d3c7e7466d794"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"d2a61be6_6aa8aca0","line":18,"in_reply_to":"fdb88719_cfd36259","updated":"2021-03-22 16:15:38.000000000","message":"I\u0027d prefer they just set the ironic config, but I\u0027ve also been hoping to kind of eliminate network boot as a default thing.","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"}],"ironic_tempest_plugin/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":159,"context_line":"               choices\u003d[\u0027local\u0027, \u0027netboot\u0027],"},{"line_number":160,"context_line":"               help\u003d\"The default boot option to be used on testing nodes.\"),"},{"line_number":161,"context_line":"    cfg.BoolOpt(\u0027vm_use_flavor_ref\u0027,"},{"line_number":162,"context_line":"                default\u003dTrue,"},{"line_number":163,"context_line":"                help\u003d\"If multitenancy tests should use the value from \""},{"line_number":164,"context_line":"                     \"`[compute]/flavor_ref` as the flavor for the VM.\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_909c256b","line":161,"updated":"2020-08-03 08:20:01.000000000","message":"nit: what does \"vm\" mean here?","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ccd260c227e7111e179d2d94984d424f6ed7fd1c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               default\u003d\u0027local\u0027,"},{"line_number":159,"context_line":"               choices\u003d[\u0027local\u0027, \u0027netboot\u0027],"},{"line_number":160,"context_line":"               help\u003d\"The default boot option to be used on testing nodes.\"),"},{"line_number":161,"context_line":"    cfg.BoolOpt(\u0027vm_use_flavor_ref\u0027,"},{"line_number":162,"context_line":"                default\u003dTrue,"},{"line_number":163,"context_line":"                help\u003d\"If multitenancy tests should use the value from \""},{"line_number":164,"context_line":"                     \"`[compute]/flavor_ref` as the flavor for the VM.\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_0431bca3","line":161,"in_reply_to":"9f560f44_909c256b","updated":"2020-08-06 21:57:34.000000000","message":"the multinode test can use vm and normally we were using the flavor_ref, this would be just to keep backward compatibility.","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"}],"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"93263ff83f499fec67d833b355a05d69bb5e6678","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        dest.validate_authentication()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def boot_instance(self, clients\u003dNone, keypair\u003dNone,"},{"line_number":173,"context_line":"                      net_id\u003dNone, fixed_ip\u003dNone, **create_kwargs):"},{"line_number":174,"context_line":"        if clients is None:"},{"line_number":175,"context_line":"            servers_client \u003d self.servers_client"},{"line_number":176,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_9857aacb","line":173,"updated":"2020-07-17 13:49:13.000000000","message":"please make boot_option a normal argument, otherwise it get passed all the way up to nova","commit_id":"d0b755b72e4aa17f31e92ff0e3f71cb2889c2c86"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"db3e6e0802e7e87ba4ce683cc149bff6aee24b26","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            keypair \u003d self.keypair"},{"line_number":181,"context_line":"        if boot_option is None:"},{"line_number":182,"context_line":"            boot_option \u003d CONF.baremetal.default_boot_option"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if any([net_id, fixed_ip]):"},{"line_number":185,"context_line":"            network \u003d {}"},{"line_number":186,"context_line":"            if net_id:"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f560f44_8f3b89c6","line":183,"updated":"2020-08-18 21:55:50.000000000","message":"3.) the cap need to be set here at the latests or nova willl not find a suitable host and the instance create will fail.","commit_id":"23adec07f1d5998951fe841cd68989c6d85f7d98"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f6ab4754d0acad9a9538c920bd22849f461576e9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                network[\u0027uuid\u0027] \u003d net_id"},{"line_number":188,"context_line":"            if fixed_ip:"},{"line_number":189,"context_line":"                network[\u0027fixed_ip\u0027] \u003d fixed_ip"},{"line_number":190,"context_line":"            instance \u003d self.create_server("},{"line_number":191,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":192,"context_line":"                networks\u003d[network],"},{"line_number":193,"context_line":"                clients\u003dclients,"},{"line_number":194,"context_line":"                **create_kwargs"},{"line_number":195,"context_line":"            )"},{"line_number":196,"context_line":"        else:"},{"line_number":197,"context_line":"            instance \u003d self.create_server("},{"line_number":198,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":199,"context_line":"                clients\u003dclients,"},{"line_number":200,"context_line":"                **create_kwargs"},{"line_number":201,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f560f44_4f0cd13a","line":198,"range":{"start_line":190,"start_character":1,"end_line":198,"end_character":41},"updated":"2020-08-18 21:52:38.000000000","message":"This is where your failing... your never getting to 205.","commit_id":"23adec07f1d5998951fe841cd68989c6d85f7d98"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"db3e6e0802e7e87ba4ce683cc149bff6aee24b26","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                network[\u0027uuid\u0027] \u003d net_id"},{"line_number":188,"context_line":"            if fixed_ip:"},{"line_number":189,"context_line":"                network[\u0027fixed_ip\u0027] \u003d fixed_ip"},{"line_number":190,"context_line":"            instance \u003d self.create_server("},{"line_number":191,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":192,"context_line":"                networks\u003d[network],"},{"line_number":193,"context_line":"                clients\u003dclients,"},{"line_number":194,"context_line":"                **create_kwargs"},{"line_number":195,"context_line":"            )"},{"line_number":196,"context_line":"        else:"},{"line_number":197,"context_line":"            instance \u003d self.create_server("},{"line_number":198,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":199,"context_line":"                clients\u003dclients,"},{"line_number":200,"context_line":"                **create_kwargs"},{"line_number":201,"context_line":"            )"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.wait_node(instance[\u0027id\u0027])"},{"line_number":204,"context_line":"        node \u003d self.get_node(instance_id\u003dinstance[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"9f560f44_4f5a112a","line":201,"range":{"start_line":190,"start_character":0,"end_line":201,"end_character":13},"updated":"2020-08-18 21:55:50.000000000","message":"2.) given the instance is created here invoking nova","commit_id":"23adec07f1d5998951fe841cd68989c6d85f7d98"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"db3e6e0802e7e87ba4ce683cc149bff6aee24b26","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.wait_node(instance[\u0027id\u0027])"},{"line_number":204,"context_line":"        node \u003d self.get_node(instance_id\u003dinstance[\u0027id\u0027])"},{"line_number":205,"context_line":"        if set_capabilities:"},{"line_number":206,"context_line":"            meta \u003d {\u0027boot_option\u0027: boot_option}"},{"line_number":207,"context_line":"            servers_client.set_server_metadata(instance[\u0027id\u0027], meta)"},{"line_number":208,"context_line":"            patch \u003d [{\u0027path\u0027: \u0027/properties/capabilities\u0027,"},{"line_number":209,"context_line":"                      \u0027op\u0027: \u0027add\u0027,"},{"line_number":210,"context_line":"                      \u0027value\u0027: {\u0027boot_option\u0027: boot_option}}]"},{"line_number":211,"context_line":"            self.update_node(node[\u0027uuid\u0027], patch)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.wait_power_state(node[\u0027uuid\u0027], BaremetalPowerStates.POWER_ON)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f560f44_0f50190a","line":211,"range":{"start_line":205,"start_character":5,"end_line":211,"end_character":49},"updated":"2020-08-18 21:55:50.000000000","message":"1.) this needs to be set before the instance is launchged","commit_id":"23adec07f1d5998951fe841cd68989c6d85f7d98"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f6ab4754d0acad9a9538c920bd22849f461576e9","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.wait_node(instance[\u0027id\u0027])"},{"line_number":204,"context_line":"        node \u003d self.get_node(instance_id\u003dinstance[\u0027id\u0027])"},{"line_number":205,"context_line":"        if set_capabilities:"},{"line_number":206,"context_line":"            meta \u003d {\u0027boot_option\u0027: boot_option}"},{"line_number":207,"context_line":"            servers_client.set_server_metadata(instance[\u0027id\u0027], meta)"},{"line_number":208,"context_line":"            patch \u003d [{\u0027path\u0027: \u0027/properties/capabilities\u0027,"},{"line_number":209,"context_line":"                      \u0027op\u0027: \u0027add\u0027,"},{"line_number":210,"context_line":"                      \u0027value\u0027: {\u0027boot_option\u0027: boot_option}}]"},{"line_number":211,"context_line":"            self.update_node(node[\u0027uuid\u0027], patch)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.wait_power_state(node[\u0027uuid\u0027], BaremetalPowerStates.POWER_ON)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f560f44_cf174145","line":211,"range":{"start_line":205,"start_character":0,"end_line":211,"end_character":49},"updated":"2020-08-18 21:52:38.000000000","message":"This needs to be set before the request ever goes to nova to create the server.... and ideally time needs to be given if any schedulign may take place upon it.","commit_id":"23adec07f1d5998951fe841cd68989c6d85f7d98"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e36de224a5c837bbef8bc0c2b8de78319c481e37","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.wait_node(instance[\u0027id\u0027])"},{"line_number":204,"context_line":"        node \u003d self.get_node(instance_id\u003dinstance[\u0027id\u0027])"},{"line_number":205,"context_line":"        if set_capabilities:"},{"line_number":206,"context_line":"            meta \u003d {\u0027boot_option\u0027: boot_option}"},{"line_number":207,"context_line":"            servers_client.set_server_metadata(instance[\u0027id\u0027], meta)"},{"line_number":208,"context_line":"            patch \u003d [{\u0027path\u0027: \u0027/properties/capabilities\u0027,"},{"line_number":209,"context_line":"                      \u0027op\u0027: \u0027add\u0027,"},{"line_number":210,"context_line":"                      \u0027value\u0027: {\u0027boot_option\u0027: boot_option}}]"},{"line_number":211,"context_line":"            self.update_node(node[\u0027uuid\u0027], patch)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.wait_power_state(node[\u0027uuid\u0027], BaremetalPowerStates.POWER_ON)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9f560f44_cfbaa108","line":211,"range":{"start_line":205,"start_character":5,"end_line":211,"end_character":49},"in_reply_to":"9f560f44_0f50190a","updated":"2020-08-18 21:57:58.000000000","message":"yep we were just talking about that on #openstack-nova\nalso this test cant run in paralle with other tests since its changing the compute node configuration dynmically.\n\nor rather any test that sets capabilities cant run in parallel with other that also do that.","commit_id":"23adec07f1d5998951fe841cd68989c6d85f7d98"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6a2af09fe506c5a597d697949eaf428addad3129","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    image_ref \u003d None"},{"line_number":52,"context_line":"    wholedisk_image \u003d None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    mandatory_attr \u003d [\u0027image_ref\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_85c917ad","line":54,"updated":"2020-07-16 14:05:38.000000000","message":"I don\u0027t think it\u0027s enough, image_ref is not passed anyway in the base manager","commit_id":"69e54b4c29da365f1c8d6d6bc30ccaba905520a2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bbf497b804104c929db78134a48807b49e96ed98","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    image_ref \u003d None"},{"line_number":52,"context_line":"    wholedisk_image \u003d None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    mandatory_attr \u003d [\u0027image_ref\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c841663b","line":54,"in_reply_to":"bf51134e_85c917ad","updated":"2020-07-16 14:43:06.000000000","message":"yeah, https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_852/741105/3/check/ironic-lib-bios-ipmi-iscsi-src/852aa31/controller/logs/tempest_log.txt I\u0027ve checked and doesn\u0027t show in use","commit_id":"69e54b4c29da365f1c8d6d6bc30ccaba905520a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6a2af09fe506c5a597d697949eaf428addad3129","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"},{"line_number":242,"context_line":"    wholedisk_image \u003d True"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @decorators.idempotent_id(\u0027549173a5-38ec-42bb-b0e2-c8b9f4a08943\u0027)"},{"line_number":245,"context_line":"    @utils.services(\u0027compute\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":246,"context_line":"    def test_baremetal_server_ops_partition_image(self):"},{"line_number":247,"context_line":"        self.baremetal_server_ops()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_05e4e73a","line":244,"updated":"2020-07-16 14:05:38.000000000","message":"duplicating ID (ditto below)","commit_id":"69e54b4c29da365f1c8d6d6bc30ccaba905520a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5781caa113f2fa09cc56189c89684f7a579d7e5e","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def baremetal_server_ops(self):"},{"line_number":201,"context_line":"        if self.image_ref is None:"},{"line_number":202,"context_line":"            raise Exception(\"image_ref is not set\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        server_args \u003d {\u0027image_id\u0027: self.image_ref}"},{"line_number":205,"context_line":"        self.add_keypair()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_3230409f","line":202,"updated":"2020-07-17 09:20:51.000000000","message":"nit: could be just\n\n assert self.image_ref","commit_id":"0e50f87358683f1bf889669e5351e8ded4f68207"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5781caa113f2fa09cc56189c89684f7a579d7e5e","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        server_args \u003d {\u0027image_id\u0027: self.image_ref}"},{"line_number":205,"context_line":"        self.add_keypair()"},{"line_number":206,"context_line":"        self.instance, self.node \u003d self.boot_instance(**server_args)"},{"line_number":207,"context_line":"        self.validate_ports()"},{"line_number":208,"context_line":"        self.validate_scheduling()"},{"line_number":209,"context_line":"        ip_address \u003d self.get_server_ip(self.instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_9225cc5f","line":206,"updated":"2020-07-17 09:20:51.000000000","message":"nit: just pass directly","commit_id":"0e50f87358683f1bf889669e5351e8ded4f68207"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"418bdc2d005e2b89f018e1f97111d41d32f59ff0","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        # We expect the ephemeral partition to be mounted on /mnt and to have"},{"line_number":213,"context_line":"        # the same size as our flavor definition."},{"line_number":214,"context_line":"        eph_size \u003d self.get_flavor_ephemeral_size()"},{"line_number":215,"context_line":"        if eph_size:"},{"line_number":216,"context_line":"            self.verify_partition(vm_client, \u0027ephemeral0\u0027, \u0027/mnt\u0027, eph_size)"},{"line_number":217,"context_line":"            # Create the test file"},{"line_number":218,"context_line":"            self.create_timestamp("},{"line_number":219,"context_line":"                ip_address, private_key\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_143253a7","line":217,"range":{"start_line":215,"start_character":7,"end_line":217,"end_character":34},"updated":"2020-07-16 18:55:23.000000000","message":"@Dmitry, do you think we need `verify_partition` when using wholedisk images?\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d4d/741105/3/check/ironic-lib-bios-ipmi-direct-src/d4d4207/testr_results.html","commit_id":"e530f430def19e8440eb27e32ed59f0cc391fbf5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0aff76c8ed20426ada3c9ed1a3e7f2273b02907d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        # We expect the ephemeral partition to be mounted on /mnt and to have"},{"line_number":213,"context_line":"        # the same size as our flavor definition."},{"line_number":214,"context_line":"        eph_size \u003d self.get_flavor_ephemeral_size()"},{"line_number":215,"context_line":"        if eph_size:"},{"line_number":216,"context_line":"            self.verify_partition(vm_client, \u0027ephemeral0\u0027, \u0027/mnt\u0027, eph_size)"},{"line_number":217,"context_line":"            # Create the test file"},{"line_number":218,"context_line":"            self.create_timestamp("},{"line_number":219,"context_line":"                ip_address, private_key\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_01c3303a","line":217,"range":{"start_line":215,"start_character":7,"end_line":217,"end_character":34},"in_reply_to":"bf51134e_143253a7","updated":"2020-07-17 04:44:27.000000000","message":"We likely do not as there should be no ephemeral partition with wholedisk.","commit_id":"e530f430def19e8440eb27e32ed59f0cc391fbf5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5b59dcc2510d28bd9eaed31e67b064dfa92150b1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.assertEqual(success_string, output)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def baremetal_server_ops(self):"},{"line_number":201,"context_line":"        if self.image_ref is None:"},{"line_number":202,"context_line":"            raise Exception(\"image_ref is not set\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        server_args \u003d {\u0027image_id\u0027: self.image_ref}"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_07c3403a","line":201,"updated":"2020-07-17 08:23:00.000000000","message":"maybe use try/except here? EAFP :)","commit_id":"289ae5cdee05ba9641cc700bb659aed6e3db5811"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c7d7b41dc6c6ef42933875b6a97e67a46415993e","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.assertEqual(success_string, output)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def baremetal_server_ops(self):"},{"line_number":201,"context_line":"        if self.image_ref is None:"},{"line_number":202,"context_line":"            raise Exception(\"image_ref is not set\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        server_args \u003d {\u0027image_id\u0027: self.image_ref}"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_07d8601c","line":201,"in_reply_to":"bf51134e_07c3403a","updated":"2020-07-17 08:26:48.000000000","message":"actually scratch that, since we\u0027re checking for None value this is the simplest way","commit_id":"289ae5cdee05ba9641cc700bb659aed6e3db5811"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ee39da21ef83828d6f44cf4ec5272bbcc5641f4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    TEST_RESCUE_MODE \u003d False"},{"line_number":51,"context_line":"    image_ref \u003d None"},{"line_number":52,"context_line":"    wholedisk_image \u003d None"},{"line_number":53,"context_line":"    default_boot_option \u003d CONF.baremetal.default_boot_option"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    mandatory_attr \u003d [\u0027image_ref\u0027, \u0027wholedisk_image\u0027]"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_3ba766aa","line":53,"updated":"2020-07-20 08:11:08.000000000","message":"Just \"boot_option\", it\u0027s not the default","commit_id":"1bd53ba4986d5d31aade97f80f2906aed48266fd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5a50c1b648f701d812b4daf70fcf131fe4d68360","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    TEST_RESCUE_MODE \u003d False"},{"line_number":51,"context_line":"    image_ref \u003d None"},{"line_number":52,"context_line":"    wholedisk_image \u003d None"},{"line_number":53,"context_line":"    default_boot_option \u003d CONF.baremetal.default_boot_option"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    mandatory_attr \u003d [\u0027image_ref\u0027, \u0027wholedisk_image\u0027]"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_3b43e6b1","line":53,"in_reply_to":"bf51134e_3ba766aa","updated":"2020-07-21 21:20:50.000000000","message":"Done","commit_id":"1bd53ba4986d5d31aade97f80f2906aed48266fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ee39da21ef83828d6f44cf4ec5272bbcc5641f4","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class BaremetalBasicOpsPartitionImage(BaremetalBasicOps):"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    if CONF.baremetal.default_boot_option !\u003d \u0027netboot\u0027:"},{"line_number":235,"context_line":"        default_boot_option \u003d \u0027netboot\u0027"},{"line_number":236,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":237,"context_line":"    wholedisk_image \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_9bb5d2d3","line":234,"updated":"2020-07-20 08:11:08.000000000","message":"not needed, there is similar logic when setting the capability","commit_id":"1bd53ba4986d5d31aade97f80f2906aed48266fd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5a50c1b648f701d812b4daf70fcf131fe4d68360","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class BaremetalBasicOpsPartitionImage(BaremetalBasicOps):"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    if CONF.baremetal.default_boot_option !\u003d \u0027netboot\u0027:"},{"line_number":235,"context_line":"        default_boot_option \u003d \u0027netboot\u0027"},{"line_number":236,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":237,"context_line":"    wholedisk_image \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_5b469ac2","line":234,"in_reply_to":"bf51134e_9bb5d2d3","updated":"2020-07-21 21:20:50.000000000","message":"Done","commit_id":"1bd53ba4986d5d31aade97f80f2906aed48266fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ee39da21ef83828d6f44cf4ec5272bbcc5641f4","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @decorators.idempotent_id(\u0027641cd3ad-a1df-497e-939e-5a9b61537ee0\u0027)"},{"line_number":251,"context_line":"    @utils.services(\u0027compute\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":252,"context_line":"    def test_baremetal_server_ops_partition_image(self):"},{"line_number":253,"context_line":"        self.baremetal_server_ops()"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_7bba7ec0","line":252,"updated":"2020-07-20 08:11:08.000000000","message":"nit: wholedisk","commit_id":"1bd53ba4986d5d31aade97f80f2906aed48266fd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5a50c1b648f701d812b4daf70fcf131fe4d68360","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    @decorators.idempotent_id(\u0027641cd3ad-a1df-497e-939e-5a9b61537ee0\u0027)"},{"line_number":251,"context_line":"    @utils.services(\u0027compute\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":252,"context_line":"    def test_baremetal_server_ops_partition_image(self):"},{"line_number":253,"context_line":"        self.baremetal_server_ops()"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_fb384e3c","line":252,"in_reply_to":"bf51134e_7bba7ec0","updated":"2020-07-21 21:20:50.000000000","message":"Done","commit_id":"1bd53ba4986d5d31aade97f80f2906aed48266fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class BaremetalBasicOpsPartitionImage(BaremetalBasicOps):"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    flavor_ref \u003d CONF.compute.flavor_ref_alt"},{"line_number":237,"context_line":"    boot_option \u003d \u0027netboot\u0027"},{"line_number":238,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":239,"context_line":"    wholedisk_image \u003d False"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_70999177","line":236,"updated":"2020-08-03 08:20:01.000000000","message":"Let\u0027s maybe create our own set of flavor parameters? I\u0027m pretty sure in half a year we\u0027re going to forget what special meaning flavor_ref_alt has. Let\u0027s have CONF.baremetal.local_boot_flavor and netboot_flavor?","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0b6736880861a6e7b9e8b6a19e44617e18946234","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class BaremetalBasicOpsPartitionImage(BaremetalBasicOps):"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    flavor_ref \u003d CONF.compute.flavor_ref_alt"},{"line_number":237,"context_line":"    boot_option \u003d \u0027netboot\u0027"},{"line_number":238,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":239,"context_line":"    wholedisk_image \u003d False"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_5040cda5","line":236,"in_reply_to":"9f560f44_70999177","updated":"2020-08-03 08:34:07.000000000","message":"I was wondering about this also hehe, sounds like a good plan! I will move with that","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        super(BaremetalBasicOpsPartitionImage, cls).skip_checks()"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if (CONF.baremetal.default_boot_option \u003d\u003d \u0027local\u0027"},{"line_number":246,"context_line":"            and cls.flavor_ref is not None):"},{"line_number":247,"context_line":"            msg \u003d \u0027Flavor is not set and boot option is local.\u0027"},{"line_number":248,"context_line":"            raise cls.skipException(msg)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_d08b3d1c","line":246,"updated":"2020-08-03 08:20:01.000000000","message":"nit: indentation","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ccd260c227e7111e179d2d94984d424f6ed7fd1c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        super(BaremetalBasicOpsPartitionImage, cls).skip_checks()"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if (CONF.baremetal.default_boot_option \u003d\u003d \u0027local\u0027"},{"line_number":246,"context_line":"            and cls.flavor_ref is not None):"},{"line_number":247,"context_line":"            msg \u003d \u0027Flavor is not set and boot option is local.\u0027"},{"line_number":248,"context_line":"            raise cls.skipException(msg)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_64f7d88c","line":246,"in_reply_to":"9f560f44_1533df63","updated":"2020-08-06 21:57:34.000000000","message":"Aha! Thanks Riccardo!","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"072b4ad4bcde7e11f8f07f9e9aa3ac2eb4bd9183","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        super(BaremetalBasicOpsPartitionImage, cls).skip_checks()"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if (CONF.baremetal.default_boot_option \u003d\u003d \u0027local\u0027"},{"line_number":246,"context_line":"            and cls.flavor_ref is not None):"},{"line_number":247,"context_line":"            msg \u003d \u0027Flavor is not set and boot option is local.\u0027"},{"line_number":248,"context_line":"            raise cls.skipException(msg)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_1533df63","line":246,"in_reply_to":"9f560f44_704351b0","updated":"2020-08-03 15:42:51.000000000","message":"this is because we\u0027re ignoring E129\nyou can rebase on top of https://review.opendev.org/744514 to check","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0b6736880861a6e7b9e8b6a19e44617e18946234","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        super(BaremetalBasicOpsPartitionImage, cls).skip_checks()"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if (CONF.baremetal.default_boot_option \u003d\u003d \u0027local\u0027"},{"line_number":246,"context_line":"            and cls.flavor_ref is not None):"},{"line_number":247,"context_line":"            msg \u003d \u0027Flavor is not set and boot option is local.\u0027"},{"line_number":248,"context_line":"            raise cls.skipException(msg)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_704351b0","line":246,"in_reply_to":"9f560f44_d08b3d1c","updated":"2020-08-03 08:34:07.000000000","message":"O.o pep8 didn\u0027t complain .-.","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":267,"context_line":"class BaremetalBasicOpsAndRescuePartitionImage(BaremetalBasicOps):"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    TEST_RESCUE_MODE \u003d True"},{"line_number":270,"context_line":"    flavor_ref \u003d CONF.compute.flavor_ref_alt"},{"line_number":271,"context_line":"    boot_option \u003d \u0027netboot\u0027"},{"line_number":272,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":273,"context_line":"    wholedisk_image \u003d False"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_b090494c","line":270,"updated":"2020-08-03 08:20:01.000000000","message":"ditto","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        super(BaremetalBasicOpsAndRescuePartitionImage, cls).skip_checks()"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if (CONF.baremetal.default_boot_option \u003d\u003d \u0027local\u0027"},{"line_number":280,"context_line":"            and cls.flavor_ref is not None):"},{"line_number":281,"context_line":"            msg \u003d \u0027Flavor is not set and boot option is local.\u0027"},{"line_number":282,"context_line":"            raise cls.skipException(msg)"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_1082d500","line":280,"updated":"2020-08-03 08:20:01.000000000","message":"ditto","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22dce4041912d38ab430f5a2c161c731bdbb29d0","unresolved":true,"context_lines":[{"line_number":233,"context_line":"class BaremetalBasicOpsPartitionImage(BaremetalBasicOps):"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":236,"context_line":"    boot_option \u003d \u0027netboot\u0027"},{"line_number":237,"context_line":"    flavor_ref \u003d ("},{"line_number":238,"context_line":"        CONF.baremetal.baremetal_flavor_netboot"},{"line_number":239,"context_line":"        if CONF.baremetal.baremetal_flavor_netboot"}],"source_content_type":"text/x-python","patch_set":25,"id":"6f655a05_ef32ec39","line":236,"updated":"2021-02-15 13:55:01.000000000","message":"I kind of just want to avoid netboot default jobs since they are so easy to break if dhcp does not update in time.","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1f2db01915d4471ab85cea190bd2193515d96588","unresolved":true,"context_lines":[{"line_number":233,"context_line":"class BaremetalBasicOpsPartitionImage(BaremetalBasicOps):"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    image_ref \u003d CONF.baremetal.partition_image_ref"},{"line_number":236,"context_line":"    boot_option \u003d \u0027netboot\u0027"},{"line_number":237,"context_line":"    flavor_ref \u003d ("},{"line_number":238,"context_line":"        CONF.baremetal.baremetal_flavor_netboot"},{"line_number":239,"context_line":"        if CONF.baremetal.baremetal_flavor_netboot"}],"source_content_type":"text/x-python","patch_set":25,"id":"285b5598_eaa1e162","line":236,"in_reply_to":"6f655a05_ef32ec39","updated":"2021-02-21 14:59:59.000000000","message":"Maybe just use the default from the Ironic configuration?","commit_id":"e204bee95a5419936865bf12c4734a16467c6194"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_multitenancy.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b70d1e8de422083f853f1a34f8e77cdec08682b5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # that will allow a different flavor to be used."},{"line_number":113,"context_line":"        if CONF.baremetal.vm_use_flavor_ref:"},{"line_number":114,"context_line":"            desired_flavor \u003d CONF.compute.flavor_ref"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            desired_flavor \u003d CONF.compute.flavor_ref_alt"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if use_vm:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_b64978d1","line":115,"updated":"2020-07-31 13:33:26.000000000","message":"nit: if CONF.compute.flavor_ref_alt always exists, you can save the else if you initialize desired_flavor using CONF.compute.flavor_ref_alt instead of None","commit_id":"c905f1db5bf69e469a32c2827918c2bf726bb1dd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f0f705fe02a80813a58af8b7c218112d2f4cfa8f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # that will allow a different flavor to be used."},{"line_number":113,"context_line":"        if CONF.baremetal.vm_use_flavor_ref:"},{"line_number":114,"context_line":"            desired_flavor \u003d CONF.compute.flavor_ref"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            desired_flavor \u003d CONF.compute.flavor_ref_alt"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if use_vm:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_1ccde3b7","line":115,"in_reply_to":"9f560f44_b64978d1","updated":"2020-07-31 14:44:03.000000000","message":"/me facepalm, yeah I will update \u003d)","commit_id":"c905f1db5bf69e469a32c2827918c2bf726bb1dd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # since we are changing this on ironic we need to offer a configuration"},{"line_number":112,"context_line":"        # that will allow a different flavor to be used."},{"line_number":113,"context_line":"        if CONF.baremetal.vm_use_flavor_ref:"},{"line_number":114,"context_line":"            desired_flavor \u003d CONF.compute.flavor_ref"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if use_vm:"},{"line_number":117,"context_line":"            # Create VM on compute node"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_f0864113","line":114,"updated":"2020-08-03 08:20:01.000000000","message":"given that vm_use_flavor_ref defaults to True, why not just use flavor_ref?","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0b6736880861a6e7b9e8b6a19e44617e18946234","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # since we are changing this on ironic we need to offer a configuration"},{"line_number":112,"context_line":"        # that will allow a different flavor to be used."},{"line_number":113,"context_line":"        if CONF.baremetal.vm_use_flavor_ref:"},{"line_number":114,"context_line":"            desired_flavor \u003d CONF.compute.flavor_ref"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if use_vm:"},{"line_number":117,"context_line":"            # Create VM on compute node"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_90f1c598","line":114,"in_reply_to":"9f560f44_f0864113","updated":"2020-08-03 08:34:07.000000000","message":"Since before flavor_ref_alt and flavor_ref were always set to the same value and now we have different values this keeps backward compatibility  (I\u0027ve let vm_use_flavor_ref true by default to keep the same workflow for VM testing...)","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e20bf43aa2a5a16107477d4b0ea176f8fe5076c3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            alt_instance \u003d self.create_server("},{"line_number":119,"context_line":"                clients\u003dself.os_alt,"},{"line_number":120,"context_line":"                key_name\u003dalt_keypair[\u0027name\u0027],"},{"line_number":121,"context_line":"                flavor\u003ddesired_flavor,"},{"line_number":122,"context_line":"                networks\u003d[{\u0027uuid\u0027: alt_network[\u0027id\u0027]}]"},{"line_number":123,"context_line":"            )"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_507f2d14","line":121,"updated":"2020-08-03 08:20:01.000000000","message":"Actually.. now you\u0027re using a BM flavor by default to create a VM.","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0b6736880861a6e7b9e8b6a19e44617e18946234","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            alt_instance \u003d self.create_server("},{"line_number":119,"context_line":"                clients\u003dself.os_alt,"},{"line_number":120,"context_line":"                key_name\u003dalt_keypair[\u0027name\u0027],"},{"line_number":121,"context_line":"                flavor\u003ddesired_flavor,"},{"line_number":122,"context_line":"                networks\u003d[{\u0027uuid\u0027: alt_network[\u0027id\u0027]}]"},{"line_number":123,"context_line":"            )"},{"line_number":124,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_70eeb1b4","line":121,"in_reply_to":"9f560f44_507f2d14","updated":"2020-08-03 08:34:07.000000000","message":"It was always a BM flavor..","commit_id":"7daa2f62ea01e82c62e37add600d87b6b2e57c99"}]}