)]}'
{"id":"openstack%2Fironic-tempest-plugin~762556","triplet_id":"openstack%2Fironic-tempest-plugin~master~If0d51b52e96f280336d0d92135681db75a6fbd65","project":"openstack/ironic-tempest-plugin","branch":"master","hashtags":[],"change_id":"If0d51b52e96f280336d0d92135681db75a6fbd65","subject":"Fix byte check in tempest plugin","status":"MERGED","created":"2020-11-12 17:31:49.000000000","updated":"2020-11-13 08:56:27.000000000","submitted":"2020-11-13 08:54:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"762556-1605257663970-40a8ff94","meta_rev_id":"330522d37a1eb4fe279c5b55a030fcc8f26f9e8a","_number":762556,"virtual_id_number":762556,"owner":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-13 08:54:23.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-11-13 07:32:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-12 18:29:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-11-13 07:32:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-12 18:29:07.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2020-11-13 07:32:27.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-11-13 08:54:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f5ba42efbe007b5b8d6cfd8e040508680a6f2bbb","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-11-12 17:31:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c1f3c1766c6800463e1e1c800c9a0847827c1226","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2020-11-12 18:29:07.000000000","message":"Patch Set 1: Code-Review+2\n\nI liked!","accounts_in_message":[],"_revision_number":1},{"id":"7cbe449bd16cf78601fc16c53efcc48798e4efc9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 19:28:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5507ae84c2e1443e97233a4d4657cf8f : SUCCESS in 5m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6e20697211164602bf5d7c5680b475d2 : SUCCESS in 3m 16s\n- ironic-standalone https://zuul.opendev.org/t/openstack/build/499d7751ac22437eb6e03ddd361a9bd4 : SUCCESS in 1h 05m 53s\n- ironic-standalone-victoria https://zuul.opendev.org/t/openstack/build/62428d4af60241058e5aa1d33633b0da : SUCCESS in 1h 10m 25s\n- ironic-standalone-ussuri https://zuul.opendev.org/t/openstack/build/801e1c95de6243058599ad75febd6a17 : SUCCESS in 1h 07m 03s\n- ironic-standalone-train https://zuul.opendev.org/t/openstack/build/1ea2639926d642d299ec29904b926c71 : SUCCESS in 1h 14m 41s (non-voting)\n- ironic-tempest-functional-python3 https://zuul.opendev.org/t/openstack/build/54c7950803ec4354bc84d5d5f42e724b : SUCCESS in 31m 01s\n- ironic-tempest-functional-python3-victoria https://zuul.opendev.org/t/openstack/build/c3f0c63ea51a4f40a11c780445211793 : SUCCESS in 32m 35s\n- ironic-tempest-functional-python3-ussuri https://zuul.opendev.org/t/openstack/build/34d527a96ef34dfab5852abcb32849c7 : SUCCESS in 30m 31s\n- ironic-tempest-functional-python3-train https://zuul.opendev.org/t/openstack/build/cee2932582dd46988b0f33e04d8da23f : SUCCESS in 27m 10s (non-voting)\n- ironic-inspector-tempest https://zuul.opendev.org/t/openstack/build/7622d2ded271439d9244a6509fd3a4eb : SUCCESS in 55m 37s\n- ironic-inspector-tempest-victoria https://zuul.opendev.org/t/openstack/build/27d0df35335a4f20aba86bede33561ca : SUCCESS in 51m 55s\n- ironic-inspector-tempest-ussuri https://zuul.opendev.org/t/openstack/build/d1860d5ec5b84d488ce15a003612ae30 : SUCCESS in 56m 19s\n- ironic-inspector-tempest-train https://zuul.opendev.org/t/openstack/build/a4cfe60298fa49ca927a4340bc1da03e : SUCCESS in 46m 56s (non-voting)\n- ironic-standalone-redfish https://zuul.opendev.org/t/openstack/build/455ca9a7f6b043e4899eefe16c703af0 : SUCCESS in 1h 04m 14s\n- ironic-standalone-redfish-victoria https://zuul.opendev.org/t/openstack/build/e54c1a364c694740a923f75d449abe46 : SUCCESS in 56m 52s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/1e10d40374c54d8eb974703ebd500630 : SUCCESS in 1h 35m 34s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-victoria https://zuul.opendev.org/t/openstack/build/b759ae57a40944c7841f5e089fe08e66 : SUCCESS in 1h 28m 50s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-ussuri https://zuul.opendev.org/t/openstack/build/a551142a61b44febaa1ea104b14a4d13 : FAILURE in 17m 34s (non-voting)\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode-train https://zuul.opendev.org/t/openstack/build/ada95967fa6b427aaed28b9a1fd7b5bb : FAILURE in 13m 28s (non-voting)\n- ironic-inspector-tempest-discovery https://zuul.opendev.org/t/openstack/build/82096a2853874db7915135025089d849 : SUCCESS in 43m 51s\n- ironic-inspector-tempest-discovery-victoria https://zuul.opendev.org/t/openstack/build/95c9aae7a2dd482a8521d8f0db14e44a : SUCCESS in 50m 05s (non-voting)\n- ironic-inspector-tempest-discovery-ussuri https://zuul.opendev.org/t/openstack/build/5117a048ecb549ebb9ba5506ed029efd : SUCCESS in 34m 41s (non-voting)\n- ironic-inspector-tempest-discovery-train https://zuul.opendev.org/t/openstack/build/eeeae40ddca04a848aa7b1cdbda6129e : SUCCESS in 1h 13m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"95307513c47152d624001ce7191aaed75039e6fe","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-11-13 07:32:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7e69ea009775839d923f1db5a471629c7c0a196f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 07:32:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4e5b6bc40f3aa7b33f83840169d0e882b9370d73","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 08:54:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"96e84f8e3e081f0642004d85100b22fca1b394a4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 08:54:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39f1a0ec90f947d3ba5ced11a2b7df1a : SUCCESS in 4m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c61a2217a7e4264bb5454e8a016ca10 : SUCCESS in 3m 06s\n- ironic-standalone https://zuul.opendev.org/t/openstack/build/9c56e4eacca849c8b680256e8442e2ab : SUCCESS in 1h 11m 13s\n- ironic-standalone-victoria https://zuul.opendev.org/t/openstack/build/dceff3ff00604f2aadb8e2e9ed436bd1 : SUCCESS in 53m 57s\n- ironic-standalone-ussuri https://zuul.opendev.org/t/openstack/build/427bacca98c445eb871d5a29e0eeefc2 : SUCCESS in 1h 01m 19s\n- ironic-tempest-functional-python3 https://zuul.opendev.org/t/openstack/build/3705d0c6774f4f8ea5bcd64dbe6e93b7 : SUCCESS in 22m 16s\n- ironic-tempest-functional-python3-victoria https://zuul.opendev.org/t/openstack/build/5e42a45955e645ca95f8e9c9ff80f017 : SUCCESS in 39m 12s\n- ironic-tempest-functional-python3-ussuri https://zuul.opendev.org/t/openstack/build/934f29edf50e4001ad29c86b4328a306 : SUCCESS in 37m 32s\n- ironic-inspector-tempest https://zuul.opendev.org/t/openstack/build/a432e919aa7d48fca06f14beddfee9a9 : SUCCESS in 1h 08m 55s\n- ironic-inspector-tempest-victoria https://zuul.opendev.org/t/openstack/build/eabe3379f35641d0bb79b36c6aa781fd : SUCCESS in 1h 02m 12s\n- ironic-inspector-tempest-ussuri https://zuul.opendev.org/t/openstack/build/86aee86d4172451b871ec6111eb9d4d6 : SUCCESS in 1h 05m 22s\n- ironic-standalone-redfish https://zuul.opendev.org/t/openstack/build/ec607378203f49f48f815493951b969f : SUCCESS in 1h 15m 00s\n- ironic-inspector-tempest-discovery https://zuul.opendev.org/t/openstack/build/38b2244bbae2485fb1c7d879055c750f : SUCCESS in 53m 34s","accounts_in_message":[],"_revision_number":1},{"id":"330522d37a1eb4fe279c5b55a030fcc8f26f9e8a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-13 08:56:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e9e8b323d9384bf1801d760ef52c1d3a : SUCCESS in 1m 33s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e056d5f4b23a432d6fb639d3b012695db603f94d","revisions":{"e056d5f4b23a432d6fb639d3b012695db603f94d":{"kind":"REWORK","_number":1,"created":"2020-11-12 17:31:49.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/56/762556/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-tempest-plugin","ref":"refs/changes/56/762556/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/56/762556/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/56/762556/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/56/762556/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-tempest-plugin refs/changes/56/762556/1"}}},"commit":{"parents":[{"commit":"c6eb17da6d1639f4031410aa92b92169fbd2f2f9","subject":"Merge \"Tear down raid sets\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-tempest-plugin/commit/c6eb17da6d1639f4031410aa92b92169fbd2f2f9"}]}],"author":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-11-12 17:24:05.000000000","tz":-480},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2020-11-12 17:24:05.000000000","tz":-480},"subject":"Fix byte check in tempest plugin","message":"Fix byte check in tempest plugin\n\nDifferent implementations of ping behave slightly differently\nin order to ensure the packet payload is transmitted across\nthe wire because some mediums have a minimum packet size.\n\nTypically this results in a frame size of 64 bytes, but\nthe client may report 56 when the header is removed and only\nthe packet payload is examined.\n\nBut the point of the check is that we got something back.\n\nThe below edited for example purposes:\n\n$ ping -c1 -w4 192.168.133.92\nPING 192.168.65.92 (192.168.133.92) 56(84) bytes of data.\nFrom 192.168.65.249 icmp_seq\u003d1 Destination Host Unreachable\n\n--- 192.168.65.92 ping statistics ---\n1 packets transmitted, 0 received, 0 errors, 100% packet loss, time 3075ms\n$ ping -c1 -w4 192.168.65.1\nPING 192.168.65.1 (192.168.65.1) 56(84) bytes of data.\n64 bytes from 192.168.65.1: icmp_seq\u003d1 ttl\u003d64 time\u003d12.4 ms\n\nAnd then in CI, we\u0027re able to see this be 56 bytes returned\nbecasue the underlying medium may not have been ethernet or\nthe client has stripped the header. Which, doesn\u0027t matter,\nwe get A reply from the expected address and we can validate\nthe test on that alone.\n\nChange-Id: If0d51b52e96f280336d0d92135681db75a6fbd65\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-tempest-plugin/commit/e056d5f4b23a432d6fb639d3b012695db603f94d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-tempest-plugin/commit/e056d5f4b23a432d6fb639d3b012695db603f94d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}