)]}'
{"ironic_tempest_plugin/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"12b1de2f031f7fb155f0ebb1f2988e298f725e21","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                     \"from a partition image.\"),"},{"line_number":161,"context_line":"    cfg.BoolOpt(\u0027skip_firmware_test\u0027,"},{"line_number":162,"context_line":"                default\u003dTrue,"},{"line_number":163,"context_line":"                help\u003d\"Skip the firmware test case if set to True\"),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027boot_mode\u0027,"},{"line_number":165,"context_line":"               default\u003d\u0027bios\u0027,"},{"line_number":166,"context_line":"               choices\u003d[\u0027bios\u0027, \u0027uefi\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"5684177d_e7fd1cb4","line":163,"updated":"2021-07-11 09:20:14.000000000","message":"To avoid increasing the number of options, let\u0027s use the presence of firmware_image_url as a flag instead","commit_id":"5da1bef67fe9652a3b9b3ff60c455c01ebc0152c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2a4574516f967486926a1c7825bcc1e56393b88f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                     \"from a partition image.\"),"},{"line_number":161,"context_line":"    cfg.BoolOpt(\u0027skip_firmware_test\u0027,"},{"line_number":162,"context_line":"                default\u003dTrue,"},{"line_number":163,"context_line":"                help\u003d\"Skip the firmware test case if set to True\"),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027boot_mode\u0027,"},{"line_number":165,"context_line":"               default\u003d\u0027bios\u0027,"},{"line_number":166,"context_line":"               choices\u003d[\u0027bios\u0027, \u0027uefi\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"f113d485_c4fb34d2","line":163,"in_reply_to":"5684177d_e7fd1cb4","updated":"2021-07-12 10:49:23.000000000","message":"Done","commit_id":"5da1bef67fe9652a3b9b3ff60c455c01ebc0152c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"228bfffb5c99cded6db29423276c51bfc7e9d5bb","unresolved":true,"context_lines":[{"line_number":111,"context_line":"                    \"tests.\"),"},{"line_number":112,"context_line":"    cfg.StrOpt(\u0027whole_disk_image_checksum\u0027,"},{"line_number":113,"context_line":"               help\u003d\"An MD5 checksum of the image.\"),"},{"line_number":114,"context_line":"    cfg.StrOpt(\u0027firmware_image_url\u0027,"},{"line_number":115,"context_line":"               help\u003d\"An http link to the firmware image to use in the \""},{"line_number":116,"context_line":"                    \"tests.\"),"},{"line_number":117,"context_line":"    cfg.StrOpt(\u0027firmware_image_checksum\u0027,"},{"line_number":118,"context_line":"               help\u003d\"An MD5 checksum of the firmware image.\"),"},{"line_number":119,"context_line":"    cfg.StrOpt(\u0027partition_image_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"889acfe9_2930469d","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":30},"updated":"2021-09-08 14:39:20.000000000","message":"I would be more comfortable with this if there was a *giant* warning on this configuration option since it runs it by default if populated *and* this may break some machines out there.","commit_id":"e894871bc15db64845d90caab0ad6f8a243374ea"}],"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_cleaning.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6e02f9c1698b22f5204575c000493c54049060c4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    delete_node \u003d False"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    fw_args \u003d {"},{"line_number":184,"context_line":"                  \"firmware_update_mode\": \"ilo\","},{"line_number":185,"context_line":"                  \"firmware_images\":["},{"line_number":186,"context_line":"                      {"},{"line_number":187,"context_line":"                          \"url\": fw_image_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_52bd0967","line":184,"updated":"2020-11-19 13:23:02.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"a980cd260bc47006484ef9b2564a959dfa226c17"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6e02f9c1698b22f5204575c000493c54049060c4","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    fw_args \u003d {"},{"line_number":184,"context_line":"                  \"firmware_update_mode\": \"ilo\","},{"line_number":185,"context_line":"                  \"firmware_images\":["},{"line_number":186,"context_line":"                      {"},{"line_number":187,"context_line":"                          \"url\": fw_image_ref,"},{"line_number":188,"context_line":"                          \"checksum\": fw_image_checksum,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_32c205eb","line":185,"updated":"2020-11-19 13:23:02.000000000","message":"pep8: E231 missing whitespace after \u0027:\u0027","commit_id":"a980cd260bc47006484ef9b2564a959dfa226c17"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6e02f9c1698b22f5204575c000493c54049060c4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                          \"component\": \"ilo\""},{"line_number":190,"context_line":"                      }"},{"line_number":191,"context_line":"                  ]"},{"line_number":192,"context_line":"              }"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @decorators.idempotent_id(\u002771ccf06f-45db-8f93-afd0-d4efae2bfd4e\u0027)"},{"line_number":195,"context_line":"    @utils.services(\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_92b77187","line":192,"updated":"2020-11-19 13:23:02.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"a980cd260bc47006484ef9b2564a959dfa226c17"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e469f394972981506a07185d96f8635aedad47a","unresolved":true,"context_lines":[{"line_number":177,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"},{"line_number":178,"context_line":"    wholedisk_image \u003d True"},{"line_number":179,"context_line":"    fw_image_ref \u003d CONF.baremetal.firmware_image_url"},{"line_number":180,"context_line":"    fw_image_checksum \u003d CONF.baremetal.firmware_image_checksum"},{"line_number":181,"context_line":"    delete_node \u003d False"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    fw_args \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"c69237f9_4616b83d","line":180,"updated":"2020-12-07 14:58:53.000000000","message":"I\u0027d almost flip this setup around. Make a generic firmware update class and test, and then have a second class that inherits it for ilo specific configuration.\n\nThat would make it easy for dell or others to adopt the same test","commit_id":"d3375370f186c62d036306df641e0874b8c0d03e"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"885dc9ce92ac5714dc7074cebac42403409ff6ce","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"},{"line_number":178,"context_line":"    wholedisk_image \u003d True"},{"line_number":179,"context_line":"    fw_image_ref \u003d CONF.baremetal.firmware_image_url"},{"line_number":180,"context_line":"    fw_image_checksum \u003d CONF.baremetal.firmware_image_checksum"},{"line_number":181,"context_line":"    delete_node \u003d False"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    fw_args \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"79f321c7_3d542dfd","line":180,"in_reply_to":"c69237f9_4616b83d","updated":"2020-12-18 07:29:00.000000000","message":"Done","commit_id":"d3375370f186c62d036306df641e0874b8c0d03e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e469f394972981506a07185d96f8635aedad47a","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                \"component\": \"ilo\""},{"line_number":190,"context_line":"            }"},{"line_number":191,"context_line":"        ]"},{"line_number":192,"context_line":"    }"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @decorators.idempotent_id(\u002771ccf06f-45db-8f93-afd0-d4efae2bfd4e\u0027)"},{"line_number":195,"context_line":"    @utils.services(\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2fd1a0ae_d01465af","line":192,"updated":"2020-12-07 14:58:53.000000000","message":"I guess this raises a really big question: We we want standalone jobs covering vendor driver specific configurations?","commit_id":"d3375370f186c62d036306df641e0874b8c0d03e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bd8ea0c9f33ee076cb0b633884afb8d8eb7fd8d8","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        self.terminate_node(self.node[\u0027uuid\u0027], force_delete\u003dTrue)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class BaremetalFirmwareUpdate(bsm.BaremetalStandaloneScenarioTest):"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    api_microversion \u003d \u00271.31\u0027  # to set the deploy_interface"},{"line_number":174,"context_line":"    driver \u003d \u0027redfish\u0027"},{"line_number":175,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"},{"line_number":176,"context_line":"    wholedisk_image \u003d True"},{"line_number":177,"context_line":"    deploy_interface \u003d \u0027direct\u0027"},{"line_number":178,"context_line":"    fw_image_ref \u003d CONF.baremetal.firmware_image_url"},{"line_number":179,"context_line":"    fw_image_checksum \u003d CONF.baremetal.firmware_image_checksum"},{"line_number":180,"context_line":"    delete_node \u003d False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    fw_args \u003d {"},{"line_number":183,"context_line":"        \"firmware_images\": ["},{"line_number":184,"context_line":"            {"},{"line_number":185,"context_line":"                \"url\": fw_image_ref"},{"line_number":186,"context_line":"            }"},{"line_number":187,"context_line":"        ]"},{"line_number":188,"context_line":"    }"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @decorators.idempotent_id(\u002771ccf06f-45db-8f93-afd0-d4efae2bfd4e\u0027)"},{"line_number":191,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":192,"context_line":"    def test_firmware_update(self):"},{"line_number":193,"context_line":"        self.update_firmware(args\u003dself.fw_args)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class BaremetalInbandFirmwareUpdateIlo(BaremetalFirmwareUpdate):"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"05d30667_675fb88f","line":194,"range":{"start_line":171,"start_character":0,"end_line":194,"end_character":0},"updated":"2021-03-23 15:01:38.000000000","message":"This doesn\u0027t seem possible in upstream CI.\n\nThe reason this change is failing is because we can\u0027t test it in upstream CI and it gets picked up.\n\nSo maybe we make it configurable/optional?\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_75f/763340/4/check/ironic-standalone-redfish/75ff622/testr_results.html","commit_id":"b8082a46703b7ae4301d451b23c4ebf7d6af921b"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"f5173dddab2dad79f2d36b7b8d428e649ced51b5","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        self.terminate_node(self.node[\u0027uuid\u0027], force_delete\u003dTrue)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class BaremetalFirmwareUpdate(bsm.BaremetalStandaloneScenarioTest):"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    api_microversion \u003d \u00271.31\u0027  # to set the deploy_interface"},{"line_number":174,"context_line":"    driver \u003d \u0027redfish\u0027"},{"line_number":175,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"},{"line_number":176,"context_line":"    wholedisk_image \u003d True"},{"line_number":177,"context_line":"    deploy_interface \u003d \u0027direct\u0027"},{"line_number":178,"context_line":"    fw_image_ref \u003d CONF.baremetal.firmware_image_url"},{"line_number":179,"context_line":"    fw_image_checksum \u003d CONF.baremetal.firmware_image_checksum"},{"line_number":180,"context_line":"    delete_node \u003d False"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    fw_args \u003d {"},{"line_number":183,"context_line":"        \"firmware_images\": ["},{"line_number":184,"context_line":"            {"},{"line_number":185,"context_line":"                \"url\": fw_image_ref"},{"line_number":186,"context_line":"            }"},{"line_number":187,"context_line":"        ]"},{"line_number":188,"context_line":"    }"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @decorators.idempotent_id(\u002771ccf06f-45db-8f93-afd0-d4efae2bfd4e\u0027)"},{"line_number":191,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":192,"context_line":"    def test_firmware_update(self):"},{"line_number":193,"context_line":"        self.update_firmware(args\u003dself.fw_args)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class BaremetalInbandFirmwareUpdateIlo(BaremetalFirmwareUpdate):"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5b54c32a_efc5fc0c","line":194,"range":{"start_line":171,"start_character":0,"end_line":194,"end_character":0},"in_reply_to":"05d30667_675fb88f","updated":"2021-03-25 07:07:24.000000000","message":"Done","commit_id":"b8082a46703b7ae4301d451b23c4ebf7d6af921b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bd8ea0c9f33ee076cb0b633884afb8d8eb7fd8d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f882181_24a7bc3d","line":218,"range":{"start_line":196,"start_character":0,"end_line":218,"end_character":0},"updated":"2021-03-23 15:01:38.000000000","message":"So this makes sense as it should get skipped... in theory.","commit_id":"b8082a46703b7ae4301d451b23c4ebf7d6af921b"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"f5173dddab2dad79f2d36b7b8d428e649ced51b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0240db65_1f857488","line":218,"range":{"start_line":196,"start_character":0,"end_line":218,"end_character":0},"in_reply_to":"9f882181_24a7bc3d","updated":"2021-03-25 07:07:24.000000000","message":"Done","commit_id":"b8082a46703b7ae4301d451b23c4ebf7d6af921b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"12b1de2f031f7fb155f0ebb1f2988e298f725e21","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        ]"},{"line_number":189,"context_line":"    }"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if not skip_fw_test:"},{"line_number":192,"context_line":"        @decorators.idempotent_id(\u002771ccf06f-45db-8f93-afd0-d4efae2bfd4e\u0027)"},{"line_number":193,"context_line":"        @utils.services(\u0027network\u0027)"},{"line_number":194,"context_line":"        def test_firmware_update(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"6114a19a_a9122938","line":191,"updated":"2021-07-11 09:20:14.000000000","message":"Please use standard skip mechanisms (see other tests for examples)","commit_id":"5da1bef67fe9652a3b9b3ff60c455c01ebc0152c"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"2a4574516f967486926a1c7825bcc1e56393b88f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        ]"},{"line_number":189,"context_line":"    }"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if not skip_fw_test:"},{"line_number":192,"context_line":"        @decorators.idempotent_id(\u002771ccf06f-45db-8f93-afd0-d4efae2bfd4e\u0027)"},{"line_number":193,"context_line":"        @utils.services(\u0027network\u0027)"},{"line_number":194,"context_line":"        def test_firmware_update(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"39647631_8d5126c2","line":191,"in_reply_to":"6114a19a_a9122938","updated":"2021-07-12 10:49:23.000000000","message":"\u003e Please use standard skip mechanisms (see other tests for examples)\n\nDone","commit_id":"5da1bef67fe9652a3b9b3ff60c455c01ebc0152c"}]}