)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"8573130642ca3a57cd6131f5dbebe8469f19d670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0ffd3f1_8ffac554","updated":"2022-01-27 11:59:14.000000000","message":"Tempest test case for review : Management cleaning steps for idrac-wsman and idrac-redfish.","commit_id":"472743c2be1eb08f9cfda3a4ad14cedcc1f42535"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce6fbf9f_77429ecf","updated":"2022-02-07 18:48:19.000000000","message":"A couple things in test_cleaning.py. A realistic minimum microversion should be set. The component requirements tags are not needed unless an instance is going to get fired up. An explicit credential setting, albeit not required, would be nice to have since we introduced SRBAC in wallaby and all tests, by default, run with legacy project admin privileges. At some point I need to change that around, but I need to keep legacy compatibility, so upfront usage of system_admin would be nice, but not requird.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"430406abe1c6d88d8e0b9db1b4bf59584cd55ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9bad2f27_f7f5592e","updated":"2022-01-31 18:36:24.000000000","message":"I have the same question as Ameya [1].\n\nIn addition, it would be very desirable to be able to execute the new test cases in parallel on all of the available baremetal nodes, similar to how the inspector test_introspection_basic.InspectorBasicTest.test_baremetal_introspection test works [2]. That could cut the time to test by an order of magnitude. As we well know, executing a test on a real physical server that involves rebooting takes much longer than on a VM. It also simulates a production workflow of resetting the BMCs of a group of systems. I feel this would be a great follow-on opportunity. Any reviewer recommendations on how to structure that would be very appreciated. Could class BaremetalStandaloneScenarioTest continue to be leveraged without breaking other tests which are based on it?\n\nOther than that, it looks great to me! Thank you, Ameya.\n\nAlso\n\n[1] https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/826646/comment/1d8e1d87_d12cb8a2/\n[2] https://opendev.org/openstack/ironic-tempest-plugin/src/commit/3d2de82b3e08b348732156ab95a492cd40022e17/ironic_tempest_plugin/tests/scenario/test_introspection_basic.py#L59-L118","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"97edf84f017d6c01933fcdb585e28bd928e32918","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2793556_984dac8c","updated":"2022-02-04 13:36:51.000000000","message":"LGTM, thanks Ameya.\n\nWould it be possible to test this test on CI before it merges? Would that require adding Dell 3rd party CI to this repo?","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"5d495cedba97d66ce762cd19ba7e72d9c60ce95d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60a5267b_508e31dc","updated":"2022-01-28 12:18:11.000000000","message":"Recheck","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"324471e793500cd6729bcf3060a344bcbad9ead9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98429a24_3c21174e","updated":"2022-02-04 10:26:37.000000000","message":"Recheck","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"dd488d00dea1cfd21fcd041754c103ae19d567a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c3981b70_7f28b8d7","updated":"2022-01-28 08:36:43.000000000","message":"Recheck","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"c1f8530f7bceeb7ee0e2114d333934044dcedbb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81204d06_060765dc","in_reply_to":"f2793556_984dac8c","updated":"2022-02-04 14:32:44.000000000","message":"Yea, that requires adding this repo as a trigger for Dell 3rd party CI. I think it should be doable to trigger by comment only if we\u0027d prefer.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c032a863_b1d40606","updated":"2022-02-15 10:02:01.000000000","message":"Addressed the review comments","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"cfcd54ecfa1133b63b04e8b354c12abda81bdde9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"88676700_37523c25","updated":"2022-02-15 10:05:04.000000000","message":"Keeping api micro version as 1.28 as quoted","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"9622540af9af6987a5672c6199bb22e16ecb994e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"482412fb_2fd63de0","updated":"2022-04-25 19:39:14.000000000","message":"Thank you, Ameya! I have a couple of in-line suggestions.","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"9d9de312c9a245b5008eaac6af1143d17bfe4095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d69ccb85_9e889dd9","updated":"2022-04-29 17:44:28.000000000","message":"Looks great to me! Thank you, Ameya.","commit_id":"64ad55769eecc98c5f225446319f6ed60c48011d"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"07aea4090df3ceaddbecd16c5033bf798781c763","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f1665b62_41da408e","updated":"2022-05-04 17:05:53.000000000","message":"recheck","commit_id":"64ad55769eecc98c5f225446319f6ed60c48011d"}],"ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Copyright 2017 Mirantis Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Copyright (c) 2022 Dell Inc. or its subsidiaries.#"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":8,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":2,"id":"148a7b18_8a7f28f6","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":1},"updated":"2022-02-07 18:48:19.000000000","message":"So copyright assignments are kind of pointless here. All rights are actually assigned over the the foundation. Also, I\u0027m unsure this is a substantial enough change to really warrant copyright stamping, since even if rights were not assigned to the foundation, it is not a substantial change to the overall contents of the file.\n\nConsider this a comment more than anything else, but I am not a copyright lawyer, and I don\u0027t thinks subsidaries can hold concurrent equal copyright rights as a parent entity, even if they were not reassigned, at the same time.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Copyright 2017 Mirantis Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Copyright (c) 2022 Dell Inc. or its subsidiaries.#"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":8,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c06a264_dd61ad39","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":1},"in_reply_to":"148a7b18_8a7f28f6","updated":"2022-02-15 10:02:01.000000000","message":"Ack","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"}],"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_cleaning.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":true,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class BaremetalIdracManagementCleaning("},{"line_number":174,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    mandatory_attr \u003d [\u0027driver\u0027, \u0027management_interface\u0027,"},{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":"    driver \u003d \u0027idrac\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac9a049c_d741f266","line":175,"updated":"2022-02-07 18:48:19.000000000","message":"You\u0027ll want to define the credentials to use using the credentials parameter on the class. Presently all of these tests use Admin, this will likely need to change to system_admin which is fine later on.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class BaremetalIdracManagementCleaning("},{"line_number":174,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    mandatory_attr \u003d [\u0027driver\u0027, \u0027management_interface\u0027,"},{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":"    driver \u003d \u0027idrac\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd0c938e_374d3f64","line":175,"in_reply_to":"ac9a049c_d741f266","updated":"2022-02-15 10:02:01.000000000","message":"Done","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"97edf84f017d6c01933fcdb585e28bd928e32918","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":179,"context_line":"    delete_node \u003d False"},{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"06f9fce5_cd96c999","line":180,"range":{"start_line":180,"start_character":24,"end_line":180,"end_character":28},"updated":"2022-02-04 13:36:51.000000000","message":"why this particular version number?","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":179,"context_line":"    delete_node \u003d False"},{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"29ebf798_a9ddb0d4","line":180,"range":{"start_line":180,"start_character":24,"end_line":180,"end_character":28},"in_reply_to":"06f9fce5_cd96c999","updated":"2022-02-07 18:48:19.000000000","message":"++ On this question. This is a microversion from Ocata. A better question is what is the earliest version these tests would be expected to pass upon?","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":179,"context_line":"    delete_node \u003d False"},{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2251168_eafeffba","line":180,"range":{"start_line":180,"start_character":24,"end_line":180,"end_character":28},"in_reply_to":"29ebf798_a9ddb0d4","updated":"2022-02-15 10:02:01.000000000","message":"Thanks Julia for review.\nMinimum version for cleaning step which we got was 1.15 (# v1.15: Add ability to do manual cleaning of nodes). While testing it was observed that test case is failing in tear down which is expecting vif\u0027s to attach.\n\nAgain looking at the versions got that vif\u0027s were added at verison 1.28 (# v1.28: Add vifs subcontroller to node), hence keeping the version as 1.28.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"cfcd54ecfa1133b63b04e8b354c12abda81bdde9","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":179,"context_line":"    delete_node \u003d False"},{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1f12b6d_64dd4dcc","line":180,"range":{"start_line":180,"start_character":24,"end_line":180,"end_character":28},"in_reply_to":"a2251168_eafeffba","updated":"2022-02-15 10:05:04.000000000","message":"Done","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"dd488d00dea1cfd21fcd041754c103ae19d567a0","unresolved":true,"context_lines":[{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":184,"context_line":"    def test_reset_idrac(self):"},{"line_number":185,"context_line":"        clean_steps \u003d ["},{"line_number":186,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1d8e1d87_d12cb8a2","line":183,"updated":"2022-01-28 08:36:43.000000000","message":"As I understand here, service tagging is required for scenario based tests and for API requires when test method is making any API call to an service.\n\nDo we need service tagging for standalone test cases?\n\nAs observed, for one of the test case its not mentioned (test_bios.py : BaremetalFakeBios).","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":true,"context_lines":[{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":184,"context_line":"    def test_reset_idrac(self):"},{"line_number":185,"context_line":"        clean_steps \u003d ["},{"line_number":186,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9d5e1eb_f91d7230","line":183,"in_reply_to":"1d8e1d87_d12cb8a2","updated":"2022-02-07 18:48:19.000000000","message":"No, they shouldn\u0027t really be needed if I\u0027m understanding what is going on here correctly.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":183,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":184,"context_line":"    def test_reset_idrac(self):"},{"line_number":185,"context_line":"        clean_steps \u003d ["},{"line_number":186,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"53f3da47_c40dda01","line":183,"in_reply_to":"b9d5e1eb_f91d7230","updated":"2022-02-15 10:02:01.000000000","message":"Done","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"dd488d00dea1cfd21fcd041754c103ae19d567a0","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @decorators.idempotent_id(\u00279252ec6f-6b5b-447e-a323-c52775b88b4e\u0027)"},{"line_number":194,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":195,"context_line":"    def test_clear_job_queue(self):"},{"line_number":196,"context_line":"        clean_steps \u003d ["},{"line_number":197,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"071c9ca7_8342b375","line":194,"updated":"2022-01-28 08:36:43.000000000","message":"Ditto","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @decorators.idempotent_id(\u00279252ec6f-6b5b-447e-a323-c52775b88b4e\u0027)"},{"line_number":194,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":195,"context_line":"    def test_clear_job_queue(self):"},{"line_number":196,"context_line":"        clean_steps \u003d ["},{"line_number":197,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"899b70ba_67c0921d","line":194,"in_reply_to":"071c9ca7_8342b375","updated":"2022-02-07 18:48:19.000000000","message":"Not needed as this test is not performing any sort of deployment.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @decorators.idempotent_id(\u00279252ec6f-6b5b-447e-a323-c52775b88b4e\u0027)"},{"line_number":194,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":195,"context_line":"    def test_clear_job_queue(self):"},{"line_number":196,"context_line":"        clean_steps \u003d ["},{"line_number":197,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a810fe2_8d4ca69d","line":194,"in_reply_to":"899b70ba_67c0921d","updated":"2022-02-15 10:02:01.000000000","message":"Done","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1007b3ee1905aa037cb8064fc6fbe8ec625cc64","unresolved":true,"context_lines":[{"line_number":199,"context_line":"                \"step\": \"clear_job_queue\""},{"line_number":200,"context_line":"            }"},{"line_number":201,"context_line":"        ]"},{"line_number":202,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00277baeff52-7d6e-4dea-a48f-a85a6bfc9f62\u0027)"},{"line_number":205,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b531761_5dd7161a","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":64},"updated":"2022-02-07 18:48:19.000000000","message":"Can anything be done after the fact to ensure that the job queue was cleared? or that the job was entirely successful? self.manual_cleaning does wait for the machine to return to the available state, maybe that is enough? Keep in mind, the test can\u0027t also attempt to talk to the barmetal directly or expect to have elevated external access.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                \"step\": \"clear_job_queue\""},{"line_number":200,"context_line":"            }"},{"line_number":201,"context_line":"        ]"},{"line_number":202,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00277baeff52-7d6e-4dea-a48f-a85a6bfc9f62\u0027)"},{"line_number":205,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"84d88e7f_cc1e70e5","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":64},"in_reply_to":"6b531761_5dd7161a","updated":"2022-02-15 10:02:01.000000000","message":"Thanks Julia! Will check what best can be done here to achieve it. As of now will take this as a follow-on task.","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"dd488d00dea1cfd21fcd041754c103ae19d567a0","unresolved":true,"context_lines":[{"line_number":202,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00277baeff52-7d6e-4dea-a48f-a85a6bfc9f62\u0027)"},{"line_number":205,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":206,"context_line":"    def test_known_good_state(self):"},{"line_number":207,"context_line":"        clean_steps \u003d ["},{"line_number":208,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"6cf39e98_d25b384b","line":205,"updated":"2022-01-28 08:36:43.000000000","message":"Ditto","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"25b09c77d2ea23828e26233d7a9a0dbb793c98f1","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        self.manual_cleaning(self.node, clean_steps\u003dclean_steps)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u00277baeff52-7d6e-4dea-a48f-a85a6bfc9f62\u0027)"},{"line_number":205,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":206,"context_line":"    def test_known_good_state(self):"},{"line_number":207,"context_line":"        clean_steps \u003d ["},{"line_number":208,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"942d207e_5aa9f55c","line":205,"in_reply_to":"6cf39e98_d25b384b","updated":"2022-02-15 10:02:01.000000000","message":"Done","commit_id":"32b5696ffe3f640596258f2cee63b81c20572c8f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"9622540af9af6987a5672c6199bb22e16ecb994e","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    mandatory_attr \u003d [\u0027driver\u0027, \u0027management_interface\u0027,"},{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":182,"context_line":"    delete_node \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"0ceedde6_412b0e7c","line":179,"updated":"2022-04-25 19:39:14.000000000","message":"Julia and I chatted about this on IRC. [1] She advised, \"it doesn\u0027t need to be defined\" here, because this class\u0027s base classes already set it to what she thinks is the desired value, at least until the legacy authorization is removed in the future.\n\nThe following is presently the desired assignment, and it is made by base class BaremetalStandaloneManager: [2]\n\n    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027sys_admin\u0027]\n\nTherefore, please remove this line.\n\n[1] https://meetings.opendev.org/irclogs/%23openstack-ironic/%23openstack-ironic.2022-04-25.log.html#t2022-04-25T17:56:49\n[2] https://opendev.org/openstack/ironic-tempest-plugin/src/commit/d3360cf3b6ad8b89b9c80fc806dc5d4ba373dd01/ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py#L34","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"03ca919afe266b2ddebec029ca62e7b413cd23d9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    mandatory_attr \u003d [\u0027driver\u0027, \u0027management_interface\u0027,"},{"line_number":177,"context_line":"                      \u0027power_interface\u0027]"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":182,"context_line":"    delete_node \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae2d928_8e3d1c1d","line":179,"in_reply_to":"0ceedde6_412b0e7c","updated":"2022-04-26 16:44:24.000000000","message":"Done","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"9622540af9af6987a5672c6199bb22e16ecb994e","unresolved":true,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":182,"context_line":"    delete_node \u003d False"},{"line_number":183,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":186,"context_line":"    def test_reset_idrac(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"665138bd_a2ff0722","line":183,"updated":"2022-04-25 19:39:14.000000000","message":"Please consider adding a comment above this line which summarizes your review comment,\n\n\"Minimum version for cleaning step which we got was 1.15 (# v1.15: Add ability to do manual cleaning of nodes). While testing it was observed that test case is failing in tear down which is expecting vif\u0027s to attach.\n\nAgain looking at the versions got that vif\u0027s were added at verison 1.28 (# v1.28: Add vifs subcontroller to node), hence keeping the version as 1.28.\"","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"03ca919afe266b2ddebec029ca62e7b413cd23d9","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    driver \u003d \u0027idrac\u0027"},{"line_number":182,"context_line":"    delete_node \u003d False"},{"line_number":183,"context_line":"    api_microversion \u003d \u00271.28\u0027"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @decorators.idempotent_id(\u0027d085ff72-abef-4931-a5b0-06efd5f9a037\u0027)"},{"line_number":186,"context_line":"    def test_reset_idrac(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"631e75aa_2089b639","line":183,"in_reply_to":"665138bd_a2ff0722","updated":"2022-04-26 16:44:24.000000000","message":"Done","commit_id":"1dae53639241395d138fcfbe1cdbfad708188342"}]}