)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7e4f1d143aa0d3eaeffc89fd70a0f5725476a935","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ameya Raut \u003crautameya04@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-19 09:27:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dettaching instance_uuid for standalone TC\u0027s"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For standalone test cases, where delete_node is set as False,"},{"line_number":10,"context_line":"the instance_uuid remains attached with the node even after test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"38a8acad_cfe4ebd7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":10},"updated":"2022-04-20 07:47:11.000000000","message":"Detaching","commit_id":"04066b1d4b56d171b6e4b4a3e84df7edeec1cbf1"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"fb2a9a19ea0a4685c3091b02563ab1b96d00bc5d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ameya Raut \u003crautameya04@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-19 09:27:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dettaching instance_uuid for standalone TC\u0027s"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For standalone test cases, where delete_node is set as False,"},{"line_number":10,"context_line":"the instance_uuid remains attached with the node even after test"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d44b5b46_ff4b0dd7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":10},"in_reply_to":"38a8acad_cfe4ebd7","updated":"2022-04-26 02:38:12.000000000","message":"Done","commit_id":"04066b1d4b56d171b6e4b4a3e84df7edeec1cbf1"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7e4f1d143aa0d3eaeffc89fd70a0f5725476a935","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This affects the serial execution of tempest test cases as"},{"line_number":14,"context_line":"instance_uuid is already associated to node which results in"},{"line_number":15,"context_line":"failure of consecutive test cases."},{"line_number":16,"context_line":"This dettaches instance_uuid of a node while cleanup."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I854c533ef4f76f3abb589dbcc9c39358ebedc194"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"03acc2c5_ae0733fa","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":14},"updated":"2022-04-20 07:47:11.000000000","message":"ditto","commit_id":"04066b1d4b56d171b6e4b4a3e84df7edeec1cbf1"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"fb2a9a19ea0a4685c3091b02563ab1b96d00bc5d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This affects the serial execution of tempest test cases as"},{"line_number":14,"context_line":"instance_uuid is already associated to node which results in"},{"line_number":15,"context_line":"failure of consecutive test cases."},{"line_number":16,"context_line":"This dettaches instance_uuid of a node while cleanup."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I854c533ef4f76f3abb589dbcc9c39358ebedc194"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a97bf3d8_c8f0b491","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":14},"in_reply_to":"03acc2c5_ae0733fa","updated":"2022-04-26 02:38:12.000000000","message":"Done","commit_id":"04066b1d4b56d171b6e4b4a3e84df7edeec1cbf1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"fb2a9a19ea0a4685c3091b02563ab1b96d00bc5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b47fa60b_e29d7527","updated":"2022-04-26 02:38:12.000000000","message":"Addressed review comments.","commit_id":"8f7ac92e84de1ed12c469917db9e67a9ee18af90"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b264fe13a7670f44301ce246510629d7233d61b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d47f6c75_5ce786df","updated":"2022-04-27 07:44:08.000000000","message":"Thanks Ameya, LGTM.","commit_id":"8f7ac92e84de1ed12c469917db9e67a9ee18af90"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"5a7e40757cf2e2a2cf004d7e8f67544506f2d282","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"69d5936b_76550575","updated":"2022-06-02 08:36:55.000000000","message":"Recheck","commit_id":"da80cccd868651a1ca60e6e41706bb5ad4973749"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"0096f05d14c227cb1fb8374407eeb4c925b6488d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b03487d5_1c1b66e5","updated":"2022-06-03 09:25:07.000000000","message":"Recheck","commit_id":"da80cccd868651a1ca60e6e41706bb5ad4973749"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"001d5f5c9080140edcef82e4750e5decfadc7c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0c9e8611_dbcf2287","updated":"2022-06-09 03:24:44.000000000","message":"Recheck","commit_id":"c652e31d4201f89ef74b2b953c7d01bb2885738b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"416e5d4c00cb6a8641053e89ddd911c45e8476a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b8e35298_b2fef917","updated":"2022-06-10 07:49:21.000000000","message":"recheck","commit_id":"c652e31d4201f89ef74b2b953c7d01bb2885738b"}],"ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"752774f9ed8d0774b9df57f7211e9cb571cb42a2","unresolved":true,"context_lines":[{"line_number":567,"context_line":"                cls.ports_client.delete_port(vif)"},{"line_number":568,"context_line":"            except lib_exc.NotFound:"},{"line_number":569,"context_line":"                pass"},{"line_number":570,"context_line":"        cls.terminate_node(cls.node[\u0027uuid\u0027])"},{"line_number":571,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":572,"context_line":"                                            \u0027path\u0027: \u0027/instance_uuid\u0027,"},{"line_number":573,"context_line":"                                            \u0027value\u0027: None}])"},{"line_number":574,"context_line":"        base.reset_baremetal_api_microversion()"},{"line_number":575,"context_line":"        super(BaremetalStandaloneManager, cls).resource_cleanup()"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ab58d9d2_60933082","line":573,"range":{"start_line":570,"start_character":0,"end_line":573,"end_character":60},"updated":"2022-05-23 15:18:14.000000000","message":"Termination of the node should remove this, If this is truly happening, this is a bug in ironic which needs to be fixed, not encoded as a workaround in the test code.","commit_id":"8f7ac92e84de1ed12c469917db9e67a9ee18af90"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"9b1b6321f07218029f0e47132e71f7b27dbc0700","unresolved":true,"context_lines":[{"line_number":567,"context_line":"                cls.ports_client.delete_port(vif)"},{"line_number":568,"context_line":"            except lib_exc.NotFound:"},{"line_number":569,"context_line":"                pass"},{"line_number":570,"context_line":"        cls.terminate_node(cls.node[\u0027uuid\u0027])"},{"line_number":571,"context_line":"        cls.update_node(cls.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":572,"context_line":"                                            \u0027path\u0027: \u0027/instance_uuid\u0027,"},{"line_number":573,"context_line":"                                            \u0027value\u0027: None}])"},{"line_number":574,"context_line":"        base.reset_baremetal_api_microversion()"},{"line_number":575,"context_line":"        super(BaremetalStandaloneManager, cls).resource_cleanup()"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"862bf9f4_48a56d91","line":573,"range":{"start_line":570,"start_character":0,"end_line":573,"end_character":60},"in_reply_to":"ab58d9d2_60933082","updated":"2022-06-08 10:17:35.000000000","message":"In terminate_node method, node gets deleted only when delete_node \u003d True. For test cases, which rely on delete_node \u003d False does not satisfies the condition and hence raising this patch.\n\nterminate_node link : https://github.com/openstack/ironic-tempest-plugin/blob/023c01e7e1214153229da14e2a22d6caadc8dab6/ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py#L290\n\nOther point, test cases in which nodes are in state other than \"active\", fails deleting in terminate_node method (if delete_node \u003d True) as per state diagram.\n\nLink : https://docs.openstack.org/ironic/latest/_images/states.svg","commit_id":"8f7ac92e84de1ed12c469917db9e67a9ee18af90"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7893e354eef394e07c5e26ce8dfcf4557bda9ba7","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @classmethod"},{"line_number":126,"context_line":"    def _disassociate_instance_with_node(cls, node_id):"},{"line_number":127,"context_line":"        \"\"\"Disassociate instance_uuid for attached node."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param node_id: Name or UUID of the node."},{"line_number":130,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"b4dfc257_e6bc5d51","line":127,"range":{"start_line":127,"start_character":38,"end_line":127,"end_character":42},"updated":"2022-06-08 14:45:12.000000000","message":"\"from\" maybe?","commit_id":"cdfbe9988d128101dea372926c9e6a2733904478"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"1a3862b915c174b62c78724b9648126b2b5694d1","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @classmethod"},{"line_number":126,"context_line":"    def _disassociate_instance_with_node(cls, node_id):"},{"line_number":127,"context_line":"        \"\"\"Disassociate instance_uuid for attached node."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param node_id: Name or UUID of the node."},{"line_number":130,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"f43ec2b1_ee1f21cd","line":127,"range":{"start_line":127,"start_character":38,"end_line":127,"end_character":42},"in_reply_to":"b4dfc257_e6bc5d51","updated":"2022-06-08 15:12:42.000000000","message":"Done","commit_id":"cdfbe9988d128101dea372926c9e6a2733904478"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"7893e354eef394e07c5e26ce8dfcf4557bda9ba7","unresolved":true,"context_lines":[{"line_number":244,"context_line":"    def unreserve_node(cls, node):"},{"line_number":245,"context_line":"        \"\"\"Unreserves node by disassociating instance_uuid attached to node."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param node: Ironic node to disassociate instance_uuid with."},{"line_number":248,"context_line":"        \"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        def _try_to_disassociate_instance():"}],"source_content_type":"text/x-python","patch_set":4,"id":"647898dc_2222a6fb","line":247,"range":{"start_line":247,"start_character":63,"end_line":247,"end_character":67},"updated":"2022-06-08 14:45:12.000000000","message":"\"from\" perhaps","commit_id":"cdfbe9988d128101dea372926c9e6a2733904478"},{"author":{"_account_id":31719,"name":"Ameya Raut","email":"rautameya04@gmail.com","username":"ameyar"},"change_message_id":"1a3862b915c174b62c78724b9648126b2b5694d1","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    def unreserve_node(cls, node):"},{"line_number":245,"context_line":"        \"\"\"Unreserves node by disassociating instance_uuid attached to node."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        :param node: Ironic node to disassociate instance_uuid with."},{"line_number":248,"context_line":"        \"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        def _try_to_disassociate_instance():"}],"source_content_type":"text/x-python","patch_set":4,"id":"afab4b9c_3f1e767f","line":247,"range":{"start_line":247,"start_character":63,"end_line":247,"end_character":67},"in_reply_to":"647898dc_2222a6fb","updated":"2022-06-08 15:12:42.000000000","message":"Done","commit_id":"cdfbe9988d128101dea372926c9e6a2733904478"}]}