)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"2b25689c418b10ce1d59cbb0d56747912bd81bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0f1b600_2b2524d8","updated":"2022-07-05 12:40:27.000000000","message":"Recheck","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"28acfeb84921a3841e871bb845ba8fe724670dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d66e2fac_6ac90f28","updated":"2022-07-06 06:43:51.000000000","message":"thanks Swapnil for the patch, some comments inline.","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"975f68e2279fa8405f12db28563c1e686d5f9620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e4dfc85_6b9934fd","updated":"2022-07-08 07:09:20.000000000","message":"thanks for the updates, LGTM.","commit_id":"17397a7187a7636643e7462bc5c9db409170a226"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67a896f86b004974a198867dde011834dc2fc2b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"41f7ba0f_02e816e9","updated":"2022-07-18 18:53:13.000000000","message":"I suspect this test is problematic for a couple different reasons:\n\n1) Somebody getting hardware in that no longer supports bios mode, which is something we\u0027re seeing occurring already. Which means the test has to know if it can schedule and execute against the node, which means the test starts with the base flavor. This seems like additional information that would be needed to safely have such a test.\n2) (and definitely a lesser concern, but the properties change needs to be rolled back as a cleanup), it is leaving a persistent state change of the preference which is advertised for scheduling on the node properties.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bc1564af16cc1bc40c77a26a8ca11ab165b91f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"741703c5_1547fe1a","updated":"2022-09-21 13:42:24.000000000","message":"lgtm, not approving directly  to see if Julia has some concern about it","commit_id":"2e680f9f801c1ebc062533b8c3bbc18135755f56"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"0fb182a9c327454d000ba6566ac25c97f36d0ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ead3f647_5eb11749","updated":"2022-09-21 15:15:54.000000000","message":"recheck ironic-standalone-yoga intermittent ping failure ","commit_id":"2e680f9f801c1ebc062533b8c3bbc18135755f56"}],"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_basic_ops.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"28acfeb84921a3841e871bb845ba8fe724670dcd","unresolved":true,"context_lines":[{"line_number":440,"context_line":"        self.boot_and_verify_node()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class BaremetalIdracSyncBootModeDirectWholedisk("},{"line_number":444,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    mandatory_attr \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a095e75_a04fb0dc","line":443,"range":{"start_line":443,"start_character":6,"end_line":443,"end_character":47},"updated":"2022-07-06 06:43:51.000000000","message":"include Redfish in name or is it too long? - BaremetalIdracRedfishSyncBootModeDirectWholedisk","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"975f68e2279fa8405f12db28563c1e686d5f9620","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        self.boot_and_verify_node()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class BaremetalIdracSyncBootModeDirectWholedisk("},{"line_number":444,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    mandatory_attr \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8cc7893_edf34d5c","line":443,"range":{"start_line":443,"start_character":6,"end_line":443,"end_character":47},"in_reply_to":"251ea88a_98854c81","updated":"2022-07-08 07:09:20.000000000","message":"Ack","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"11ca5f1cf449fe9a15535346d7607be81d7e9c05","unresolved":true,"context_lines":[{"line_number":440,"context_line":"        self.boot_and_verify_node()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class BaremetalIdracSyncBootModeDirectWholedisk("},{"line_number":444,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    mandatory_attr \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"251ea88a_98854c81","line":443,"range":{"start_line":443,"start_character":6,"end_line":443,"end_character":47},"in_reply_to":"9a095e75_a04fb0dc","updated":"2022-07-08 05:21:03.000000000","message":"It is too long, so kept it as it is","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"28acfeb84921a3841e871bb845ba8fe724670dcd","unresolved":true,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class BaremetalIdracSyncBootModeDirectWholedisk("},{"line_number":444,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    mandatory_attr \u003d \\"},{"line_number":447,"context_line":"        [\u0027driver\u0027, \u0027power_interface\u0027, \u0027management_interface\u0027,"},{"line_number":448,"context_line":"            \u0027bios_interface\u0027]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    api_microversion \u003d \u00271.40\u0027  # to get list_node_bios_settings"},{"line_number":451,"context_line":"    driver \u003d \u0027idrac\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"664bd94c_1f45dd3b","line":448,"range":{"start_line":445,"start_character":0,"end_line":448,"end_character":29},"updated":"2022-07-06 06:43:51.000000000","message":"avoid using \\ for breaking lines, suggesting to reformat this to:\n\n    mandatory_attr \u003d [\u0027driver\u0027, \u0027power_interface\u0027,  \u0027management_interface\u0027,\n                      \u0027bios_interface\u0027]","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"11ca5f1cf449fe9a15535346d7607be81d7e9c05","unresolved":true,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class BaremetalIdracSyncBootModeDirectWholedisk("},{"line_number":444,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    mandatory_attr \u003d \\"},{"line_number":447,"context_line":"        [\u0027driver\u0027, \u0027power_interface\u0027, \u0027management_interface\u0027,"},{"line_number":448,"context_line":"            \u0027bios_interface\u0027]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    api_microversion \u003d \u00271.40\u0027  # to get list_node_bios_settings"},{"line_number":451,"context_line":"    driver \u003d \u0027idrac\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"c423183e_84fe64cd","line":448,"range":{"start_line":445,"start_character":0,"end_line":448,"end_character":29},"in_reply_to":"664bd94c_1f45dd3b","updated":"2022-07-08 05:21:03.000000000","message":"Done","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"975f68e2279fa8405f12db28563c1e686d5f9620","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"class BaremetalIdracSyncBootModeDirectWholedisk("},{"line_number":444,"context_line":"        bsm.BaremetalStandaloneScenarioTest):"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    mandatory_attr \u003d \\"},{"line_number":447,"context_line":"        [\u0027driver\u0027, \u0027power_interface\u0027, \u0027management_interface\u0027,"},{"line_number":448,"context_line":"            \u0027bios_interface\u0027]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    api_microversion \u003d \u00271.40\u0027  # to get list_node_bios_settings"},{"line_number":451,"context_line":"    driver \u003d \u0027idrac\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"854d6416_00b9d18b","line":448,"range":{"start_line":445,"start_character":0,"end_line":448,"end_character":29},"in_reply_to":"c423183e_84fe64cd","updated":"2022-07-08 07:09:20.000000000","message":"Done","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"28acfeb84921a3841e871bb845ba8fe724670dcd","unresolved":true,"context_lines":[{"line_number":459,"context_line":"    bios_mode \u003d \u0027boot_mode:bios\u0027"},{"line_number":460,"context_line":"    uefi_mode \u003d \u0027boot_mode:uefi\u0027"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def get_boot_mode_to_update(self):"},{"line_number":463,"context_line":"        _, bios_settings \u003d self.baremetal_client.\\"},{"line_number":464,"context_line":"            list_node_bios_settings(self.node[\u0027uuid\u0027])"},{"line_number":465,"context_line":"        for attr_name in bios_settings[\u0027bios\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"035f71ad_0a73c458","line":462,"range":{"start_line":462,"start_character":8,"end_line":462,"end_character":31},"updated":"2022-07-06 06:43:51.000000000","message":"make this method \"private\" (prefix with _).","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"11ca5f1cf449fe9a15535346d7607be81d7e9c05","unresolved":true,"context_lines":[{"line_number":459,"context_line":"    bios_mode \u003d \u0027boot_mode:bios\u0027"},{"line_number":460,"context_line":"    uefi_mode \u003d \u0027boot_mode:uefi\u0027"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def get_boot_mode_to_update(self):"},{"line_number":463,"context_line":"        _, bios_settings \u003d self.baremetal_client.\\"},{"line_number":464,"context_line":"            list_node_bios_settings(self.node[\u0027uuid\u0027])"},{"line_number":465,"context_line":"        for attr_name in bios_settings[\u0027bios\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"20d4eedf_2525b486","line":462,"range":{"start_line":462,"start_character":8,"end_line":462,"end_character":31},"in_reply_to":"035f71ad_0a73c458","updated":"2022-07-08 05:21:03.000000000","message":"Done","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"975f68e2279fa8405f12db28563c1e686d5f9620","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    bios_mode \u003d \u0027boot_mode:bios\u0027"},{"line_number":460,"context_line":"    uefi_mode \u003d \u0027boot_mode:uefi\u0027"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def get_boot_mode_to_update(self):"},{"line_number":463,"context_line":"        _, bios_settings \u003d self.baremetal_client.\\"},{"line_number":464,"context_line":"            list_node_bios_settings(self.node[\u0027uuid\u0027])"},{"line_number":465,"context_line":"        for attr_name in bios_settings[\u0027bios\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e67b9b6a_7997eccb","line":462,"range":{"start_line":462,"start_character":8,"end_line":462,"end_character":31},"in_reply_to":"20d4eedf_2525b486","updated":"2022-07-08 07:09:20.000000000","message":"Done","commit_id":"41ec8896b1d2f5e56a393627927294c059b98151"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67a896f86b004974a198867dde011834dc2fc2b1","unresolved":true,"context_lines":[{"line_number":618,"context_line":"    @decorators.idempotent_id(\u0027c2bebda2-fd27-4b10-9015-f7d877f0eb60\u0027)"},{"line_number":619,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_sync_boot_mode(self):"},{"line_number":621,"context_line":"        boot_mode_path \u003d \u0027/properties/capabilities\u0027"},{"line_number":622,"context_line":"        mode_to_update \u003d self._get_boot_mode_to_update()"},{"line_number":623,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":624,"context_line":"                                              \u0027path\u0027: boot_mode_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5600c401_82f5cf11","line":621,"range":{"start_line":621,"start_character":0,"end_line":621,"end_character":51},"updated":"2022-07-18 18:53:13.000000000","message":"For what it is worth, this is what the node is capable of for scheduling, which is used if not otherwise defined on the instance info which details what was in the flavor.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5e4f69852506880ff9f9940fc07f0b3484d53134","unresolved":true,"context_lines":[{"line_number":618,"context_line":"    @decorators.idempotent_id(\u0027c2bebda2-fd27-4b10-9015-f7d877f0eb60\u0027)"},{"line_number":619,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_sync_boot_mode(self):"},{"line_number":621,"context_line":"        boot_mode_path \u003d \u0027/properties/capabilities\u0027"},{"line_number":622,"context_line":"        mode_to_update \u003d self._get_boot_mode_to_update()"},{"line_number":623,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":624,"context_line":"                                              \u0027path\u0027: boot_mode_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"59193b68_d98c3af3","line":621,"range":{"start_line":621,"start_character":0,"end_line":621,"end_character":51},"in_reply_to":"099a14b2_030847e9","updated":"2022-07-20 13:35:16.000000000","message":"Okay, there are two fields\n\n\u0027/properties/capabilities\u0027 which is \"What are the capabilities of the node which can be used. This field is fallen back to if instance_info field does not contain a capabilities field.\n\n\u0027/instance_info/capabilities\u0027 is what should be used when requesting a node\u0027s state for deployment.\n\nhttps://github.com/openstack/ironic/blob/a346ee4d7fef2922706bf6d9efd13c0292d0f8b7/ironic/drivers/modules/boot_mode_utils.py#L235-L277","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"118aa47fbe133984079f4976572266079a65eef3","unresolved":true,"context_lines":[{"line_number":618,"context_line":"    @decorators.idempotent_id(\u0027c2bebda2-fd27-4b10-9015-f7d877f0eb60\u0027)"},{"line_number":619,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_sync_boot_mode(self):"},{"line_number":621,"context_line":"        boot_mode_path \u003d \u0027/properties/capabilities\u0027"},{"line_number":622,"context_line":"        mode_to_update \u003d self._get_boot_mode_to_update()"},{"line_number":623,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":624,"context_line":"                                              \u0027path\u0027: boot_mode_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"099a14b2_030847e9","line":621,"range":{"start_line":621,"start_character":0,"end_line":621,"end_character":51},"in_reply_to":"5600c401_82f5cf11","updated":"2022-07-20 05:21:00.000000000","message":"Can you please explain this point in more detail","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"bdc103dd0650c6d44d033110be7ad7b14a39a6f2","unresolved":true,"context_lines":[{"line_number":618,"context_line":"    @decorators.idempotent_id(\u0027c2bebda2-fd27-4b10-9015-f7d877f0eb60\u0027)"},{"line_number":619,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_sync_boot_mode(self):"},{"line_number":621,"context_line":"        boot_mode_path \u003d \u0027/properties/capabilities\u0027"},{"line_number":622,"context_line":"        mode_to_update \u003d self._get_boot_mode_to_update()"},{"line_number":623,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":624,"context_line":"                                              \u0027path\u0027: boot_mode_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f549db96_ea14ba66","line":621,"range":{"start_line":621,"start_character":0,"end_line":621,"end_character":51},"in_reply_to":"59193b68_d98c3af3","updated":"2022-07-22 04:27:21.000000000","message":"Sure I will try with this approach","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b8822c5d652b932dda8de46e3a4b7f036a763eba","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    @decorators.idempotent_id(\u0027c2bebda2-fd27-4b10-9015-f7d877f0eb60\u0027)"},{"line_number":619,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_sync_boot_mode(self):"},{"line_number":621,"context_line":"        boot_mode_path \u003d \u0027/properties/capabilities\u0027"},{"line_number":622,"context_line":"        mode_to_update \u003d self._get_boot_mode_to_update()"},{"line_number":623,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":624,"context_line":"                                              \u0027path\u0027: boot_mode_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"89689ed9_29d857e5","line":621,"range":{"start_line":621,"start_character":0,"end_line":621,"end_character":51},"in_reply_to":"7ba34a91_19c8d84f","updated":"2022-09-12 13:09:42.000000000","message":"Done","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"fc0aa8ec280d8db6b68cbe257ad182e25c55068c","unresolved":true,"context_lines":[{"line_number":618,"context_line":"    @decorators.idempotent_id(\u0027c2bebda2-fd27-4b10-9015-f7d877f0eb60\u0027)"},{"line_number":619,"context_line":"    @utils.services(\u0027image\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_sync_boot_mode(self):"},{"line_number":621,"context_line":"        boot_mode_path \u003d \u0027/properties/capabilities\u0027"},{"line_number":622,"context_line":"        mode_to_update \u003d self._get_boot_mode_to_update()"},{"line_number":623,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":624,"context_line":"                                              \u0027path\u0027: boot_mode_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ba34a91_19c8d84f","line":621,"range":{"start_line":621,"start_character":0,"end_line":621,"end_character":51},"in_reply_to":"f549db96_ea14ba66","updated":"2022-07-22 12:51:08.000000000","message":"Done","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67a896f86b004974a198867dde011834dc2fc2b1","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4eb9682f_24db8a4b","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"updated":"2022-07-18 18:53:13.000000000","message":"I guess my concern here is that we\u0027re not returning the node to a consistent state. The effect of a tempest run should be from a use standpoint, and this leaves a persistent, alternating setting.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"371877cb8c665df68ab11cb06c65ed58b64d38b7","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c6413e8_67c5c50f","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"087e2169_f65e6a0a","updated":"2022-08-10 12:56:29.000000000","message":"1) We can put a note and mention that image should be compatible\n2)Regarding the cleaning instead of rebuild we checked code of manual cleaning in baremetal_standalone_manager.py where we can do the\nfactory reset but there is an issue while doing factory reset below url for reference\nhttps://docs.openstack.org/ironic/latest/admin/drivers/idrac.html#pxe-reset-with-factory-reset-bios-clean-step\n\nso can you please suggest any reference or any example that might help us","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"50fa816ee85ac2939f08d08a3ee5cd54386e6116","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"62474df5_b876965b","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"1a04a771_0e0f4da5","updated":"2022-09-15 12:38:39.000000000","message":"Resolving this as In another comment I have mentioned that no need for the code change","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"118aa47fbe133984079f4976572266079a65eef3","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ee04163d_a432d245","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"4eb9682f_24db8a4b","updated":"2022-07-20 05:21:00.000000000","message":"Is it not enough to revert the boot mode in the test when rebuilding as we are doing at line number 634? Is there a another way or place to return node to a consistent state? Any examples of existing tests? Or is it about not overwriting \u0027/properties/capabilities\u0027 and setting back to the value what was there before the test if it was set at all?","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"bdc103dd0650c6d44d033110be7ad7b14a39a6f2","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e5105d0_54600072","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"60fb7297_a2124378","updated":"2022-07-22 04:27:21.000000000","message":"1. As the image is configurable in code so we can give reference of the image on which we want to test it.\n2. This test case is meant for only idrac systems.\n3. In order to automate the sync boot mode functionality if this is not the proper approach then can you please suggest an alternative approach for it?","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3290d9e6c9bbc41a40eb4df2ad707631197ea666","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"087e2169_f65e6a0a","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"7e5105d0_54600072","updated":"2022-08-08 16:34:31.000000000","message":"1) Yes, that is a possibility, however not every image works for other modes. It seems like it needs to be explicit, but it is a user configurable variable. I feel like the test needs to be explicit and state.\n2) It being only for idrac does not really address my concern, which was more \"rebuild is not exactly intended to be used this way\", in terms of reconfiguring the machine. It might just work fine though, but then again, not every image works in both modes, and this may be an easy stest for people to break if they independently.\n3) The list was not a list of issues, but more an emumeration of thoughts.\n\nIdeally, the node should be returned to the original state using a cleanup method call.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6621b730aea77f37c59b0e7bac58784b20b7e69a","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a04a771_0e0f4da5","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"8c6413e8_67c5c50f","updated":"2022-08-15 14:29:57.000000000","message":"1) That seems reasonable.\n2) I\u0027m afraid I don\u0027t understand, are you now wanting to run a factory reset clean step as well?","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5e4f69852506880ff9f9940fc07f0b3484d53134","unresolved":true,"context_lines":[{"line_number":628,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":629,"context_line":"        else:"},{"line_number":630,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"60fb7297_a2124378","line":633,"range":{"start_line":631,"start_character":0,"end_line":633,"end_character":72},"in_reply_to":"ee04163d_a432d245","updated":"2022-07-20 13:35:16.000000000","message":"I don\u0027t see this as a revert of the intended test state. I see what your explicitly testing as\n1) Boot/deploy the node using whatever it has setting wise at the start of the test.\n2) Rebuild the node so the boot mode is... in theory... changed upon the rebuild.\n3) Wait until the node is again in active state.\n\nWe\u0027re not actually testing that the machine works, which might be smart because not all instance operating systems can be redeployed when changing boot mode.\n\nUltimately, this has never been done before as Tempest is API contract testing, not mechanics integration for testing hardware\u0027s ability to toggle boot mode. Given the entire deprecation of bios boot mode by intel, I just don\u0027t think this overall test is a good idea.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"67a896f86b004974a198867dde011834dc2fc2b1","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6effc311_610ef311","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"updated":"2022-07-18 18:53:13.000000000","message":"I guess a conundrum here is there is a risk with images not being *able* to, or muchless the hardware even being guaranteed to be able to toggle mode back and forth. We\u0027ve already seen some of the ?crystal lake? chips not supporting this.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5e4f69852506880ff9f9940fc07f0b3484d53134","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dacadfb8_483f4e0b","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"in_reply_to":"31c54539_9d3e401a","updated":"2022-07-20 13:35:16.000000000","message":"It does look like the Ice Lake (10nm) server line is the one I had in mind.\n\nLooks like the high end processors dell is selling are still Cascade Lake (14nm), so the likely next server processor generation where it just won\u0027t work anymore.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"371877cb8c665df68ab11cb06c65ed58b64d38b7","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c25514c_c0d91a76","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"in_reply_to":"38cced49_822c277f","updated":"2022-08-10 12:56:29.000000000","message":"we will put an appropriate note","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"50fa816ee85ac2939f08d08a3ee5cd54386e6116","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f9874b58_83912f8c","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"in_reply_to":"4c25514c_c0d91a76","updated":"2022-09-15 12:38:39.000000000","message":"Done","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"118aa47fbe133984079f4976572266079a65eef3","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"31c54539_9d3e401a","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"in_reply_to":"6effc311_610ef311","updated":"2022-07-20 05:21:00.000000000","message":"Does it mean ice lake instead of crystal lake? if yes then on on which ice lake systems this does not work? are those Dell systems?","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"bdc103dd0650c6d44d033110be7ad7b14a39a6f2","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed10f702_d8d22ba0","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"in_reply_to":"dacadfb8_483f4e0b","updated":"2022-07-22 04:27:21.000000000","message":"As long as we have existing systems which supports this, we will use it as a part of our regression testing, and for future processor generation we might not use it","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3290d9e6c9bbc41a40eb4df2ad707631197ea666","unresolved":true,"context_lines":[{"line_number":631,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":632,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":633,"context_line":"                                              \u0027value\u0027: mode_to_update}])"},{"line_number":634,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":635,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":636,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":637,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":3,"id":"38cced49_822c277f","line":634,"range":{"start_line":634,"start_character":7,"end_line":634,"end_character":67},"in_reply_to":"ed10f702_d8d22ba0","updated":"2022-08-08 16:34:31.000000000","message":"Okay! I just hope it is understood that people outside of dell *will* attempt to execute this test. It might be good to put notes in regaridng use/intent.","commit_id":"ea9346dfd5b13bb698842327dbcf36a9c0a789c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3290d9e6c9bbc41a40eb4df2ad707631197ea666","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"318cd176_c6dd809f","line":647,"updated":"2022-08-08 16:34:31.000000000","message":"Given the comment on the other test that the image can define what it prefers, you may want to explicitly fail or skip the test.","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6621b730aea77f37c59b0e7bac58784b20b7e69a","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae35fc47_080b92cf","line":647,"in_reply_to":"0bfa935d_a86bf301","updated":"2022-08-15 14:29:57.000000000","message":"Perhaps check the image properties?\n\n\nhttps://github.com/openstack/tempest/blob/7e96c8e854386f43604ad098a6ec7606ee676145/tempest/api/image/v2/test_images.py#L83\n\n*but*\n\nit would be self.image_client.show_image()","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"371877cb8c665df68ab11cb06c65ed58b64d38b7","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"0bfa935d_a86bf301","line":647,"in_reply_to":"318cd176_c6dd809f","updated":"2022-08-10 12:56:29.000000000","message":"In order to skip or fail the test case on the basis of Image, how can we determine it or what should be the condition to fail or skip the test case? Can you please give an example or any suggestion?","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"50fa816ee85ac2939f08d08a3ee5cd54386e6116","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"23caaf80_8127391b","line":647,"in_reply_to":"3596e8cf_effab596","updated":"2022-09-15 12:38:39.000000000","message":"Done","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f18408a6ab5500eeb666af04c8045f5ce046c9e9","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"abdcc54f_7011234b","line":647,"in_reply_to":"97f2c5de_c6501046","updated":"2022-08-25 13:19:13.000000000","message":"Properties are user/admin registered when uploaded.\n\nThis is the command for libvirt VMs: openstack image set --property hw_firmware_type\u003duefi $IMAGE\n\nBut it is not returned, and we use flavors for Ironic.\n\nI guess it is fine to do what your doing, your likely just going to need to add an inline note in the test so at least someone trying to run it can identify \"oh, this must be this type of image, which must meet x,y,z requirements to successfully pass.","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"367c67d4ed82d572afabc92698feef707cdf7462","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3596e8cf_effab596","line":647,"in_reply_to":"abdcc54f_7011234b","updated":"2022-08-26 09:47:43.000000000","message":"added the inline note","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"6174349226fda7a8814c919f3432ba9b31832a36","unresolved":true,"context_lines":[{"line_number":644,"context_line":"        if mode_to_update \u003d\u003d self.uefi_mode:"},{"line_number":645,"context_line":"            mode_to_update \u003d self.bios_mode"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            mode_to_update \u003d self.uefi_mode"},{"line_number":648,"context_line":"        self.update_node(self.node[\u0027uuid\u0027], [{\u0027op\u0027: \u0027replace\u0027,"},{"line_number":649,"context_line":"                                              \u0027path\u0027: boot_mode_path,"},{"line_number":650,"context_line":"                                              \u0027value\u0027: mode_to_update}])"}],"source_content_type":"text/x-python","patch_set":4,"id":"97f2c5de_c6501046","line":647,"in_reply_to":"ae35fc47_080b92cf","updated":"2022-08-25 11:50:10.000000000","message":"Below is the output returned from self.image_client.show_image(), so which property can be used in order to fail or skip the test case\n\n{\u0027kernel_id\u0027: \u0027897e6eaa-d7f6-4d89-8f19-2ea14d4a74bf\u0027, \u0027owner_specified.openstack.md5\u0027: \u0027\u0027, \u0027owner_specified.openstack.object\u0027: \u0027images/overcloud-full\u0027, \u0027owner_specified.openstack.sha256\u0027: \u0027\u0027, \u0027ramdisk_id\u0027: \u0027b64758bf-4624-48b1-a135-2b6cd894651f\u0027, \u0027name\u0027: \u0027overcloud-full\u0027, \u0027disk_format\u0027: \u0027ami\u0027, \u0027container_format\u0027: \u0027ami\u0027, \u0027visibility\u0027: \u0027public\u0027, \u0027size\u0027: 1220476928, \u0027virtual_size\u0027: None, \u0027status\u0027: \u0027active\u0027, \u0027checksum\u0027:\u0027178809a76d41824d655578d104f0b872\u0027, \u0027protected\u0027: False,\u0027min_ram\u0027: 0, \u0027min_disk\u0027: 0, \u0027owner\u0027: \u0027b265a498b177481da93ce0450316ad8f\u0027, \u0027os_hidden\u0027: False, \u0027os_hash_algo\u0027:\u0027sha512\u0027,\u0027os_hash_value\u0027:\u0027190e1c670dd38f81d978cc79ea9aa6d15e682e192e79c0c3338789fa9c3b16ff5263a9e9d0e0622682806dd94a16e139d93a6b44393eeb2c77a2a3cc6a008350\u0027, \u0027id\u0027: \u0027093c9d56-c9f3-4659-b3ec-06dc7b150af9\u0027, \u0027created_at\u0027: \u00272022-08-08T10:49:21Z\u0027, \u0027updated_at\u0027: \u00272022-08-08T10:49:38Z\u0027, \u0027tags\u0027: [], \u0027self\u0027: \u0027/v2/images/093c9d56-c9f3-4659-b3ec-06dc7b150af9\u0027, \u0027file\u0027: \u0027/v2/images/093c9d56-c9f3-4659-b3ec-06dc7b150af9/file\u0027, \u0027schema\u0027: \u0027/v2/schemas/image\u0027}","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3290d9e6c9bbc41a40eb4df2ad707631197ea666","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fdd932a2_f971615e","line":654,"updated":"2022-08-08 16:34:31.000000000","message":"Please explicitly teardown the node so the test leaves ironic as it found it. The current mananager does not have an automatic cleanup added.","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f18408a6ab5500eeb666af04c8045f5ce046c9e9","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac21fd0_a0b7bb1b","line":654,"in_reply_to":"0e396727_1f375658","updated":"2022-08-25 13:19:13.000000000","message":"so tearing down is likely not needed, looks like nodes are automatically torn down in standalone testing. it is just not quick.","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"50fa816ee85ac2939f08d08a3ee5cd54386e6116","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8fd50102_41f35a33","line":654,"in_reply_to":"0ea0c897_1c7bf7fa","updated":"2022-09-15 12:38:39.000000000","message":"As not code change required, resolving this comment","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"367c67d4ed82d572afabc92698feef707cdf7462","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2655eeec_a2992f87","line":654,"in_reply_to":"1ac21fd0_a0b7bb1b","updated":"2022-08-26 09:47:43.000000000","message":"Ok, so did not add any extra code","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b8822c5d652b932dda8de46e3a4b7f036a763eba","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ea0c897_1c7bf7fa","line":654,"in_reply_to":"2655eeec_a2992f87","updated":"2022-09-12 13:09:42.000000000","message":"correct","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6621b730aea77f37c59b0e7bac58784b20b7e69a","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0e396727_1f375658","line":654,"in_reply_to":"2c8fb253_bf53bf74","updated":"2022-08-15 14:29:57.000000000","message":"https://github.com/openstack/ironic-tempest-plugin/blob/3af6253bc96ba1897feb0a88e60bddd0097d05ff/ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py#L689 is one option, albeit modified to call self.terminate_node(uuid).\n\nIf you take that path, which I think it would be preferred, you\u0027ll want to call it right after boot_and_verify_node is called.\n\n\nAlternatively you can just acll self.terminate_node(uuid) at the end of the test.","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"},{"author":{"_account_id":34694,"name":"Swapnil Machikar","email":"swapnil.machikar@yahoo.com","username":"smachi"},"change_message_id":"371877cb8c665df68ab11cb06c65ed58b64d38b7","unresolved":true,"context_lines":[{"line_number":651,"context_line":"        self.set_node_provision_state(self.node[\u0027uuid\u0027], \u0027rebuild\u0027)"},{"line_number":652,"context_line":"        self.wait_provisioning_state(self.node[\u0027uuid\u0027], \u0027active\u0027,"},{"line_number":653,"context_line":"                                     timeout\u003dCONF.baremetal.active_timeout,"},{"line_number":654,"context_line":"                                     interval\u003d30)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c8fb253_bf53bf74","line":654,"in_reply_to":"fdd932a2_f971615e","updated":"2022-08-10 12:56:29.000000000","message":"should it be different than the above clean up?","commit_id":"09d9491e84f950e54a75996f0a3f598ea1a114e8"}]}