)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d4d395ff8a2d0641787f0d344caa13700207951","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kamlesh Chauvhan \u003ckamlesh.chauvhan@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-18 10:43:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add iDRAC Redfish firmware update test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds test for firmware update using iDRAC redfish."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f7d20858_efc311c9","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":17},"updated":"2022-08-19 07:04:36.000000000","message":"this patch also contains test for `redfish` hardware type. Suggest to update title to \"Add Redfish firmware update test\" and in description section mention both `redfish` and `idrac` hardware types.","commit_id":"97af1e6ccd761b8e7ffff4adaf4b900a6edf5d9d"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"4ecba54cc1391b3baa687a46ebb37f5c9738658a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kamlesh Chauvhan \u003ckamlesh.chauvhan@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-18 10:43:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add iDRAC Redfish firmware update test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds test for firmware update using iDRAC redfish."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7bc0788c_44535874","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":17},"in_reply_to":"d6a62237_848c7ab6","updated":"2022-08-19 07:41:05.000000000","message":"Done","commit_id":"97af1e6ccd761b8e7ffff4adaf4b900a6edf5d9d"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"87bb73012193b2a2d7dc081f653c02386c73c61c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kamlesh Chauvhan \u003ckamlesh.chauvhan@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-08-18 10:43:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add iDRAC Redfish firmware update test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds test for firmware update using iDRAC redfish."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d6a62237_848c7ab6","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":17},"in_reply_to":"f7d20858_efc311c9","updated":"2022-08-19 07:35:47.000000000","message":"Incorporated.","commit_id":"97af1e6ccd761b8e7ffff4adaf4b900a6edf5d9d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2d4d395ff8a2d0641787f0d344caa13700207951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb922603_3fc6475a","updated":"2022-08-19 07:04:36.000000000","message":"thanks for the patch, one comment inline.","commit_id":"97af1e6ccd761b8e7ffff4adaf4b900a6edf5d9d"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"87bb73012193b2a2d7dc081f653c02386c73c61c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04685767_62bf22b9","updated":"2022-08-19 07:35:47.000000000","message":"Incorporated Suggested Change. Thanks Aija.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"80c376ac20d9e21dc48fbec6f29d6334bded941d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27f4ef60_764f4edb","updated":"2022-08-19 07:50:51.000000000","message":"LGTM, thanks.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"4ecba54cc1391b3baa687a46ebb37f5c9738658a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e931aff_5d4a83ef","updated":"2022-08-19 07:41:05.000000000","message":"done","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"346f3090d6f3f92d58ea960e19eb6b95d421cadc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81209523_9c4f8651","updated":"2022-08-26 09:20:14.000000000","message":"HI Julia. Thanks for review Comment. Incorporated Suggested Changes.","commit_id":"e385aff1fe7e26e10697e32971c39cd784ebc789"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"624deec054176951dd3df850abc04a5c4508c511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"206a9b2a_fac88cad","updated":"2022-09-13 13:18:27.000000000","message":"Approving, looking at the past discussion I think all comments have been addressed.\nTks!","commit_id":"853164a480abee7e2f9c32837d2559c6ea101f06"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"9772cd06037a8475d6da548d3bbef4526f48a68b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1928b353_0e5260ee","updated":"2022-09-05 11:06:28.000000000","message":"Thanks for review comment. Incorporated suggested changes.","commit_id":"853164a480abee7e2f9c32837d2559c6ea101f06"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"8b35363333c399e4b930549bfe7b2c6df13cb746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d8a5396_22fb1bb9","updated":"2022-09-05 13:06:12.000000000","message":"Thanks, LGTM.","commit_id":"853164a480abee7e2f9c32837d2559c6ea101f06"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e3513479a9ce2822e18791582e782f869e2134dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf83898a_7d7f3850","updated":"2022-09-07 21:10:41.000000000","message":"There\u0027s nothing wrong with this code, hence my +2 vote.\n\nI must strongly caution you against this path. I presume you know a lot more about DELL/DRAC hardware than I do; but in my experience with running OnMetal, we were warned against flashing firmware chips too often due to write exhaustion. \n\nMy approval is predicated on the idea that you all know that this is safe for Dell hardware -- but please be careful; I don\u0027t want your third-party CI machines burning up :).\n","commit_id":"853164a480abee7e2f9c32837d2559c6ea101f06"}],"ironic_tempest_plugin/tests/scenario/ironic_standalone/test_cleaning.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdc9cb795eabd47abb5b8aa088db3ca47aa97eff","unresolved":true,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"class BaremetalRedfishFirmwareUpdate(bsm.BaremetalStandaloneScenarioTest):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    api_microversion \u003d \u00271.31\u0027  # to set the management_interface"},{"line_number":360,"context_line":"    driver \u003d \u0027redfish\u0027"},{"line_number":361,"context_line":"    delete_node \u003d False"},{"line_number":362,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6c8c4ba_b95f6adb","line":359,"range":{"start_line":359,"start_character":23,"end_line":359,"end_character":64},"updated":"2022-08-25 15:30:52.000000000","message":"while 1.31 is needed for management interface, the clean step your exercising didn\u0027t actually appear until around 1.68, so it would likely be more appropriate to have the minimum version be 1.68 *as* the feature would not exist in prior versions.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"346f3090d6f3f92d58ea960e19eb6b95d421cadc","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"class BaremetalRedfishFirmwareUpdate(bsm.BaremetalStandaloneScenarioTest):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    api_microversion \u003d \u00271.31\u0027  # to set the management_interface"},{"line_number":360,"context_line":"    driver \u003d \u0027redfish\u0027"},{"line_number":361,"context_line":"    delete_node \u003d False"},{"line_number":362,"context_line":"    image_ref \u003d CONF.baremetal.whole_disk_image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"1cfcce9d_7988023d","line":359,"range":{"start_line":359,"start_character":23,"end_line":359,"end_character":64},"in_reply_to":"e6c8c4ba_b95f6adb","updated":"2022-08-26 09:20:14.000000000","message":"Incorporated.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdc9cb795eabd47abb5b8aa088db3ca47aa97eff","unresolved":true,"context_lines":[{"line_number":402,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":403,"context_line":"    @decorators.idempotent_id(\u0027360e0c0e-3c17-4d2e-b052-55a932c1a4c7\u0027)"},{"line_number":404,"context_line":"    def test_firmware_update(self):"},{"line_number":405,"context_line":"        # WARNING: Removing power from a server while it is in the process of"},{"line_number":406,"context_line":"        # updating firmware may result in devices in the server, or the server"},{"line_number":407,"context_line":"        # itself becoming inoperable."},{"line_number":408,"context_line":"        # Execution of firmware test case needs careful execution as it"},{"line_number":409,"context_line":"        # changes state of server, may result in break down of server on"},{"line_number":410,"context_line":"        # interruption. As it deals with firmware of component, make sure"},{"line_number":411,"context_line":"        # to provide proper image url path while testing with correct SHA1"},{"line_number":412,"context_line":"        # checksum of image even for rollback image on which server would be"},{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"}],"source_content_type":"text/x-python","patch_set":2,"id":"54eef526_35535800","line":413,"range":{"start_line":405,"start_character":8,"end_line":413,"end_character":31},"updated":"2022-08-25 15:30:52.000000000","message":"given this warning, do we want to make the user of tempest have to explicitly enable this test?","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"9772cd06037a8475d6da548d3bbef4526f48a68b","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":403,"context_line":"    @decorators.idempotent_id(\u0027360e0c0e-3c17-4d2e-b052-55a932c1a4c7\u0027)"},{"line_number":404,"context_line":"    def test_firmware_update(self):"},{"line_number":405,"context_line":"        # WARNING: Removing power from a server while it is in the process of"},{"line_number":406,"context_line":"        # updating firmware may result in devices in the server, or the server"},{"line_number":407,"context_line":"        # itself becoming inoperable."},{"line_number":408,"context_line":"        # Execution of firmware test case needs careful execution as it"},{"line_number":409,"context_line":"        # changes state of server, may result in break down of server on"},{"line_number":410,"context_line":"        # interruption. As it deals with firmware of component, make sure"},{"line_number":411,"context_line":"        # to provide proper image url path while testing with correct SHA1"},{"line_number":412,"context_line":"        # checksum of image even for rollback image on which server would be"},{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3bfa7265_c88e2f9b","line":413,"range":{"start_line":405,"start_character":8,"end_line":413,"end_character":31},"in_reply_to":"14a8c37e_642c41b7","updated":"2022-09-05 11:06:28.000000000","message":"Done","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"346f3090d6f3f92d58ea960e19eb6b95d421cadc","unresolved":true,"context_lines":[{"line_number":402,"context_line":"    @utils.services(\u0027network\u0027)"},{"line_number":403,"context_line":"    @decorators.idempotent_id(\u0027360e0c0e-3c17-4d2e-b052-55a932c1a4c7\u0027)"},{"line_number":404,"context_line":"    def test_firmware_update(self):"},{"line_number":405,"context_line":"        # WARNING: Removing power from a server while it is in the process of"},{"line_number":406,"context_line":"        # updating firmware may result in devices in the server, or the server"},{"line_number":407,"context_line":"        # itself becoming inoperable."},{"line_number":408,"context_line":"        # Execution of firmware test case needs careful execution as it"},{"line_number":409,"context_line":"        # changes state of server, may result in break down of server on"},{"line_number":410,"context_line":"        # interruption. As it deals with firmware of component, make sure"},{"line_number":411,"context_line":"        # to provide proper image url path while testing with correct SHA1"},{"line_number":412,"context_line":"        # checksum of image even for rollback image on which server would be"},{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"}],"source_content_type":"text/x-python","patch_set":2,"id":"14a8c37e_642c41b7","line":413,"range":{"start_line":405,"start_character":8,"end_line":413,"end_character":31},"in_reply_to":"54eef526_35535800","updated":"2022-08-26 09:20:14.000000000","message":"I believe we don\u0027t require to explicitly enable this test. Test cases would be skipped if user would not provide Firmware Image Url and Checksum of it in tempest configuration file.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bdc9cb795eabd47abb5b8aa088db3ca47aa97eff","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"},{"line_number":417,"context_line":"                        CONF.baremetal.firmware_rollback_image_url,"},{"line_number":418,"context_line":"                        CONF.baremetal.firmware_rollback_image_checksum)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"class BaremetalIdracRedfishFirmwareUpdate(BaremetalRedfishFirmwareUpdate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"e552da1c_42044549","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":72},"updated":"2022-08-25 15:30:52.000000000","message":"Are we explicitly rolling back for a reason?  Should that be part of the test?\n\nIs it really needed? I guess a question might be, what would the cost be on the machines running this test frequently?","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":31616,"name":"Eric Barrera","email":"Eric_Barrera@Dell.com","username":"erbarr"},"change_message_id":"8854de208998fe6634b500be95b578cda64b58ec","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"},{"line_number":417,"context_line":"                        CONF.baremetal.firmware_rollback_image_url,"},{"line_number":418,"context_line":"                        CONF.baremetal.firmware_rollback_image_checksum)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"class BaremetalIdracRedfishFirmwareUpdate(BaremetalRedfishFirmwareUpdate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"15c5e9d5_edbaa667","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":72},"in_reply_to":"03113915_2e5b1559","updated":"2022-08-30 15:01:44.000000000","message":"Yea, I can think of something","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"08e52410d0765dcb9855f0621d06502e964a79ea","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"},{"line_number":417,"context_line":"                        CONF.baremetal.firmware_rollback_image_url,"},{"line_number":418,"context_line":"                        CONF.baremetal.firmware_rollback_image_checksum)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"class BaremetalIdracRedfishFirmwareUpdate(BaremetalRedfishFirmwareUpdate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3dfb754e_1f166fea","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":72},"in_reply_to":"15c5e9d5_edbaa667","updated":"2022-09-02 14:57:02.000000000","message":"I checked with firmware team if there are any limitations for iDRAC users, and they said there are no limitations. That\u0027s why I would prefer that there is optional rollback as a cleanup available for those willing to use it in one go. That is, if rollback url is provided, then add cleanup.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"9772cd06037a8475d6da548d3bbef4526f48a68b","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"},{"line_number":417,"context_line":"                        CONF.baremetal.firmware_rollback_image_url,"},{"line_number":418,"context_line":"                        CONF.baremetal.firmware_rollback_image_checksum)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"class BaremetalIdracRedfishFirmwareUpdate(BaremetalRedfishFirmwareUpdate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa7fc0e6_f47c9532","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":72},"in_reply_to":"3dfb754e_1f166fea","updated":"2022-09-05 11:06:28.000000000","message":"Addressed. Optional rollback has been added.","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b6e29502eabb6cf210ef42237b3dbfd9d7fce6e9","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"},{"line_number":417,"context_line":"                        CONF.baremetal.firmware_rollback_image_url,"},{"line_number":418,"context_line":"                        CONF.baremetal.firmware_rollback_image_checksum)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"class BaremetalIdracRedfishFirmwareUpdate(BaremetalRedfishFirmwareUpdate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"03113915_2e5b1559","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":72},"in_reply_to":"c1e151b4_f9478786","updated":"2022-08-30 08:43:48.000000000","message":"@Eric, will it be possible to run this test case automatically without manual intervention? E.g., run this test in sequence twice with different config values. First to test firmware update, second to roll it back to previous, so it\u0027s possible to test it again at some point without picking different version?\n\nWhile firmware upgrade can be risky, I wouldn\u0027t run this with BMC firmware (such as iDRAC) as that is rebooting iDRAC itself and takes more time. Better pick other components to check that firmware upgrade is still working with Ironic.\n\nMaybe make rollback configurable for those having more confidence or willing to take risks?","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"346f3090d6f3f92d58ea960e19eb6b95d421cadc","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        # moved during cleanup."},{"line_number":414,"context_line":"        self._firmware_update(CONF.baremetal.firmware_image_url,"},{"line_number":415,"context_line":"                              CONF.baremetal.firmware_image_checksum)"},{"line_number":416,"context_line":"        self.addCleanup(self._firmware_update,"},{"line_number":417,"context_line":"                        CONF.baremetal.firmware_rollback_image_url,"},{"line_number":418,"context_line":"                        CONF.baremetal.firmware_rollback_image_checksum)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"class BaremetalIdracRedfishFirmwareUpdate(BaremetalRedfishFirmwareUpdate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1e151b4_f9478786","line":418,"range":{"start_line":416,"start_character":0,"end_line":418,"end_character":72},"in_reply_to":"e552da1c_42044549","updated":"2022-08-26 09:20:14.000000000","message":"Removed rolling back firmware update as discussed https://meetings.opendev.org/irclogs/%23openstack-ironic/%23openstack-ironic.2022-08-25.log.html#t2022-08-25T15:20:50 .","commit_id":"b264acc4e7599fc1597fbb2ab774b6ebf11dc7a8"}]}