)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ebff691daac706f0ee152c1e17bab50693276e28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b3b48dcd_649c3565","updated":"2023-05-09 09:37:33.000000000","message":"```","commit_id":"b54beca6118232bd265a4dde7128dc82372be756"}],"ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ebff691daac706f0ee152c1e17bab50693276e28","unresolved":true,"context_lines":[{"line_number":719,"context_line":"        :param ind_ident: The indicator of a Bare Metal component."},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        \"\"\""},{"line_number":722,"context_line":"        path \u003d \u0027nodes/%s/management/indicators/%s\u0027 % (node_uuid, component)"},{"line_number":723,"context_line":"        resp, body \u003d self._list_request(path)"},{"line_number":724,"context_line":"        self.expected_success(http_client.OK, resp.status)"},{"line_number":725,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":5,"id":"e59a3fb4_43334b81","line":722,"range":{"start_line":722,"start_character":16,"end_line":722,"end_character":49},"updated":"2023-05-09 09:37:33.000000000","message":"This does not work, and the api-ref is in need of additional updates.\nGET /v1/nodes/{node_ident}/management/indicators/{component} as documented does not work.\n\nThis calls ironic.api.controllers.v1.node.IndicatorController.get_one and it will raise InvalidParameterValue in ironic.api.controllers.v1.node.IndicatorAtComponent\n\nConfirmed when testing:\n\n```\n2023-05-09 09:31:21,952 160894 INFO     [tempest.lib.common.rest_client] Request (TestNodeSystemReader:test_reader_can_get_indicator_state): 400 GET https://192.168.122.223/baremetal/v1/nodes/2b27c424-007b-435c-9332-83d0da1ea50d/management/indicators/system 0.095s\n2023-05-09 09:31:21,952 160894 DEBUG    [tempest.lib.common.rest_client] Request - Headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Accept\u0027: \u0027application/json\u0027, \u0027X-OpenStack-Ironic-API-Version\u0027: \u00271.70\u0027, \u0027X-Auth-Token\u0027: \u0027\u003comitted\u003e\u0027}\n        Body: None\n    Response - Headers: {\u0027date\u0027: \u0027Tue, 09 May 2023 09:31:21 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.52 (Ubuntu)\u0027, \u0027x-openstack-ironic-api-minimum-version\u0027: \u00271.1\u0027, \u0027x-openstack-ironic-api-maximum-version\u0027: \u00271.82\u0027, \u0027x-openstack-ironic-api-version\u0027: \u00271.70\u0027, \u0027openstack-request-id\u0027: \u0027req-a9ddb3b2-3210-42db-a16f-1df1ccee1a91\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027content-length\u0027: \u0027131\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027status\u0027: \u0027400\u0027, \u0027content-location\u0027: \u0027https://192.168.122.223/baremetal/v1/nodes/2b27c424-007b-435c-9332-83d0da1ea50d/management/indicators/system\u0027}\n        Body: b\u0027{\"error_message\": \"{\\\\\"faultcode\\\\\": \\\\\"Client\\\\\", \\\\\"faultstring\\\\\": \\\\\"Malformed indicator name \\\\\\\\\\\\\"system\\\\\\\\\\\\\"\\\\\", \\\\\"debuginfo\\\\\": null}\"}\u0027\n        \n```\n\n\n```\nMay 09 09:35:06 devstack devstack@ir-api.service[93857]: DEBUG ironic.api.method [None req-0551169d-d100-4f5f-853b-d9349f14b217 None tempest-TestNodeSystemReader-1653383041-system-reader] Client-side error: Malformed indicator name \"system\n\" {{(pid\u003d93857) format_exception /opt/stack/ironic/ironic/api/method.py:124}}\n```","commit_id":"b54beca6118232bd265a4dde7128dc82372be756"}],"ironic_tempest_plugin/tests/api/rbac_defaults/test_nodes.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2f606cd9db3e844a6fd1d54fbfba3d0e85409d86","unresolved":true,"context_lines":[{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        baremetal:node:get_indicator_state"},{"line_number":1032,"context_line":"        \"\"\""},{"line_number":1033,"context_line":"        resp, body \u003d self.reader_client.get_node_indicator_state("},{"line_number":1034,"context_line":"            self.node[\u0027uuid\u0027], \u0027system\u0027)"},{"line_number":1035,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    def test_reader_cannot_set_indicator_state(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"b8dd0b13_b34c1150","line":1034,"range":{"start_line":1033,"start_character":21,"end_line":1034,"end_character":40},"updated":"2023-05-09 08:56:28.000000000","message":"to be nit picky, this is testing \"get_indicators_by_component\" - not a specific indicator?","commit_id":"c0a521940713198467029a3539397e2d8c861e2c"}]}