)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6b1a5d1e01f1b12c614562581006e94b68f7accb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fbdff89b_f13c00a3","updated":"2024-03-28 20:25:15.000000000","message":"I think CI failures here aren\u0027t your fault, but we have to figure them out before this can land...","commit_id":"9fea99ed49c7b93fe25eb0998b55d9c6e82daa72"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"c0f3969f410a055f0ad909a94d34db7e7ba0c710","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b02ad4d3_40b554be","updated":"2024-04-22 11:18:36.000000000","message":"Recheck","commit_id":"6c4f7015247b3b1f482fcddfae82f35949f9caaf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"89f80f9183d8f85770546ae31dbbda18230822fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"469c2dbf_81f96daa","updated":"2024-05-07 19:10:00.000000000","message":"Only looked at the diff, but lgtm.","commit_id":"50747cab4aab425fd99e065fc1fb26dfc29784a2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d2c7d2465f51f85628c6c70c46d9c07d6b4e1510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ea7f4d69_ee193abe","updated":"2024-05-23 03:16:04.000000000","message":"recheck ipa fix has merged","commit_id":"5fdaffe11125cdb2a376c8cfb9fe973a78ed3caa"}],"ironic_tempest_plugin/tests/api/admin/test_allocations.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class TestAllocationsJsonExtSupport(Base):"},{"line_number":218,"context_line":"    \"\"\"Tests for baremetal allocations.\"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6b4836b1_01b9e228","line":218,"updated":"2024-03-26 00:07:43.000000000","message":"IF you can enumerate on the why a little bit more, that would be helpful for anyone coming along in the future. Thanks!","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class TestAllocationsJsonExtSupport(Base):"},{"line_number":218,"context_line":"    \"\"\"Tests for baremetal allocations.\"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff7161fe_53f7d258","line":218,"in_reply_to":"6b4836b1_01b9e228","updated":"2024-05-22 13:06:31.000000000","message":"Acknowledged","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":217,"context_line":"class TestAllocationsJsonExtSupport(Base):"},{"line_number":218,"context_line":"    \"\"\"Tests for baremetal allocations.\"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u0027d111b85b-a169-440e-9dcd-9b8b6ad8c917\u0027)"},{"line_number":223,"context_line":"    def test_create_show_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fc9d547_bbcd8a37","line":220,"updated":"2024-03-26 00:07:43.000000000","message":"I initially sas this and thought \"min_microversion\", This makes more sense now. An inline note might help too. Thanks!","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"class TestAllocationsJsonExtSupport(Base):"},{"line_number":218,"context_line":"    \"\"\"Tests for baremetal allocations.\"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    @decorators.idempotent_id(\u0027d111b85b-a169-440e-9dcd-9b8b6ad8c917\u0027)"},{"line_number":223,"context_line":"    def test_create_show_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"29e72e95_c3edcd9f","line":220,"in_reply_to":"1fc9d547_bbcd8a37","updated":"2024-05-22 13:06:31.000000000","message":"Acknowledged","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class TestAllocationsNoJsonExtSupport(Base):"},{"line_number":257,"context_line":"    \"\"\"Tests for baremetal allocations.\"\"\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6e1baf82_e9f7908d","line":257,"updated":"2024-03-26 00:07:43.000000000","message":"Same as above. Just a little more inline detail since \"No\" in the class name might not be the higgest hint for folks.","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class TestAllocationsNoJsonExtSupport(Base):"},{"line_number":257,"context_line":"    \"\"\"Tests for baremetal allocations.\"\"\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"321adb46_bfa369c1","line":257,"in_reply_to":"6e1baf82_e9f7908d","updated":"2024-05-22 13:06:31.000000000","message":"Acknowledged","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        self.assertEqual(body, body2)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self.assertRaises(lib_exc.NotFound, self.client.show_allocation,"},{"line_number":283,"context_line":"                          \u0027%s.json\u0027 % body[\u0027uuid\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @decorators.idempotent_id(\u0027cdf36c46-3da7-4306-b265-bcea3ab3bc3f\u0027)"},{"line_number":286,"context_line":"    def test_delete_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"91171eac_07fbf29a","line":283,"updated":"2024-03-26 00:07:43.000000000","message":"One thing, and hopefully not an existing bug elsewhere, but we need to somewhere ensure that we do ensure the node/allocation is all cleaned up. The plugin might properly unwind it all, but I just want us to be sure.","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":231,"context_line":"     to an allocation\u0027s `name` or `uuid` in API versions 1.90 and prior works."},{"line_number":232,"context_line":"     \"\"\""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @decorators.idempotent_id(\u0027d111b85b-a169-440e-9dcd-9b8b6ad8c917\u0027)"},{"line_number":237,"context_line":"    def test_create_show_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fcc9d2f8_6a5d83fb","line":234,"updated":"2024-04-03 20:34:19.000000000","message":"So what is happening, and causing these tests to fail, is the tests by default attempt to set a version for the request and include some extra fields.\n\nFor example, this can be found in the test output (https://b82af873f398e35b9667-d46fd59902d68f923f6bb91c5de228d0.ssl.cf2.rackcdn.com/913926/9/check/ironic-tempest-functional-python3/949d14e/testr_results.html)\n\n \u0027x-openstack-ironic-api-version\u0027: \u00271.1\u0027\n \n Which is the client saying \"I\u0027m using this version\"\n \n Except, if you look at the body we sent, you see \"resource_class\" which was added in a much later version of ironic!\n \n   Body: {\"resource_class\": \"031e4d60-c510-4a46-983d-b7e92c2ad36c\", \"chassis_uuid\": \"345de938-bfa7-49eb-9810-66a8126512fb\", \"properties\": {\"cpu_arch\": \"x86_64\", \"cpus\": 8, \"local_gb\": 10, \"memory_mb\": 4096}, \"driver\": \"fake-hardware\"}\n    \nAnd got back:\n\n        Body: b\u0027{\"error_message\": \"{\\\\\"faultcode\\\\\": \\\\\"Client\\\\\", \\\\\"faultstring\\\\\": \\\\\"Request not acceptable.\\\\\", \\\\\"debuginfo\\\\\": null}\"}\u0027\n        \nThe *huge* hint:\n\nhttps://b82af873f398e35b9667-d46fd59902d68f923f6bb91c5de228d0.ssl.cf2.rackcdn.com/913926/9/check/ironic-tempest-functional-python3/949d14e/controller/logs/screen-ir-api.txt has the following:\n\nMar 30 09:40:50.606084 np0037197416 devstack@ir-api.service[49476]: [pid: 49476|app: 0|req: 252/252] 173.231.255.75 () {66 vars in 1257 bytes} [Sat Mar 30 09:40:50 2024] POST /baremetal/v1/chassis \u003d\u003e generated 655 bytes in 152 msecs (HTTP/1.1 201) 8 headers in 380 bytes (1 switches on core 0)\nMar 30 09:40:50.641139 np0037197416 devstack@ir-api.service[49476]: DEBUG ironic.api.controllers.v1.node [None req-2344ff07-bbd8-4b2d-96fb-5da41e3aa885 None tempest-TestAllocationsWithJsonExtSupport-1289873436-system-admin] Field resource_class is not acceptable in version 1.1 {{(pid\u003d49476) reject_fields_in_newer_versions /opt/stack/ironic/ironic/api/controllers/v1/node.py:378}}\nMar 30 09:40:50.641800 np0037197416 devstack@ir-api.service[49476]: DEBUG ironic.api.method [None req-2344ff07-bbd8-4b2d-96fb-5da41e3aa885 None tempest-TestAllocationsWithJsonExtSupport-1289873436-system-admin] Client-side error: Request not acceptable. {{(pid\u003d49476) format_exception /opt/stack/ironic/ironic/api/method.py:124}}\n\nWhere things go sideways for the other tests is we\u0027re attempting calls still with 1.1 since I guess the class maximum api version is short circuiting some of the version logic.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"     to an allocation\u0027s `name` or `uuid` in API versions 1.90 and prior works."},{"line_number":232,"context_line":"     \"\"\""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @decorators.idempotent_id(\u0027d111b85b-a169-440e-9dcd-9b8b6ad8c917\u0027)"},{"line_number":237,"context_line":"    def test_create_show_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ff51b67_0615a906","line":234,"in_reply_to":"fcc9d2f8_6a5d83fb","updated":"2024-05-22 13:06:31.000000000","message":"Acknowledged","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":277,"context_line":"    disabled."},{"line_number":278,"context_line":"    \"\"\""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @decorators.idempotent_id(\u00276b851ef4-e364-4a3e-af1d-e6b73c1adec6\u0027)"},{"line_number":283,"context_line":"    def test_create_show_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"89efc6f7_db11b917","line":280,"updated":"2024-04-03 20:34:19.000000000","message":"you likely want request_microversion here, as well.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    disabled."},{"line_number":278,"context_line":"    \"\"\""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @decorators.idempotent_id(\u00276b851ef4-e364-4a3e-af1d-e6b73c1adec6\u0027)"},{"line_number":283,"context_line":"    def test_create_show_allocation_with_json(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"0a23e692_f767d290","line":280,"in_reply_to":"89efc6f7_db11b917","updated":"2024-05-22 13:06:31.000000000","message":"Acknowledged","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"}],"ironic_tempest_plugin/tests/api/admin/test_deploy_templates.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class TestDeployTemplatesJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":200,"context_line":"    \"\"\"Tests for deploy templates.\"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"80fe0f3b_a0251598","line":200,"updated":"2024-03-26 00:07:43.000000000","message":"A little bit more verbosity in the description please.","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class TestDeployTemplatesJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":200,"context_line":"    \"\"\"Tests for deploy templates.\"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"12c230ed_79f02de5","line":200,"in_reply_to":"80fe0f3b_a0251598","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class TestDeployTemplatesNoJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":230,"context_line":"    \"\"\"Tests for deploy templates.\"\"\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b0f4d336_bc8d406a","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":37},"updated":"2024-03-26 00:07:43.000000000","message":"A little more verbosity in the description please. 😊","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class TestDeployTemplatesNoJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":230,"context_line":"    \"\"\"Tests for deploy templates.\"\"\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f69be0fd_2b22e11b","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":37},"in_reply_to":"b0f4d336_bc8d406a","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a17ef3975760172fc067ec3547a61192aed37c","unresolved":true,"context_lines":[{"line_number":205,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def setUp(self):"},{"line_number":208,"context_line":"        super(TestDeployTemplates, self).setUp()"},{"line_number":209,"context_line":"        self.name \u003d _get_random_trait()"},{"line_number":210,"context_line":"        self.steps \u003d copy.deepcopy(EXAMPLE_STEPS)"},{"line_number":211,"context_line":"        _, self.template \u003d self.create_deploy_template(self.name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"63dba44a_0376b840","line":208,"range":{"start_line":208,"start_character":14,"end_line":208,"end_character":33},"updated":"2024-03-29 19:53:50.000000000","message":"This class name is wrong, it should be the class name on line 199.\n\nYour saying \"call setUp method on the class my class is derived from, and as such you can\u0027t invoke something not inside of your current class\u0027s context.","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def setUp(self):"},{"line_number":208,"context_line":"        super(TestDeployTemplates, self).setUp()"},{"line_number":209,"context_line":"        self.name \u003d _get_random_trait()"},{"line_number":210,"context_line":"        self.steps \u003d copy.deepcopy(EXAMPLE_STEPS)"},{"line_number":211,"context_line":"        _, self.template \u003d self.create_deploy_template(self.name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ad9ba87d_898a7b1f","line":208,"range":{"start_line":208,"start_character":14,"end_line":208,"end_character":33},"in_reply_to":"63dba44a_0376b840","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a17ef3975760172fc067ec3547a61192aed37c","unresolved":true,"context_lines":[{"line_number":240,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def setUp(self):"},{"line_number":243,"context_line":"        super(TestDeployTemplates, self).setUp()"},{"line_number":244,"context_line":"        self.name \u003d _get_random_trait()"},{"line_number":245,"context_line":"        self.steps \u003d copy.deepcopy(EXAMPLE_STEPS)"},{"line_number":246,"context_line":"        _, self.template \u003d self.create_deploy_template(self.name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e665e073_2fd8b614","line":243,"range":{"start_line":243,"start_character":14,"end_line":243,"end_character":33},"updated":"2024-03-29 19:53:50.000000000","message":"This also needs to be changed to match line 234","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def setUp(self):"},{"line_number":243,"context_line":"        super(TestDeployTemplates, self).setUp()"},{"line_number":244,"context_line":"        self.name \u003d _get_random_trait()"},{"line_number":245,"context_line":"        self.steps \u003d copy.deepcopy(EXAMPLE_STEPS)"},{"line_number":246,"context_line":"        _, self.template \u003d self.create_deploy_template(self.name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5b06ec4e_8f97c129","line":243,"range":{"start_line":243,"start_character":14,"end_line":243,"end_character":33},"in_reply_to":"e665e073_2fd8b614","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"}],"ironic_tempest_plugin/tests/api/admin/test_nodes.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class TestNodesNoJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":229,"context_line":"    \"\"\"Tests for baremetal nodes in older api.\"\"\""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"55c05ee3_2d3d9e5b","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":49},"updated":"2024-03-26 00:07:43.000000000","message":"s/older/newer/","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class TestNodesNoJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":229,"context_line":"    \"\"\"Tests for baremetal nodes in older api.\"\"\""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"78af513b_90de5032","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":49},"in_reply_to":"55c05ee3_2d3d9e5b","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a17ef3975760172fc067ec3547a61192aed37c","unresolved":true,"context_lines":[{"line_number":189,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def setUp(self):"},{"line_number":192,"context_line":"        super(TestNodes, self).setUp()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":195,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"5719ae38_1798fe8b","line":192,"updated":"2024-03-29 19:53:50.000000000","message":"The class name here is wrong, it should be the class name on line 183.","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def setUp(self):"},{"line_number":192,"context_line":"        super(TestNodes, self).setUp()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":195,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"2299422d_9395c74e","line":192,"in_reply_to":"5719ae38_1798fe8b","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9a17ef3975760172fc067ec3547a61192aed37c","unresolved":true,"context_lines":[{"line_number":240,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def setUp(self):"},{"line_number":243,"context_line":"        super(TestNodes, self).setUp()"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":246,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"2e04a6e9_98ea0c22","line":243,"range":{"start_line":243,"start_character":14,"end_line":243,"end_character":23},"updated":"2024-03-29 19:53:50.000000000","message":"This is the wrong class name, should be TestNodesWithoutJsonExtSupport","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def setUp(self):"},{"line_number":243,"context_line":"        super(TestNodes, self).setUp()"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":246,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3056db7a_75771045","line":243,"range":{"start_line":243,"start_character":14,"end_line":243,"end_character":23},"in_reply_to":"2e04a6e9_98ea0c22","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"96117c9d97e6411403237cb0b1ca6bd004320881"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":186,"context_line":"    node\u0027s `name` or `uuid` in API versions 1.90 and prior works."},{"line_number":187,"context_line":"    \"\"\""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def setUp(self):"},{"line_number":192,"context_line":"        super(TestNodesWithJsonExtSupport, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"25e9577e_0f7d0ae3","line":189,"range":{"start_line":189,"start_character":4,"end_line":189,"end_character":31},"updated":"2024-04-03 20:34:19.000000000","message":"this knob only impacts skip checking, I think you need to set request_microversion here, and on other tests.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    node\u0027s `name` or `uuid` in API versions 1.90 and prior works."},{"line_number":187,"context_line":"    \"\"\""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def setUp(self):"},{"line_number":192,"context_line":"        super(TestNodesWithJsonExtSupport, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"58dab781_55e2111d","line":189,"range":{"start_line":189,"start_character":4,"end_line":189,"end_character":31},"in_reply_to":"25e9577e_0f7d0ae3","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @decorators.idempotent_id(\u0027bc1134aa-2950-409c-b91c-b2d85df9b065\u0027)"},{"line_number":228,"context_line":"    def test_show_node_with_json(self):"},{"line_number":229,"context_line":"        \"\"\"Show a node while appending .json extension to its uuid\"\"\""},{"line_number":230,"context_line":"        _, loaded_node \u003d self.client.show_node(\u0027%s.json\u0027 % self.node[\u0027uuid\u0027])"},{"line_number":231,"context_line":"        self._assertExpected(self.node, loaded_node)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class TestNodesWithoutJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":235,"context_line":"    \"\"\"Tests for baremetal nodes to validate appending .json extension to a"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0376fd11_aa9115ba","line":233,"range":{"start_line":229,"start_character":0,"end_line":233,"end_character":0},"updated":"2024-04-03 20:34:19.000000000","message":"What is happening here, is your getting a 404  back, so the check is actually wrong\n\n    Response - Headers: {\u0027date\u0027: \u0027Sat, 30 Mar 2024 09:42:50 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.52 (Ubuntu)\u0027, \u0027x-openstack-ironic-api-minimum-version\u0027: \u00271.1\u0027, \u0027x-openstack-ironic-api-maximum-version\u0027: \u00271.91\u0027, \u0027x-openstack-ironic-api-version\u0027: \u00271.1\u0027, \u0027openstack-request-id\u0027: \u0027req-0a18df93-a413-487d-b649-b3bd6e640fa4\u0027, \u0027content-type\u0027: \u0027application/json\u0027, \u0027content-length\u0027: \u0027158\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027status\u0027: \u0027404\u0027, \u0027content-location\u0027: \u0027https://173.231.255.75/baremetal/v1/nodes/3fc3def1-fc5e-4b3d-a1de-859e4b9459c5.json\u0027}\n        Body: b\u0027{\"error_message\": \"{\\\\\"faultcode\\\\\": \\\\\"Client\\\\\", \\\\\"faultstring\\\\\": \\\\\"Node 3fc3def1-fc5e-4b3d-a1de-859e4b9459c5.json could not be found.\\\\\", \\\\\"debuginfo\\\\\": null}\"}\u0027\n}}}\n\n\nThe important thing is version 1.1 is being requested, which is wrong.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":260,"context_line":"                 \u0027local_gb\u0027: \u002710000\u0027,"},{"line_number":261,"context_line":"                 \u0027memory_mb\u0027: \u002712300\u0027}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.assertRaisese(lib_exc.NotFound, self.client.update_node,"},{"line_number":264,"context_line":"                           \u0027%s.json\u0027 % node[\u0027uuid\u0027], properties\u003dnew_p)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @decorators.idempotent_id(\u0027594160b6-a608-4024-98d1-818f75d2d895\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a9b6a8d4_a5ae7923","line":263,"updated":"2024-04-03 20:34:19.000000000","message":"Traceback (most recent call last):\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/ironic_tempest_plugin/tests/api/admin/test_nodes.py\", line 263, in test_update_node_with_json\n    self.assertRaisese(lib_exc.NotFound, self.client.update_node,\nAttributeError: \u0027TestNodesWithoutJsonExtSupport\u0027 object has no attribute \u0027assertRaisese\u0027\n\nIn other word, self.assertRaises(...","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                 \u0027local_gb\u0027: \u002710000\u0027,"},{"line_number":261,"context_line":"                 \u0027memory_mb\u0027: \u002712300\u0027}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self.assertRaisese(lib_exc.NotFound, self.client.update_node,"},{"line_number":264,"context_line":"                           \u0027%s.json\u0027 % node[\u0027uuid\u0027], properties\u003dnew_p)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    @decorators.idempotent_id(\u0027594160b6-a608-4024-98d1-818f75d2d895\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4539999f_ae522927","line":263,"in_reply_to":"a9b6a8d4_a5ae7923","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"}],"ironic_tempest_plugin/tests/api/admin/test_portgroups.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class TestPortGroupsJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":158,"context_line":"    \"\"\"Basic positive test cases for port groups.\"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a609954f_2f9992d8","line":158,"updated":"2024-03-26 00:07:43.000000000","message":"Well, ensuring it worked pre .90. Lets try and update the string to be a little more verbose. Thanks!","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class TestPortGroupsJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":158,"context_line":"    \"\"\"Basic positive test cases for port groups.\"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    max_microversion \u003d \u00271.90\u0027"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d9226cd6_92c57201","line":158,"in_reply_to":"a609954f_2f9992d8","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"175253d8796bbd625bfc09f3e224e17af3dec1d6","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class TestPortGroupsNoJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":211,"context_line":"    \"\"\"Basic positive test cases for port groups.\"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0e8a83_af8cc85e","line":211,"range":{"start_line":211,"start_character":5,"end_line":211,"end_character":52},"updated":"2024-03-26 00:07:43.000000000","message":"Lets update this too to detail it is for naming without .json.","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class TestPortGroupsNoJsonExtSupport(base.BaseBaremetalTest):"},{"line_number":211,"context_line":"    \"\"\"Basic positive test cases for port groups.\"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    min_microversion \u003d \u00271.91\u0027"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4cd69908_7becf9f8","line":211,"range":{"start_line":211,"start_character":5,"end_line":211,"end_character":52},"in_reply_to":"ff0e8a83_af8cc85e","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"af623d5d2f0a164223f01e4e1a1aa0fe458f7950"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    `name` or `uuid` in API versions 1.90 and prior works."},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def setUp(self):"},{"line_number":167,"context_line":"        super(TestPortGroupsWithJsonExtSupport, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a208b65_eb5fb618","line":164,"updated":"2024-04-03 20:34:19.000000000","message":"you\u0027ll want to set request_microversion here as well.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    `name` or `uuid` in API versions 1.90 and prior works."},{"line_number":162,"context_line":"    \"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    max_microversion \u003d \u00271.90\u0027  # Max API version for testing: 1.90"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def setUp(self):"},{"line_number":167,"context_line":"        super(TestPortGroupsWithJsonExtSupport, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"d1c46793_7578eb1b","line":164,"in_reply_to":"3a208b65_eb5fb618","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":217,"context_line":"    `name` or `uuid` in API versions later than 1.90 is disabled."},{"line_number":218,"context_line":"    \"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def setUp(self):"},{"line_number":223,"context_line":"        super(TestPortGroupsWithoutJsonExtSupport, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"202bb06c_902562c8","line":220,"updated":"2024-04-03 20:34:19.000000000","message":"Also here.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    `name` or `uuid` in API versions later than 1.90 is disabled."},{"line_number":218,"context_line":"    \"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    min_microversion \u003d \u00271.91\u0027  # Min API version for testing: 1.91"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def setUp(self):"},{"line_number":223,"context_line":"        super(TestPortGroupsWithoutJsonExtSupport, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"cb6fa3d5_5409126a","line":220,"in_reply_to":"202bb06c_902562c8","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2a831c5192ea98c55d1364f2f65dbcb880da936","unresolved":true,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def setUp(self):"},{"line_number":223,"context_line":"        super(TestPortGroupsWithoutJsonExtSupport, self).setUp()"},{"line_number":224,"context_line":"        self.useFixture("},{"line_number":225,"context_line":"            api_microversion_fixture.APIMicroversionFixture("},{"line_number":226,"context_line":"                self.min_microversion))"},{"line_number":227,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":228,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":229,"context_line":"        _, self.portgroup \u003d self.create_portgroup("}],"source_content_type":"text/x-python","patch_set":9,"id":"ff759bab_d771f85b","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":39},"updated":"2024-04-03 20:34:19.000000000","message":"so setting the version *is* good, it helps, but I think you can do it on the class level without explicitly setting the min here.","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"e0fdcf18d73558b59732b67f72704aaf603e8b2a","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def setUp(self):"},{"line_number":223,"context_line":"        super(TestPortGroupsWithoutJsonExtSupport, self).setUp()"},{"line_number":224,"context_line":"        self.useFixture("},{"line_number":225,"context_line":"            api_microversion_fixture.APIMicroversionFixture("},{"line_number":226,"context_line":"                self.min_microversion))"},{"line_number":227,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":228,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":229,"context_line":"        _, self.portgroup \u003d self.create_portgroup("}],"source_content_type":"text/x-python","patch_set":9,"id":"5ccb8024_45f7d88a","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":39},"in_reply_to":"ff759bab_d771f85b","updated":"2024-05-22 13:06:31.000000000","message":"Done","commit_id":"05da8a8055b8dddeeca2228097558121c2cce8f5"}]}