)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"d80744fbcd7de6858a88e3b6f690936d13abfac6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a079633_4ccba10f","updated":"2024-05-22 06:10:25.000000000","message":"+1ing this. My only reservation is same as raised by Lukas","commit_id":"332dacdaba67add001dcec5edb06281839b57772"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"2a9503d3c52ce02b265452c677b53e8b4c989dc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b790a131_bd74c6de","updated":"2024-05-29 07:26:45.000000000","message":"LGTM!\n\nI think the patch fixes the linked launchpad. Any further work can be done in a separate patch.","commit_id":"332dacdaba67add001dcec5edb06281839b57772"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c2733cf65d88bd43dbf4ad03c2ab181254ac86fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"19fafcf8_346b4d50","updated":"2024-05-30 14:06:42.000000000","message":"recheck Appears that there is some sort of race with this test. This could just be a fluke.","commit_id":"332dacdaba67add001dcec5edb06281839b57772"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3de95a8e0ad1e854dba9aeca57ea1e3de5ff28c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"701db23a_5d62fb65","updated":"2024-05-14 22:50:28.000000000","message":"recheck unrelated failure","commit_id":"332dacdaba67add001dcec5edb06281839b57772"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9c52928175f41a1652e298465a53cfba99d96562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab9e82fa_ce4e5ba9","in_reply_to":"3a079633_4ccba10f","updated":"2024-05-23 22:21:12.000000000","message":"Yeah, that really needs to be done separately.","commit_id":"332dacdaba67add001dcec5edb06281839b57772"}],"ironic_tempest_plugin/tests/api/admin/test_nodes.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"476ca08075ee747e52be6fe751b49e0caf0e5725","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027],"},{"line_number":318,"context_line":"                                        network_interface\u003d\u0027flat\u0027)"},{"line_number":319,"context_line":"        if CONF.network.shared_physical_network:"},{"line_number":320,"context_line":"            if not CONF.compute.fixed_network_name:"},{"line_number":321,"context_line":"                raise self.skipException("},{"line_number":322,"context_line":"                    \u0027Unable to perform vif test as there is no network \u0027"},{"line_number":323,"context_line":"                    \u0027defined for the [compute]fixed_network_name \u0027"},{"line_number":324,"context_line":"                    \u0027parameter.\u0027)"},{"line_number":325,"context_line":"            self.net \u003d self.os_admin.networks_client.list_networks("},{"line_number":326,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027][0]"},{"line_number":327,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f43d8701_65301b41","line":324,"range":{"start_line":320,"start_character":12,"end_line":324,"end_character":33},"updated":"2024-05-14 04:22:47.000000000","message":"Just a thought. Shouldn\u0027t this be in the skip_checks (we would avoid the unnecessary create_node() and create_chassis() when the tests are skipped)?","commit_id":"dd36a3c3ba36074cabf4dbca7c2b8902dc8856fb"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"029c3a596e5d0746c02a3596e9adef6c4b22fe6c","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027],"},{"line_number":318,"context_line":"                                        network_interface\u003d\u0027flat\u0027)"},{"line_number":319,"context_line":"        if CONF.network.shared_physical_network:"},{"line_number":320,"context_line":"            if not CONF.compute.fixed_network_name:"},{"line_number":321,"context_line":"                raise self.skipException("},{"line_number":322,"context_line":"                    \u0027Unable to perform vif test as there is no network \u0027"},{"line_number":323,"context_line":"                    \u0027defined for the [compute]fixed_network_name \u0027"},{"line_number":324,"context_line":"                    \u0027parameter.\u0027)"},{"line_number":325,"context_line":"            self.net \u003d self.os_admin.networks_client.list_networks("},{"line_number":326,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027][0]"},{"line_number":327,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"974f68d0_e4370f52","line":324,"range":{"start_line":320,"start_character":12,"end_line":324,"end_character":33},"in_reply_to":"0365c279_74a2386a","updated":"2024-05-15 07:18:21.000000000","message":"Yes, I understand. It was really just a thought. \n\nIf a cleanup function is registered with addCleanup [1] then it is called even when setUp fails. But it looks like both create_node and crete_chassis don\u0027t register a cleanup function.\n\n[1] https://docs.python.org/3.10/library/unittest.html#unittest.TestCase.addCleanup","commit_id":"dd36a3c3ba36074cabf4dbca7c2b8902dc8856fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"12978c5b92a7a833bdc01e1df2c1ff36129c42f2","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027],"},{"line_number":318,"context_line":"                                        network_interface\u003d\u0027flat\u0027)"},{"line_number":319,"context_line":"        if CONF.network.shared_physical_network:"},{"line_number":320,"context_line":"            if not CONF.compute.fixed_network_name:"},{"line_number":321,"context_line":"                raise self.skipException("},{"line_number":322,"context_line":"                    \u0027Unable to perform vif test as there is no network \u0027"},{"line_number":323,"context_line":"                    \u0027defined for the [compute]fixed_network_name \u0027"},{"line_number":324,"context_line":"                    \u0027parameter.\u0027)"},{"line_number":325,"context_line":"            self.net \u003d self.os_admin.networks_client.list_networks("},{"line_number":326,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027][0]"},{"line_number":327,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"38383455_e6ec9bf9","line":324,"range":{"start_line":320,"start_character":12,"end_line":324,"end_character":33},"in_reply_to":"974f68d0_e4370f52","updated":"2024-05-15 18:51:16.000000000","message":"Something to fix separately in that case.","commit_id":"dd36a3c3ba36074cabf4dbca7c2b8902dc8856fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b87eaf10afa5bfd869379c638080438c5f52503","unresolved":true,"context_lines":[{"line_number":317,"context_line":"        _, self.node \u003d self.create_node(self.chassis[\u0027uuid\u0027],"},{"line_number":318,"context_line":"                                        network_interface\u003d\u0027flat\u0027)"},{"line_number":319,"context_line":"        if CONF.network.shared_physical_network:"},{"line_number":320,"context_line":"            if not CONF.compute.fixed_network_name:"},{"line_number":321,"context_line":"                raise self.skipException("},{"line_number":322,"context_line":"                    \u0027Unable to perform vif test as there is no network \u0027"},{"line_number":323,"context_line":"                    \u0027defined for the [compute]fixed_network_name \u0027"},{"line_number":324,"context_line":"                    \u0027parameter.\u0027)"},{"line_number":325,"context_line":"            self.net \u003d self.os_admin.networks_client.list_networks("},{"line_number":326,"context_line":"                name\u003dCONF.compute.fixed_network_name)[\u0027networks\u0027][0]"},{"line_number":327,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0365c279_74a2386a","line":324,"range":{"start_line":320,"start_character":12,"end_line":324,"end_character":33},"in_reply_to":"f43d8701_65301b41","updated":"2024-05-14 17:12:12.000000000","message":"Eh, doesn\u0027t really matter, but likely does make sense to go ahead and disjoint it a little because I don\u0027t know if resources get cleaned up automatically when skip is raised.","commit_id":"dd36a3c3ba36074cabf4dbca7c2b8902dc8856fb"}]}