)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1fcdb45af777ae6f661d13e84bb073d775750bc6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sharpz7 \u003cadam.mcarthur62@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-05 20:37:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Microversion handling test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding tests to check if microversions are handled correctly. Based on https://gist.github.com/Sharpz7/97356eb57f77d3ee75892791c6cab155 which I use locally."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1467657f_001939b4","line":7,"updated":"2024-11-05 22:06:32.000000000","message":"If this is ready, remove the WIP","commit_id":"c9fd67334eee8ee1b45dbd2cf38e15405182422b"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"adc14fd31ad2a8cdfe9cc8c669855c535f525d1a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sharpz7 \u003cadam.mcarthur62@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-05 20:37:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Microversion handling test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding tests to check if microversions are handled correctly. Based on https://gist.github.com/Sharpz7/97356eb57f77d3ee75892791c6cab155 which I use locally."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6a5dffe2_a32297b6","line":7,"in_reply_to":"1467657f_001939b4","updated":"2024-11-07 00:53:02.000000000","message":"Going to leave it as WIP until I get the tests passing","commit_id":"c9fd67334eee8ee1b45dbd2cf38e15405182422b"}],"ironic_tempest_plugin/tests/api/admin/test_shards.py":[{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"672d82bc25d7b259e2e9b4d6e8c20ac39ba4c1c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from tempest import config"},{"line_number":14,"context_line":"from tempest.lib import decorators, exceptions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ironic_tempest_plugin.tests.api import base"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"23795e60_44c48215","line":14,"in_reply_to":"1669ca00_c9f74e9a","updated":"2024-11-05 20:37:50.000000000","message":"Done","commit_id":"5a2255f505f0b0b0ad2225e55074fc5e4c17dcb5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"934a50f3f74a44665b64798d199e6af6d3ea586b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from tempest import config"},{"line_number":14,"context_line":"from tempest.lib import decorators, exceptions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from ironic_tempest_plugin.tests.api import base"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1669ca00_c9f74e9a","line":14,"in_reply_to":"d97baba2_84248c11","updated":"2024-11-02 19:49:07.000000000","message":"\u003e pep8: H301: one import per line\n\nPlease fix.","commit_id":"5a2255f505f0b0b0ad2225e55074fc5e4c17dcb5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"934a50f3f74a44665b64798d199e6af6d3ea586b","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        self.assertIn(self.none_node_id, fetched_node_ids)"},{"line_number":128,"context_line":"        self.assertNotIn(self.bad_node_id, fetched_node_ids)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\"microversion-query-check-1\")"},{"line_number":131,"context_line":"    def test_microversion_query_check(self):"},{"line_number":132,"context_line":"        \"\"\"Ensure querying nodes fails for unsupported microversions.\"\"\""},{"line_number":133,"context_line":"        shard \u003d \"microversion-query-test\""}],"source_content_type":"text/x-python","patch_set":1,"id":"b67e39ee_aca1f2bc","line":130,"updated":"2024-11-02 19:49:07.000000000","message":"Your tests are failing because this must be a valid UUID. Please generate one... you probably have `uuidgen` on your devstack 😊","commit_id":"5a2255f505f0b0b0ad2225e55074fc5e4c17dcb5"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"672d82bc25d7b259e2e9b4d6e8c20ac39ba4c1c5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.assertIn(self.none_node_id, fetched_node_ids)"},{"line_number":128,"context_line":"        self.assertNotIn(self.bad_node_id, fetched_node_ids)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @decorators.idempotent_id(\"microversion-query-check-1\")"},{"line_number":131,"context_line":"    def test_microversion_query_check(self):"},{"line_number":132,"context_line":"        \"\"\"Ensure querying nodes fails for unsupported microversions.\"\"\""},{"line_number":133,"context_line":"        shard \u003d \"microversion-query-test\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9bb7b5c7_b91903f3","line":130,"in_reply_to":"b67e39ee_aca1f2bc","updated":"2024-11-05 20:37:50.000000000","message":"Done","commit_id":"5a2255f505f0b0b0ad2225e55074fc5e4c17dcb5"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"672d82bc25d7b259e2e9b4d6e8c20ac39ba4c1c5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                self.client.list_nodes(shard\u003dshard)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Reset to valid microversion"},{"line_number":145,"context_line":"        self.client.set_microversion(self.min_microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d69066d9_67b2dcda","line":145,"in_reply_to":"3b572a4d_45303054","updated":"2024-11-05 20:37:50.000000000","message":"Done","commit_id":"5a2255f505f0b0b0ad2225e55074fc5e4c17dcb5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"934a50f3f74a44665b64798d199e6af6d3ea586b","unresolved":true,"context_lines":[{"line_number":142,"context_line":"                self.client.list_nodes(shard\u003dshard)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # Reset to valid microversion"},{"line_number":145,"context_line":"        self.client.set_microversion(self.min_microversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b572a4d_45303054","line":145,"in_reply_to":"db39564b_8201d253","updated":"2024-11-02 19:49:07.000000000","message":"\u003e pep8: W292 no newline at end of file\n\nPlease fix.","commit_id":"5a2255f505f0b0b0ad2225e55074fc5e4c17dcb5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cdcc885b67a19ee69afef049be5caff6681902e9","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        invalid_microversions \u003d ["},{"line_number":139,"context_line":"            \"1.56\",  # Significantly older than the first shard support"},{"line_number":140,"context_line":"            \"1.81\",  # Just below the minimum"},{"line_number":141,"context_line":"            \"1.95\"   # Above the maximum"},{"line_number":142,"context_line":"        ]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        for microversion in invalid_microversions:"}],"source_content_type":"text/x-python","patch_set":5,"id":"4548cf29_81076900","line":141,"updated":"2024-11-09 00:53:46.000000000","message":"so we shouldn\u0027t include this IMO as it will break as we introduce new microversions","commit_id":"e137e788cf911f36b602daf07059e3631e56089d"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"c9601a37de48e94d9ba148bdd51d46d12d2525d4","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        invalid_microversions \u003d ["},{"line_number":139,"context_line":"            \"1.56\",  # Significantly older than the first shard support"},{"line_number":140,"context_line":"            \"1.81\",  # Just below the minimum"},{"line_number":141,"context_line":"            \"1.95\"   # Above the maximum"},{"line_number":142,"context_line":"        ]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        for microversion in invalid_microversions:"}],"source_content_type":"text/x-python","patch_set":5,"id":"16359827_09d90558","line":141,"in_reply_to":"4548cf29_81076900","updated":"2024-11-10 02:11:05.000000000","message":"Addressing all these comments at once - I am still very much in \"get the tests passing\" mode, I doubt the final change will look anything like this, thus the \"WIP\" still being in place. If there is another way to make this clearer let me know.","commit_id":"e137e788cf911f36b602daf07059e3631e56089d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cdcc885b67a19ee69afef049be5caff6681902e9","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                api_microversion_fixture.APIMicroversionFixture(microversion)"},{"line_number":147,"context_line":"            )"},{"line_number":148,"context_line":"            self.assertRaises("},{"line_number":149,"context_line":"                exceptions.BadRequest, self.client.list_nodes, shard\u003dshard"},{"line_number":150,"context_line":"            )"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Reset to valid microversion"}],"source_content_type":"text/x-python","patch_set":5,"id":"373475f4_091f9d53","line":149,"updated":"2024-11-09 00:53:46.000000000","message":"When we try to filter by shard on a too-early microversion, we 406, not 400: https://opendev.org/openstack/ironic/src/commit/f76b006b3f6d2767df3daffd4a8a3095bf99e41b/ironic/api/controllers/v1/utils.py#L1139","commit_id":"e137e788cf911f36b602daf07059e3631e56089d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"cdcc885b67a19ee69afef049be5caff6681902e9","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        _, fetched_shards \u003d self.client.get_shards()"},{"line_number":152,"context_line":"        fetched_shards \u003d [shard[\u0027name\u0027] for shard in fetched_shards[\u0027shards\u0027]]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.assertItemsEqual(self.shards, fetched_shards)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @decorators.idempotent_id(\u00274db850b2-d5b3-4076-b207-aaf3c3f49e47\u0027)"},{"line_number":157,"context_line":"    def test_get_shards_wrong_microversions(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6072efb_41654c56","line":154,"updated":"2024-11-09 00:53:46.000000000","message":"suggestion for these batch of tests: maybe do two tests? one with latest/tempest plugin default, and one with the first version it\u0027s supposed to work in?","commit_id":"dc221d307a337cd7d91a10b4cbf5a51364d54a1d"}]}