)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e56ab2b6edc517779c47ff95a914d240706340aa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"node porgroup configuration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1718481"},{"line_number":14,"context_line":"Related-Prod: PRODX-49717"},{"line_number":15,"context_line":"Change-Id: I0f06f01fdfcd6665e1e493dcebd26747aef6dd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b0dfaa3a_5b4bdad1","line":14,"updated":"2025-02-04 17:22:52.000000000","message":"This is not an openstack identifier, and appears to reference a non-public system. Please remove or provide a full public link.","commit_id":"c383ffdfe5181c1f8514266cc3cda7820ac3d24a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2359ac1fe53c116d379de40f70efd296f0d706da","unresolved":false,"context_lines":[{"line_number":11,"context_line":"node porgroup configuration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1718481"},{"line_number":14,"context_line":"Related-Prod: PRODX-49717"},{"line_number":15,"context_line":"Change-Id: I0f06f01fdfcd6665e1e493dcebd26747aef6dd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a79773f_db3f9a87","line":14,"in_reply_to":"2235da9d_dc345ea0","updated":"2025-02-08 13:46:47.000000000","message":"Done","commit_id":"c383ffdfe5181c1f8514266cc3cda7820ac3d24a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6c31d596333d4fe7d5bf4acfc67818e95bd055bb","unresolved":true,"context_lines":[{"line_number":11,"context_line":"node porgroup configuration."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1718481"},{"line_number":14,"context_line":"Related-Prod: PRODX-49717"},{"line_number":15,"context_line":"Change-Id: I0f06f01fdfcd6665e1e493dcebd26747aef6dd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"2235da9d_dc345ea0","line":14,"in_reply_to":"b0dfaa3a_5b4bdad1","updated":"2025-02-04 17:51:36.000000000","message":"O_o yes, good catch. Will drop.","commit_id":"c383ffdfe5181c1f8514266cc3cda7820ac3d24a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"943cdbbb8809caf116f083f8642f9631522e88eb","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1718481"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/c/openstack/ironic/+/942340"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I0f06f01fdfcd6665e1e493dcebd26747aef6dd3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5102e1a5_f54cec8e","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":26},"updated":"2025-02-20 11:53:54.000000000","message":"not actual dependency want to debug unstable CI.","commit_id":"3ccae2cd14e6f94439fa51010637c7aefed8f4d2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94eb2480654c031a45499c60d8b6962e20c4985f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7e01c073_5bf8a38e","updated":"2025-02-19 14:36:39.000000000","message":"Greetings Vasyl, A couple things in-line around api version being defined. In essence, it is a pattern we should be avoiding because clients generally are no longer pinned so tempest needs to test current standing behavior. Hope that makes sense, please let me know if you have any questions.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4ba2e329b8300ce42fcf14579c0102969e437777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b4025a48_a27d06e8","updated":"2025-02-20 19:16:57.000000000","message":"recheck not messaging failure","commit_id":"3ccae2cd14e6f94439fa51010637c7aefed8f4d2"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a666175db7ce1c17189ba50d72e13f92b5a6c740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0a46fdab_1936325c","updated":"2025-04-08 18:30:35.000000000","message":"Reviewed as part of PTG review jam.\n\nOverall feedback: this is a useful thing to test, but we need to ensure it\u0027s tied to a microversion or the client can negotiate the microversion.","commit_id":"19a6da2b842db0a3372c0766b8d7477f39b6181e"}],"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94eb2480654c031a45499c60d8b6962e20c4985f","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    def get_portgroups(self, node_uuid):"},{"line_number":165,"context_line":"        portgroups \u003d []"},{"line_number":166,"context_line":"        _, body \u003d self.baremetal_client.list_portgroups("},{"line_number":167,"context_line":"            node\u003dnode_uuid, api_version\u003d\u00271.23\u0027)"},{"line_number":168,"context_line":"        for portgroup in body[\u0027portgroups\u0027]:"},{"line_number":169,"context_line":"            _, p \u003d self.baremetal_client.show_portgroup("},{"line_number":170,"context_line":"                portgroup[\u0027uuid\u0027], api_version\u003d\u00271.23\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b03bd07e_0d68cf82","line":167,"range":{"start_line":167,"start_character":27,"end_line":167,"end_character":47},"updated":"2025-02-19 14:36:39.000000000","message":"If it can be avoided, remove the specific api_version","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0fe1a19a458c4fa7617612fc194a7ccca7acf4c4","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    def get_portgroups(self, node_uuid):"},{"line_number":165,"context_line":"        portgroups \u003d []"},{"line_number":166,"context_line":"        _, body \u003d self.baremetal_client.list_portgroups("},{"line_number":167,"context_line":"            node\u003dnode_uuid, api_version\u003d\u00271.23\u0027)"},{"line_number":168,"context_line":"        for portgroup in body[\u0027portgroups\u0027]:"},{"line_number":169,"context_line":"            _, p \u003d self.baremetal_client.show_portgroup("},{"line_number":170,"context_line":"                portgroup[\u0027uuid\u0027], api_version\u003d\u00271.23\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"d8604551_0c8356cf","line":167,"range":{"start_line":167,"start_character":27,"end_line":167,"end_character":47},"in_reply_to":"8f8331fe_2a6ed109","updated":"2025-02-20 08:34:50.000000000","message":"I\u0027ve added \u0027latest\u0027 as by default client uses smallest microversion available.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"afaa8c2d801997c33bb6c88a30bf1686cf16693d","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    def get_portgroups(self, node_uuid):"},{"line_number":165,"context_line":"        portgroups \u003d []"},{"line_number":166,"context_line":"        _, body \u003d self.baremetal_client.list_portgroups("},{"line_number":167,"context_line":"            node\u003dnode_uuid, api_version\u003d\u00271.23\u0027)"},{"line_number":168,"context_line":"        for portgroup in body[\u0027portgroups\u0027]:"},{"line_number":169,"context_line":"            _, p \u003d self.baremetal_client.show_portgroup("},{"line_number":170,"context_line":"                portgroup[\u0027uuid\u0027], api_version\u003d\u00271.23\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"8f8331fe_2a6ed109","line":167,"range":{"start_line":167,"start_character":27,"end_line":167,"end_character":47},"in_reply_to":"b03bd07e_0d68cf82","updated":"2025-02-19 19:30:18.000000000","message":"should I use `latest` here? if not set microversion here, than default is used and it does not work at least on caracal for sure.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94eb2480654c031a45499c60d8b6962e20c4985f","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            node\u003dnode_uuid, api_version\u003d\u00271.23\u0027)"},{"line_number":168,"context_line":"        for portgroup in body[\u0027portgroups\u0027]:"},{"line_number":169,"context_line":"            _, p \u003d self.baremetal_client.show_portgroup("},{"line_number":170,"context_line":"                portgroup[\u0027uuid\u0027], api_version\u003d\u00271.23\u0027)"},{"line_number":171,"context_line":"            portgroups.append(p)"},{"line_number":172,"context_line":"        return portgroups"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8d678806_51fdcc6a","line":170,"range":{"start_line":170,"start_character":35,"end_line":170,"end_character":53},"updated":"2025-02-19 14:36:39.000000000","message":"Same as above.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a666175db7ce1c17189ba50d72e13f92b5a6c740","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            node\u003dnode_uuid, api_version\u003d\u0027latest\u0027)"},{"line_number":168,"context_line":"        for portgroup in body[\u0027portgroups\u0027]:"},{"line_number":169,"context_line":"            _, p \u003d self.baremetal_client.show_portgroup("},{"line_number":170,"context_line":"                portgroup[\u0027uuid\u0027], api_version\u003d\u0027latest\u0027)"},{"line_number":171,"context_line":"            portgroups.append(p)"},{"line_number":172,"context_line":"        return portgroups"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"0d2a566e_697361ef","line":170,"updated":"2025-04-08 18:30:35.000000000","message":"We need to indicate a specific microversion for testing (or permit client to negotiate it).","commit_id":"19a6da2b842db0a3372c0766b8d7477f39b6181e"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94eb2480654c031a45499c60d8b6962e20c4985f","unresolved":true,"context_lines":[{"line_number":212,"context_line":"        output \u003d client.exec_command(cmd).rstrip()"},{"line_number":213,"context_line":"        self.assertEqual(success_string, output)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def validate_network_data(self, ssh_client):"},{"line_number":216,"context_line":"        node \u003d self.get_node(instance_id\u003dself.instance[\u0027id\u0027],"},{"line_number":217,"context_line":"                             api_version\u003d\u00271.23\u0027)"},{"line_number":218,"context_line":"        portgroups \u003d self.get_portgroups(node[\"uuid\"])"}],"source_content_type":"text/x-python","patch_set":10,"id":"55424460_b08a1183","line":215,"updated":"2025-02-19 14:36:39.000000000","message":"nit: I\u0027d add a short doc string just describing the overall goal.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94eb2480654c031a45499c60d8b6962e20c4985f","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        self.assertEqual(success_string, output)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def validate_network_data(self, ssh_client):"},{"line_number":216,"context_line":"        node \u003d self.get_node(instance_id\u003dself.instance[\u0027id\u0027],"},{"line_number":217,"context_line":"                             api_version\u003d\u00271.23\u0027)"},{"line_number":218,"context_line":"        portgroups \u003d self.get_portgroups(node[\"uuid\"])"},{"line_number":219,"context_line":"        if (not portgroups"},{"line_number":220,"context_line":"                or node[\"network_interface\"] !\u003d \"neutron\"):"}],"source_content_type":"text/x-python","patch_set":10,"id":"e6ed2dc9_33362714","line":217,"range":{"start_line":216,"start_character":6,"end_line":217,"end_character":48},"updated":"2025-02-19 14:36:39.000000000","message":"I\u0027m afriad this is the wrong route to take.\n\nWhat you should do is you should version check and operate on whatever the remote API is, and skip if it is below 1.23.\n\nThat being said, version 1.23 was... a very long time ago and current versioning is like ?1.96? and as such 1.23 is far outside of the window current tempest would be reasonably able to generate meaningful test results from.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94eb2480654c031a45499c60d8b6962e20c4985f","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        for pg in portgroups:"},{"line_number":238,"context_line":"            modes_to_check.append(pg[\u0027mode\u0027])"},{"line_number":239,"context_line":"            expected_links_count +\u003d 1"},{"line_number":240,"context_line":"            _, body \u003d self.baremetal_client.list_ports("},{"line_number":241,"context_line":"                portgroup\u003dpg[\u0027uuid\u0027], api_version\u003d\u00271.28\u0027)"},{"line_number":242,"context_line":"            expected_links_count +\u003d len(body[\u0027ports\u0027])"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        for link in result[\"links\"]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"198a8065_f598dd57","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":57},"updated":"2025-02-19 14:36:39.000000000","message":"Same here, pinning to the oldest version validates the behavior at that client version, but the key here is forward looking behavior. What is the behavior we introduce in the next version and does it break.\n\nIt shouldn\u0027t break, but that is the value with tempest as opposed to testing frozen in time behavior/responses.\n\nFWIW, the clients are also no longer version locked.","commit_id":"068c168afd3162b5c4ace08cf49e8fad1121bb14"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a666175db7ce1c17189ba50d72e13f92b5a6c740","unresolved":true,"context_lines":[{"line_number":232,"context_line":"           to setup bond in case ironic port groups were used."},{"line_number":233,"context_line":"        \"\"\""},{"line_number":234,"context_line":"        node \u003d self.get_node(instance_id\u003dself.instance[\u0027id\u0027],"},{"line_number":235,"context_line":"                             api_version\u003d\u0027latest\u0027)"},{"line_number":236,"context_line":"        try:"},{"line_number":237,"context_line":"            portgroups \u003d self.get_portgroups(node[\"uuid\"])"},{"line_number":238,"context_line":"        except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":15,"id":"360220e5_4299a4d8","line":235,"updated":"2025-04-08 18:30:35.000000000","message":"Similar feedback: avoid api_version\u003dlatest","commit_id":"19a6da2b842db0a3372c0766b8d7477f39b6181e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a666175db7ce1c17189ba50d72e13f92b5a6c740","unresolved":true,"context_lines":[{"line_number":240,"context_line":"                     \"Skipping portgroup network_data.json check.\")"},{"line_number":241,"context_line":"            return"},{"line_number":242,"context_line":"        if (not portgroups"},{"line_number":243,"context_line":"                or node[\"network_interface\"] !\u003d \"neutron\"):"},{"line_number":244,"context_line":"            LOG.debug(\"Skip portgroup network_data validation\""},{"line_number":245,"context_line":"                      \"As node does not have portgroups or do\""},{"line_number":246,"context_line":"                      \"do not use neutron network interface.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"5e41aa70_f7de6900","line":243,"updated":"2025-04-08 18:30:35.000000000","message":"we should also skip if trunk feature is disabled","commit_id":"19a6da2b842db0a3372c0766b8d7477f39b6181e"}]}