)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"776334a66ccf8f6b7da4f1643fd815f2f9be3da8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f71750db_7d94a71c","updated":"2025-02-09 07:27:52.000000000","message":"recheck unrelated","commit_id":"d4e1d3e052a1efe6eb8777298a6303516e2e071a"}],"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1231e1698084ca2a1071aa5332f8532a5874ef12","unresolved":true,"context_lines":[{"line_number":320,"context_line":"                self.get_remote_client(ip_address, username, private_key,"},{"line_number":321,"context_line":"                                       server\u003dserver)"},{"line_number":322,"context_line":"            except Exception:"},{"line_number":323,"context_line":"                return False"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        test_utils.call_until_true(_wait_ssh, timeout, delay)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c24f3c64_2a94892e","line":323,"updated":"2025-02-10 14:12:43.000000000","message":"This is going to completely silence the actual exception, maybe at least log it? Or is already logged somewhere?\n\nAlso, don\u0027t you want to return True on success?","commit_id":"d4e1d3e052a1efe6eb8777298a6303516e2e071a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"16bb0c269e970567b85acd3648de830980fe7717","unresolved":true,"context_lines":[{"line_number":320,"context_line":"                self.get_remote_client(ip_address, username, private_key,"},{"line_number":321,"context_line":"                                       server\u003dserver)"},{"line_number":322,"context_line":"            except Exception:"},{"line_number":323,"context_line":"                return False"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        test_utils.call_until_true(_wait_ssh, timeout, delay)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c6f9d517_bf84872f","line":323,"in_reply_to":"18aff666_13a31dc1","updated":"2025-02-10 15:28:18.000000000","message":"thanks for review Dmitry","commit_id":"d4e1d3e052a1efe6eb8777298a6303516e2e071a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f06db6fd8880b8a1e0a674b6bb300d5a189457c9","unresolved":true,"context_lines":[{"line_number":320,"context_line":"                self.get_remote_client(ip_address, username, private_key,"},{"line_number":321,"context_line":"                                       server\u003dserver)"},{"line_number":322,"context_line":"            except Exception:"},{"line_number":323,"context_line":"                return False"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        test_utils.call_until_true(_wait_ssh, timeout, delay)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"18aff666_13a31dc1","line":323,"in_reply_to":"c24f3c64_2a94892e","updated":"2025-02-10 15:21:53.000000000","message":"yes, we need to return it nice catch! Added debug log for exception.","commit_id":"d4e1d3e052a1efe6eb8777298a6303516e2e071a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"278cdb3e2e2b72ca299957a76bf826213c5d43dc","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                self.get_remote_client(ip_address, username, private_key,"},{"line_number":321,"context_line":"                                       server\u003dserver)"},{"line_number":322,"context_line":"            except Exception:"},{"line_number":323,"context_line":"                return False"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        test_utils.call_until_true(_wait_ssh, timeout, delay)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6fd4a779_bd43836d","line":323,"in_reply_to":"c6f9d517_bf84872f","updated":"2025-02-10 17:14:33.000000000","message":"Done","commit_id":"d4e1d3e052a1efe6eb8777298a6303516e2e071a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"61c977faee86c4577c9b0fc9eca4089b147c2b8b","unresolved":true,"context_lines":[{"line_number":322,"context_line":"                self.get_remote_client(ip_address, username, private_key,"},{"line_number":323,"context_line":"                                       server\u003dserver)"},{"line_number":324,"context_line":"            except Exception:"},{"line_number":325,"context_line":"                LOG.debug(\"Failed to get ssh client for %s\", ip_address)"},{"line_number":326,"context_line":"                return False"},{"line_number":327,"context_line":"            return True"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1e9c2803_745cc9b1","line":325,"updated":"2025-02-10 15:41:45.000000000","message":"Let\u0027s also include the exception message just in case it\u0027s not what we expect.. or even better, pass exc_info\u003dTrue for a full traceback in the logs.","commit_id":"bf50ca502a2ea139450cc94932434e324b945f49"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cfc04a1ca4998be3ab893c4767772ff7d27c9b23","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                self.get_remote_client(ip_address, username, private_key,"},{"line_number":323,"context_line":"                                       server\u003dserver)"},{"line_number":324,"context_line":"            except Exception:"},{"line_number":325,"context_line":"                LOG.debug(\"Failed to get ssh client for %s\", ip_address)"},{"line_number":326,"context_line":"                return False"},{"line_number":327,"context_line":"            return True"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fc81380_7c0560ee","line":325,"in_reply_to":"1e9c2803_745cc9b1","updated":"2025-02-10 16:13:14.000000000","message":"Done","commit_id":"bf50ca502a2ea139450cc94932434e324b945f49"}]}