)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b28508d6248c5e88ca5fe8d9fd85affdc6a3bb4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20ba6bec_45cfde3c","updated":"2025-04-10 10:53:45.000000000","message":"Trying to recreate issue","commit_id":"943957b0b84b0428e1128ca2a1c54c13c4b6e6df"}],"ironic_tempest_plugin/common/waiters.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a7cac8b6dcbec0af03db6919ee297050550a574","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        node \u003d utils.get_node(client, node_id\u003dnode_id)"},{"line_number":75,"context_line":"        if node[attr] in status:"},{"line_number":76,"context_line":"            return True"},{"line_number":77,"context_line":"        elif (abort_on_error_state"},{"line_number":78,"context_line":"              and (node[\u0027provision_state\u0027].endswith(\u0027 failed\u0027)"},{"line_number":79,"context_line":"                   or node[\u0027provision_state\u0027] \u003d\u003d \u0027error\u0027)):"},{"line_number":80,"context_line":"            msg \u003d (\u0027Node %(node)s reached failure state %(state)s while \u0027"},{"line_number":81,"context_line":"                   \u0027waiting for %(attr)s\u003d%(expected)s. \u0027"},{"line_number":82,"context_line":"                   \u0027Error: %(error)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"eb34d16c_6b74f486","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":59},"updated":"2025-04-15 16:13:05.000000000","message":"This is sort of what I think you want to be doing.","commit_id":"e22b70b3b07e55af48a364fea6dcb2a223a8fbcf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"33fc023f6678e3ff6f8605cfd6b4377c76dbfd44","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        node \u003d utils.get_node(client, node_id\u003dnode_id)"},{"line_number":75,"context_line":"        if node[attr] in status:"},{"line_number":76,"context_line":"            return True"},{"line_number":77,"context_line":"        elif (abort_on_error_state"},{"line_number":78,"context_line":"              and (node[\u0027provision_state\u0027].endswith(\u0027 failed\u0027)"},{"line_number":79,"context_line":"                   or node[\u0027provision_state\u0027] \u003d\u003d \u0027error\u0027)):"},{"line_number":80,"context_line":"            msg \u003d (\u0027Node %(node)s reached failure state %(state)s while \u0027"},{"line_number":81,"context_line":"                   \u0027waiting for %(attr)s\u003d%(expected)s. \u0027"},{"line_number":82,"context_line":"                   \u0027Error: %(error)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"8f998735_79e113e3","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":59},"in_reply_to":"eb34d16c_6b74f486","updated":"2025-04-18 13:28:05.000000000","message":"Done","commit_id":"e22b70b3b07e55af48a364fea6dcb2a223a8fbcf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a7cac8b6dcbec0af03db6919ee297050550a574","unresolved":true,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"def wait_node_value_in_field(client, node_id, field, value,"},{"line_number":167,"context_line":"                             abort_on_error_state\u003dFalse,"},{"line_number":168,"context_line":"                             raise_if_insufficent_access\u003dTrue,"},{"line_number":169,"context_line":"                             timeout\u003dNone, interval\u003dNone):"},{"line_number":170,"context_line":"    \"\"\"Waits for a node to have a field value appear."}],"source_content_type":"text/x-python","patch_set":8,"id":"0e258e90_86f1c3e4","line":167,"range":{"start_line":167,"start_character":30,"end_line":167,"end_character":56},"updated":"2025-04-15 16:13:05.000000000","message":"Only add new keys at the end of method parameter declaration. This is because it is actually breaking if someone doesn\u0027t pass this in as a keyword argument upfront. If you add to the end, you don\u0027t break the caller.\n\nIn other words, this should be added after interval, not at the beginning of kwargs.","commit_id":"e22b70b3b07e55af48a364fea6dcb2a223a8fbcf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5a7cac8b6dcbec0af03db6919ee297050550a574","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    def is_field_updated():"},{"line_number":183,"context_line":"        node \u003d utils.get_node(client, node_id\u003dnode_id)"},{"line_number":184,"context_line":"        field_value \u003d node[field]"},{"line_number":185,"context_line":"        if (abort_on_error_state"},{"line_number":186,"context_line":"            and (raise_if_insufficent_access"},{"line_number":187,"context_line":"                 and \u0027** Redacted\u0027 in field_value)):"},{"line_number":188,"context_line":"            msg \u003d (\u0027Unable to see contents of redacted field \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"841d6201_7f4e97df","line":185,"updated":"2025-04-15 16:13:05.000000000","message":"So, as proposed your changing the behavior to generally ignore error states moving forward.\n\nIn fact, this seems wrong in general because the method executing here is checking *if*  there is sufficient access or not and returning an error. That is unrelated to the purpose of the change as I understand it.","commit_id":"e22b70b3b07e55af48a364fea6dcb2a223a8fbcf"}]}