)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"231810dfc49fccfeb86e3b08c3dc12ecde888f1f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create/edit port elements have been modified to enable"},{"line_number":10,"context_line":"specification of an associated portgroup. The portgroup table in"},{"line_number":11,"context_line":"the node-detail/configuration tab has been modeified to show the"},{"line_number":12,"context_line":"number of ports for each portgroup."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I851b07110bcf85cce8ba1351509d4a8afcc9cd60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_f19ddf57","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":52},"updated":"2017-07-07 17:43:37.000000000","message":"nit: modified","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"caad69738a584deba7144cafd97903a976447c2a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create/edit port elements have been modified to enable"},{"line_number":10,"context_line":"specification of an associated portgroup. The portgroup table in"},{"line_number":11,"context_line":"the node-detail/configuration tab has been modeified to show the"},{"line_number":12,"context_line":"number of ports for each portgroup."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I851b07110bcf85cce8ba1351509d4a8afcc9cd60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_d419b122","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":52},"in_reply_to":"3f1d235d_f19ddf57","updated":"2017-07-07 17:53:24.000000000","message":"I will fix.","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"}],"ironic_ui/api/ironic.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e0951a053b82c05597745645d8cdc713c026621","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    :param portgroup_id: The UUID or name of the portgroup."},{"line_number":337,"context_line":"    :return: List of ports."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.portgroup.html#ironicclient.v1.portgroup.PortgroupManager.list_ports"},{"line_number":340,"context_line":"    \"\"\""},{"line_number":341,"context_line":"    return ironicclient(request).portgroup.list_ports(portgroup_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_9ef86f7b","line":339,"range":{"start_line":339,"start_character":30,"end_line":339,"end_character":39},"updated":"2017-07-17 13:13:19.000000000","message":"nit: This url is now wrong due to the doc migration, but I\u0027m okay if we change them all later.","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"3a4f547f26b78901469db5831124fa501cf97ba5","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    :param portgroup_id: The UUID or name of the portgroup."},{"line_number":337,"context_line":"    :return: List of ports."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.portgroup.html#ironicclient.v1.portgroup.PortgroupManager.list_ports"},{"line_number":340,"context_line":"    \"\"\""},{"line_number":341,"context_line":"    return ironicclient(request).portgroup.list_ports(portgroup_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_c4ba9a6c","line":339,"range":{"start_line":339,"start_character":30,"end_line":339,"end_character":39},"in_reply_to":"1f1a1f67_9ef86f7b","updated":"2017-07-17 13:52:20.000000000","message":"Thanks for pointing this out. Fixing all doc references in a single pass sounds good to me.","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"}],"ironic_ui/api/ironic_rest_api.py":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f3f33a608a074323dc6a1d4978b37fa771c4c60c","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    @rest_utils.ajax()"},{"line_number":359,"context_line":"    def get(self, request, portgroup_id):"},{"line_number":360,"context_line":"        \"\"\"Get the ports for for a specified portgroup."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :param request: HTTP request."},{"line_number":363,"context_line":"        :param node_id: UUID or name of portgroup."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_2bfb3479","line":360,"range":{"start_line":360,"start_character":25,"end_line":360,"end_character":28},"updated":"2017-07-06 01:07:24.000000000","message":"nit: repeated twice","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"8c766a9af27263b045507ace463088803b3a3296","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    @rest_utils.ajax()"},{"line_number":359,"context_line":"    def get(self, request, portgroup_id):"},{"line_number":360,"context_line":"        \"\"\"Get the ports for for a specified portgroup."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :param request: HTTP request."},{"line_number":363,"context_line":"        :param node_id: UUID or name of portgroup."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_182f9388","line":360,"range":{"start_line":360,"start_character":25,"end_line":360,"end_character":28},"in_reply_to":"3f1d235d_2bfb3479","updated":"2017-07-06 13:02:59.000000000","message":"Thanks, I will fix.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"da3bc1d52e6988b721f84554e82f6877bef287b3","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :param request: HTTP request."},{"line_number":363,"context_line":"        :param node_id: UUID or name of portgroup."},{"line_number":364,"context_line":"        :return: Dictionary with keys \"boot_device\" and \"persistent\""},{"line_number":365,"context_line":"        \"\"\""},{"line_number":366,"context_line":"        ports \u003d ironic.portgroup_get_ports(request, portgroup_id)"},{"line_number":367,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_6eec5329","line":364,"range":{"start_line":364,"start_character":17,"end_line":364,"end_character":68},"updated":"2017-07-07 15:17:01.000000000","message":"nit: returns list of ports","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"d7dc9a3988813620a08978f1f354443b5029349a","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :param request: HTTP request."},{"line_number":363,"context_line":"        :param node_id: UUID or name of portgroup."},{"line_number":364,"context_line":"        :return: Dictionary with keys \"boot_device\" and \"persistent\""},{"line_number":365,"context_line":"        \"\"\""},{"line_number":366,"context_line":"        ports \u003d ironic.portgroup_get_ports(request, portgroup_id)"},{"line_number":367,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_bb450846","line":364,"range":{"start_line":364,"start_character":17,"end_line":364,"end_character":68},"in_reply_to":"3f1d235d_6eec5329","updated":"2017-07-07 16:06:48.000000000","message":"I will fix.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"}],"ironic_ui/static/dashboard/admin/ironic/base-port/base-port.controller.js":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"da3bc1d52e6988b721f84554e82f6877bef287b3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      type: \"select\","},{"line_number":172,"context_line":"      id: \"portgroup-uuid\","},{"line_number":173,"context_line":"      title: gettext(\"Portgroup\"),"},{"line_number":174,"context_line":"      desc: gettext(\"Portgroup that this port belongs to\"),"},{"line_number":175,"context_line":"      portgroups: [],"},{"line_number":176,"context_line":"      options: \"portgroup.uuid as portgroup.name ? portgroup.name : portgroup.uuid for portgroup in field.portgroups\", // eslint-disable-line max-len"},{"line_number":177,"context_line":"      value: null});"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_0ee5df0a","line":174,"range":{"start_line":174,"start_character":20,"end_line":174,"end_character":57},"updated":"2017-07-07 15:17:01.000000000","message":"nit: rewording of this may sound simpler; for example \u0027Portgroup of this port.\u0027 WDYT?","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"d7dc9a3988813620a08978f1f354443b5029349a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      type: \"select\","},{"line_number":172,"context_line":"      id: \"portgroup-uuid\","},{"line_number":173,"context_line":"      title: gettext(\"Portgroup\"),"},{"line_number":174,"context_line":"      desc: gettext(\"Portgroup that this port belongs to\"),"},{"line_number":175,"context_line":"      portgroups: [],"},{"line_number":176,"context_line":"      options: \"portgroup.uuid as portgroup.name ? portgroup.name : portgroup.uuid for portgroup in field.portgroups\", // eslint-disable-line max-len"},{"line_number":177,"context_line":"      value: null});"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_5b3f1487","line":174,"range":{"start_line":174,"start_character":20,"end_line":174,"end_character":57},"in_reply_to":"3f1d235d_0ee5df0a","updated":"2017-07-07 16:06:48.000000000","message":"Not sure. I took the text from the cli description. I am happy to make the change if people agree on an alternative.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f3f33a608a074323dc6a1d4978b37fa771c4c60c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"      var field \u003d ctrl.portgroup_uuid;"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"      if (portgroups.length \u003e 0) {"},{"line_number":189,"context_line":"        field.portgroups.push({uuid: null, name: \"No portgroup\"});"},{"line_number":190,"context_line":"      }"},{"line_number":191,"context_line":"      field.portgroups \u003d field.portgroups.concat(portgroups);"},{"line_number":192,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_c644b549","line":189,"range":{"start_line":189,"start_character":50,"end_line":189,"end_character":62},"updated":"2017-07-06 01:07:24.000000000","message":"I believe this is the default one if there is any portgroup associated with a port? I think it should be \"Select a portgroup\" here as you have to select a portgroup in case if there are.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"8c766a9af27263b045507ace463088803b3a3296","unresolved":false,"context_lines":[{"line_number":186,"context_line":"      var field \u003d ctrl.portgroup_uuid;"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"      if (portgroups.length \u003e 0) {"},{"line_number":189,"context_line":"        field.portgroups.push({uuid: null, name: \"No portgroup\"});"},{"line_number":190,"context_line":"      }"},{"line_number":191,"context_line":"      field.portgroups \u003d field.portgroups.concat(portgroups);"},{"line_number":192,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_188b1368","line":189,"range":{"start_line":189,"start_character":50,"end_line":189,"end_character":62},"in_reply_to":"3f1d235d_c644b549","updated":"2017-07-06 13:02:59.000000000","message":"You are correct, and I like the suggestion of \"Select a portgroup\". I will make the change.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"}],"ironic_ui/static/dashboard/admin/ironic/create-port/create-port.controller.js":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f3f33a608a074323dc6a1d4978b37fa771c4c60c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    $controller(\u0027BasePortController\u0027,"},{"line_number":44,"context_line":"                {ctrl: ctrl,"},{"line_number":45,"context_line":"                 node: node,"},{"line_number":46,"context_line":"                 $uibModalInstance: $uibModalInstance});"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    ctrl.modalTitle \u003d gettext(\"Create Port\");"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_2b61f405","line":45,"range":{"start_line":45,"start_character":17,"end_line":45,"end_character":27},"updated":"2017-07-06 01:07:24.000000000","message":"why is this added? Doesn\u0027t seem to be getting used","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"8c766a9af27263b045507ace463088803b3a3296","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    $controller(\u0027BasePortController\u0027,"},{"line_number":44,"context_line":"                {ctrl: ctrl,"},{"line_number":45,"context_line":"                 node: node,"},{"line_number":46,"context_line":"                 $uibModalInstance: $uibModalInstance});"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    ctrl.modalTitle \u003d gettext(\"Create Port\");"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_38becffe","line":45,"range":{"start_line":45,"start_character":17,"end_line":45,"end_character":27},"in_reply_to":"3f1d235d_2b61f405","updated":"2017-07-06 13:02:59.000000000","message":"The CreatePortController inherits from the BasePortController, and \"node\" is an argument in the BasePortController constructor.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"}],"ironic_ui/static/dashboard/admin/ironic/edit-port/edit-port.controller.js":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"da3bc1d52e6988b721f84554e82f6877bef287b3","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if (cannotEditConnectivityAttr) {"},{"line_number":77,"context_line":"      angular.forEach("},{"line_number":78,"context_line":"        [ctrl.pxeEnabled, ctrl.portgroup_uuid],"},{"line_number":79,"context_line":"        function(field) {"},{"line_number":80,"context_line":"          field.disable(UNABLE_TO_UPDATE_CONNECTIVITY_ATTR_MSG);"},{"line_number":81,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_2e03fb75","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":24},"updated":"2017-07-07 15:17:01.000000000","message":"So, pxeEnabled is disabled twice; here and on L80. Why is it needed here?","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"d7dc9a3988813620a08978f1f354443b5029349a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if (cannotEditConnectivityAttr) {"},{"line_number":77,"context_line":"      angular.forEach("},{"line_number":78,"context_line":"        [ctrl.pxeEnabled, ctrl.portgroup_uuid],"},{"line_number":79,"context_line":"        function(field) {"},{"line_number":80,"context_line":"          field.disable(UNABLE_TO_UPDATE_CONNECTIVITY_ATTR_MSG);"},{"line_number":81,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_1bad1cea","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":24},"in_reply_to":"3f1d235d_2e03fb75","updated":"2017-07-07 16:06:48.000000000","message":"Good catch, I will fix.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"}],"ironic_ui/static/dashboard/admin/ironic/ironic.backend-mock.service.js":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f3f33a608a074323dc6a1d4978b37fa771c4c60c","unresolved":false,"context_lines":[{"line_number":606,"context_line":"          }"},{"line_number":607,"context_line":"          return [status, {ports: ports}];"},{"line_number":608,"context_line":"        });"},{"line_number":609,"context_line":"    } // init()"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    /**"},{"line_number":612,"context_line":"     * @description Get the list of supported drivers"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_c6b27549","line":609,"range":{"start_line":609,"start_character":6,"end_line":609,"end_character":15},"updated":"2017-07-06 01:07:24.000000000","message":"Not clear of this? Is this left by mistake?","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"8c766a9af27263b045507ace463088803b3a3296","unresolved":false,"context_lines":[{"line_number":606,"context_line":"          }"},{"line_number":607,"context_line":"          return [status, {ports: ports}];"},{"line_number":608,"context_line":"        });"},{"line_number":609,"context_line":"    } // init()"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    /**"},{"line_number":612,"context_line":"     * @description Get the list of supported drivers"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_f80737c9","line":609,"range":{"start_line":609,"start_character":6,"end_line":609,"end_character":15},"in_reply_to":"3f1d235d_c6b27549","updated":"2017-07-06 13:02:59.000000000","message":"No. I added the comment to help keep track of the nested structure of the function hierarchy. I find it helps.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"da3bc1d52e6988b721f84554e82f6877bef287b3","unresolved":false,"context_lines":[{"line_number":606,"context_line":"          }"},{"line_number":607,"context_line":"          return [status, {ports: ports}];"},{"line_number":608,"context_line":"        });"},{"line_number":609,"context_line":"    } // init()"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    /**"},{"line_number":612,"context_line":"     * @description Get the list of supported drivers"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_0e26ff17","line":609,"range":{"start_line":609,"start_character":6,"end_line":609,"end_character":15},"in_reply_to":"3f1d235d_f80737c9","updated":"2017-07-07 15:17:01.000000000","message":"++","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f3f33a608a074323dc6a1d4978b37fa771c4c60c","unresolved":false,"context_lines":[{"line_number":645,"context_line":"      $httpBackend.verifyNoOutstandingExpectation();"},{"line_number":646,"context_line":"      $httpBackend.verifyNoOutstandingRequest();"},{"line_number":647,"context_line":"    }"},{"line_number":648,"context_line":"  } // ironicBackendMockService()"},{"line_number":649,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_e6b57133","line":648,"range":{"start_line":648,"start_character":4,"end_line":648,"end_character":33},"updated":"2017-07-06 01:07:24.000000000","message":"nit: i think missed to remove the comment","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"da3bc1d52e6988b721f84554e82f6877bef287b3","unresolved":false,"context_lines":[{"line_number":645,"context_line":"      $httpBackend.verifyNoOutstandingExpectation();"},{"line_number":646,"context_line":"      $httpBackend.verifyNoOutstandingRequest();"},{"line_number":647,"context_line":"    }"},{"line_number":648,"context_line":"  } // ironicBackendMockService()"},{"line_number":649,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_4e0cf793","line":648,"range":{"start_line":648,"start_character":4,"end_line":648,"end_character":33},"in_reply_to":"3f1d235d_b8265f67","updated":"2017-07-07 15:17:01.000000000","message":"++","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"8c766a9af27263b045507ace463088803b3a3296","unresolved":false,"context_lines":[{"line_number":645,"context_line":"      $httpBackend.verifyNoOutstandingExpectation();"},{"line_number":646,"context_line":"      $httpBackend.verifyNoOutstandingRequest();"},{"line_number":647,"context_line":"    }"},{"line_number":648,"context_line":"  } // ironicBackendMockService()"},{"line_number":649,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":1,"id":"3f1d235d_b8265f67","line":648,"range":{"start_line":648,"start_character":4,"end_line":648,"end_character":33},"in_reply_to":"3f1d235d_e6b57133","updated":"2017-07-06 13:02:59.000000000","message":"Similar to the above, this kind of comment helps me keep track of the nested function hierarchy.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"}],"ironic_ui/static/dashboard/admin/ironic/node-details/sections/configuration.html":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f3f33a608a074323dc6a1d4978b37fa771c4c60c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"              \u003c/action\u003e"},{"line_number":211,"context_line":"              \u003cmenu\u003e"},{"line_number":212,"context_line":"                \u003cli role\u003d\"presentation\""},{"line_number":213,"context_line":"                    ng-class\u003d\"{disabled: portgroup.ports.length \u003e 0}\"\u003e"},{"line_number":214,"context_line":"                  \u003ca role\u003d\"menuitem\""},{"line_number":215,"context_line":"                     ng-click\u003d\"portgroup.ports.length \u003e 0 ||"},{"line_number":216,"context_line":"                               ctrl.deletePortgroups([portgroup]);"}],"source_content_type":"text/html","patch_set":1,"id":"3f1d235d_465c25ec","line":213,"range":{"start_line":213,"start_character":41,"end_line":213,"end_character":67},"updated":"2017-07-06 01:07:24.000000000","message":"Not 100 sure with disabled directive but from what i understand if ports.length is \u003e 0 then disable it? If that\u0027s correct then we don\u0027t want it to be disable.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"8c766a9af27263b045507ace463088803b3a3296","unresolved":false,"context_lines":[{"line_number":210,"context_line":"              \u003c/action\u003e"},{"line_number":211,"context_line":"              \u003cmenu\u003e"},{"line_number":212,"context_line":"                \u003cli role\u003d\"presentation\""},{"line_number":213,"context_line":"                    ng-class\u003d\"{disabled: portgroup.ports.length \u003e 0}\"\u003e"},{"line_number":214,"context_line":"                  \u003ca role\u003d\"menuitem\""},{"line_number":215,"context_line":"                     ng-click\u003d\"portgroup.ports.length \u003e 0 ||"},{"line_number":216,"context_line":"                               ctrl.deletePortgroups([portgroup]);"}],"source_content_type":"text/html","patch_set":1,"id":"3f1d235d_f8d5f71c","line":213,"range":{"start_line":213,"start_character":41,"end_line":213,"end_character":67},"in_reply_to":"3f1d235d_465c25ec","updated":"2017-07-06 13:02:59.000000000","message":"My understanding is that you cannot delete a portgroup that contains ports, so we disable the action if that is the case.","commit_id":"6f7175244b2a3cddcc8e4d8070419d8df20cd572"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"231810dfc49fccfeb86e3b08c3dc12ecde888f1f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            {$ portgroup.name | noValue $}"},{"line_number":199,"context_line":"          \u003c/td\u003e"},{"line_number":200,"context_line":"          \u003ctd class\u003d\"rsp-p1\"\u003e"},{"line_number":201,"context_line":"            {$ portgroup.ports.length | noValue $}"},{"line_number":202,"context_line":"          \u003c/td\u003e"},{"line_number":203,"context_line":"          \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":204,"context_line":"            \u003caction-list uib-dropdown class\u003d\"pull-right\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3f1d235d_14c4c991","line":201,"updated":"2017-07-07 17:43:37.000000000","message":"Just a comment; wondering if it helps to show the port IDs in a portgroup.","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"caad69738a584deba7144cafd97903a976447c2a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            {$ portgroup.name | noValue $}"},{"line_number":199,"context_line":"          \u003c/td\u003e"},{"line_number":200,"context_line":"          \u003ctd class\u003d\"rsp-p1\"\u003e"},{"line_number":201,"context_line":"            {$ portgroup.ports.length | noValue $}"},{"line_number":202,"context_line":"          \u003c/td\u003e"},{"line_number":203,"context_line":"          \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":204,"context_line":"            \u003caction-list uib-dropdown class\u003d\"pull-right\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"3f1d235d_94b699dc","line":201,"in_reply_to":"3f1d235d_14c4c991","updated":"2017-07-07 17:53:24.000000000","message":"Good question, I wondered about that to. How to best link the port and portgroup tables. I opted for a lightweight approach to get started with the possibility of making changes based on user feedback.","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e0951a053b82c05597745645d8cdc713c026621","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            {$ portgroup.name | noValue $}"},{"line_number":199,"context_line":"          \u003c/td\u003e"},{"line_number":200,"context_line":"          \u003ctd class\u003d\"rsp-p1\"\u003e"},{"line_number":201,"context_line":"            {$ portgroup.ports.length | noValue $}"},{"line_number":202,"context_line":"          \u003c/td\u003e"},{"line_number":203,"context_line":"          \u003ctd class\u003d\"actions_column\"\u003e"},{"line_number":204,"context_line":"            \u003caction-list uib-dropdown class\u003d\"pull-right\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"1f1a1f67_5e29b798","line":201,"in_reply_to":"3f1d235d_94b699dc","updated":"2017-07-17 13:13:19.000000000","message":"I think it would be useful, but a count is also useful.  Wait and see I guess. :)","commit_id":"7612110d94702d9877e79aef95b60aaa270ccc68"}]}