)]}'
{"ironic_ui/static/dashboard/admin/ironic/node-state-transition.service.js":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"ec298c566db3534e2d5d2b64750401f49bae6c97","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      return transitions;"},{"line_number":136,"context_line":"    };"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    this.getKnownStates \u003d function() {"},{"line_number":139,"context_line":"      return Object.keys(states);"},{"line_number":140,"context_line":"    };"},{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":"}());"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f436f4f_158ff92a","line":139,"range":{"start_line":138,"start_character":4,"end_line":139,"end_character":33},"updated":"2017-08-09 19:35:24.000000000","message":"minor nit: missing description","commit_id":"c1d272bbea4fb589dfd2d5a54668f59925ad31f7"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"9362c3e26cb9979e5922ed95526c477c39a00c8b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      return transitions;"},{"line_number":136,"context_line":"    };"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    this.getKnownStates \u003d function() {"},{"line_number":139,"context_line":"      return Object.keys(states);"},{"line_number":140,"context_line":"    };"},{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":"}());"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f436f4f_f5e91580","line":139,"range":{"start_line":138,"start_character":4,"end_line":139,"end_character":33},"in_reply_to":"9f436f4f_158ff92a","updated":"2017-08-09 19:50:01.000000000","message":"Done","commit_id":"c1d272bbea4fb589dfd2d5a54668f59925ad31f7"}],"ironic_ui/static/dashboard/admin/ironic/node-state-transition.service.spec.js":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"ec298c566db3534e2d5d2b64750401f49bae6c97","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                           \u0027available\u0027,"},{"line_number":46,"context_line":"                           \u0027adopt failed\u0027,"},{"line_number":47,"context_line":"                           \u0027clean failed\u0027,"},{"line_number":48,"context_line":"                           \u0027inspect failed\u0027,"},{"line_number":49,"context_line":"                           \u0027clean wait\u0027,"},{"line_number":50,"context_line":"                           \u0027deploy failed\u0027,"},{"line_number":51,"context_line":"                           \u0027error\u0027].sort();"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f436f4f_15a6d9c2","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":42},"updated":"2017-08-09 19:35:24.000000000","message":"confused, we have inspect failed state but not inspecting state? And we are adding transition manageable-\u003einspect","commit_id":"c1d272bbea4fb589dfd2d5a54668f59925ad31f7"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"9362c3e26cb9979e5922ed95526c477c39a00c8b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                           \u0027available\u0027,"},{"line_number":46,"context_line":"                           \u0027adopt failed\u0027,"},{"line_number":47,"context_line":"                           \u0027clean failed\u0027,"},{"line_number":48,"context_line":"                           \u0027inspect failed\u0027,"},{"line_number":49,"context_line":"                           \u0027clean wait\u0027,"},{"line_number":50,"context_line":"                           \u0027deploy failed\u0027,"},{"line_number":51,"context_line":"                           \u0027error\u0027].sort();"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f436f4f_d57171e2","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":42},"in_reply_to":"9f436f4f_15a6d9c2","updated":"2017-08-09 19:50:01.000000000","message":"In this service, we only include stable end-states. Transient states like \"inspecting\" are not included. Transient services could be added if the need arises.","commit_id":"c1d272bbea4fb589dfd2d5a54668f59925ad31f7"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"a139f03dc790692f99e024e13c72038ab4e22a1d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                           \u0027available\u0027,"},{"line_number":46,"context_line":"                           \u0027adopt failed\u0027,"},{"line_number":47,"context_line":"                           \u0027clean failed\u0027,"},{"line_number":48,"context_line":"                           \u0027inspect failed\u0027,"},{"line_number":49,"context_line":"                           \u0027clean wait\u0027,"},{"line_number":50,"context_line":"                           \u0027deploy failed\u0027,"},{"line_number":51,"context_line":"                           \u0027error\u0027].sort();"}],"source_content_type":"text/javascript","patch_set":1,"id":"9f436f4f_6b1b061b","line":48,"range":{"start_line":48,"start_character":28,"end_line":48,"end_character":42},"in_reply_to":"9f436f4f_d57171e2","updated":"2017-08-09 20:40:23.000000000","message":"Okay, yes sure","commit_id":"c1d272bbea4fb589dfd2d5a54668f59925ad31f7"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"f2ffdca88bcd4e15b8436cddcdbc1e0d4d7f7907","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                   verb: \u0027adopt\u0027})).toBe(true);"},{"line_number":81,"context_line":"      });"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      it(\u0027manageable - provide - available\u0027, function() {"},{"line_number":84,"context_line":"        expect(validateTransition({source: \u0027manageable\u0027,"},{"line_number":85,"context_line":"                                   target: \u0027available\u0027,"},{"line_number":86,"context_line":"                                   verb: \u0027provide\u0027})).toBe(true);"}],"source_content_type":"text/javascript","patch_set":2,"id":"9f436f4f_77171647","line":83,"updated":"2017-08-13 03:19:22.000000000","message":"I think this transistion is needed as well:\n\nmanageable -\u003e provide -\u003e clean failed","commit_id":"1b120b08639a5af1f2dba21d48814dc5c9e45b0f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"5bb9d45e298e1747f065f91fee6abf221b418d17","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                   verb: \u0027adopt\u0027})).toBe(true);"},{"line_number":81,"context_line":"      });"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      it(\u0027manageable - provide - available\u0027, function() {"},{"line_number":84,"context_line":"        expect(validateTransition({source: \u0027manageable\u0027,"},{"line_number":85,"context_line":"                                   target: \u0027available\u0027,"},{"line_number":86,"context_line":"                                   verb: \u0027provide\u0027})).toBe(true);"}],"source_content_type":"text/javascript","patch_set":2,"id":"9f436f4f_d45d6547","line":83,"in_reply_to":"9f436f4f_44ad7099","updated":"2017-08-15 18:14:38.000000000","message":"Peter, thanks. This patch works as-is and the missing transitions need to be added separately.","commit_id":"1b120b08639a5af1f2dba21d48814dc5c9e45b0f"},{"author":{"_account_id":19380,"name":"Peter Piela","email":"ppiela@gmail.com","username":"ppiela"},"change_message_id":"e2e8123183910a0eaa1a8e8143d04fb98ba32741","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                   verb: \u0027adopt\u0027})).toBe(true);"},{"line_number":81,"context_line":"      });"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      it(\u0027manageable - provide - available\u0027, function() {"},{"line_number":84,"context_line":"        expect(validateTransition({source: \u0027manageable\u0027,"},{"line_number":85,"context_line":"                                   target: \u0027available\u0027,"},{"line_number":86,"context_line":"                                   verb: \u0027provide\u0027})).toBe(true);"}],"source_content_type":"text/javascript","patch_set":2,"id":"9f436f4f_44ad7099","line":83,"in_reply_to":"9f436f4f_77171647","updated":"2017-08-14 12:52:48.000000000","message":"Rama, you are correct, there are missing transitions. So far I have been adding transitions that I am able to verify. I am open to adding the missing entries that you identified.","commit_id":"1b120b08639a5af1f2dba21d48814dc5c9e45b0f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"52c5801b68005cb0d1bb09a5e15e929681881c4c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                   verb: \u0027adopt\u0027})).toBe(true);"},{"line_number":81,"context_line":"      });"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      it(\u0027manageable - provide - available\u0027, function() {"},{"line_number":84,"context_line":"        expect(validateTransition({source: \u0027manageable\u0027,"},{"line_number":85,"context_line":"                                   target: \u0027available\u0027,"},{"line_number":86,"context_line":"                                   verb: \u0027provide\u0027})).toBe(true);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7f287b81_435bc486","line":83,"in_reply_to":"9f436f4f_d45d6547","updated":"2017-08-22 12:59:21.000000000","message":"I\u0027m not exactly sure why we should really want to map out all of the possible transitions in the state machine, especially ones that are unintended/can\u0027t be reached without a hard failure","commit_id":"1b120b08639a5af1f2dba21d48814dc5c9e45b0f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"f2ffdca88bcd4e15b8436cddcdbc1e0d4d7f7907","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                   verb: \u0027provide\u0027})).toBe(true);"},{"line_number":87,"context_line":"      });"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"      it(\u0027manageable - inspect - manageable\u0027, function() {"},{"line_number":90,"context_line":"        expect(validateTransition({source: \u0027manageable\u0027,"},{"line_number":91,"context_line":"                                   target: \u0027manageable\u0027,"},{"line_number":92,"context_line":"                                   verb: \u0027inspect\u0027})).toBe(true);"}],"source_content_type":"text/javascript","patch_set":2,"id":"9f436f4f_572ad27e","line":89,"updated":"2017-08-13 03:19:22.000000000","message":"Also, manageable -\u003e inspect -\u003e inspect failed","commit_id":"1b120b08639a5af1f2dba21d48814dc5c9e45b0f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"f2ffdca88bcd4e15b8436cddcdbc1e0d4d7f7907","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                   verb: \u0027inspect\u0027})).toBe(true);"},{"line_number":93,"context_line":"      });"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"      it(\u0027manageable - clean - manageable\u0027, function() {"},{"line_number":96,"context_line":"        expect(validateTransition({source: \u0027manageable\u0027,"},{"line_number":97,"context_line":"                                   target: \u0027manageable\u0027,"},{"line_number":98,"context_line":"                                   verb: \u0027clean\u0027})).toBe(true);"}],"source_content_type":"text/javascript","patch_set":2,"id":"9f436f4f_1720ca9a","line":95,"updated":"2017-08-13 03:19:22.000000000","message":"Also, manageable -\u003e clean -\u003e clean failed","commit_id":"1b120b08639a5af1f2dba21d48814dc5c9e45b0f"}]}
