)]}'
{"ironic_ui/api/ironic.py":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"c9edc3aeceb0b4e96f7d3b92b20bee0853c107af","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    :param request: HTTP request."},{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_db52fd67","line":267,"range":{"start_line":267,"start_character":13,"end_line":267,"end_character":28},"updated":"2017-11-21 18:23:01.000000000","message":"Are we sure we don\u0027t get updated node in return? Because for methods like set_console_mode, set_power_state, set_provision_state we are returning node. In ironic client code i see all the above methods return in exact same way.","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"fba65b784b320b35e762cf48e40ee5c238b424e1","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    :param request: HTTP request."},{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_58c1cf2d","line":267,"range":{"start_line":267,"start_character":13,"end_line":267,"end_character":28},"in_reply_to":"ff82abbf_a37f7213","updated":"2017-12-06 18:04:44.000000000","message":"I see. Alright.","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3537c3f87d5500a58faf6f9b06684430d944c4d9","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    :param request: HTTP request."},{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_a37f7213","line":267,"range":{"start_line":267,"start_character":13,"end_line":267,"end_character":28},"in_reply_to":"ff82abbf_db52fd67","updated":"2017-11-24 22:18:37.000000000","message":"According to the api-ref, we do not get anything back.\nhttps://developer.openstack.org/api-ref/baremetal/#inject-nmi-non-masking-interrupts","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"c9edc3aeceb0b4e96f7d3b92b20bee0853c107af","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""},{"line_number":271,"context_line":"    return ironicclient(request).node.inject_nmi(node_id)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_bb7db91d","line":269,"range":{"start_line":269,"start_character":4,"end_line":269,"end_character":133},"updated":"2017-11-21 18:23:01.000000000","message":"This is a stale link. I think we should change it to openstack CLI. https://docs.openstack.org/python-ironicclient/latest/cli/osc/v1/index.html#baremetal-node-inject-nmi","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"fba65b784b320b35e762cf48e40ee5c238b424e1","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""},{"line_number":271,"context_line":"    return ironicclient(request).node.inject_nmi(node_id)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_98cc3762","line":269,"range":{"start_line":269,"start_character":4,"end_line":269,"end_character":133},"in_reply_to":"ff82abbf_43a8e68b","updated":"2017-12-06 18:04:44.000000000","message":"Ok","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3537c3f87d5500a58faf6f9b06684430d944c4d9","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""},{"line_number":271,"context_line":"    return ironicclient(request).node.inject_nmi(node_id)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_43a8e68b","line":269,"range":{"start_line":269,"start_character":4,"end_line":269,"end_character":133},"in_reply_to":"ff82abbf_bb7db91d","updated":"2017-11-24 22:18:37.000000000","message":"Actually, we should just remove developer from the URL. This is not an OSC command reply.","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"818375b0197d76b891d8cc48999caadaa3b4c1be","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    :param request: HTTP request."},{"line_number":266,"context_line":"    :param node_id: The UUID or name of the node."},{"line_number":267,"context_line":"    :return: Empty response."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html#ironicclient.v1.node.NodeManager.inject_nmi"},{"line_number":270,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_01b08642","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":28},"updated":"2017-12-08 04:37:26.000000000","message":"Maybe remove this if this doesn\u0027t return anything?","commit_id":"7e5516cad9786c4cac4684357efe9d2e1e01037f"}],"ironic_ui/api/ironic_rest_api.py":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"2b4935235b608f272909767ea665b6225d861403","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    url_regex \u003d r\u0027ironic/nodes/(?P\u003cnode_id\u003e{})/management/inject_nmi$\u0027. \\"},{"line_number":476,"context_line":"                format(LOGICAL_NAME_PATTERN)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @rest_utils.ajax()"},{"line_number":479,"context_line":"    def put(self, request, node_id):"},{"line_number":480,"context_line":"        \"\"\"Inject Non-Masking Interrupts into a specified node."},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_db70bd75","line":478,"range":{"start_line":478,"start_character":3,"end_line":478,"end_character":22},"updated":"2017-11-21 17:51:25.000000000","message":"Shouldn\u0027t data_required\u003dTrue be passed to ajax()?","commit_id":"16843ea17efa8ff6ae68f9c5df976d084b969f2d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eead46a47e338e9c173aa284a567adef1d531959","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    url_regex \u003d r\u0027ironic/nodes/(?P\u003cnode_id\u003e{})/management/inject_nmi$\u0027. \\"},{"line_number":476,"context_line":"                format(LOGICAL_NAME_PATTERN)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @rest_utils.ajax()"},{"line_number":479,"context_line":"    def put(self, request, node_id):"},{"line_number":480,"context_line":"        \"\"\"Inject Non-Masking Interrupts into a specified node."},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_5bd82d52","line":478,"range":{"start_line":478,"start_character":3,"end_line":478,"end_character":22},"in_reply_to":"ff82abbf_db70bd75","updated":"2017-11-21 17:54:19.000000000","message":"Great catch!","commit_id":"16843ea17efa8ff6ae68f9c5df976d084b969f2d"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"c9edc3aeceb0b4e96f7d3b92b20bee0853c107af","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        \"\"\"Inject Non-Masking Interrupts into a specified node."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        :param request: HTTP request."},{"line_number":483,"context_line":"        :param node_id: Node name or uuid."},{"line_number":484,"context_line":"        :return: Empty response."},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        return ironic.node_inject_nmi(request, node_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_1bef0585","line":483,"range":{"start_line":483,"start_character":37,"end_line":483,"end_character":42},"updated":"2017-11-21 18:23:01.000000000","message":"nit: s/uuid/UUID","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3537c3f87d5500a58faf6f9b06684430d944c4d9","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        \"\"\"Inject Non-Masking Interrupts into a specified node."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        :param request: HTTP request."},{"line_number":483,"context_line":"        :param node_id: Node name or uuid."},{"line_number":484,"context_line":"        :return: Empty response."},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        return ironic.node_inject_nmi(request, node_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_e396da3e","line":483,"range":{"start_line":483,"start_character":37,"end_line":483,"end_character":42},"in_reply_to":"ff82abbf_1bef0585","updated":"2017-11-24 22:18:37.000000000","message":"i think this would be good to have a follow-up to address for the whole file.","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"818375b0197d76b891d8cc48999caadaa3b4c1be","unresolved":false,"context_lines":[{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        :param request: HTTP request."},{"line_number":483,"context_line":"        :param node_id: Node name or uuid."},{"line_number":484,"context_line":"        :return: Empty response."},{"line_number":485,"context_line":"        \"\"\""},{"line_number":486,"context_line":"        return ironic.node_inject_nmi(request, node_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_c1b5be33","line":484,"range":{"start_line":484,"start_character":0,"end_line":484,"end_character":32},"updated":"2017-12-08 04:37:26.000000000","message":"Ditto","commit_id":"7e5516cad9786c4cac4684357efe9d2e1e01037f"}],"ironic_ui/static/dashboard/admin/ironic/node-details/node-details.controller.spec.js":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"c9edc3aeceb0b4e96f7d3b92b20bee0853c107af","unresolved":false,"context_lines":[{"line_number":256,"context_line":"      expect(ctrl.nodeValidation[0].hw_interface).toEqual(hwInterface);"},{"line_number":257,"context_line":"    });"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    it(\u0027should have injectNmi\u0027, function () {"},{"line_number":260,"context_line":"      var ctrl;"},{"line_number":261,"context_line":"      createNode()"},{"line_number":262,"context_line":"        .then(function(node) {"}],"source_content_type":"text/javascript","patch_set":4,"id":"ff82abbf_a66a7c7d","line":259,"range":{"start_line":259,"start_character":4,"end_line":259,"end_character":45},"updated":"2017-11-21 18:23:01.000000000","message":"Is it possible to check if error was not returned after inject NMI operation?","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"}],"ironic_ui/static/dashboard/admin/ironic/node-details/node-details.html":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"c9edc3aeceb0b4e96f7d3b92b20bee0853c107af","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u003c/action\u003e"},{"line_number":73,"context_line":"        \u003cli role\u003d\"presentation\"\u003e"},{"line_number":74,"context_line":"          \u003ca role\u003d\"menuitem\""},{"line_number":75,"context_line":"             ng-click\u003d\"ctrl.injectNmi();"},{"line_number":76,"context_line":"                       $event.stopPropagation();"},{"line_number":77,"context_line":"                       $event.preventDefault()\"\u003e"},{"line_number":78,"context_line":"            \u003cspan\u003e{$ \"Inject NMI\" | translate $}\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"ff82abbf_8691789c","line":75,"range":{"start_line":75,"start_character":28,"end_line":75,"end_character":39},"updated":"2017-11-21 18:23:01.000000000","message":"I am sure we can directly also pass ctrl.node from here. Is there a reason for not passing from here. Not insisting of changing anything but just curious to know if there is any reason","commit_id":"eda151c987b7a292d632b971c8ed88c9f2e3fbbf"}],"releasenotes/notes/inject-nmi-0320453eaf1bda9b.yaml":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"818375b0197d76b891d8cc48999caadaa3b4c1be","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for injecting non-maskable interrupts into a node. A new"},{"line_number":5,"context_line":"    action ``Inject NMI`` has been aded to the node actions dropdown menu"},{"line_number":6,"context_line":"    in the ``Node Details`` page."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df87a7cf_a18afa66","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":39},"updated":"2017-12-08 04:37:26.000000000","message":"added","commit_id":"7e5516cad9786c4cac4684357efe9d2e1e01037f"}]}
