)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4190099f87ee3ea292f1cfb308663dca61d369e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"file in the requirements repo picks up the right version of horizon."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This commit is proposed directly as the similar change in the master"},{"line_number":22,"context_line":"branch happened as part of Django 1.11 drop."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I9a310446743cfe6bca5480455b91a7cd74da8785"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_9be6f149","line":22,"updated":"2020-01-10 09:45:11.000000000","message":"Can you please add the link to the change as reference ?","commit_id":"864c78b30cb740ac4e2cd0eb42e846215c64fc18"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6abdd68d27647d991e98bb3bcda8877b1107f20c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"file in the requirements repo picks up the right version of horizon."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This commit is proposed directly as the similar change in the master"},{"line_number":22,"context_line":"branch happened as part of Django 1.11 drop."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I9a310446743cfe6bca5480455b91a7cd74da8785"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_47941099","line":22,"in_reply_to":"3fa7e38b_9be6f149","updated":"2020-01-11 16:23:55.000000000","message":"https://review.opendev.org/#/c/700845/ is the corresponding master change. I will add it in the next patch set.","commit_id":"864c78b30cb740ac4e2cd0eb42e846215c64fc18"}],"doc/requirements.txt":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7376d2f0c878c12fe4498ee2d16371172f108196","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Include horizon as test requirement"},{"line_number":13,"context_line":"horizon\u003e\u003d16.0.0 # Apache-2.0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"selenium\u003e\u003d2.50.1 # Apache-2.0"},{"line_number":16,"context_line":"xvfbwrapper\u003e\u003d0.1.3 #license: MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_c766cabc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":28},"updated":"2020-01-10 14:35:58.000000000","message":"Does this need to be here? I am curious on the why...","commit_id":"864c78b30cb740ac4e2cd0eb42e846215c64fc18"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d732a0e9d46454b62cd00fa7732d847bcb2192f6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Include horizon as test requirement"},{"line_number":13,"context_line":"horizon\u003e\u003d16.0.0 # Apache-2.0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"selenium\u003e\u003d2.50.1 # Apache-2.0"},{"line_number":16,"context_line":"xvfbwrapper\u003e\u003d0.1.3 #license: MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_c7a7a00a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":28},"in_reply_to":"3fa7e38b_6774ac9c","updated":"2020-01-11 16:26:47.000000000","message":"I forgot to share the link.\n\n[1] https://opendev.org/openstack/ironic-ui/src/branch/master/tox.ini#L9","commit_id":"864c78b30cb740ac4e2cd0eb42e846215c64fc18"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6abdd68d27647d991e98bb3bcda8877b1107f20c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Include horizon as test requirement"},{"line_number":13,"context_line":"horizon\u003e\u003d16.0.0 # Apache-2.0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"selenium\u003e\u003d2.50.1 # Apache-2.0"},{"line_number":16,"context_line":"xvfbwrapper\u003e\u003d0.1.3 #license: MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_6774ac9c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":28},"in_reply_to":"3fa7e38b_c766cabc","updated":"2020-01-11 16:23:55.000000000","message":"The basic reason is to generate the \"Source Code Index\".\n\nAt the moment, this is unnecessary as modules in requirements.txt are installed when ironic-ui is installed in a venv. However, this works just because ironic-ui specifes \"install_command\" with upper-constraints.txt [1] and this is not the way used in most OpenStack projects. Once install_command was dropped and the upper-constraints is specified in \"deps\", horizon from Ussuri release would be installed as upper-constraints.txt is not specified when installing ironic-ui into a tox venv. In such case, the solution would be either to add -rrequirements.txt to \"deps\" or to have horizon in doc/requirements.txt (as we do now). \n\nI am not a maintainer of ironic-ui, so I have no strong opinion on this. What is the preference from the ironic-ui maintainer? Ideally I think it is better to sync the best practice in OpenStack dev community.","commit_id":"864c78b30cb740ac4e2cd0eb42e846215c64fc18"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bde46f5da072f7ab355a922b2c7b3c5660b39d5f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Include horizon as test requirement"},{"line_number":13,"context_line":"horizon\u003e\u003d16.0.0 # Apache-2.0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"selenium\u003e\u003d2.50.1 # Apache-2.0"},{"line_number":16,"context_line":"xvfbwrapper\u003e\u003d0.1.3 #license: MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_e7d2dc5f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":28},"in_reply_to":"3fa7e38b_c7a7a00a","updated":"2020-01-11 16:45:29.000000000","message":"IMHO it is better to follow the convention used widely in the OpenStack community. I modified tox.ini and doc/requirements.txt in the next patch set.","commit_id":"864c78b30cb740ac4e2cd0eb42e846215c64fc18"}]}