)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0b1380c1a0605fc0cdfe39853271858825350c61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f560f44_ddfd443c","updated":"2020-08-18 12:42:03.000000000","message":"The commit message should mention why npm tox env is added.","commit_id":"341c73ac0ec56d5ca79796e0224587d6051852b3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"875e66f9c4e817e50d1d21aedc64b3d71f646ab3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"support in their later version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch also adds npm tox env. in tox.ini file which fixes the"},{"line_number":18,"context_line":"failed nodejs job during focal migration."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Story: #2007865"},{"line_number":21,"context_line":"Task: #40188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9f560f44_1f768c07","line":18,"updated":"2020-08-18 17:07:01.000000000","message":"If the reason is only the failure on focal, you can use \u0027py38\u0027 or some instead of \u0027py36\u0027. It is better to describe the reason why you introduce a new tox env named \u0027npm\u0027 too.","commit_id":"835d8202c9a55c12c86849f8f675ba90d255c1e0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"51047addc5ee9030331cf1821b334710ea1a188e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As per victoria cycle testing runtime and community goal[1]"},{"line_number":10,"context_line":"we need to migrate upstream CI/CD to Ubuntu Focal(20.04)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixing:"},{"line_number":13,"context_line":"- bug#1886298"},{"line_number":14,"context_line":"Bump the lower constraints for required deps which added python3.8"},{"line_number":15,"context_line":"support in their later version."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_97995b6e","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":13},"updated":"2020-08-26 18:20:32.000000000","message":"This can be \"Closes-Bug: #nnnn\" and you can drop L.26.","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5f919dc5c2eb288283aff13bcbe57d034597a017","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As per victoria cycle testing runtime and community goal[1]"},{"line_number":10,"context_line":"we need to migrate upstream CI/CD to Ubuntu Focal(20.04)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixing:"},{"line_number":13,"context_line":"- bug#1886298"},{"line_number":14,"context_line":"Bump the lower constraints for required deps which added python3.8"},{"line_number":15,"context_line":"support in their later version."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_374defc3","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":13},"in_reply_to":"9f560f44_97995b6e","updated":"2020-08-26 18:33:32.000000000","message":"Done.","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"51047addc5ee9030331cf1821b334710ea1a188e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Bump the lower constraints for required deps which added python3.8"},{"line_number":15,"context_line":"support in their later version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch update python version to py38 in package.json,"},{"line_number":18,"context_line":"karma.conf.js as py36 is not avaialbale on focal. It also adds"},{"line_number":19,"context_line":"libfontconfig1 in bindep.txt as it requires for node-js job[2]."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_f7a3779c","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":57},"updated":"2020-08-26 18:20:32.000000000","message":"-\u003e and","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"51047addc5ee9030331cf1821b334710ea1a188e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Bump the lower constraints for required deps which added python3.8"},{"line_number":15,"context_line":"support in their later version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch update python version to py38 in package.json,"},{"line_number":18,"context_line":"karma.conf.js as py36 is not avaialbale on focal. It also adds"},{"line_number":19,"context_line":"libfontconfig1 in bindep.txt as it requires for node-js job[2]."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_37aa0f70","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":17},"updated":"2020-08-26 18:20:32.000000000","message":"-\u003e updates","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"51047addc5ee9030331cf1821b334710ea1a188e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch update python version to py38 in package.json,"},{"line_number":18,"context_line":"karma.conf.js as py36 is not avaialbale on focal. It also adds"},{"line_number":19,"context_line":"libfontconfig1 in bindep.txt as it requires for node-js job[2]."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Story: #2007865"},{"line_number":22,"context_line":"Task: #40188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_97e79be3","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":63},"updated":"2020-08-26 18:20:32.000000000","message":"The job result will be dropped after enough time passes, so [2] is not a good link. I think it is better to clarify the reason directly like \"phantomjs requires libfontconfg\" and add the link to the phantomjs doc https://www.npmjs.com/package/phantomjs-prebuilt#linux-note.","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5f919dc5c2eb288283aff13bcbe57d034597a017","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch update python version to py38 in package.json,"},{"line_number":18,"context_line":"karma.conf.js as py36 is not avaialbale on focal. It also adds"},{"line_number":19,"context_line":"libfontconfig1 in bindep.txt as it requires for node-js job[2]."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Story: #2007865"},{"line_number":22,"context_line":"Task: #40188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_57f4e35a","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":63},"in_reply_to":"9f560f44_97e79be3","updated":"2020-08-26 18:33:32.000000000","message":"Done.","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"}],"bindep.txt":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"51047addc5ee9030331cf1821b334710ea1a188e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# selenium tests"},{"line_number":2,"context_line":"firefox [selenium]"},{"line_number":3,"context_line":"libfontconfig1 [selenium]"},{"line_number":4,"context_line":"xvfb [selenium platform:dpkg]"},{"line_number":5,"context_line":"# already part of xorg-x11-server on openSUSE"},{"line_number":6,"context_line":"xorg-x11-server-Xvfb [selenium platform:redhat]"}],"source_content_type":"text/plain","patch_set":11,"id":"9f560f44_573b439a","line":3,"updated":"2020-08-26 18:20:32.000000000","message":"It looks better to add platform:dpkg because this package name looks specific to Ubuntu. According to rpmfind, fontconfig package provides libfontconfig.so.1.","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5f919dc5c2eb288283aff13bcbe57d034597a017","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# selenium tests"},{"line_number":2,"context_line":"firefox [selenium]"},{"line_number":3,"context_line":"libfontconfig1 [selenium]"},{"line_number":4,"context_line":"xvfb [selenium platform:dpkg]"},{"line_number":5,"context_line":"# already part of xorg-x11-server on openSUSE"},{"line_number":6,"context_line":"xorg-x11-server-Xvfb [selenium platform:redhat]"}],"source_content_type":"text/plain","patch_set":11,"id":"9f560f44_d768f321","line":3,"in_reply_to":"9f560f44_573b439a","updated":"2020-08-26 18:33:32.000000000","message":"Done.\nthanks.","commit_id":"94ba5d0fbc98ea4d69817440f57bb90c002d7304"}],"tox.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58f96618a7a66145bbcff3e0080bb57161ade8ad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"commands \u003d"},{"line_number":42,"context_line":"  nodeenv -p"},{"line_number":43,"context_line":"  npm install"},{"line_number":44,"context_line":"  npm run {posargs:test}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[testenv:venv]"},{"line_number":47,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":7,"id":"9f560f44_3de440ac","line":44,"updated":"2020-08-18 12:40:21.000000000","message":"I am personally against adding these commands.\nHow about just adding a tox env named \u0027npm\u0027?\n\n [testenv:npm]\n\nThis is from the following reasons.\n\n- npm jobs in the OpenStack CI do not use nodeenv. These commands are just for local development.\n- nodeenv is not listed in test-requirements.txt so tox -e npm does not work as is.\n\nThe main purpose of this patch is to make the jobs work in focal, Running npm tests in local using tox is a separate topic and should be discussed separately.","commit_id":"341c73ac0ec56d5ca79796e0224587d6051852b3"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"54032068a26d811cd6881797d525a03d6c3d1295","unresolved":false,"context_lines":[{"line_number":41,"context_line":"commands \u003d"},{"line_number":42,"context_line":"  nodeenv -p"},{"line_number":43,"context_line":"  npm install"},{"line_number":44,"context_line":"  npm run {posargs:test}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[testenv:venv]"},{"line_number":47,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":7,"id":"9f560f44_1da69c54","line":44,"in_reply_to":"9f560f44_3de440ac","updated":"2020-08-18 12:44:52.000000000","message":"ok, let me update it in the next P.S.","commit_id":"341c73ac0ec56d5ca79796e0224587d6051852b3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"875e66f9c4e817e50d1d21aedc64b3d71f646ab3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.1.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py3,pep8,npm"},{"line_number":5,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":8,"id":"9f560f44_bf2160ff","line":4,"updated":"2020-08-18 17:07:01.000000000","message":"There seems no need to have \u0027npm\u0027 in the default env list.","commit_id":"835d8202c9a55c12c86849f8f675ba90d255c1e0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"875e66f9c4e817e50d1d21aedc64b3d71f646ab3","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:pep8]"},{"line_number":35,"context_line":"commands \u003d flake8 {posargs}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[testenv:npm]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:venv]"}],"source_content_type":"text/x-properties","patch_set":8,"id":"9f560f44_ff1bd8c6","line":36,"updated":"2020-08-18 17:07:01.000000000","message":"It looks better to have some explanation on why this is required.","commit_id":"835d8202c9a55c12c86849f8f675ba90d255c1e0"}]}