)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8ccd812cd885b0bf619df26f3b2f7cee050bc000","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"161bf02f_a843f601","updated":"2026-08-17 19:27:26.000000000","message":"So, basically this is lacking a negative test. It should be a quick addition.","commit_id":"dff21394cd209c4cdc8d3bc0df45acd9ae916321"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8bf4ad011a73fbd3091ca9a030fbd3ccea1a6554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"640b76ff_454818e6","updated":"2026-08-18 13:32:03.000000000","message":"looks good, one comment inline, and I think we\u0027re missing api-ref and version history doc updates","commit_id":"aa7bcdfa205cf2d985069c02e7cdae03c91fa3e1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b9e70a0c60cf149e5bc06b9a808a8166fc487260","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"15854ac9_ead08c5c","updated":"2026-08-19 06:15:08.000000000","message":"thanks! we\u0027re very close","commit_id":"d4354a03d1b06961cb60c9f7708b237734aa3040"}],"api-ref/source/baremetal-api-v1-nodes-history.inc":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b9e70a0c60cf149e5bc06b9a808a8166fc487260","unresolved":true,"context_lines":[{"line_number":67,"context_line":"   - event: history_event"},{"line_number":68,"context_line":"   - event_type: history_event_type"},{"line_number":69,"context_line":"   - conductor: hostname"},{"line_number":70,"context_line":"   - project: project"},{"line_number":71,"context_line":"   - state: state"},{"line_number":72,"context_line":"   - target_provision_state: target_provision_state"},{"line_number":73,"context_line":"   - duration_seconds: duration_seconds"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"a15c0cb8_adf843a7","line":70,"updated":"2026-08-19 06:15:08.000000000","message":"you will have to add values also to api-ref/source/parameters.yaml","commit_id":"d4354a03d1b06961cb60c9f7708b237734aa3040"}],"api-ref/source/samples/node-history-list-response.json":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b9e70a0c60cf149e5bc06b9a808a8166fc487260","unresolved":true,"context_lines":[{"line_number":5,"context_line":"      \"created_at\": \"2021-09-15T17:45:04.686541+00:00\","},{"line_number":6,"context_line":"      \"severity\": \"ERROR\","},{"line_number":7,"context_line":"      \"event\": \"Something is wrong\","},{"line_number":8,"context_line":"      \"event_type\": \"provisioning\","},{"line_number":9,"context_line":"      \"conductor\": \"cat-tree1\","},{"line_number":10,"context_line":"      \"user\": \"peaches\","},{"line_number":11,"context_line":"      \"project\": \"admin\","}],"source_content_type":"application/json","patch_set":3,"id":"93a92014_90ed9df9","line":8,"updated":"2026-08-19 06:15:08.000000000","message":"this will need a separate sample file, let\u0027s revert this, we can do that in a follow up","commit_id":"d4354a03d1b06961cb60c9f7708b237734aa3040"}],"ironic/tests/unit/api/controllers/v1/test_node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8ccd812cd885b0bf619df26f3b2f7cee050bc000","unresolved":true,"context_lines":[{"line_number":9138,"context_line":"        self.assertIn(\u0027state\u0027, record)"},{"line_number":9139,"context_line":"        self.assertIn(\u0027target_provision_state\u0027, record)"},{"line_number":9140,"context_line":"        self.assertIn(\u0027duration_seconds\u0027, record)"},{"line_number":9141,"context_line":""},{"line_number":9142,"context_line":"    def test_get_history_item_not_found(self):"},{"line_number":9143,"context_line":"        self._add_history_entries()"},{"line_number":9144,"context_line":"        ret \u003d self.get_json(\u0027/nodes/%s/history/52949728-59fc-\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2328faf_234e9a9b","line":9141,"updated":"2026-08-17 19:27:26.000000000","message":"I guess the missing part here is to ensure the three fields are not present in 1.114. Specifically you\u0027ve also changed get_test_history_item to bump the minimum ersion.","commit_id":"dff21394cd209c4cdc8d3bc0df45acd9ae916321"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8bf4ad011a73fbd3091ca9a030fbd3ccea1a6554","unresolved":true,"context_lines":[{"line_number":9141,"context_line":""},{"line_number":9142,"context_line":"    def test_get_history_item_no_state_and_provision_fields_old_version(self):"},{"line_number":9143,"context_line":"        self._add_history_entries()"},{"line_number":9144,"context_line":"        record \u003d self.get_json(\u0027/nodes/%s/history/%s\u0027 % (self.node.uuid,"},{"line_number":9145,"context_line":"                                                         self.event1.uuid),"},{"line_number":9146,"context_line":"                               headers\u003d{api_base.Version.string: \u00271.114\u0027})"},{"line_number":9147,"context_line":"        self.assertNotIn(\u0027state\u0027, record)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d12682f_373d4f5c","line":9144,"updated":"2026-08-18 13:32:03.000000000","message":"we should verify that the \u0027project\u0027 field is prevent as a safeguard for version 1.113","commit_id":"aa7bcdfa205cf2d985069c02e7cdae03c91fa3e1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b9e70a0c60cf149e5bc06b9a808a8166fc487260","unresolved":true,"context_lines":[{"line_number":9108,"context_line":"        self._add_history_entries()"},{"line_number":9109,"context_line":"        record \u003d self.get_json(\u0027/nodes/%s/history/%s\u0027 % (self.node.uuid,"},{"line_number":9110,"context_line":"                                                         self.event1.uuid),"},{"line_number":9111,"context_line":"                               headers\u003d{api_base.Version.string: \u00271.115\u0027})"},{"line_number":9112,"context_line":"        self.assertEqual(12, len(record))"},{"line_number":9113,"context_line":"        expected_keys \u003d [\u0027created_at\u0027, \u0027links\u0027, \u0027event\u0027,"},{"line_number":9114,"context_line":"                         \u0027event_type\u0027, \u0027severity\u0027, \u0027user\u0027, \u0027uuid\u0027, \u0027project\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a04b68ad_5d62b9f6","line":9111,"updated":"2026-08-19 06:15:08.000000000","message":"this should be left as it was as \"base\" test\nyou are already adding the test for 1.115","commit_id":"d4354a03d1b06961cb60c9f7708b237734aa3040"}]}