)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b7702844d21effba13612f0efb6176ed57ccff5c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  selected by setting the warm parameter to False (cold) or True"},{"line_number":22,"context_line":"  (warm). Defaults to warm."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I508eabae7428daea29d749bb2aa9fc9c5a357e8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baada198_a63b1aea","line":24,"updated":"2014-07-09 21:11:20.000000000","message":"could we create a bug for this too?","commit_id":"6ce6338df927efedd84e27485a7803f921a19184"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"27ef18330aa87457c2c14fba4fd5077fa7468e29","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  selected by setting the warm parameter to False (cold) or True"},{"line_number":22,"context_line":"  (warm). Defaults to warm."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I508eabae7428daea29d749bb2aa9fc9c5a357e8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"baada198_a7a4f1b9","line":24,"in_reply_to":"baada198_a63b1aea","updated":"2014-07-10 00:07:31.000000000","message":"+1","commit_id":"6ce6338df927efedd84e27485a7803f921a19184"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"dbf0088aaa7257084ca8e25a263d06d21aefb915","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":477,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":478,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":479,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":480,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":481,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_a38d8cd5","line":478,"updated":"2014-06-18 07:29:00.000000000","message":"\u0027\u0027\u0027 -\u003e \"\"\" ?","commit_id":"028915ae2925bd7b7843720e69f881f3152925fd"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"dbf0088aaa7257084ca8e25a263d06d21aefb915","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":491,"context_line":"    def _bmc_reset(self, task, warm\u003dTrue):"},{"line_number":492,"context_line":"        \u0027\u0027\u0027Reset BMC with IPMI command \u0027bmc reset (warm|cold)\u0027.\u0027\u0027\u0027"},{"line_number":493,"context_line":"        if warm:"},{"line_number":494,"context_line":"            warm_param \u003d \u0027warm\u0027"},{"line_number":495,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_63aaa41b","line":492,"updated":"2014-06-18 07:29:00.000000000","message":"ditto","commit_id":"028915ae2925bd7b7843720e69f881f3152925fd"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"399cc6a2498a3b920ae29d29c1cd681e1bfda8df","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            if device not in VALID_BOOT_DEVICES:"},{"line_number":513,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":514,"context_line":"                    \"Invalid boot device %s specified.\") % device)"},{"line_number":515,"context_line":"        elif method \u003d\u003d \u0027send_raw\u0027:"},{"line_number":516,"context_line":"            if not kwargs.get(\u0027raw_bytes\u0027):"},{"line_number":517,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":518,"context_line":"                    \u0027Bytestring not supplied as raw_bytes.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_7e53e915","line":515,"updated":"2014-06-19 04:22:22.000000000","message":"Since the method list is growing, wouldn\u0027t it be good if we can do the following:\n\n1) All the methods set_boot_device, send_raw, set_bootparam,bmc_reset receive task, kwargs as arguments.\n\n2) We keep the list of vendor_passhthru method names and their corresponding methods in a dict, and then call them with task, kwargs.","commit_id":"2f492e3784fac4b569cbb43bdac1f88dc49a9175"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a07f1430644fa3aae4cdd0c8a6b65dc19cdaecc6","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":478,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":479,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab895d6_6112f8b5","line":478,"updated":"2014-06-30 10:07:12.000000000","message":"Hi Jim, kinda worried about it because the \"chassis bootparam set bootflag\" does the same thing as \"chassis bootdev\" (used by the _set_boot_device), no? Maybe it would be better to have only one way to set the boot device? We need to use bootparam for other things apart from setting the boot device?","commit_id":"5dcd906d09d5dd48fbb20e66f7a87ec2191147ec"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"da21637b15e69715834adefedb91695821c86f28","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":478,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":479,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab895d6_f33a5d35","line":478,"in_reply_to":"dab895d6_6112f8b5","updated":"2014-06-30 11:40:42.000000000","message":"I may be wrong, but \"ipmitool chassis bootdev set \u003csmth\u003e\" and \"ipmitool chassis bootparam set bootflag \u003csmth\u003e\" will do the same job. If so, we may replace bootdev with bootparam which is more generic.","commit_id":"5dcd906d09d5dd48fbb20e66f7a87ec2191147ec"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f8d34a3d9268a10aa0c7e511fa2525fbf7977546","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5d6180a7","line":465,"updated":"2014-07-07 21:54:26.000000000","message":"for consistency please list params as other functions.\nIE. \n:param task: a TaskManager instance.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_bada5b15","line":465,"in_reply_to":"baada198_5d6180a7","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":469,"context_line":"        cmd \u003d \u0027raw %s\u0027 % raw_bytes"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_974a6924","line":466,"updated":"2014-07-03 21:52:20.000000000","message":"just a suggestion. The node hmm, if it is the uuid, is a known length, whereas you don\u0027t know how long the raw bytes string is, so it might be better to put the node info first.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f8d34a3d9268a10aa0c7e511fa2525fbf7977546","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":469,"context_line":"        cmd \u003d \u0027raw %s\u0027 % raw_bytes"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5d9ee0b9","line":466,"updated":"2014-07-07 21:54:26.000000000","message":"we should start using the new _L* when logging.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":469,"context_line":"        cmd \u003d \u0027raw %s\u0027 % raw_bytes"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_fa8e9326","line":466,"in_reply_to":"baada198_5d9ee0b9","updated":"2014-07-10 14:00:37.000000000","message":"Debug log levels don\u0027t get translated, afaik.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":469,"context_line":"        cmd \u003d \u0027raw %s\u0027 % raw_bytes"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5aecdfc7","line":466,"in_reply_to":"baada198_974a6924","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":469,"context_line":"        cmd \u003d \u0027raw %s\u0027 % raw_bytes"},{"line_number":470,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_575c51ed","line":467,"updated":"2014-07-03 21:52:20.000000000","message":"Do you really want to output task.node, or task.node.uuid?","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes.\"\"\""},{"line_number":466,"context_line":"        LOG.debug(\u0027Sending raw bytes %(bytes)s to node %(node)s\u0027,"},{"line_number":467,"context_line":"                  {\u0027bytes\u0027: raw_bytes, \u0027node\u0027: task.node})"},{"line_number":468,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":469,"context_line":"        cmd \u003d \u0027raw %s\u0027 % raw_bytes"},{"line_number":470,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_63d3975f","line":467,"in_reply_to":"baada198_575c51ed","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f8d34a3d9268a10aa0c7e511fa2525fbf7977546","unresolved":false,"context_lines":[{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":478,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":479,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":482,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_1dbd4802","line":479,"updated":"2014-07-07 21:54:26.000000000","message":"for consistency please use dbl quotes here.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":478,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":479,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":482,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5a3a1f37","line":479,"in_reply_to":"baada198_1dbd4802","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":479,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":482,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":483,"context_line":"        cmd \u003d \u0027chassis bootparam %s\u0027 % flag"},{"line_number":484,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_971fc907","line":481,"updated":"2014-07-03 21:52:20.000000000","message":"ditto about task.node","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":478,"context_line":"    def _set_bootparam(self, task, flag):"},{"line_number":479,"context_line":"        \u0027\u0027\u0027Set a boot flag, such as \u0027set bootflag force_disk\u0027 on the BMC.\u0027\u0027\u0027"},{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":482,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":483,"context_line":"        cmd \u003d \u0027chassis bootparam %s\u0027 % flag"},{"line_number":484,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_3a356b46","line":481,"in_reply_to":"baada198_971fc907","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":482,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":483,"context_line":"        cmd \u003d \u0027chassis bootparam %s\u0027 % flag"},{"line_number":484,"context_line":"        try:"},{"line_number":485,"context_line":"            out, err \u003d _exec_ipmitool(driver_info, cmd)"},{"line_number":486,"context_line":"            LOG.debug(\u0027set bootparam returned stdout: %(stdout)s, stderr:\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_7a7e9c1a","line":483,"updated":"2014-07-03 21:52:20.000000000","message":"Is it the case that there are 2 (or more?) different syntax/commands for bootparam? I\u0027ve seen \u0027chassis bootparam \u003cflag\u003e\u0027 and \u0027chassis bootparam set bootflag \u003cflag\u003e\u0027.\n\nAre you trying to handle both cases?","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        LOG.debug(\u0027Setting bootparam %(flag)s on node %(node)s\u0027,"},{"line_number":481,"context_line":"                  {\u0027flag\u0027: flag, \u0027node\u0027: task.node})"},{"line_number":482,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":483,"context_line":"        cmd \u003d \u0027chassis bootparam %s\u0027 % flag"},{"line_number":484,"context_line":"        try:"},{"line_number":485,"context_line":"            out, err \u003d _exec_ipmitool(driver_info, cmd)"},{"line_number":486,"context_line":"            LOG.debug(\u0027set bootparam returned stdout: %(stdout)s, stderr:\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9af4b788","line":483,"in_reply_to":"baada198_7a7e9c1a","updated":"2014-07-10 14:00:37.000000000","message":"I\u0027m removing this method, as it does the same thing as \"chassis bootdev\"","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"58bddf80f51eb739f58fa34420254e42c7d3263d","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":492,"context_line":"    def _bmc_reset(self, task, warm\u003dTrue):"},{"line_number":493,"context_line":"        \u0027\u0027\u0027Reset BMC with IPMI command \u0027bmc reset (warm|cold)\u0027.\u0027\u0027\u0027"},{"line_number":494,"context_line":"        if warm:"},{"line_number":495,"context_line":"            warm_param \u003d \u0027warm\u0027"},{"line_number":496,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_7af1b594","line":493,"updated":"2014-07-09 05:49:26.000000000","message":"Here also should use double quotes","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":492,"context_line":"    def _bmc_reset(self, task, warm\u003dTrue):"},{"line_number":493,"context_line":"        \u0027\u0027\u0027Reset BMC with IPMI command \u0027bmc reset (warm|cold)\u0027.\u0027\u0027\u0027"},{"line_number":494,"context_line":"        if warm:"},{"line_number":495,"context_line":"            warm_param \u003d \u0027warm\u0027"},{"line_number":496,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_baf17b97","line":493,"in_reply_to":"baada198_7af1b594","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        else:"},{"line_number":497,"context_line":"            warm_param \u003d \u0027cold\u0027"},{"line_number":498,"context_line":"        LOG.debug(\u0027Doing %(warm)s BMC reset on node %(node)s\u0027,"},{"line_number":499,"context_line":"                  {\u0027warm\u0027: warm_param, \u0027node\u0027: task.node})"},{"line_number":500,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":501,"context_line":"        cmd \u003d \u0027bmc reset %s\u0027 % warm_param"},{"line_number":502,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_97cd0988","line":499,"updated":"2014-07-03 21:52:20.000000000","message":"ditto about task.node","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        else:"},{"line_number":497,"context_line":"            warm_param \u003d \u0027cold\u0027"},{"line_number":498,"context_line":"        LOG.debug(\u0027Doing %(warm)s BMC reset on node %(node)s\u0027,"},{"line_number":499,"context_line":"                  {\u0027warm\u0027: warm_param, \u0027node\u0027: task.node})"},{"line_number":500,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":501,"context_line":"        cmd \u003d \u0027bmc reset %s\u0027 % warm_param"},{"line_number":502,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_daee2fb4","line":499,"in_reply_to":"baada198_97cd0988","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        elif method \u003d\u003d \u0027send_raw\u0027:"},{"line_number":517,"context_line":"            if not kwargs.get(\u0027raw_bytes\u0027):"},{"line_number":518,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":519,"context_line":"                    \u0027Bytestring not supplied as raw_bytes.\u0027))"},{"line_number":520,"context_line":"        elif method \u003d\u003d \u0027set_bootparam\u0027:"},{"line_number":521,"context_line":"            if not kwargs.get(\u0027flag\u0027):"},{"line_number":522,"context_line":"                raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9a3e1027","line":519,"updated":"2014-07-03 21:52:20.000000000","message":"I think we can improve on these msgs. They don\u0027t clearly mention the name of the parameter that is expected.  Eg;\n\"Parameter \u0027raw_bytes\u0027 (string of bytes) wasn\u0027t specified\u0027.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        elif method \u003d\u003d \u0027send_raw\u0027:"},{"line_number":517,"context_line":"            if not kwargs.get(\u0027raw_bytes\u0027):"},{"line_number":518,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":519,"context_line":"                    \u0027Bytestring not supplied as raw_bytes.\u0027))"},{"line_number":520,"context_line":"        elif method \u003d\u003d \u0027set_bootparam\u0027:"},{"line_number":521,"context_line":"            if not kwargs.get(\u0027flag\u0027):"},{"line_number":522,"context_line":"                raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f5e86418","line":519,"in_reply_to":"baada198_9a3e1027","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3dca04ed6d48ec392a1acc504e033fa2b7825f85","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        elif method \u003d\u003d \u0027set_bootparam\u0027:"},{"line_number":521,"context_line":"            if not kwargs.get(\u0027flag\u0027):"},{"line_number":522,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":523,"context_line":"                    \u0027No bootparam flag specified\u0027))"},{"line_number":524,"context_line":"        elif method \u003d\u003d \u0027bmc_reset\u0027:"},{"line_number":525,"context_line":"            # no additional parameters needed"},{"line_number":526,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_3a0b447e","line":523,"updated":"2014-07-03 21:52:20.000000000","message":"ditto.","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3230269dfd266439b057a46aa484e5aeefa96b94","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        elif method \u003d\u003d \u0027set_bootparam\u0027:"},{"line_number":521,"context_line":"            if not kwargs.get(\u0027flag\u0027):"},{"line_number":522,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":523,"context_line":"                    \u0027No bootparam flag specified\u0027))"},{"line_number":524,"context_line":"        elif method \u003d\u003d \u0027bmc_reset\u0027:"},{"line_number":525,"context_line":"            # no additional parameters needed"},{"line_number":526,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_15eeb822","line":523,"in_reply_to":"baada198_3a0b447e","updated":"2014-07-10 14:00:37.000000000","message":"Done","commit_id":"20880a703b13ba5ead2ec2ccf66301cfbed071d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f1c86eb463c33b50a9175e6aa9b721b07f9cecd4","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        :param task: a TaskManager instance."},{"line_number":468,"context_line":"        :param raw_bytes: a string of raw bytes to send, e.g. \u00270x00 0x01\u0027"},{"line_number":469,"context_line":"        :raises: IPMIFailure on an error from ipmitool."},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        \"\"\""},{"line_number":472,"context_line":"        LOG.debug(\u0027Sending node %(node)s raw bytes %(bytes)s\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_2eeb35b1","line":469,"updated":"2014-07-10 21:09:29.000000000","message":"It could also raise InvalidParamValue if required ipmi parameters are missing. (Whether or not it should be mentioned in the docstring, I can\u0027t recall, but it is mentioned for _set_boot_device() so to be consistent...","commit_id":"4c98b08e61161e34595bc9a2cfcd96cceaef6591"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f1c86eb463c33b50a9175e6aa9b721b07f9cecd4","unresolved":false,"context_lines":[{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        :param task: a TaskManager instance."},{"line_number":488,"context_line":"        :param warm: boolean parameter to decide on warm or cold reset."},{"line_number":489,"context_line":"        :raises: IPMIFailure on an error from ipmitool."},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        \"\"\""},{"line_number":492,"context_line":"        if warm:"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_6ec52d3c","line":489,"updated":"2014-07-10 21:09:29.000000000","message":"ditto about InvalidParamValue.","commit_id":"4c98b08e61161e34595bc9a2cfcd96cceaef6591"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f1c86eb463c33b50a9175e6aa9b721b07f9cecd4","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        elif method \u003d\u003d \u0027send_raw\u0027:"},{"line_number":515,"context_line":"            if not kwargs.get(\u0027raw_bytes\u0027):"},{"line_number":516,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":517,"context_line":"                    \u0027Parameter raw_bytes (string of bytes) was not\u0027"},{"line_number":518,"context_line":"                    \u0027specified.\u0027))"},{"line_number":519,"context_line":"        elif method \u003d\u003d \u0027bmc_reset\u0027:"},{"line_number":520,"context_line":"            # no additional parameters needed"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_6e6d2d99","line":517,"updated":"2014-07-10 21:09:29.000000000","message":"you\u0027re missing a blank space after \u0027not\u0027; it\u0027ll be \u0027was notspecified\u0027 otherwise.","commit_id":"4c98b08e61161e34595bc9a2cfcd96cceaef6591"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0168cdc7260bb23e9689b631067913e67c05e96b","unresolved":false,"context_lines":[{"line_number":461,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        :param task: a TaskManager instance."}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_a449d261","line":464,"updated":"2014-07-14 11:28:04.000000000","message":"Just a friendly reminder: if you\u0027re going to use this methods outside of this class (IIRC you are), they should not start with underscore.","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d8f24535d0ccfb7d5c86af9b781e4e9dd9d6e80f","unresolved":false,"context_lines":[{"line_number":461,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":464,"context_line":"    def _send_raw_bytes(self, task, raw_bytes):"},{"line_number":465,"context_line":"        \"\"\"Send raw bytes to the BMC. Bytes should be a string of bytes."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        :param task: a TaskManager instance."}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_d36498e6","line":464,"in_reply_to":"baada198_a449d261","updated":"2014-07-15 13:15:02.000000000","message":"We won\u0027t be - callers should call vendor_passthru.","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0168cdc7260bb23e9689b631067913e67c05e96b","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            LOG.debug(\u0027send raw bytes returned stdout: %(stdout)s, stderr:\u0027"},{"line_number":479,"context_line":"                      \u0027 %(stderr)s\u0027, {\u0027stdout\u0027: out, \u0027stderr\u0027: err})"},{"line_number":480,"context_line":"        except Exception:"},{"line_number":481,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":484,"context_line":"    def _bmc_reset(self, task, warm\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_44a7160b","line":481,"updated":"2014-07-14 11:28:04.000000000","message":"Please don\u0027t lose context of this exception, at least please log.exception() it, otherwise we\u0027ll get something too generic here","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d8f24535d0ccfb7d5c86af9b781e4e9dd9d6e80f","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            LOG.debug(\u0027send raw bytes returned stdout: %(stdout)s, stderr:\u0027"},{"line_number":479,"context_line":"                      \u0027 %(stderr)s\u0027, {\u0027stdout\u0027: out, \u0027stderr\u0027: err})"},{"line_number":480,"context_line":"        except Exception:"},{"line_number":481,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":484,"context_line":"    def _bmc_reset(self, task, warm\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_f35fdc0c","line":481,"in_reply_to":"baada198_44a7160b","updated":"2014-07-15 13:15:02.000000000","message":"Done","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0168cdc7260bb23e9689b631067913e67c05e96b","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            LOG.debug(\u0027bmc reset returned stdout: %(stdout)s, stderr:\u0027"},{"line_number":503,"context_line":"                      \u0027 %(stderr)s\u0027, {\u0027stdout\u0027: out, \u0027stderr\u0027: err})"},{"line_number":504,"context_line":"        except Exception:"},{"line_number":505,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def validate(self, task, **kwargs):"},{"line_number":508,"context_line":"        method \u003d kwargs[\u0027method\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_a4b71239","line":505,"updated":"2014-07-14 11:28:04.000000000","message":"ditto about logging","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d8f24535d0ccfb7d5c86af9b781e4e9dd9d6e80f","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            LOG.debug(\u0027bmc reset returned stdout: %(stdout)s, stderr:\u0027"},{"line_number":503,"context_line":"                      \u0027 %(stderr)s\u0027, {\u0027stdout\u0027: out, \u0027stderr\u0027: err})"},{"line_number":504,"context_line":"        except Exception:"},{"line_number":505,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def validate(self, task, **kwargs):"},{"line_number":508,"context_line":"        method \u003d kwargs[\u0027method\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_135b7022","line":505,"in_reply_to":"baada198_a4b71239","updated":"2014-07-15 13:15:02.000000000","message":"Done","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a893edc70d88628c5455189bb3e4a20e6bd8f4c3","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        except Exception as e:"},{"line_number":483,"context_line":"            LOG.exception(_(\u0027IPMI \"raw bytes\" failed for node %(node_id)s \u0027"},{"line_number":484,"context_line":"                          \u0027with error: %(error)s.\u0027)"},{"line_number":485,"context_line":"                        % {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":486,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_5b495ab6","line":485,"updated":"2014-07-16 09:36:00.000000000","message":"Nit: Just fix it if you put another review up. \n\nFor logs interpolation we really should use \u0027,\u0027 instead of \u0027%\u0027 [1]\n\n[1] http://stackoverflow.com/questions/11615053/why-use-multiple-arguments-to-log-instead-of-interpolation","commit_id":"da31c20cc4b9f2b95bce57388751ad86407ca50b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a893edc70d88628c5455189bb3e4a20e6bd8f4c3","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        except Exception as e:"},{"line_number":514,"context_line":"            LOG.exception(_(\u0027IPMI \"bmc reset\" failed for node %(node_id)s \u0027"},{"line_number":515,"context_line":"                          \u0027with error: %(error)s.\u0027)"},{"line_number":516,"context_line":"                        % {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":517,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def validate(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_dbd48abf","line":516,"updated":"2014-07-16 09:36:00.000000000","message":"Nit: Just fix it if you put another review up. \n\nFor logs interpolation we really should use \u0027,\u0027 instead of \u0027%\u0027 [1]\n\n[1] http://stackoverflow.com/questions/11615053/why-use-multiple-arguments-to-log-instead-of-interpolation","commit_id":"da31c20cc4b9f2b95bce57388751ad86407ca50b"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"27cbc720b1be7a08393bebf63a40c6c2ee01dc86","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        except Exception as e:"},{"line_number":483,"context_line":"            LOG.exception(_(\u0027IPMI \"raw bytes\" failed for node %(node_id)s \u0027"},{"line_number":484,"context_line":"                          \u0027with error: %(error)s.\u0027)"},{"line_number":485,"context_line":"                        % {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":486,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":17,"id":"baada198_000bc32b","line":485,"updated":"2014-07-17 06:50:47.000000000","message":"nit: use , instead of % for LOG.xxx","commit_id":"9e440c0c40e0499b0c61e213fb94acc9e4a1def9"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"27cbc720b1be7a08393bebf63a40c6c2ee01dc86","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        except Exception as e:"},{"line_number":514,"context_line":"            LOG.exception(_(\u0027IPMI \"bmc reset\" failed for node %(node_id)s \u0027"},{"line_number":515,"context_line":"                          \u0027with error: %(error)s.\u0027)"},{"line_number":516,"context_line":"                        % {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":517,"context_line":"            raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def validate(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"baada198_6052bf36","line":516,"updated":"2014-07-17 06:50:47.000000000","message":"nit: use , instead of % for LOG.xxx","commit_id":"9e440c0c40e0499b0c61e213fb94acc9e4a1def9"}],"ironic/tests/drivers/test_ipmitool.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a9d85d202696fd193a39521cfa19580ebeb66518","unresolved":false,"context_lines":[{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def test_vendor_passthru_validate__bmc_reset_good(self):"},{"line_number":747,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":748,"context_line":"            self.driver.vendor.validate(task,"},{"line_number":749,"context_line":"                                        method\u003d\u0027bmc_reset\u0027)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def test_vendor_passthru_validate__bmc_reset_warm_good(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_b6ce7a2b","line":748,"updated":"2014-07-13 15:31:43.000000000","message":"This is asserting that the \u0027bmc_reset\u0027 method exists by calling validate() on it.","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"bec2480352357be83a150c1724328caeca4ea315","unresolved":false,"context_lines":[{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def test_vendor_passthru_validate__bmc_reset_good(self):"},{"line_number":747,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":748,"context_line":"            self.driver.vendor.validate(task,"},{"line_number":749,"context_line":"                                        method\u003d\u0027bmc_reset\u0027)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def test_vendor_passthru_validate__bmc_reset_warm_good(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_d9e40b0f","line":748,"updated":"2014-07-12 11:35:16.000000000","message":"This test method does not make any assertion. The fact that there was no exception does not guarantee that it performed required stuff.","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"df2021573766ff989b09d246f7fd8f5382dbf188","unresolved":false,"context_lines":[{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    def test_vendor_passthru_validate__bmc_reset_good(self):"},{"line_number":747,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027]) as task:"},{"line_number":748,"context_line":"            self.driver.vendor.validate(task,"},{"line_number":749,"context_line":"                                        method\u003d\u0027bmc_reset\u0027)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def test_vendor_passthru_validate__bmc_reset_warm_good(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_6446f37c","line":748,"in_reply_to":"baada198_d9e40b0f","updated":"2014-07-12 23:33:56.000000000","message":"Roman, for bmc_reset, the validate() method just does \"pass\", there\u0027s really nothing I can assert here.","commit_id":"ef92a5e63c04ea57bf545b67ef4e3aa48e7f15df"}]}
