)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f5a5f2867f5f0412cc45f7f0c43c8c730d83ffa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjacob-anders-dev@proton.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-10-15 15:21:10 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Dell LC job status helper for multiple JIDs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On Dell hardware a Redfish firmware update task can finish before the"},{"line_number":10,"context_line":"firmware has been applied: the Lifecycle Controller applies it in a job"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"82172cec_f3faa7a0","line":7,"updated":"2026-10-15 11:47:54.000000000","message":"It\u0027s odd to focus on the helper: you\u0027re changing the behavior, aren\u0027t you? Let\u0027s focus on the main user-visible change in the summary.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jacob Anders \u003cjacob-anders-dev@proton.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-10-15 15:21:10 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Dell LC job status helper for multiple JIDs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On Dell hardware a Redfish firmware update task can finish before the"},{"line_number":10,"context_line":"firmware has been applied: the Lifecycle Controller applies it in a job"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ae8ceee_5db9ec50","line":7,"in_reply_to":"82172cec_f3faa7a0","updated":"2026-10-19 10:24:32.000000000","message":"Good point, updated commit message.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7072c370a039904163ff52ce8fe7d0d82f2fbcc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3087abd4_5f7b47ea","updated":"2026-09-17 02:03:10.000000000","message":"Code wise lgtm, and makes sense to have the Dell bits here since we have the drac/firmware.py to help","commit_id":"374879b1e94479f65cd938bc895d77ae8801cc47"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b14a3564974856d8621a23b2da7db007e071d916","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f5710f99_95504938","updated":"2026-09-17 04:46:59.000000000","message":"recommend adding a release note","commit_id":"374879b1e94479f65cd938bc895d77ae8801cc47"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"18063fffeb66ddd5759306f9bcc5218bdab02b1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f98c8272_2315cf8f","in_reply_to":"f5710f99_95504938","updated":"2026-09-17 06:33:19.000000000","message":"Done","commit_id":"374879b1e94479f65cd938bc895d77ae8801cc47"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a34a6c2b59abbaf023d13c15e2c7a6841d5d33a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a5d42b9a_9cb99813","updated":"2026-09-22 00:28:02.000000000","message":"Moving to +2, ironic have cut the branch so this will land in Indri. \nJust wondering if we should release sushy in Indri and update the requirements.","commit_id":"5b3ef05620f4e01de95d8e3e63a555011712484c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"67b90666e4c13dbd97b871cd463c64ab38d259bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58cb17c4_656f200c","updated":"2026-09-21 02:15:44.000000000","message":"So, this depends on the sushy change https://review.opendev.org/c/openstack/sushy/+/1005653 right?\n\nSushy is already targeting 2027.1 Indri, we need the sushy patch backported and will probably need to cut a new Hibiscus release for it.. \nOr maybe I\u0027m overthinking.. @elfosardo@gmail.com thoughts?","commit_id":"5b3ef05620f4e01de95d8e3e63a555011712484c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c534b30520c80a0de67748525dd10b3b45565998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"990b2f0b_f71b7b67","in_reply_to":"a5d42b9a_9cb99813","updated":"2026-09-22 06:55:45.000000000","message":"we should remove the depends on from here, that is misleading for the requirements, we risk to merge something that does not work because of a requirement that is not released yet. I will release sushy, then we update the reqs here.","commit_id":"5b3ef05620f4e01de95d8e3e63a555011712484c"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"915efb3b666a5a54a6f6bde7f50d86579a6c6fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d58eb3c1_bed96054","updated":"2026-09-29 08:22:10.000000000","message":"let\u0027s assess GPT-Astra alternate patches and decide if and how to reconcile the sets","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"89858efbe8389d4c85e161e2da66790686e69cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c9a171b9_63ebd603","updated":"2026-10-02 00:55:36.000000000","message":"Brought in improvements suggested by GPT Astra into this series. Ready for re-review.","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"741416be_f149c211","updated":"2026-10-02 00:20:05.000000000","message":"Thank you for your review Dmitry, I think I addressed all comments/suggestions. Let me know what you think.","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"358fee5be4a6bd2b28aaa0c9ee8367b3c44c036d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"142293b9_643d551b","updated":"2026-10-01 06:39:57.000000000","message":"re-reviewing after merging in improvements from an alternate implementation","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"1738b096cef4e33fb7d42221430f4bb87608ed25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"30146129_ff458742","updated":"2026-10-06 13:02:13.000000000","message":"running lab tests, lets wait for results before resuming reviews","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"afa68c81c4fd27977812f8d6e15018d6cf3cf34f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ee5a0cf0_ef7a72c9","updated":"2026-10-09 12:07:27.000000000","message":"Merged in changes proposed by agentic review. On-hardware lab testing ongoing.","commit_id":"89c8af76485161b53cc573be42c27454606d9158"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d6b7cc58b98315e1db7454e146ff98b30413e60d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6c29ad9f_9f6d56f4","updated":"2026-10-15 05:28:26.000000000","message":"Thank you for your review Iury. Pushed updated patch.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"71caf901_4486c0e9","updated":"2026-10-19 10:24:32.000000000","message":"Thank you for your comments Iury, Dmitry and Riccardo, pushed updated version of the patch.","commit_id":"ecb38a5bd2c37bdc938d587b9d3aba24e079577b"}],"ironic/drivers/modules/drac/firmware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LC_JOBS_DONE \u003d \u0027done\u0027"},{"line_number":28,"context_line":"LC_JOBS_RUNNING \u003d \u0027running\u0027"},{"line_number":29,"context_line":"LC_JOBS_ERROR \u003d \u0027error\u0027"},{"line_number":30,"context_line":"LC_JOBS_UNAVAILABLE \u003d \u0027unavailable\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"306bb644_027cc3e8","line":27,"updated":"2026-09-28 10:40:22.000000000","message":"nit: create a real enum?","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LC_JOBS_DONE \u003d \u0027done\u0027"},{"line_number":28,"context_line":"LC_JOBS_RUNNING \u003d \u0027running\u0027"},{"line_number":29,"context_line":"LC_JOBS_ERROR \u003d \u0027error\u0027"},{"line_number":30,"context_line":"LC_JOBS_UNAVAILABLE \u003d \u0027unavailable\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"8df96c0d_488e4d45","line":27,"in_reply_to":"306bb644_027cc3e8","updated":"2026-10-02 00:20:05.000000000","message":"Done in ironic/drivers/modules/drac/firmware.py:34-37","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                    {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":49,"context_line":"        return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if not system.managers:"},{"line_number":52,"context_line":"        return None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    for manager in system.managers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"78e537c3_39eab142","line":51,"updated":"2026-09-28 10:40:22.000000000","message":"This can raise MissingAttributeError. If you don\u0027t want to handle it, add it to the docstring. (Existing code, so not blocking on it.)","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":49,"context_line":"        return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if not system.managers:"},{"line_number":52,"context_line":"        return None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    for manager in system.managers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3d29803f_ac6dc9bc","line":51,"in_reply_to":"78e537c3_39eab142","updated":"2026-10-02 00:20:05.000000000","message":"Done in ironic/drivers/modules/drac/firmware.py:73-75","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":90,"context_line":"           if task_monitor_uri else \u0027\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if not jid:"},{"line_number":93,"context_line":"        return None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    status, detail \u003d check_lc_jobs(task, [jid])"},{"line_number":96,"context_line":"    if status \u003d\u003d LC_JOBS_UNAVAILABLE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"cef0d8c6_f4fbda28","line":93,"updated":"2026-09-28 10:40:22.000000000","message":"Worth logging a warning here? We don\u0027t expect this from Dell machines, right?","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"           if task_monitor_uri else \u0027\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if not jid:"},{"line_number":93,"context_line":"        return None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    status, detail \u003d check_lc_jobs(task, [jid])"},{"line_number":96,"context_line":"    if status \u003d\u003d LC_JOBS_UNAVAILABLE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0122569_8d26ba14","line":93,"in_reply_to":"cef0d8c6_f4fbda28","updated":"2026-10-02 00:20:05.000000000","message":"Good point, done (L116 above)","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    if status \u003d\u003d LC_JOBS_UNAVAILABLE:"},{"line_number":97,"context_line":"        return None"},{"line_number":98,"context_line":"    if status \u003d\u003d LC_JOBS_RUNNING:"},{"line_number":99,"context_line":"        LOG.info("},{"line_number":100,"context_line":"            \u0027Dell iDRAC: found scheduled LC job %(jid)s \u0027"},{"line_number":101,"context_line":"            \u0027for node %(node)s, firmware staging succeeded.\u0027,"},{"line_number":102,"context_line":"            {\u0027jid\u0027: jid, \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a882e0e_78c5b2bc","line":99,"updated":"2026-09-28 10:40:22.000000000","message":"nit: I\u0027m leaning towards DEBUG","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    if status \u003d\u003d LC_JOBS_UNAVAILABLE:"},{"line_number":97,"context_line":"        return None"},{"line_number":98,"context_line":"    if status \u003d\u003d LC_JOBS_RUNNING:"},{"line_number":99,"context_line":"        LOG.info("},{"line_number":100,"context_line":"            \u0027Dell iDRAC: found scheduled LC job %(jid)s \u0027"},{"line_number":101,"context_line":"            \u0027for node %(node)s, firmware staging succeeded.\u0027,"},{"line_number":102,"context_line":"            {\u0027jid\u0027: jid, \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":3,"id":"32c0eb7e_4095c3c4","line":99,"in_reply_to":"1a882e0e_78c5b2bc","updated":"2026-10-02 00:20:05.000000000","message":"Done in ironic/drivers/modules/drac/firmware.py:127-129","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        return None"},{"line_number":98,"context_line":"    if status \u003d\u003d LC_JOBS_RUNNING:"},{"line_number":99,"context_line":"        LOG.info("},{"line_number":100,"context_line":"            \u0027Dell iDRAC: found scheduled LC job %(jid)s \u0027"},{"line_number":101,"context_line":"            \u0027for node %(node)s, firmware staging succeeded.\u0027,"},{"line_number":102,"context_line":"            {\u0027jid\u0027: jid, \u0027node\u0027: node.uuid})"},{"line_number":103,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bc157be2_c68b8587","line":100,"updated":"2026-09-28 10:40:22.000000000","message":"nit: the log record is already located in `...modules.drac.firmware`","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        return None"},{"line_number":98,"context_line":"    if status \u003d\u003d LC_JOBS_RUNNING:"},{"line_number":99,"context_line":"        LOG.info("},{"line_number":100,"context_line":"            \u0027Dell iDRAC: found scheduled LC job %(jid)s \u0027"},{"line_number":101,"context_line":"            \u0027for node %(node)s, firmware staging succeeded.\u0027,"},{"line_number":102,"context_line":"            {\u0027jid\u0027: jid, \u0027node\u0027: node.uuid})"},{"line_number":103,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"f0ed6d50_aa74104d","line":100,"in_reply_to":"bc157be2_c68b8587","updated":"2026-10-02 00:20:05.000000000","message":"Good point, redundant prefixes removed.","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        detail \u003d \u0027; \u0027.join("},{"line_number":183,"context_line":"            \u0027%s: %s - %s\u0027 % (jid, job_state, message or \u0027unknown error\u0027)"},{"line_number":184,"context_line":"            for jid, job_state, message in failed)"},{"line_number":185,"context_line":"        return LC_JOBS_ERROR, detail"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if running:"},{"line_number":188,"context_line":"        return LC_JOBS_RUNNING, \u0027, \u0027.join(running)"}],"source_content_type":"text/x-python","patch_set":3,"id":"56a42ab9_262b4b47","line":185,"updated":"2026-09-28 10:40:22.000000000","message":"This is potentially problematic: what if there are other jobs still running? Shouldn\u0027t this wait for all jobs to finish somehow before reporting? Otherwise, Ironic may decide to move on to the next actions, while Dell still has pending jobs.","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        detail \u003d \u0027; \u0027.join("},{"line_number":183,"context_line":"            \u0027%s: %s - %s\u0027 % (jid, job_state, message or \u0027unknown error\u0027)"},{"line_number":184,"context_line":"            for jid, job_state, message in failed)"},{"line_number":185,"context_line":"        return LC_JOBS_ERROR, detail"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if running:"},{"line_number":188,"context_line":"        return LC_JOBS_RUNNING, \u0027, \u0027.join(running)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7cd78f17_2a891d7f","line":185,"in_reply_to":"56a42ab9_262b4b47","updated":"2026-10-02 00:20:05.000000000","message":"Done via the reorder suggested below (L198): ERROR is only reported once none of the given JIDs is still running; until then callers keep polling.","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":184,"context_line":"            for jid, job_state, message in failed)"},{"line_number":185,"context_line":"        return LC_JOBS_ERROR, detail"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if running:"},{"line_number":188,"context_line":"        return LC_JOBS_RUNNING, \u0027, \u0027.join(running)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    return LC_JOBS_DONE, None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea7dcca3_518e72ae","line":187,"updated":"2026-09-28 10:40:22.000000000","message":"i.e. move this above `if failed`?","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            for jid, job_state, message in failed)"},{"line_number":185,"context_line":"        return LC_JOBS_ERROR, detail"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if running:"},{"line_number":188,"context_line":"        return LC_JOBS_RUNNING, \u0027, \u0027.join(running)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    return LC_JOBS_DONE, None"}],"source_content_type":"text/x-python","patch_set":3,"id":"8edc2d29_1dac8852","line":187,"in_reply_to":"ea7dcca3_518e72ae","updated":"2026-10-02 00:20:05.000000000","message":"Very good point, done. This helps with https://review.opendev.org/c/openstack/ironic/+/1005656/comment/56a42ab9_262b4b47/","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":200,"context_line":"    :param jids: an iterable of Dell LC job IDs (JIDs) to check"},{"line_number":201,"context_line":"    :returns: a tuple (status, detail).  status is one of"},{"line_number":202,"context_line":"        LC_JOBS_DONE, LC_JOBS_RUNNING, LC_JOBS_ERROR,"},{"line_number":203,"context_line":"        LC_JOBS_UNAVAILABLE.  detail is None for LC_JOBS_DONE, a"},{"line_number":204,"context_line":"        comma-separated list of still-running JIDs for"},{"line_number":205,"context_line":"        LC_JOBS_RUNNING, a description of the failed job(s) for"},{"line_number":206,"context_line":"        LC_JOBS_ERROR, or a reason string for LC_JOBS_UNAVAILABLE"}],"source_content_type":"text/x-python","patch_set":3,"id":"86c1364b_1cb935a5","line":203,"updated":"2026-09-28 10:40:22.000000000","message":"I haven\u0027t read the next patches yet, but do you actually need to distinguish so many cases?","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    :param jids: an iterable of Dell LC job IDs (JIDs) to check"},{"line_number":201,"context_line":"    :returns: a tuple (status, detail).  status is one of"},{"line_number":202,"context_line":"        LC_JOBS_DONE, LC_JOBS_RUNNING, LC_JOBS_ERROR,"},{"line_number":203,"context_line":"        LC_JOBS_UNAVAILABLE.  detail is None for LC_JOBS_DONE, a"},{"line_number":204,"context_line":"        comma-separated list of still-running JIDs for"},{"line_number":205,"context_line":"        LC_JOBS_RUNNING, a description of the failed job(s) for"},{"line_number":206,"context_line":"        LC_JOBS_ERROR, or a reason string for LC_JOBS_UNAVAILABLE"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f98102a_e66446f7","line":203,"in_reply_to":"86c1364b_1cb935a5","updated":"2026-10-02 00:20:05.000000000","message":"Fewer now. What was removed: read failures are no longer reported as a status. In PS3, a failure to read the system, managers or jobs came back as UNAVAILABLE, or silently fell back to the unfinished-jobs list, so \"couldn\u0027t read\" looked the same as \"not supported\". Now they raise, and callers retry on the next poll. A job missing from the queue also no longer counts as DONE.\n\nWhat remains, and why:\n- DONE: every job finished successfully. The post-reboot gate passes.\n- RUNNING: at least one job hasn\u0027t finished. Callers keep polling; this is also reported while another job has already failed, so we never act while the LC is still applying something.\n- ERROR: everything has stopped and a job failed or is missing from the queue. The step fails.\n- UNAVAILABLE: the node has no Dell OEM job collection, so there is nothing to check. The LC gate is skipped.\n\nDONE and UNAVAILABLE are kept apart deliberately: only a finished job proves POST ran, which lets the post-reboot verify in 1005658 skip the fixed delay on BMCs that don\u0027t report BootProgress.","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    try:"},{"line_number":232,"context_line":"        jobs \u003d get_jobs(job_ids\u003djids)"},{"line_number":233,"context_line":"    except Exception as e:"},{"line_number":234,"context_line":"        LOG.warning(\u0027Failed to fetch Dell LC jobs %(jids)s for node \u0027"},{"line_number":235,"context_line":"                    \u0027%(node)s: %(error)s. Falling back to the \u0027"},{"line_number":236,"context_line":"                    \u0027unfinished-jobs check.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"cffdc357_2822596e","line":233,"updated":"2026-09-28 10:40:22.000000000","message":"Let\u0027s limit it to Sushy exceptions?","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    try:"},{"line_number":232,"context_line":"        jobs \u003d get_jobs(job_ids\u003djids)"},{"line_number":233,"context_line":"    except Exception as e:"},{"line_number":234,"context_line":"        LOG.warning(\u0027Failed to fetch Dell LC jobs %(jids)s for node \u0027"},{"line_number":235,"context_line":"                    \u0027%(node)s: %(error)s. Falling back to the \u0027"},{"line_number":236,"context_line":"                    \u0027unfinished-jobs check.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8760638_f1506ef4","line":233,"in_reply_to":"cffdc357_2822596e","updated":"2026-10-02 00:20:05.000000000","message":"check_lc_jobs no longer catches exceptions; callers (ironic/drivers/modules/redfish/firmware.py L1331 in this change, L1657 in https://review.opendev.org/c/openstack/ironic/+/1005658) only catch exception.RedfishError and sushy.exceptions.SushyError","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"0db2158a2c9c487fd088d5a06821db11c905eb94","unresolved":true,"context_lines":[{"line_number":94,"context_line":"def check_scheduled_idrac_job(task, current_update):"},{"line_number":95,"context_line":"    \"\"\"Check Dell iDRAC for a scheduled Lifecycle Controller job."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    Used when the Redfish task of a firmware update disappeared before"},{"line_number":98,"context_line":"    it could be observed: a job that is still scheduled or running means"},{"line_number":99,"context_line":"    the firmware was staged and a reboot will apply it, while a missing"},{"line_number":100,"context_line":"    or finished job means the download or staging did not leave anything"},{"line_number":101,"context_line":"    to apply."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    :param task: a TaskManager instance"},{"line_number":104,"context_line":"    :param current_update: the current firmware update being processed"}],"source_content_type":"text/x-python","patch_set":4,"id":"f17620a2_204967d4","line":101,"range":{"start_line":97,"start_character":3,"end_line":101,"end_character":13},"updated":"2026-10-02 00:57:41.000000000","message":"bit awkward wording, worth refining if further revisions are needed","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d6b7cc58b98315e1db7454e146ff98b30413e60d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"def check_scheduled_idrac_job(task, current_update):"},{"line_number":95,"context_line":"    \"\"\"Check Dell iDRAC for a scheduled Lifecycle Controller job."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    Used when the Redfish task of a firmware update disappeared before"},{"line_number":98,"context_line":"    it could be observed: a job that is still scheduled or running means"},{"line_number":99,"context_line":"    the firmware was staged and a reboot will apply it, while a missing"},{"line_number":100,"context_line":"    or finished job means the download or staging did not leave anything"},{"line_number":101,"context_line":"    to apply."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    :param task: a TaskManager instance"},{"line_number":104,"context_line":"    :param current_update: the current firmware update being processed"}],"source_content_type":"text/x-python","patch_set":4,"id":"14f3f6c0_c660a00b","line":101,"range":{"start_line":97,"start_character":3,"end_line":101,"end_character":13},"in_reply_to":"2ac55d7a_17fd54e7","updated":"2026-10-15 05:28:26.000000000","message":"Reworded it while updating the reno.","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"78d8cee73d162b69ec9e575f19ef39aa56114b2f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"def check_scheduled_idrac_job(task, current_update):"},{"line_number":95,"context_line":"    \"\"\"Check Dell iDRAC for a scheduled Lifecycle Controller job."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    Used when the Redfish task of a firmware update disappeared before"},{"line_number":98,"context_line":"    it could be observed: a job that is still scheduled or running means"},{"line_number":99,"context_line":"    the firmware was staged and a reboot will apply it, while a missing"},{"line_number":100,"context_line":"    or finished job means the download or staging did not leave anything"},{"line_number":101,"context_line":"    to apply."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    :param task: a TaskManager instance"},{"line_number":104,"context_line":"    :param current_update: the current firmware update being processed"}],"source_content_type":"text/x-python","patch_set":4,"id":"2ac55d7a_17fd54e7","line":101,"range":{"start_line":97,"start_character":3,"end_line":101,"end_character":13},"in_reply_to":"f17620a2_204967d4","updated":"2026-10-15 01:26:56.000000000","message":"I was able to understand, but I had to read twice XD","commit_id":"9eba08bc1c3a42c888d9ee80c65fa1b49ad427dc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f5a5f2867f5f0412cc45f7f0c43c8c730d83ffa","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                        {\u0027manager\u0027: manager.identity, \u0027node\u0027: node.uuid,"},{"line_number":87,"context_line":"                         \u0027error\u0027: e})"},{"line_number":88,"context_line":"            continue"},{"line_number":89,"context_line":"        return manager_oem.job_collection"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    return None"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"cac28096_ba43d4aa","line":89,"updated":"2026-10-15 11:47:54.000000000","message":"This can potentially raise MissingAttributeError (not sure if it happens in practice)","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                        {\u0027manager\u0027: manager.identity, \u0027node\u0027: node.uuid,"},{"line_number":87,"context_line":"                         \u0027error\u0027: e})"},{"line_number":88,"context_line":"            continue"},{"line_number":89,"context_line":"        return manager_oem.job_collection"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    return None"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ed83526e_fcf15859","line":89,"in_reply_to":"cac28096_ba43d4aa","updated":"2026-10-19 10:24:32.000000000","message":"Fair, added exception handling","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f5a5f2867f5f0412cc45f7f0c43c8c730d83ffa","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    node \u003d task.node"},{"line_number":113,"context_line":"    jid \u003d jid_from_task_monitor(current_update.get(\u0027task_monitor\u0027))"},{"line_number":114,"context_line":"    if not jid:"},{"line_number":115,"context_line":"        LOG.warning(\u0027Task monitor %(uri)s of node %(node)s does not name a \u0027"},{"line_number":116,"context_line":"                    \u0027Lifecycle Controller job, so the job cannot be \u0027"},{"line_number":117,"context_line":"                    \u0027checked.\u0027,"},{"line_number":118,"context_line":"                    {\u0027uri\u0027: current_update.get(\u0027task_monitor\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"aa9b017c_5b44f175","line":115,"updated":"2026-10-15 11:47:54.000000000","message":"nit: s/name/represent/ ?","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    node \u003d task.node"},{"line_number":113,"context_line":"    jid \u003d jid_from_task_monitor(current_update.get(\u0027task_monitor\u0027))"},{"line_number":114,"context_line":"    if not jid:"},{"line_number":115,"context_line":"        LOG.warning(\u0027Task monitor %(uri)s of node %(node)s does not name a \u0027"},{"line_number":116,"context_line":"                    \u0027Lifecycle Controller job, so the job cannot be \u0027"},{"line_number":117,"context_line":"                    \u0027checked.\u0027,"},{"line_number":118,"context_line":"                    {\u0027uri\u0027: current_update.get(\u0027task_monitor\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1e6a0b77_1bfb96f5","line":115,"in_reply_to":"aa9b017c_5b44f175","updated":"2026-10-19 10:24:32.000000000","message":"Fair, rephrased it.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f5a5f2867f5f0412cc45f7f0c43c8c730d83ffa","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        return None"},{"line_number":125,"context_line":"    if status \u003d\u003d LCJobStatus.RUNNING:"},{"line_number":126,"context_line":"        LOG.debug(\u0027Found scheduled LC job %(jid)s for node %(node)s, \u0027"},{"line_number":127,"context_line":"                  \u0027firmware staging succeeded.\u0027,"},{"line_number":128,"context_line":"                  {\u0027jid\u0027: jid, \u0027node\u0027: node.uuid})"},{"line_number":129,"context_line":"        return True"},{"line_number":130,"context_line":"    if status \u003d\u003d LCJobStatus.ERROR:"}],"source_content_type":"text/x-python","patch_set":7,"id":"98f6377b_7c43fe09","line":127,"updated":"2026-10-15 11:47:54.000000000","message":"nit: do you want to log reason? otherwise it\u0027s ignored","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return None"},{"line_number":125,"context_line":"    if status \u003d\u003d LCJobStatus.RUNNING:"},{"line_number":126,"context_line":"        LOG.debug(\u0027Found scheduled LC job %(jid)s for node %(node)s, \u0027"},{"line_number":127,"context_line":"                  \u0027firmware staging succeeded.\u0027,"},{"line_number":128,"context_line":"                  {\u0027jid\u0027: jid, \u0027node\u0027: node.uuid})"},{"line_number":129,"context_line":"        return True"},{"line_number":130,"context_line":"    if status \u003d\u003d LCJobStatus.ERROR:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5b42c6b6_4be03d6e","line":127,"in_reply_to":"98f6377b_7c43fe09","updated":"2026-10-19 10:24:32.000000000","message":"Well spotted. Dropped the reason instead: check_lc_jobs already logs a warning when the job collection is unavailable.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2f5a5f2867f5f0412cc45f7f0c43c8c730d83ffa","unresolved":true,"context_lines":[{"line_number":203,"context_line":"        LOG.warning(\u0027Cannot check LC jobs %(jids)s for node %(node)s: OEM \u0027"},{"line_number":204,"context_line":"                    \u0027job collection unavailable.\u0027,"},{"line_number":205,"context_line":"                    {\u0027jids\u0027: jids, \u0027node\u0027: node.uuid})"},{"line_number":206,"context_line":"        return LCJobStatus.UNAVAILABLE, reason"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    return _classify_dell_jobs(jids, job_collection.get_jobs(job_ids\u003djids))"}],"source_content_type":"text/x-python","patch_set":7,"id":"b6082d41_40dd0036","line":206,"updated":"2026-10-15 11:47:54.000000000","message":"nit: the caller ignores reason for UNAVAILABLE","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        LOG.warning(\u0027Cannot check LC jobs %(jids)s for node %(node)s: OEM \u0027"},{"line_number":204,"context_line":"                    \u0027job collection unavailable.\u0027,"},{"line_number":205,"context_line":"                    {\u0027jids\u0027: jids, \u0027node\u0027: node.uuid})"},{"line_number":206,"context_line":"        return LCJobStatus.UNAVAILABLE, reason"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    return _classify_dell_jobs(jids, job_collection.get_jobs(job_ids\u003djids))"}],"source_content_type":"text/x-python","patch_set":7,"id":"32e9fed4_ac5307c1","line":206,"in_reply_to":"b6082d41_40dd0036","updated":"2026-10-19 10:24:32.000000000","message":"Good catch, neither caller used it. UNAVAILABLE now returns None as its detail and the docstring says so.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"}],"releasenotes/notes/dell-lc-job-status-check-7c2e9a41d5b83f60.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Improves Lifecycle Controller job checking on Dell iDRAC during"},{"line_number":5,"context_line":"    Redfish firmware updates. When the Redfish task of an update is"},{"line_number":6,"context_line":"    purged before Ironic can poll it, the corresponding job is now read"},{"line_number":7,"context_line":"    individually through sushy\u0027s ``DellJobCollection.get_jobs()``, so a"},{"line_number":8,"context_line":"    job that ended in error is reported as a failed update rather than"},{"line_number":9,"context_line":"    treated as complete. This needs a sushy release providing"},{"line_number":10,"context_line":"    ``get_jobs()``; with older releases Ironic falls back to the previous"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d79c8f99_8878d501","line":7,"updated":"2026-09-28 10:40:22.000000000","message":"Let\u0027s not mention code details in operator facing notes","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Improves Lifecycle Controller job checking on Dell iDRAC during"},{"line_number":5,"context_line":"    Redfish firmware updates. When the Redfish task of an update is"},{"line_number":6,"context_line":"    purged before Ironic can poll it, the corresponding job is now read"},{"line_number":7,"context_line":"    individually through sushy\u0027s ``DellJobCollection.get_jobs()``, so a"},{"line_number":8,"context_line":"    job that ended in error is reported as a failed update rather than"},{"line_number":9,"context_line":"    treated as complete. This needs a sushy release providing"},{"line_number":10,"context_line":"    ``get_jobs()``; with older releases Ironic falls back to the previous"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cefca068_6a34d939","line":7,"in_reply_to":"d79c8f99_8878d501","updated":"2026-10-02 00:20:05.000000000","message":"Apologies, Claude got carried away and I didn\u0027t catch it. Fixed.","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"771ed0565a6f870b08b95af52715160f72ff7a40","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    individually through sushy\u0027s ``DellJobCollection.get_jobs()``, so a"},{"line_number":8,"context_line":"    job that ended in error is reported as a failed update rather than"},{"line_number":9,"context_line":"    treated as complete. This needs a sushy release providing"},{"line_number":10,"context_line":"    ``get_jobs()``; with older releases Ironic falls back to the previous"},{"line_number":11,"context_line":"    unfinished-jobs check and logs a warning."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e5612351_0c93eea4","line":10,"updated":"2026-09-28 10:40:22.000000000","message":"Do we know the release version already?","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6a260f80d315299266c0b9823bdefd5a08ae6d7b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    individually through sushy\u0027s ``DellJobCollection.get_jobs()``, so a"},{"line_number":8,"context_line":"    job that ended in error is reported as a failed update rather than"},{"line_number":9,"context_line":"    treated as complete. This needs a sushy release providing"},{"line_number":10,"context_line":"    ``get_jobs()``; with older releases Ironic falls back to the previous"},{"line_number":11,"context_line":"    unfinished-jobs check and logs a warning."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"909d6374_e1c5df30","line":10,"in_reply_to":"e5612351_0c93eea4","updated":"2026-10-02 00:20:05.000000000","message":"Probably 5.14.0: https://review.opendev.org/c/openstack/releases/+/1006695 but it\u0027s still WIP","commit_id":"da1301f7b7ce4f86a642e5cc876aef31b30fbfb1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"78d8cee73d162b69ec9e575f19ef39aa56114b2f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a7cc402d_7f2e7dcb","line":12,"updated":"2026-10-15 01:26:56.000000000","message":"So, it\u0027s a bit weird having two release notes...\nI would recommend merging them or if you think it\u0027s possible you can split the code in separate patches, so we have one with \"fixes\" and the other with \"upgrades\"","commit_id":"a82c8e0bea7c9b4e08174ce156f622d91c679a69"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d6b7cc58b98315e1db7454e146ff98b30413e60d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a33d78b_74e866f1","line":12,"in_reply_to":"a7cc402d_7f2e7dcb","updated":"2026-10-15 05:28:26.000000000","message":"Good point, Claude-ism. Merged the notes.","commit_id":"a82c8e0bea7c9b4e08174ce156f622d91c679a69"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2da4e1afc5f12fd6da088adbd292d3dea0727212","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    disappears before Ironic can poll it, a job that ended in error is"},{"line_number":7,"context_line":"    reported as a failed update, and a temporary failure to read the job"},{"line_number":8,"context_line":"    queue is retried instead of triggering the reboot. If the job has"},{"line_number":9,"context_line":"    disappeared before its outcome could be observed, Ironic fails closed"},{"line_number":10,"context_line":"    because it cannot establish whether firmware remains to be applied;"},{"line_number":11,"context_line":"    inspect the BMC before retrying."},{"line_number":12,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8284378e_3010a8e8","line":9,"range":{"start_line":9,"start_character":54,"end_line":9,"end_character":73},"updated":"2026-10-15 12:55:07.000000000","message":"nit: \"treats the update as failed\"","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2a68a833a1fd37835c63c2b62ac8c0ebdb912aa9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    disappears before Ironic can poll it, a job that ended in error is"},{"line_number":7,"context_line":"    reported as a failed update, and a temporary failure to read the job"},{"line_number":8,"context_line":"    queue is retried instead of triggering the reboot. If the job has"},{"line_number":9,"context_line":"    disappeared before its outcome could be observed, Ironic fails closed"},{"line_number":10,"context_line":"    because it cannot establish whether firmware remains to be applied;"},{"line_number":11,"context_line":"    inspect the BMC before retrying."},{"line_number":12,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cebdacf3_ae09d7cd","line":9,"range":{"start_line":9,"start_character":54,"end_line":9,"end_character":73},"in_reply_to":"8284378e_3010a8e8","updated":"2026-10-19 10:24:32.000000000","message":"Good point Riccardo, applied your suggestion.","commit_id":"89d5f8897bafebfe891b656b084215b231ac8500"}]}
