)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"354bd302072f4761a85a8b1f165c54fe697ce367","unresolved":false,"context_lines":[{"line_number":31,"context_line":"callers skip the check. This mirrors the pattern the Redfish BIOS"},{"line_number":32,"context_line":"interface already uses."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The helpers live in redfish/utils.py rather than the firmware-specific"},{"line_number":35,"context_line":"module so that other Redfish interfaces, the BIOS one in particular,"},{"line_number":36,"context_line":"can share them."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Partial-Bug: #2166690"},{"line_number":39,"context_line":"Change-Id: I0ecd33147c664d22448939d7d1099b2c85669ea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9d86d50b_9d53aac6","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":15},"updated":"2026-09-22 00:29:48.000000000","message":"I like this!","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d8bbb1c7e951804291e4bfa2d517f1f22bad9488","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d23aae9_f8f57735","updated":"2026-09-17 04:47:53.000000000","message":"recommend adding a release note","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e27c7e72033196166f8ccbf528ae432e0103e178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09518139_cf5e211f","in_reply_to":"9d23aae9_f8f57735","updated":"2026-09-17 06:33:12.000000000","message":"Done","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a87e3444ce514657b19ad33b488d32dbfcb8175d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a88b2c64_eaf48411","updated":"2026-09-22 04:55:37.000000000","message":"Thank you for your review, Iury. Pushed revised version.","commit_id":"880ca7b2e11a156e63a210627bd6902f17e38955"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"354bd302072f4761a85a8b1f165c54fe697ce367","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import hashlib"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"from urllib import parse as urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"0402246a_a73948d5","line":20,"updated":"2026-09-22 00:29:48.000000000","message":"the idea of using time makes me a bit worried, but it\u0027s what it\u0027 \u003d)","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a87e3444ce514657b19ad33b488d32dbfcb8175d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import hashlib"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"from urllib import parse as urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"172326db_2b2b06c5","line":20,"in_reply_to":"0402246a_a73948d5","updated":"2026-09-22 04:55:37.000000000","message":"I believe this is not uncommon in existing codebase, first example I could find: https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/redfish/power.py#L88\nFor shorter-duration waits this may be reasonable, let me know if you see a need for changing this approach?","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"354bd302072f4761a85a8b1f165c54fe697ce367","unresolved":true,"context_lines":[{"line_number":710,"context_line":"# Whether and when a BMC reports OS_RUNNING is platform-specific and"},{"line_number":711,"context_line":"# not guaranteed by the Redfish schema, so callers bound the wait for"},{"line_number":712,"context_line":"# it once BOOT_PROGRESS_POST_COMPLETE is seen."},{"line_number":713,"context_line":"BOOT_PROGRESS_SERVICE_TARGETS \u003d frozenset({"},{"line_number":714,"context_line":"    sushy.BootProgressStates.OS_RUNNING,"},{"line_number":715,"context_line":"})"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d9ad5034_0e819a68","line":713,"updated":"2026-09-22 00:29:48.000000000","message":"If I recall constants we would normally put at the begin of the file, after the imports","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a87e3444ce514657b19ad33b488d32dbfcb8175d","unresolved":false,"context_lines":[{"line_number":710,"context_line":"# Whether and when a BMC reports OS_RUNNING is platform-specific and"},{"line_number":711,"context_line":"# not guaranteed by the Redfish schema, so callers bound the wait for"},{"line_number":712,"context_line":"# it once BOOT_PROGRESS_POST_COMPLETE is seen."},{"line_number":713,"context_line":"BOOT_PROGRESS_SERVICE_TARGETS \u003d frozenset({"},{"line_number":714,"context_line":"    sushy.BootProgressStates.OS_RUNNING,"},{"line_number":715,"context_line":"})"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3d70aa39_25c952db","line":713,"in_reply_to":"d9ad5034_0e819a68","updated":"2026-09-22 04:55:37.000000000","message":"Good point, moved up.","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"}]}