)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"354bd302072f4761a85a8b1f165c54fe697ce367","unresolved":false,"context_lines":[{"line_number":31,"context_line":"callers skip the check. This mirrors the pattern the Redfish BIOS"},{"line_number":32,"context_line":"interface already uses."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The helpers live in redfish/utils.py rather than the firmware-specific"},{"line_number":35,"context_line":"module so that other Redfish interfaces, the BIOS one in particular,"},{"line_number":36,"context_line":"can share them."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Partial-Bug: #2166690"},{"line_number":39,"context_line":"Change-Id: I0ecd33147c664d22448939d7d1099b2c85669ea9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9d86d50b_9d53aac6","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":15},"updated":"2026-09-22 00:29:48.000000000","message":"I like this!","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d8bbb1c7e951804291e4bfa2d517f1f22bad9488","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d23aae9_f8f57735","updated":"2026-09-17 04:47:53.000000000","message":"recommend adding a release note","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e27c7e72033196166f8ccbf528ae432e0103e178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09518139_cf5e211f","in_reply_to":"9d23aae9_f8f57735","updated":"2026-09-17 06:33:12.000000000","message":"Done","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a87e3444ce514657b19ad33b488d32dbfcb8175d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a88b2c64_eaf48411","updated":"2026-09-22 04:55:37.000000000","message":"Thank you for your review, Iury. Pushed revised version.","commit_id":"880ca7b2e11a156e63a210627bd6902f17e38955"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d4e48c717016ec786e1b7e16a138ad69809a63b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"812d7c52_53fcdf7c","updated":"2026-10-14 23:15:22.000000000","message":"recheck","commit_id":"79c1263f3f2c40f9f906e007f3f05d14f99293a5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"86608b940647ff2b005616b5f9a8ebfed50dff16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1ada213a_aa41b20b","updated":"2026-10-21 02:55:20.000000000","message":"Awesome, thanks!","commit_id":"805157f4eae0145dd48d0b20cb8c56ab79313fed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed3edd1f5a7da320ab61146bd1fe0ca7e60323d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c2890d78_34287e66","updated":"2026-10-20 11:54:03.000000000","message":"It\u0027s somewhat tricky to review helpers without seeing where they\u0027re used, but the code looks good.","commit_id":"805157f4eae0145dd48d0b20cb8c56ab79313fed"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"5373849c5f21c231e8abd97748c53550622f44dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6bd221c3_587c2e4d","updated":"2026-10-19 11:30:20.000000000","message":"Thank you for your review Dmitry, pushed revisited patch.","commit_id":"805157f4eae0145dd48d0b20cb8c56ab79313fed"}],"ironic/drivers/modules/redfish/utils.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"354bd302072f4761a85a8b1f165c54fe697ce367","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import hashlib"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"from urllib import parse as urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"0402246a_a73948d5","line":20,"updated":"2026-09-22 00:29:48.000000000","message":"the idea of using time makes me a bit worried, but it\u0027s what it\u0027 \u003d)","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a87e3444ce514657b19ad33b488d32dbfcb8175d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import hashlib"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"from urllib import parse as urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"172326db_2b2b06c5","line":20,"in_reply_to":"0402246a_a73948d5","updated":"2026-09-22 04:55:37.000000000","message":"I believe this is not uncommon in existing codebase, first example I could find: https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/redfish/power.py#L88\nFor shorter-duration waits this may be reasonable, let me know if you see a need for changing this approach?","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a9007e70aaad11e3b1230b7257900eb94b73e69c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import hashlib"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"from urllib import parse as urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c6e0d80_ba7795b4","line":20,"in_reply_to":"172326db_2b2b06c5","updated":"2026-10-15 05:19:29.000000000","message":"Changed the code to avoid the blocking loop","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"354bd302072f4761a85a8b1f165c54fe697ce367","unresolved":true,"context_lines":[{"line_number":710,"context_line":"# Whether and when a BMC reports OS_RUNNING is platform-specific and"},{"line_number":711,"context_line":"# not guaranteed by the Redfish schema, so callers bound the wait for"},{"line_number":712,"context_line":"# it once BOOT_PROGRESS_POST_COMPLETE is seen."},{"line_number":713,"context_line":"BOOT_PROGRESS_SERVICE_TARGETS \u003d frozenset({"},{"line_number":714,"context_line":"    sushy.BootProgressStates.OS_RUNNING,"},{"line_number":715,"context_line":"})"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d9ad5034_0e819a68","line":713,"updated":"2026-09-22 00:29:48.000000000","message":"If I recall constants we would normally put at the begin of the file, after the imports","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a87e3444ce514657b19ad33b488d32dbfcb8175d","unresolved":false,"context_lines":[{"line_number":710,"context_line":"# Whether and when a BMC reports OS_RUNNING is platform-specific and"},{"line_number":711,"context_line":"# not guaranteed by the Redfish schema, so callers bound the wait for"},{"line_number":712,"context_line":"# it once BOOT_PROGRESS_POST_COMPLETE is seen."},{"line_number":713,"context_line":"BOOT_PROGRESS_SERVICE_TARGETS \u003d frozenset({"},{"line_number":714,"context_line":"    sushy.BootProgressStates.OS_RUNNING,"},{"line_number":715,"context_line":"})"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3d70aa39_25c952db","line":713,"in_reply_to":"d9ad5034_0e819a68","updated":"2026-09-22 04:55:37.000000000","message":"Good point, moved up.","commit_id":"4ebdfd698a48898bd422ba12be1e3dedc692ca6d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aac067d3c934f321e92625d8db6ecf1bf60cec3e","unresolved":true,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"BOOT_PROGRESS_PASSED \u003d \u0027passed\u0027"},{"line_number":116,"context_line":"BOOT_PROGRESS_WAITING \u003d \u0027waiting\u0027"},{"line_number":117,"context_line":"BOOT_PROGRESS_UNAVAILABLE \u003d \u0027unavailable\u0027"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# Servicing requires the OS to be fully running: the firmware inventory"},{"line_number":120,"context_line":"# is only read once the node reaches this state, so anything earlier can"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fd2a936_5fe5371d","line":117,"updated":"2026-10-15 11:53:48.000000000","message":"Enum here as well?","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"5373849c5f21c231e8abd97748c53550622f44dd","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"BOOT_PROGRESS_PASSED \u003d \u0027passed\u0027"},{"line_number":116,"context_line":"BOOT_PROGRESS_WAITING \u003d \u0027waiting\u0027"},{"line_number":117,"context_line":"BOOT_PROGRESS_UNAVAILABLE \u003d \u0027unavailable\u0027"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# Servicing requires the OS to be fully running: the firmware inventory"},{"line_number":120,"context_line":"# is only read once the node reaches this state, so anything earlier can"}],"source_content_type":"text/x-python","patch_set":8,"id":"a0ddd8e8_bfdb389f","line":117,"in_reply_to":"3fd2a936_5fe5371d","updated":"2026-10-19 11:30:20.000000000","message":"Good point. Done.","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aac067d3c934f321e92625d8db6ecf1bf60cec3e","unresolved":true,"context_lines":[{"line_number":747,"context_line":"        return BOOT_PROGRESS_SERVICE_TARGETS"},{"line_number":748,"context_line":"    if node.clean_step or node.deploy_step:"},{"line_number":749,"context_line":"        return BOOT_PROGRESS_CLEAN_TARGETS"},{"line_number":750,"context_line":"    return BOOT_PROGRESS_SERVICE_TARGETS"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"def get_boot_observation(system):"}],"source_content_type":"text/x-python","patch_set":8,"id":"0ee03cd6_108ba9e8","line":750,"updated":"2026-10-15 11:53:48.000000000","message":"This should be unreachable, raise?","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"5373849c5f21c231e8abd97748c53550622f44dd","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        return BOOT_PROGRESS_SERVICE_TARGETS"},{"line_number":748,"context_line":"    if node.clean_step or node.deploy_step:"},{"line_number":749,"context_line":"        return BOOT_PROGRESS_CLEAN_TARGETS"},{"line_number":750,"context_line":"    return BOOT_PROGRESS_SERVICE_TARGETS"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"def get_boot_observation(system):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3bf016fb_4ff0d8b4","line":750,"in_reply_to":"0ee03cd6_108ba9e8","updated":"2026-10-19 11:30:20.000000000","message":"Good point. Done.","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aac067d3c934f321e92625d8db6ecf1bf60cec3e","unresolved":true,"context_lines":[{"line_number":762,"context_line":"    \"\"\""},{"line_number":763,"context_line":"    boot_progress \u003d system.boot_progress"},{"line_number":764,"context_line":"    state \u003d boot_progress.last_state if boot_progress is not None else None"},{"line_number":765,"context_line":"    # sushy does not model LastResetTime, so read it from the raw resource."},{"line_number":766,"context_line":"    reset_time \u003d (system.json or {}).get(\u0027LastResetTime\u0027)"},{"line_number":767,"context_line":"    return {"},{"line_number":768,"context_line":"        \u0027state\u0027: state.value if state is not None else None,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bdd3e9b4_a294fc3c","line":765,"updated":"2026-10-15 11:53:48.000000000","message":"Let\u0027s address it in sushy in the meantime","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f533b0217fe98682c732b054453a6e86e2b3215f","unresolved":true,"context_lines":[{"line_number":762,"context_line":"    \"\"\""},{"line_number":763,"context_line":"    boot_progress \u003d system.boot_progress"},{"line_number":764,"context_line":"    state \u003d boot_progress.last_state if boot_progress is not None else None"},{"line_number":765,"context_line":"    # sushy does not model LastResetTime, so read it from the raw resource."},{"line_number":766,"context_line":"    reset_time \u003d (system.json or {}).get(\u0027LastResetTime\u0027)"},{"line_number":767,"context_line":"    return {"},{"line_number":768,"context_line":"        \u0027state\u0027: state.value if state is not None else None,"}],"source_content_type":"text/x-python","patch_set":8,"id":"2c0f8244_6fa5c260","line":765,"in_reply_to":"0283de56_9b309e02","updated":"2026-10-20 22:07:42.000000000","message":"Now we need a new release of sushy or we will go with a follow-up? 😅","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2e0a60407677930b751d93bd37e3ebc476b1cfe1","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    \"\"\""},{"line_number":763,"context_line":"    boot_progress \u003d system.boot_progress"},{"line_number":764,"context_line":"    state \u003d boot_progress.last_state if boot_progress is not None else None"},{"line_number":765,"context_line":"    # sushy does not model LastResetTime, so read it from the raw resource."},{"line_number":766,"context_line":"    reset_time \u003d (system.json or {}).get(\u0027LastResetTime\u0027)"},{"line_number":767,"context_line":"    return {"},{"line_number":768,"context_line":"        \u0027state\u0027: state.value if state is not None else None,"}],"source_content_type":"text/x-python","patch_set":8,"id":"b63d5ca2_a4e95e84","line":765,"in_reply_to":"2c0f8244_6fa5c260","updated":"2026-10-21 00:39:22.000000000","message":"I\u0027d do it in a follow up","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"5373849c5f21c231e8abd97748c53550622f44dd","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    \"\"\""},{"line_number":763,"context_line":"    boot_progress \u003d system.boot_progress"},{"line_number":764,"context_line":"    state \u003d boot_progress.last_state if boot_progress is not None else None"},{"line_number":765,"context_line":"    # sushy does not model LastResetTime, so read it from the raw resource."},{"line_number":766,"context_line":"    reset_time \u003d (system.json or {}).get(\u0027LastResetTime\u0027)"},{"line_number":767,"context_line":"    return {"},{"line_number":768,"context_line":"        \u0027state\u0027: state.value if state is not None else None,"}],"source_content_type":"text/x-python","patch_set":8,"id":"0283de56_9b309e02","line":765,"in_reply_to":"bdd3e9b4_a294fc3c","updated":"2026-10-19 11:30:20.000000000","message":"Good idea, I pushed https://review.opendev.org/c/openstack/sushy/+/1011250 and added a TODO","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aac067d3c934f321e92625d8db6ecf1bf60cec3e","unresolved":true,"context_lines":[{"line_number":832,"context_line":"    \"\"\""},{"line_number":833,"context_line":"    boot_progress \u003d system.boot_progress"},{"line_number":834,"context_line":"    last_state \u003d (boot_progress.last_state"},{"line_number":835,"context_line":"                  if boot_progress is not None else None)"},{"line_number":836,"context_line":"    if last_state is None:"},{"line_number":837,"context_line":"        return BOOT_PROGRESS_UNAVAILABLE, None"},{"line_number":838,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"a2bc6606_fb2ef04c","line":835,"updated":"2026-10-15 11:53:48.000000000","message":"nit: reuse get_boot_observation","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"5373849c5f21c231e8abd97748c53550622f44dd","unresolved":false,"context_lines":[{"line_number":832,"context_line":"    \"\"\""},{"line_number":833,"context_line":"    boot_progress \u003d system.boot_progress"},{"line_number":834,"context_line":"    last_state \u003d (boot_progress.last_state"},{"line_number":835,"context_line":"                  if boot_progress is not None else None)"},{"line_number":836,"context_line":"    if last_state is None:"},{"line_number":837,"context_line":"        return BOOT_PROGRESS_UNAVAILABLE, None"},{"line_number":838,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"e91cd059_70749b28","line":835,"in_reply_to":"a2bc6606_fb2ef04c","updated":"2026-10-19 11:30:20.000000000","message":"Done, added a helper for this.","commit_id":"1b3a58cf3e57003c630f2edc706d2ac8334e90d8"}]}
