)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c526fa465608914c390ebfbe418c65e3ef4432bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"03156be2_7b134172","updated":"2026-10-26 16:09:32.000000000","message":"I\u0027m sorry, but I\u0027ll probably ask you to decompose the patch further into logical part. For example, you can start with only the BootProgress part without fallbacks. Then add a Dell alternative. Then fallbacks. Or something like this.\n\nUnfortunately, I cannot grok the PR otherwise.","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e5d10ed1828a0e612ca1c987af05b16e59918a12","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cfc34bd4_be890350","in_reply_to":"03156be2_7b134172","updated":"2026-10-27 04:32:20.000000000","message":"Fair, it\u0027s a big patch, will try splitting it along the lines you suggested.","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fc1d4702f9934df6b187d795c34d6d9d3fbe8f5d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"038320d9_eff17117","in_reply_to":"cfc34bd4_be890350","updated":"2026-10-27 06:46:35.000000000","message":"I attempted splitting the patch along the lines you suggested. It\u0027s still huge but I hope it\u0027s easier to follow. Let me know if this works or whether I need to divide it up further.","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e5d10ed1828a0e612ca1c987af05b16e59918a12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d859c702_8802fe7d","updated":"2026-10-27 04:32:20.000000000","message":"Thank you for your reviews Dmitry and Iury. Addressed the lock comment, will attempt the split next.","commit_id":"d9d5042e7bf0dac6b39c142c1069d8c35d0fbf34"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"fc1d4702f9934df6b187d795c34d6d9d3fbe8f5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3919790e_038d514a","updated":"2026-10-27 06:46:35.000000000","message":"I prepared a new version split into three related changes - let me know if this helps.","commit_id":"ae083bb9d39808029b2c93ff9ea8cd40bb234c35"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b241ecada7f32e965d1051a1f4af32f018320742","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a2fbaccb_90ac0f5d","updated":"2026-11-03 07:05:31.000000000","message":"lab re-test in progress","commit_id":"54fe43fd40d1fb71651acc9c382b0e508b51e8f8"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e092597736ad65adb0f84a0b2374645d4a95fafa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2610fcd1_9c91f9cb","updated":"2026-11-04 11:09:49.000000000","message":"recheck","commit_id":"554ac2b2b77c90bb2b15112a2830e999a58439a0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7e932dab_e52e9fb1","updated":"2026-11-09 15:22:44.000000000","message":"A bunch of nits inline. The one about the format of the timestamp is something you need to decide in this patch, everything else can be addressed separately.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e9effc4e93399be0a3028eea8a17bc2608ef31bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f61ef93f_95fb0ec4","updated":"2026-11-11 07:14:55.000000000","message":"added direct links in follow-up patch","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"da19b9760d9e8a839ed226bf6f09c89b0ab564ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"a0a15a0d_fcfde482","in_reply_to":"7e932dab_e52e9fb1","updated":"2026-11-10 06:02:56.000000000","message":"Thank you for your review, Dmitry. I will address all the comments in https://review.opendev.org/c/openstack/ironic/+/1014850/1. Time format answer inline.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"}],"ironic/conf/redfish.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"847fbc0610ebfcd865a6790ac7adeeb3d175eda2","unresolved":true,"context_lines":[{"line_number":166,"context_line":"                      \u0027start applying firmware, while others can begin \u0027"},{"line_number":167,"context_line":"                      \u0027immediately. This timeout helps determine which \u0027"},{"line_number":168,"context_line":"                      \u0027behavior the hardware exhibits.\u0027)),"},{"line_number":169,"context_line":"    cfg.IntOpt(\u0027firmware_update_post_reboot_verify_timeout\u0027,"},{"line_number":170,"context_line":"               min\u003d0,"},{"line_number":171,"context_line":"               default\u003d1800,"},{"line_number":172,"context_line":"               help\u003d_(\u0027Maximum time (in seconds) to wait, after a reboot \u0027"},{"line_number":173,"context_line":"                      \u0027to apply staged firmware, for the post-reboot \u0027"},{"line_number":174,"context_line":"                      \u0027verify phase to complete: a Dell Lifecycle \u0027"},{"line_number":175,"context_line":"                      \u0027Controller job finishing (Dell only) and the \u0027"},{"line_number":176,"context_line":"                      \u0027node reaching a target BootProgress state. \u0027"},{"line_number":177,"context_line":"                      \u0027During servicing the node must reach OSRunning, \u0027"},{"line_number":178,"context_line":"                      \u0027so that the firmware versions cached before the \u0027"},{"line_number":179,"context_line":"                      \u0027step resumes are current; during cleaning and \u0027"},{"line_number":180,"context_line":"                      \u0027deployment an earlier state is accepted, since \u0027"},{"line_number":181,"context_line":"                      \u0027no OS need boot. Each check is skipped when \u0027"},{"line_number":182,"context_line":"                      \u0027unavailable. The node may be flashing firmware \u0027"},{"line_number":183,"context_line":"                      \u0027during POST for part of this period, so it must \u0027"},{"line_number":184,"context_line":"                      \u0027accommodate a full POST cycle. Set to 0 to wait \u0027"},{"line_number":185,"context_line":"                      \u0027indefinitely, bounded only by \u0027"},{"line_number":186,"context_line":"                      \u0027``firmware_update_overall_timeout``. Default is \u0027"},{"line_number":187,"context_line":"                      \u00271800 seconds (30 minutes).\u0027)),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027firmware_update_os_running_timeout\u0027,"},{"line_number":189,"context_line":"               min\u003d0,"},{"line_number":190,"context_line":"               default\u003d300,"},{"line_number":191,"context_line":"               help\u003d_(\u0027Maximum time (in seconds) to keep waiting for \u0027"},{"line_number":192,"context_line":"                      \u0027BootProgress to report OSRunning after the node \u0027"},{"line_number":193,"context_line":"                      \u0027has finished POST, reporting \u0027"},{"line_number":194,"context_line":"                      \u0027SystemHardwareInitializationComplete or \u0027"},{"line_number":195,"context_line":"                      \u0027OSBootStarted, during a servicing firmware \u0027"},{"line_number":196,"context_line":"                      \u0027update. The firmware versions cached \u0027"},{"line_number":197,"context_line":"                      \u0027before the step resumes are most accurate once \u0027"},{"line_number":198,"context_line":"                      \u0027the OS is fully running, but whether and when a \u0027"},{"line_number":199,"context_line":"                      \u0027BMC reports OSRunning is platform-specific and \u0027"},{"line_number":200,"context_line":"                      \u0027not guaranteed by the Redfish schema: some BMCs \u0027"},{"line_number":201,"context_line":"                      \u0027never advance past the end of POST. \u0027"},{"line_number":202,"context_line":"                      \u0027When this time elapses, Ironic logs a warning \u0027"},{"line_number":203,"context_line":"                      \u0027and proceeds. Set to 0 to not wait beyond the \u0027"},{"line_number":204,"context_line":"                      \u0027end of POST at all. Only applies to servicing: \u0027"},{"line_number":205,"context_line":"                      \u0027cleaning and deployment accept earlier boot \u0027"},{"line_number":206,"context_line":"                      \u0027states. Default is 300 seconds (5 minutes).\u0027)),"},{"line_number":207,"context_line":"    cfg.IntOpt(\u0027firmware_update_boot_check_delay\u0027,"},{"line_number":208,"context_line":"               min\u003d0,"},{"line_number":209,"context_line":"               default\u003d600,"},{"line_number":210,"context_line":"               help\u003d_(\u0027Minimum time (in seconds) after a reboot issued \u0027"},{"line_number":211,"context_line":"                      \u0027to apply firmware before Ironic trusts a target \u0027"},{"line_number":212,"context_line":"                      \u0027BootProgress state it has not seen the node \u0027"},{"line_number":213,"context_line":"                      \u0027reach. A reboot request does not reset \u0027"},{"line_number":214,"context_line":"                      \u0027BootProgress: until the host actually resets, \u0027"},{"line_number":215,"context_line":"                      \u0027the BMC keeps reporting the state the previous \u0027"},{"line_number":216,"context_line":"                      \u0027boot ended in, so an immediate reading can be a \u0027"},{"line_number":217,"context_line":"                      \u0027stale one. It is also how long a node whose BMC \u0027"},{"line_number":218,"context_line":"                      \u0027does not report BootProgress at all is held \u0027"},{"line_number":219,"context_line":"                      \u0027before it is allowed to proceed. On hardware \u0027"},{"line_number":220,"context_line":"                      \u0027that gives no boot signal this delay stands in \u0027"},{"line_number":221,"context_line":"                      \u0027for the whole POST-and-flash window, during \u0027"},{"line_number":222,"context_line":"                      \u0027which the node must not be powered off, so it \u0027"},{"line_number":223,"context_line":"                      \u0027should comfortably exceed the slowest POST \u0027"},{"line_number":224,"context_line":"                      \u0027expected in the deployment. Where the reboot is \u0027"},{"line_number":225,"context_line":"                      \u0027observed instead -- BootProgress changes after \u0027"},{"line_number":226,"context_line":"                      \u0027the reset, or a non-target state is polled -- \u0027"},{"line_number":227,"context_line":"                      \u0027the delay does not apply and the node proceeds \u0027"},{"line_number":228,"context_line":"                      \u0027as soon as its boot state says it may. Default \u0027"},{"line_number":229,"context_line":"                      \u0027is 600 seconds (10 minutes).\u0027)),"},{"line_number":230,"context_line":"    cfg.IntOpt(\u0027firmware_update_reboot_watch_timeout\u0027,"},{"line_number":231,"context_line":"               min\u003d0,"},{"line_number":232,"context_line":"               default\u003d60,"},{"line_number":233,"context_line":"               help\u003d_(\u0027How long (in seconds) to watch BootProgress, \u0027"},{"line_number":234,"context_line":"                      \u0027after issuing a reboot to apply firmware, for \u0027"},{"line_number":235,"context_line":"                      \u0027LastState to leave the value it held before the \u0027"},{"line_number":236,"context_line":"                      \u0027reboot, which proves the node reset. A BMC that \u0027"},{"line_number":237,"context_line":"                      \u0027resets slowly may need more. If the change is \u0027"},{"line_number":238,"context_line":"                      \u0027not seen within this time, Ironic falls back on \u0027"},{"line_number":239,"context_line":"                      \u0027``firmware_update_boot_check_delay``; a change \u0027"},{"line_number":240,"context_line":"                      \u0027seen later by the regular polling still counts. \u0027"},{"line_number":241,"context_line":"                      \u0027Set to 0 to disable the watch. Default is 60 \u0027"},{"line_number":242,"context_line":"                      \u0027seconds.\u0027)),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027firmware_update_overall_timeout\u0027,"},{"line_number":244,"context_line":"               min\u003d0,"},{"line_number":245,"context_line":"               default\u003d7200,"}],"source_content_type":"text/x-python","patch_set":2,"id":"71dd719b_ee03b719","line":242,"range":{"start_line":169,"start_character":5,"end_line":242,"end_character":35},"updated":"2026-09-17 06:59:11.000000000","message":"this may benefit from discussion with wider group.\n1) we are leaning towards too many knobs\n2) how does BootProgress timeout interact with LC-phase timeout","commit_id":"0b8db255a7fe63414071eb84c2e4ab5649906329"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"d95fe175b6bbe8e7f8e855e15ec054e8c90048df","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                      \u0027start applying firmware, while others can begin \u0027"},{"line_number":167,"context_line":"                      \u0027immediately. This timeout helps determine which \u0027"},{"line_number":168,"context_line":"                      \u0027behavior the hardware exhibits.\u0027)),"},{"line_number":169,"context_line":"    cfg.IntOpt(\u0027firmware_update_post_reboot_verify_timeout\u0027,"},{"line_number":170,"context_line":"               min\u003d0,"},{"line_number":171,"context_line":"               default\u003d1800,"},{"line_number":172,"context_line":"               help\u003d_(\u0027Maximum time (in seconds) to wait, after a reboot \u0027"},{"line_number":173,"context_line":"                      \u0027to apply staged firmware, for the post-reboot \u0027"},{"line_number":174,"context_line":"                      \u0027verify phase to complete: a Dell Lifecycle \u0027"},{"line_number":175,"context_line":"                      \u0027Controller job finishing (Dell only) and the \u0027"},{"line_number":176,"context_line":"                      \u0027node reaching a target BootProgress state. \u0027"},{"line_number":177,"context_line":"                      \u0027During servicing the node must reach OSRunning, \u0027"},{"line_number":178,"context_line":"                      \u0027so that the firmware versions cached before the \u0027"},{"line_number":179,"context_line":"                      \u0027step resumes are current; during cleaning and \u0027"},{"line_number":180,"context_line":"                      \u0027deployment an earlier state is accepted, since \u0027"},{"line_number":181,"context_line":"                      \u0027no OS need boot. Each check is skipped when \u0027"},{"line_number":182,"context_line":"                      \u0027unavailable. The node may be flashing firmware \u0027"},{"line_number":183,"context_line":"                      \u0027during POST for part of this period, so it must \u0027"},{"line_number":184,"context_line":"                      \u0027accommodate a full POST cycle. Set to 0 to wait \u0027"},{"line_number":185,"context_line":"                      \u0027indefinitely, bounded only by \u0027"},{"line_number":186,"context_line":"                      \u0027``firmware_update_overall_timeout``. Default is \u0027"},{"line_number":187,"context_line":"                      \u00271800 seconds (30 minutes).\u0027)),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027firmware_update_os_running_timeout\u0027,"},{"line_number":189,"context_line":"               min\u003d0,"},{"line_number":190,"context_line":"               default\u003d300,"},{"line_number":191,"context_line":"               help\u003d_(\u0027Maximum time (in seconds) to keep waiting for \u0027"},{"line_number":192,"context_line":"                      \u0027BootProgress to report OSRunning after the node \u0027"},{"line_number":193,"context_line":"                      \u0027has finished POST, reporting \u0027"},{"line_number":194,"context_line":"                      \u0027SystemHardwareInitializationComplete or \u0027"},{"line_number":195,"context_line":"                      \u0027OSBootStarted, during a servicing firmware \u0027"},{"line_number":196,"context_line":"                      \u0027update. The firmware versions cached \u0027"},{"line_number":197,"context_line":"                      \u0027before the step resumes are most accurate once \u0027"},{"line_number":198,"context_line":"                      \u0027the OS is fully running, but whether and when a \u0027"},{"line_number":199,"context_line":"                      \u0027BMC reports OSRunning is platform-specific and \u0027"},{"line_number":200,"context_line":"                      \u0027not guaranteed by the Redfish schema: some BMCs \u0027"},{"line_number":201,"context_line":"                      \u0027never advance past the end of POST. \u0027"},{"line_number":202,"context_line":"                      \u0027When this time elapses, Ironic logs a warning \u0027"},{"line_number":203,"context_line":"                      \u0027and proceeds. Set to 0 to not wait beyond the \u0027"},{"line_number":204,"context_line":"                      \u0027end of POST at all. Only applies to servicing: \u0027"},{"line_number":205,"context_line":"                      \u0027cleaning and deployment accept earlier boot \u0027"},{"line_number":206,"context_line":"                      \u0027states. Default is 300 seconds (5 minutes).\u0027)),"},{"line_number":207,"context_line":"    cfg.IntOpt(\u0027firmware_update_boot_check_delay\u0027,"},{"line_number":208,"context_line":"               min\u003d0,"},{"line_number":209,"context_line":"               default\u003d600,"},{"line_number":210,"context_line":"               help\u003d_(\u0027Minimum time (in seconds) after a reboot issued \u0027"},{"line_number":211,"context_line":"                      \u0027to apply firmware before Ironic trusts a target \u0027"},{"line_number":212,"context_line":"                      \u0027BootProgress state it has not seen the node \u0027"},{"line_number":213,"context_line":"                      \u0027reach. A reboot request does not reset \u0027"},{"line_number":214,"context_line":"                      \u0027BootProgress: until the host actually resets, \u0027"},{"line_number":215,"context_line":"                      \u0027the BMC keeps reporting the state the previous \u0027"},{"line_number":216,"context_line":"                      \u0027boot ended in, so an immediate reading can be a \u0027"},{"line_number":217,"context_line":"                      \u0027stale one. It is also how long a node whose BMC \u0027"},{"line_number":218,"context_line":"                      \u0027does not report BootProgress at all is held \u0027"},{"line_number":219,"context_line":"                      \u0027before it is allowed to proceed. On hardware \u0027"},{"line_number":220,"context_line":"                      \u0027that gives no boot signal this delay stands in \u0027"},{"line_number":221,"context_line":"                      \u0027for the whole POST-and-flash window, during \u0027"},{"line_number":222,"context_line":"                      \u0027which the node must not be powered off, so it \u0027"},{"line_number":223,"context_line":"                      \u0027should comfortably exceed the slowest POST \u0027"},{"line_number":224,"context_line":"                      \u0027expected in the deployment. Where the reboot is \u0027"},{"line_number":225,"context_line":"                      \u0027observed instead -- BootProgress changes after \u0027"},{"line_number":226,"context_line":"                      \u0027the reset, or a non-target state is polled -- \u0027"},{"line_number":227,"context_line":"                      \u0027the delay does not apply and the node proceeds \u0027"},{"line_number":228,"context_line":"                      \u0027as soon as its boot state says it may. Default \u0027"},{"line_number":229,"context_line":"                      \u0027is 600 seconds (10 minutes).\u0027)),"},{"line_number":230,"context_line":"    cfg.IntOpt(\u0027firmware_update_reboot_watch_timeout\u0027,"},{"line_number":231,"context_line":"               min\u003d0,"},{"line_number":232,"context_line":"               default\u003d60,"},{"line_number":233,"context_line":"               help\u003d_(\u0027How long (in seconds) to watch BootProgress, \u0027"},{"line_number":234,"context_line":"                      \u0027after issuing a reboot to apply firmware, for \u0027"},{"line_number":235,"context_line":"                      \u0027LastState to leave the value it held before the \u0027"},{"line_number":236,"context_line":"                      \u0027reboot, which proves the node reset. A BMC that \u0027"},{"line_number":237,"context_line":"                      \u0027resets slowly may need more. If the change is \u0027"},{"line_number":238,"context_line":"                      \u0027not seen within this time, Ironic falls back on \u0027"},{"line_number":239,"context_line":"                      \u0027``firmware_update_boot_check_delay``; a change \u0027"},{"line_number":240,"context_line":"                      \u0027seen later by the regular polling still counts. \u0027"},{"line_number":241,"context_line":"                      \u0027Set to 0 to disable the watch. Default is 60 \u0027"},{"line_number":242,"context_line":"                      \u0027seconds.\u0027)),"},{"line_number":243,"context_line":"    cfg.IntOpt(\u0027firmware_update_overall_timeout\u0027,"},{"line_number":244,"context_line":"               min\u003d0,"},{"line_number":245,"context_line":"               default\u003d7200,"}],"source_content_type":"text/x-python","patch_set":2,"id":"22b903a8_447dc6d7","line":242,"range":{"start_line":169,"start_character":5,"end_line":242,"end_character":35},"in_reply_to":"71dd719b_ee03b719","updated":"2026-09-17 10:37:01.000000000","message":"I think this is actually OK for now, there is no interference between BootProgress and LC timeouts.","commit_id":"0b8db255a7fe63414071eb84c2e4ab5649906329"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9a76fdca38949afde0abc49457ce20c57f8b8e35","unresolved":true,"context_lines":[{"line_number":1555,"context_line":"        :param task: a TaskManager instance"},{"line_number":1556,"context_line":"        :param settings: firmware update settings; the first entry is the"},{"line_number":1557,"context_line":"            update applied by this reboot."},{"line_number":1558,"context_line":"        \"\"\""},{"line_number":1559,"context_line":"        node \u003d task.node"},{"line_number":1560,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1561,"context_line":"        jids \u003d list(node.driver_internal_info.get(FIRMWARE_PENDING_JIDS, []))"}],"source_content_type":"text/x-python","patch_set":10,"id":"a48d36b0_3bca7e12","line":1558,"updated":"2026-10-20 11:56:42.000000000","message":"Start with upgrade_lock?","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e5d10ed1828a0e612ca1c987af05b16e59918a12","unresolved":false,"context_lines":[{"line_number":1555,"context_line":"        :param task: a TaskManager instance"},{"line_number":1556,"context_line":"        :param settings: firmware update settings; the first entry is the"},{"line_number":1557,"context_line":"            update applied by this reboot."},{"line_number":1558,"context_line":"        \"\"\""},{"line_number":1559,"context_line":"        node \u003d task.node"},{"line_number":1560,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1561,"context_line":"        jids \u003d list(node.driver_internal_info.get(FIRMWARE_PENDING_JIDS, []))"}],"source_content_type":"text/x-python","patch_set":10,"id":"b2af11cf_362feea9","line":1558,"in_reply_to":"3ee7cb4c_1f9cf889","updated":"2026-10-27 04:32:20.000000000","message":"Done","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e5d10ed1828a0e612ca1c987af05b16e59918a12","unresolved":false,"context_lines":[{"line_number":1555,"context_line":"        :param task: a TaskManager instance"},{"line_number":1556,"context_line":"        :param settings: firmware update settings; the first entry is the"},{"line_number":1557,"context_line":"            update applied by this reboot."},{"line_number":1558,"context_line":"        \"\"\""},{"line_number":1559,"context_line":"        node \u003d task.node"},{"line_number":1560,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1561,"context_line":"        jids \u003d list(node.driver_internal_info.get(FIRMWARE_PENDING_JIDS, []))"}],"source_content_type":"text/x-python","patch_set":10,"id":"6045a994_8aa349c6","line":1558,"in_reply_to":"3ee7cb4c_1f9cf889","updated":"2026-10-27 04:32:20.000000000","message":"Good point, added.","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ef66e39e86accd58af277533204fc749ac764aad","unresolved":true,"context_lines":[{"line_number":1555,"context_line":"        :param task: a TaskManager instance"},{"line_number":1556,"context_line":"        :param settings: firmware update settings; the first entry is the"},{"line_number":1557,"context_line":"            update applied by this reboot."},{"line_number":1558,"context_line":"        \"\"\""},{"line_number":1559,"context_line":"        node \u003d task.node"},{"line_number":1560,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1561,"context_line":"        jids \u003d list(node.driver_internal_info.get(FIRMWARE_PENDING_JIDS, []))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ee7cb4c_1f9cf889","line":1558,"in_reply_to":"a48d36b0_3bca7e12","updated":"2026-10-26 11:56:47.000000000","message":"yes please ++","commit_id":"0801c38b557455b678c579b4a5e5ff36924a2ad4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1543,"context_line":"        node \u003d task.node"},{"line_number":1544,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1545,"context_line":"        fw_upd[VERIFY] \u003d {"},{"line_number":1546,"context_line":"            \u0027reboot_time\u0027: str(timeutils.utcnow().isoformat()),"},{"line_number":1547,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1548,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1549,"context_line":"            \u0027waiting\u0027: None,"}],"source_content_type":"text/x-python","patch_set":17,"id":"ad7267e2_cebd4c5c","line":1546,"updated":"2026-11-09 15:22:44.000000000","message":"nit: \"reboot_time\" (and maybe the rest of keys) could be a constant too","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e9effc4e93399be0a3028eea8a17bc2608ef31bd","unresolved":false,"context_lines":[{"line_number":1543,"context_line":"        node \u003d task.node"},{"line_number":1544,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1545,"context_line":"        fw_upd[VERIFY] \u003d {"},{"line_number":1546,"context_line":"            \u0027reboot_time\u0027: str(timeutils.utcnow().isoformat()),"},{"line_number":1547,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1548,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1549,"context_line":"            \u0027waiting\u0027: None,"}],"source_content_type":"text/x-python","patch_set":17,"id":"dcd460e0_35ad461c","line":1546,"in_reply_to":"54a4a36a_966faf19","updated":"2026-11-11 07:14:55.000000000","message":"https://review.opendev.org/c/openstack/ironic/+/1014850/2/ironic/drivers/modules/redfish/firmware.py#52 (L52–62)","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":false,"context_lines":[{"line_number":1543,"context_line":"        node \u003d task.node"},{"line_number":1544,"context_line":"        fw_upd \u003d settings[0]"},{"line_number":1545,"context_line":"        fw_upd[VERIFY] \u003d {"},{"line_number":1546,"context_line":"            \u0027reboot_time\u0027: str(timeutils.utcnow().isoformat()),"},{"line_number":1547,"context_line":"            \u0027before\u0027: self._observe_boot(node),"},{"line_number":1548,"context_line":"            \u0027new_boot\u0027: False,"},{"line_number":1549,"context_line":"            \u0027waiting\u0027: None,"}],"source_content_type":"text/x-python","patch_set":17,"id":"54a4a36a_966faf19","line":1546,"in_reply_to":"ad7267e2_cebd4c5c","updated":"2026-11-10 13:36:49.000000000","message":"Done in https://review.opendev.org/c/openstack/ironic/+/1014850/1/ironic/drivers/modules/redfish/firmware.py","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1605,"context_line":"            log(\u0027Firmware update of %(component)s on node %(node)s is \u0027"},{"line_number":1606,"context_line":"                \u0027not verified yet: %(reason)s.\u0027,"},{"line_number":1607,"context_line":"                {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid,"},{"line_number":1608,"context_line":"                 \u0027reason\u0027: verify[\u0027waiting\u0027]})"},{"line_number":1609,"context_line":"            self._save_updates(node, settings)"},{"line_number":1610,"context_line":"            return"},{"line_number":1611,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"b168d341_214062aa","line":1608,"updated":"2026-11-09 15:22:44.000000000","message":"nit: \"waiting\" defaults to None, it won\u0027t look good in the log message","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e9effc4e93399be0a3028eea8a17bc2608ef31bd","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"            log(\u0027Firmware update of %(component)s on node %(node)s is \u0027"},{"line_number":1606,"context_line":"                \u0027not verified yet: %(reason)s.\u0027,"},{"line_number":1607,"context_line":"                {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid,"},{"line_number":1608,"context_line":"                 \u0027reason\u0027: verify[\u0027waiting\u0027]})"},{"line_number":1609,"context_line":"            self._save_updates(node, settings)"},{"line_number":1610,"context_line":"            return"},{"line_number":1611,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"0f9a6aa3_810ca0c0","line":1608,"in_reply_to":"67a0c8b3_f153b623","updated":"2026-11-11 07:14:55.000000000","message":"https://review.opendev.org/c/openstack/ironic/+/1014850/2/ironic/drivers/modules/redfish/firmware.py#1613 (L1613–1621)","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":false,"context_lines":[{"line_number":1605,"context_line":"            log(\u0027Firmware update of %(component)s on node %(node)s is \u0027"},{"line_number":1606,"context_line":"                \u0027not verified yet: %(reason)s.\u0027,"},{"line_number":1607,"context_line":"                {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid,"},{"line_number":1608,"context_line":"                 \u0027reason\u0027: verify[\u0027waiting\u0027]})"},{"line_number":1609,"context_line":"            self._save_updates(node, settings)"},{"line_number":1610,"context_line":"            return"},{"line_number":1611,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"67a0c8b3_f153b623","line":1608,"in_reply_to":"b168d341_214062aa","updated":"2026-11-10 13:36:49.000000000","message":"Ditto.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1618,"context_line":"    def _since_reboot(self, verify):"},{"line_number":1619,"context_line":"        \"\"\"Seconds since the reboot applying the update.\"\"\""},{"line_number":1620,"context_line":"        return (timeutils.utcnow(True) - timeutils.parse_isotime("},{"line_number":1621,"context_line":"            verify[\u0027reboot_time\u0027])).total_seconds()"},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"    def _read_task(self, node, fw_upd):"},{"line_number":1624,"context_line":"        \"\"\"Read the Redfish task of a firmware update."}],"source_content_type":"text/x-python","patch_set":17,"id":"14805919_14e8183a","line":1621,"updated":"2026-11-09 15:22:44.000000000","message":"if you only care about seconds of difference, maybe store the unix timestamp instead of a string?","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"da19b9760d9e8a839ed226bf6f09c89b0ab564ed","unresolved":true,"context_lines":[{"line_number":1618,"context_line":"    def _since_reboot(self, verify):"},{"line_number":1619,"context_line":"        \"\"\"Seconds since the reboot applying the update.\"\"\""},{"line_number":1620,"context_line":"        return (timeutils.utcnow(True) - timeutils.parse_isotime("},{"line_number":1621,"context_line":"            verify[\u0027reboot_time\u0027])).total_seconds()"},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"    def _read_task(self, node, fw_upd):"},{"line_number":1624,"context_line":"        \"\"\"Read the Redfish task of a firmware update."}],"source_content_type":"text/x-python","patch_set":17,"id":"1e73bad5_9ce954f2","line":1621,"in_reply_to":"14805919_14e8183a","updated":"2026-11-10 06:02:56.000000000","message":"Good suggestion. I thought about this and ultimately decided to keep the iso format for two reasons: 1) it is already used in DII 2) when Operators start looking at DII fields, it is often because something has gone wrong. It\u0027s likely helpful to give them human-readable records to remove the need for UNIX\u003ehuman_readable conversion. Is this reasonable, WDYT?","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"53a4cb722f6a1b13327a998a8427b3f0865e28e1","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"    def _since_reboot(self, verify):"},{"line_number":1619,"context_line":"        \"\"\"Seconds since the reboot applying the update.\"\"\""},{"line_number":1620,"context_line":"        return (timeutils.utcnow(True) - timeutils.parse_isotime("},{"line_number":1621,"context_line":"            verify[\u0027reboot_time\u0027])).total_seconds()"},{"line_number":1622,"context_line":""},{"line_number":1623,"context_line":"    def _read_task(self, node, fw_upd):"},{"line_number":1624,"context_line":"        \"\"\"Read the Redfish task of a firmware update."}],"source_content_type":"text/x-python","patch_set":17,"id":"bd2beb35_e03c1018","line":1621,"in_reply_to":"1e73bad5_9ce954f2","updated":"2026-11-10 07:54:47.000000000","message":"Yeah, debugability is a good reason.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1644,"context_line":"            # so get it"},{"line_number":1645,"context_line":"            return task_monitor.get_task()"},{"line_number":1646,"context_line":"        except sushy.exceptions.ResourceNotFoundError as e:"},{"line_number":1647,"context_line":"            raise exception.RedfishError(error\u003de)"},{"line_number":1648,"context_line":"        except Exception as e:"},{"line_number":1649,"context_line":"            LOG.warning(\u0027Unable to get task for node %(node)s: %(error)s. \u0027"},{"line_number":1650,"context_line":"                        \u0027Will retry on next poll.\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"393910e9_1c2d71d4","line":1647,"updated":"2026-11-09 15:22:44.000000000","message":"Why not keep a ResourceNotFoundError? Re-raising a more generic RedfishError looks like a footgun: we may start raising it for another reason, but the caller will still assume \"not found\"","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":true,"context_lines":[{"line_number":1644,"context_line":"            # so get it"},{"line_number":1645,"context_line":"            return task_monitor.get_task()"},{"line_number":1646,"context_line":"        except sushy.exceptions.ResourceNotFoundError as e:"},{"line_number":1647,"context_line":"            raise exception.RedfishError(error\u003de)"},{"line_number":1648,"context_line":"        except Exception as e:"},{"line_number":1649,"context_line":"            LOG.warning(\u0027Unable to get task for node %(node)s: %(error)s. \u0027"},{"line_number":1650,"context_line":"                        \u0027Will retry on next poll.\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fd4c2322_36b44239","line":1647,"in_reply_to":"393910e9_1c2d71d4","updated":"2026-11-10 13:36:49.000000000","message":"I ran it by Claude and here\u0027s what it proposed:\n\nClaude: I went a step further than keeping sushy\u0027s exception: a task that\u0027s gone usually 404s already when the TaskMonitor is built (sushy GETs it in __init__), and redfish_utils.get_task_monitor() turns that into a plain RedfishError, the same footgun one level down. So the follow-up adds RedfishResourceNotFound, a RedfishError subclass, raised there and by _read_task(). Existing callers that catch RedfishError (RAID, management) are unaffected. Happy to do it differently if you prefer.\n\nhttps://review.opendev.org/c/openstack/ironic/+/1014850/1/ironic/common/exception.py\n\nJacob: It may be overkill but I am curious WDYT? I can either keep this or just do a plain raise on ResourceNotFoundError.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1670,"context_line":"            system \u003d redfish_utils.get_system(node)"},{"line_number":1671,"context_line":"        except (exception.RedfishError, sushy.exceptions.SushyError) as e:"},{"line_number":1672,"context_line":"            LOG.warning(\u0027Unable to read the boot state of node %(node)s: \u0027"},{"line_number":1673,"context_line":"                        \u0027%(error)s. Will check again on the next poll.\u0027,"},{"line_number":1674,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":1675,"context_line":"            system \u003d None"},{"line_number":1676,"context_line":"        if system is not None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"2f0202b9_c760b0b1","line":1673,"updated":"2026-11-09 15:22:44.000000000","message":"\"Will check again on the next poll\" doesn\u0027t seem to be true: you continue to `read_task`","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"            system \u003d redfish_utils.get_system(node)"},{"line_number":1671,"context_line":"        except (exception.RedfishError, sushy.exceptions.SushyError) as e:"},{"line_number":1672,"context_line":"            LOG.warning(\u0027Unable to read the boot state of node %(node)s: \u0027"},{"line_number":1673,"context_line":"                        \u0027%(error)s. Will check again on the next poll.\u0027,"},{"line_number":1674,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":1675,"context_line":"            system \u003d None"},{"line_number":1676,"context_line":"        if system is not None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7453db76_7b9ff61c","line":1673,"in_reply_to":"2f0202b9_c760b0b1","updated":"2026-11-10 13:36:49.000000000","message":"Fixed in https://review.opendev.org/c/openstack/ironic/+/1014850/1/ironic/drivers/modules/redfish/firmware.py (L1687)","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1680,"context_line":"            sushy_task \u003d self._read_task(node, fw_upd)"},{"line_number":1681,"context_line":"        except exception.RedfishError:"},{"line_number":1682,"context_line":"            LOG.info(\u0027The %(component)s firmware update task is gone from \u0027"},{"line_number":1683,"context_line":"                     \u0027node %(node)s after the reboot to apply it.\u0027,"},{"line_number":1684,"context_line":"                     {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1685,"context_line":"        else:"},{"line_number":1686,"context_line":"            if sushy_task is None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"f905e31f_c5830b92","line":1683,"updated":"2026-11-09 15:22:44.000000000","message":"Let\u0027s also log what we\u0027re going to do about it.\n\nAlso it should be a DEBUG or a WARNING depending on severity (INFO is for operator-visible units of work)","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e9effc4e93399be0a3028eea8a17bc2608ef31bd","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"            sushy_task \u003d self._read_task(node, fw_upd)"},{"line_number":1681,"context_line":"        except exception.RedfishError:"},{"line_number":1682,"context_line":"            LOG.info(\u0027The %(component)s firmware update task is gone from \u0027"},{"line_number":1683,"context_line":"                     \u0027node %(node)s after the reboot to apply it.\u0027,"},{"line_number":1684,"context_line":"                     {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1685,"context_line":"        else:"},{"line_number":1686,"context_line":"            if sushy_task is None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"e079ff05_7d7bfbd0","line":1683,"in_reply_to":"78d1a58d_361d1955","updated":"2026-11-11 07:14:55.000000000","message":"https://review.opendev.org/c/openstack/ironic/+/1014850/2/ironic/drivers/modules/redfish/firmware.py#1701","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"            sushy_task \u003d self._read_task(node, fw_upd)"},{"line_number":1681,"context_line":"        except exception.RedfishError:"},{"line_number":1682,"context_line":"            LOG.info(\u0027The %(component)s firmware update task is gone from \u0027"},{"line_number":1683,"context_line":"                     \u0027node %(node)s after the reboot to apply it.\u0027,"},{"line_number":1684,"context_line":"                     {\u0027component\u0027: fw_upd[\u0027component\u0027], \u0027node\u0027: node.uuid})"},{"line_number":1685,"context_line":"        else:"},{"line_number":1686,"context_line":"            if sushy_task is None:"}],"source_content_type":"text/x-python","patch_set":17,"id":"78d1a58d_361d1955","line":1683,"in_reply_to":"f905e31f_c5830b92","updated":"2026-11-10 13:36:49.000000000","message":"Done","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1753,"context_line":"                                  \u0027%s\u0027) % e"},{"line_number":1754,"context_line":""},{"line_number":1755,"context_line":"        if status \u003d\u003d redfish_utils.BootProgressStatus.PASSED:"},{"line_number":1756,"context_line":"            if verify[\u0027new_boot\u0027]:"},{"line_number":1757,"context_line":"                LOG.info(\u0027Node %(node)s reached BootProgress %(state)s \u0027"},{"line_number":1758,"context_line":"                         \u0027after the reboot to apply firmware.\u0027,"},{"line_number":1759,"context_line":"                         {\u0027node\u0027: node.uuid, \u0027state\u0027: _name(last_state)})"}],"source_content_type":"text/x-python","patch_set":17,"id":"48c3fa0f_29dd78a1","line":1756,"updated":"2026-11-09 15:22:44.000000000","message":"I wonder why you don\u0027t call `_detect_reset` here since this seems to be the only place where you use `new_boot` flag.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":true,"context_lines":[{"line_number":1753,"context_line":"                                  \u0027%s\u0027) % e"},{"line_number":1754,"context_line":""},{"line_number":1755,"context_line":"        if status \u003d\u003d redfish_utils.BootProgressStatus.PASSED:"},{"line_number":1756,"context_line":"            if verify[\u0027new_boot\u0027]:"},{"line_number":1757,"context_line":"                LOG.info(\u0027Node %(node)s reached BootProgress %(state)s \u0027"},{"line_number":1758,"context_line":"                         \u0027after the reboot to apply firmware.\u0027,"},{"line_number":1759,"context_line":"                         {\u0027node\u0027: node.uuid, \u0027state\u0027: _name(last_state)})"}],"source_content_type":"text/x-python","patch_set":17,"id":"0b3e175c_8c7d030e","line":1756,"in_reply_to":"48c3fa0f_29dd78a1","updated":"2026-11-10 13:36:49.000000000","message":"Claude: It has to run on every poll, including while the update task is still running. The reset only shows in BootProgress early in POST, and on the hardware I tested the task kept running long after that (reset seen at ~60s, task finished at ~720s). _check_boot() only runs once the task is done, and by then BootProgress already reads OSRunning, so the reset would never be seen and every update would wait out the full firmware_update_post_reboot_wait. I\u0027ve added a comment at the call explaining this: https://review.opendev.org/c/openstack/ironic/+/1014850/1/ironic/drivers/modules/redfish/firmware.py#1692\n\nJacob: Does this answer your concern?","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1769,"context_line":"            if (verify[\u0027before\u0027] or {}).get(\u0027state\u0027) is None:"},{"line_number":1770,"context_line":"                # Nothing says when POST, and any firmware flashed during"},{"line_number":1771,"context_line":"                # it, is over."},{"line_number":1772,"context_line":"                LOG.info(\u0027Node %(node)s reports no BootProgress, so its \u0027"},{"line_number":1773,"context_line":"                         \u0027boot after the reboot to apply firmware was not \u0027"},{"line_number":1774,"context_line":"                         \u0027confirmed.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":1775,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":17,"id":"a2cc426a_ce8f0c6b","line":1772,"updated":"2026-11-09 15:22:44.000000000","message":"nit: warning?","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":false,"context_lines":[{"line_number":1769,"context_line":"            if (verify[\u0027before\u0027] or {}).get(\u0027state\u0027) is None:"},{"line_number":1770,"context_line":"                # Nothing says when POST, and any firmware flashed during"},{"line_number":1771,"context_line":"                # it, is over."},{"line_number":1772,"context_line":"                LOG.info(\u0027Node %(node)s reports no BootProgress, so its \u0027"},{"line_number":1773,"context_line":"                         \u0027boot after the reboot to apply firmware was not \u0027"},{"line_number":1774,"context_line":"                         \u0027confirmed.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":1775,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":17,"id":"b67179a1_5cdaa91c","line":1772,"in_reply_to":"a2cc426a_ce8f0c6b","updated":"2026-11-10 13:36:49.000000000","message":"Done","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"e9effc4e93399be0a3028eea8a17bc2608ef31bd","unresolved":false,"context_lines":[{"line_number":1769,"context_line":"            if (verify[\u0027before\u0027] or {}).get(\u0027state\u0027) is None:"},{"line_number":1770,"context_line":"                # Nothing says when POST, and any firmware flashed during"},{"line_number":1771,"context_line":"                # it, is over."},{"line_number":1772,"context_line":"                LOG.info(\u0027Node %(node)s reports no BootProgress, so its \u0027"},{"line_number":1773,"context_line":"                         \u0027boot after the reboot to apply firmware was not \u0027"},{"line_number":1774,"context_line":"                         \u0027confirmed.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":1775,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":17,"id":"6a8c54a5_09114edf","line":1772,"in_reply_to":"b67179a1_5cdaa91c","updated":"2026-11-11 07:14:55.000000000","message":"https://review.opendev.org/c/openstack/ironic/+/1014850/2/ironic/drivers/modules/redfish/firmware.py#1790","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79345c1a0a137ca5f7abf4699762bc7ce5b8f612","unresolved":true,"context_lines":[{"line_number":1933,"context_line":"        verify \u003d current_update.get(VERIFY)"},{"line_number":1934,"context_line":"        if verify and not verify[\u0027passed\u0027]:"},{"line_number":1935,"context_line":"            self._poll_verify(task, update_service, settings, current_update)"},{"line_number":1936,"context_line":"            return"},{"line_number":1937,"context_line":""},{"line_number":1938,"context_line":"        wait_start_time \u003d current_update.get(\u0027wait_start_time\u0027)"},{"line_number":1939,"context_line":"        if wait_start_time:"}],"source_content_type":"text/x-python","patch_set":17,"id":"6df3f7a7_e34bf860","line":1936,"updated":"2026-11-09 15:22:44.000000000","message":"nit: check \"passed\" again or make `_poll_verify` return a boolean to avoid unnecessary wait.","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"7efc56adbb5d1d8330e6c12d15a7134bb1f154fb","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"        verify \u003d current_update.get(VERIFY)"},{"line_number":1934,"context_line":"        if verify and not verify[\u0027passed\u0027]:"},{"line_number":1935,"context_line":"            self._poll_verify(task, update_service, settings, current_update)"},{"line_number":1936,"context_line":"            return"},{"line_number":1937,"context_line":""},{"line_number":1938,"context_line":"        wait_start_time \u003d current_update.get(\u0027wait_start_time\u0027)"},{"line_number":1939,"context_line":"        if wait_start_time:"}],"source_content_type":"text/x-python","patch_set":17,"id":"02a062a9_7c39d845","line":1936,"in_reply_to":"6df3f7a7_e34bf860","updated":"2026-11-10 13:36:49.000000000","message":"Agreed, applied the second recommendation in https://review.opendev.org/c/openstack/ironic/+/1014850/2/ironic/drivers/modules/redfish/firmware.py#1953","commit_id":"199ad17b7b9861924c85ef1d36182a71f2b5b993"}]}
